Bug#739889: RFS: twython/3.1.2-1 [ITP] -- Pure Python wrapper for the Twitter API
On Thu, Aug 14, 2014 at 7:28 AM, Eriberto wrote: > Hi Josué, > > I have a new, little and last correction. The file README.rst is being > installed in python-twython binary only. There are two ways to fix it: > > 1. Rename d/docs to python-twython.docs and copy python-twython.docs > as python3-twython.docs or; > > 2. Remove d/docs and add a 'dh_installdocs -a README.rst' in d/rules > (inside an override_dh_installdocs target). > > I think that the first option is better. > > Thanks for your work. Have a nice day! > > Cheers, > > Eriberto > > 2014-08-14 2:42 GMT-03:00 Josué Ortega : > > > > > > > > > > > > On Wed, Aug 13, 2014 at 7:06 PM, Eriberto > wrote: > >> > >> Hi, Josué, > >> > >> Sorry for my delay. > >> > >> From my email: > >> > >> -- > >> 1. Remove requirements.txt from d/docs. This information is specific > >> to packager, not to final user. > >> -- > >> > >> You didn't remove. See d/docs. > >> > >> You din't installed the changelog correctly. Please, use > >> dh_installchangelogs in d/rules. > >> > >> I understood that you would use the version from > >> https://pypi.python.org/pypi/twython. However, your d/control and > >> d/copyright point to GitHub. > >> > >> Cheers, > >> > >> Eriberto > >> > >> > >> > >> > >> 2014-08-11 0:03 GMT-03:00 Josué Ortega : > >> > Hi Eriberto, > >> > The new revision is on mentors: > >> > > >> > dget -x > >> > > http://mentors.debian.net/debian/pool/main/t/twython/twython_3.1.2-1.dsc > >> > > >> > Thanks! > >> > > >> > Cheers > >> > > >> > > >> > > >> > On Sun, Aug 10, 2014 at 2:45 PM, Eriberto > >> > wrote: > >> >> > >> >> > > >> >> > I suggest working with the pypi releases which don't include the > >> >> > minified js > >> >> > files. > >> >> > >> >> Hi Josué. Ok to me. Send me your package. > >> >> > >> >> Cheers, > >> >> > >> >> Eriberto > >> > > >> > > >> > > >> > > >> > -- > >> > Josue Ortega > >> > Happy Hacking > >> > http://josueortega.org > >> > PGP key 4096R/AB4AFD3F 2012-08-20 > >> > Fingerprint = 7733 B328 D279 5F5B E232 5ADD 0150 9D5C AB4A FD3F > >> > > > > > > > Hi Eriberto, > > Thanks again for reviewing the package. I've changed the debian rules as > you > > asked and I've changed > > the URL. > > > > The new version is on mentors > > > > dget -x > > http://mentors.debian.net/debian/pool/main/t/twython/twython_3.1.2-1.dsc > > > > Cheers > > > > > > -- > > Josue Ortega > > Happy Hacking > > http://josueortega.org > > PGP key 4096R/AB4AFD3F 2012-08-20 > > Fingerprint = 7733 B328 D279 5F5B E232 5ADD 0150 9D5C AB4A FD3F > > > Hi Eriberto, I've made the change and I've uploaded again to mentors dget -x http://mentors.debian.net/debian/pool/main/t/twython/twython_3.1.2-1.dsc Thanks!! Cheers -- Josue Ortega Happy Hacking http://josueortega.org PGP key 4096R/AB4AFD3F 2012-08-20 Fingerprint = 7733 B328 D279 5F5B E232 5ADD 0150 9D5C AB4A FD3F
Bug#739889: RFS: twython/3.1.2-1 [ITP] -- Pure Python wrapper for the Twitter API
On Wed, Aug 13, 2014 at 7:06 PM, Eriberto wrote: > Hi, Josué, > > Sorry for my delay. > > From my email: > > -- > 1. Remove requirements.txt from d/docs. This information is specific > to packager, not to final user. > -- > > You didn't remove. See d/docs. > > You din't installed the changelog correctly. Please, use > dh_installchangelogs in d/rules. > > I understood that you would use the version from > https://pypi.python.org/pypi/twython. However, your d/control and > d/copyright point to GitHub. > > Cheers, > > Eriberto > > > > > 2014-08-11 0:03 GMT-03:00 Josué Ortega : > > Hi Eriberto, > > The new revision is on mentors: > > > > dget -x > > http://mentors.debian.net/debian/pool/main/t/twython/twython_3.1.2-1.dsc > > > > Thanks! > > > > Cheers > > > > > > > > On Sun, Aug 10, 2014 at 2:45 PM, Eriberto > wrote: > >> > >> > > >> > I suggest working with the pypi releases which don't include the > >> > minified js > >> > files. > >> > >> Hi Josué. Ok to me. Send me your package. > >> > >> Cheers, > >> > >> Eriberto > > > > > > > > > > -- > > Josue Ortega > > Happy Hacking > > http://josueortega.org > > PGP key 4096R/AB4AFD3F 2012-08-20 > > Fingerprint = 7733 B328 D279 5F5B E232 5ADD 0150 9D5C AB4A FD3F > > > Hi Eriberto, Thanks again for reviewing the package. I've changed the debian rules as you asked and I've changed the URL. The new version is on mentors dget -x http://mentors.debian.net/debian/pool/main/t/twython/twython_3.1.2-1.dsc Cheers -- Josue Ortega Happy Hacking http://josueortega.org PGP key 4096R/AB4AFD3F 2012-08-20 Fingerprint = 7733 B328 D279 5F5B E232 5ADD 0150 9D5C AB4A FD3F
Bug#739889: RFS: twython/3.1.2-1 [ITP] -- Pure Python wrapper for the Twitter API
Hi Eriberto, The new revision is on mentors: dget -x http://mentors.debian.net/debian/pool/main/t/twython/twython_3.1.2-1.dsc Thanks! Cheers On Sun, Aug 10, 2014 at 2:45 PM, Eriberto wrote: > > > > I suggest working with the pypi releases which don't include the > minified js > > files. > > Hi Josué. Ok to me. Send me your package. > > Cheers, > > Eriberto > -- Josue Ortega Happy Hacking http://josueortega.org PGP key 4096R/AB4AFD3F 2012-08-20 Fingerprint = 7733 B328 D279 5F5B E232 5ADD 0150 9D5C AB4A FD3F
Bug#739889: RFS: twython/3.1.2-1 [ITP] -- Pure Python wrapper for the Twitter API
On Thu, Aug 7, 2014 at 5:58 AM, Eriberto wrote: > Sorry, but three last changes: > > 1. Remove requirements.txt from d/docs. This information is specific > to packager, not to final user. > > 2. In d/rules, remove the useless lines '# -*- makefile -*-' and '# > Uncomment this to turn on verbose mode.' > > 3. I studied the upstream repository and he doesn't declares a > version. You can see that after several changes in repository, after > your packaging, in 'setup.py' we can see 3.1.2 yet. So, use as version > the Git information: 0.0 to version, the date and Git commit (or other > similar format). An example: 0.0~git20140314.938cf1. In your case, > considering that you will update the upstream code: > 0.0~git20140805.54647c. To see more examples: $ dpkg -l | grep -i git. > > When you do it, I will upload your package. No more changes. > > Thanks! > > Eriberto > > 2014-08-07 3:58 GMT-03:00 Josué Ortega : > > > > > > > > On Tue, Aug 5, 2014 at 2:44 PM, Eriberto > wrote: > >> > >> Hi! > >> > >> No need rename. And is dh_installchangelogs, not dh_autoinstalldocs. > >> > >> Cheers, > >> > >> Eriberto > >> > >> > >> 2014-08-05 17:37 GMT-03:00 Josué Ortega : > >> > > >> > I have one question about dh_autoinstalldocs, should I rename the > >> > History.rst before > >> > pass it as parementer to dh_autoinstalldocs? > > > > > > > > Hi Eriberto, > > > > I have made the changes you asked for. > > The new version is on mentors [0][1]. Thanks. > > > > Cheers, > > > > [0]: > > http://mentors.debian.net/debian/pool/main/t/twython/twython_3.1.2-1.dsc > > [1]: http://mentors.debian.net/package/twython > > > > -- > > Josue Ortega > > Happy Hacking > > http://josueortega.org > > PGP key 4096R/AB4AFD3F 2012-08-20 > > Fingerprint = 7733 B328 D279 5F5B E232 5ADD 0150 9D5C AB4A FD3F > > > Hi Eriberto Thanks for your time, I've made the changes you requested, but I've found the following problems: I've packaged the latest upstream version taking the latest commit as you told me but I've noticed the tarball on PyPi[0] does not include the docs directory. This directory includes some minified Javascript scripts[1][2] and this directory is present in the tarball downloaded from Github. I thought that repacking the tarball would be the solution, since the repack script uses uscan and the watch file is searching in PyPi and the Github URL doesn't manage any version just the branch name [3], as far as I understand repacking using the repack script will not fix the problem. What approach do you think is the best? I suggest working with the pypi releases which don't include the minified js files. Cheers [0]: https://pypi.python.org/pypi/twython [1]: https://github.com/ryanmcgrath/twython/blob/master/docs/_themes/basicstrap/static/js/jquery.min.js [2]: https://github.com/ryanmcgrath/twython/blob/master/docs/_themes/basicstrap/static/js/bootstrap.min.js [3]: https://github.com/ryanmcgrath/twython/archive/master.tar.gz -- Josue Ortega Happy Hacking http://josueortega.org PGP key 4096R/AB4AFD3F 2012-08-20 Fingerprint = 7733 B328 D279 5F5B E232 5ADD 0150 9D5C AB4A FD3F
Bug#739889: RFS: twython/3.1.2-1 [ITP] -- Pure Python wrapper for the Twitter API
Hi Eriberto, On Tue, Aug 5, 2014 at 5:18 AM, Eriberto wrote: > Hi Josue, > > I will be glad sponsoring your package. Please, put a revised version > in mentors. When you can do it? > > Thanks! I estimate the changes will be ready this weekend but I'll try to get them done ASAP > Cheers, > > Eriberto > I have one question about dh_autoinstalldocs, should I rename the History.rst before pass it as parementer to dh_autoinstalldocs? Cheers -- Josue Ortega Happy Hacking http://josueortega.org PGP key 4096R/AB4AFD3F 2012-08-20 Fingerprint = 7733 B328 D279 5F5B E232 5ADD 0150 9D5C AB4A FD3F
Bug#753982: RFS: mp3diags/1.2.01-1 - find issues in MP3 files and help to solve them
On Tue, Jul 8, 2014 at 1:22 PM, Sebastian Ramacher wrote: > Hi Josué > > On 2014-07-07 22:00:49, Josué Ortega wrote: > > I have fixed the patch and I have re-uploaded it to mentors[0] > > Good. The new watch file does not seem to work as expected: > > % uscan --report-status > Processing watchfile line for package mp3diags... > Newest version on remote site is 1.2.01.., local version is 1.2.01 > mp3diags: Newer version (1.2.01..) available on remote site: > http://qa.debian.org/watch/sf.php/mp3diags/MP3Diags-1.2.01.tar.gz > (local version is 1.2.01) > > It should report 1.2.01. > > Cheers > -- > Sebastian Ramacher > Hi Sebastian, Thanks for the follow up, I have fixed the watch file and now the package is being versioned with git at collab-maint[0] The new version is on Mentors: dget -x http://mentors.debian.net/debian/pool/main/m/mp3diags/mp3diags_1.2.01-1.dsc [0]: http://anonscm.debian.org/gitweb/?p=collab-maint/mp3diags.git;a=summary Cheers -- Josue Ortega Happy Hacking http://josueortega.org PGP key 4096R/AB4AFD3F 2012-08-20 Fingerprint = 7733 B328 D279 5F5B E232 5ADD 0150 9D5C AB4A FD3F
Bug#753982: RFS: mp3diags/1.2.01-1 - find issues in MP3 files and help to solve them
On Mon, Jul 7, 2014 at 3:40 AM, Sebastian Ramacher wrote: > Control: owner -1 ! > > On 2014-07-06 13:04:08, Josue Ortega wrote: > > dget -x > http://mentors.debian.net/debian/pool/main/m/mp3diags/mp3diags_1.2.01-1.dsc > > Unfortunately, the package fails to unpack: > > dpkg-source: info: extracting mp3diags in mp3diags-1.2.01 > dpkg-source: info: unpacking mp3diags_1.2.01.orig.tar.gz > dpkg-source: info: unpacking mp3diags_1.2.01-1.debian.tar.xz > dpkg-source: info: applying 01-disable_updates.patch > dpkg-source: error: expected ^--- in line 5 of diff > `mp3diags-1.2.01/debian/patches/03-pass_flags_to_qmake.patch' > dpkg-source: info: applying 03-pass_flags_to_qmake.patch > dpkg-source: info: fuzz is not allowed when applying patches > dpkg-source: info: if patch '03-pass_flags_to_qmake.patch' is correctly > applied by quilt, use 'quilt refresh' to update it > FAILED [dpkg-source died] > > See https://lists.debian.org/debian-dpkg/2014/06/msg00052.html for > possible failure reasons. Please fix the patch. > > Cheers > -- > Sebastian Ramacher > Hi Sebastian, Thanks for reviewing mp3diags. I have fixed the patch and I have re-uploaded it to mentors[0] Cheers. [0]: http://mentors.debian.net/debian/pool/main/m/mp3diags/mp3diags_1.2.01-1.dsc -- Josue Ortega Happy Hacking http://josueortega.org PGP key 4096R/AB4AFD3F 2012-08-20 Fingerprint = 7733 B328 D279 5F5B E232 5ADD 0150 9D5C AB4A FD3F
Bug#696973: RFS: mp3diags/1.0.12.079-1
On Tue, Mar 26, 2013 at 5:33 PM, Sebastian Ramacher wrote: > Hi Josué, > > On 2013-03-25 10:07:53, Josué Ortega wrote: >> I just uploaded the package to mentors with the fix for the previous issues >> [0]. >> About the Vcs-*, I removed the fielf from debian/control because I >> decided not to use that system. >> I'll be wating for your feedback, thanks in advance. > > Good. There are only two points remaining: current Standards-Version is > 3.9.4. Please check if the package still complies with 3.9.4 and update > Standards-Version in d/control accordingly. [1] has an overview of the > changes between 3.9.3 and 3.9.4. > > Since you're not using the repo, please remove debian/gbp.conf. It has > no use. > > Cheers > > [1] http://www.debian.org/doc/debian-policy/upgrading-checklist > -- > Sebastian Ramacher Hi Sebastian, Thanks again, I've done the changes and uploaded the package again to mentors[0] Cheers [0] http://mentors.debian.net/package/mp3diags -- Josue Ortega http://josueortega.org PGP key 4096R/AB4AFD3F 2012-08-20 Fingerprint = 7733 B328 D279 5F5B E232 5ADD 0150 9D5C AB4A FD3F -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/cacg6gslyssd+agxgtlj-nrhbyppa28hejpqhbmso736c2...@mail.gmail.com
Bug#696973: RFS: mp3diags/1.0.12.079-1
On Sat, Feb 23, 2013 at 8:15 PM, Sebastian Ramacher wrote: > Control: owner -1 ! > > Hi Josué, > > I had a look at your mp3diags package and found the following issue. Once the > issues are fixed I'm happy to upload the package for you. > > On 2012-12-29 21:44:47, Josué Ortega wrote: >> dget -x >> http://mentors.debian.net/debian/pool/main/m/mp3diags/mp3diags_1.0.12.079-1.dsc > > * Please prepare an upload to experimental so that we can keep unstable clean >until the release of wheezy. > > * -g is not passed to the compiler and thus DEB_BUILD_OPTIONS=nostrip is not >supported. Please check Debian Policy §4.9.1 and §10.1. > > * The package is built without hardening flags. In particular lintian emits: > > W: mp3diags: hardening-no-relro usr/bin/mp3diags > W: mp3diags: hardening-no-fortify-functions usr/bin/mp3diags > >Please build the package with hardening flags enabled and check the build > log >with blhc. > > The last two issues can be solved by using dpkg-buildflags directly or by > including /usr/share/dpkg/buildflags.mk in debian/rules. dh_auto_* also set > them in compat level 9. > > * The package fails to build twice in a row. Please have a look at the >attached file for the log of the second build. The files dpkg-source is >complaining about come from running cmake by dh_auto_configure. However, >elsewhere qmake is used to build mp3diags. Please decide on one of these >two build systems. > >If you choose qmake, note that debhelper supports qmake since 7.4.12. So >removing the overrides for dh_auto_clean, dh_auto_build and passing -Sqmake >to dh should be enough. > > * lintian also emits: > > W: mp3diags source: out-of-date-standards-version 3.9.3 (current is 3.9.4) > I: mp3diags: spelling-error-in-binary usr/bin/mp3diags teH the > > Please fix these issues and ping me when you're done. > > One other thing: Vcs-* lists a collab-maint repo which has not been updated > since the last upload by Alessio. It'd be great if you could push your work > there. If you just don't have access to this repository, please say so. > > Cheers > -- > Sebastian Ramacher Hi Sebastian, First of all thanks for all your advices, they were very useful :). I just uploaded the package to mentors with the fix for the previous issues [0]. About the Vcs-*, I removed the fielf from debian/control because I decided not to use that system. I'll be wating for your feedback, thanks in advance. Cheers [0]: http://mentors.debian.net/package/mp3diags -- Josue Ortega http://josueortega.org PGP key 4096R/AB4AFD3F 2012-08-20 Fingerprint = 7733 B328 D279 5F5B E232 5ADD 0150 9D5C AB4A FD3F -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CACg6GsJPSmjCTXiMaL8D-ZkN9kHSKm_E-tq3p3gZB-r=elc...@mail.gmail.com
Bug#696973: RFS: mp3diags/1.0.12.079-1
On Sat, Feb 23, 2013 at 8:15 PM, Sebastian Ramacher wrote: > Control: owner -1 ! > > Hi Josué, > > I had a look at your mp3diags package and found the following issue. Once the > issues are fixed I'm happy to upload the package for you. > > On 2012-12-29 21:44:47, Josué Ortega wrote: >> dget -x >> http://mentors.debian.net/debian/pool/main/m/mp3diags/mp3diags_1.0.12.079-1.dsc > > * Please prepare an upload to experimental so that we can keep unstable clean >until the release of wheezy. > > * -g is not passed to the compiler and thus DEB_BUILD_OPTIONS=nostrip is not >supported. Please check Debian Policy §4.9.1 and §10.1. > > * The package is built without hardening flags. In particular lintian emits: > > W: mp3diags: hardening-no-relro usr/bin/mp3diags > W: mp3diags: hardening-no-fortify-functions usr/bin/mp3diags > >Please build the package with hardening flags enabled and check the build > log >with blhc. > > The last two issues can be solved by using dpkg-buildflags directly or by > including /usr/share/dpkg/buildflags.mk in debian/rules. dh_auto_* also set > them in compat level 9. > > * The package fails to build twice in a row. Please have a look at the >attached file for the log of the second build. The files dpkg-source is >complaining about come from running cmake by dh_auto_configure. However, >elsewhere qmake is used to build mp3diags. Please decide on one of these >two build systems. > >If you choose qmake, note that debhelper supports qmake since 7.4.12. So >removing the overrides for dh_auto_clean, dh_auto_build and passing -Sqmake >to dh should be enough. > > * lintian also emits: > > W: mp3diags source: out-of-date-standards-version 3.9.3 (current is 3.9.4) > I: mp3diags: spelling-error-in-binary usr/bin/mp3diags teH the > > Please fix these issues and ping me when you're done. > > One other thing: Vcs-* lists a collab-maint repo which has not been updated > since the last upload by Alessio. It'd be great if you could push your work > there. If you just don't have access to this repository, please say so. > > Cheers > -- > Sebastian Ramacher Hi Sebastian, Thanks for reviewing the package and thanks for the advices, as soon as I fix the issues, I will let you know Cheers -- Josue Ortega http://josueortega.org PGP key 4096R/AB4AFD3F 2012-08-20 Fingerprint = 7733 B328 D279 5F5B E232 5ADD 0150 9D5C AB4A FD3F -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CACg6GsKM1DUsZxDirD4gDZ6Fp2+Q_m=o0wtrgenhbds6+wn...@mail.gmail.com
Bug#700829: RFS: python-gnuplot/1.8-3 [ITA] -- Python interface to the gnuplot plotting program
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "python-gnuplot", * Package name: python-gnuplot Version : 1.8-3 Upstream Author : Michael Haggerty * URL : http://gnuplot-py.sourceforge.net/ * License : LGPL Section : python It builds those binary packages: python-gnuplot - Python interface to the gnuplot plotting program To access further information about this package, please visit the following URL: http://mentors.debian.net/package/python-gnuplot Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/p/python-gnuplot/python-gnuplot_1.8-3.dsc More information about hello can be obtained from http://www.example.com. Changes since the last upload: * New Maintainer. (Closes: #699039) * Added debian/source/format file * Changed to dpkg-source 3.0 (quilt) format. * debian/copyright updated to format version 1.0 * debian/control: added homepage Regards, -- Josue Ortega http://josueortega.com PGP key 4096R/AB4AFD3F 2012-08-20 Fingerprint = 7733 B328 D279 5F5B E232 5ADD 0150 9D5C AB4A FD3F -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CACg6GsJCB-2uDaDAbS-WZZtJibZk1_yjq1rERNM=D6bCM1=e...@mail.gmail.com
Bug#696973: RFS: mp3diags/1.0.12.079-1
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "mp3diags" * Package name: mp3diags Version : 1.0.12.079-1 Upstream Author : Marian Ciobanu * URL : http://mp3diags.sourceforge.net * License : GPL-2 Section : sound It builds those binary packages: mp3diags - find issues in MP3 files and help to solve them mp3diags-doc - MP3 Diags documentation To access further information about this package, please visit the following URL:http://mentors.debian.net/package/mp3diags Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/m/mp3diags/mp3diags_1.0.12.079-1.dsc Changes since the last upload: mp3diags (1.0.12.079-1) * New upstream release: - fix Discogs issue with albums that have more than twenty tracks. Regards, -- Josue Ortega openfecks.wordpress.com PGP key 4096R/AB4AFD3F 2012-08-20 Fingerprintt = 7733 B328 D279 5F5B E232 5ADD 0150 9D5C AB4A FD3F
Re: mp3diags at mentors
On Fri, Oct 12, 2012 at 2:08 PM, Josué Ortega wrote: > > > On Fri, Oct 12, 2012 at 1:38 PM, Bart Martens wrote: > >> Hi Josue, >> >> I had a look at mp3diags at mentors uploaded there on 2012-10-12 06:43. >> I'm >> afraid that bug 689811 is not yet fully solved. >> >> For example, upstream wrote that "the icons are mainly taken from KDE 4' >> Oxygen >> icon set", and I don't see the copyright holder(s) mentioned in >> debian/copyright. >> >> Also, the text from upstream you quoted is helpful for clarification, as >> part >> of the fix for bug 689811. I suggest to add the exact text in >> debian/copyright >> including the From and Date headers. >> >> And since you're updating the package anyway : the white lines in >> debian/rules >> are still there. You may want to remove them before requesting an >> unblock to >> debian-release with a debdiff. >> >> Regards, >> >> Bart Martens >> > > > Hi Bart, > Thanks for the review , I'll try to fix it today > Regards, > -- > Josue Ortega > openfecks.wordpress.com > PGP key 4096R/AB4AFD3F 2012-08-20 > Fingerprintt = 7733 B328 D279 5F5B E232 5ADD 0150 9D5C AB4A FD3F > > > Hi Bart, I've fixed the debian/copyright and debian/rules as you told me , hoping that the files are right this time. Thanks :) Heres is the mentors adress for mp3diags: http://mentors.debian.net/package/mp3diags Regards -- Josue Ortega openfecks.wordpress.com PGP key 4096R/AB4AFD3F 2012-08-20 Fingerprintt = 7733 B328 D279 5F5B E232 5ADD 0150 9D5C AB4A FD3F
Re: mp3diags at mentors
On Fri, Oct 12, 2012 at 1:38 PM, Bart Martens wrote: > Hi Josue, > > I had a look at mp3diags at mentors uploaded there on 2012-10-12 06:43. > I'm > afraid that bug 689811 is not yet fully solved. > > For example, upstream wrote that "the icons are mainly taken from KDE 4' > Oxygen > icon set", and I don't see the copyright holder(s) mentioned in > debian/copyright. > > Also, the text from upstream you quoted is helpful for clarification, as > part > of the fix for bug 689811. I suggest to add the exact text in > debian/copyright > including the From and Date headers. > > And since you're updating the package anyway : the white lines in > debian/rules > are still there. You may want to remove them before requesting an unblock > to > debian-release with a debdiff. > > Regards, > > Bart Martens > Hi Bart, Thanks for the review , I'll try to fix it today Regards, -- Josue Ortega openfecks.wordpress.com PGP key 4096R/AB4AFD3F 2012-08-20 Fingerprintt = 7733 B328 D279 5F5B E232 5ADD 0150 9D5C AB4A FD3F
Re: mp3diags at mentors
On Sat, Oct 6, 2012 at 9:43 AM, Josué Ortega wrote: > > > On Sat, Oct 6, 2012 at 9:18 AM, Bart Martens wrote: > >> Hi Josue, >> >> I had a look at mp3diags at mentors uploaded there on 2012-10-06 06:36. >> I see >> that you want to adopt this package without changes (except for the three >> added >> newlines in debian/rules). So I had a look at the package to see what >> could be >> improved. I saw that debian/copyright is not correct and that the >> upstream >> license information is quite confusing. I submitted bug 689811 for that. >> It >> would be nice to have that bug fixed in wheezy. >> >> Regards, >> >> Bart Martens >> > > Hi Bart, > > Thanks for took a look , I'll be working on this bug and I'll noticing you > , about the changes in debian rules probably I left some white lines after > trying to add hardening flags but since the package is using cmake and > compat level 7 I decided to wait to the fix of cmake's bug > > Regards > -- > Josue Ortega > openfecks.wordpress.com > PGP key 4096R/AB4AFD3F 2012-08-20 > Fingerprint = 7733 B328 D279 5F5B E232 5ADD 0150 9D5C AB4A FD3F > > > Hi Bart, I just uploaded the version of mp3diags wich fixes the problem with the debian copyright I wrote an email to upstream asking for the licenses and this is the reply: "Hi Josue, Basically the "About" box tells where which license applies: - All the code is GPL V2, including the UI files. Since they are generated, I'm not sure I can list a license inside them. The rest of my supporting code (mainly build scripts and tools) is also GPL V2. - The icons are mainly taken from KDE 4' Oxygen icon set, which is LGPL V3 (which, unlike V2, was created as an addition to GPL V3, and needs the GPL V3 text to make sense, so that's why GPL V3 got included). Some icons are created by me. They are also LGPL V3, to keep things simple. - The program uses 3 libraries: Qt (which is LGPL V.2.1), Boost (with its own custom license), and zlib (with its own custom license). It is my understanding that I should mention these licenses, and that's why they are included, even if none of my files is under any of these licenses. It is also my understanding that the way I use the libraries and the icons is consistent with their licensing terms. The reason the licenses are included twice, once in the root directory and again in src/licenses: - users who download the package expect to find licenses in the root directory - the ones in src/licenses are shown in the "About" dialog; I think I couldn't convince the build to use the ones in the root, so I duplicated them For the second question: all icons are LGPL V3. The GPL V3 is included because the definition of LGPL V3 needs it. Please let me know if you have any more questions or if there is any issue with the licenses, or if you have suggestions. Thanks, Marian" Based on the previous information I've changed the debian copyright here is the link for the new version of mp3diags in mentors: https://mentors.debian.net/package/mp3diags Regards -- Josue Ortega openfecks.wordpress.com PGP key 4096R/AB4AFD3F 2012-08-20 Fingerprint = 7733 B328 D279 5F5B E232 5ADD 0150 9D5C AB4A FD3F
Re: mp3diags at mentors
On Sat, Oct 6, 2012 at 9:18 AM, Bart Martens wrote: > Hi Josue, > > I had a look at mp3diags at mentors uploaded there on 2012-10-06 06:36. I > see > that you want to adopt this package without changes (except for the three > added > newlines in debian/rules). So I had a look at the package to see what > could be > improved. I saw that debian/copyright is not correct and that the upstream > license information is quite confusing. I submitted bug 689811 for that. > It > would be nice to have that bug fixed in wheezy. > > Regards, > > Bart Martens > Hi Bart, Thanks for took a look , I'll be working on this bug and I'll noticing you , about the changes in debian rules probably I left some white lines after trying to add hardening flags but since the package is using cmake and compat level 7 I decided to wait to the fix of cmake's bug Regards -- Josue Ortega openfecks.wordpress.com PGP key 4096R/AB4AFD3F 2012-08-20 Fingerprint = 7733 B328 D279 5F5B E232 5ADD 0150 9D5C AB4A FD3F
