Re: blocked mentors queue?
Dies schrieb foss.freedom (foss.free...@gmail.com): > many thanks for the reply and guidance. Have sent an email to > supp...@mentors.debian.net I've seen one new package appear on https://mentors.debian.net/packages/index, however the one I've uploaded last night still seems to be stuck - did you receive any news whether the queue will be processed or if further manual intervention is needed?
Bug#827149: RFS: triggerhappy/0.4.0-1
Good morning, Dies schrieb Sean Whitton (spwhit...@spwhitton.name): > On Sun, Jun 12, 2016 at 11:59:34PM +0200, Stefan Tomanek wrote: > > Changes since the last upload: > > > >* update to version 0.4.0 (closes: bug#827079, bug#769184) > > Although this bug closing syntax is acceptable, it's marked as "not > preferred" Developer's Reference section 5.8.4. You might consider the > more usual syntax: > > Closes: #769184, #827079 > > and you should perhaps mention that 0.4.0 is a new *upstream* version. > > >* adapt to newer debian packaging standards > > Could you be more verbose here, please? What you wrote could mean a lot > of things! Thanks for your input, I adjusted the changelog accordingly and reuploaded the package.
Bug#827149: RFS: triggerhappy/0.4.0-1
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "triggerhappy" * Package name: triggerhappy Version : 0.4.0-1 Upstream Author : Stefan Tomanek <stefan.tomanek...@wertarbyte.de> * URL : https://github.com/wertarbyte/triggerhappy * License : GPLv3 Section : utils It builds those binary packages: triggerhappy - global hotkey daemon for Linux To access further information about this package, please visit the following URL: https://mentors.debian.net/package/triggerhappy Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/t/triggerhappy/triggerhappy_0.4.0-1.dsc More information about hello can be obtained from https://www.example.com. Changes since the last upload: * update to version 0.4.0 (closes: bug#827079, bug#769184) * adapt to newer debian packaging standards Regards, Stefan Tomanek
Re: RFS: tartarus
Dies schrieb Arno Töll (deb...@toell.net): * You bundle a Perl module in your source tarball. Please package this separately. Even if the perl module is only used by the scripts packaged? I created the module when several programs used the same functions and configuration data, so I am not sure whether a dedicated perl package is really that useful. * Your original source tarball did not match the package source directory you use to produce the package from. This resulted in a quilt/3.0 changes patch in patches/debian-changes-0.9.8-1. Please update your source tarball accordingly and re-upload. This is probably glitch in the git-buildpackage configuration, repackaging should fix that. * You install man pages through dh_installman, but they belong to the upstream part of your package. Please consider writing an install target upstream for them. * You don't have an install target at all in your upstream package, eventually you want to add that instead of relying to various debhelper. I'll think about adding that, thank you. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110529184923.gv13...@zirkel.wertarbyte.de
RFS: tartarus
Dear mentors, I am looking for a sponsor for my package tartarus. * Package name: tartarus Version : 0.9.8-1 Upstream Author : Stefan Tomanek stefan.tomanek+tarta...@wertarbyte.de * URL : http://wertarbyte.de/tartarus.shtml * License : GPLv3 or later Section : admin It builds these binary packages: tartarus - script based backup system The package appears to be lintian clean. The upload would fix these bugs: 604447 My motivation for maintaining this package is: I've written tartarus as a simple backup solution for my dedicated server. It uses parts of the unix toolshed that should be available even in the most basic rescue system, making recovery easy in case things go wrong. By using Bash and Perl, the program is easily extendable and offers various hooks that can be used to modify its behaviour, while including features like LVM snapshots, on-the-fly-uploading and compression/encryption out of the box. I created the package to simplify the installation on now roughly 1400 systems using this program (http://wertarbyte.de/stats/tartarus-use.png) on a regular basis and I would really like to this this included into Debian. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/t/tartarus - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/t/tartarus/tartarus_0.9.8-1.dsc I would be glad if someone uploaded this package for me. Kind regards Stefan Tomanek -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110525211825.gq13...@zirkel.wertarbyte.de
RFS: tartarus
Dear mentors, I am looking for a sponsor for my package tartarus. * Package name: tartarus Version : 0.9.8-1 Upstream Author : Stefan Tomanek stefan.tomanek+tarta...@wertarbyte.de * URL : http://wertarbyte.de/tartarus.shtml * License : GPLv3 or later Section : admin It builds these binary packages: tartarus - script based backup system The package appears to be lintian clean. The upload would fix these bugs: 604447 My motivation for maintaining this package is: I've written tartarus as a simple backup solution for my dedicated server. It uses parts of the unix toolshed that should be available even in the most basic rescue system, making recovery easy in case things go wrong. By using Bash and Perl, the program is easily extendable and offers various hooks that can be used to modify its behaviour, while including features like LVM snapshots, on-the-fly-uploading and compression/encryption out of the box. I created the package to simplify the installation on now roughly 1400 systems using this program (http://wertarbyte.de/stats/tartarus-use.png) on a regular basis and I would really like to this this included into Debian. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/t/tartarus - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/t/tartarus/tartarus_0.9.8-1.dsc I would be glad if someone uploaded this package for me. Kind regards Stefan Tomanek -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110525211028.gp13...@zirkel.wertarbyte.de
Re: ITS: triggerhappy
Dies schrieb Niels Thykier (ni...@thykier.net): debian/copyright says it its GPL-3 or any later, but the license header in the source files merely say: You have permission to copy, modify, and redistribute under the terms of the GPL. For full license terms, see COPYING. Looking at COPYING, I see a GPL-3 license. Please see the How to Apply These Terms to Your New Programs in COPYING on an example of how to correct this. Legal stuff is unfortunately very pedantic and d/copyright must reflect what is in the upstream sources. OK, being upstream myself, I clarified the statement in the source files to refer to GPLv3 specificly. Secondly, the package has two debian-changes patches in debian/patches. These changes were an accident produced by git-buildpackage; on my build system, the upstream branch was not correctly checked out at HEAD, so the changes were detected relative to the debian branch. There is a newer Standards-Version 3.9.2, please update accordingly. OK, I just ran an update to make sure my local tools are recent; since my build/sign system is running stable, I might encounter a few warning messages there. The changelog file contains a lot of entries and some of them suggests you have had an unofficial repository from where your users could download this package. If that is the case, please move the entry that closes #603842 to the newest changelog entry[1]. OK, I just updated the changelog to reflect this. Thank you very much for your input, I hope you'll revisit my package as soon as I uploaded the new version. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110510205146.gz23...@zirkel.wertarbyte.de
Re: ITS: triggerhappy
Dies schrieb Niels Thykier (ni...@thykier.net): To say GPLv3 or GPLv3 or any later? (I did not check the tarball for the reasons listed below) or any later version, so every licence statement should be the same. I tried to re-fetch your package, but dpkg-source refuses to unpack it because the tarball has a different size than what is expected(/written in the .dsc). Not sure what happened, but according to the directory listing on mentors.debian.net[1], the orig.tar.gz is from March and the dsc is from today. Perhaps, you have to remove the package from mentors and re-upload it again? I just did that, it should be working now. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110510220859.ga23...@zirkel.wertarbyte.de
RFS: triggerhappy
Dear mentors, I am looking for a sponsor for my package triggerhappy. * Package name: triggerhappy Version : 0.3.4-2 Upstream Author : Stefan Tomanek stefan.tomanek...@wertarbyte.de * URL : https://github.com/wertarbyte/triggerhappy * License : GPLv3 Section : utils It builds these binary packages: triggerhappy - global hotkey daemon for Linux The package appears to be lintian clean. My motivation for maintaining this package is: I've written this little daemon software to allow the global handling of hotkeys. While many window managers offer such a functionality, they require a specific user being logged in, having the focus and running an X session. Triggerhappy observes the input device files provided by the kernel and can react to pressed keys, switches and buttons even on headless systems. It offers a few distinct features that set it apart from the few existing solutions: * system scope There is no need for anyone being logged in, since the daemon operates on a system wide scale, allowing e.g. the regulation of volume while using the console or the login manager. * hotplug capabilities A running triggerhappy daemon (thd) can handle an arbitrary number of input devices; devices can be added and removed without restarting the daemon by calling a helper program. A udev rule to inform the daemon about new devices is included. * optional exclusive grabbing of devices While usually running alongside the normal X session, thd can grab devices exclusively when instructed to do so; this way input events from those devices won't be handled by other software * generating synthetic events triggerhappy can not only launch arbitrary commands, but also generate input event itself by using uinput. By doing so, thd can grab input events from a device exclusively while channeling or even remap selected input events * support of different modes The triggerhappy daemon supports modes, allowing one to define several sets of key binding. Modes can be switched on-the-fly using the th-cmd command line utility or a predefined key Having this package uploaded to Debian would fill the gap I tried to fill by developing and packaging this tool; I'm using it on my notebook systems to regulate volume, as well as on my armel-Dockstar systems to control an mpd media player, where it proved useful as well due to its low memory footprint. Considering that there is currently no other software offering these features, I'd really appreciate the addition of my program to Debian. If you'd like to see any changes in the program or package, feel free to contact me. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/t/triggerhappy - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/t/triggerhappy/triggerhappy_0.3.4-2.dsc I would be glad if someone uploaded this package for me. Kind regards Stefan Tomanek signature.asc Description: Digital signature
Re: RFS: triggerhappy (retry)
Hello and thanks for your reply, Dies schrieb Stanislav Maslovski (stanislav.maslov...@gmail.com): But the orig.tar.gz does not have it either, so it is probably OK by now, however, you may consider adding it in future, because your work may be of interest to other distributions, and for them the Debian changelog is not a substitution for upstream's one. Sure, adding a changelog is something I'm considering to do, but I haven't gotten around to it. A somewhat related note: the patch debian-changes-0.3.4-1 in debian/patches contains changes that actually belong to upstream. As you are the upstream it should not be a problem to incorporate them in the proper place. Actually, uscan --verbose shows that you have not even oficially released the version 0.3.4 yet, while you have already packaged it for Debian! This is not good. I forgot to push the tag for release 0.3.4 to github, that's why the release was missing from the uscan output. It probably also caused the changes to appear to appear in the debian patch file. Your debian/control insists on having debhelper (= 7.0.50~) but as you do not use any of the override-* directives, I think that (= 7) should suffice. Thanks, I'll see if I can use these more relaxed requirements. Your debian/copyright is mostly OK, however, you may consider making it more DEP-5 aware (http://dep.debian.net/deps/dep5/). In any case, the copyright lines must match exactly what you have in the source files, please amend your Copyright: paragraph respectively. There is no need for any angular brackets around the copyright line; these brackets most likely came from the template. You may also consider removing redundant comments that came from templates and are seen in your init.d script and debian/rules file. Thanks for your input, I'll try to hunt down these issues. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110313125637.gd23...@zirkel.wertarbyte.de
RFS: triggerhappy (retry)
Dear mentors, I am looking for a sponsor for my package triggerhappy. * Package name: triggerhappy Version : 0.3.4-1 Upstream Author : Stefan Tomanek stefan.tomanek...@wertarbyte.de * URL : https://github.com/wertarbyte/triggerhappy * License : GPLv3 Section : utils It builds these binary packages: triggerhappy - global hotkey daemon for Linux The package appears to be lintian clean. My motivation for maintaining this package is: I've written this little daemon software to allow the global handling of hotkeys. While many window managers offer such a functionality, they require a specific user being logged in, having the focus and running an X session. Triggerhappy observes the input device files provided by the kernel and can react to pressed keys, switches and buttons even on headless systems. It offers a few distinct features that set it apart from the few existing solutions: * system scope There is no need for anyone being logged in, since the daemon operates on a system wide scale, allowing e.g. the regulation of volume while using the console or the login manager. * hotplug capabilities A running triggerhappy daemon (thd) can handle an arbitrary number of input devices; devices can be added and removed without restarting the daemon by calling a helper program. A udev rule to inform the daemon about new devices is included. * optional exclusive grabbing of devices While usually running alongside the normal X session, thd can grab devices exclusively when instructed to do so; this way input events from those devices won't be handled by other software * generating synthetic events triggerhappy can not only launch arbitrary commands, but also generate input event itself by using uinput. By doing so, thd can grab input events from a device exclusively while channeling or even remap selected input events * support of different modes The triggerhappy daemon supports modes, allowing one to define several sets of key binding. Modes can be switched on-the-fly using the th-cmd command line utility or a predefined key Having this package uploaded to Debian would fill the gap I tried to fill by developing and packaging this tool; I'm using it on my notebook systems to regulate volume, as well as on my armel-Dockstar systems to control an mpd media player, where it proved useful as well due to its low memory footprint. Considering that there is currently no other software offering these features, I'd really appreciate the addition of my program to Debian. If you'd like to see any changes in the program or package, feel free to contact me. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/t/triggerhappy - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/t/triggerhappy/triggerhappy_0.3.4-1.dsc I would be glad if someone uploaded this package for me. Kind regards Stefan Tomanek signature.asc Description: Digital signature
RFS: triggerhappy (retry)
Dear mentors, I am looking for a sponsor for my package triggerhappy. * Package name: triggerhappy Version : 0.3.3-1 Upstream Author : Stefan Tomanek stefan.tomanek...@wertarbyte.de * URL : https://github.com/wertarbyte/triggerhappy * License : GPLv3 Section : utils It builds these binary packages: triggerhappy - global hotkey daemon for Linux The package appears to be lintian clean. My motivation for maintaining this package is: I've written this little daemon software to allow the global handling of hotkeys. While many window managers offer such a functionality, they require a specific user being logged in, having the focus and running an X session. Triggerhappy observes the input device files provided by the kernel and can react to pressed keys, switches and buttons even on headless systems. It offers a few distinct features that set it apart from the few existing solutions: * system scope There is no need for anyone being logged in, since the daemon operates on a system wide scale, allowing e.g. the regulation of volume while using the console or the login manager. * hotplug capabilities A running triggerhappy daemon (thd) can handle an arbitrary number of input devices; devices can be added and removed without restarting the daemon by calling a helper program. A udev rule to inform the daemon about new devices is included. * optional exclusive grabbing of devices While usually running alongside the normal X session, thd can grab devices exclusively when instructed to do so; this way input events from those devices won't be handled by other software * generating synthetic events triggerhappy can not only launch arbitrary commands, but also generate input event itself by using uinput. By doing so, thd can grab input events from a device exclusively while channeling or even remap selected input events * support of different modes The triggerhappy daemon supports modes, allowing one to define several sets of key binding. Modes can be switched on-the-fly using the th-cmd command line utility or a predefined key Having this package uploaded to Debian would fill the gap I tried to fill by developing and packaging this tool; I'm using it on my notebook systems to regulate volume, as well as on my armel-Dockstar systems to control an mpd media player, where it proved useful as well due to its low memory footprint. Considering that there is currently no other software offering these features, I'd really appreciate the addition of my program to Debian. If you'd like to see any changes in the program or package, feel free to contact me. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/t/triggerhappy - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/t/triggerhappy/triggerhappy_0.3.3-1.dsc I would be glad if someone uploaded this package for me. Kind regards Stefan Tomanek signature.asc Description: Digital signature
RFS: triggerhappy
Dear mentors, I am looking for a sponsor for my package triggerhappy. * Package name: triggerhappy Version : 0.3.3-1 Upstream Author : Stefan Tomanek stefan.tomanek...@wertarbyte.de * URL : https://github.com/wertarbyte/triggerhappy * License : GPLv3 Section : utils It builds these binary packages: triggerhappy - global hotkey daemon for Linux The package appears to be lintian clean. My motivation for maintaining this package is: I've written this little ademon software to allow the global handling of hotkeys. While many window managers offer such a functionality, they require a specific user being logged in, having the focus and running an X session. Triggerhappy observes the input device files provided by the kernel and can react to pressed keys, switches and buttons even on headless systems. It offers a few distinct features that set it apart from the few existing solutions: * system scope There is no need for anyone being logged in, since the daemon operates on a system wide scale, allowing e.g. the regulation of volume while using the console or the login manager * hotplug capabilities A running triggerhappy daemon (thd) can handle an arbitrary number of input devices; devices can be added and removed without restarting the daemon. A udev rule to inform the daemon about new devices is included. * optional exclusive grabbing of devices While usually running alongside the normal X session, thd can grab devices exclusively when instructed to do so; this way input events from those devices won't be handled by other software * generating synthetic events triggerhappy can not only launch arbitrary commands, but also generate input event itself by using uinput. By doing so, thd can grab input events from a device exclusively while channeling or even remap selected input events * support of different modes The triggerhappy daemon supports modes, allowing one to define several sets of key binding. Modes can be switched on-the-fly using the th-cmd command line utility or a predefined key Having this package uploaded to Debian would fill the gap I tried to fill by developing and packaging this tool; I'm using it on my notebook systems to regulate volume as well as my armel-Dockstar systems to control an mpd media player, where it proved useful as well due to its low memory footprint. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/t/triggerhappy - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/t/triggerhappy/triggerhappy_0.3.3-1.dsc I would be glad if someone uploaded this package for me. Kind regards Stefan Tomanek signature.asc Description: Digital signature
RFS: triggerhappy
Dear mentors, I am looking for a sponsor for my package triggerhappy. * Package name: triggerhappy Version : 0.3.2-1 Upstream Author : Stefan Tomanek stefan.tomanek...@wertarbyte.de * URL : http://github.com/wertarbyte/triggerhappy * License : GPL Section : utils It builds these binary packages: triggerhappy - global hotkey daemon for Linux The package appears to be lintian clean. My motivation for maintaining this package is: Looking for a way of globally assigning hotkey handlers to the special keys found on my notebooks, I developed triggerhappy. I also use it to control headless systems, e.g. a ARM based MPD jukebox which is controlled by a USB keypad or bluetooth wiimote. Having this software in Debian would provide an easy way to bind commands to input events without the need for running an X11 session or logging in. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/t/triggerhappy - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/t/triggerhappy/triggerhappy_0.3.2-1.dsc I would be glad if someone uploaded this package for me. Kind regards Stefan Tomanek -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110120223231.gl18...@zirkel.wertarbyte.de
Re: RFS: triggerhappy
Dies schrieb Nick Leverton (n...@leverton.org): Every .c-file has to contain that header? Sure, possible, but seems very awkward? It helps, the Debian tool licensecheck can then scan and report on the contents of the package. Also if a source is borrowed elsewhere, the authorship is still clear. Do you have an example for such an header? I tried a few variants, but could not get licensecheck to work. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110118214753.gi18...@zirkel.wertarbyte.de
Re: RFS: triggerhappy
Dies schrieb Nick Leverton (n...@leverton.org): I gather that this is a new package to Debian. Your debian/changelog should probably start from new in that case. You could perhaps move the existing debian/changelog to changelog.OLD or similar, if you want to retain the history of the code's evolution before it entered Debian. I'm not sure about that and I heard different opinions about it - does it hurt to keep the old history? OK, it'll survive inside the git repository, but is removing the history before the package introduction really necessary? The new debian/changelog should start with the new version, 0.3.1-1, and should Close: your ITP bug #603842 (you've closed it in a version which AFAICS has never been in Debian). Sure, adding that line would be the first thing I'd do once someone volunteers to sponsor the package. The source files licensing (author, date and a pointer to COPYING) needs to be made explicit in each file, via a comment block near the top: http://lists.debian.org/debian-mentors/2009/03/msg00451.html Are you your own upstream ? This could be easy to apply then :) Every .c-file has to contain that header? Sure, possible, but seems very awkward? Sorry this took so long to write up, hope you can have a happy $FESTIVITIES and write some more cool code for Debian :-) Well, thanks for your review, I'll try to do both :-) -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101224170053.gb4...@zirkel.wertarbyte.de
Re: RFS: triggerhappy
Dies schrieb Niels Thykier (ni...@thykier.net): It might be because you have a different version than I; I am using 1.44 (from testing). So am I: ste...@exa:~$ cppcheck --version Cppcheck 1.44 -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101221104819.gu4...@zirkel.wertarbyte.de
Re: RFS: triggerhappy
Dies schrieb Niels Thykier (ni...@thykier.net): I just cloned the git repository and I cannot reproduce any more either. I suspect this is because you fixed the buffer variable going out of scope. Strange, I did not touch anything in that section of code. But anyhow, I'm glad that warning is gone now :-) -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101221114340.gw4...@zirkel.wertarbyte.de
Re: RFS: triggerhappy
Dies schrieb Niels Thykier (ni...@thykier.net): I just cloned the git repository and I cannot reproduce any more either. I suspect this is because you fixed the buffer variable going out of scope. OK, I think now I incorporated all your suggested fixes and uploaded a new package with version 0.3.2-1. Thanks again for your review. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101221122307.gx4...@zirkel.wertarbyte.de
Re: RFS: triggerhappy
Dies schrieb Niels Thykier (ni...@thykier.net):
Though the upstream code might need a little attention (or some
clarification); e.g. cppcheck finds a resource leak:
Checking cmdsocket.c...
[cmdsocket.c:126]: (error) Resource leak: fd
Looking at the code I am not sure what the intention is. My best guess
is that it is trying to transmit the leaked file descriptor.
Yes, it does that. This allows the daemon itself to run as user nobody,
while th-cmd (launched by udev) can open a new device and pass the fd
to thd.
Though I am not convinced this will work; even if it is possible (I
vaguely recall seeing an extension in Linux to allow something like
this), I suspect the program relies on undefined behaviour here:
char buffer[CMSG_SPACE(sizeof(dev_fd))];
m.msg_control = buffer;
The issue is that buffer goes out of scope before m is used (in sendmsg).
I guess you are refering to line 115 in cmdsocket.c?
I see, I'll move the buffer declaration to a safer location.
In the if in uinput.c:27 it looks like you are missing a uinput_fd = -1;
Fixed that, I'm now simply calling close_uinput(..) there.
In trigger.c:205 there is no check for if fork failed and this leads to
a silent nothing happened. There are also got a number of unchecked
malloc/strdup, which could lead to out of memory segfaults, but at
least that is some kind of feedback.
OK, I added some error reporting there.
cppcheck also believes that count_triggers (trigger.c) and print_ignores
(ignore.c) are never used. I did not verify that.
Indeed, I used those functions for debugging purposes only, but I guess
leaving them there does no harm.
In thd.c:331 the error message implies that the user does not exist, but
getpwnam can fail with other reasons; it might be a good idea to
use a more neutral error like:
int err = errno;
fprintf(stderr, Could not look up the user %s\n, user);
errno = err;
perror(getpwnam);
OK, I neutralized the error message, however using perror(errno) from getpwnam
is not really interesting, since all I get is Sucess, even when specifying a
completely
bogus name.
Adding warnings to gcc I saw the following:
cc -g -O2 -Wall -Wextra -g -O2 -Wall -Wextra -c -o eventnames.o
eventnames.c
In file included from eventtable.h:10,
from eventnames.c:5:
evtable_KEY.h:123: warning: initialized field overwritten
evtable_KEY.h:123: warning: (near initialization for 'KEY_NAME[122]')
[...]
They are were triggered with -Wextra; it may be nothing, but I figured I
would mention it.
Yes, I was aware of those. evtable_{KEY,EV,SW} are autogenerated from
linux/input.h,
generating a mapping table from event names to the integer values, but since
some events
have multiple names, these messages appear.
Thanks for your review, I'll push the changed advocated by you to my git
repository
today (https://github.com/wertarbyte/triggerhappy).
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20101220160842.gr4...@zirkel.wertarbyte.de
Re: RFS: triggerhappy
Dies schrieb Niels Thykier (ni...@thykier.net): Checking cmdsocket.c... [cmdsocket.c:126]: (error) Resource leak: fd [...] Okay, perhaps you could document this in the code that this is intentional (e.g. transmitting the fd and the leak is a false-positive)? I'm playing around with cppcheck myself, but I cannot reproduce the message above; how did you call the program? ste...@exa:~/git/triggerhappy$ cppcheck . --enable=all -v Checking ./cmdsocket.c... 1/11 files checked 9% done Checking ./devices.c... 2/11 files checked 18% done Checking ./eventnames.c... 3/11 files checked 27% done Checking ./ignore.c... 4/11 files checked 36% done Checking ./keystate.c... 5/11 files checked 45% done Checking ./obey.c... 6/11 files checked 54% done Checking ./th-cmd.c... 7/11 files checked 63% done Checking ./thd.c... 8/11 files checked 72% done Checking ./trigger.c... 9/11 files checked 81% done Checking ./triggerparser.c... 10/11 files checked 90% done Checking ./uinput.c... 11/11 files checked 100% done Checking usage of global functions.. [./trigger.c:1]: (style) The function 'count_triggers' is never used [./ignore.c:1]: (style) The function 'print_ignores' is never used ste...@exa:~/git/triggerhappy$ I've pushed the changes done so far to my git repository. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101220202027.gs4...@zirkel.wertarbyte.de
RFS: triggerhappy
Dear mentors, I am looking for a sponsor for my package triggerhappy. * Package name: triggerhappy Version : 0.3.1-1 Upstream Author : Stefan Tomanek stefan.tomanek...@wertarbyte.de * URL : http://github.com/wertarbyte/triggerhappy * License : GPL Section : utils It builds these binary packages: triggerhappy - global hotkey daemon for Linux The package appears to be lintian clean. My motivation for maintaining this package is: Looking for a way of globally assigning hotkey handlers to the special keys found on my notebooks, I developed triggerhappy. I also use it to control headless systems, e.g. a ARM based MPD jukebox which is controlled by a USB keypad or bluetooth wiimote. Having this software in Debian would provide an easy way to bind commands to input events without the need for running an X11 session or logging in. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/t/triggerhappy - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/t/triggerhappy/triggerhappy_0.3.1-1.dsc I would be glad if someone uploaded this package for me. Kind regards Stefan Tomanek -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101218141021.gn4...@zirkel.wertarbyte.de
Re: esekeyd and triggerhappy (Re: RFS: triggerhappy)
Dies schrieb Stanislav Maslovski (stanislav.maslov...@gmail.com): Just a note for completeness: although not properly documented, acpid reacts to quite a few non-acpi events, including volume control buttons and cd-related buttons found on many laptops (as of ver. 2.0.7). It didn't use to to this; the thinkpad acpi module switching from acpi to input events was the main motivation to develop the perl based precursor to triggerhappy (called magmakeys back then). -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101210104317.ge28...@zirkel.wertarbyte.de
Re: esekeyd and triggerhappy (Re: RFS: triggerhappy)
Dies schrieb Jonathan Nieder (jrnie...@gmail.com): Would it be easy and would it be sensible to teach esekeyd these features? Triggerhappy 0.3.0 brings some new features; individual devices can now be tagged, so that pressing a certain key on a USB keyboard can trigger a hotkey handler, while pressing the identical key on the system keyboard cannot; It is also possible to let triggerhappy grab a device exclusively; the daemon can also generate synthetic key events (using uinput) that can be processed by other applications. Still looking for a sponsor though :-) -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101210104703.gf28...@zirkel.wertarbyte.de
Re: esekeyd and triggerhappy (Re: RFS: triggerhappy)
Dies schrieb Jonathan Nieder (jrnie...@gmail.com):
This information could be useful for both package descriptions.
(Maybe, for triggerhappy:
That is, this is similar to esekeyd but it also supports
such and such, allowing you to such and such.
and for esekeyd:
This package does not do such and such; for that, see
triggerhappy. In the simple situations it does handle,
esekeyd is {simpler to configure | compatible with the
old funkey daemon | more conservative in its use of
resources | providing a different interface that existing
users might be used to | whatever}.
OK, I don't know esekeyd enough to include it into a direct comparison, but I
tweaked my package description to better reflect the main aspects of
triggerhappy and its features.
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20101129001421.gb28...@zirkel.wertarbyte.de
Re: esekeyd and triggerhappy (Re: RFS: triggerhappy)
Dies schrieb Jonathan Nieder (jrnie...@gmail.com):
This information could be useful for both package descriptions.
(Maybe, for triggerhappy:
That is, this is similar to esekeyd but it also supports
such and such, allowing you to such and such.
and for esekeyd:
This package does not do such and such; for that, see
triggerhappy. In the simple situations it does handle,
esekeyd is {simpler to configure | compatible with the
old funkey daemon | more conservative in its use of
resources | providing a different interface that existing
users might be used to | whatever}.
) As you can see, there are some placeholders because I do not know
the packages; I am just saying it would be nice to provide the
sysadmin with advice of some sort to choose between them.
I'm not sure whether such a direct comparison of packages in their description
might be not be considered offensive to some and might incite some kind of arms
race: yo daemon so fat
Think of such comparisons in the description of gnome/kde or vim/emacs packages
:-)
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20101127152810.ga28...@zirkel.wertarbyte.de
Re: RFS: triggerhappy
Dies schrieb Jonathan Nieder (jrnie...@gmail.com): How does triggerhappy compare to Krzysztof Burghardt's esekeyd? I think esekeyd can only handle KEY events, while triggerhappy can also process Switch and button events. I am also unsure whether esekeyd support the hotplugging of input devices (done in triggerhappy by a udev script) or daemon control via socket. From what I see, esekeyd also lacks the support for modes, which can modify the button assignment depending on the state the daemon is in. It is easy to misunderstand the short description. I think it is meant to say that that the hotkey daemon is not tied to a user session, but now it conjures up images of user-independent hotkeys. Maybe: Description: hotkey daemon for Linux Triggerhappy watches connected input devices for certain key presses (like Suspend and Volume Control) and runs administrator-configured commands when they are pressed. Unlike suchandsuch, it runs as a persistent, systemwide service and therefore can be used even outside the context of a user or X11 session. . It can also handle remote controls, as they are presented as keyboards. No kernel patch is required. The daemon is a userspace program that polls the /dev/input/event? interfaces for incoming key presses. . For example, this package might be useful on a headless system to use input events generated by a remote control to control an mpd server. Sounds good, I'll look into adapting that description. Thanks for your reply Stefan Tomanek -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101123085643.go15...@zirkel.wertarbyte.de
Re: esekeyd and triggerhappy (Re: RFS: triggerhappy)
Dies schrieb Jonathan Nieder (jrnie...@gmail.com): I think esekeyd can only handle KEY events, while triggerhappy can also process Switch and button events. I am also unsure whether esekeyd support the hotplugging of input devices (done in triggerhappy by a udev script) or daemon control via socket. From what I see, esekeyd also lacks the support for modes, which can modify the button assignment depending on the state the daemon is in. Thanks, that helps. Next comes a question that might sound off-topic. Would it be easy and would it be sensible to teach esekeyd these features? I looked through the esekey source code, and from what I've seen esekey can handle only one input device at a time, while triggerhappy can open multiple devices simultanously. This is important for supporting devices that might not even be there when the daemon is started (bluetooth remote, USB keypad). What I am trying to figure out is whether esekeyd and triggerhappy occupy different niches or if it is an accident of history that you are not already working on the same codebase. IIUC triggerhappy is very young so there might be a chance to merge or make the user interfaces compatible before users grow irrationally attached to the quirks of one or the other. Of course I am in favor of _my_ pet project (who wouldn't?), but I think merging the two programs would be difficult. Although young, triggerhappy has accumulated quite a few features that would require a redesigning many aspects of esekeyd (multiple devices, command socket, multiple config files). -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101123141011.gq15...@zirkel.wertarbyte.de
Re: RFS: triggerhappy [fixed mistake in URL]
Dies schrieb Benoît Knecht (benoit.kne...@fsfe.org): I understand :) But now that you're packaging it, you should let people know by retitling the bug to ITP and setting yourself as the bug owner (otherwise someone else might start working on it too, only to discover the work has already been done). And don't forget to add (Closes: #603842) to your changelog. Hm, for some reason the BTS did not retitle the report, although it processed the ownership change, do you know what I did wrong? -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101122082009.ga15...@zirkel.wertarbyte.de
Re: RFS: triggerhappy [fixed mistake in URL]
Dies schrieb Benoît Knecht (benoit.kne...@fsfe.org): As a matter of fact, I do :) You retitled it to the exact same title it already has: Indeed, I just noticed. Classic case of copypaste gone wrong. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101122084026.gd15...@zirkel.wertarbyte.de
RFS: tartarus
Dear mentors, I am looking for a sponsor for my package tartarus. * Package name: tartarus Version : 0.9.4-2 Upstream Author : Stefan Tomanek stefan.tomanek+tarta...@wertarbyte.de * URL : http://wertarbyte.de/tartarus.shtml * License : GPLv3 Section : utils It builds these binary packages: tartarus - script based backup system The package appears to be lintian clean. The upload would fix these bugs: 604447 My motivation for maintaining this package is: I've written tartarus as a simple backup solution for my dedicated server. It uses parts of the unix toolshed that should be available even in the most basic rescue system, making recovery easy in case things go wrong. By using Bash and Perl, the program is easily extendable and offers various hooks that can be used to modify its behaviour, while including features like LVM snapshots, on-the-fly-uploading and compression/encryption out of the box. I created the package to simplify the installation on now roughly 1100 systems using this program (http://wertarbyte.de/stats/tartarus-use.png) on a regular basis and I would really like to this this included into Debian. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/t/tartarus - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/t/tartarus/tartarus_0.9.4-2.dsc I would be glad if someone uploaded this package for me. Kind regards Stefan Tomanek -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101122105251.gg15...@zirkel.wertarbyte.de
RFS: ifupdown-scripts-wa
Dear mentors, I am looking for a sponsor for my package ifupdown-scripts-wa. * Package name: ifupdown-scripts-wa Version : 0.4.2 Upstream Author : Stefan Tomanek stefan.tomanek+ifupd...@wertarbyte.de * URL : https://github.com/wertarbyte/ifupdown-scripts/ * License : GPLv3 Section : admin It builds these binary packages: ifupdown-scripts-wa - Additional ifupdown scripts for configuring network devices The package appears to be lintian clean. The upload would fix these bugs: 604462 My motivation for maintaining this package is: The package contains various extension scripts to ifupdown I've written over time. They add the following functionality to the mechanisms provided by Debian's ifupdown: * addresses allows multiple addresses to be added to an network device in a convenient CIDR notation * reachable add additional networks reachable through a configured interface, either directly or by using a connected gateway * conflicts automatically (de)configures an interface when another one comes up or goes down * pan connects your computer to an Bluetooth PAN access point before configuring the interface * vpnc controls a cisco VPN connect through ifupdown * wireless-tools-snooze waits for association with the access point before retrieving an IP address for the wireless network * ifupdown-network pm-utils script that shuts down specified network devices during suspend and restores them during resume The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/i/ifupdown-scripts-wa - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/i/ifupdown-scripts-wa/ifupdown-scripts-wa_0.4.2.dsc I would be glad if someone uploaded this package for me. Kind regards Stefan Tomanek -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101122120813.gh15...@zirkel.wertarbyte.de
Re: RFS: ifupdown-scripts-wa
Dies schrieb Benoît Knecht (benoit.kne...@fsfe.org): You should get in touch with the maintainer of ifupdown, Anthony Towns a...@debian.org. And FYI, lintian reports the following: W: ifupdown-scripts-wa source: out-of-date-standards-version 3.8.1 (current is 3.9.1) W: ifupdown-scripts-wa: latest-debian-changelog-entry-changed-to-native Yes, I know - ifupdown-scripts aren't thatuseful for other distributions I think? -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101122154713.gi15...@zirkel.wertarbyte.de
Re: RFS: tartarus
Thanks for your feedback, I just created a new package version which should take care of most issues described by you. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101122162454.gk15...@zirkel.wertarbyte.de
Re: RFS: triggerhappy
Dies schrieb Jonathan Nieder (jrnie...@gmail.com): How does this compare to Rick van Rein's funkey[1]? Hm, funkey does require a kernel patch und looks quite dated? Funky Daemon which demonstrates how to parse the /dev/funkey character device. As I said, triggerhappy uses the /dev/input/eventX files, anything that fires SW_, KEY_ or BTN_ events can be used t launch programs. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101123073810.gn15...@zirkel.wertarbyte.de
RFS: triggerhappy
Dear mentors, I am looking for a sponsor for my package triggerhappy. * Package name: triggerhappy Version : 0.1.6-1 Upstream Author : Stefan Tomanek stefan.tomanek...@wertarbyte.de * URL : http://github.com/wertarbyte/triggerhappy/ * License : GPL Section : admin It builds these binary packages: triggerhappy - global, user and session independent hotkey daemon The package appears to be lintian clean. My motivation for maintaining this package is: I've written this small program to fill a need not covered by any existing program, so I think having it in Debian and making it available to others is a good thing. Currently, there is no practical way to configure global hotkeys that act independent from a user and/or X11 session. Buttons like Suspend or Volume Control should be handeled without requiring a user to log into their desktop environment, which is hard to achieve since most notebook drivers do not generate ACPI events for their special buttons. The daemon is also convinient to use in embedded or headless situations; I am using a Debian system installed on a Dockstar device (ARM9 system with USB and Ethernet) running mpd which is controlled by a bluetooth wiimote and an USB keypad; triggerhappy captures the input events generated by those devices and launches the appropiate mpc commands. No user session is required for this, since triggerhappy directly reads from /dev/input/eventX and is therefore independent from focus. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/t/triggerhappy - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/t/triggerhappy/triggerhappy_0.1.3-1.dsc I would be glad if someone uploaded this package for me. Kind regards Stefan Tomanek -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101121214324.gh17...@zirkel.wertarbyte.de
RFS: triggerhappy [fixed mistake in URL]
Dear mentors, I am looking for a sponsor for my package triggerhappy. * Package name: triggerhappy Version : 0.1.6-1 Upstream Author : Stefan Tomanek stefan.tomanek...@wertarbyte.de * URL : http://github.com/wertarbyte/triggerhappy/ * License : GPL Section : utils It builds these binary packages: triggerhappy - global, user and session independent hotkey daemon The package appears to be lintian clean. My motivation for maintaining this package is: I've written this small program to fill a need not covered by any existing program, so I think having it in Debian and making it available to others is a good thing. Currently, there is no practical way to configure global hotkeys that act independent from a user and/or X11 session. Buttons like Suspend or Volume Control should be handeled without requiring a user to log into their desktop environment, which is hard to achieve since most notebook drivers do not generate ACPI events for their special buttons. The daemon is also convinient to use in embedded or headless situations; I am using a Debian system installed on a Dockstar device (ARM9 system with USB and Ethernet) running mpd which is controlled by a bluetooth wiimote and an USB keypad; triggerhappy captures the input events generated by those devices and launches the appropiate mpc commands. No user session is required for this, since triggerhappy directly reads from /dev/input/eventX and is therefore independent from focus. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/t/triggerhappy - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/t/triggerhappy/triggerhappy_0.1.6-1.dsc I would be glad if someone uploaded this package for me. Kind regards Stefan Tomanek -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101121214558.gi17...@zirkel.wertarbyte.de
RFS: triggerhappy
Dear mentors, I am looking for a sponsor for my package triggerhappy. * Package name: triggerhappy Version : 0.1.6-1 Upstream Author : Stefan Tomanek stefan.tomanek...@wertarbyte.de * URL : http://github.com/wertarbyte/triggerhappy/ * License : GPL Section : admin It builds these binary packages: triggerhappy - global, user and session independent hotkey daemon The package appears to be lintian clean. My motivation for maintaining this package is: I've written this small program to fill a need not covered by any existing program, so I think having it in Debian and making it available to others is a good thing. Currently, there is no practical way to configure global hotkeys that act independent from a user and/or X11 session. Buttons like Suspend or Volume Control should be handeled without requiring a user to log into their desktop environment, which is hard to achieve since most notebook drivers do not generate ACPI events for their special buttons. The daemon is also convinient to use in embedded or headless situations; I am using a Debian system installed on a Dockstar device (ARM9 system with USB and Ethernet) running mpd which is controlled by a bluetooth wiimote and an USB keypad; triggerhappy captures the input events generated by those devices and launches the appropiate mpc commands. No user session is required for this, since triggerhappy directly reads from /dev/input/eventX and is therefore independent from focus. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/t/triggerhappy - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/t/triggerhappy/triggerhappy_0.1.3-1.dsc I would be glad if someone uploaded this package for me. Kind regards Stefan Tomanek -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101121213307.gg17...@zirkel.wertarbyte.de
Re: RFS: triggerhappy [fixed mistake in URL]
Dies schrieb Benoît Knecht (benoit.kne...@fsfe.org): I see you've now opened a bug for your package (#603842), but you still need to close it in your changelog. And it should be an ITP bug owned by you, not an RFP. I opened that bug before I uploaded the package here, hoping that someone else might pick up that torch :-) Besides that, I still believe it would be best to run the daemon as a regular system user by default, and let the user decide if root privileges are required (with a commented-out option in /etc/default/triggerhappy with some explanation about when and why it should be run as root, for example). Do you think nobody would be sufficient, or should triggerhappy create a dedicated user account for that? And this is not a big deal, but I think it's worth mentioning anyway: your man pages have a OPTIONS AND ARGUMENTS header, whereas man-pages(7) recommends simply using OPTIONS; you may want to change that in order to be more consistent with most man pages. Hm, thanks for that remark, I'll look into this and change that in the next upstream version. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101121230008.gm17...@zirkel.wertarbyte.de
RFS: triggerhappy
Dear mentors, I am looking for a sponsor for my package triggerhappy. * Package name: triggerhappy Version : 0.1.3-1 Upstream Author : Stefan Tomanek stefan.tomanek...@wertarbyte.de * URL : http://github.com/wertarbyte/triggerhappy * License : GPL Section : admin It builds these binary packages: triggerhappy - global, user and session independent hotkey daemon The package appears to be lintian clean. My motivation for maintaining this package is: I've written this small program to fill a need not covered by any existing program, so I think having it in Debian and making it available to others is a good thing. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/t/triggerhappy - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/t/triggerhappy/triggerhappy_0.1.3-1.dsc I would be glad if someone uploaded this package for me. Kind regards Stefan Tomanek PS: Please CC me, since I am not yet subscribed to the list. signature.asc Description: Digital signature
Re: RFS: triggerhappy
Dies schrieb Benoît Knecht (benoit.kne...@fsfe.org): lintian -I --pedantic actually gives a few warnings: I: triggerhappy source: debian-watch-file-is-missing W: triggerhappy: description-starts-with-leading-spaces I: triggerhappy: init.d-script-does-not-provide-itself /etc/init.d/triggerhappy P: triggerhappy: no-upstream-changelog I: triggerhappy: spelling-error-in-manpage usr/share/man/man1/thd.1.gz seperated separated I: triggerhappy: spelling-error-in-manpage usr/share/man/man1/thd.1.gz appropiate appropriate I'm also wondering if admin is the right section for your package; utils maybe? Yes, that is probably a better choice. Oh and one last thing (keep in mind I didn't look into your package very thoroughly, so forgive me if it's a silly question), I saw in your changelog that you introduced an option to drop root privileges; why aren't you using it by default? From a security point of view, it would of course be preferable, but maybe there's another reason not to do it? Dropping root privileges (and become nobody) might be a good idea, but it depends on what the daemon and its triggers are used for; if they are supposed to initiate a shutdown or configure the network, the root privileges might be missing. It also makes hotplugging more complicated, since the daemon cannot open new devices - although the th-cmd client is now able open the device itself and pass the open fd through the socket to the server, provided the client program runs as root, which is probably the case when triggered by udev. Thank you for your review, I'll see if I can squish some of those issues. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101118000706.gi17...@zirkel.wertarbyte.de
Re: RFS: triggerhappy
Dies schrieb Benoît Knecht (benoit.kne...@fsfe.org): lintian -I --pedantic actually gives a few warnings: I: triggerhappy source: debian-watch-file-is-missing W: triggerhappy: description-starts-with-leading-spaces I: triggerhappy: init.d-script-does-not-provide-itself /etc/init.d/triggerhappy P: triggerhappy: no-upstream-changelog I: triggerhappy: spelling-error-in-manpage usr/share/man/man1/thd.1.gz seperated separated I: triggerhappy: spelling-error-in-manpage usr/share/man/man1/thd.1.gz appropiate appropriate I'm also wondering if admin is the right section for your package; utils maybe? OK, I just uploaded 0.1.4-1, which addresses most of those issues, so if you (or anyone else) want to take another look? Greetings Stefan Tomanek -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101118065801.gj17...@zirkel.wertarbyte.de
