Bug#968728: closing 968728

2020-08-21 Thread Thomas Stewart 
close 968728 

Thanks Adam :)

Kind Regards
--
Tom

Bug#968728: RFS: w1retap/1.4.4-4 [RC] -- Data logger for 1-Wire weather sensors

2020-08-20 Thread Thomas Stewart 
Package: sponsorship-requests
Severity: important

Dear mentors,

As my existing sponsor seems very busy I am looking for a new sponsor
for my package "w1retap":

 * Package name: w1retap
   Version : 1.4.4-4
   Upstream Author : Jonathan Hudson 
 * URL : http://www.zen35309.zen.co.uk/wx/tech.html
 * License : Expat-Dallas-Semiconductor-Corporation and 
Expat-University-of-Newcastle-upon-Tyne and GPL-2+, GPL-2+, 
Expat-Dallas-Semiconductor-Corporation and GPL-2+, Expat
 * Vcs : https://salsa.debian.org/thomasdstewart-guest/w1retap
   Section : electronics

It builds those binary packages:

  w1retap-sqlite - Data logger for 1-Wire weather sensors (SQLite plugin)
  w1retap-pgsql - Data logger for 1-Wire weather sensors (PostgreSQL plugin)
  w1retap-odbc - Data logger for 1-Wire weather sensors (ODBC plugin)
  w1retap-mongo - Data logger for 1-Wire weather sensors (MongoDB plugin)
  w1retap-mysql - Data logger for 1-Wire weather sensors (MySQL plugin)
  w1retap-doc - Data logger for 1-Wire weather sensors (docs)
  w1retap - Data logger for 1-Wire weather sensors

To access further information about this package, please visit the following 
URL:

  https://mentors.debian.net/package/w1retap/

Alternatively, one can download the package with dget using this command:

  dget -x 
https://mentors.debian.net/debian/pool/main/w/w1retap/w1retap_1.4.4-4.dsc

Changes since the last upload:

 w1retap (1.4.4-4) unstable; urgency=medium
 .
   * Refresh dquilt patches
   * Rename fix-w1pgsql-snprintf-timet.patch to fix-timet.patch
   * Add timet fixes for w1file, w1pgsql, w1util and w1xml
   * Update patch descriptions
   * Fix lintian autotools-pkg-config-macro-not-cross-compilation-safe
   * Add fix-autotools-libxml2.patch (Closes: #949511)
   * Fix gcc-10 build errors (Closes: #957921)
   * Fix owerr spelling
   * Replace build dependency asciidoc with asciidoc-base
   * Update standards from 3.9.8 to 4.5.0
   * Fix lintian init.d-script-should-always-start-service
   * Upgrade debhelper compat from 10 to 13
   * Add Vcs-Git and Vcs-Browser fields to control file
   * Fix lintian skip-systemd-native-flag-missing-pre-depends
   * Add Rules-Requires-Root to control
   * Added salsa-ci.yml
   * Fix man page spelling
   * Add Documentation key to service
   * Add systemd service hardening-features
   * Make copyright format URL https
   * Update lintian-overrides
   * Add some autopkgtest tests
   * Remove training whitespace from changelog
   * Fix lintian debian-rules-uses-as-needed-linker-flag
   * Fix lintian upstream-metadata-file-is-missing

Kind Regards
--
Tom

Bug#791724: RFS: w1retap/1.4.4-1 [ITP] -- Data logger for 1-Wire weather sensors

2016-10-21 Thread Thomas Stewart 
Hi Gianfranco,

Thanks again for another review and the suggestions you made! I have
made a number of the fixes you suggested and have tried to explain my
choices below. I have just uploaded a fresh version of the package to
http://mentors.debian.net/package/w1retap. 

If you have any further comments they would really be appreciated,
alternatively if you think that the package is ready would you be
willing to sponsor the upload?


On 15 Oct 2016, at 11:10, Gianfranco Costamagna wrote:
> >The plugin packages contain .so files, the --noscripts option stops an
> >ldconfig run when installing. Without it I get a lintian useless
> >ldconfig run warnings.
> 
> well, I usually don't care about such warnings, but I wonder if somewhen
> in the future the package starts shipping an external shared library
> and ldconfig won't be run because of this.
> (I'm not asking to change this, just wondering about a possible future
> side effect, and please note I have no clues about the possibilities
> of this scenario, and probably lintian will complain in such case)
> 

I think w1retap is in maintenance mode, so this is currently unlikely.
However I'll keep it in mind in the future.


> >I did run all of the above and found some issues. Some of the issues
> >seemed to be more related to actual upstream development rather than
> >packaging. Most notably predicable file creation in /tmp, which is
> >fixed in the above mentioned movetmp.patch. Did you spot anything
> >else that needing fixing?
> 
> mmm movetmp.patch... 
> 
> -w1->tmpname = "/tmp/.w1retap.dat";
> +w1->tmpname = "/var/lib/w1retap/.w1retap.dat";
> 
> I don't think using /var/lib for tmp stuff is something 
> 
> this is a log, isn't /var/log something better?
> (with some logrotate stuff)
>

The /var/lib/w1retap directory contains the location for the default
w1retap data log file. If I were to record the data to PostgreSQL or
MySQL the actual data would end up somewhere else under /var/lib too.
Given that the data will be sensor readings (temperature, windspeed,
rainfall, etc) I would not expect this data to be rotated.

The ".w1retap.dat" file contains the last successful data reading. This
data can then be read by various other programs or scripts that only
want current readings (eg the current outside temperature). I think /tmp
is not the correct place to store it and I think that it does not fit
well into /var/log either. This is why I changed it to /var/lib.

 
> additional little points:
> - please enable hardening if possible, according to blhc 
> http://debomatic-amd64.debian.net/distribution#unstable/w1retap/1.4.4-1/blhc
> somebody is overriding flags
> 
> - 
> DPKG_EXPORT_BUILDFLAGS = 1
> include /usr/share/dpkg/default.mk
> 
> 
> ^^ this is useless now
> 

I removed the above and I think the buildflags or the include was
overriding the flags. The build now includes "-fPIE
-fstack-protector-strong -Wformat -Werror=format-security" when
building.


> - why the upstream build system is creating all this stuff in /usr/bin?

Dallas Semiconductor Corp (now Maxim Integrated) created the 1-wire
standard and devices. They created a software release (confusingly
called libusblinux300.tar.gz) to interface with the devices. The idea
was to enable anyone to make use of the devices quickly without
restrictions. It was this software that was used to create the w1retap
project.

The upstream build system continues to create the sample utilities that
were included in the original software release. While these utilities
may be useful for w1retap development, to my knowledge they are not
required to actually run a w1retap setup. This is why I've not packaged
those extra binary's.


> - doc might be split easily into a w1retap-doc package
> 

Good idea, I've split it out and created w1retap-doc. This nicely
reduced the size of the main w1retap deb file. This also prompted me to
install another useful script called w1sensors.


> usr/lib/*/w1retap/libw1common.so*
> usr/lib/*/w1retap/libw1csv.so*
> usr/lib/*/w1retap/libw1file.so*
> usr/lib/*/w1retap/libw1serial.so*
> usr/lib/*/w1retap/libw1usb.so*
> usr/lib/*/w1retap/libw1xml.so*
> 
> what about a single
> usr/lib/*/w1retap/lib*.so* entry?
> 

I do like that shorter version, however that glob will match all the
available plugins. So it would also include mondo, mysql, odbc, etc.
For example libw1mongo.so.0 would be packaged in w1retap and
w1retap-mongo. I can't see a simple way to get around this.


> - why systemd as runtime dependency?
>

That looks like my mistake, I thought I needed to depend on it given
that I'm shipping a service file that starts the main daemon with
systemd. I have removed that dependency.


> - with compat 10 you can avoid --parallel and --with autoreconf
> 

Excellent, I've changed to compat 10.

> this should be enough for now (and probably now the review is complete)
> 
> last thing about your patch
> 
> -w1->rcfile = strdup("/etc/default/w1retap");
> +w1->rcfile

Bug#791724: RFS: w1retap/1.4.4-1 [ITP] -- Data logger for 1-Wire weather sensors

2016-10-14 Thread Thomas Stewart 
Hi Gianfranco,

Thank you for the comments and suggestions, they are really appreciated.
Apologies for the delay, I have slowly worked through your email on and
off over the past few months. I think I have addressed most of the
issues you mentioned (see my comments below), so I have uploaded a fresh
version to http://mentors.debian.net/package/w1retap.

Thanks again for reviewing the package, I would appreciate any other
comments you have or uploading it if you feel it's ready.

On 01 Apr 2016, at 20:52, Gianfranco Costamagna wrote:
> control:
> "retrieved   data" <-- double space
> std version is 3.9.7 now
> please run wrap-and-sort
> please remove quilt from b-d
> changelog:
> one single changelog entry please
> 
> -rm -f $(CURDIR)/debian/w1retap.1 $(CURDIR)/debian/w1find.1 -> debian/clean 
> might be easier to maintain
> 
> rules:
> dh_auto_install is a no-op please remove

All fixed.

> dh_makeshlibs --noscripts <-- why?

The plugin packages contain .so files, the --noscripts option stops an
ldconfig run when installing. Without it I get a lintian useless
ldconfig run warnings.

> remove quilt

Fixed.

> libw1retap0-odbc.install <-- is that the mysql wrapper?

No, it's a odbc plugin and the mysql plugin is separate. The confusion was
caused by a typo on my part. In anycase, both are now fixed.

> service file:
> ExecStop=/bin/kill $MAINPID
> 
> really needed?

Fixed.

> patches: remove-data-time-macro.patch
> you can dpkg-parsechangelog and export the changelog date an build date.
> (this will make the package reproducible I think)

The current upstream code (src/w1retap.c) uses the "__DATE__" and
"__TIME__" GCC standard macros directly. I don't think
dpkg-parsechangelog can affect these macros. My patch replaces these
macros with __BUILD_DATE__.
 
> question:
> usually libraries are ship in this way
> 
> libfooSONAME shipping libfoo.so.SONAME
> 
> libfoo-dev with an hard dependency on libfooSONAME
> and a libfoo.so symlink to libfoo.so.SONAME and /usr/include/foo
> headers files.
> 
> In your package you are shipping them together
> 
> not an issue, but do you know what you are doing here?
> are them useful and being linked outside the package?
> are them just internal?

The .so files are not useful or used and outside the w1retap, they are
all internal. Thus I agree and have removed all the libw1retap*
packages. They act more like plugins so I now have a main w1retap
package and 5 separate plugin package for each database type.

> lots of stuff (systemd script udev rules) should be upstreamed to me

There are a number of patches that I will send upstream:
 - add-etc-w1retap-conf.patch
 - movetmp.patch
 - remove-data-time-macro.patch 
 - udev rule
 - systemd service
 
> check-all-the-things review:
> codespell --quiet-level=3
> cppcheck -j1 --quiet -f .
> grep -riE 'fixme|todo|hack|xxx' .
> grep -r '/tmp/' .

I did run all of the above and found some issues. Some of the issues
seemed to be more related to actual upstream development rather than
packaging. Most notably predicable file creation in /tmp, which is fixed
in the above mentioned movetmp.patch. Did you spot anything else that
needing fixing?

Regards
--
Tom

Bug#791724: RFS: w1retap/1.4.4-1 [ITP] -- Data logger for 1-Wire weather sensors

2016-01-19 Thread Thomas Stewart 
Dear mentors,

I am looking for a sponsor for my package "w1retap":

* Package name: w1retap
  Version : 1.4.4-1
  Upstream Author : Jonathan Hudson 
* URL : http://www.zen35309.zen.co.uk/wx/tech.html
* License : GPL with some Expat
  Programming Lang: C
  Description : Data logger for 1-Wire weather sensors

It builds those binary packages:
  libw1retap0 - Data logger for 1-Wire weather sensors
  libw1retap0-mongo - Data logger for 1-Wire weather sensors
  libw1retap0-odbc - Data logger for 1-Wire weather sensors
  libw1retap0-pgsql - Data logger for 1-Wire weather sensors
  libw1retap0-sqlite - Data logger for 1-Wire weather sensors
  w1retap - Data logger for 1-Wire weather sensors

To access further information about this package, please visit the following 
URL:
http://mentors.debian.net/package/w1retap

Alternatively, one can download the package with dget using this command:
dget -x http://mentors.debian.net/debian/pool/main/w/w1retap/w1retap_1.4.4-1.dsc

More information about hello can be obtained from 
http://www.zen35309.zen.co.uk/wx/tech.html.

Changes since the last upload:
 w1retap (1.4.4-1) unstable; urgency=medium
 .
   * New upstream release.

Kind Regards
--
Tom

Bug#791724: closing RFS: w1retap/1.4.2-1 [ITP] -- Data logger for 1-Wire weather sensors

2016-01-19 Thread Thomas Stewart 
On 11 Jan 2016, at 21:11, Gianfranco Costamagna wrote:
> On Wed, 02 Dec 2015 16:32:19 + Bart Martens wrote:
> > Package w1retap has been removed from mentors.
> 
> do you still need this package? if so please reupload and I'll review it.

Hi Gianfranco,

Thank you very much for offering to review the w1retap package. I still
use this software and would like it packaged. I have created an updated
package following two minor upstream releases.

I have uploaded it to: http://mentors.debian.net/package/w1retap

Thanks :-)

Regards
--
Tom

Bug#791724: RFS: w1retap/1.4.2-1 [ITP] -- Data logger for 1-Wire weather sensors

2015-07-07 Thread Thomas Stewart 
Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package w1retap:

* Package name: w1retap
  Version : 1.4.2
  Upstream Author : Jonathan Hudson jh+w1re...@daria.co.uk
* URL : http://www.zen35309.zen.co.uk/wx/tech.html
* License : GPL with some Expat
  Programming Lang: C
  Description : Data logger for 1-Wire weather sensors

It builds those binary packages:
  libw1retap0 - Data logger for 1-Wire weather sensors
  libw1retap0-mongo - Data logger for 1-Wire weather sensors
  libw1retap0-odbc - Data logger for 1-Wire weather sensors
  libw1retap0-pgsql - Data logger for 1-Wire weather sensors
  libw1retap0-sqlite - Data logger for 1-Wire weather sensors
  w1retap - Data logger for 1-Wire weather sensors

To access further information about this package, please visit the following 
URL:
http://mentors.debian.net/package/w1retap

Alternatively, one can download the package with dget using this command:
dget -x http://mentors.debian.net/debian/pool/main/w/w1retap/w1retap_1.4.2-1.dsc

More information about hello can be obtained from 
http://www.zen35309.zen.co.uk/wx/tech.html.

Changes since the last upload:
 w1retap (1.4.2-1) unstable; urgency=low
 .
   * Initial release (Closes: #787770)


Kind Regards
--
Tom


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/20150707211753.ga13...@beryl.stewarts.org.uk