Bug#1072906: RFS: markdown-mode/2.6-3 [Team] -- mode for editing Markdown-formatted text files in GNU Emacs
Xiyue Deng writes: > Control: retitle -1 RFS: markdown-mode/2.6-3 [Team] -- mode for editing > Markdown-formatted text files in GNU Emacs > > Xiyue Deng writes: > >> Xiyue Deng writes: >> >>> [[PGP Signed Part:Undecided]] >>> Hi Nicholas, >>> >>> Nicholas D Steeves writes: >>> >>>> Xiyue Deng writes: >>>> >>>> Git pull, then read along with the reply that follows inline. >>>> >>>>>> Xiyue Deng writes: >>>>>> >>>>>>>* Drop unused override_dh_auto_test in d/rules (dh_elpa_test is in >>>>>>> effect) >>>>>> >>>>>> override_dh_auto_test: >>>>>> @echo Using dh_elpa_test to run tests instead of upstream Makefile >>>>>> >>>>>> Used to be useful, because the Makefile tests used to run as well as the >>>>>> dh_elpa_test ones. Dh_elpa_test was also "in effect then"... >>>>>> >>>>> >>>>> I believe dh_elpa_test disables dh_auto_test by default unless it is >>>>> disabled in debian/elpa-test[1]. I think you did this change back in >>>>> this commit[2] back in 2019. On the other hand, it looks like >>>>> dh_auto_test was disabled by dh-elpa even earlier[3]. Maybe you were >>>>> referring to even more back then? Anyway, would be good to figure this >>>>> out. >>>> >>>> Some team members voluntarily accommodate backports and/or >>>> oldstable-backports. Write something like "No longer needed" or >>>> something to that effect, if it's buildable on bookworm and bullseye. >>>> If not buildable, talk to whoever added the B-D. >>>> >>>> If "Drop unnecessary Build-Depends on markdown" were true than discount >>>> shouldn't become a B-D. So there's a major contradiction in your >>>> changelog entries and/or thinking. Likewise, in the interest of >>>> timeliness I'm fixing this myself. Read the updated changelog carefully >>>> and recursively follow any references. Also, consider that if markdown >>>> wasn't a B-D we wouldn't have received this RC bug notifying us of >>>> markdowns removal, and it's probable no one would have noticed until >>>> users complained. That might have been after Trixie's release. If >>>> nothing else, the B-D is worth it for that. >>>> >>> >>> (Here your response was below a past discussion on dh_elpa_test but was >>> really about B-D, and I got a bit confused, but I'll assume the >>> previously quoted texts are not relevant here. I believe your were >>> referring to a later part that discusses B-D.) >>> >>> I'd like to clarify that the contradiction in the changelog was an >>> oversight and I tried to fix that: I realized that `discount' provides a >>> compatible markdown command and should be a suitable replacement of the >>> `markdown' and used that in place of markdown. I tried to remove that >>> entry about dropping, as you can see from my first upload on mentors[1]. >>> It got overwritten due to a later `gbp dch` as I didn't commit that >>> changelog yet and added more work and hence that change was lost. So in >>> retrospect, I realized the early change mentioning that `markdown' is >>> "unnecessary" was incorrect and tried to replace it with `discount', but >>> forgot to remove the earlier entry generated from `gbp dch`. Please >>> also see my previous reply (quoted below) for my analysis on how >>> markdown-mode checks for available commands to process. I guess the >>> better word to describe it is "optional" instead of "unused" indeed, >>> which I tried to remove from d/changelog anyway. >>> >>>> Why should your colleagues give you the time of day (ie: spend any of >>>> their time to review your work) if you systematically refuse to trust >>>> their work? Doing security audits would be a better use >>>> skepticism/suspicion ;) >>>> >>> >>> I hope the previous explanation would clarify that there is no >>> ill-intent to discredit any of the existing work. >>> >>>>>>>* Update debian copyright year in d/copyright >>>>>> >>>>>> -Copyright: 2015-2017 David Bremner >>&g
Bug#1074622: RFS: emacs-dape/0.15.0-1 [ITP] -- Debug Adapter Protocol for Emacs
Control: retitle -1 RFS: emacs-dape/0.15.0-1 [ITP] -- Debug Adapter Protocol for Emacs Friendly ping for sponsoring. Also update the package on mentors to the latest release (0.15.0). Thanks in advance for considering! -- Xiyue Deng
Bug#1081131: RFS: emacs-oauth2/0.17-1 [ITP] -- OAuth 2.0 Authorization Protocol
Friendly ping for sponsoring :) -- Xiyue Deng
Bug#1074622: RFS: emacs-dape/0.13.0-1 [ITP] -- Debug Adapter Protocol for Emacs
Phil Wyett writes: > Xiyue, > > Preamble... > > Thank you for taking the time to create this package and your contribution > to the Debian project. > > The review below is for assistance. This review is offered to help > package submitters to Debian mentors inorder to improve their packages > prior to possible sponsorship into Debian. There is no obligation on behalf > of the submitter to make any alterations based upon information provided > in the review. > > Review... > > 1. Build[1]: Good > > 2. Lintian[2]: Good > > 3. Licenses (lrc[3]): Good > > 4. Watch file (uscan --force-download): Good > > 5. Build Twice (sudo pbuilder build --twice .dsc): Good > > 6. Reproducible builds (reporotest)[3]: Good > > 7. Install (No previous installs): Good > > 8. Upgrade (Over previous installs if any): N/A > > Summary... > > I believe emacs-dape is ready for sponsorship/upload. Could a Debian > Developer (DD) with available free time, please review this package and > upload if you feel it is ready and appropriate for the distribution. > > Regards > > Phil > > [1] Using: > * pbuilder - https://wiki.ubuntu.com/PbuilderHowto. > * https://wiki.debian.org/PbuilderTricks > and > * sbuild - https://wiki.debian.org/sbuild. > > [2] Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, > *.changes, *.buildinfo). Each can throw up different, so be thorough. > > [3] 'lrc' from 'licenserecon' is located in Debian testing and newer. > > [4] https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method > > -- > "I play the game for the game’s own sake" > > Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans > > -- > > Internet Relay Chat (IRC): kathenas > > Website: https://kathenas.org > > Instagram: https://instagram.com/kathenasorg/ > > Buy Me A Coffee: https://buymeacoffee.com/kathenasorg > > -- > Friendly ping for sponsoring :) -- Xiyue Deng
Bug#1071209: RFS: emacs-bazel-mode/0.0~git20230919.769b30d-1 [ITP] -- Bazel support for GNU Emacs
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package "emacs-bazel-mode": * Package name : emacs-bazel-mode Version : 0.0~git20230919.769b30d-1 Upstream contact : Google LLC * URL : https://github.com/bazelbuild/emacs-bazel-mode * License : Apache-2.0 * Vcs : https://salsa.debian.org/emacsen-team/emacs-bazel-mode Section : editors The source builds the following binary packages: elpa-bazel-mode - Bazel support for GNU Emacs To access further information about this package, please visit the following URL: https://mentors.debian.net/package/emacs-bazel-mode/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/e/emacs-bazel-mode/emacs-bazel-mode_0.0~git20230919.769b30d-1.dsc Changes for the initial release: emacs-bazel-mode (0.0~git20230919.769b30d-1) unstable; urgency=medium . * Initial release (Closes: #1071204) Regards, -- Xiyue Deng
Bug#1069620: RFS: lua-mode/20231023~git-1 -- Emacs major-mode for editing Lua programs
Hi Tobias, Tobias Frost writes: > Hi Xiyue, > > when packaging a git snapshot, I feel this should be indicated in the > upstream version that it is based on the old one, something like > + > > In your case I'd 20210802+git20231023 as upstream version. > > Long time ago I did something like that for dhewm3, you > can see the watch file here: > https://salsa.debian.org/games-team/dhewm3/-/blob/debian/1.5.0+git20181221+dfsg-1/debian/watch?ref_type=tags > > (not marking moreinfo, as other people might see that differently.) Thanks for your comments! I actually also thought about this but ended up not following that idea because it will end up with 3 different versions based on dates: * 20210802 which is the last tagged version[1], * 20221027 which is specified in the upstream source[2] and will end up in the installed elpa package directory but was never tagged, and * 20231023 which is the date of the latest upstream commit[3] when sending this email. I think 20210802+git20231023. follows the current practice but will be *very* confusing when user will find that the package is installed at /usr/share/emacs/site-lisp/elpa/lua-mode-20221027. I chose 20231023~git as a compromise just to avoid having too many dates there, which is still possible to upgrade to 20231023 should that be tagged one day. I think the next choice could be 20221027+git20231023. just so there is one less date to deal with. Wdyt? [1] https://github.com/immerrr/lua-mode/tags [2] https://github.com/immerrr/lua-mode/blob/master/lua-mode.el#L15 [3] https://github.com/immerrr/lua-mode/commit/d074e4134b1beae9ed4c9b512af741ca0d852ba3 > > -- > tobi > > On Sun, Apr 21, 2024 at 10:02:48AM -0700, Xiyue Deng wrote: >> Package: sponsorship-requests >> Severity: normal >> >> Dear mentors, >> >> I am looking for a sponsor for my package "lua-mode": >> >> * Package name : lua-mode >>Version : 20231023~git-1 >>Upstream contact : immerrr >> * URL : https://github.com/immerrr/lua-mode >> * License : GPL-3+ >> * Vcs : https://salsa.debian.org/emacsen-team/lua-mode >>Section : lisp >> >> The source builds the following binary packages: >> >> elpa-lua-mode - Emacs major-mode for editing Lua programs >> >> To access further information about this package, please visit the following >> URL: >> >> https://mentors.debian.net/package/lua-mode/ >> >> Alternatively, you can download the package with 'dget' using this command: >> >> dget -x >> https://mentors.debian.net/debian/pool/main/l/lua-mode/lua-mode_20231023~git-1.dsc >> >> Changes since the last upload: >> >> lua-mode (20231023~git-1) unstable; urgency=medium >> . >>* Sync to latest upstream snapshot (d074e41) >>* Drop the patch applied upstream and reorder the remaining patch >>* Update upstream license to GPL-3+ following upstream change >>* Add a missing upstream copyright holder >> >> Regards, >> -- >> Xiyue Deng >> -- Xiyue Deng
Bug#1054420: RFS: js2-mode/0.0~git20230628.79bc78d-1 [RC] [Team] -- Emacs mode for editing Javascript programs
Control: retitle -1 RFS: js2-mode/0.0~git20240418.9b90d31-1 [RC] [Team] -- Emacs mode for editing Javascript programs Hi, A new snapshot was available and I have updated the package according with a few more improvements. Please find the latest package on mentors[1] and changes on salsa[2] (sans the finalizing commit.) TIA! [1] https://mentors.debian.net/package/js2-mode/ [2] https://salsa.debian.org/emacsen-team/js2-mode -- Xiyue Deng
Bug#1070131: RFS: emacs-cfrs/1.6.0-1 [ITP] -- Child-frame based read-string for Emacs
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package "emacs-cfrs": * Package name : emacs-cfrs Version : 1.6.0-1 Upstream contact : Alexander Miller * URL : https://github.com/Alexander-Miller/cfrs * License : GPL-3+ * Vcs : https://salsa.debian.org/emacsen-team/emacs-cfrs Section : editors The source builds the following binary packages: elpa-cfrs - Child-frame based read-string for Emacs To access further information about this package, please visit the following URL: https://mentors.debian.net/package/emacs-cfrs/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/e/emacs-cfrs/emacs-cfrs_1.6.0-1.dsc Changes for the initial release: emacs-cfrs (1.6.0-1) unstable; urgency=medium . * Initial release (Closes: #1070096) Note that this is a required dependency of newer treemacs versions which I plan to request for RFS soon after this is sponsored. Regards, -- Xiyue Deng
Bug#1065302: RFS: elpa-rust-mode/1.0.5+git20240415.e54bbae-1 -- Major Emacs mode for editing Rust source code)
Control: retitle -1 RFS: elpa-rust-mode/1.0.5+git20240415.e54bbae-1 -- Major Emacs mode for editing Rust source code Another sync to latest snapshot that fixes precedence with rust-ts-mode. (Mentors[1], team repo[2].) PTAL, TIA! -- Xiyue Deng [1] https://mentors.debian.net/package/elpa-rust-mode/ [2] https://salsa.debian.org/emacsen-team/rust-mode
Bug#1069620: RFS: lua-mode/20231023~git-1 -- Emacs major-mode for editing Lua programs
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "lua-mode": * Package name : lua-mode Version : 20231023~git-1 Upstream contact : immerrr * URL : https://github.com/immerrr/lua-mode * License : GPL-3+ * Vcs : https://salsa.debian.org/emacsen-team/lua-mode Section : lisp The source builds the following binary packages: elpa-lua-mode - Emacs major-mode for editing Lua programs To access further information about this package, please visit the following URL: https://mentors.debian.net/package/lua-mode/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/l/lua-mode/lua-mode_20231023~git-1.dsc Changes since the last upload: lua-mode (20231023~git-1) unstable; urgency=medium . * Sync to latest upstream snapshot (d074e41) * Drop the patch applied upstream and reorder the remaining patch * Update upstream license to GPL-3+ following upstream change * Add a missing upstream copyright holder Regards, -- Xiyue Deng
Bug#1055431: RFS: scala-mode-el/1:1.1.0+git20221025.5d7cf21-1 [RC] [Team] -- Emacs major mode for editing scala source code
Control: retitle -1 RFS: scala-mode-el/1:1.1.0+git20240113.4c6d636-1 [RC] [Team] -- Emacs major mode for editing scala source code Xiyue Deng writes: > Hi, > > Xiyue Deng writes: > >> Nicholas D Steeves writes: >> >>> Hi, >>> >>> Paul Wise writes: >>> >>>> On Mon, 2023-12-04 at 02:28 -0800, Xiyue Deng wrote: >>>> >>>>> I think dh_auto_clean is the right place, because the build failure is >>>>> because that the clean target requires the existence of >>>>> scala-mode-pkg.el, which is generated by Cask. As we don't have Cask, >>>>> we need to provide this before dh_auto_clean runs. >>> >>> The generation of this metadata, and file, is one of dh_elpa's primary >>> functions. See the section of the dh_elpa man page that discusses >>> DEB_VERSION_UPSTREAM. >> >> Ah I see what you mean: as long as dh_elpa can detect the version >> correctly we don't need to provide an actual *-pkg.el file and can just >> let dh_elpa generate it, which also avoids the potential policy >> violation Paul pointed out. >> >> So now I make override_dh_auto_clean to call dh_elpa to generate this >> file for use. However, as the generated file is "buried" pretty deep in >> the generated directory, the command becomes pretty long, but it works. >> Admittedly that requiring a generated file during clean is pretty exotic >> and I haven't encountered it elsewhere (yet) which is good. >> >> New handling strategy pushed to team repo. PTAL. >> >>> >>> Read Policy §4.9 closely; Cask cannot be used. >>> >>> Grep the buildlog for "dh_" and if you'd like to see a more >>> comprehensive list of applicable entry points in the sequence, try >>> >>> $ dh binary-indep --no-act >>> >>> It's also worth reading the dh man page. >> >> Ack. >> >>> >>>> I think it is against ftp-master rules to have generated files >>>> present that can't be built using only tools from Debian main. >>> >>> Yes, and thank you for bringing this up. >>> >>>> So I think you would need to package Cask first? >>> >>> Cask is not relevant nor needed, and dh_elpa is used. Whenever this >>> topic comes up on IRC, new contributors are briefed and are additionally >>> referred to the RFP for Cask, where the unsuitability of this type of >>> tool for Debian packaging is discussed (#837922). It's also worth >>> noting that dh_elpa was written by people by current and/or past members >>> of the Debian TC. >>> >>> Xiyue Deng writes: >>> >>>> Cask and similar tools like Eask and Eldev are tools that automatically >>>> install dependencies of an Emacs addon package, which doesn't use and >>>> circumvents the system package management. I think the Emacsen team >>>> chooses not to package those tools and prefers using dh-elpa for the >>>> job, and may override build target to avoid using those tools. >>> >>> If you're familiar with the concept of "hats", then when you're working >>> on debian/* you need to put on your Debian packaging hat, and when >>> you're working on !(debian/*) you use your upstream >>> development/debugging/packaging hat. These tools are not relevant to >>> Debian packaging and referring to them is not useful for describing >>> packaging problems or decisions; there will always be a more direct and >>> useful description. >> >> I think those external tools are not completely irrelevant but just in >> the sense that we do it the Debian way. Usually they provide two types >> of functions: 1) automatic dependency management, and 2) automatic file >> generation required for testing and distribution through elpa. In >> Debian, the former is handled by apt, and the latter by dh_elpa, and we >> take effort to make sure they behave the same. >> >>> >>> Cheers, >>> Nicholas >>> It looks like the bug was archived so the previous mail didn't reach BTS. So unarchived, reopened, and retitle the bug with newer snapshot, and also resending the following from previous message. > > With the release of the new policy version, I have done some more clean > up to the package and update team repo and mentors. PTAL. TIA! -- Xiyue Deng signature.asc Description: PGP signature
Bug#1069078: RFS: lua-mode/20210802-4 [RC] [Team] -- Emacs major-mode for editing Lua programs
Sean Whitton writes: > Hello, > > On Thu 18 Apr 2024 at 06:24pm -07, Xiyue Deng wrote: > >> Sean Whitton writes: >> >>> control: tag -1 + moreinfo >>> >>> Hello Xiyue, >>> >>> Please explain the autopkgtest_keep change. Remember that autopkgtests >>> are to test the installed package. If you need to keep the .el files, >>> it must be for some reason other than because the test suite actually >>> just tests those. >>> >> >> I think this is another example of buttercup tests that requires source >> .el files to run. I'll probably open a bug on buttercup to see whether >> this is required for buttercup. Meanwhile I think it'd probably be >> better to just disable autopkgtest as the tests are already run as part >> of the build process. > > I agree. It is important not to use autopkgtest_keep without being sure > it's the right answer. > So it turns out using "disable" in d/elpa-test also disable dh_elpa_test in d/rules so that the test is not run as part of the package building, which would be suboptimal in that we don't run any test at all. I'll try to see a way to disable it only in autopkgtest in dh-elpa. On the other hand, it looks like I misjudged the situation of the buttercup tests that with "autopkgtest_keep = test/*" it just works, which is much better than disabling. >>> You've removed the Built-Using with the justification that it's an >>> arch:all package, but that doesn't make sense; Built-Using is for >>> licensing reasons, and may well be applicable to an arch:all package (I >>> think this came up before with one of your uploads?). >> >> Ah I was following the suggestions of Lintian which said it cannot be >> used by arch:all packages which is probably wrong. > > See #999785. > Ack. I also checked that bug before and wondering why that lintian tag is still enabled. Hopefully Bug#1069256 will move things forward. >> On the other hand, on a closer look at the policy regarding >> Built-Using on section 7.8[1], it has the following passage: >> >> , >> | This field should be used only when there are license or DFSG >> | requirements to retain the referenced source packages. It should not be >> | added solely as a way to locate packages that need to be rebuilt against >> | newer versions of their build dependencies. >> ` >> >> I checked that lua-mode is of GPL-2+[2], and of all its dependencies >> lua5.3 is of MIT which is compatible with GPL, and the rest are all GPL >> 2+ or 3+, so I don't see a license or DFSG need to add this Built-Using >> requirement. The change was introduced in [3] but it was part of the >> modernization effort so there is no direct justification of adding the >> field. May be I'm missing something here? > > It sounds like it shouldn't have been introduced. So you can remove it > based on your reading of Policy, and briefly note your reasoning in > d/changelog. Updated d/changelog accordingly. Also took this opportunity to add myself to uploaders. That way we don't have to deal with the "team upload" complications for sponsors. Mentors and team repo are both updated. PTAL. Thanks! -- Xiyue Deng signature.asc Description: PGP signature
Bug#1069078: RFS: lua-mode/20210802-4 [RC] [Team] -- Emacs major-mode for editing Lua programs
Sean Whitton writes: > control: tag -1 + moreinfo > > Hello Xiyue, > > Please explain the autopkgtest_keep change. Remember that autopkgtests > are to test the installed package. If you need to keep the .el files, > it must be for some reason other than because the test suite actually > just tests those. > I think this is another example of buttercup tests that requires source .el files to run. I'll probably open a bug on buttercup to see whether this is required for buttercup. Meanwhile I think it'd probably be better to just disable autopkgtest as the tests are already run as part of the build process. > You've removed the Built-Using with the justification that it's an > arch:all package, but that doesn't make sense; Built-Using is for > licensing reasons, and may well be applicable to an arch:all package (I > think this came up before with one of your uploads?). Ah I was following the suggestions of Lintian which said it cannot be used by arch:all packages which is probably wrong. On the other hand, on a closer look at the policy regarding Built-Using on section 7.8[1], it has the following passage: , | This field should be used only when there are license or DFSG | requirements to retain the referenced source packages. It should not be | added solely as a way to locate packages that need to be rebuilt against | newer versions of their build dependencies. ` I checked that lua-mode is of GPL-2+[2], and of all its dependencies lua5.3 is of MIT which is compatible with GPL, and the rest are all GPL 2+ or 3+, so I don't see a license or DFSG need to add this Built-Using requirement. The change was introduced in [3] but it was part of the modernization effort so there is no direct justification of adding the field. May be I'm missing something here? -- Xiyue Deng [1] https://www.debian.org/doc/debian-policy/ch-relationships.html#additional-source-packages-used-to-build-the-binary-built-using [2] Upstream switched to GPL-3+ in 2022 but we haven't packaged that yet. [3] https://salsa.debian.org/emacsen-team/lua-mode/-/commit/2e207a6835a3899f6eba0675c4763c1757335bcc signature.asc Description: PGP signature
Bug#1069078: Acknowledgement (RFS: lua-mode/20210802-4 [RC] [Team] -- Emacs major-mode for editing Lua programs)
Forwarding to the Debian Emacsen Team list. Start of forwarded message From: Xiyue Deng To: sub...@bugs.debian.org Subject: RFS: lua-mode/20210802-4 [RC] [Team] -- Emacs major-mode for editing Lua programs Date: Mon, 15 Apr 2024 21:06:11 -0700 Package: sponsorship-requests Severity: important Dear mentors, I am looking for a sponsor for my package "lua-mode": * Package name : lua-mode Version : 20210802-4 Upstream contact : immerrr * URL : https://github.com/immerrr/lua-mode * License : GPL-2+ * Vcs : https://salsa.debian.org/emacsen-team/lua-mode Section : lisp The source builds the following binary packages: elpa-lua-mode - Emacs major-mode for editing Lua programs To access further information about this package, please visit the following URL: https://mentors.debian.net/package/lua-mode/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/l/lua-mode/lua-mode_20210802-4.dsc Changes since the last upload: lua-mode (20210802-4) unstable; urgency=medium . * Team upload * Mark lexical binding patch as Forwarded and Applied-Upstream * Add patch to use eval in lexical scope to fix tests (Closes: #1069073) * Keep source *.el in autopkgtest to make it work * Add Upstream-Contact in d/copyright * Update homepage to github page in d/control (old link no longer works) * Set Rules-Requires-Root to no in d/control * Drop Built-Using from arch:all package in d/control * Trim trailing whitespace in d/changelog * Bump debhelper from old 10 to 13 * Set debhelper-compat version in Build-Depends * Set upstream metadata fields: Bug-Database, Bug-Submit, Repository, Repository-Browse * Update Standards-Version to 4.7.0; no change needed * Modernize d/watch with substitute strings to be more robust Regards, -- Xiyue Deng End of forwarded message
Bug#1069078: RFS: lua-mode/20210802-4 [RC] [Team] -- Emacs major-mode for editing Lua programs
Package: sponsorship-requests Severity: important Dear mentors, I am looking for a sponsor for my package "lua-mode": * Package name : lua-mode Version : 20210802-4 Upstream contact : immerrr * URL : https://github.com/immerrr/lua-mode * License : GPL-2+ * Vcs : https://salsa.debian.org/emacsen-team/lua-mode Section : lisp The source builds the following binary packages: elpa-lua-mode - Emacs major-mode for editing Lua programs To access further information about this package, please visit the following URL: https://mentors.debian.net/package/lua-mode/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/l/lua-mode/lua-mode_20210802-4.dsc Changes since the last upload: lua-mode (20210802-4) unstable; urgency=medium . * Team upload * Mark lexical binding patch as Forwarded and Applied-Upstream * Add patch to use eval in lexical scope to fix tests (Closes: #1069073) * Keep source *.el in autopkgtest to make it work * Add Upstream-Contact in d/copyright * Update homepage to github page in d/control (old link no longer works) * Set Rules-Requires-Root to no in d/control * Drop Built-Using from arch:all package in d/control * Trim trailing whitespace in d/changelog * Bump debhelper from old 10 to 13 * Set debhelper-compat version in Build-Depends * Set upstream metadata fields: Bug-Database, Bug-Submit, Repository, Repository-Browse * Update Standards-Version to 4.7.0; no change needed * Modernize d/watch with substitute strings to be more robust Regards, -- Xiyue Deng
Bug#1068605: RFS: web-mode/17.3.13-1 [Team] -- major emacs mode for editing web templates
Hi Nicholas, Xiyue Deng writes: > Nicholas D Steeves writes: > > [..snip..] > >>>>>>* Fix issues in d/copyright >>>>>> - Clarify license to be GPL-3+ to be consistent with upstream >> >> This is unclear. Which licence was it before, and whose license are you >> talking about? Web-mode is a non-native package and debian/* is >> separate from the upstream source. Also, what does it mean to clarify a >> license? >> > > It used to be GPL-2, and I'm talking about the upstream license. The > upstream updated it to GPL-3 in 2022, which was actually after Thomas > last worked on the package. I think maybe I should change the wording > to "Update license to GPL-3+ following upstream changes"[5] > >>>>>> - Update copyright year info for upstream >>>>>> - Add copyright info for debian/* >> >> You added a license grant for debian/* where there was previously none >> with no explanation, notes, nor justification. Are you sure you have >> the right to do this? Contact debian-legal and ask them for a patch >> review of your intended changes. >> > > I checked upstream contributor list and didn't find the original > maintainer in it, so I believe it's a mistake that there is no separate > copyright section for debian/* which Thomas worked on and should be > attributed to him. But I agree that I should consult debian-legal@ on > how to properly handle this. I have sent a mail there[6] and CCed you. > Let's wait for an reply. > I have got some replies on debian-legal@l.d.o from Richard[1] and Soren[2] and both suggested that using GPL-3+ for upstream and GPL-2+ for debian/* is a good path forward. Soren further suggested the possibility of upgrading debian/* to GPL-3+ as GPL-2+ is compatible, but I don't think I'll go this round at this time as I will need to be added to the copyright list, which I might not be doing this time. These suggestions actually are aligned with my change at [3]. PTAL. TIA! -- Xiyue Deng [1] https://lists.debian.org/debian-legal/2024/04/msg2.html [2] https://lists.debian.org/debian-legal/2024/04/msg5.html [3] https://salsa.debian.org/emacsen-team/web-mode/-/commit/9a0a2ac9eb56a11bdeab7a98a42e5726fbb0e967 signature.asc Description: PGP signature
Bug#1068958: RFS: elpa-snakemake/2.0.0+git20231210.4ad41da-1 [RC] [Team] -- Run Snakemake workflows from Emacs
Control: retitle -1 RFS: elpa-snakemake/2.0.0+git20231210.4ad41da-1 [RC] [Team] -- Run Snakemake workflows from Emacs Some obvious silly copy-and-paste error in the title. Now it should be fixed :P -- Xiyue Deng
Bug#1068958: Xiyue Deng
Package: sponsorship-requests Severity: important Dear mentors, I am looking for a sponsor for my package "elpa-snakemake": * Package name : elpa-snakemake Version : 2.0.0+git20231210.4ad41da-1 Upstream contact : Kyle Meyer * URL : https://git.kyleam.com/snakemake-mode/about * License : GPL-3+ * Vcs : https://salsa.debian.org/emacsen-team/elpa-snakemake Section : editors The source builds the following binary packages: elpa-snakemake-mode - provides syntax highlighting for snakekmake files in emacs elpa-snakemake - Run Snakemake workflows from Emacs To access further information about this package, please visit the following URL: https://mentors.debian.net/package/elpa-snakemake/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/e/elpa-snakemake/elpa-snakemake_2.0.0+git20231210.4ad41da-1.dsc Changes since the last upload: elpa-snakemake (2.0.0+git20231210.4ad41da-1) unstable; urgency=medium . * Team upload * Sync to latest upstream snapshot (4ad41da) (Closes: #1068956) * Disable autopkgtest as the ERT tests require a writable $HOME * Modernize d/watch with substitute strings to be more robust * Add a version header in snakemake.el to workaround dh-elpa upstream version handling limitation * Commit Debian 3.0 (quilt) metadata * Trim trailing whitespace * Set upstream metadata fields: Repository * Update standards version to 4.7.0, no changes needed Regards, -- Xiyue Deng
Bug#1068564: RFS: emacs-buttercup/1.35-1 -- behaviour-driven testing for Emacs Lisp packages
Jeremy Sowden writes: > On 2024-04-12, at 19:50:58 +0800, Sean Whitton wrote: >> On Fri 12 Apr 2024 at 12:44pm +01, Jeremy Sowden wrote: >> > On 2024-04-12, at 17:53:15 +0800, Sean Whitton wrote: >> > > Do you have your 1.34 upload of buttercup in git, please? >> > >> > Yup, it's all on Salsa. >> >> Er. I got confused, then, didn't I? Should this RFS be closed? > > I uploaded 1.34, and that is what is currently in the emacsen-team repo. > This bug is for 1.35, which is currently sitting in Xiyue's fork, by the > looks of it. I haven't looked at this yet. I can pick it up over the > week-end. > > J. > So I did it again (pushed to my fork but forgot to push to team repo :P) Just pushed there as well. Please take another look. Thanks! -- Xiyue Deng signature.asc Description: PGP signature
Bug#1054420: RFS: js2-mode/0.0~git20230628.79bc78d-1 [RC] [Team] -- Emacs mode for editing Javascript programs
Control: retitle -1 RFS: js2-mode/0.0~git20240310.e92829d-1 [RC] [Team] -- Emacs mode for editing Javascript programs Hi, A new snapshot was available and I have updated the package according with a few more improvements. Please find the latest package on mentors[1] and changes on salsa[2] (sans the finalizing commit.) TIA! -- Xiyue Deng [1] https://mentors.debian.net/package/js2-mode/ [2] https://salsa.debian.org/emacsen-team/js2-mode
Bug#1068847: RFS: circe/2.13-1 [RC] [Team] -- client for IRC in Emacs
Package: sponsorship-requests Severity: important Dear mentors, I am looking for a sponsor for my package "circe": * Package name : circe Version : 2.13-1 Upstream contact : Jorgen Schäfer * URL : https://github.com/jorgenschaefer/circe * License : GPL-2+, BSD-3-clause, GPL-3+ * Vcs : https://salsa.debian.org/cgit/emacsen-team/circe.git Section : net The source builds the following binary packages: elpa-circe - client for IRC in Emacs To access further information about this package, please visit the following URL: https://mentors.debian.net/package/circe/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/c/circe/circe_2.13-1.dsc Changes since the last upload: circe (2.13-1) unstable; urgency=medium . * Team upload * New upstream release * Refresh patches using quilt-fixup * Backport patch adding lexical-cast to test-tracking.el to fix tests (Closes: #1068754) * Drop Built-Using on arch:all binary package * Modernize d/watch with special strings to be more robust * Use secure copyright file specification URI. * debian/copyright: use spaces rather than tabs to start continuation lines. * Bump debhelper from old 10 to 13. * Set debhelper-compat version in Build-Depends. * Set upstream metadata fields: Bug-Database, Bug-Submit, Repository-Browse. * Update standards version to 4.7.0, no changes needed. * Add Upstream-Contact in d/copyright * Add "Rules-Requires-Root: no" in d/control Regards, -- Xiyue Deng
Bug#1068605: RFS: web-mode/17.3.13-1 [Team] -- major emacs mode for editing web templates
Nicholas D Steeves writes: > reopen 1068605 > owner 1068605 ! > thanks > > Hi, > > Sorry I didn't ask this sooner, but would you prefer if I call you Deng, > or Xiyue, or something else? Conventions and understanding vary a lot > from place to place, after all. No worries! My first name is Xiyue, but I acknowledge that this is probably difficult to pronounce in non-Asian countries or even outside of China, so feel free to call me Deng, or even my code name "manphiz" :) > > Xiyue Deng writes: > >> Thanks for pointing out #1019031! Totally missed it. I'll opt for >> option 1 obviously. Updated team repo and mentors accordingly. > > You're welcome, and thank you. On a related note, have you read the > definitions for source and binary packages? > > #1019031 was filed against src:web-mode, so was hidden from the > bin:elpa-web-mode view. On the BTS the src:package view will display > bugs that affect each binary package as well as the src:package. §4 of > Policy has the definition, and here is another good resource: > > https://wiki.debian.org/Packaging/SourcePackage > Actually I should have noticed it through the tracker page[1], which has a panel showing all bugs reported against all source and binary packages. >> Also, accordingly to this comment from Tobias[1] it looks like there are >> opinions that prefer to reuse existing RFS bugs instead of filing new >> ones. Do you think it's OK to reopen this one? > > There are also people who maintain the opposite position, but in the > spirit of harmony I've reopened this bug. [edit: Be careful about only > waiting a day and then going ahead and doing something without having > received a reply, because when you "ask" for something, but then don't > actually wait for a reply, it can make you look disingenuous and/or > impatient and/or pushy.] > I acted fast this time as this is a RFS bug so by reopening I'm not overriding any other people's work and it gives me a higher chance to find a potential sponsor faster. But I acknowledge the concern you pointed out and will be cautious in future. (And I get you as a reviewer which is better than I expected and I'd say it "worked" in my favor :P) > Onto the review: > >>>>>* New upstream release > > Push the upstream tag to salsa, and find a way to mitigate this issue in > the future. > Thanks for pointing this out, and this is something that confuses me. According to the dgit-maint-merge(7) workflow, one should have a upstream branch tracking upstream git repo directly, so that when you merge a tagged release "git deborig" can directly use upstream tags to create the tarball. On the other hand, if we have salsa CI set up there is no upstream tag on salsa so it probably will fail at "git deborig" stage. Still, if I read the dgit-maint-merge workflow correctly (I could be wrong), it only requires a "upstream/%(version)s" tag when the upstream only releases tarballs or when we want to package a snapshot. So I'm not sure whether we always want to have "upstream/%(version)s" tags. Would like to hear your opinion on this. >>>>>* Set upstream metadata fields: Bug-Database, Bug-Submit, >>>>> Repository-Browse >>>>>* Update standards version to 4.6.2; no changes needed > > Update this, since a new Policy version was recently released. Did you > already work through the upgrade checklist stepwise, starting from > 4.3.0? > Yes, I reviewed the policy upgrading checklist[2] and there should not be any changes required (actually from 4.5.0 when Thomas last worked on it). The same applies to 4.7.0 which I've updated to in [3]. > "debian-devel-announce" is a low traffic list that will keep you > appraised of stuff like this. > Ack, and glad I've already subscribed. Just that I worked on web-mode a bit earlier than the announcement. >>>>>* Use https link of homepage in d/control >>>>>* Modernize d/watch using special substitute strings to be more >>>>>robust > > I'm happy to see this clear, concise, and useful phrasing. If you have > any pending not-yet-uploaded work that doesn't use this, please update > it. If you're interested in a nitpick, the key term is "substitution > strings" and not "[special] substitute strings" (see the manpages for > uscan and deb-substvars as well as codesearch.debian.net). > Ack. Dropping the "special" part in changelog[4]. >>>>>* Fix issues in d/copyright >>>>> - Clarify license to be GPL-3+ to be consistent with upstr
Bug#1068605: RFS: web-mode/17.3.13-1 [Team] -- major emacs mode for editing web templates
Control: reopen -1 Xiyue Deng writes: > Hi Nicholas, > > Nicholas D Steeves writes: > >> Nicholas D Steeves writes: >> >>> This package cannot be uploaded without a human Uploader. See #1019031 >>> and current git history for more info. Either >>> >>> 1. Add yourself to Uploaders >> >> Yes, this requires a changelog entry too, in case that wasn't obvious. >> > > Thanks for pointing out #1019031! Totally missed it. I'll opt for > option 1 obviously. Updated team repo and mentors accordingly. > > Also, accordingly to this comment from Tobias[1] it looks like there are > opinions that prefer to reuse existing RFS bugs instead of filing new > ones. Do you think it's OK to reopen this one? I took the liberty to opt for reopening. Thanks! -- Xiyue Deng signature.asc Description: PGP signature
Bug#1065302: Acknowledgement (RFS: elpa-rust-mode/1.0.5+git20240301.6d86af4-1 -- Major Emacs mode for editing Rust source code)
Control: retitle -1 RFS: elpa-rust-mode/1.0.5+git20240329.b2b18aa-1 -- Major Emacs mode for editing Rust source code Now synced to the latest snapshot that adds support for 29.3. Team repo[1] and mentors[2] are updated accordingly. PTAL. -- Xiyue Deng [1] https://salsa.debian.org/emacsen-team/rust-mode [2] https://mentors.debian.net/package/elpa-rust-mode/
Bug#1068687: RFS: activities-el/0.7-1 [ITP] -- Save/restore sets of windows, tabs/frames, and their buffers in Emacs
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package "activities-el": * Package name : activities-el Version : 0.7-1 Upstream contact : Adam Porter * URL : https://github.com/alphapapa/activities.el * License : GPL-3+ * Vcs : https://salsa.debian.org/emacsen-team/activities-el Section : editors The source builds the following binary packages: elpa-activities - Save/restore sets of windows, tabs/frames, and their buffers in Emacs To access further information about this package, please visit the following URL: https://mentors.debian.net/package/activities-el/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/a/activities-el/activities-el_0.7-1.dsc Changes for the initial release: activities-el (0.7-1) unstable; urgency=medium . * Initial release (Closes: #1068677). Regards, -- Xiyue Deng
Bug#1068605: RFS: web-mode/17.3.13-1 [Team] -- major emacs mode for editing web templates
Hi Nicholas, Nicholas D Steeves writes: > Nicholas D Steeves writes: > >> This package cannot be uploaded without a human Uploader. See #1019031 >> and current git history for more info. Either >> >> 1. Add yourself to Uploaders > > Yes, this requires a changelog entry too, in case that wasn't obvious. > Thanks for pointing out #1019031! Totally missed it. I'll opt for option 1 obviously. Updated team repo and mentors accordingly. Also, accordingly to this comment from Tobias[1] it looks like there are opinions that prefer to reuse existing RFS bugs instead of filing new ones. Do you think it's OK to reopen this one? -- Xiyue Deng [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1067127#15 signature.asc Description: PGP signature
Bug#1068605: RFS: web-mode/17.3.13-1 [Team] -- major emacs mode for editing web templates
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "web-mode": * Package name : web-mode Version : 17.3.13-1 Upstream contact : François-Xavier Bois * URL : https://web-mode.org * License : GPL-3+ * Vcs : https://salsa.debian.org/emacsen-team/web-mode Section : lisp The source builds the following binary packages: elpa-web-mode - major emacs mode for editing web templates To access further information about this package, please visit the following URL: https://mentors.debian.net/package/web-mode/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/w/web-mode/web-mode_17.3.13-1.dsc Changes since the last upload: web-mode (17.3.13-1) unstable; urgency=medium . * Team upload * New upstream release * Set upstream metadata fields: Bug-Database, Bug-Submit, Repository-Browse * Update standards version to 4.6.2; no changes needed * Use https link of homepage in d/control * Modernize d/watch using special substitute strings to be more robust * Fix issues in d/copyright - Clarify license to be GPL-3+ to be consistent with upstream - Update copyright year info for upstream - Add copyright info for debian/* - Add Upstream-Contact Regards, -- Xiyue Deng
Bug#1059065: Acknowledgement (RFS: lsp-mode/8.0.0+git20231219.2cdb9bc-1 [RC] -- Emacs client/library for the Language Server Protocol)
Control: retitle -1 RFS: lsp-mode/9.0.0-1 [RC] -- Emacs client/library for the Language Server Protocol A new tagged version was released upstream and I have updated both the team repository[1] and the package on mentors[2]. Please review and sponsor. TIA! -- Xiyue Deng [1] https://salsa.debian.org/emacsen-team/lsp-mode [2] https://mentors.debian.net/package/lsp-mode/
Bug#1068564: RFS: emacs-buttercup/1.35-1 -- behaviour-driven testing for Emacs Lisp packages
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "emacs-buttercup": * Package name : emacs-buttercup Version : 1.35-1 Upstream contact : Jorgen Schaefer * URL : https://github.com/jorgenschaefer/emacs-buttercup/ * License : GFDL-1.2+ or CC-BY-SA-3.0, GPL-3+ * Vcs : https://salsa.debian.org/emacsen-team/emacs-buttercup Section : lisp The source builds the following binary packages: elpa-buttercup - behaviour-driven testing for Emacs Lisp packages To access further information about this package, please visit the following URL: https://mentors.debian.net/package/emacs-buttercup/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/e/emacs-buttercup/emacs-buttercup_1.35-1.dsc Changes since the last upload: emacs-buttercup (1.35-1) unstable; urgency=medium . * New upstream release * Add myself to uploaders Regards, -- Xiyue Deng
Bug#1068558: [Xiyue Deng] RFS: flycheck/34.1-1 -- modern on-the-fly syntax checking for Emacs - documentation
Forwarding to Debian Emacsen Team mailing list.
Start of forwarded message
From: Xiyue Deng
To: sub...@bugs.debian.org
Subject: RFS: flycheck/34.1-1 -- modern on-the-fly syntax checking for Emacs
- documentation
Date: Sun, 07 Apr 2024 02:19:21 -0700
Package: sponsorship-requests
Severity: normal
Dear mentors,
I am looking for a sponsor for my package "flycheck":
* Package name : flycheck
Version : 34.1-1
Upstream contact : Bozhidar Batsov
* URL : https://www.flycheck.org/
* License : CC-BY-SA-4.0, GPL-3+
* Vcs : https://salsa.debian.org/emacsen-team/flycheck
Section : lisp
The source builds the following binary packages:
elpa-flycheck - modern on-the-fly syntax checking for Emacs
flycheck-doc - modern on-the-fly syntax checking for Emacs - documentation
To access further information about this package, please visit the following
URL:
https://mentors.debian.net/package/flycheck/
Alternatively, you can download the package with 'dget' using this command:
dget -x
https://mentors.debian.net/debian/pool/main/f/flycheck/flycheck_34.1-1.dsc
Changes since the last upload:
flycheck (34.1-1) unstable; urgency=medium
.
* New upstream release.
* Update skipped flaky tests
* Refresh patches
* Drop obsolete handling in elpa-test and ert-helper.el
* Update d/watch to track releases now that upstream releases have
resumed
* Update lintian overrides name:
debian-watch-does-not-check-{,open}gpg-signature
* Set upstream metadata fields: Bug-Database, Bug-Submit,
Repository-Browse.
* Add Upstream-Contact in d/copyright
Regards,
--
Xiyue Deng
End of forwarded message ----
--
Xiyue Deng
Bug#1068558: RFS: flycheck/34.1-1 -- modern on-the-fly syntax checking for Emacs - documentation
Package: sponsorship-requests
Severity: normal
Dear mentors,
I am looking for a sponsor for my package "flycheck":
* Package name : flycheck
Version : 34.1-1
Upstream contact : Bozhidar Batsov
* URL : https://www.flycheck.org/
* License : CC-BY-SA-4.0, GPL-3+
* Vcs : https://salsa.debian.org/emacsen-team/flycheck
Section : lisp
The source builds the following binary packages:
elpa-flycheck - modern on-the-fly syntax checking for Emacs
flycheck-doc - modern on-the-fly syntax checking for Emacs - documentation
To access further information about this package, please visit the following
URL:
https://mentors.debian.net/package/flycheck/
Alternatively, you can download the package with 'dget' using this command:
dget -x
https://mentors.debian.net/debian/pool/main/f/flycheck/flycheck_34.1-1.dsc
Changes since the last upload:
flycheck (34.1-1) unstable; urgency=medium
.
* New upstream release.
* Update skipped flaky tests
* Refresh patches
* Drop obsolete handling in elpa-test and ert-helper.el
* Update d/watch to track releases now that upstream releases have
resumed
* Update lintian overrides name:
debian-watch-does-not-check-{,open}gpg-signature
* Set upstream metadata fields: Bug-Database, Bug-Submit,
Repository-Browse.
* Add Upstream-Contact in d/copyright
Regards,
--
Xiyue Deng
Bug#1068491: RFS: emacs-popon/0.13-1 [ITP] -- Pop floating text on an Emacs window
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package "emacs-popon": * Package name : emacs-popon Version : 0.13-1 Upstream contact : Akib Azmain Turja * URL : https://codeberg.org/akib/emacs-popon * License : GPL-3+ * Vcs : https://salsa.debian.org/emacsen-team/emacs-popon Section : editors The source builds the following binary packages: elpa-popon - Pop floating text on an Emacs window To access further information about this package, please visit the following URL: https://mentors.debian.net/package/emacs-popon/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/e/emacs-popon/emacs-popon_0.13-1.dsc Changes for the initial release: emacs-popon (0.13-1) unstable; urgency=medium . * Initial release (Closes: #1068441). Regards, -- Xiyue Deng
Bug#1068477: RFS: emacs-corfu/1.3-1 [Team] -- Completion Overlay Region FUnction in Emacs
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "emacs-corfu": * Package name : emacs-corfu Version : 1.3-1 Upstream contact : Daniel Mendler * URL : https://github.com/minad/corfu/ * License : GPL-3+ * Vcs : https://salsa.debian.org/emacsen-team/emacs-corfu Section : editors The source builds the following binary packages: elpa-corfu - Completion Overlay Region FUnction in Emacs To access further information about this package, please visit the following URL: https://mentors.debian.net/package/emacs-corfu/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/e/emacs-corfu/emacs-corfu_1.3-1.dsc Changes since the last upload: emacs-corfu (1.3-1) unstable; urgency=medium . * Team upload * New upstream release * Drop file name from lintian overrides so that it works either compressed or not Regards, -- Xiyue Deng
Bug#1068427: RFS: dpkg-dev-el/37.12 -- Emacs helpers specific to Debian development
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "dpkg-dev-el": * Package name : dpkg-dev-el Version : 37.12 Upstream contact : Debian Emacsen Team * URL : [fill in URL of upstream's web site] * License : GPL-2+ * Vcs : https://salsa.debian.org/emacsen-team/dpkg-dev-el Section : lisp The source builds the following binary packages: elpa-dpkg-dev-el - Emacs helpers specific to Debian development dpkg-dev-el - Transition package, dpkg-dev-el to elpa-dpkg-dev-el To access further information about this package, please visit the following URL: https://mentors.debian.net/package/dpkg-dev-el/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/d/dpkg-dev-el/dpkg-dev-el_37.12.dsc Changes since the last upload: dpkg-dev-el (37.12) unstable; urgency=medium . [ Niels Thykier ] * Update list of known d/control fields for debian-control-mode . [ Xiyue Deng ] * Untabify and reindent source code in Emacs 29 for consistency * Fix fill-paragraph in debian-changelog-mode (Closes: #620185) * Improve highlighting in debian-copyright (Closes: #557594, #1067589) - Add highlighting for more field names - Properly highlight common URLs - Add highlighting for emails - Add highlighting for common licenses as defined in base-files * Fix comp warnings (Closes: #1026450, #1028470) - Drop calls to obsolete easy-menu-add - Guard XEmacs functions - Require debian-bug for function usage - There are still some warnings due to compatibility with XEmacs which are being tracked in Bug#1068370. - Replace obsolete `max-specpdl-size' with `max-lisp-eval-depth' - Drop calls to no-op function `easy-menu-add' - Use defvar for variables without a require - Replace `position' with `seq-position' - Replace `subseq' with `seq-subseq' - Fix long docstring - Use `goto-char' instead of `goto-line' * Initial support for autopkgtest control files (Closes: #1067590) - Add initial highlighting for field names, dependency extensions, and restrictions * Bump version to prepare for release * Add myself to uploaders Regards, -- Xiyue Deng
Bug#1067933: RFS: graphviz-dot-mode/0.4.2+git20230325.8ff793b-1 [Team] -- Emacs mode for the dot-language used by graphviz
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "graphviz-dot-mode": * Package name : graphviz-dot-mode Version : 0.4.2+git20230325.8ff793b-1 Upstream contact : Pieter Pareit * URL : https://ppareit.github.io/graphviz-dot-mode/ * License : GFDL-1.3+, GPL-2+ * Vcs : https://salsa.debian.org/emacsen-team/graphviz-dot-mode Section : lisp The source builds the following binary packages: elpa-graphviz-dot-mode - Emacs mode for the dot-language used by graphviz To access further information about this package, please visit the following URL: https://mentors.debian.net/package/graphviz-dot-mode/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/g/graphviz-dot-mode/graphviz-dot-mode_0.4.2+git20230325.8ff793b-1.dsc Changes since the last upload: graphviz-dot-mode (0.4.2+git20230325.8ff793b-1) unstable; urgency=medium . * Team upload. * Sync to latest snapshot (8ff793b). - Implement completion based on capf and drop company dependency. - Switch to lexical-binding. * Drop dependency on company in d/control now that it is capf-based. * Trim trailing whitespace. * Bump debhelper from old 10 to 13. * Set debhelper-compat version in Build-Depends. * Set upstream metadata fields: Bug-Database, Bug-Submit, Repository-Browse. * Update standards version to 4.6.2. No change needed. * Add Homepage in d/control. * Add "Rules-Requires-Root: no" in d/control. * Do not end description with a sentence end in d/control. * Drop extra license file LICENSE.md. * Modernize d/watch with special substitute strings to be more robust. * Update upstream copyright year in d/changelog. * Add Source and Upstream-Contact in d/copyright. Regards, -- Xiyue Deng
Bug#1067895: RFS: emacs-format-all-the-code/0.6.0-1 [Team] -- Auto-format C, C++, JS, Python, Ruby and 50 other languages
Sean Whitton writes: > control: tag -1 + moreinfo > > Looks like the Source: in d/copyright is bogus? Ah indeed. Fixed in [1], recompiled and uploaded to mentors as well. PTAL. [1] https://salsa.debian.org/emacsen-team/emacs-format-all-the-code/-/commit/92cfb4b866bfe4fb3200f13c42850b3febfe -- Xiyue Deng
Bug#1067895: RFS: emacs-format-all-the-code/0.6.0-1 [Team] -- Auto-format C, C++, JS, Python, Ruby and 50 other languages
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "emacs-format-all-the-code": * Package name : emacs-format-all-the-code Version : 0.6.0-1 Upstream contact : Lassi Kortela * URL : https://github.com/lassik/emacs-format-all-the-code * License : MIT * Vcs : https://salsa.debian.org/emacsen-team/emacs-format-all-the-code Section : editors The source builds the following binary packages: elpa-format-all - Auto-format C, C++, JS, Python, Ruby and 50 other languages To access further information about this package, please visit the following URL: https://mentors.debian.net/package/emacs-format-all-the-code/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/e/emacs-format-all-the-code/emacs-format-all-the-code_0.6.0-1.dsc Changes since the last upload: emacs-format-all-the-code (0.6.0-1) unstable; urgency=medium . * Team upload. * New upstream release. * Refresh patches and add forwarded info. - Add `:features' in puppet-lint which is required now. * Drop obsolete emacs version from Recommends. * Update Standards-Version to 4.6.2 (no change needed.) * Add d/upstream/metadata. * Fix d/watch with special substitute strings. * Add Upstream-Contact in d/copyright. Regards, -- Xiyue Deng
Bug#1067581: RFS: package-lint-el/0.22-1 [Team] -- package-lint Flymake backend
Sean Whitton writes: > control: tag -1 + moreinfo > > Hello, > > Looks like you didn't push to master :) Ah indeed. Just done (with tags). PTAL, thanks! -- Xiyue Deng signature.asc Description: PGP signature
Bug#1067806: RFS: dockerfile-mode/1.9-1 [Team] -- Major mode for editing Docker's Dockerfiles
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "dockerfile-mode": * Package name : dockerfile-mode Version : 1.9-1 Upstream contact : Spotify * URL : https://github.com/spotify/dockerfile-mode * License : Apache-2.0 * Vcs : https://salsa.debian.org/emacsen-team/dockerfile-mode Section : lisp The source builds the following binary packages: elpa-dockerfile-mode - Major mode for editing Docker's Dockerfiles To access further information about this package, please visit the following URL: https://mentors.debian.net/package/dockerfile-mode/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/d/dockerfile-mode/dockerfile-mode_1.9-1.dsc Changes since the last upload: dockerfile-mode (1.9-1) unstable; urgency=medium . * Team upload. . [ Aymeric Agon-Rambosson ] * d/control : Add Rules-Requires-Root field to satisfy Policy. * d/copyright : bump copyright years for debian/*. . [ Xiyue Deng ] * New upstream release. * Set upstream metadata fields: Bug-Database, Bug-Submit, Repository-Browse. * Update standards version to 4.6.2, no changes needed. * Modernize d/watch with special substitute strings to be more robust. * Update upstream copyright year in d/copyright. * Add Upstream-Contact in d/copyright. Regards, -- Xiyue Deng
Bug#1067721: RFS: emacs-corfu/1.2-1 [Team] -- Completion Overlay Region FUnction in Emacs
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "emacs-corfu": * Package name : emacs-corfu Version : 1.2-1 Upstream contact : Daniel Mendler * URL : https://github.com/minad/corfu/ * License : GPL-3+ * Vcs : https://salsa.debian.org/emacsen-team/emacs-corfu Section : editors The source builds the following binary packages: elpa-corfu - Completion Overlay Region FUnction in Emacs To access further information about this package, please visit the following URL: https://mentors.debian.net/package/emacs-corfu/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/e/emacs-corfu/emacs-corfu_1.2-1.dsc Changes since the last upload: emacs-corfu (1.2-1) unstable; urgency=medium . * Team upload * New upstream release * Set upstream metadata fields: Bug-Database, Bug-Submit, Repository-Browse * Update standards version to 4.6.2, no changes needed * Update copyright year in d/copyright * Modernize d/watch with special substitute strings to be more robust * Add d/gbp.conf to match current packaging practice * Mark vendored patch as "Forwarded: not-needed" * Add lintian-overrides for org format changelog Regards, -- Xiyue Deng
Bug#1067698: RFS: persist-el/0.6+dfsg-1 [Team] -- persist variables between Emacs Sessions
Hi Nicholas, Nicholas D Steeves writes: > Control: owner -1 ! > > Xiyue Deng writes: > >>[ Xiyue Deng ] >>* New upstream release. >>* Re-export upstream signing key without extra signatures. > > $ uscan --download-current-version > Newest version of persist-el on remote site is 0.6, specified download > version is 0.6 > gpgv: Signature made Sat 13 Jan 2024 05:05:03 EST > gpgv:using RSA key C433554766D3DDC64221BFAA066DAFCB81E42C40 > gpgv: Good signature from "GNU ELPA Signing Agent (2019) > " > gpgv: Signature made Sat 13 Jan 2024 05:05:03 EST > gpgv:using EDDSA key 0327BE68D64D9A1A66859F15645357D2883A0966 > gpgv: Can't check signature: No public key > uscan die: OpenPGP signature did not verify. at > /usr/share/perl5/Devscripts/Uscan/Output.pm line 77. I have been in contact with upstream maintainer Joseph Turner about this issue. He replied that he recently took over the maintenance of persist and was not aware about this key either. I have followed his suggestion and filed a bug report to bug-gnu-em...@gnu.org about this issue[1]. Meanwhile, as the RSA key signature is good, I resorted to use "uscan --skip-signature" to get the current version, dropped the GFDL document source and repacked the source tarball. Hope this process sounds ok to you. -- Xiyue Deng [1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70003
Bug#1067698: RFS: persist-el/0.6+dfsg-1 [Team] -- persist variables between Emacs Sessions
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "persist-el": * Package name : persist-el Version : 0.6+dfsg-1 Upstream contact : Phillip Lord * URL : https://elpa.gnu.org/packages/persist.html * License : GPL-3+ * Vcs : https://salsa.debian.org/emacsen-team/persist-el Section : editors The source builds the following binary packages: elpa-persist - persist variables between Emacs Sessions To access further information about this package, please visit the following URL: https://mentors.debian.net/package/persist-el/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/p/persist-el/persist-el_0.6+dfsg-1.dsc Changes since the last upload: persist-el (0.6+dfsg-1) unstable; urgency=medium . * Team upload. . [ Debian Janitor ] * Remove constraints unnecessary since buster (oldstable): + elpa-persist: Drop versioned constraint on emacs in Recommends. . [ Xiyue Deng ] * New upstream release. * Re-export upstream signing key without extra signatures. * Update standards version to 4.6.2, no changes needed. Regards, -- Xiyue Deng
Bug#1067581: RFS: package-lint-el/0.22-1 [Team] -- package-lint Flymake backend
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "package-lint-el": * Package name : package-lint-el Version : 0.22-1 Upstream contact : Steve Purcell * URL : https://github.com/purcell/package-lint * License : GPL-3+ * Vcs : https://salsa.debian.org/emacsen-team/package-lint-el Section : lisp The source builds the following binary packages: elpa-package-lint - linting library for Elisp package authors elpa-package-lint-flymake - package-lint Flymake backend To access further information about this package, please visit the following URL: https://mentors.debian.net/package/package-lint-el/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/p/package-lint-el/package-lint-el_0.22-1.dsc Changes since the last upload: package-lint-el (0.22-1) unstable; urgency=medium . * Team upload * New upstream version 0.22 * Update copyright year in d/copyright * Add Upstream-Contact in d/copyright * Modernize d/watch with special substitute string to be more robust Regards, -- Xiyue Deng
Bug#1067127: marked as done (RFS: emacs-cmake-mode/3.28.3+ds-1 [Team] -- Emacs major mode for editing CMake sources)
Tobias Frost writes: > Control: reopen -1 > Control: retitle -1 RFS: emacs-cmake-mode/3.29.0+ds-1 [Team] -- Emacs major > mode for editing CMake sources > Control: forcemerge -1 1067530 > >> Date: Sat, 23 Mar 2024 00:15:55 -0700 >> From: Xiyue Deng >> To: 1067127-d...@bugs.debian.org >> Subject: Re: Bug#1067127: Acknowledgement (RFS: >> emacs-cmake-mode/3.28.3+ds-1 [Team] -- Emacs major mode for editing CMake >> sources) >> User-Agent: Gnus/5.13 (Gnus v5.13) >> >> 3.29.0 has just been released. Will send a new RFS. > > Please do not open new RFS when the old one has not been sponsored. > Instead, use the old one and update it accordingly. > > Thanks! > >> -- >> Xiyue Deng > Acknowledged. Will follow your advice in future. -- Xiyue Deng
Bug#1067530: RFS: emacs-cmake-mode/3.29.0+ds-1 [Team] -- Emacs major mode for editing CMake sources
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "emacs-cmake-mode": * Package name : emacs-cmake-mode Version : 3.29.0+ds-1 Upstream contact : Brad King * URL : https://cmake.org * License : BSD-3-Clause * Vcs : https://salsa.debian.org/emacsen-team/emacs-cmake-mode Section : editors The source builds the following binary packages: elpa-cmake-mode - Emacs major mode for editing CMake sources To access further information about this package, please visit the following URL: https://mentors.debian.net/package/emacs-cmake-mode/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/e/emacs-cmake-mode/emacs-cmake-mode_3.29.0+ds-1.dsc Changes since the last upload: emacs-cmake-mode (3.29.0+ds-1) unstable; urgency=medium . * Team upload * New upstream version 3.29.0+ds * Add d/upstream/metadata * Add Upstream-Contact to d/copyright * Update year in d/copyright Regards, -- Xiyue Deng
Bug#1067526: RFS: company-mode/0.10.2-1 [Team] -- Modular in-buffer completion framework for Emacs
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "company-mode": * Package name : company-mode Version : 0.10.2-1 Upstream contact : Dmitry Gutov * URL : https://company-mode.github.io/ * License : GPL-3+ * Vcs : https://salsa.debian.org/emacsen-team/company-mode Section : lisp The source builds the following binary packages: elpa-company - Modular in-buffer completion framework for Emacs To access further information about this package, please visit the following URL: https://mentors.debian.net/package/company-mode/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/c/company-mode/company-mode_0.10.2-1.dsc Changes since the last upload: company-mode (0.10.2-1) unstable; urgency=medium . * Team upload * New upstream version * Migrate from debhelper >= 11 to debhelper-compat version 13 * Update Standards-Version to 4.6.2 (no change needed) * Set Rules-Requires-Root as no in d/control * Check DEB_BUILD_OPTIONS against nocheck in override_dh_auto_test * Modernize d/watch to version 4 with substitute strings to be robust * Add Upstream-Contact in d/copyright Regards, -- Xiyue Deng
Bug#1067471: RFS: emacs-language-id/0.20-1 [Team] -- Library to work with programming language identifiers
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "emacs-language-id": * Package name : emacs-language-id Version : 0.20-1 Upstream contact : Lassi Kortela * URL : https://github.com/lassik/emacs-language-id * License : ISC * Vcs : https://salsa.debian.org/emacsen-team/emacs-language-id Section : editors The source builds the following binary packages: elpa-language-id - Library to work with programming language identifiers To access further information about this package, please visit the following URL: https://mentors.debian.net/package/emacs-language-id/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/e/emacs-language-id/emacs-language-id_0.20-1.dsc Changes since the last upload: emacs-language-id (0.20-1) unstable; urgency=medium . * Team upload. * New upstream release. * Drop 0001-Add-Puppet-mode.patch (applied upstream.) * Update Standards-Version to 4.6.2 (no change needed.) * Drop obsolete emacs version in Recommends. * Fix d/watch with special substitue strings. * Add d/upstream/metadata. * Add Upstream-Contact and add upstream maintainer's email in d/copyright Regards, -- Xiyue Deng
Bug#1067408: RFS: compat-el/29.1.4.5+dfsg-1 [Team] -- COMPATibility Library for Emacs
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "compat-el": * Package name : compat-el Version : 29.1.4.5+dfsg-1 Upstream contact : Daniel Mendler * URL : https://github.com/emacs-compat/compat * License : GPL-3+ * Vcs : https://salsa.debian.org/emacsen-team/compat-el Section : editors The source builds the following binary packages: elpa-compat - COMPATibility Library for Emacs To access further information about this package, please visit the following URL: https://mentors.debian.net/package/compat-el/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/c/compat-el/compat-el_29.1.4.5+dfsg-1.dsc Changes since the last upload: compat-el (29.1.4.5+dfsg-1) unstable; urgency=medium . * Team upload. * New upstream release. * Add Upstream-Contact in d/copyright. * Add d/upstream/metadata. Regards, -- Xiyue Deng
Bug#1067133: RFS: clojure-mode/5.18.1-2 [ITA] -- extra font-locking for clojure-mode
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "clojure-mode": * Package name : clojure-mode Version : 5.18.1-2 Upstream contact : Bozhidar Batsov * URL : https://github.com/clojure-emacs/clojure-mode * License : GPL-3+ * Vcs : https://salsa.debian.org/emacsen-team/clojure-mode Section : lisp The source builds the following binary packages: elpa-clojure-mode - Emacs major mode for Clojure code elpa-clojure-mode-extra-font-locking - extra font-locking for clojure-mode To access further information about this package, please visit the following URL: https://mentors.debian.net/package/clojure-mode/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/c/clojure-mode/clojure-mode_5.18.1-2.dsc Changes since the last upload: clojure-mode (5.18.1-2) unstable; urgency=medium . * Add myself to Uploaders (Closes: 952808) * Fix buttercup tests stuck under autopkgtest (Closes: #1067131) Note: this upload fixes bug#1067131[1] which prevents clojure-mode from migrating to testing. Thanks in advance for considering! Regards, -- Xiyue Deng [1] https://bugs.debian.org/1067131
Bug#1067127: RFS: emacs-cmake-mode/3.28.3+ds-1 [Team] -- Emacs major mode for editing CMake sources
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "emacs-cmake-mode": * Package name : emacs-cmake-mode Version : 3.28.3+ds-1 Upstream contact : [fill in name and email of upstream] * URL : https://cmake.org * License : BSD-3-Clause * Vcs : https://salsa.debian.org/emacsen-team/emacs-cmake-mode Section : editors The source builds the following binary packages: elpa-cmake-mode - Emacs major mode for editing CMake sources To access further information about this package, please visit the following URL: https://mentors.debian.net/package/emacs-cmake-mode/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/e/emacs-cmake-mode/emacs-cmake-mode_3.28.3+ds-1.dsc Changes since the last upload: emacs-cmake-mode (3.28.3+ds-1) unstable; urgency=medium . * Team upload * New upstream version 3.28.3+ds * Add d/upstream/metadata Regards, -- Xiyue Deng
Bug#1067081: RFS: emacs-libvterm/0.0.2+git20240102.c3a3a23-1 [Team] -- fully-fledged terminal emulator inside GNU Emacs based on libvterm - module
Martin writes: > Hi, > > I can sponsor this, but would build the package from git. > > (Note, that pristine-tar contains the .gz tar file, while the .dsc > refers to a .xz one. Doesn't matter much.) > > Cheers Thanks a lot, Martin! I have synced to the latest snapshot so that I can drop the typo patch and also fixed the inconsistent of tarball in pristine-tar. New package also uploaded to mentors[1]. PTAL. TIA! [1] https://mentors.debian.net/package/emacs-libvterm/ -- Xiyue Deng
Bug#1067081: RFS: emacs-libvterm/0.0.2+git20240102.c3a3a23-1 [Team] -- fully-fledged terminal emulator inside GNU Emacs based on libvterm - module
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "emacs-libvterm": * Package name : emacs-libvterm Version : 0.0.2+git20240102.c3a3a23-1 Upstream contact : Lukas Fürmetz * URL : https://github.com/akermu/emacs-libvterm * License : GPL-2+, GPL-3, GPL-3+ * Vcs : https://salsa.debian.org/emacsen-team/emacs-libvterm Section : editors The source builds the following binary packages: emacs-libvterm - fully-fledged terminal emulator inside GNU Emacs based on libvterm - module elpa-vterm - fully-fledged terminal emulator inside GNU Emacs based on libvterm - elisp To access further information about this package, please visit the following URL: https://mentors.debian.net/package/emacs-libvterm/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/e/emacs-libvterm/emacs-libvterm_0.0.2+git20240102.c3a3a23-1.dsc Changes since the last upload: emacs-libvterm (0.0.2+git20240102.c3a3a23-1) unstable; urgency=medium . * Team upload . [ Debian Janitor ] * Set upstream metadata fields: Bug-Database, Bug-Submit, Repository-Browse. . [ Xiyue Deng ] * New upstream snapshot * Drop elpa-vterm dependency from emacs-libvterm to avoid circular dependency * Drop emacs dependency from emacs-libvterm following existing practice * Update breaks/replaces versions to be backports friendly * Update Standards-Version to 4.6.2 (no change needed) * Add d/watch tracking latest snapshot * Mark vendor patches as "Forwarded: not-needed" * Add patch to fix typo in vterm-module.c * Enable hardening builds Notes: emacs-libvterm has been marked for autoremoval[1] due to Bug#1065731[2] whose fix marked libvterm Breaks the current emacs-libvterm version, so this upload is required to keep emacs-libvterm in testing. Thanks in advance for considering! Regards, -- Xiyue Deng [1] https://lists.debian.org/debian-emacsen/2024/03/msg00035.html [2] https://bugs.debian.org/1065731
Bug#1067028: RFS: emacs-buttercup/1.34-1 [Team] -- behaviour-driven testing for Emacs Lisp packages
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "emacs-buttercup": * Package name : emacs-buttercup Version : 1.34-1 Upstream contact : [fill in name and email of upstream] * URL : https://github.com/jorgenschaefer/emacs-buttercup/ * License : GFDL-1.2+ or CC-BY-SA-3.0, GPL-3+ * Vcs : https://salsa.debian.org/emacsen-team/emacs-buttercup Section : lisp The source builds the following binary packages: elpa-buttercup - behaviour-driven testing for Emacs Lisp packages To access further information about this package, please visit the following URL: https://mentors.debian.net/package/emacs-buttercup/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/e/emacs-buttercup/emacs-buttercup_1.34-1.dsc Changes since the last upload: emacs-buttercup (1.34-1) unstable; urgency=medium . * Team upload * New upstream release * Migrate to debhelper-compat version 13 Regards, -- Xiyue Deng
Bug#1065302: RFS: elpa-rust-mode/1.0.5+git20240301.6d86af4-1 -- Major Emacs mode for editing Rust source code
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "elpa-rust-mode": * Package name : elpa-rust-mode Version : 1.0.5+git20240301.6d86af4-1 Upstream contact : The Rust Project Developers * URL : https://github.com/rust-lang/rust-mode * License : Apache-2.0 or MIT * Vcs : https://salsa.debian.org/emacsen-team/rust-mode Section : editors The source builds the following binary packages: elpa-rust-mode - Major Emacs mode for editing Rust source code To access further information about this package, please visit the following URL: https://mentors.debian.net/package/elpa-rust-mode/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/e/elpa-rust-mode/elpa-rust-mode_1.0.5+git20240301.6d86af4-1.dsc Changes since the last upload: elpa-rust-mode (1.0.5+git20240301.6d86af4-1) unstable; urgency=medium . [ Nicholas D Steeves ] * Drop emacs24 from Enhances (package does not exist in bullseye). * Matthew Kraai has moved to Emeritus status; remove him from Uploaders on his request. . [ Xiyue Deng ] * Sync to latest upstream head (6d86af4) * Drop obsolete patches * Skip upstream Makefile which relies on eask * Drop obsolete override_dh_auto_test and refine override_dh_auto_clean * Include all source files in d/elpa * Migrate from compat to debhelper-compat version 13 * Drop unnecessary parameter "--parallel" with debhelper-compat 13 * Drop obsolete version requirements from dh-elpa and emacs * Update to Standards-Version 4.6.2 (no change needed) * Extend package description using upstream introduction * Drop Built-Using from "Architecture: all" package * Add myself as uploader * Modernize d/watch with special substitute strings * Rename license from Expat to MIT following upstream * Use https in Format URL * Update copyright years * Add copyright information for debian/* * Add Upstream-Contact * Add d/upstream/metadata Regards, -- Xiyue Deng
Bug#1061653: RFS: dpkg-dev-el/37.11 [RC] [Team] -- Emacs helpers specific to Debian development
Xiyue Deng writes: > Bastian Germann writes: > >> On Sat, 27 Jan 2024 20:13:44 -0800 Xiyue Deng wrote: >>>* d/control: add elpa-debian-el to Build-Depends (Closes: #1061650). >> >> The changelog is incorrect. You have added to elpa-dpkg-dev-el's Depends. >> > > Indeed. Thanks for spotting this! I've corrected the changelog entry > in salsa[1] and reuploaded to mentors[2]. PTAL. TIA! > > [1] > https://salsa.debian.org/emacsen-team/dpkg-dev-el/-/commit/5c04c8541515ffb583be09e417179ed4ef31fc9c > [2] https://mentors.debian.net/package/dpkg-dev-el/ Actually, I've also added some tests to check dependencies during building, so it's now also required as part of the Build-Depends. Salsa and mentors updated again, PTAL. TIA! -- Xiyue Deng
Bug#1061653: RFS: dpkg-dev-el/37.11 [RC] [Team] -- Emacs helpers specific to Debian development
Bastian Germann writes: > On Sat, 27 Jan 2024 20:13:44 -0800 Xiyue Deng wrote: >>* d/control: add elpa-debian-el to Build-Depends (Closes: #1061650). > > The changelog is incorrect. You have added to elpa-dpkg-dev-el's Depends. > Indeed. Thanks for spotting this! I've corrected the changelog entry in salsa[1] and reuploaded to mentors[2]. PTAL. TIA! [1] https://salsa.debian.org/emacsen-team/dpkg-dev-el/-/commit/5c04c8541515ffb583be09e417179ed4ef31fc9c [2] https://mentors.debian.net/package/dpkg-dev-el/ -- Xiyue Deng
Bug#1061653: RFS: dpkg-dev-el/37.11 [RC] [Team] -- Emacs helpers specific to Debian development
Package: sponsorship-requests Severity: important Dear mentors, I am looking for a sponsor for my package "dpkg-dev-el": * Package name : dpkg-dev-el Version : 37.11 Upstream contact : Debian Emacsen Team * URL : https://salsa.debian.org/emacsen-team/dpkg-dev-el * License : GPL-2+ * Vcs : https://salsa.debian.org/emacsen-team/dpkg-dev-el Section : lisp The source builds the following binary packages: elpa-dpkg-dev-el - Emacs helpers specific to Debian development dpkg-dev-el - Transition package, dpkg-dev-el to elpa-dpkg-dev-el To access further information about this package, please visit the following URL: https://mentors.debian.net/package/dpkg-dev-el/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/d/dpkg-dev-el/dpkg-dev-el_37.11.dsc Changes since the last upload: dpkg-dev-el (37.11) unstable; urgency=medium . * Team upload. * d/control: add elpa-debian-el to Build-Depends (Closes: #1061650). Regards, -- Xiyue Deng
Bug#1059200: RFS: elenv/0.1.0+git20231211.94cf71e-1 -- Emacs Lisp Environment Detection Library
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "elenv": * Package name : elenv Version : 0.1.0+git20231211.94cf71e-1 Upstream contact : Jen-Chieh Shen * URL : https://github.com/jcs-elpa/elenv * License : GPL-3+ * Vcs : https://salsa.debian.org/emacsen-team/elenv Section : editors The source builds the following binary packages: elpa-elenv - Emacs Lisp Environment Detection Library To access further information about this package, please visit the following URL: https://mentors.debian.net/package/elenv/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/e/elenv/elenv_0.1.0+git20231211.94cf71e-1.dsc Changes since the last upload: elenv (0.1.0+git20231211.94cf71e-1) unstable; urgency=medium . * Sync to latest upstream master (94cf71e). - Fix lint warnings. - Add debugging flag. Notes: according to the tracker page[1], it requires another source-only upload for it to be allowed to migrate to testing, so I took this chance to also updated to a newer upstream snapshot with more added functions. [1] https://qa.debian.org/excuses.php?package=elenv Regards, -- Xiyue Deng
Bug#1059074: RFS: dpkg-dev-el/37.10 [Team] -- Emacs helpers specific to Debian development
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "dpkg-dev-el": * Package name : dpkg-dev-el Version : 37.10 Upstream contact : [fill in name and email of upstream] * URL : [fill in URL of upstream's web site] * License : GPL-2+ * Vcs : https://salsa.debian.org/emacsen-team/dpkg-dev-el Section : lisp The source builds the following binary packages: elpa-dpkg-dev-el - Emacs helpers specific to Debian development dpkg-dev-el - Transition package, dpkg-dev-el to elpa-dpkg-dev-el To access further information about this package, please visit the following URL: https://mentors.debian.net/package/dpkg-dev-el/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/d/dpkg-dev-el/dpkg-dev-el_37.10.dsc Changes since the last upload: dpkg-dev-el (37.10) unstable; urgency=medium . * Team upload . [ Nicholas D Steeves ] * Drop emacs25 from Enhances (package does not exist in bullseye). . [ Amin Bandali ] * Fix a few warnings. . [ Xiyue Deng ] * Convert debian-changelog-mode file encoding to UTF-8 * Drop emacs version from recommends * Update Standards-Version to 4.6.2, no changes needed * Migrate to debhelper-compat version 13 * Mark Rules-Requires-Root as no in d/control * Use dh_elpa to generate autoloads and pkg el files * Add "Package" to debian-control-binary-fields * Fix a few more warnings Regards, -- Xiyue Deng
Bug#1059073: RFS: debian-el/37.11 [Team] -- Emacs helpers specific to Debian users
Package: sponsorship-requests
Severity: normal
Dear mentors,
I am looking for a sponsor for my package "debian-el":
* Package name : debian-el
Version : 37.11
Upstream contact : Debian Emacsen team
* URL : https://salsa.debian.org/emacsen-team/debian-el
* License : GPL-2+
* Vcs : https://salsa.debian.org/emacsen-team/debian-el
Section : lisp
The source builds the following binary packages:
elpa-debian-el - Emacs helpers specific to Debian users
debian-el - Transition package, debian-el to elpa-debian-el
To access further information about this package, please visit the following
URL:
https://mentors.debian.net/package/debian-el/
Alternatively, you can download the package with 'dget' using this command:
dget -x
https://mentors.debian.net/debian/pool/main/d/debian-el/debian-el_37.11.dsc
Changes since the last upload:
debian-el (37.11) unstable; urgency=medium
.
* Team upload.
.
[ Salman Mohammadi ]
* apt-utils.el: fix broken example, replace emacs21 with emacs
.
[ Nicholas D Steeves ]
* Drop emacs25 from Enhances (package does not exist in bullseye).
.
[ Debian Janitor ]
* Remove constraints unnecessary since buster (oldstable):
+ elpa-debian-el: Drop versioned constraint on dpkg and reportbug in
Depends.
+ elpa-debian-el: Drop versioned constraint on emacs in Recommends.
.
[ Hermógenes Oliveira ]
* Make apt-utils-search honour apt-utils-use-current-window.
.
[ Łukasz Stelmach ]
* debian-bug.el: Highlight Control: pseudo-header
.
[ Fabrice Bauzac ]
* Fix Emacs 28.2 warnings about beginning/end-of-buffer.
+ {beginning,end}-of-buffer functions are for interactive use only.
* Fix warning about save-excursion+set-buffer.
* Fix warning about next-line.
* Fix warning about mapcar's unused return value.
* Fix byte-compilation warning about dired-load-hook.
.
[ Xiyue Deng ]
* Documentation fixes.
+ Fixes a few typos.
+ Revise some wording.
+ Stop using obsoleted versioned emacs21 in examples.
* Handle process error more gracefully (Closes: #1050685).
* Run term-exec without hooks to be more robust.
* Resolve comp warnings (Closes: #1024695, #1034734, #1037179, #1051478).
* Fix install status detection of "Multi-Arch:same" packages
(Closes: #664083).
* Update Standards-Version to 4.6.2. No change needed.
* Use secure URI in d/copyright.
* Add lintian override for info page outside of /usr/share/doc.
* Migrate to debhelper-compat version 13.
* Add "Rules-Requires-Root: no" in d/control.
* Update year in d/copyright.
* Add team as Upstream-Contact in d/copyright.
* Use dh_elpa to handle *-{autoloads,pkg}.el generations.
+ Add package info comments to debian-el.el.
+ Drop debian-autoloads.el and debian-el-pkg.el in favor of dh_elpa
generated ones.
Regards,
--
Xiyue Deng
Bug#1059065: RFS: lsp-mode/8.0.0+git20231219.2cdb9bc-1 [RC] -- Emacs client/library for the Language Server Protocol
Package: sponsorship-requests Severity: important Dear mentors, I am looking for a sponsor for my package "lsp-mode": * Package name : lsp-mode Version : 8.0.0+git20231219.2cdb9bc-1 Upstream contact : Vibhav Pant * URL : https://github.com/emacs-lsp/lsp-mode * License : GPL-3+ * Vcs : https://salsa.debian.org/emacsen-team/lsp-mode Section : lisp The source builds the following binary packages: elpa-lsp-mode - Emacs client/library for the Language Server Protocol To access further information about this package, please visit the following URL: https://mentors.debian.net/package/lsp-mode/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/l/lsp-mode/lsp-mode_8.0.0+git20231219.2cdb9bc-1.dsc Changes since the last upload: lsp-mode (8.0.0+git20231219.2cdb9bc-1) unstable; urgency=medium . * Sync to latest upstream head (2cdb9bc) (Closes: #1052939) * Drop obsolete version from Recommends and emacs25 from Enhances * Add newly required elpa-elenv to Build-Depends in d/control * Override dh auto clean to avoid using eask * Drop workaround of dh_elpa_test in favor of upstream fix * Skip test that fails in autopkgtest trying to overwrite without ACL * Allow stderr in autopkgtest * Use @builddeps@ in autopkgtest Depends to ensure B-D are available Regards, -- Xiyue Deng
Re: autopkgtest and generated files
Xiyue Deng writes: > (I'm not subscribed to the list so please keep me CCed.) > > Hi Debian mentors, > > I encountered a behavior difference between the package test during > building and in autopkgtest. When attempting to fix a emacs-wgrep FTBFS > bug[1], I added a new file through a patch[2] to the package which > should be used during the test phase. This works as expected during > package building[3] phase (which actually uses the dh_elpa_test but else > should behave the same as dh_auto_test). But during autopkgtest it > doesn't find the new file I added and fails[4] even though it was > running the same command as the building test phase. > > It was suggested to me that autopkgtest doesn't take generated files > into account. Is this true? If so this looks like a limitation of > autopkgtest. I wonder whether there is anyway to workaround this > restriction, or to disable autopkgtest that prevents the migration of > the package[5] as this is a false positive. > > TIA. > > [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1057559 > [2] > https://salsa.debian.org/emacsen-team/emacs-wgrep/-/commit/62bc99d768bcb290612b834c668f131e9f5b53f0 > [3] https://paste.debian.net/1301172/ (the test phase log) > [4] https://ci.debian.net/packages/e/emacs-wgrep/testing/amd64/41007238/ > [5] https://tracker.debian.org/pkg/emacs-wgrep > > -- > Xiyue Deng > So it turns out that this is not an autopkgtest issue at all, but that the package has a debian/elpa-test file[1] that specifies which files should be kept for autopkgtest, and I should just add the newly generated file to the list and problem solved! And now I feel silly.. [1] https://salsa.debian.org/emacsen-team/emacs-wgrep/-/blob/master/debian/elpa-test -- Xiyue Deng signature.asc Description: PGP signature
Bug#1054523: RFS: persp-projectile/1:1.0.0+git20210618.4e374d7-1 [RC] [Team] -- integrate perspective.el with projectile
Sean Whitton writes:
> Hello,
>
> On Sun 10 Dec 2023 at 09:09pm -08, Xiyue Deng wrote:
>
>> So a little further reading from the policy[1] and the lintian bug[2]
>> helped me understand the usage of "Built-Using" a bit better: it's used
>> to include other source package required for building without having to
>> depend on them. So technically it's not mutually exclusive with
>> arch:all as stated in the bug. However, in the case of
>> persp-perspective, I tried with or without it and it doesn't make any
>> difference. What's important is that ${elpa:Depends} correctly added
>> elpa-perspective and elpa-projectile to the dependency list of the
>> binary package. So I think in the end dropping it should be OK.
>>
>> Still, it makes sense to clarify the actual reason to drop it, so I've
>> updated the changelog entry to reflect this fact[3]. PTAL, TIA!
>
> Well, it's more about ensuring that those source package versions aren't
> dropped from the archive by dak, rendering us license-incompliant.
> Thanks for looking into it further. I've made a further change to your
> changelog message. Please take a look.
LGTM. Thanks!
>
> I've also noticed that there has been an upload to the archive,
> 1:0.2.0-4, which is not accounted for in our history. Please merge it
> in. 'gbp import-dsc apt:persp-projectile/sid', and then a manual merge,
> is probably what you want, because of how the patches are unapplied.
Not sure how I missed this, sorry about that. Somehow `apt source`
cannot find persp-projectile, and I see that there is actually a
"debian/1:0.2.0-4" tag created but the change is not merged to master
since I worked on it, so I just merged from the tag and resolved the
conflicts. Also rebuilt and pushed to mentors[1]. PTAL, TIA!
[1] https://mentors.debian.net/package/persp-projectile/
--
Xiyue Deng
signature.asc
Description: PGP signature
Bug#1058780: RFS: emacs-wgrep/3.0.0-3 [Team] -- edit multiple Emacs buffers with a helm-grep-mode buffer
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "emacs-wgrep": * Package name : emacs-wgrep Version : 3.0.0-3 Upstream contact : Masahiro Hayashi * URL : https://github.com/mhayashi1120/Emacs-wgrep * License : GPL-3+ * Vcs : https://salsa.debian.org/emacsen-team/emacs-wgrep Section : editors The source builds the following binary packages: elpa-wgrep - edit multiple Emacs buffers using a master grep pattern buffer elpa-wgrep-ack - edit multiple Emacs buffers using a master ack pattern buffer elpa-wgrep-ag - edit multiple Emacs buffers using a master ag pattern buffer elpa-wgrep-helm - edit multiple Emacs buffers with a helm-grep-mode buffer To access further information about this package, please visit the following URL: https://mentors.debian.net/package/emacs-wgrep/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/e/emacs-wgrep/emacs-wgrep_3.0.0-3.dsc Changes since the last upload: emacs-wgrep (3.0.0-3) unstable; urgency=medium . * Team upload. * Keep wgrep-test-helper.el in autopkgtest to fix missing file issue. * Add d/upstream/metadata. * Refresh patch to more aligned with upstream applied version. Regards, -- Xiyue Deng signature.asc Description: PGP signature
autopkgtest and generated files
(I'm not subscribed to the list so please keep me CCed.) Hi Debian mentors, I encountered a behavior difference between the package test during building and in autopkgtest. When attempting to fix a emacs-wgrep FTBFS bug[1], I added a new file through a patch[2] to the package which should be used during the test phase. This works as expected during package building[3] phase (which actually uses the dh_elpa_test but else should behave the same as dh_auto_test). But during autopkgtest it doesn't find the new file I added and fails[4] even though it was running the same command as the building test phase. It was suggested to me that autopkgtest doesn't take generated files into account. Is this true? If so this looks like a limitation of autopkgtest. I wonder whether there is anyway to workaround this restriction, or to disable autopkgtest that prevents the migration of the package[5] as this is a false positive. TIA. [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1057559 [2] https://salsa.debian.org/emacsen-team/emacs-wgrep/-/commit/62bc99d768bcb290612b834c668f131e9f5b53f0 [3] https://paste.debian.net/1301172/ (the test phase log) [4] https://ci.debian.net/packages/e/emacs-wgrep/testing/amd64/41007238/ [5] https://tracker.debian.org/pkg/emacs-wgrep -- Xiyue Deng signature.asc Description: PGP signature
Bug#1054523: RFS: persp-projectile/1:1.0.0+git20210618.4e374d7-1 [RC] [Team] -- integrate perspective.el with projectile
Sean Whitton writes:
> Hello,
>
> On Fri 03 Nov 2023 at 05:01pm -07, Xiyue Deng wrote:
>
>> I thought mentioning dropping Built-Using from arch:all package could be
>> an acceptable reason, which in turn also follows Lintian's suggestion :)
>> But do let me know if I should further clarify.
>
> But why couldn't an arch:all package have Built-Using? Built-Using, per
> Policy, is for license issues. arch:any vs. arch:all isn't
> determinative.
So a little further reading from the policy[1] and the lintian bug[2]
helped me understand the usage of "Built-Using" a bit better: it's used
to include other source package required for building without having to
depend on them. So technically it's not mutually exclusive with
arch:all as stated in the bug. However, in the case of
persp-perspective, I tried with or without it and it doesn't make any
difference. What's important is that ${elpa:Depends} correctly added
elpa-perspective and elpa-projectile to the dependency list of the
binary package. So I think in the end dropping it should be OK.
Still, it makes sense to clarify the actual reason to drop it, so I've
updated the changelog entry to reflect this fact[3]. PTAL, TIA!
[1]
https://www.debian.org/doc/debian-policy/ch-relationships.html#additional-source-packages-used-to-build-the-binary-built-using
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=999785
[3]
https://salsa.debian.org/emacsen-team/persp-projectile/-/commit/a0c39b5d53d96f7e85b163f9cb530efbf34b6166
--
Xiyue Deng
signature.asc
Description: PGP signature
Bug#1055379: RFS: clojure-mode/5.18.0-1 [RC] [Team] -- extra font-locking for clojure-mode
Hi Sean, Thanks for taking care of it! Please also see the replies below inline. Sean Whitton writes: > Hello, > > On Sat 09 Dec 2023 at 04:23pm GMT, Sean Whitton wrote: > >> Hello Xiyue, >> >> I made some commits before uploading. Please review. >> >> For the dgit-maint-merge(7) workflow, there is no need to manually >> refresh patches. dgit will do it for us whenever necessary. See the >> automatic commit now on the branch. Ack. Looks like I was still using the old quilt-based approach. Will take a look at how dgit does it. > > Hmm. Looks like I might have deleted some changes. Could you take a > look? Thank you. Looks like the deleted changes are the patches that dropped the package.el based installation instructions from README.md and an extra loading path of Eldev based directory. I don't think they'll matter much to be honest (especially the latter doesn't cause any issue for the tests), so please feel free to leave them as is. -- Xiyue Deng signature.asc Description: PGP signature
Bug#1055431: RFS: scala-mode-el/1:1.1.0+git20221025.5d7cf21-1 [RC] [Team] -- Emacs major mode for editing scala source code
Nicholas D Steeves writes: > Hi, > > Paul Wise writes: > >> On Mon, 2023-12-04 at 02:28 -0800, Xiyue Deng wrote: >> >>> I think dh_auto_clean is the right place, because the build failure is >>> because that the clean target requires the existence of >>> scala-mode-pkg.el, which is generated by Cask. As we don't have Cask, >>> we need to provide this before dh_auto_clean runs. > > The generation of this metadata, and file, is one of dh_elpa's primary > functions. See the section of the dh_elpa man page that discusses > DEB_VERSION_UPSTREAM. Ah I see what you mean: as long as dh_elpa can detect the version correctly we don't need to provide an actual *-pkg.el file and can just let dh_elpa generate it, which also avoids the potential policy violation Paul pointed out. So now I make override_dh_auto_clean to call dh_elpa to generate this file for use. However, as the generated file is "buried" pretty deep in the generated directory, the command becomes pretty long, but it works. Admittedly that requiring a generated file during clean is pretty exotic and I haven't encountered it elsewhere (yet) which is good. New handling strategy pushed to team repo. PTAL. > > Read Policy §4.9 closely; Cask cannot be used. > > Grep the buildlog for "dh_" and if you'd like to see a more > comprehensive list of applicable entry points in the sequence, try > > $ dh binary-indep --no-act > > It's also worth reading the dh man page. Ack. > >> I think it is against ftp-master rules to have generated files >> present that can't be built using only tools from Debian main. > > Yes, and thank you for bringing this up. > >> So I think you would need to package Cask first? > > Cask is not relevant nor needed, and dh_elpa is used. Whenever this > topic comes up on IRC, new contributors are briefed and are additionally > referred to the RFP for Cask, where the unsuitability of this type of > tool for Debian packaging is discussed (#837922). It's also worth > noting that dh_elpa was written by people by current and/or past members > of the Debian TC. > > Xiyue Deng writes: > >> Cask and similar tools like Eask and Eldev are tools that automatically >> install dependencies of an Emacs addon package, which doesn't use and >> circumvents the system package management. I think the Emacsen team >> chooses not to package those tools and prefers using dh-elpa for the >> job, and may override build target to avoid using those tools. > > If you're familiar with the concept of "hats", then when you're working > on debian/* you need to put on your Debian packaging hat, and when > you're working on !(debian/*) you use your upstream > development/debugging/packaging hat. These tools are not relevant to > Debian packaging and referring to them is not useful for describing > packaging problems or decisions; there will always be a more direct and > useful description. I think those external tools are not completely irrelevant but just in the sense that we do it the Debian way. Usually they provide two types of functions: 1) automatic dependency management, and 2) automatic file generation required for testing and distribution through elpa. In Debian, the former is handled by apt, and the latter by dh_elpa, and we take effort to make sure they behave the same. > > Cheers, > Nicholas > -- Xiyue Deng signature.asc Description: PGP signature
Bug#1055431: RFS: scala-mode-el/1:1.1.0+git20221025.5d7cf21-1 [RC] [Team] -- Emacs major mode for editing scala source code
Hi Paul, Paul Wise writes: > On Mon, 2023-12-04 at 02:28 -0800, Xiyue Deng wrote: > >> I think dh_auto_clean is the right place, because the build failure is >> because that the clean target requires the existence of >> scala-mode-pkg.el, which is generated by Cask. As we don't have Cask, >> we need to provide this before dh_auto_clean runs. > > I think it is against ftp-master rules to have generated files > present that can't be built using only tools from Debian main. > > So I think you would need to package Cask first? Cask and similar tools like Eask and Eldev are tools that automatically install dependencies of an Emacs addon package, which doesn't use and circumvents the system package management. I think the Emacsen team chooses not to package those tools and prefers using dh-elpa for the job, and may override build target to avoid using those tools. See also [1] and [2] for some previous discussions. [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=837922#15 [2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=875722#16 -- Xiyue Deng signature.asc Description: PGP signature
Bug#1055431: RFS: scala-mode-el/1:1.1.0+git20221025.5d7cf21-1 [RC] [Team] -- Emacs major mode for editing scala source code
Nicholas D Steeves writes: > Xiyue Deng writes: > >> Nicholas D Steeves writes: >>> Xiyue Deng writes: >>>> Nicholas D Steeves writes: >>>> >> >> There are about 3 years of newer commits since 1.1.0, and one of the >> major changes is that it adds support of scala 3 syntax which is not yet >> in a tagged release and would be good to have. > > Ok, you've convinced me :) Convey this information in your changelog > (that's what it's for), because the human maintainer (and any interested > users) of this package deserves to know why you made this change. Indeed, updated the changelog with this[2]. > >> Also seeing the last commit is from the end of last year, I sense that >> upstream may becoming a bit dormant for the time being, which is why I >> prefer to package the latest snapshot instead of waiting for a stable >> release. > > This can also mean that we run the risk of becoming defacto upstream if > they quit at this point, but that said, I agree it's a good cut point as > well as the right thing to do. > >>> Also, do you use this package? >>> >> >> Not on a regular basis, but I do use it a bit once in a while as I try >> to learn a bit of new programming languages every few months. > > Thanks for confirming! > > [snip] > >> And then I just realized: why not just host the scala-mode-pkg.el file >> and substitute the version so that we don't need to update it manually >> on each update? This is now implemented at [1]. > > Substvars make sense ;) > > Also, neat use of a makefile target called from within the dh sequence. > > Are you sure dh_auto_clean is the right place for this override? Skim > its man page, as well as the one for dh_clean before replying. Also, > whenever one overrides something in rules, one needs to document this in > the changelog. I think dh_auto_clean is the right place, because the build failure is because that the clean target requires the existence of scala-mode-pkg.el, which is generated by Cask. As we don't have Cask, we need to provide this before dh_auto_clean runs. > > Please use "cp -a" so timestamps between builds will be reproducible. Done. > What is the rationale for CURDIR? From what I can tell it isn't needed > and should be dropped. I can't find a packaging suggestion on $(CURDIR), but it looks like it also works without it, so I dropped it[3]. > >>> Do you see what will happen when the package is updated to >>> 1.1.1 or newer? Also, why did you choose to set the version to "0.23" >>> rather than "1.1.0"? >> >> Well I didn't choose it (if I did I'd use 1.1.0 :) This is the version >> specified in scala-mode.el[2]. > > I like your choice, and so what if upstream has that! Is it correct? > >>> Did you verify that elpa package version is consistent with the >>> upstream version of the Debian package in bin:elpa-scala-mode that is >>> consumed by users (the binary package)? >>> >> >> I tried install it from stable.melpa.org and yeah it's being >> installed as scala-mode-0.23 even if it's registered as version 1.1.0 >> there[3]. So it's consistent in a sense :P > > Oh my! Sorry for the convoluted sentence I wrote, and I'm impressed > that you were able to make sense of it. Yes, stable.melpa.org publishes > a scala-mode version 1.1.0 elpa package, which contains a scala-mode.el > file with "Package-Version: 0.23", and it also contains a > scala-mode-pkg.el file that overrides the Package-Version to `1.1.0`. > It is because of this pkg.el file that elpa/scala-mode-1.1.0 subdir. > > Meanwhile our elpa-scala-mode 1.1.0-* all declare 0.23, and install to a > scala-mode-0.23 subdir. Thank you for your kind optimism, that's very > gracious. > > Your work reveals that I missed this issue when reviewing 1.1.0-1, > which I appreciate having pointed out. Lets fix it in the upload you've > proposed. Somehow I didn't include this patch I submitted upstream in my last changes. This is done now[1]. > >> Anyway, I have just made a pull request to update this upstream[4] so >> hopefully the versioning will be sane. > > Thank you, and hopefully they'll agree. > >>>>>>* Modernize d/watch using special substitute strings. >>>>> >>>>> Ok, but why? >>>>> >>>> >>>> I believe this provides a more robust way of detecting tags and should >>>> be an encouraged practices. From my own experience, when I find a >>>> d
Bug#1055431: RFS: scala-mode-el/1:1.1.0+git20221025.5d7cf21-1 [RC] [Team] -- Emacs major mode for editing scala source code
Nicholas D Steeves writes: > Xiyue Deng writes: > >> Nicholas D Steeves writes: >> >> >>> Have you asked upstream to tag a release? >>> >> >> Not before your review but done by now at [1] > > Thank you. You may have heard that Debian is a distribution that > privileges the stable release model... When the human maintainer of a > Debian package tracks stable releases, why is importing a snapshot > justified? > There are about 3 years of newer commits since 1.1.0, and one of the major changes is that it adds support of scala 3 syntax which is not yet in a tagged release and would be good to have. Also seeing the last commit is from the end of last year, I sense that upstream may becoming a bit dormant for the time being, which is why I prefer to package the latest snapshot instead of waiting for a stable release. > Also, do you use this package? > Not on a regular basis, but I do use it a bit once in a while as I try to learn a bit of new programming languages every few months. >>>>* Override clean rules in d/rules to fix building. (Closes: >>>>#1052917) >>> >>> I believe you already know that >>> >>> override_dh_auto_clean: >>>/bin/true >>> >>> is an incorrect approach. >>> >> >> Indeed it was not ideal. Upstream depends on Cask to generated the >> scala-mode-pkg.el file that is used in the clean target to get the name >> of the generated tarball, and indeed using this lazy approach is >> incorrect. I've now included the generated pkg file through a patch to >> make this work in [2]. > > Consistency is essential between an explanation (in a comment or > changelog) and the work that was done. > > Statically defining package metadata is fine, but in this case you can't > claim that you're generating the pkg.el file. Oh yes it's generated using Cask following upstream practice. I just include it as a patch as we don't use Cask for Debian packaging. > Either make the changelog and patch description consistent with what > is actually happening, or change the implementation so that something > is actually generated (there are multiple approaches here). I think I > tend to use makefile substvars for this. Personally I prefer not to patch upstream source if not necessary, otherwise we end up carrying the patch for the foreseeable future. Though arguably in this case the scala-mode-pkg.el file needs to be generated/patched which requires I use Cask locally, so it's more or less the same effort. And then I just realized: why not just host the scala-mode-pkg.el file and substitute the version so that we don't need to update it manually on each update? This is now implemented at [1]. > Do you see what will happen when the package is updated to > 1.1.1 or newer? Also, why did you choose to set the version to "0.23" > rather than "1.1.0"? Well I didn't choose it (if I did I'd use 1.1.0 :) This is the version specified in scala-mode.el[2]. > Did you verify that elpa package version is consistent with the > upstream version of the Debian package in bin:elpa-scala-mode that is > consumed by users (the binary package)? > I tried install it from stable.melpa.org and yeah it's being installed as scala-mode-0.23 even if it's registered as version 1.1.0 there[3]. So it's consistent in a sense :P Anyway, I have just made a pull request to update this upstream[4] so hopefully the versioning will be sane. >>>>* Modernize d/watch using special substitute strings. >>> >>> Ok, but why? >>> >> >> I believe this provides a more robust way of detecting tags and should >> be an encouraged practices. From my own experience, when I find a >> d/watch file that doesn't work I may search for other packages to learn >> from existing practices, and some may not work well as different >> upstream may follow different conventions. The substitute strings use a >> more robust and tested regexp that works most of the time, and promoting >> its use may save people's time instead of working on an ad-hoc regexp. > > Sounds good! This is the kind of rationale that should be in the > changelog, so please add it there :) From now on, read your changelog > and patche desriptions, and imagine I'm asking you "ok, but why" for > each point. Yes, rarely something is self-evident and/or an > implementation detail, but most of the time you should say a few words > explaining "why"--particularly when you want to find a sponsor quickly. > My expectation is that you get better at this with each review, and that > you will
Bug#1054523: RFS: persp-projectile/1:1.0.0+git20210618.4e374d7-1 [RC] [Team] -- integrate perspective.el with projectile
Xiyue Deng writes: > Hi Sean, > > Thanks for the review! I initially thought d/changelog should mainly be > about user-facing changes. But looks like it's better to be thorough. > Please see replies inline below. > > Sean Whitton writes: > >> control: tag -1 + moreinfo >> control: owner -1 ! >> >> Hello Xiyue, >> >> Thank you for working on this. >> A review of 2ea5e050fe78c7a382a613bc60ce5f14da4f130a: >> >> I'm wondering why you've updated git watch to check for the git HEAD, >> since upstream seems to now be tagging releases? >> > > I could have mixed the impression with other repos that don't have it. > Now tracking tags and slightly modernize it using "@ANY_VERSION@". > >> The changelog should mention the switch d/compat -> debhelper-compat. >> > > Done. > >> The typo fix in d/control should be mentioned in d/changelog. >> > > Done. > >> You should say that it's --parallel that you dropped from d/rules. >> > > Done. > >> Your justification for dropping the Built-Using should not be that >> Lintian suggested dropping it. Please determine the real reason :) > > I thought mentioning dropping Built-Using from arch:all package could be > an acceptable reason, which in turn also follows Lintian's suggestion :) > But do let me know if I should further clarify. > > New updates pushed to team repo and reuploaded to mentors. PTAL. TIA! Friendly ping :) -- Xiyue Deng signature.asc Description: PGP signature
Bug#1055431: RFS: scala-mode-el/1:1.1.0+git20221025.5d7cf21-1 [RC] [Team] -- transitional dummy package, scala-mode-el to elpa-scala-mode
Hi Nicholas, Thanks for your review! Please see my replies inline below. Nicholas D Steeves writes: > Control: retitle -1 RFS: scala-mode-el/1:1.1.0+git20221025.5d7cf21-1 [RC] > [Team] -- Emacs major mode for editing scala source code > > Xiyue Deng writes: > > [snip] >>[ Xiyue Deng ] >>* Sync to latest upstream head (5d7cf21). > > Have you asked upstream to tag a release? > Not before your review but done by now at [1] >>* Override clean rules in d/rules to fix building. (Closes: >>#1052917) > > I believe you already know that > > override_dh_auto_clean: >/bin/true > > is an incorrect approach. > Indeed it was not ideal. Upstream depends on Cask to generated the scala-mode-pkg.el file that is used in the clean target to get the name of the generated tarball, and indeed using this lazy approach is incorrect. I've now included the generated pkg file through a patch to make this work in [2]. >>* Modernize d/watch using special substitute strings. > > Ok, but why? > I believe this provides a more robust way of detecting tags and should be an encouraged practices. From my own experience, when I find a d/watch file that doesn't work I may search for other packages to learn from existing practices, and some may not work well as different upstream may follow different conventions. The substitute strings use a more robust and tested regexp that works most of the time, and promoting its use may save people's time instead of working on an ad-hoc regexp. >>* Add more metadata in d/upstream/metadata. > > https://github.com/hvesalai/emacs-scala-mode/commits/master > > is a git history log, not a changelog nor release notes. > I thought the git history log may be considered an alternative form of a Changelog. Looks like I was wrong except for projects that requires the same format across changelog/git history/release notes. I've dropped that line in [3]. >>* Update year and Upstream-Contact and add myself in d/copyright. > > Why did you add yourself? > https://en.wikipedia.org/wiki/Threshold_of_originality > > I'm happy to support your claim, but you'll need to work for it in more > than a "sweat of the brow"/mechanical sense. > To be honest, the only reason I did this is to suppress the "update-debian-copyright" lintian warning which is actually experimental. I believe what I did was in the same nature as Sławomir did in 2020 though admittedly not to the same extent, so I've reverted this part in [4]. >>* Use xz compression in d/gbp.conf. > > Why is this useful when it has been the default since gbp 0.9.15? > I'm pretty sure that if I don't add this "git deborig" will create the tarball using gzip instead. And it looks like the commit from 0.9.15 just changed the value in the comment[5]. Please let me know if there is any other option that I missed that makes it use xz. > > Best, > Nicholas > I've committed the new changes (sans "Release to unstable" commit) to the team repo and reuploaded to mentors[6]. PTAL, and TIA! [1] https://github.com/hvesalai/emacs-scala-mode/issues/182 [2] https://salsa.debian.org/emacsen-team/scala-mode-el/-/commit/bc32e3dbf3983c5cf8d4eab98be25e67a9016310 [3] https://salsa.debian.org/emacsen-team/scala-mode-el/-/commit/0ddf10c8e88ae0e6d52ce02968dd678aceeab6f7 [4] https://salsa.debian.org/emacsen-team/scala-mode-el/-/commit/203a3d718956f14bc991b61e4bf9a02bdacd1756 [5] https://salsa.debian.org/agx/git-buildpackage/-/commit/d1960b3dc0dfbb6be2183e555e615864468b234c [6] https://mentors.debian.net/package/scala-mode-el/ -- Xiyue Deng signature.asc Description: PGP signature
Bug#1055431: RFS: scala-mode-el/1:1.1.0+git20221025.5d7cf21-1 [RC] [Team] -- transitional dummy package, scala-mode-el to elpa-scala-mode
Package: sponsorship-requests Severity: important X-Debbugs-CC: debian-emac...@lists.debian.org Dear mentors, I am looking for a sponsor for my package "scala-mode-el": * Package name : scala-mode-el Version : 1:1.1.0+git20221025.5d7cf21-1 Upstream contact : Heikki Vesalainen * URL : https://github.com/hvesalai/emacs-scala-mode * License : SCALA-LICENSE, GPL-3+ * Vcs : https://salsa.debian.org/emacsen-team/scala-mode-el Section : editors The source builds the following binary packages: elpa-scala-mode - Emacs major mode for editing scala source code scala-mode-el - transitional dummy package, scala-mode-el to elpa-scala-mode To access further information about this package, please visit the following URL: https://mentors.debian.net/package/scala-mode-el/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/s/scala-mode-el/scala-mode-el_1.1.0+git20221025.5d7cf21-1.dsc Changes since the last upload: scala-mode-el (1:1.1.0+git20221025.5d7cf21-1) unstable; urgency=medium . * Team upload. . [ Debian Janitor ] * Set upstream metadata fields: Repository-Browse. * Update standards version to 4.6.1, no changes needed. * Set upstream metadata fields: Repository. * Update standards version to 4.6.2, no changes needed. . [ Xiyue Deng ] * Sync to latest upstream head (5d7cf21). * Override clean rules in d/rules to fix building. (Closes: #1052917) * Modernize d/watch using special substitute strings. * Add more metadata in d/upstream/metadata. * Update year and Upstream-Contact and add myself in d/copyright. * Use xz compression in d/gbp.conf. Regards, -- Xiyue Deng
Bug#1055379: RFS: clojure-mode/5.18.0-1 [RC] [Team] -- extra font-locking for clojure-mode
Package: sponsorship-requests Severity: important X-Debbugs-CC: debian-emac...@lists.debian.org Dear mentors, I am looking for a sponsor for my package "clojure-mode": * Package name : clojure-mode Version : 5.18.0-1 Upstream contact : Bozhidar Batsov * URL : https://github.com/clojure-emacs/clojure-mode * License : GPL-3+ * Vcs : https://salsa.debian.org/emacsen-team/clojure-mode Section : lisp The source builds the following binary packages: elpa-clojure-mode - Emacs major mode for Clojure code elpa-clojure-mode-extra-font-locking - extra font-locking for clojure-mode To access further information about this package, please visit the following URL: https://mentors.debian.net/package/clojure-mode/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/c/clojure-mode/clojure-mode_5.18.0-1.dsc Changes since the last upload: clojure-mode (5.18.0-1) unstable; urgency=medium . * Team upload. . [ Sean Whitton ] * New upstream release. * Update path in d/elpa-test. * Update copyright years. . [ Nicholas D Steeves ] * Drop emacs25 from Enhances (package does not exist in bullseye). . [ Xiyue Deng ] * New upstream release (Closes: #1052961). * Refresh patches. * Migrate from d/compat to debhelper-compat version 13. * Drop emacs version requires as they were met since oldoldstable. * Update Standards-Version to 4.6.2. No change needed. * Modernize d/watch using special strings. * Add d/upstream/metadata. * Update year and add Upstream-Contact in d/copyright. * Add d/gbp.conf. Regards, -- Xiyue Deng
Bug#1054523: RFS: persp-projectile/1:1.0.0+git20210618.4e374d7-1 [RC] [Team] -- integrate perspective.el with projectile
Hi Sean, Thanks for the review! I initially thought d/changelog should mainly be about user-facing changes. But looks like it's better to be thorough. Please see replies inline below. Sean Whitton writes: > control: tag -1 + moreinfo > control: owner -1 ! > > Hello Xiyue, > > Thank you for working on this. > A review of 2ea5e050fe78c7a382a613bc60ce5f14da4f130a: > > I'm wondering why you've updated git watch to check for the git HEAD, > since upstream seems to now be tagging releases? > I could have mixed the impression with other repos that don't have it. Now tracking tags and slightly modernize it using "@ANY_VERSION@". > The changelog should mention the switch d/compat -> debhelper-compat. > Done. > The typo fix in d/control should be mentioned in d/changelog. > Done. > You should say that it's --parallel that you dropped from d/rules. > Done. > Your justification for dropping the Built-Using should not be that > Lintian suggested dropping it. Please determine the real reason :) I thought mentioning dropping Built-Using from arch:all package could be an acceptable reason, which in turn also follows Lintian's suggestion :) But do let me know if I should further clarify. New updates pushed to team repo and reuploaded to mentors. PTAL. TIA! -- Xiyue Deng signature.asc Description: PGP signature
Bug#1054422: RFS: pointback/0.2-5 [RC] [Team] -- restore window points when returning to buffers
Tobias Frost writes: > On Mon, Oct 23, 2023 at 10:12:50AM -0700, Xiyue Deng wrote: >> Package: sponsorship-requests >> Severity: important >> X-Debbugs-CC: debian-emac...@lists.debian.org >> >> Dear mentors, >> >> I am looking for a sponsor for my package "pointback": >> >> * Package name : pointback >>Version : 0.2-5 >>Upstream contact : Markus Triska >> * URL : https://www.metalevel.at/pointback/ >> * License : GPL-3+ >> * Vcs : https://salsa.debian.org/emacsen-team/pointback >>Section : lisp >> >> The source builds the following binary packages: >> >> elpa-pointback - restore window points when returning to buffers >> >> To access further information about this package, please visit the following >> URL: >> >> https://mentors.debian.net/package/pointback/ >> >> Alternatively, you can download the package with 'dget' using this command: >> >> dget -x >> https://mentors.debian.net/debian/pool/main/p/pointback/pointback_0.2-5.dsc >> >> Changes since the last upload: >> >> pointback (0.2-5) unstable; urgency=medium >> . >>* Team upload. >> . >>[ Nicholas D Steeves ] >>* Drop emacs24 and emacs25 from Enhances (packages do not exist in >> bullseye). >> . >>[ Debian Janitor ] >>* Bump debhelper from old 10 to 13. >>* Set debhelper-compat version in Build-Depends. >> . >>[ Xiyue Deng ] >>* Add patch migrate-from-removed-assoc-el.patch to migrate from >> obsoleted functions in assoc.el which has been removed since Emacs >> 29.1 (Closes: #1042900). >>* Drop Built-Using which should not be used for an "arch: all" package. >>* Update Standards-Version to 4.6.2. No change needed. >>* Drop emacs version in Recommends which is from oldoldstable. >>* Add d/watch with comments of no real upstream version control. >>* Update d/copyright year and add Upstream-Contact. >> >> Regards, >> -- >> Xiyue Deng > > Looks good, but one question: > Upstream says: > > As of Emacs 26.1, switch-to-buffer-preserve-window-point defaults to t, which > solves the problem that pointback.el addresses. > Indeed, I've tested that this flag enables the same effect of pointback.el. > Is this pacakge (pointback) obsolete and should it be kept in Debian? > Will file an RM request. Thanks for looking into this! > (As the package is fine, I'm uploadig it, but if it is obsolete, please > file a bug for removal.) > > > Please also investiate: > I: elpa-pointback: wrong-section-according-to-package-name lisp => editors -- Xiyue Deng
Bug#1054494: RFS: lsp-mode/8.0.0-6 [ITA] [RC] -- Emacs client/library for the Language Server Protocol
Bo YU writes:
> Hi!
>
> On Fri, Oct 27, 2023 at 10:30 AM Xiyue Deng wrote:
>>
>> Xiyue Deng writes:
>>
>> > Hi Bo,
>> >
>> > Bo YU writes:
>> >
>> >> Hi!
>> >>
>> >> On Thu, Oct 26, 2023 at 7:02 AM Xiyue Deng wrote:
>> >>
>> >> ...
>> >>>
>> >>> For the unlikely but possible cause that tests with a long name is a
>> >>> prefix of other tests that may trigger this issue, I have modified the
>> >>> test name for testing purposes. Can you help get the latest upload on
>> >>> mentors and try again? TIA.
>> >>>
>> >> I tried this and it seems the issue was raised with my sbuild build
>> >> environment.
>> >> I still got this:
>> >> https://paste.debian.net/1296268/
>> >>
>> >> My sbuilderrc is here:
>> >> https://paste.debian.net/1296269/
>> >>
>> >> But if use pbuilder[0] to build your package, it is ok.
>> >> So I think your package which is no problem.
>> >>
>> >> BTW, I suspect the network accessing leads to the issue and I am annoy
>> >> how to
>> >> disable network access during building for sbuild.
>> >>
>> >> BR,
>> >> Bo
>> >> [0]: https://wiki.ubuntu.com/PbuilderHowto
>> >
>> > Thanks for testing! The reason I'm interested in reproducing this error
>> > is that in the report of the RC bug that this upload is trying to solve
>> > - https://bugs.debian.org/1052939 - the build log from Lucas has exactly
>> > the same error:
>> >
>> > ,
>> > | ...
>> > | > Test ‘lsp-text-document-hover-request’ redefined
>> > | >
>> > | > Error: error ("Test ‘lsp-text-document-hover-request’ redefined")
>> > | ...
>> > `
>> >
>> > But I haven't been able to reproduce this until Arto and you sent your
>> > reports, and this being reproduced by two people makes this more
>> > interesting. There must be something that may trigger this unlikely
>> > error. Also I'm not sure whether the network accessing may have been
>> > the cause as sbuild needs to download the dependencies and without
>> > something like apt-cacher{,-ng} it does need network access for that to
>> > happen.
>> >
>> > I suspected that the parallel setting in $DEB_BUILD_OPTIONS may have
>> > affected it so I copied your sbuild settings and tried again but
>> > unfortunately it still succeeded for me. For the unlikely event and for
>> > completeness, can you also try to turn that off in your sbuild config
>> > and retry just in case? TIA.
>> >
>>
>> Actually scratch my previous mail, as I found how to produce the issue.
>> In `lsp-clangd-test.el' it does `(require 'lsp-integration-test)', so if
>> `lsp-clangd-test.el' is loaded before `lsp-integration-test.el', it
>> seems the test symbols in the latter are loaded twice that triggers the
>> error regardless of whether there is an actual duplicated test name. I
>> can confirm that in your build log that the clangd one was loaded first
>> which causes this error. I assume Arto sees it due to the same cause.
>>
>> I have added another change to override dh_elpa_test to ensure
>> `lsp-clangd-test' is loaded last and uploaded to mentors. Please help
>> test again.
>
> This time the package can be built on my sbuild environment.
> Please go ahead.
>
Thanks for testing!
I have pushed the change to salsa. Waiting for sponsor upload to push
the final commit of `dch -r` and tags.
> BR,
> Bo
>>
>> I'll probably also report this issue upstream to see how it should be
>> handled.
>>
>> >>> ,
>> >>> | $ dget -x
>> >>> https://mentors.debian.net/debian/pool/main/l/lsp-mode/lsp-mode_8.0.0-6.dsc
>> >>> | $ sbuild lsp-mode_8.0.0-6.dsc
>> >>> `
>> >>>
>> >>> P.S. If you can provide the failed build log and ~/.sbuildrc it may
>> >>> still help to eliminate potential sbuild differences in our environment.
>> >>>
>> >>> >>
>> >>> >> BR,
>> >>> >> Bo
>> >>> >>>
>> >>> >>> --
>> >>> >>> Arto Jantunen
>> >>> >>>
>> >>>
>> >>> --
>> >>> Xiyue Deng
>>
>> --
>> Xiyue Deng
--
Xiyue Deng
Bug#1054494: RFS: lsp-mode/8.0.0-6 [ITA] [RC] -- Emacs client/library for the Language Server Protocol
Xiyue Deng writes:
> Hi Bo,
>
> Bo YU writes:
>
>> Hi!
>>
>> On Thu, Oct 26, 2023 at 7:02 AM Xiyue Deng wrote:
>>
>> ...
>>>
>>> For the unlikely but possible cause that tests with a long name is a
>>> prefix of other tests that may trigger this issue, I have modified the
>>> test name for testing purposes. Can you help get the latest upload on
>>> mentors and try again? TIA.
>>>
>> I tried this and it seems the issue was raised with my sbuild build
>> environment.
>> I still got this:
>> https://paste.debian.net/1296268/
>>
>> My sbuilderrc is here:
>> https://paste.debian.net/1296269/
>>
>> But if use pbuilder[0] to build your package, it is ok.
>> So I think your package which is no problem.
>>
>> BTW, I suspect the network accessing leads to the issue and I am annoy how to
>> disable network access during building for sbuild.
>>
>> BR,
>> Bo
>> [0]: https://wiki.ubuntu.com/PbuilderHowto
>
> Thanks for testing! The reason I'm interested in reproducing this error
> is that in the report of the RC bug that this upload is trying to solve
> - https://bugs.debian.org/1052939 - the build log from Lucas has exactly
> the same error:
>
> ,
> | ...
> | > Test ‘lsp-text-document-hover-request’ redefined
> | >
> | > Error: error ("Test ‘lsp-text-document-hover-request’ redefined")
> | ...
> `
>
> But I haven't been able to reproduce this until Arto and you sent your
> reports, and this being reproduced by two people makes this more
> interesting. There must be something that may trigger this unlikely
> error. Also I'm not sure whether the network accessing may have been
> the cause as sbuild needs to download the dependencies and without
> something like apt-cacher{,-ng} it does need network access for that to
> happen.
>
> I suspected that the parallel setting in $DEB_BUILD_OPTIONS may have
> affected it so I copied your sbuild settings and tried again but
> unfortunately it still succeeded for me. For the unlikely event and for
> completeness, can you also try to turn that off in your sbuild config
> and retry just in case? TIA.
>
Actually scratch my previous mail, as I found how to produce the issue.
In `lsp-clangd-test.el' it does `(require 'lsp-integration-test)', so if
`lsp-clangd-test.el' is loaded before `lsp-integration-test.el', it
seems the test symbols in the latter are loaded twice that triggers the
error regardless of whether there is an actual duplicated test name. I
can confirm that in your build log that the clangd one was loaded first
which causes this error. I assume Arto sees it due to the same cause.
I have added another change to override dh_elpa_test to ensure
`lsp-clangd-test' is loaded last and uploaded to mentors. Please help
test again.
I'll probably also report this issue upstream to see how it should be
handled.
>>> ,
>>> | $ dget -x
>>> https://mentors.debian.net/debian/pool/main/l/lsp-mode/lsp-mode_8.0.0-6.dsc
>>> | $ sbuild lsp-mode_8.0.0-6.dsc
>>> `
>>>
>>> P.S. If you can provide the failed build log and ~/.sbuildrc it may
>>> still help to eliminate potential sbuild differences in our environment.
>>>
>>> >>
>>> >> BR,
>>> >> Bo
>>> >>>
>>> >>> --
>>> >>> Arto Jantunen
>>> >>>
>>>
>>> --
>>> Xiyue Deng
--
Xiyue Deng
Bug#1054494: RFS: lsp-mode/8.0.0-6 [ITA] [RC] -- Emacs client/library for the Language Server Protocol
Hi Bo,
Bo YU writes:
> Hi!
>
> On Thu, Oct 26, 2023 at 7:02 AM Xiyue Deng wrote:
>
> ...
>>
>> For the unlikely but possible cause that tests with a long name is a
>> prefix of other tests that may trigger this issue, I have modified the
>> test name for testing purposes. Can you help get the latest upload on
>> mentors and try again? TIA.
>>
> I tried this and it seems the issue was raised with my sbuild build
> environment.
> I still got this:
> https://paste.debian.net/1296268/
>
> My sbuilderrc is here:
> https://paste.debian.net/1296269/
>
> But if use pbuilder[0] to build your package, it is ok.
> So I think your package which is no problem.
>
> BTW, I suspect the network accessing leads to the issue and I am annoy how to
> disable network access during building for sbuild.
>
> BR,
> Bo
> [0]: https://wiki.ubuntu.com/PbuilderHowto
Thanks for testing! The reason I'm interested in reproducing this error
is that in the report of the RC bug that this upload is trying to solve
- https://bugs.debian.org/1052939 - the build log from Lucas has exactly
the same error:
,
| ...
| > Test ‘lsp-text-document-hover-request’ redefined
| >
| > Error: error ("Test ‘lsp-text-document-hover-request’ redefined")
| ...
`
But I haven't been able to reproduce this until Arto and you sent your
reports, and this being reproduced by two people makes this more
interesting. There must be something that may trigger this unlikely
error. Also I'm not sure whether the network accessing may have been
the cause as sbuild needs to download the dependencies and without
something like apt-cacher{,-ng} it does need network access for that to
happen.
I suspected that the parallel setting in $DEB_BUILD_OPTIONS may have
affected it so I copied your sbuild settings and tried again but
unfortunately it still succeeded for me. For the unlikely event and for
completeness, can you also try to turn that off in your sbuild config
and retry just in case? TIA.
>> ,
>> | $ dget -x
>> https://mentors.debian.net/debian/pool/main/l/lsp-mode/lsp-mode_8.0.0-6.dsc
>> | $ sbuild lsp-mode_8.0.0-6.dsc
>> `
>>
>> P.S. If you can provide the failed build log and ~/.sbuildrc it may
>> still help to eliminate potential sbuild differences in our environment.
>>
>> >>
>> >> BR,
>> >> Bo
>> >>>
>> >>> --
>> >>> Arto Jantunen
>> >>>
>>
>> --
>> Xiyue Deng
--
Xiyue Deng
Bug#1054494: RFS: lsp-mode/8.0.0-6 [ITA] [RC] -- Emacs client/library for the Language Server Protocol
Hi Arto, Bo,
Xiyue Deng writes:
> Hi Bo,
>
> Bo YU writes:
>
>> Hi!
>>
>> On Wed, Oct 25, 2023 at 5:06 PM Arto Jantunen wrote:
>>>
>>> Xiyue Deng writes:
>>>
>>> > Arto Jantunen writes:
>>> >
>>> >> Xiyue Deng writes:
>>> >>
>>> >>> Hi Arto,
>>> >>>
>>> >>> Arto Jantunen writes:
>>> >>>
>>> >>>> Xiyue Deng writes:
>>> >>>>> Package: sponsorship-requests
>>> >>>>> Severity: important
>>> >>>>> X-Debbugs-CC: debian-emac...@lists.debian.org
>>> >>>>>
>>> >>>>> Dear mentors,
>>> >>>>>
>>> >>>>> I am looking for a sponsor for my package "lsp-mode":
>>> >>>>>
>>> >>>>> * Package name : lsp-mode
>>> >>>>>Version : 8.0.0-6
>>> >>>>>Upstream contact : Vibhav Pant
>>> >>>>> * URL : https://github.com/emacs-lsp/lsp-mode
>>> >>>>> * License : GPL-3+
>>> >>>>> * Vcs : https://salsa.debian.org/emacsen-team/lsp-mode
>>> >>>>>Section : lisp
>>> >>>>>
>>> >>>>> The source builds the following binary packages:
>>> >>>>>
>>> >>>>> elpa-lsp-mode - Emacs client/library for the Language Server
>>> >>>>> Protocol
>>> >>>>>
>>> >>>>> To access further information about this package, please visit the
>>> >>>>> following URL:
>>> >>>>>
>>> >>>>> https://mentors.debian.net/package/lsp-mode/
>>> >>>>>
>>> >>>>> Alternatively, you can download the package with 'dget' using this
>>> >>>>> command:
>>> >>>>>
>>> >>>>> dget -x
>>> >>>>> https://mentors.debian.net/debian/pool/main/l/lsp-mode/lsp-mode_8.0.0-6.dsc
>>> >>>>>
>>> >>>>> Changes since the last upload:
>>> >>>>>
>>> >>>>> lsp-mode (8.0.0-6) unstable; urgency=medium
>>> >>>>> .
>>> >>>>>* Add patch to fix test failures (Closes: #1052939).
>>> >>>>>* Update Standards-Version to 4.6.2. No change needed.
>>> >>>>>* Add myself as uploader (Closes: #1042568).
>>> >>>>>* Add signing key verification to d/watch.
>>> >>>>>* Add d/upstream/metadata.
>>> >>>>>* Add Upstream-Contact and update year in d/copyright.
>>> >>>>>* Add patch to fix non-UTF-8 encoding.
>>> >>>>>* Drop unused lintian overrides.
>>> >>>>
>>> >>>> Thanks for taking over this package.
>>> >>>>
>>> >>>> When I try to build this (under sbuild) I get the following build
>>> >>>> failure:
>>> >>>>
>>> >>>> Test ‘lsp-text-document-hover-request’ redefined
>>> >>>>
>>> >>>> Error: error ("Test ‘lsp-text-document-hover-request’ redefined")
>>> >>>> mapbacktrace(#f(compiled-function (evald func args flags) #>> >>>> -0x187de6214517952>))
>>> >>>> debug-early-backtrace()
>>> >>>> debug-early(error (error "Test ‘lsp-text-document-hover-request’
>>> >>>> redefined"))
>>> >>>> error("Test `%s' redefined" lsp-text-document-hover-request)
>>> >>>> ert-set-test(lsp-text-document-hover-request #s(ert-test :name
>>> >>>> lsp-text-document-hover-request :documentation nil :body (closure (t)
>>> >>>> nil
>>> >>>> (lsp-workspace-folders-add (f-join lsp-test-location "fixtures"))
>>> >>>> (find-file
>>> >>>> (f-join lsp-test-location "fixtures/pyls/test.py")) (lsp)
>>> >>>> (deferred:sync!
>>> >>>> (deferred:nextc (deferred:nextc (lsp-test--wait-for '(progn (eq
>>> >>>> 'initialized
&g
Bug#1054419: RFS: go-mode.el/3:1.6.0+git202300823.8dce1e3-1 [RC] [Team] -- Emacs mode for editing Go code
Xiyue Deng writes: > Package: sponsorship-requests > Severity: important > X-Debbugs-CC: debian-emac...@lists.debian.org > > Dear mentors, > > I am looking for a sponsor for my package "go-mode.el": > > * Package name : go-mode.el >Version : 3:1.6.0+git202300823.8dce1e3-1 >Upstream contact : Dominik Honnef > * URL : https://github.com/dominikh/go-mode.el > * License : BSD-3-clasue > * Vcs : https://salsa.debian.org/emacsen-team/go-mode.el >Section : lisp > > The source builds the following binary packages: > > elpa-go-mode - Emacs mode for editing Go code > > To access further information about this package, please visit the following > URL: > > https://mentors.debian.net/package/go-mode.el/ > > Alternatively, you can download the package with 'dget' using this command: > > dget -x > https://mentors.debian.net/debian/pool/main/g/go-mode.el/go-mode.el_1.6.0+git202300823.8dce1e3-1.dsc > > Changes since the last upload: > > go-mode.el (3:1.6.0+git202300823.8dce1e3-1) unstable; urgency=medium > . >* Team upload. >* Sync to latest upstream head (8dce1e3). >* Apply patch to drop duplicated test (Closes: #1052922). >* Drop Built-Using which should not be used on an "arch:all" package. >* Add DEP5 headers for fix-test-path.patch. >* Update year and add Upstream-Contact in d/copyright. >* Use git mode and fix lintian warnings in d/watch. > > Regards, The previous uploads had a typo in the version number. This has been fixed in the latest upload. -- Xiyue Deng
Bug#1054494: RFS: lsp-mode/8.0.0-6 [ITA] [RC] -- Emacs client/library for the Language Server Protocol
Hi Bo,
Bo YU writes:
> Hi!
>
> On Wed, Oct 25, 2023 at 5:06 PM Arto Jantunen wrote:
>>
>> Xiyue Deng writes:
>>
>> > Arto Jantunen writes:
>> >
>> >> Xiyue Deng writes:
>> >>
>> >>> Hi Arto,
>> >>>
>> >>> Arto Jantunen writes:
>> >>>
>> >>>> Xiyue Deng writes:
>> >>>>> Package: sponsorship-requests
>> >>>>> Severity: important
>> >>>>> X-Debbugs-CC: debian-emac...@lists.debian.org
>> >>>>>
>> >>>>> Dear mentors,
>> >>>>>
>> >>>>> I am looking for a sponsor for my package "lsp-mode":
>> >>>>>
>> >>>>> * Package name : lsp-mode
>> >>>>>Version : 8.0.0-6
>> >>>>>Upstream contact : Vibhav Pant
>> >>>>> * URL : https://github.com/emacs-lsp/lsp-mode
>> >>>>> * License : GPL-3+
>> >>>>> * Vcs : https://salsa.debian.org/emacsen-team/lsp-mode
>> >>>>>Section : lisp
>> >>>>>
>> >>>>> The source builds the following binary packages:
>> >>>>>
>> >>>>> elpa-lsp-mode - Emacs client/library for the Language Server Protocol
>> >>>>>
>> >>>>> To access further information about this package, please visit the
>> >>>>> following URL:
>> >>>>>
>> >>>>> https://mentors.debian.net/package/lsp-mode/
>> >>>>>
>> >>>>> Alternatively, you can download the package with 'dget' using this
>> >>>>> command:
>> >>>>>
>> >>>>> dget -x
>> >>>>> https://mentors.debian.net/debian/pool/main/l/lsp-mode/lsp-mode_8.0.0-6.dsc
>> >>>>>
>> >>>>> Changes since the last upload:
>> >>>>>
>> >>>>> lsp-mode (8.0.0-6) unstable; urgency=medium
>> >>>>> .
>> >>>>>* Add patch to fix test failures (Closes: #1052939).
>> >>>>>* Update Standards-Version to 4.6.2. No change needed.
>> >>>>>* Add myself as uploader (Closes: #1042568).
>> >>>>>* Add signing key verification to d/watch.
>> >>>>>* Add d/upstream/metadata.
>> >>>>>* Add Upstream-Contact and update year in d/copyright.
>> >>>>>* Add patch to fix non-UTF-8 encoding.
>> >>>>>* Drop unused lintian overrides.
>> >>>>
>> >>>> Thanks for taking over this package.
>> >>>>
>> >>>> When I try to build this (under sbuild) I get the following build
>> >>>> failure:
>> >>>>
>> >>>> Test ‘lsp-text-document-hover-request’ redefined
>> >>>>
>> >>>> Error: error ("Test ‘lsp-text-document-hover-request’ redefined")
>> >>>> mapbacktrace(#f(compiled-function (evald func args flags) #> >>>> -0x187de6214517952>))
>> >>>> debug-early-backtrace()
>> >>>> debug-early(error (error "Test ‘lsp-text-document-hover-request’
>> >>>> redefined"))
>> >>>> error("Test `%s' redefined" lsp-text-document-hover-request)
>> >>>> ert-set-test(lsp-text-document-hover-request #s(ert-test :name
>> >>>> lsp-text-document-hover-request :documentation nil :body (closure (t)
>> >>>> nil
>> >>>> (lsp-workspace-folders-add (f-join lsp-test-location "fixtures"))
>> >>>> (find-file
>> >>>> (f-join lsp-test-location "fixtures/pyls/test.py")) (lsp)
>> >>>> (deferred:sync!
>> >>>> (deferred:nextc (deferred:nextc (lsp-test--wait-for '(progn (eq
>> >>>> 'initialized
>> >>>> (lsp--workspace-status (cl-first (lsp-workspaces)) #'(lambda (_)
>> >>>> (goto-char
>> >>>> (point-min)) (search-forward "fn1") (lsp-def-request-async
>> >>>> "textDocument/hover"
>> >>>> (lsp--text-document-position-params #'(lambda (contents) (let*
>> >>&g
Bug#1054494: RFS: lsp-mode/8.0.0-6 [ITA] [RC] -- Emacs client/library for the Language Server Protocol
Arto Jantunen writes:
> Xiyue Deng writes:
>
>> Arto Jantunen writes:
>>
>>> Xiyue Deng writes:
>>>
>>>> Hi Arto,
>>>>
>>>> Arto Jantunen writes:
>>>>
>>>>> Xiyue Deng writes:
>>>>>> Package: sponsorship-requests
>>>>>> Severity: important
>>>>>> X-Debbugs-CC: debian-emac...@lists.debian.org
>>>>>>
>>>>>> Dear mentors,
>>>>>>
>>>>>> I am looking for a sponsor for my package "lsp-mode":
>>>>>>
>>>>>> * Package name : lsp-mode
>>>>>>Version : 8.0.0-6
>>>>>>Upstream contact : Vibhav Pant
>>>>>> * URL : https://github.com/emacs-lsp/lsp-mode
>>>>>> * License : GPL-3+
>>>>>> * Vcs : https://salsa.debian.org/emacsen-team/lsp-mode
>>>>>>Section : lisp
>>>>>>
>>>>>> The source builds the following binary packages:
>>>>>>
>>>>>> elpa-lsp-mode - Emacs client/library for the Language Server Protocol
>>>>>>
>>>>>> To access further information about this package, please visit the
>>>>>> following URL:
>>>>>>
>>>>>> https://mentors.debian.net/package/lsp-mode/
>>>>>>
>>>>>> Alternatively, you can download the package with 'dget' using this
>>>>>> command:
>>>>>>
>>>>>> dget -x
>>>>>> https://mentors.debian.net/debian/pool/main/l/lsp-mode/lsp-mode_8.0.0-6.dsc
>>>>>>
>>>>>> Changes since the last upload:
>>>>>>
>>>>>> lsp-mode (8.0.0-6) unstable; urgency=medium
>>>>>> .
>>>>>>* Add patch to fix test failures (Closes: #1052939).
>>>>>>* Update Standards-Version to 4.6.2. No change needed.
>>>>>>* Add myself as uploader (Closes: #1042568).
>>>>>>* Add signing key verification to d/watch.
>>>>>>* Add d/upstream/metadata.
>>>>>>* Add Upstream-Contact and update year in d/copyright.
>>>>>>* Add patch to fix non-UTF-8 encoding.
>>>>>>* Drop unused lintian overrides.
>>>>>
>>>>> Thanks for taking over this package.
>>>>>
>>>>> When I try to build this (under sbuild) I get the following build
>>>>> failure:
>>>>>
>>>>> Test ‘lsp-text-document-hover-request’ redefined
>>>>>
>>>>> Error: error ("Test ‘lsp-text-document-hover-request’ redefined")
>>>>> mapbacktrace(#f(compiled-function (evald func args flags) #>>>> -0x187de6214517952>))
>>>>> debug-early-backtrace()
>>>>> debug-early(error (error "Test ‘lsp-text-document-hover-request’
>>>>> redefined"))
>>>>> error("Test `%s' redefined" lsp-text-document-hover-request)
>>>>> ert-set-test(lsp-text-document-hover-request #s(ert-test :name
>>>>> lsp-text-document-hover-request :documentation nil :body (closure (t) nil
>>>>> (lsp-workspace-folders-add (f-join lsp-test-location "fixtures"))
>>>>> (find-file
>>>>> (f-join lsp-test-location "fixtures/pyls/test.py")) (lsp) (deferred:sync!
>>>>> (deferred:nextc (deferred:nextc (lsp-test--wait-for '(progn (eq
>>>>> 'initialized
>>>>> (lsp--workspace-status (cl-first (lsp-workspaces)) #'(lambda (_)
>>>>> (goto-char
>>>>> (point-min)) (search-forward "fn1") (lsp-def-request-async
>>>>> "textDocument/hover"
>>>>> (lsp--text-document-position-params #'(lambda (contents) (let*
>>>>> ((fn-566
>>>>> #'lsp-hover?) (args-567 (condition-case err (let ((signal-hook-function
>>>>> #'ert--should-signal-hook)) (list contents)) (error (progn (setq fn-566
>>>>> #'signal) (list (car err) (cdr err))) (let ((value-568
>>>>> 'ert-form-evaluation-aborted-569)) (let (form-description-570) (if
>>>>> (unwind-protect (setq value-568 (apply fn-566 args-567)) (setq
>>>>> form-description-570 (nconc (list '(should (l
Bug#1054494: RFS: lsp-mode/8.0.0-6 [ITA] [RC] -- Emacs client/library for the Language Server Protocol
Arto Jantunen writes:
> Xiyue Deng writes:
>
>> Hi Arto,
>>
>> Arto Jantunen writes:
>>
>>> Xiyue Deng writes:
>>>> Package: sponsorship-requests
>>>> Severity: important
>>>> X-Debbugs-CC: debian-emac...@lists.debian.org
>>>>
>>>> Dear mentors,
>>>>
>>>> I am looking for a sponsor for my package "lsp-mode":
>>>>
>>>> * Package name : lsp-mode
>>>>Version : 8.0.0-6
>>>>Upstream contact : Vibhav Pant
>>>> * URL : https://github.com/emacs-lsp/lsp-mode
>>>> * License : GPL-3+
>>>> * Vcs : https://salsa.debian.org/emacsen-team/lsp-mode
>>>>Section : lisp
>>>>
>>>> The source builds the following binary packages:
>>>>
>>>> elpa-lsp-mode - Emacs client/library for the Language Server Protocol
>>>>
>>>> To access further information about this package, please visit the
>>>> following URL:
>>>>
>>>> https://mentors.debian.net/package/lsp-mode/
>>>>
>>>> Alternatively, you can download the package with 'dget' using this command:
>>>>
>>>> dget -x
>>>> https://mentors.debian.net/debian/pool/main/l/lsp-mode/lsp-mode_8.0.0-6.dsc
>>>>
>>>> Changes since the last upload:
>>>>
>>>> lsp-mode (8.0.0-6) unstable; urgency=medium
>>>> .
>>>>* Add patch to fix test failures (Closes: #1052939).
>>>>* Update Standards-Version to 4.6.2. No change needed.
>>>>* Add myself as uploader (Closes: #1042568).
>>>>* Add signing key verification to d/watch.
>>>>* Add d/upstream/metadata.
>>>>* Add Upstream-Contact and update year in d/copyright.
>>>>* Add patch to fix non-UTF-8 encoding.
>>>>* Drop unused lintian overrides.
>>>
>>> Thanks for taking over this package.
>>>
>>> When I try to build this (under sbuild) I get the following build
>>> failure:
>>>
>>> Test ‘lsp-text-document-hover-request’ redefined
>>>
>>> Error: error ("Test ‘lsp-text-document-hover-request’ redefined")
>>> mapbacktrace(#f(compiled-function (evald func args flags) #>> -0x187de6214517952>))
>>> debug-early-backtrace()
>>> debug-early(error (error "Test ‘lsp-text-document-hover-request’
>>> redefined"))
>>> error("Test `%s' redefined" lsp-text-document-hover-request)
>>> ert-set-test(lsp-text-document-hover-request #s(ert-test :name
>>> lsp-text-document-hover-request :documentation nil :body (closure (t) nil
>>> (lsp-workspace-folders-add (f-join lsp-test-location "fixtures")) (find-file
>>> (f-join lsp-test-location "fixtures/pyls/test.py")) (lsp) (deferred:sync!
>>> (deferred:nextc (deferred:nextc (lsp-test--wait-for '(progn (eq 'initialized
>>> (lsp--workspace-status (cl-first (lsp-workspaces)) #'(lambda (_)
>>> (goto-char
>>> (point-min)) (search-forward "fn1") (lsp-def-request-async
>>> "textDocument/hover"
>>> (lsp--text-document-position-params #'(lambda (contents) (let* ((fn-566
>>> #'lsp-hover?) (args-567 (condition-case err (let ((signal-hook-function
>>> #'ert--should-signal-hook)) (list contents)) (error (progn (setq fn-566
>>> #'signal) (list (car err) (cdr err))) (let ((value-568
>>> 'ert-form-evaluation-aborted-569)) (let (form-description-570) (if
>>> (unwind-protect (setq value-568 (apply fn-566 args-567)) (setq
>>> form-description-570 (nconc (list '(should (lsp-hover? contents))) (list
>>> :form
>>> (cons fn-566 args-567)) (if (eql value-568
>>> 'ert-form-evaluation-aborted-569) nil
>>> (list :value value-568)) (if (eql value-568
>>> 'ert-form-evaluation-aborted-569)
>>> nil (let* ((-explainer- (and t (ert--get-explainer 'lsp-hover? (if
>>> -explainer- (list :explanation (apply -explainer- args-567)) nil)
>>> (ert--signal-should-execution form-description-570)) nil (ert-fail
>>> form-description-570))) value-568) (kill-buffer)
>>> (lsp-workspace-folders-remove (f-join lsp-test-location "fixtures")))
>>> :most-recent-result nil :expected-result-type :passed :tags nil :file-name
>>> "/<>/test
Bug#1054494: RFS: lsp-mode/8.0.0-6 [ITA] [RC] -- Emacs client/library for the Language Server Protocol
Hi Arto,
Arto Jantunen writes:
> Xiyue Deng writes:
>> Package: sponsorship-requests
>> Severity: important
>> X-Debbugs-CC: debian-emac...@lists.debian.org
>>
>> Dear mentors,
>>
>> I am looking for a sponsor for my package "lsp-mode":
>>
>> * Package name : lsp-mode
>>Version : 8.0.0-6
>>Upstream contact : Vibhav Pant
>> * URL : https://github.com/emacs-lsp/lsp-mode
>> * License : GPL-3+
>> * Vcs : https://salsa.debian.org/emacsen-team/lsp-mode
>>Section : lisp
>>
>> The source builds the following binary packages:
>>
>> elpa-lsp-mode - Emacs client/library for the Language Server Protocol
>>
>> To access further information about this package, please visit the following
>> URL:
>>
>> https://mentors.debian.net/package/lsp-mode/
>>
>> Alternatively, you can download the package with 'dget' using this command:
>>
>> dget -x
>> https://mentors.debian.net/debian/pool/main/l/lsp-mode/lsp-mode_8.0.0-6.dsc
>>
>> Changes since the last upload:
>>
>> lsp-mode (8.0.0-6) unstable; urgency=medium
>> .
>>* Add patch to fix test failures (Closes: #1052939).
>>* Update Standards-Version to 4.6.2. No change needed.
>>* Add myself as uploader (Closes: #1042568).
>>* Add signing key verification to d/watch.
>>* Add d/upstream/metadata.
>>* Add Upstream-Contact and update year in d/copyright.
>>* Add patch to fix non-UTF-8 encoding.
>>* Drop unused lintian overrides.
>
> Thanks for taking over this package.
>
> When I try to build this (under sbuild) I get the following build
> failure:
>
> Test ‘lsp-text-document-hover-request’ redefined
>
> Error: error ("Test ‘lsp-text-document-hover-request’ redefined")
> mapbacktrace(#f(compiled-function (evald func args flags) # -0x187de6214517952>))
> debug-early-backtrace()
> debug-early(error (error "Test ‘lsp-text-document-hover-request’
> redefined"))
> error("Test `%s' redefined" lsp-text-document-hover-request)
> ert-set-test(lsp-text-document-hover-request #s(ert-test :name
> lsp-text-document-hover-request :documentation nil :body (closure (t) nil
> (lsp-workspace-folders-add (f-join lsp-test-location "fixtures")) (find-file
> (f-join lsp-test-location "fixtures/pyls/test.py")) (lsp) (deferred:sync!
> (deferred:nextc (deferred:nextc (lsp-test--wait-for '(progn (eq 'initialized
> (lsp--workspace-status (cl-first (lsp-workspaces)) #'(lambda (_)
> (goto-char
> (point-min)) (search-forward "fn1") (lsp-def-request-async
> "textDocument/hover"
> (lsp--text-document-position-params #'(lambda (contents) (let* ((fn-566
> #'lsp-hover?) (args-567 (condition-case err (let ((signal-hook-function
> #'ert--should-signal-hook)) (list contents)) (error (progn (setq fn-566
> #'signal) (list (car err) (cdr err))) (let ((value-568
> 'ert-form-evaluation-aborted-569)) (let (form-description-570) (if
> (unwind-protect (setq value-568 (apply fn-566 args-567)) (setq
> form-description-570 (nconc (list '(should (lsp-hover? contents))) (list :form
> (cons fn-566 args-567)) (if (eql value-568 'ert-form-evaluation-aborted-569)
> nil
> (list :value value-568)) (if (eql value-568 'ert-form-evaluation-aborted-569)
> nil (let* ((-explainer- (and t (ert--get-explainer 'lsp-hover? (if
> -explainer- (list :explanation (apply -explainer- args-567)) nil)
> (ert--signal-should-execution form-description-570)) nil (ert-fail
> form-description-570))) value-568) (kill-buffer)
> (lsp-workspace-folders-remove (f-join lsp-test-location "fixtures")))
> :most-recent-result nil :expected-result-type :passed :tags nil :file-name
> "/<>/test/lsp-integration-test.el"))
> load-with-code-conversion("/<>/test/lsp-integration-test.el"
> "/<>/test/lsp-integration-test.el" nil t)
> command-line-1(("-l" "package" "--eval" "(add-to-list
> 'package-directory-list
> \"/usr/share/emacs/site-lisp/elpa\")" "--eval" "(add-to-list
> 'package-directory-list \"/usr/share/emacs/site-lisp/elpa-src\")" "-f"
> "package-initialize" "-L" "clients/" "-L" "." "-L" "test" "-l"
> "test/lsp-clangd-test.el" "-l" "test/lsp-completion-test.el" "-l"
> "test/lsp-fi
Bug#1054523: RFS: persp-projectile/1:1.0.0+git20210618.4e374d7-1 [RC] [Team] -- integrate perspective.el with projectile
Package: sponsorship-requests
Severity: important
X-Debbugs-CC: debian-emac...@lists.debian.org
Dear mentors,
I am looking for a sponsor for my package "persp-projectile":
* Package name : persp-projectile
Version : 1:1.0.0+git20210618.4e374d7-1
Upstream contact : Bozhidar Batsov
* URL : https://github.com/bbatsov/persp-projectile
* License : GPL-3+
* Vcs : https://salsa.debian.org/emacsen-team/persp-projectile
Section : lisp
The source builds the following binary packages:
elpa-persp-projectile - integrate perspective.el with projectile
To access further information about this package, please visit the following
URL:
https://mentors.debian.net/package/persp-projectile/
Alternatively, you can download the package with 'dget' using this command:
dget -x
https://mentors.debian.net/debian/pool/main/p/persp-projectile/persp-projectile_1.0.0+git20210618.4e374d7-1.dsc
Changes since the last upload:
persp-projectile (1:1.0.0+git20210618.4e374d7-1) unstable; urgency=medium
.
* Team upload.
.
[ David Krauser ]
* Update maintainer email address
.
[ Dhavan Vaidya ]
* d/control: Change Vcs-{Browser,Git} URL to salsa.debian.org
.
[ Nicholas D Steeves ]
* Drop emacs24 from Enhances (package does not exist in bullseye).
.
[ Xiyue Deng ]
* Team upload.
* Sync to latest upstream head.
- Fix compatibility with elpa-perspective. Closes: #919035.
- Refresh patches.
* Update d/watch to check for head.
* Update debhelper-compat to version 13.
* Update Standards-Version to 4.6.2. No change needed.
* Drop unnecessary parameter in d/rules.
* Drop Built-Using from arch:all package as per lintian suggestion.
* Drop unused and update renamed lintian overrides.
* Update year and Upstream-Contact in d/copyright.
* Add d/upstream/metadata.
Regards,
--
Xiyue Deng
Bug#1054494: RFS: lsp-mode/8.0.0-6 [ITA] [RC] -- Emacs client/library for the Language Server Protocol
Package: sponsorship-requests Severity: important X-Debbugs-CC: debian-emac...@lists.debian.org Dear mentors, I am looking for a sponsor for my package "lsp-mode": * Package name : lsp-mode Version : 8.0.0-6 Upstream contact : Vibhav Pant * URL : https://github.com/emacs-lsp/lsp-mode * License : GPL-3+ * Vcs : https://salsa.debian.org/emacsen-team/lsp-mode Section : lisp The source builds the following binary packages: elpa-lsp-mode - Emacs client/library for the Language Server Protocol To access further information about this package, please visit the following URL: https://mentors.debian.net/package/lsp-mode/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/l/lsp-mode/lsp-mode_8.0.0-6.dsc Changes since the last upload: lsp-mode (8.0.0-6) unstable; urgency=medium . * Add patch to fix test failures (Closes: #1052939). * Update Standards-Version to 4.6.2. No change needed. * Add myself as uploader (Closes: #1042568). * Add signing key verification to d/watch. * Add d/upstream/metadata. * Add Upstream-Contact and update year in d/copyright. * Add patch to fix non-UTF-8 encoding. * Drop unused lintian overrides. Regards, -- Xiyue Deng
Bug#1054422: RFS: pointback/0.2-5 [RC] [Team] -- restore window points when returning to buffers
Package: sponsorship-requests Severity: important X-Debbugs-CC: debian-emac...@lists.debian.org Dear mentors, I am looking for a sponsor for my package "pointback": * Package name : pointback Version : 0.2-5 Upstream contact : Markus Triska * URL : https://www.metalevel.at/pointback/ * License : GPL-3+ * Vcs : https://salsa.debian.org/emacsen-team/pointback Section : lisp The source builds the following binary packages: elpa-pointback - restore window points when returning to buffers To access further information about this package, please visit the following URL: https://mentors.debian.net/package/pointback/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/p/pointback/pointback_0.2-5.dsc Changes since the last upload: pointback (0.2-5) unstable; urgency=medium . * Team upload. . [ Nicholas D Steeves ] * Drop emacs24 and emacs25 from Enhances (packages do not exist in bullseye). . [ Debian Janitor ] * Bump debhelper from old 10 to 13. * Set debhelper-compat version in Build-Depends. . [ Xiyue Deng ] * Add patch migrate-from-removed-assoc-el.patch to migrate from obsoleted functions in assoc.el which has been removed since Emacs 29.1 (Closes: #1042900). * Drop Built-Using which should not be used for an "arch: all" package. * Update Standards-Version to 4.6.2. No change needed. * Drop emacs version in Recommends which is from oldoldstable. * Add d/watch with comments of no real upstream version control. * Update d/copyright year and add Upstream-Contact. Regards, -- Xiyue Deng
Bug#1054420: RFS: js2-mode/0.0~git20230628.79bc78d-1 [RC] [Team] -- Emacs mode for editing Javascript programs
Package: sponsorship-requests Severity: important X-Debbugs-CC: debian-emac...@lists.debian.org Dear mentors, I am looking for a sponsor for my package "js2-mode": * Package name : js2-mode Version : 0.0~git20230628.79bc78d-1 Upstream contact : Dmitry Gutov * URL : https://github.com/mooz/js2-mode * License : GPL-3+ * Vcs : https://salsa.debian.org/emacsen-team/js2-mode Section : editors The source builds the following binary packages: elpa-js2-mode - Emacs mode for editing Javascript programs js2-mode - Emacs mode for editing Javascript programs (dummy package) To access further information about this package, please visit the following URL: https://mentors.debian.net/package/js2-mode/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/j/js2-mode/js2-mode_0.0~git20230628.79bc78d-1.dsc Changes since the last upload: js2-mode (0.0~git20230628.79bc78d-1) unstable; urgency=medium . * Team upload. . [ Debian Janitor ] * Remove constraints unnecessary since buster (oldstable): + elpa-js2-mode: Drop versioned constraint on emacsen-common (>= 2.0.8) in Depends. + elpa-js2-mode: Drop conflict with removed package js2-mode (<< 0~20150909-1) in Breaks. . [ Xiyue Deng ] * Update to new upstream version 0.0~git20230628.79bc78d (Closes: #1052865). * Update d/watch to track savannah's canonical js2-mode branch. * Update Standards-Version to 4.6.2. No change needed. * Update debhelper-compat to 13. * Simplify handling in d/rules. * Fix non-canonical URL for Vcs-Browser and drop trailing whitespace. * Use secure protocol in URL and add Upstream-Contact in d/copyright. * Update year and contributor in d/copyright. * Add d/upstream/metadata. Regards, -- Xiyue Deng
Bug#1054419: RFS: go-mode.el/3:1.6.0+git202300823.8dce1e3-1 [RC] [Team] -- Emacs mode for editing Go code
Package: sponsorship-requests Severity: important X-Debbugs-CC: debian-emac...@lists.debian.org Dear mentors, I am looking for a sponsor for my package "go-mode.el": * Package name : go-mode.el Version : 3:1.6.0+git202300823.8dce1e3-1 Upstream contact : Dominik Honnef * URL : https://github.com/dominikh/go-mode.el * License : BSD-3-clasue * Vcs : https://salsa.debian.org/emacsen-team/go-mode.el Section : lisp The source builds the following binary packages: elpa-go-mode - Emacs mode for editing Go code To access further information about this package, please visit the following URL: https://mentors.debian.net/package/go-mode.el/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/g/go-mode.el/go-mode.el_1.6.0+git202300823.8dce1e3-1.dsc Changes since the last upload: go-mode.el (3:1.6.0+git202300823.8dce1e3-1) unstable; urgency=medium . * Team upload. * Sync to latest upstream head (8dce1e3). * Apply patch to drop duplicated test (Closes: #1052922). * Drop Built-Using which should not be used on an "arch:all" package. * Add DEP5 headers for fix-test-path.patch. * Update year and add Upstream-Contact in d/copyright. * Use git mode and fix lintian warnings in d/watch. Regards, -- Xiyue Deng
Bug#1053987: RFS: bison-mode/0.3-1 [ITP] -- Emacs major mode for editing lex, yacc, and bison grammars
Sean Whitton writes: > Hello, > > On Sun 15 Oct 2023 at 10:45pm -07, Xiyue Deng wrote: > >> Ah I see. So for d/copyright we need to stick to the source >> information. Dropped Wilfred from the list of copyright holders for >> now. Also opened a PR upstream for tracking[1]. > > Cool. Just to note, in your commit message you wrote that he's not a > copyright holder yet, but we can't assert that -- in fact, he probably > is a copyright holder. You could have written that he's not > /documented/ as a copyright holder. > Ack. Yeah I should have said that in the commit message. I guess doing a reword and letting everyone having to do a force pull is a no-go so I think I'll have to leave it as-is. Will be more precise in future. >> As this is the first time I attempt of ITP/RFS, I'd like to go over the >> steps for packaging as much as possible if OK. But AIUI this package >> will need to go through the NEW queue, so I guess if you sponsor my >> upload to mentors.d.n it may require some extra steps, then I'm OK if >> what you propose can save some trouble. > > Okay, go ahead and let me know when you've done 'dch -r'. > > I will still work out of git, so please don't push a signed tag there. > See dgit-sponsorship(7) for more. Pushed the commit with 'dch -r' to salsa and also uploaded to mentors[1]. Please proceed as you see fit. Thanks for the sponsorship! [1] https://mentors.debian.net/package/bison-mode/ -- Xiyue Deng signature.asc Description: PGP signature
Bug#1053987: RFS: bison-mode/0.3-1 [ITP] -- Emacs major mode for editing lex, yacc, and bison grammars
Sean Whitton writes: > Hello, > > On Mon 16 Oct 2023 at 03:51am -07, Xiyue Deng wrote: > >> Looks like I got confused about what you suggested as there was a "0.3" >> tag that was from the upstream repo which I assume "git deborig" can use >> so I thought an "upstream" may help more. >> >> I've now also pushed an "upstream/0.3" tag at the commit that matches >> the "0.3" tag, but not sure whether this is what you were referring to. >> If this works better I can remove the upstream branch to avoid further >> complications. Please advice. Thanks! > > What I meant was simply pushing the 0.3 tag to salsa. Ah got it, and done. Sorry for the confusion. I have also dropped the unnecessary tag "upstream/0.3" and the upstream branch, which is not actually used much in the dgit-maint-merge workflow AIUI. -- Xiyue Deng signature.asc Description: PGP signature
Bug#1053987: RFS: bison-mode/0.3-1 [ITP] -- Emacs major mode for editing lex, yacc, and bison grammars
Sean Whitton writes: > Hello, > > On Sun 15 Oct 2023 at 10:46pm -07, Xiyue Deng wrote: > >> Sean Whitton writes: >> >>> Hello, >>> >>> On Sun 15 Oct 2023 at 03:10pm +01, Sean Whitton wrote: >>> >>>> Hello, >>>> >>>> On Sun 15 Oct 2023 at 05:14am -07, Xiyue Deng wrote: >>>> >>>>> Sure! It's at https://salsa.debian.org/manphiz/bison-mode. FYI I have >>>>> also filed an RFS bug#1053987. >>>> >>>> Alright, pushed that to a team repo, let's work from there. >>> >>> It would be a good idea to push upstream's git tags to the repo, so that >>> I can just type 'git deborig'. >> >> Done. The `upstream' branch should be available now. > > I did mean the tags -- I myself prefer not to push an upstream branch. > The idea is that from our point of view the upstream source is > immutable, like tags, and unlike branches. But of course it's fine to > have one. Looks like I got confused about what you suggested as there was a "0.3" tag that was from the upstream repo which I assume "git deborig" can use so I thought an "upstream" may help more. I've now also pushed an "upstream/0.3" tag at the commit that matches the "0.3" tag, but not sure whether this is what you were referring to. If this works better I can remove the upstream branch to avoid further complications. Please advice. Thanks! -- Xiyue Deng signature.asc Description: PGP signature
Bug#1053987: RFS: bison-mode/0.3-1 [ITP] -- Emacs major mode for editing lex, yacc, and bison grammars
Hi Sean, Thanks for your comments. Replies are inline below. Sean Whitton writes: > Hello, > > On Sun 15 Oct 2023 at 05:14am -07, Xiyue Deng wrote: > >> Sure! It's at https://salsa.debian.org/manphiz/bison-mode. FYI I have >> also filed an RFS bug#1053987. > > Alright, pushed that to a team repo, let's work from there. > Thanks! Pushed the new changes with detailed below. > Review of 8123e6e09fa1591dc2182682661421d9be80c328: > > - d/copyright is required to say where upstream sources were obtained -- > see Debian Policy > Added in the `Source' field. Also added upstream maintainer to the `Upstream-Contact' field. > - It looks like you made up the copyright statement for Wilfred Hughes, > right? > > While he may indeed hold copyright, what the GPL requires is just that > we reproduce the copyright notices we actually find in the source. > So it's probably best to drop it for now, and consider offering a pull > request upstream. > Ah I see. So for d/copyright we need to stick to the source information. Dropped Wilfred from the list of copyright holders for now. Also opened a PR upstream for tracking[1]. > - I'd like to suggest dropping the .gitignore, because it interferes > with me uploading using dgit. Can explain more if you want. > Got it. Also dropped ".gitignore". > - description "electric support" is ambiguous. Support for doing what? > It should have been "electric indentation". Fixed now. > - in general, do you mind if when I upload I commit the 'dch -r' change > for you? I.e. the upload is signed off by me, but there'd be [ Xiyue > Deng ] in the changelog. This avoids an e-mail roundtrip. Totally up > to you. As this is the first time I attempt of ITP/RFS, I'd like to go over the steps for packaging as much as possible if OK. But AIUI this package will need to go through the NEW queue, so I guess if you sponsor my upload to mentors.d.n it may require some extra steps, then I'm OK if what you propose can save some trouble. Thanks! [1] https://github.com/Wilfred/bison-mode/issues/15 -- Xiyue Deng signature.asc Description: PGP signature
Bug#1053987: RFS: bison-mode/0.3-1 [ITP] -- Emacs major mode for editing lex, yacc, and bison grammars
Sean Whitton writes: > Hello, > > On Sun 15 Oct 2023 at 03:10pm +01, Sean Whitton wrote: > >> Hello, >> >> On Sun 15 Oct 2023 at 05:14am -07, Xiyue Deng wrote: >> >>> Sure! It's at https://salsa.debian.org/manphiz/bison-mode. FYI I have >>> also filed an RFS bug#1053987. >> >> Alright, pushed that to a team repo, let's work from there. > > It would be a good idea to push upstream's git tags to the repo, so that > I can just type 'git deborig'. Done. The `upstream' branch should be available now. -- Xiyue Deng signature.asc Description: PGP signature
Bug#1053987: RFS: bison-mode/0.3-1 [ITP] -- Emacs major mode for editing lex, yacc, and bison grammars
Xiyue Deng writes: > Sean Whitton writes: > >> Hello Xiyue, >> >> On Sun 15 Oct 2023 at 04:32am -07, Xiyue Deng wrote: >> >>> Package: sponsorship-requests >>> Severity: wishlist >>> X-Debbugs-Cc: Xiyue Deng , >>> debian-emac...@lists.debian.org >>> >>> Dear mentors, >>> >>> I am looking for a sponsor for my package "bison-mode": >>> >>> * Package name : bison-mode >>>Version : 0.3-1 >>>Upstream contact : [fill in name and email of upstream] >>> * URL : https://github.com/Wilfred/bison-mode >>> * License : GPL-2+ >>> * Vcs : https://salsa.debian.org/emacsen-team/bison-mode >> >> Can you give me a git repo to clone, please? I'll create and push it to >> that team repo, then review and sponsor. > > Sure! It's at https://salsa.debian.org/manphiz/bison-mode. FYI I have > also filed an RFS bug#1053987. > Apparently I meant the ITP bug#1053906 :P > Thanks in advance for taking a look! signature.asc Description: PGP signature
Bug#1053987: RFS: bison-mode/0.3-1 [ITP] -- Emacs major mode for editing lex, yacc, and bison grammars
Sean Whitton writes: > Hello Xiyue, > > On Sun 15 Oct 2023 at 04:32am -07, Xiyue Deng wrote: > >> Package: sponsorship-requests >> Severity: wishlist >> X-Debbugs-Cc: Xiyue Deng , debian-emac...@lists.debian.org >> >> Dear mentors, >> >> I am looking for a sponsor for my package "bison-mode": >> >> * Package name : bison-mode >>Version : 0.3-1 >>Upstream contact : [fill in name and email of upstream] >> * URL : https://github.com/Wilfred/bison-mode >> * License : GPL-2+ >> * Vcs : https://salsa.debian.org/emacsen-team/bison-mode > > Can you give me a git repo to clone, please? I'll create and push it to > that team repo, then review and sponsor. Sure! It's at https://salsa.debian.org/manphiz/bison-mode. FYI I have also filed an RFS bug#1053987. Thanks in advance for taking a look! -- Xiyue Deng signature.asc Description: PGP signature
Bug#1053987: RFS: bison-mode/0.3-1 [ITP] -- Emacs major mode for editing lex, yacc, and bison grammars
Package: sponsorship-requests Severity: wishlist X-Debbugs-Cc: Xiyue Deng , debian-emac...@lists.debian.org Dear mentors, I am looking for a sponsor for my package "bison-mode": * Package name : bison-mode Version : 0.3-1 Upstream contact : [fill in name and email of upstream] * URL : https://github.com/Wilfred/bison-mode * License : GPL-2+ * Vcs : https://salsa.debian.org/emacsen-team/bison-mode Section : editors The source builds the following binary packages: elpa-bison-mode - Emacs major mode for editing lex, yacc, and bison grammars To access further information about this package, please visit the following URL: https://mentors.debian.net/package/bison-mode/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/b/bison-mode/bison-mode_0.3-1.dsc Changes for the initial release: bison-mode (0.3-1) UNRELEASED; urgency=medium . * Initial release. Closes: #1053906. Please note that I am currently intentionally leaving the distribution as "UNRELEASE" in case any changes is required. Will change this to "unstable" when uploading the final package. Regards, -- Xiyue Deng signature.asc Description: PGP signature
