Re: Fwd: Re: Adequate reports obsolete conffiles: and now what?

2017-01-23 Thread Gianfranco Costamagna
Hi,



>OK, I see your point.
>
>In my usual, provocative style: To me, this means that the bug should be 
>closed without further actions unless there is more input.


or change to usr/share, that seems a saner approach.
Your call, I don't have an opinion here!

G.



Re: Fwd: Re: Adequate reports obsolete conffiles: and now what?

2017-01-23 Thread Alec Leamas



On 23/01/17 18:03, Gianfranco Costamagna wrote:

hello,


Hi!



However I think the .dist files
should be installed in /usr/share and copied from there instead of being
installed in /etc.


This is of course the Right Thing to do.  Will implement, thanks!



This is nice, however I think this "workaround" should be dropped post-Stretch
release.
Right now living for an year or two with such conf files, will make people 
switch
to the new lirc, so an adequate report is not so much a problem to my eyes,
and will remember us to drop the hack at some point :p


OK, I see your point.

In my usual, provocative style: To me, this means that the bug should be 
closed without further actions unless there is more input.


Just to be clear ;)

--alec



Re: Fwd: Re: Adequate reports obsolete conffiles: and now what?

2017-01-23 Thread Gianfranco Costamagna
hello,



>> However I think the .dist files
>> should be installed in /usr/share and copied from there instead of being
>> installed in /etc.
>
>This is of course the Right Thing to do.  Will implement, thanks!


This is nice, however I think this "workaround" should be dropped post-Stretch
release.
Right now living for an year or two with such conf files, will make people 
switch
to the new lirc, so an adequate report is not so much a problem to my eyes,
and will remember us to drop the hack at some point :p

cheers,

G.



Fwd: Re: Adequate reports obsolete conffiles: and now what?

2017-01-23 Thread Alec Leamas
oops, happened to send the reply to James as a PM... here it comes, it 
was actually meant for the list



 Forwarded Message 
Subject: Re: Adequate reports obsolete conffiles: and now what?
Date: Sat, 21 Jan 2017 16:40:10 +0100
From: Alec Leamas <leamas.a...@gmail.com>
To: James Cowgill <jcowg...@debian.org>


On 21/01/17 13:16, James Cowgill wrote:


Hi,


Hi, thanks for taking time to reply!


By definition, an obsolete conffile is a file which used to be a
conffile, isn't in a new package version, but wasn't moved/removed on
upgrade.


So, when I have done such an operation on purpose, the warning is sort a 
false positive, right?



Removing a conffile with dpkg-maintscript-helper will actually move it
(to xxx.dpkg-back) if it was modified, so I think you can safely remove
this as users will still be able to refer to it later.


Well... I have made both manual instructions and a script based on that 
hardware.conf is still in it's original location. Of course, the file 
should eventually be removed, but doesn't it make make sense to leave it 
in it's original location for the first update cycle(s)? Basically, 
having it in it's original location IMHO makes it much more visible. Or?



Isn't this the problem conffiles was meant to solve? Dpkg will ask the
user before updating those config files and not touching them is the
default option. This will also warn the user when they may need to
update them anyway (eg new features).



I guess this is a maintainer decision on how they want to do this (even
if I think it's a bad idea) so using .dist files is still OK.


Yes...the lirc history is plagued with some bugs related to this. I'm 
not saying that following this scheme is the ultimate solution, but for 
better or worse it's a decision I have made.



In this
case, and as long as you're sure your maintainer scripts always do the
right thing, you can ignore adequate.


OK... But "being sure that the maintainer scripts does the right thing" 
is not something I feel comfortable with. The conffiles handling is hard 
to understand for anyone; it's even harder for me with a RPM background ;)



However I think the .dist files
should be installed in /usr/share and copied from there instead of being
installed in /etc.


This is of course the Right Thing to do.  Will implement, thanks!


Cheers!

--alec



Re: Adequate reports obsolete conffiles: and now what?

2017-01-21 Thread James Cowgill
Hi,

On 21/01/17 09:51, Alec Leamas wrote:
> The new, shiny lirc 0.9.4 has received a bug report #851618. At the
> core, this is about adequate reporting
> 
> lirc: obsolete-conffile /etc/lirc/irexec.lircrc
> lirc: obsolete-conffile /etc/lirc/lircmd.conf
> lirc: obsolete-conffile /etc/lirc/hardware.conf
> lirc: obsolete-conffile /etc/lirc/lircd.conf
> lirc: obsolete-conffile /etc/lirc/lirc_options.conf
> 
> However, all of these files exists for a purpose and are not obsolete.

By definition, an obsolete conffile is a file which used to be a
conffile, isn't in a new package version, but wasn't moved/removed on
upgrade.

> The details:
> 
> - hardware.conf is indeed obsolete in 0.9.4. However, the manual,
> breaking update is about moving bits and pieces from hardware,conf to
> other files, so it needs to be around for some cycles  before it's removed.

Removing a conffile with dpkg-maintscript-helper will actually move it
(to xxx.dpkg-back) if it was modified, so I think you can safely remove
this as users will still be able to refer to it later.

> - For the other files I'm using my own scheme: The upstream files are
> installed as e. g.,lirc_options.conf.dist. This file is updated but not
> used. If the actually used lirc_options.conf is missing it's created as
> a copy of the *dist file, but otherwise kept as-is.. In other words, I
> don't try to merge possible upstream changes, I just keep the *dist
> files around as reference

Isn't this the problem conffiles was meant to solve? Dpkg will ask the
user before updating those config files and not touching them is the
default option. This will also warn the user when they may need to
update them anyway (eg new features).

I guess this is a maintainer decision on how they want to do this (even
if I think it's a bad idea) so using .dist files is still OK. In this
case, and as long as you're sure your maintainer scripts always do the
right thing, you can ignore adequate. However I think the .dist files
should be installed in /usr/share and copied from there instead of being
installed in /etc. Presumably these .dist files have been (incorrectly)
marked as conffiles already?

> Since the overall idea is that the adequate (or really dpkg) error
> message is a bug: How should I resolve this bug?

James



signature.asc
Description: OpenPGP digital signature


Adequate reports obsolete conffiles: and now what?

2017-01-21 Thread Alec Leamas

Dear list,


The new, shiny lirc 0.9.4 has received a bug report #851618. At the 
core, this is about adequate reporting


lirc: obsolete-conffile /etc/lirc/irexec.lircrc
lirc: obsolete-conffile /etc/lirc/lircmd.conf
lirc: obsolete-conffile /etc/lirc/hardware.conf
lirc: obsolete-conffile /etc/lirc/lircd.conf
lirc: obsolete-conffile /etc/lirc/lirc_options.conf

However, all of these files exists for a purpose and are not obsolete. 
The details:


- hardware.conf is indeed obsolete in 0.9.4. However, the manual, 
breaking update is about moving bits and pieces from hardware,conf to 
other files, so it needs to be around for some cycles  before it's removed.


- For the other files I'm using my own scheme: The upstream files are 
installed as e. g.,lirc_options.conf.dist. This file is updated but not 
used. If the actually used lirc_options.conf is missing it's created as 
a copy of the *dist file, but otherwise kept as-is.. In other words, I 
don't try to merge possible upstream changes, I just keep the *dist 
files around as reference


Since the overall idea is that the adequate (or really dpkg) error 
message is a bug: How should I resolve this bug?


Any clue out there? Shortcut to the packaging at [1]


--alec


[1] https://sourceforge.net/p/lirc/git/ci/debian/tree/debian/