Bug#1003090: RFS: ffcvt/1.7.5-1
Hi Tong, On 1/16/22 10:41 PM, Tong Sun wrote: I'll remove the build dependency of easygen as planned, as I know for sure it can fix the issue I am not sure if that's the problem here. Why would it fix the issue? [...] config.go:1:1: expected 'package', found 'EOF' which is in turn caused by https://salsa.debian.org/go-team/packages/ffcvt/-/blob/master/debian/rules#L20 that rm -f ... config.go statement. I know removing the build dependency of easygen will work because I don't need to do `rm -f ... config.go` after that. Apparently not. I tried doing these changes on a different branch[1], but as you might see, the CI is still failing[2], unless I did that wrong. So it is likely unrelated. I think the the config.go that you see there is _probably_ this one[3] instead of the one in package, because this thing is being 'run'. I took this even further I triggered salsa CI on a branched-off commit from _last uploaded version_ of ffcvt see here[4] and that still fails, while that has nothing to do with easygen at all. The CI is trying to build all golang packages, install your current package and trying to test if something failed after installing current package. Since ffcvt has no reverse-deps and no deps either, it looks highly unlikely for it to break anything at all. It seems a problem with the CI instead here. I do think we can ignore CI failures here. (I'll remove these useless branches before uploading the new release.) [1]: https://salsa.debian.org/go-team/packages/ffcvt/-/commits/salsa-ci [2]: https://salsa.debian.org/go-team/packages/ffcvt/-/jobs/2372473 [3]: https://salsa.debian.org/go-team/infra/pkg-go-tools/-/blob/master/config/config.go [4]: https://salsa.debian.org/go-team/packages/ffcvt/-/commits/salsa-ci-test Everything builds fine locally, even with sbuild -- https://paste.debian.net/1227301/ That's why I don't understand why it fails in salsa CI, even after I've done a brand new push to salsa -- https://salsa.debian.org/go-team/packages/ffcvt/-/jobs/2372315 Yep. I faced a failure on another package of mine today that does nothing intrusive at all[5] and it goes fine on buildd[6] so IMO we ignore this for now. CI doesn't work perfect for all packages (which is fine too) [5]: https://salsa.debian.org/go-team/packages/golang-github-biogo-graph/-/jobs/2371800 [6]: https://buildd.debian.org/status/fetch.php?pkg=golang-github-biogo-graph=all=0.0%7Egit20150317.057c198-3=1642331568=0 @Alois, could you shed some light on the CI thingy? From the logs, it is hard to figure out what went wrong. The packages that are shown failing there do not have anything to do with ffcvt package, are the failing logs stored somewhere? > Yes please @Alois. CC'ed Faust as well. @Faustin, would you have some idea? Hope that helps. Let me know if you need sponsoring. Please do when all dust settles. I want to do this now, but I'll wait for a couple of days for replies/opinions. Yes, indeed Nilesh, as I'm not allowed to do dput myself yet. Have you sorted out your gpg key stuff? If yes, you should be able to upload after this month's keyring changes (hopefully next week) Regards, Nilesh OpenPGP_signature Description: OpenPGP digital signature
Bug#1003090: RFS: ffcvt/1.7.5-1
On Sat, Jan 15, 2022 at 3:21 AM Nilesh Patra wrote:
>
> Hi Tong,
>
> On 1/15/22 2:55 AM, Tong Sun wrote:
> >> Hi,
> >>
> >> The situation should have been fixed with the new upload of easygen.
> >>
> >> However, the CI build is still failing in salsa. This is something
> >> that I don't understand as it builds OK on github.
> >>
> >> Sorry I've run out of ideas why it is happening like this, and am now
> >> thinking to remove the build dependency of easygen, to fix this and to
> >> make things easier...
> >
> > I still don't have a clue why
>
> I intended to reply earlier, but I was occupied and simply forgot later,
> sorry about that!
Oh, that's perfectly fine.
> > I'll wait for one or two weeks more, and if still nobody can help,
>
> It is usually a good idea to ask on #debian-mentors if there is more delay in
> a reply.
> Also, feel free to ping me if you think I can be of any help.
Oh, I only wrote that because I got total silence from my first
request. Now I know, that you'll still willing to help, just were busy
with something else. That promise alone, I'm forever grateful.
I'll keep it in mind but I won't ping anyone unless it's super urgent.
I normally give people a week, only after that I'll do a short follow
up, even at work, unless it's more urgent. Thanks again for helping.
> > it builds OK on github but fails in
> > salsa CI build, and I still hope that somebody can help.
>
> Okay, so there are two parts to it.
>
> 1) Why does github CI pass?
> Ok, so there are two reasons about this as well
> + test-all.sh does not seem to run anywhere in your github actions/CI and
> that error stems from this script (in the deb package)
> + `go test -v` in your CI essentially does nothing since there are no
> _test.go files and it is visible
> on the CI too
>
> | go test -v ./...
> | shell: /usr/bin/bash -e {0}
> | env:
> |GOROOT: /opt/hostedtoolcache/go/1.15.15/x64
> | github.com/suntong/ffcvt
> | ? github.com/suntong/ffcvt[no test files]
>
> So you probably should update it accordingly there as well.
Ah, good catch. fixed upstream. See
https://github.com/suntong/ffcvt/runs/4830553950?check_suite_focus=true
> 2) For salsa CI, I thought that it is because of the failing build.
> You will find the build failure logs pasted at the end of this email.
> The reason for test to be failing is that you have not updated
> "test/ffcvt_test.txt" file in accordance with the
> latest manpage/latest ffcvt options upstream.
>
> However, even after I have pushed a patch to fix the build, salsa CI chokes.
>
>
> > I'll remove the build dependency of easygen as planned, as I know for
> > sure it can fix the issue
> I am not sure if that's the problem here. Why would it fix the issue?
Ok, that does need a bit of explanation.
- ffcvt has the build dependency of easygen.
- the older version of easygen cause the initial v1.7.5 build failure
- which should be fixed by the updated easygen (from 4.1.0-1 to 5.1.9-2)
- that's why I triggered a rebuild (e673085)
- yet that rebuild still failed.
This is why I'm asking for help, as I don't understand why it still fails.
>From https://salsa.debian.org/go-team/packages/ffcvt/-/jobs/2342864#L719
the failure is caused by
config.go:1:1: expected 'package', found 'EOF'
which is in turn caused by
https://salsa.debian.org/go-team/packages/ffcvt/-/blob/master/debian/rules#L20
that
rm -f ... config.go
statement.
Everything builds fine locally, even with sbuild --
https://paste.debian.net/1227301/
That's why I don't understand why it fails in salsa CI, even after
I've done a brand new push to salsa --
https://salsa.debian.org/go-team/packages/ffcvt/-/jobs/2372315
I know removing the build dependency of easygen will work because I
don't need to do `rm -f ... config.go` after that.
> @Alois, could you shed some light on the CI thingy?
> From the logs, it is hard to figure out what went wrong.
> The packages that are shown failing there do not have anything to do with
> ffcvt package, are the failing logs stored somewhere?
Yes please @Alois.
> >> Somebody help please.
>
> Hope that helps. Let me know if you need sponsoring.
Yes, indeed Nilesh, as I'm not allowed to do dput myself yet. Please
do when all dust settles.
Thanks!
Bug#1003090: RFS: ffcvt/1.7.5-1
Hi Tong,
On 1/15/22 2:55 AM, Tong Sun wrote:
Hi,
The situation should have been fixed with the new upload of easygen.
However, the CI build is still failing in salsa. This is something
that I don't understand as it builds OK on github.
Sorry I've run out of ideas why it is happening like this, and am now
thinking to remove the build dependency of easygen, to fix this and to
make things easier...
I still don't have a clue why
I intended to reply earlier, but I was occupied and simply forgot later, sorry
about that!
it builds OK on github but fails in
salsa CI build, and I still hope that somebody can help.
Okay, so there are two parts to it.
1) Why does github CI pass?
Ok, so there are two reasons about this as well
+ test-all.sh does not seem to run anywhere in your github actions/CI and that
error stems from this script (in the deb package)
+ `go test -v` in your CI essentially does nothing since there are no _test.go
files and it is visible
on the CI too
| go test -v ./...
| shell: /usr/bin/bash -e {0}
| env:
|GOROOT: /opt/hostedtoolcache/go/1.15.15/x64
| github.com/suntong/ffcvt
| ? github.com/suntong/ffcvt[no test files]
So you probably should update it accordingly there as well.
2) For salsa CI, I thought that it is because of the failing build.
You will find the build failure logs pasted at the end of this email.
The reason for test to be failing is that you have not updated
"test/ffcvt_test.txt" file in accordance with the
latest manpage/latest ffcvt options upstream.
However, even after I have pushed a patch to fix the build, salsa CI chokes.
@Alois, could you shed some light on the CI thingy?
From the logs, it is hard to figure out what went wrong.
The packages that are shown failing there do not have anything to do with ffcvt
package, are the failing logs stored somewhere?
I'll wait for one or two weeks more, and if still nobody can help,
It is usually a good idea to ask on #debian-mentors if there is more delay in a
reply.
Also, feel free to ping me if you think I can be of any help.
I'll remove the build dependency of easygen as planned, as I know for
sure it can fix the issue
I am not sure if that's the problem here. Why would it fix the issue?
Somebody help please.
Hope that helps. Let me know if you need sponsoring.
Regards,
Nilesh
| cd obj-x86_64-linux-gnu/src/github.com/suntong/ffcvt/test && ./test-all.sh
| ffcvt
| Version 1.7.5 built on 2022-01-02
| - Test (config.go) cli help output
| - Test transcoding single file
| - Test -sym control
| - Compare test results
| --- ffcvt_test.txt2022-01-15 07:35:05.137033394 +
| +++ /tmp/ffcvt_test.txt 2022-01-15 07:35:08.193097895 +
| @@ -6,3 +6,3 @@
|
| - -t target type: webm/x265-opus/x264-mp3/youtube (FFCVT_T)
| + -t target type: webm/x265-opus/x264-mp3/wx/youtube/copy (FFCVT_T)
| -vesvideo encoding method set (FFCVT_VES)
| @@ -32,3 +32,8 @@
| -vssvideo: same size (FFCVT_VSS)
| + -C,Cut Cut segment(s) out to keep. Specify in the form of start-[end],
| + strictly in the format of hh:mm:ss, and may repeat (FFCVT_C,CUT)
| + -S,Seg Split video into multiple segments (strictly in format:
hh:mm:ss) (FFCVT_S,SEG)
| + -Speed Speed up/down video playback speed (e.g. 1.28) (FFCVT_SPEED)
| -lang language selection for audio stream extraction (FFCVT_LANG)
| + -sel subtitle encoding language (language picked for reencoded
video) (FFCVT_SEL)
| -o more options that will pass to ffmpeg program (FFCVT_O)
| @@ -49,2 +54,14 @@
|
| + -C value
| + Cut segment(s) out to keep. Specify in the form of start-[end],
| + strictly in the format of hh:mm:ss, and may repeat
| + -Cut value
| + Cut segment(s) out to keep. Specify in the form of start-[end],
| + strictly in the format of hh:mm:ss, and may repeat
| + -S string
| + Split video into multiple segments (strictly in format: hh:mm:ss)
| + -Seg string
| + Split video into multiple segments (strictly in format: hh:mm:ss)
| + -Speed string
| + Speed up/down video playback speed (e.g. 1.28)
| -abr string
| @@ -90,2 +107,4 @@
| -p par2create, create par2 files (in work directory)
| + -sel value
| + subtitle encoding language (language picked for reencoded video)
| -sep string
| @@ -99,3 +118,3 @@
| -t string
| - target type: webm/x265-opus/x264-mp3/youtube (default "webm")
| + target type: webm/x265-opus/x264-mp3/wx/youtube/copy (default "webm")
| -vc
| 1
OpenPGP_signature
Description: OpenPGP digital signature
Bug#1003090: RFS: ffcvt/1.7.5-1
Trying again. On Thu, Jan 6, 2022 at 1:16 PM Tong Sun wrote: > > On Mon, Jan 3, 2022 at 3:45 PM Tong Sun wrote: > > > > On Mon, Jan 3, 2022 at 3:20 PM Tong Sun > > wrote: > > > > > > Package: sponsorship-requests > > > Severity: normal > > > > > > Dear mentors, > > > > > > I updated my ffcvt to a newer version, and am now looking for a sponsor. > > > > > > Here is from the d/changelog > > > > > > ffcvt (1.7.5-1) unstable; urgency=medium > > > > > > * New upstream version 1.7.5 > > > - add --Speed for speeding up playback (v1.7.5) > > > - add a copy target type that can speed up operations (v1.7.4) > > > - add option -S,Seg -- split video into multiple segments (v1.7.3) > > > - add option -sel, subtitle encoding language (v1.7.2) > > > - add option -C which allows cutting multiple segments (v1.7.1) > > > - add wx type for weixin (v1.7.0) > > > - x264-mp3 type set ext to .mp4 (v1.6.2) > > > * fix "source: out-of-date-standards-version" problem > > > * fix "source: update-debian-copyright" problem > > > * fix "source: prefer-uscan-symlink filenamemangle" problem > > > > > > Note > > > > > > 1) My GPG key expired a few days ago, and I've already submit the > > > update to keyring.debian.org, yet I understand it might take a while > > > to really get updated, so please > > > > > > go directly to > > > https://salsa.debian.org/go-team/packages/ffcvt/-/commits/master > > > > > > 2) Please disregard the .gitlab-ci.yml build failure as I'm not > > > supposed to touch it. > > > > Ops, please hold off reviewing it, as I've found out where the problem > > is -- ffcvt depends on the latest easygen to build yet I haven't > > upgraded easygen in Debian yet. and my expired GPG key is preventing > > me from fixing it promptly. > > > > Will update when the situation is fixed. > > > > Sorry & thanks > > > > > The build is fine, check out here -- > > > https://github.com/suntong/ffcvt/runs/4687405723?check_suite_focus=true > > Hi, > > The situation should have been fixed with the new upload of easygen. > > However, the CI build is still failing in salsa. This is something > that I don't understand as it builds OK on github. > > Sorry I've run out of ideas why it is happening like this, and am now > thinking to remove the build dependency of easygen, to fix this and to > make things easier... I still don't have a clue why it builds OK on github but fails in salsa CI build, and I still hope that somebody can help. I'll wait for one or two weeks more, and if still nobody can help, I'll remove the build dependency of easygen as planned, as I know for sure it can fix the issue. > Somebody help please. thanks
Bug#1003090: RFS: ffcvt/1.7.5-1
On Mon, Jan 3, 2022 at 3:45 PM Tong Sun wrote: > > On Mon, Jan 3, 2022 at 3:20 PM Tong Sun > wrote: > > > > Package: sponsorship-requests > > Severity: normal > > > > Dear mentors, > > > > I updated my ffcvt to a newer version, and am now looking for a sponsor. > > > > Here is from the d/changelog > > > > ffcvt (1.7.5-1) unstable; urgency=medium > > > > * New upstream version 1.7.5 > > - add --Speed for speeding up playback (v1.7.5) > > - add a copy target type that can speed up operations (v1.7.4) > > - add option -S,Seg -- split video into multiple segments (v1.7.3) > > - add option -sel, subtitle encoding language (v1.7.2) > > - add option -C which allows cutting multiple segments (v1.7.1) > > - add wx type for weixin (v1.7.0) > > - x264-mp3 type set ext to .mp4 (v1.6.2) > > * fix "source: out-of-date-standards-version" problem > > * fix "source: update-debian-copyright" problem > > * fix "source: prefer-uscan-symlink filenamemangle" problem > > > > Note > > > > 1) My GPG key expired a few days ago, and I've already submit the > > update to keyring.debian.org, yet I understand it might take a while > > to really get updated, so please > > > > go directly to > > https://salsa.debian.org/go-team/packages/ffcvt/-/commits/master > > > > 2) Please disregard the .gitlab-ci.yml build failure as I'm not > > supposed to touch it. > > Ops, please hold off reviewing it, as I've found out where the problem > is -- ffcvt depends on the latest easygen to build yet I haven't > upgraded easygen in Debian yet. and my expired GPG key is preventing > me from fixing it promptly. > > Will update when the situation is fixed. > > Sorry & thanks > > > The build is fine, check out here -- > > https://github.com/suntong/ffcvt/runs/4687405723?check_suite_focus=true Hi, The situation should have been fixed with the new upload of easygen. However, the CI build is still failing in salsa. This is something that I don't understand as it builds OK on github. Sorry I've run out of ideas why it is happening like this, and am now thinking to remove the build dependency of easygen, to fix this and to make things easier... Somebody help please.
Bug#1003090: RFS: ffcvt/1.7.5-1
On Mon, Jan 3, 2022 at 3:20 PM Tong Sun wrote: > > Package: sponsorship-requests > Severity: normal > > Dear mentors, > > I updated my ffcvt to a newer version, and am now looking for a sponsor. > > Here is from the d/changelog > > ffcvt (1.7.5-1) unstable; urgency=medium > > * New upstream version 1.7.5 > - add --Speed for speeding up playback (v1.7.5) > - add a copy target type that can speed up operations (v1.7.4) > - add option -S,Seg -- split video into multiple segments (v1.7.3) > - add option -sel, subtitle encoding language (v1.7.2) > - add option -C which allows cutting multiple segments (v1.7.1) > - add wx type for weixin (v1.7.0) > - x264-mp3 type set ext to .mp4 (v1.6.2) > * fix "source: out-of-date-standards-version" problem > * fix "source: update-debian-copyright" problem > * fix "source: prefer-uscan-symlink filenamemangle" problem > > Note > > 1) My GPG key expired a few days ago, and I've already submit the > update to keyring.debian.org, yet I understand it might take a while > to really get updated, so please > > go directly to > https://salsa.debian.org/go-team/packages/ffcvt/-/commits/master > > 2) Please disregard the .gitlab-ci.yml build failure as I'm not > supposed to touch it. Ops, please hold off reviewing it, as I've found out where the problem is -- ffcvt depends on the latest easygen to build yet I haven't upgraded easygen in Debian yet. and my expired GPG key is preventing me from fixing it promptly. Will update when the situation is fixed. Sorry & thanks > The build is fine, check out here -- > https://github.com/suntong/ffcvt/runs/4687405723?check_suite_focus=true > > Thanks > > > On Sat, Jan 9, 2021 at 11:23 PM Dmitry Smirnov wrote: > > > > Please help. > > > > I'm at the limit of my capacity so I don't have much time to spare... > > I had a quick look and I'd like to ask you to make few trivial changes > > if you could, before I upload. > > > > Please ... > > > > It might take few more _flawless_ uploads before I'll become confident > > enough in your work to give you upload rights.
Bug#1003090: RFS: ffcvt/1.7.5-1
Package: sponsorship-requests Severity: normal Dear mentors, I updated my ffcvt to a newer version, and am now looking for a sponsor. Here is from the d/changelog ffcvt (1.7.5-1) unstable; urgency=medium * New upstream version 1.7.5 - add --Speed for speeding up playback (v1.7.5) - add a copy target type that can speed up operations (v1.7.4) - add option -S,Seg -- split video into multiple segments (v1.7.3) - add option -sel, subtitle encoding language (v1.7.2) - add option -C which allows cutting multiple segments (v1.7.1) - add wx type for weixin (v1.7.0) - x264-mp3 type set ext to .mp4 (v1.6.2) * fix "source: out-of-date-standards-version" problem * fix "source: update-debian-copyright" problem * fix "source: prefer-uscan-symlink filenamemangle" problem Note 1) My GPG key expired a few days ago, and I've already submit the update to keyring.debian.org, yet I understand it might take a while to really get updated, so please go directly to https://salsa.debian.org/go-team/packages/ffcvt/-/commits/master 2) Please disregard the .gitlab-ci.yml build failure as I'm not supposed to touch it. The build is fine, check out here -- https://github.com/suntong/ffcvt/runs/4687405723?check_suite_focus=true Thanks On Sat, Jan 9, 2021 at 11:23 PM Dmitry Smirnov wrote: > > Please help. > > I'm at the limit of my capacity so I don't have much time to spare... > I had a quick look and I'd like to ask you to make few trivial changes > if you could, before I upload. > > Please ... > > It might take few more _flawless_ uploads before I'll become confident > enough in your work to give you upload rights.
