Bug#1052597: RFS: libkysdk-base/2.2.0.1-1 -- common files for kylin sdk base library
Hi, It appears the included symbols file isn't complete and lintian complains: E: libkysdk-base: symbols-file-contains-current-version-with-debian-revision on symbol _ZN8nlohmann10basic_jsonISt3mapSt6vectorNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEblmdSaNS_14adl_serializerES2_IhSaIhEEE10json_value7destroyENS_6detail7value_tE@Base and 84 others (libkydiagnostics.so.1) [symbols] I: libkysdk-base: symbols-file-missing-build-depends-package-field libkydiagnostics.so.1 [symbols] Looking through the build log, dpkg-gensymbols has emitted some warnings: dpkg-gensymbols: warning: some new symbols appeared in the symbols file: see diff output below dpkg-gensymbols: warning: debian/libkysdk-base/DEBIAN/symbols doesn't match completely debian/libkysdk-base.symbols --- debian/libkysdk-base.symbols (libkysdk-base_2.2.0.1-1_amd64) +++ dpkg-gensymbolsiEEcLA 2024-02-16 09:59:46.896778987 + @@ -18,6 +18,91 @@ _ZN3kdk11BuriedPointC2Ev@Base 2.2.0.1 _ZN3kdk11BuriedPointD1Ev@Base 2.2.0.1 _ZN3kdk11BuriedPointD2Ev@Base 2.2.0.1 + _ZN8nlohmann10basic_jsonISt3mapSt6vectorNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEblmdSaNS_14adl_serializerES2_IhSaIhEEE1 0json_value7destroyENS_6detail7value_tE@Base 2.2.0.1-1 + _ZN8nlohmann10basic_jsonISt3mapSt6vectorNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEblmdSaNS_14adl_serializerES2_IhSaIhEEEC 1EDn@Base 2.2.0.1-1 + _ZN8nlohmann10basic_jsonISt3mapSt6vectorNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEblmdSaNS_14adl_serializerES2_IhSaIhEEEC 2EDn@Base 2.2.0.1-1 + _ZN8nlohmann10basic_jsonISt3mapSt6vectorNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEblmdSaNS_14adl_serializerES2_IhSaIhEEED 1Ev@Base 2.2.0.1-1 + _ZN8nlohmann10basic_jsonISt3mapSt6vectorNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEblmdSaNS_14adl_serializerES2_IhSaIhEEED 2Ev@Base 2.2.0.1-1 + _ZN8nlohmann10basic_jsonISt3mapSt6vectorNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEblmdSaNS_14adl_serializerES2_IhSaIhEEEi xERKS8_@Base 2.2.0.1-1 + _ZN8nlohmann10basic_jsonISt3mapSt6vectorNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEblmdSaNS_14adl_serializerES2_IhSaIhEEEi xIKcEERSC_PT_@Base 2.2.0.1-1 + _ZN8nlohmann6detail10serializerINS_10basic_jsonISt3mapSt6vectorNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEblmdSaNS_14adl_s erializerES4_IhSaIhE12dump_escapedERKSA_b@Base 2.2.0.1-1 + _ZN8nlohmann6detail10serializerINS_10basic_jsonISt3mapSt6vectorNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEblmdSaNS_14adl_s erializerES4_IhSaIhE12dump_integerIhLi0EEEvT_@Base 2.2.0.1-1 + _ZN8nlohmann6detail10serializerINS_10basic_jsonISt3mapSt6vectorNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEblmdSaNS_14adl_serializerES4_IhSaIhE12dump_integerIlLi0EEEvT_@Base 2.2.0.1-1 + _ZN8nlohmann6detail10serializerINS_10basic_jsonISt3mapSt6vectorNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEblmdSaNS_14adl_serializerES4_IhSaIhE12dump_integerImLi0EEEvT_@Base 2.2.0.1-1 + _ZN8nlohmann6detail10serializerINS_10basic_jsonISt3mapSt6vectorNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEblmdSaNS_14adl_serializerES4_IhSaIhE4dumpERKSE_bbjj@Base 2.2.0.1-1 + _ZN8nlohmann6detail10serializerINS_10basic_jsonISt3mapSt6vectorNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEblmdSaNS_14adl_serializerES4_IhSaIhED1Ev@Base 2.2.0.1-1 + _ZN8nlohmann6detail10serializerINS_10basic_jsonISt3mapSt6vectorNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEblmdSaNS_14adl_serializerES4_IhSaIhED2Ev@Base 2.2.0.1-1 + _ZN8nlohmann6detail10type_errorD0Ev@Base 2.2.0.1-1 + _ZN8nlohmann6detail10type_errorD1Ev@Base 2.2.0.1-1 + _ZN8nlohmann6detail10type_errorD2Ev@Base 2.2.0.1-1 + _ZN8nlohmann6detail21output_string_adapterIcNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIc15write_characterEc@Base 2.2.0.1-1+ _ZN8nlohmann6detail21output_string_adapterIcNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIc16write_charactersEPKcm@Base 2.2.0.1-1 + _ZN8nlohmann6detail21output_string_adapterIcNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcD0Ev@Base 2.2.0.1-1 + _ZN8nlohmann6detail21output_string_adapterIcNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcD1Ev@Base 2.2.0.1-1 + _ZN8nlohmann6detail21output_string_adapterIcNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcD2Ev@Base 2.2.0.1-1 + _ZN8nlohmann6detail8to_charsIdEEPcS2_PKcT_@Base 2.2.0.1-1 + _ZN8nlohmann6detail9dtoa_impl13format_bufferEPc@Base 2.2.0.1-1 + _ZN8nlohmann6detail9dtoa_impl16grisu2_digit_genEPcRiS3_NS1_5diyfpES4_S4_@Base 2.2.0.1-1 + _ZN8nlohmann6detail9dtoa_impl18compute_boundariesIdEENS1_10boundariesET_@Base 2.2.0.1-1 + _ZN8nlohmann6detail9dtoa_impl6grisu2IdEEvPcRiS4_T_@Base 2.2.0.1-1 + _ZN8nlohmann6detail9exception4nameERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEi@Base 2.2.0.1-1 + _ZN8nlohmann6detail9exceptionD0Ev@Base 2.2.0.1-1 + _ZN8nlohmann6detail9exceptionD1Ev@Base 2.2.0.1-1 + _ZN8nlohmann6detail9exceptionD2Ev@Base 2.2.0.1-1 +
Bug#1052597: RFS: libkysdk-base/2.2.0.1-1 -- common files for kylin sdk base library
Thanks for replied. I have updated the symbols file and uploaded latest version on: https://mentors.debian.net/package/libkysdk-base/ Thanks a lot! xibowen
Bug#1052597: RFS: libkysdk-base/2.2.0.1-1 -- common files for kylin sdk base library
Hi, It appears you've removed the symbols file for libraries included in the latest version on mentors.d.n, would you mind bringing it back? Thanks, Aron
Re: Bug#1052597: RFS: libkysdk-base/2.2.0.1-1 -- common files for kylin sdk base library
On 2023-12-18, Tobias Frost wrote:
> - Updating the SONAME of a library requires this procedure to be followed:
> https://wiki.debian.org/Teams/ReleaseTeam/Transitions
> Comparing the symbols file does not make it obvious why you are
> bumping SONAME, but I did not check with abi-complicance-checker...
> Can you fill me in why you bump the soname?
>
> - the breaks/replaces version seems odd, as it is a binnmu version.
> You likely want (<< 2.2.0.1-1~), though I am not sure why you think
> you'll need the Break/Replace? Can you exand?
>
> - you could use d/clean instead of overriding dh_clean
>
> - for the install files, for multiarch, a cleaner way would be to write
> /usr/lib/${DEB_HOST_MULTIARCH}/… instead of /usr/lib/*/…
Why does the build system force an ancient c++ standard ? It seems to
mostly get in the way and there are rarely good reasons to do it.
Why does it build with -O1 in release mode ?
How do you plan on dealing with just a SONAME break in one of the
libraries?
Why is nlohman-json embedded and not used from system?
- Also just a quick review.
/Sune
Bug#1052597: RFS: libkysdk-base/2.2.0.1-1 -- common files for kylin sdk base library
Control: tags -1 moreinfo
Hi xibowen,
On Mon, Oct 30, 2023 at 11:23:33AM +0800, xibowen wrote:
> Hi. thanks for reply.
>
> >
> > I'm curious if libkysdk-base-common is really needed? This will also
> > require a NEW processing btw.
> >
>
> I have removed the libkysdk-base-common and uploaded to mentors.
>
> Lastest upload: https://mentors.debian.net/package/libkysdk-base/
>
> libkysdk-base (2.2.0.1-1) unstable; urgency=medium
> .
>* Update libs soname version.
>* Fix compile error on armhf and ppc64el.
>* d/control:
> - Add Multi-Arch.
(this is a partial review, as I ran out of time.)
- Updating the SONAME of a library requires this procedure to be followed:
https://wiki.debian.org/Teams/ReleaseTeam/Transitions
Comparing the symbols file does not make it obvious why you are
bumping SONAME, but I did not check with abi-complicance-checker...
Can you fill me in why you bump the soname?
- the breaks/replaces version seems odd, as it is a binnmu version.
You likely want (<< 2.2.0.1-1~), though I am not sure why you think
you'll need the Break/Replace? Can you exand?
- you could use d/clean instead of overriding dh_clean
- for the install files, for multiarch, a cleaner way would be to write
/usr/lib/${DEB_HOST_MULTIARCH}/… instead of /usr/lib/*/…
--
Cheers,
tobi
signature.asc
Description: PGP signature
Bug#1052597: RFS: libkysdk-base/2.2.0.1-1 -- common files for kylin sdk base library
Hi. thanks for reply. > > I'm curious if libkysdk-base-common is really needed? This will also > require a NEW processing btw. > I have removed the libkysdk-base-common and uploaded to mentors. Lastest upload: https://mentors.debian.net/package/libkysdk-base/ libkysdk-base (2.2.0.1-1) unstable; urgency=medium . * Update libs soname version. * Fix compile error on armhf and ppc64el. * d/control: - Add Multi-Arch. Regards, xibowen
Bug#1052597: RFS: libkysdk-base/2.2.0.1-1 -- common files for kylin sdk base library
Hi, On Mon, 25 Sep 2023 11:11:05 +0800 "xibowen" wrote: > > Changes since the last upload: > > libkysdk-base (2.2.0.1-1) unstable; urgency=medium > . >* Update libs soname version. >* Fix compile error on armhf and ppc64el. >* d/control: > - Add libkysdk-base-common. > - Add Multi-Arch. > I'm curious if libkysdk-base-common is really needed? This will also require a NEW processing btw. $ cat libkysdk-base-common.install etc/kysdk/kysdk-base/kylog-rotate-default src/log/kylog-default.conf etc/kysdk/kysdk-base Regards, Aron
Bug#1052597: RFS: libkysdk-base/2.2.0.1-1 -- common files for kylin sdk base library
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "libkysdk-base": * Package name : libkysdk-base Version : 2.2.0.1-1 Upstream contact : Zhikai Chen * URL : https://gitee.com/openkylin/libkysdk-base * License : LGPL-3+ * Vcs : https://gitee.com/openkylin/libkysdk-base Section : libs The source builds the following binary packages: libkysdk-base2 - Kylin SDK basic library libkysdk-base-dev - development files for libkysdk-base libkysdk-base-common - common files for kylin sdk base library To access further information about this package, please visit the following URL: https://mentors.debian.net/package/libkysdk-base/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/libk/libkysdk-base/libkysdk-base_2.2.0.1-1.dsc Changes since the last upload: libkysdk-base (2.2.0.1-1) unstable; urgency=medium . * Update libs soname version. * Fix compile error on armhf and ppc64el. * d/control: - Add libkysdk-base-common. - Add Multi-Arch. Regards, -- xibowen
