Bug#1061290: RFS: rgbds/0.7.0-3 [ITP] -- Game Boy ASM programming tools
I'm not a DD so I can't upload this, but I took a look. I see you've addressed most of the comments on Mentors in the repository on GitHub, so I'm reviewing that rather than the older upload on Mentors. Build-Depends lists pkg-config, which is a transitional package since bookworm that should be replaced with the newer pkgconf. lintian warns about this: W: rgbds source: build-depends-on-obsolete-package Build-Depends: pkg-config => pkgconf This is just a suggestion/tip and not at all required, but it's popular to use `wrap-and-sort -ast` to put each dependency on its own line (with a trailing comma). This would make the diff clearer in commits like d1842536 and 22baba8b. The years in the Copyright field of the "Files: *" stanza of d/copyright look outdated: "1997-2020" when LICENSE says "1997-2023" since commit f8af5696. Not required by all sponsors, but Emmanuel on Mentors and Tobias here suggested maintaining the packaging Git repository on Salsa (and updating the Vcs- fields): https://salsa.debian.org/ https://salsa.debian.org/games-team https://salsa.debian.org/debian You may also want to look into git-buildpackage with pristine-tar and a DEP-14 branch layout: https://honk.sigxcpu.org/piki/projects/git-buildpackage/ https://www.eyrie.org/~eagle/notes/debian/git.html https://dep-team.pages.debian.net/deps/dep14/ Looks OK otherwise to me, and the package builds fine under sbuild with no lintian tags (even informational or pedantic) other than the obsolete package warning above; nice work! So, once the pkg-config -> pkgconf switch and copyright years update are done, I think it's good enough for someone to upload. -- Patrick "P. J." McDermott: http://www.pehjota.net/ Lead Developer, ProteanOS: http://www.proteanos.com/ Founder and CEO, Libiquity: http://www.libiquity.com/
Bug#1061290: RFS: rgbds/0.7.0-3 [ITP] -- Game Boy ASM programming tools
Control: tags -1 moreinfo Hi Julius, a short review based on the dsc uploaded 2024-02-02 22:10 d/control: - Initial packagin starts at Debian revision -1 (yours is -3) d/patches; - Remove, as empty. d/control: - its up to you to keep the comments, but then you need to maintain them and keep them up to date. However, as the information you write in the comment is already given by the Build-Depends: field, it would be redudant for me, I would remove them completly. - Some of your versioned Build-Depends are available since at least oldstable. In this case, remove the version constraint. (cmake and bison) - VCS-* points to where the package is maintained, not upstream. Please update the link, preferable to a repository on salsa. I can create one for you either in the Debian namespace of games-team namespace and grant you all rights you need. Let me know. (Note: I do not sponsor uploads of new packages if the packaging is not maintained on salsa. This does not consitute a promise that I will sponsor if it on salsa, though.) - As you've asked the games team for sponsoring, please put it under the umbrella of the games team. d/gbp.conf: - seems that there is some git repo ;) - you should also use pristine-tar and enable sign-tags d/source/lintian-overrides: - please limit the usage of wildcards to the minimum, so that new instances of the override will be caught in future versions of the d/rules: - it seems that you leave out some tests, due to it pulling stuff from the web. This is the right way during build, as you cant download. However, you can download stuff in autopkgtest, so you should implement autopkgtest. d/changelog: - update the timestamp. (dch -r "") Tagging "moreinfo", remove the tag when you've got something ready for review. -- Cheers, tobi
Bug#1061290: RFS: rgbds/0.7.0-3 [ITP] -- Game Boy ASM programming tools
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package "rgbds": * Package name : rgbds Version : 0.7.0-3 Upstream contact : Eldred Habert * URL : https://rgbds.gbdev.io * License : Expat * Vcs : https://github.com/Robbi-Blechdose/rgbds-deb Section : devel The source builds the following binary packages: rgbds - Game Boy ASM programming tools To access further information about this package, please visit the following URL: https://mentors.debian.net/package/rgbds/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/r/rgbds/rgbds_0.7.0-3.dsc Changes for the initial release: rgbds (0.7.0-3) unstable; urgency=medium
