Bug#682781: RFS: minidlna
Bart Martens wrote: > On Fri, Jul 27, 2012 at 03:10:02PM +0200, Benoît Knecht wrote: > > I'm not sure what you're proposing I should do. > > I sometimes give feedback on a package without proposing a solution. I understand, but since I didn't see a solution myself, I thought I'd ask if you had any suggestions :) > In this case it is, in my opinion, OK to remove the non-free parts from the > upstream tarball, and to ship everything else in the .debian.tar.gz file. I disagree, if that means that the source cannot be built without the *.debian.tar.gz tarball. Out of curiosity, I had a look at the iceweasel package to see how they handled the repackaging, and they also substitute non-free portions with free replacements in a few files. So I think it's more important that the repackaged archive is buildable than to not modify any upstream file (as long as the modifications are documented, of course). Cheers, -- Benoît Knecht -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120806145922.gc24...@marvin.lan
Bug#682781: RFS: minidlna
On Fri, Jul 27, 2012 at 03:10:02PM +0200, Benoît Knecht wrote: > I'm not sure what you're proposing I should do. I sometimes give feedback on a package without proposing a solution. In this case it is, in my opinion, OK to remove the non-free parts from the upstream tarball, and to ship everything else in the .debian.tar.gz file. Regards, Bart Martens -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120727175410.ga14...@master.debian.org
Bug#682781: RFS: minidlna
Bart Martens wrote:
> On Thu, Jul 26, 2012 at 05:45:51PM +0200, Benoît Knecht wrote:
> > Bart Martens wrote:
> > > minidlna-1.0.25+dfsg/debian/copyright :
> > >
> > > | Source: http://sourceforge.net/projects/minidlna/files/
> > > | The icons.c file in the original tarball contained binary blobs of
> > > possibly
> > > | unfree images. It has hence been replaced in the DFSG tarball by a
> > > file
> > > | containing the free Debian logo instead. It can be generated from
> > > the SVG logo
> > > | using the debian/make_icons.sh script (see the header of that file
> > > for
> > > | instructions).
> > >
> > > http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-origtargz
> > >
> > > | A repackaged .orig.tar.{gz,bz2,xz} should not contain any file that
> > > does not
> > > | come from the upstream author(s), or whose contents has been changed
> > > by you.
> > >
> > > So removing files is OK, adding/replacing files not.
> >
> > You're right, except that in this case, the source would fail to build
> > if I simply removed icons.c, so I think it falls under the exception
> > laid out in the footnote [1]:
> >
> > | As a special exception, if the omission of non-free files would lead
> > | to the source failing to build without assistance from the Debian
> > | diff, it might be appropriate to instead edit the files, omitting only
> > | the non-free parts of them, and/or explain the situation in a
> > | README.source file in the root of the source tree. But in that case
> > | please also urge the upstream author to make the non-free components
> > | easier separable from the rest of the source.
> >
> > [1]
> > http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#ftn.idp20146152
>
> That is about editing the to omit non-free parts, not about adding/replacing
> files.
I'm not sure what you're proposing I should do. The upstream icons.c
contained four binary blobs, each corresponding to a possibly unfree
logo. I can't remove the entire file (or it won't compile) and I can't
replace the binary blobs with empty strings (or it won't run). So I
changed the file as little as possible while ensuring that it leads to a
DFSG-compliant and running program; it just happens to be more or less
the same thing as replacing the entire file, since it contained unfree
data only.
Cheers,
--
Benoît Knecht
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120727131001.ga2...@marvin.lan
Bug#682781: RFS: minidlna
On Thu, Jul 26, 2012 at 04:13:53PM +, Bart Martens wrote: > That is about editing the to omit non-free parts, not about adding/replacing > files. I meant "editing the files". Regards, Bart Martens -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120726161822.ge31...@master.debian.org
Bug#682781: RFS: minidlna
On Thu, Jul 26, 2012 at 05:45:51PM +0200, Benoît Knecht wrote:
> Bart Martens wrote:
> > minidlna-1.0.25+dfsg/debian/copyright :
> >
> > | Source: http://sourceforge.net/projects/minidlna/files/
> > | The icons.c file in the original tarball contained binary blobs of
> > possibly
> > | unfree images. It has hence been replaced in the DFSG tarball by a
> > file
> > | containing the free Debian logo instead. It can be generated from the
> > SVG logo
> > | using the debian/make_icons.sh script (see the header of that file for
> > | instructions).
> >
> > http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-origtargz
> >
> > | A repackaged .orig.tar.{gz,bz2,xz} should not contain any file that
> > does not
> > | come from the upstream author(s), or whose contents has been changed
> > by you.
> >
> > So removing files is OK, adding/replacing files not.
>
> You're right, except that in this case, the source would fail to build
> if I simply removed icons.c, so I think it falls under the exception
> laid out in the footnote [1]:
>
> | As a special exception, if the omission of non-free files would lead
> | to the source failing to build without assistance from the Debian
> | diff, it might be appropriate to instead edit the files, omitting only
> | the non-free parts of them, and/or explain the situation in a
> | README.source file in the root of the source tree. But in that case
> | please also urge the upstream author to make the non-free components
> | easier separable from the rest of the source.
>
> [1]
> http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#ftn.idp20146152
That is about editing the to omit non-free parts, not about adding/replacing
files.
>
> I haven't contacted upstream about it though, but I will do so shortly.
It is always good to inform upstream about any non-free parts.
>
> But I now realize, reading the page you pointed to, that the top-level
> directory in my orig.tar is improperly named; right now, it's called
> minidlna-1.0.25+dfsg, and it should be minidlna-1.0.25+dfsg.orig (or is
> it minidlna-1.0.25.orig?).
I read packagename-upstream-version.orig, so it is minidlna-1.0.25.orig.
> I wonder however, if the goal is to "make it
> possible to distinguish pristine tarballs from repackaged ones", if
> minidlna-1.0.25+dfsg doesn't make that clear enough already.
I agree that this makes that clear enough already.
Regards,
Bart Martens
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120726161353.gd31...@master.debian.org
Bug#682781: RFS: minidlna
Hi Bart,
Thanks a lot for your prompt reply.
Bart Martens wrote:
> minidlna-1.0.25+dfsg/debian/copyright :
>
> | Source: http://sourceforge.net/projects/minidlna/files/
> | The icons.c file in the original tarball contained binary blobs of
> possibly
> | unfree images. It has hence been replaced in the DFSG tarball by a file
> | containing the free Debian logo instead. It can be generated from the
> SVG logo
> | using the debian/make_icons.sh script (see the header of that file for
> | instructions).
>
> http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-origtargz
>
> | A repackaged .orig.tar.{gz,bz2,xz} should not contain any file that does
> not
> | come from the upstream author(s), or whose contents has been changed by
> you.
>
> So removing files is OK, adding/replacing files not.
You're right, except that in this case, the source would fail to build
if I simply removed icons.c, so I think it falls under the exception
laid out in the footnote [1]:
| As a special exception, if the omission of non-free files would lead
| to the source failing to build without assistance from the Debian
| diff, it might be appropriate to instead edit the files, omitting only
| the non-free parts of them, and/or explain the situation in a
| README.source file in the root of the source tree. But in that case
| please also urge the upstream author to make the non-free components
| easier separable from the rest of the source.
[1]
http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#ftn.idp20146152
I haven't contacted upstream about it though, but I will do so shortly.
But I now realize, reading the page you pointed to, that the top-level
directory in my orig.tar is improperly named; right now, it's called
minidlna-1.0.25+dfsg, and it should be minidlna-1.0.25+dfsg.orig (or is
it minidlna-1.0.25.orig?). I wonder however, if the goal is to "make it
possible to distinguish pristine tarballs from repackaged ones", if
minidlna-1.0.25+dfsg doesn't make that clear enough already. It's the
default name chosen by git-buildpackage, so if there is agreement that
this isn't a good name, I'll submit a patch to change that.
Thanks again for taking a look at my package; if there are any other
issues (or if you think I didn't address your concerns appropriately),
don't hesitate to let me know.
Cheers,
--
Benoît Knecht
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120726154551.ge2...@marvin.lan
Bug#682781: RFS: minidlna
Hi Benoît,
minidlna-1.0.25+dfsg/debian/copyright :
| Source: http://sourceforge.net/projects/minidlna/files/
| The icons.c file in the original tarball contained binary blobs of
possibly
| unfree images. It has hence been replaced in the DFSG tarball by a file
| containing the free Debian logo instead. It can be generated from the SVG
logo
| using the debian/make_icons.sh script (see the header of that file for
| instructions).
http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-origtargz
| A repackaged .orig.tar.{gz,bz2,xz} should not contain any file that does
not
| come from the upstream author(s), or whose contents has been changed by
you.
So removing files is OK, adding/replacing files not.
Regards,
Bart Martens
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120725184220.gb14...@master.debian.org
Bug#682781: RFS: minidlna/1.0.25+dfsg-1 -- lightweight DLNA/UPnP-AV server targeted at embedded systems
Package: sponsorship-requests Severity: normal User: sponsorship-reque...@packages.debian.org Usertags: not-for-wheezy, not-fit-for-wheezy Dear mentors, I am looking for a sponsor for my package "minidlna" * Package name: minidlna Version : 1.0.25+dfsg-1 Upstream Author : Justin Maggard * URL : http://sourceforge.net/projects/minidlna/ * License : GPL-2 Section : net It builds those binary packages: minidlna - lightweight DLNA/UPnP-AV server targeted at embedded systems As it is not intended for wheezy, I'm targeting experimental. To access further information about this package, please visit the following URL: http://mentors.debian.net/package/minidlna Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/m/minidlna/minidlna_1.0.25+dfsg-1.dsc Changes since the last upload: * New upstream version - Fix a couple crash bugs on malformed WAV files - Forcibly tweak the model number for Xbox360 clients, or they might ignore us - Enable all network interfaces by default if none were specified - Add flag to force downscaled thumbnails rather than using embedded ones - Add DirecTV client detection, and fix image resolution issue - Add support for the latest ffmpeg/libav library versions - Fix a potential crash on requests for a resize of a non-existent image - Make DeviceID checking more permissive for Sagem Radio * Update the documentation with new options and various corrections in the following places: - minidlna(1) man page; - minidlna.conf(5) man page; - output of "minidlna -h"; - default configuration file. * Display the user minidlna is running as in the default friendly name * Adapt "Get IP and MAC addresses in a non Linux-specific way" patch to upstream changes * Fix Makefile so that hardening flags are actually passed to the compiler * preinst: Make sure that the home directory exists and is owned by the correct user:group * postrm: Do not remove the minidlna user and group on purge * postrm: During purge, only remove the $HOME directory if it's /var/lib/minidlna; we don't want to mess with home directories if the admin changed the default * postrm: Do not remove the configuration file in the purge case, it has already been removed by dpkg before the script is called * Update period of copyright for debian/* * Replace `...` with $(...) in all maintainer scripts * Do not include scripts specific to the git repository in the debian/ directory in the source package Cheers, -- Benoît Knecht -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120725155524.ga31...@marvin.lan
