Bug#683120: RFS: yadifa/2.0.5-1 [ITP]
Hi Gianfranco On 17.08.2015 at 16:41 Gianfranco Costamagna wrote: 1) # upstream does not sign releases #yadifa source: debian-watch-may-check-gpg-signature That is a commented out leftover. I have removed it anyway so other won't think it is still used like you ;-) 2) sbin/yadifad/install-sh not mentioned in copyright (and every install-sh on the source tree) Ah, well spotted. I added the (hopefully correct) license paragraph to debian/copyright. the other stuff looks good to me Great. Thanks for the review. New version is on mentors.d.n Best regards, Markus
Bug#683120: RFS: yadifa/2.0.5-1 [ITP]
Hi everyone, On 16.08.2015 at 22:53 Jakub Wilk wrote: * Christian Kastner c...@debian.org, 2015-08-16, 19:08: debian/rules: - I believe the export DH_OPTIONS [...] to make magic work can be dropped. I think this is a remnant from a time long past; I can't find any reference to this in recent documentation. dh(1), for example, makes no mention of this. Second opinions welcome... Right. It's no-op when you export DH_OPTIONS but never set it. Okay, I have made all suggested changes, rebuild the 2.1.1 release and uploaded it to mentors. http://mentors.debian.net/debian/pool/main/y/yadifa/yadifa_2.1.1-1.dsc Yes, that is not the latest upstream version, but that one does not segfault. So I'd rather introduce a working, but not latest, version into Debian than a broken one. Best regards, Markus
Bug#683120: RFS: yadifa/2.0.5-1 [ITP]
Control: owner -1 ! Hi Markus, Following my review: 1) # upstream does not sign releases #yadifa source: debian-watch-may-check-gpg-signature ls upstream/signing-key.asc upstream/signing-key.asc which one is correct? 2) sbin/yadifad/install-sh not mentioned in copyright (and every install-sh on the source tree) the other stuff looks good to me cheers, Gianfranco
Bug#683120: RFS: yadifa/2.0.5-1 [ITP]
Hi Markus, On 2015-06-05 13:52, Markus Schade wrote: New package for yadifa 2.1.0 is available http://mentors.debian.net/debian/pool/main/y/yadifa/yadifa_2.1.0-1.dsc It would be great if someone could sponsor this package. I think the history of this bugreport proves that the package is well maintained. And it is much better than upstream referencing my github repo as the canonical way to get yadifa to run on Debian/Ubuntu. I just checked your package and I think that it is almost ready for upload. Here are just a few minor points: debian/copyright: - lintian complains about non-unique license specifications. Applying the pattern from Example #2 of [1] should resolve this issue. debian/control: - You can drop the version restriction for dpkg-dev. The version in oldstable (wheezy) is already higher. debian/changelog: - Please remove all entries except the newest one which documents the initial release. debian/yadifa.default debian/yadifa.service: - AFAIUI, when using systemd, the contents of /etc/default/yadifa will be ignored. This might be a problem for users switching from sysvinit to systemd later on. If they changed the default, eg by changing the location of the configuration file, this change will no longer be honored after the systemd switch. One way you can address this problem is by using EnvironmentFile in the service file. The cron package does it that way, for example. debian/rules: - I believe the export DH_OPTIONS [...] to make magic work can be dropped. I think this is a remnant from a time long past; I can't find any reference to this in recent documentation. dh(1), for example, makes no mention of this. Second opinions welcome... [1] https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#stand-alone-license-paragraph Regards, Christian signature.asc Description: OpenPGP digital signature
Bug#683120: RFS: yadifa/2.0.5-1 [ITP]
* Christian Kastner c...@debian.org, 2015-08-16, 19:08: debian/rules: - I believe the export DH_OPTIONS [...] to make magic work can be dropped. I think this is a remnant from a time long past; I can't find any reference to this in recent documentation. dh(1), for example, makes no mention of this. Second opinions welcome... Right. It's no-op when you export DH_OPTIONS but never set it. Also, debhelper manpage says: When using dh(1), it can be passed options that will be passed on to each debhelper command, which is generally better than using DH_OPTIONS. For the curious, the origin of the export DH_OPTIONS pattern is this d/rules example, where it was indeed required to make things work: https://sources.debian.net/src/debhelper/8.0.0/examples/rules.multi2/ dh-make include similar d/rules skeletons, too. -- Jakub Wilk
Bug#683120: RFS: yadifa/2.0.5-1 [ITP]
On 03/05/2015 04:32 PM, Paul Wise wrote: On Thu, 2015-03-05 at 16:24 +0100, Markus Schade wrote: And I have asked them to do so, of course. Likewise with the other things you mentioned (e.g. signing their releases). Ah, good. I wasn't sure if you had done that, sorry. My point is that I cannot make upstream do any of it. Ack. Nagging upstream has paid off and they have started signing their releases. New package for yadifa 2.1.0 is available http://mentors.debian.net/debian/pool/main/y/yadifa/yadifa_2.1.0-1.dsc It would be great if someone could sponsor this package. I think the history of this bugreport proves that the package is well maintained. And it is much better than upstream referencing my github repo as the canonical way to get yadifa to run on Debian/Ubuntu. Best regards, Markus -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/55718d81.9070...@gmail.com
Bug#683120: RFS: yadifa/2.0.5-1 [ITP]
On Thu, 2015-03-05 at 16:24 +0100, Markus Schade wrote: Yes, I know that. ;-) And I have asked them to do so, of course. Likewise with the other things you mentioned (e.g. signing their releases). Ah, good. I wasn't sure if you had done that, sorry. My point is that I cannot make upstream do any of it. Ack. -- bye, pabs https://wiki.debian.org/PaulWise signature.asc Description: This is a digitally signed message part
Bug#683120: RFS: yadifa/2.0.5-1 [ITP]
On Thu, Mar 5, 2015 at 10:32 PM, Markus Schade wrote: But then again, I am just the packager not the developer. So I can do little about the code quality. You could forward the code quality issues upstream as suggested by the Debian social contract: https://www.debian.org/social_contract -- bye, pabs https://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/caktje6ecw3py4w7zuh1zpd8ew+nzw1fzwumu16ofmbahjjd...@mail.gmail.com
Bug#683120: RFS: yadifa/2.0.5-1 [ITP]
On 03/05/2015 04:16 PM, Paul Wise wrote: On Thu, Mar 5, 2015 at 10:32 PM, Markus Schade wrote: You could forward the code quality issues upstream as suggested by the Debian social contract: https://www.debian.org/social_contract Yes, I know that. ;-) And I have asked them to do so, of course. Likewise with the other things you mentioned (e.g. signing their releases). My point is that I cannot make upstream do any of it. Markus -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/54f87539.60...@gmail.com
Bug#683120: RFS: yadifa/2.0.5-1 [ITP]
Dear Paul, dear mentors, Thank you for your extensive review. I won't go into detail for every item you have mentioned, but I believe that many if not most issues have been dealt with. But then again, I am just the packager not the developer. So I can do little about the code quality. All of my patches are now upstream, even though they are still not signing their releases (I haven't got an answer as to why). I will leave the internal libraries as static until they are stable. So far nothing outside of yadifa can or should use them. So, to sum things up, I am again looking for a sponsor for yadifa. Now with the new release 2.0.5 YADIFA is a Yet Another DNS Implementation For All, a DNS server written by the people of the EURid registry. The URL of the package is: http://mentors.debian.net/package/yadifa The respective dsc file can be found at: http://mentors.debian.net/debian/pool/main/y/yadifa/yadifa_2.0.5-1.dsc Kind regards, Markus -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/54f868f3.7090...@gmail.com
