Bug#697627: RFS: gogglesmm/0.12.7-1
Hi Sebastian, thank you for your review. Those libraries are linked due to the pkg-config file generated during the build of gogglesmm. libfox-1.6-dev's fox.pc only says to link against liblFOX-1.6. So using the pkg-config file provided by libfox-1.6-dev gets rid of all the unnecessary dependencies. Removing the unecessary dependencies means that gogglesmm doesn't need to be taken care of if those libraries should ever be transitioned. At least for one of the libraries a transition is planned (libpng12 - libpng15). So that was my mistake. I assumed that fox-config and pkg-config do the same. Some time ago the package libfox-1.6 did not contain a pkg-config script. Hence it was necessary to generate one. But fortunately things have changed so I removed the generation of the pkg-config file. The corrected version can be obtained via dget -x http://mentors.debian.net/debian/pool/main/g/gogglesmm/gogglesmm_0.12.7-1.dsc Regards Hendrik signature.asc Description: This is a digitally signed message part
Bug#697627: RFS: gogglesmm/0.12.7-1
Hi Hendrik, sorry for the very late reply. Somehow the mail got lost in my inbox. Please feel free to ping me if I shouldn't respond within a week. On 2013-06-05 00:11:00, Hendrik Rittich wrote: There also many useless dependency warnings from dh-shlibdeps. Please get these fixed. Those libraries are linked due to pkg-config configuration files. These libraries are all dependencies of the libfox-1.6-0 package. Since gogglesmm depends on libfox those dependencies are needed anyways. Therefore I think there is no reason for removing these direct dependencies. Those libraries are linked due to the pkg-config file generated during the build of gogglesmm. libfox-1.6-dev's fox.pc only says to link against liblFOX-1.6. So using the pkg-config file provided by libfox-1.6-dev gets rid of all the unnecessary dependencies. Removing the unecessary dependencies means that gogglesmm doesn't need to be taken care of if those libraries should ever be transitioned. At least for one of the libraries a transition is planned (libpng12 - libpng15). Regards -- Sebastian Ramacher signature.asc Description: Digital signature
Bug#697627: RFS: gogglesmm/0.12.7-1
Hi, I made some changes to the package which can be found here: http://mentors.debian.net/debian/pool/main/g/gogglesmm/gogglesmm_0.12.7-1.dsc Am Sonntag, den 02.06.2013, 23:54 +0200 schrieb Sebastian Ramacher: On 2013-01-07 20:19:36, Hendrik Rittich wrote: dget -x http://mentors.debian.net/debian/pool/main/g/gogglesmm/gogglesmm_0.12.7-1.dsc The change of Standards-Version is not documented in the changelog. Some of the changes to debian/rules are not documented either. This should be corrected. Why are you only using the hardening flags from CPPFLAGS and LDFLAGS but not the ones from C(XX)FLAGS? Additionally, DEB_BUILD_OPTIONS=noopt doesn't work anymore. That was my mistake. I used the wrong variable. Should be fixed. There also many useless dependency warnings from dh-shlibdeps. Please get these fixed. Those libraries are linked due to pkg-config configuration files. These libraries are all dependencies of the libfox-1.6-0 package. Since gogglesmm depends on libfox those dependencies are needed anyways. Therefore I think there is no reason for removing these direct dependencies. Why does the clean target run dh_testroot? I removed that. lintian emits: P: gogglesmm source: duplicate-in-relation-field in source build-depends: libdbus-1-dev, libdbus-1-dev P: gogglesmm source: unversioned-copyright-format-uri http://dep.debian.net/deps/dep5 W: gogglesmm source: out-of-date-standards-version 3.9.3 (current is 3.9.4) Please fix these. This should be fixed. lintian also emits: I: gogglesmm: desktop-entry-lacks-keywords-entry usr/share/applications/gogglesmm.desktop Please forward this issue upstream and get it fixed there. Done. I hope that fixes the issues with the package. Thank you for your time. Regards, Hendrik signature.asc Description: This is a digitally signed message part
Bug#697627: RFS: gogglesmm/0.12.7-1
On 2013-01-07 20:19:36, Hendrik Rittich wrote: dget -x http://mentors.debian.net/debian/pool/main/g/gogglesmm/gogglesmm_0.12.7-1.dsc The change of Standards-Version is not documented in the changelog. Some of the changes to debian/rules are not documented either. Why are you only using the hardening flags from CPPFLAGS and LDFLAGS but not the ones from C(XX)FLAGS? Additionally, DEB_BUILD_OPTIONS=noopt doesn't work anymore. There also many useless dependency warnings from dh-shlibdeps. Please get these fixed. Why does the clean target run dh_testroot? lintian emits: P: gogglesmm source: duplicate-in-relation-field in source build-depends: libdbus-1-dev, libdbus-1-dev P: gogglesmm source: unversioned-copyright-format-uri http://dep.debian.net/deps/dep5 W: gogglesmm source: out-of-date-standards-version 3.9.3 (current is 3.9.4) Please fix these. lintian also emits: I: gogglesmm: desktop-entry-lacks-keywords-entry usr/share/applications/gogglesmm.desktop Please forward this issue upstream and get it fixed there. Regards -- Sebastian Ramacher signature.asc Description: Digital signature
Bug#697627: RFS: gogglesmm/0.12.7-1
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package gogglesmm * Package name: gogglesmm Version : 0.12.7-1 Upstream Author : Sander Jansen s.jan...@gmail.com * URL : http://code.google.com/p/gogglesmm/ * License : GPLv3 Section : sound It builds those binary packages: gogglesmm - Goggles Music Manager To access further information about this package, please visit the following URL: http://mentors.debian.net/package/gogglesmm Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/g/gogglesmm/gogglesmm_0.12.7-1.dsc More information about hello can be obtained from http://www.example.com. Changes since the last upload: * New upstream release, closes: #697587 * Updated build dependencies * Added the use of buildflags.mk Regards, Hendrik Rittich signature.asc Description: This is a digitally signed message part
