Bug#701706: RFS: ocamlrss/2.0-1 [ITP] -- RSS 2.0 parser and printer for OCaml
On Thu, May 23, 2013 at 6:38 PM, Stéphane Glondu glo...@debian.org wrote:
Le 23/05/2013 05:45, Prach Pongpanich a écrit :
Packaging a new upstream 2.2.0:
Sorry for taking so long, but I wanted to look at the whole thread
first... which I haven't done so far. Anyway, since you've been waiting
for some time now, I've just directly looked at your package without
looking at previous comments.
dget -x
http://mentors.debian.net/debian/pool/main/o/ocamlrss/ocamlrss_2.2.0-1.dsc
http://anonscm.debian.org/gitweb/?p=pkg-ocaml-maint/packages/ocamlrss.git
Please do not override Lintian tags about hardening.
Native plugins should be installed only when natdynlink is available,
please consider s/OPT/DYN/ in librss-ocaml.install.in.
Please add ${shlibs:Depends} to -dev package as well.
The relationship with Cameleon described in the description suggests a
versioned Breaks/Replaces relationship instead of a Conflicts.
A period is missing at the end of the -dev description.
rss_date.* files have been removed in version 2.1.0. Please update
debian/copyright accordingly.
You say LGPL-3+ in debian/copyright whereas it is written LGPL-3 (no
or later clause) everywhere else. Please fix.
Thanks for your review and suggestion, I have done all of the above.
http://anonscm.debian.org/gitweb/?p=pkg-ocaml-maint/packages/ocamlrss.git
Regrads,
Prach
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive:
http://lists.debian.org/CAF=n8mlezsrf4cos5xf0vamarvrudork+gresm5thnkohpv...@mail.gmail.com
Bug#701706: RFS: ocamlrss/2.0-1 [ITP] -- RSS 2.0 parser and printer for OCaml
Le 24/05/2013 10:09, Prach Pongpanich a écrit : Thanks for your review and suggestion, I have done all of the above. Your Replaces/Breaks clause is always satisfied, even in oldstable... isnt't? If so, it is pointless and you should remove it. Does ocamlrss actually install files in the same location as cameleon? Replaces/Breaks/Conflicts are there for expressing package-level relationships, not for end users (in)convenience. IMHO, just installing a module with the same name in different locations is not enough to justify it. I don't know exactly what you understood when I said: A period is missing at the end of the -dev description. ... but from your changes, it looks like it is not the lack of a punctuation sign. Cheers, -- Stéphane -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/519f737c.7070...@debian.org
Bug#701706: RFS: ocamlrss/2.0-1 [ITP] -- RSS 2.0 parser and printer for OCaml
On Fri, May 24, 2013 at 9:04 PM, Stéphane Glondu glo...@debian.org wrote: Le 24/05/2013 10:09, Prach Pongpanich a écrit : Thanks for your review and suggestion, I have done all of the above. Your Replaces/Breaks clause is always satisfied, even in oldstable... isnt't? If so, it is pointless and you should remove it. Does ocamlrss actually install files in the same location as cameleon? Replaces/Breaks/Conflicts are there for expressing package-level relationships, not for end users (in)convenience. IMHO, just installing a module with the same name in different locations is not enough to justify it. No, I remove Replaces/Breaks from the librss-ocaml-dev package. I don't know exactly what you understood when I said: A period is missing at the end of the -dev description. ... but from your changes, it looks like it is not the lack of a punctuation sign. My bad, I added a full stop (period) to the end of description. http://anonscm.debian.org/gitweb/?p=pkg-ocaml-maint/packages/ocamlrss.git Cheers, Prach -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAF=n8m+udrnpcdvzdckr_kp3ew0r7oay7nda8fxnk+x_vmx...@mail.gmail.com
Bug#701706: RFS: ocamlrss/2.0-1 [ITP] -- RSS 2.0 parser and printer for OCaml
Le 23/05/2013 05:45, Prach Pongpanich a écrit :
Packaging a new upstream 2.2.0:
Sorry for taking so long, but I wanted to look at the whole thread
first... which I haven't done so far. Anyway, since you've been waiting
for some time now, I've just directly looked at your package without
looking at previous comments.
dget -x
http://mentors.debian.net/debian/pool/main/o/ocamlrss/ocamlrss_2.2.0-1.dsc
http://anonscm.debian.org/gitweb/?p=pkg-ocaml-maint/packages/ocamlrss.git
Please do not override Lintian tags about hardening.
Native plugins should be installed only when natdynlink is available,
please consider s/OPT/DYN/ in librss-ocaml.install.in.
Please add ${shlibs:Depends} to -dev package as well.
The relationship with Cameleon described in the description suggests a
versioned Breaks/Replaces relationship instead of a Conflicts.
A period is missing at the end of the -dev description.
rss_date.* files have been removed in version 2.1.0. Please update
debian/copyright accordingly.
You say LGPL-3+ in debian/copyright whereas it is written LGPL-3 (no
or later clause) everywhere else. Please fix.
Cheers,
--
Stéphane
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/519dffb3.8000...@debian.org
Bug#701706: RFS: ocamlrss/2.0-1 [ITP] -- RSS 2.0 parser and printer for OCaml
Control: retitle -1 RFS: ocamlrss/2.2.0-1 [ITP] -- RSS 2.0 parser and printer for OCaml Hi, Packaging a new upstream 2.2.0: dget -x http://mentors.debian.net/debian/pool/main/o/ocamlrss/ocamlrss_2.2.0-1.dsc http://anonscm.debian.org/gitweb/?p=pkg-ocaml-maint/packages/ocamlrss.git Regrads, Prach -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAF=n8mlnxfmewttwe6x5a-rd-b8rqy7kzz++hmcdchpcx-y...@mail.gmail.com
Bug#701706: RFS: ocamlrss/2.0-1 [ITP] -- RSS 2.0 parser and printer for OCaml
Control: retitle -1 RFS: ocamlrss/2.1.0-1 [ITP] -- RSS 2.0 parser and printer for OCaml Hi Paul, ocamlc: File rss_date.ml, line 220, characters 10-280: Warning 25: bad style, all clauses in this pattern-matching are guarded. similarity-tester: rss_types.ml consists for 85 % of ./rss.ml material I will discuss with the upstream author. rss_date.ml was removed from upstream. lintian overrides, upstream changelog is not available (#513544). It is not correct to override these, instead you should ask upstream to add a NEWS file or ChangeLog. After I opened issue about a changelog file, a Changes file was added for release 2.1.0 [1]. dget -x http://mentors.debian.net/debian/pool/main/o/ocamlrss/ocamlrss_2.1.0-1.dsc [2] [1] https://github.com/zoggy/ocamlrss/issues/4 [2] https://mentors.debian.net/package/ocamlrss Regrads, -- Prach Pongpanich -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAF=n8MLSayaBYaJpbCipJg95mNZZRCeXmne=Xbg102=upek...@mail.gmail.com
Bug#701706: RFS: ocamlrss/2.0-1 [ITP] -- RSS 2.0 parser and printer for OCaml
Hi Paul, On Mon, Mar 4, 2013 at 6:19 PM, Paul Wise p...@debian.org wrote: I don't intend to sponsor this package, but here is a review: You might want to get involved in the ocaml team: http://wiki.debian.org/Teams/OCamlTaskForce I already done. Please drop the unnessecary information from the patch header, including the partial changelog and the stuff about patch tagging guidelines. Please get the patch included upstream. Please improve your watch file: Fixed There should be no need for .PHONY in debian/rules. Fixed The lintian override should probably be replaced by a bug against lintian or blhc. I see in debian-ocaml-maint [1] but I can't find a bug against lintian. [2] The copyright/license info for rss_date.mli/rss_date.ml is incomplete. Fixed, dual license lintian: P: librss-ocaml: no-upstream-changelog P: librss-ocaml-dev: no-upstream-changelog lintian overrides, upstream changelog is not available (#513544). ocamlc: File rss_date.ml, line 220, characters 10-280: Warning 25: bad style, all clauses in this pattern-matching are guarded. similarity-tester: rss_types.ml consists for 85 % of ./rss.ml material I will discuss with the upstream author. dget -x http://mentors.debian.net/debian/pool/main/o/ocamlrss/ocamlrss_2.0-1.dsc [1] https://lists.debian.org/debian-ocaml-maint/2012/05/msg00091.html [2] http://bugs.debian.org/cgi-bin/pkgreport.cgi?pkg=lintian Regrads -- ปรัชญ์ พงษ์พานิช Prach Pongpanich http://prach-public.blogspot.com -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAF=n8mloomucm-pr58kdq6wz3wc788v8vf-b9v77kgsaklb...@mail.gmail.com
Bug#701706: RFS: ocamlrss/2.0-1 [ITP] -- RSS 2.0 parser and printer for OCaml
On Tue, Mar 5, 2013 at 4:58 PM, Prach Pongpanich wrote: I already done. Great, perhaps they can sponsor this. I see in debian-ocaml-maint [1] but I can't find a bug against lintian. [2] Please file one. lintian overrides, upstream changelog is not available (#513544). It is not correct to override these, instead you should ask upstream to add a NEWS file or ChangeLog. -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/caktje6gsvrgr+qjwscet0188tmvjj653m4vu+uwyzmimofu...@mail.gmail.com
Bug#701706: RFS: ocamlrss/2.0-1 [ITP] -- RSS 2.0 parser and printer for OCaml
I don't intend to sponsor this package, but here is a review: You might want to get involved in the ocaml team: http://wiki.debian.org/Teams/OCamlTaskForce Please drop the unnessecary information from the patch header, including the partial changelog and the stuff about patch tagging guidelines. Please get the patch included upstream. Please improve your watch file: http://wiki.debian.org/debian/watch#Common_mistakes There should be no need for .PHONY in debian/rules. The lintian override should probably be replaced by a bug against lintian or blhc. The copyright/license info for rss_date.mli/rss_date.ml is incomplete. Automatic checks: http://wiki.debian.org/HowToPackageForDebian#Check_points_for_any_package ocamlc: File rss_date.ml, line 220, characters 10-280: Warning 25: bad style, all clauses in this pattern-matching are guarded. lintian: P: librss-ocaml: no-upstream-changelog P: librss-ocaml-dev: no-upstream-changelog similarity-tester: rss_types.ml consists for 85 % of ./rss.ml material -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAKTje6G1iDg84=u=vvSdAUaLzcVUe-DUsvEzAH+YmB9dk=4...@mail.gmail.com
