Re: Bug#765009: Subject: RFS: abcmidi/20140928-1 [ITA]
On 10/25/2014 07:19 PM, Tobias Frost wrote:
> d/clean is your friend :)
> I pushed a fix to the repository: Adding debian/clean
>
> tobi@edoras:~/workspace/deb/mentors/_done/abcmidi/abcmidi$ cat
> debian/clean
> Makefile
> config.h
> config.log
> config.status
>
Thanks Tobias,
Okay, I am closer! Unfortunately, dh_clean is still not working and I
cannot workout why (buildlog attached). At least I managed to clean up
after autoreconf by adding dh_autoreconf_clean to the dh_auto_install
target. So the only files left now are in the debian directory, and do
not cause a subsequent build to fail.
debian/abcmidi.debhelper.log
debian/abcmidi.substvars
debian/abcmidi/
debian/files
For now I will carry on with some of Jame's other suggestions (copyright
& LDFLAGs).
Regards,
Ross
dpkg-buildpackage -rfakeroot -D -us -uc
dpkg-buildpackage: source package abcmidi
dpkg-buildpackage: source version 20141016-1~3.gbp63b824
dpkg-buildpackage: source distribution UNRELEASED
dpkg-buildpackage: source changed by Ross Gammon
dpkg-source --before-build abcmidi
dpkg-buildpackage: host architecture amd64
dpkg-source: info: using options from abcmidi/debian/source/local-options:
--unapply-patches
dpkg-source: info: applying hardening.patch
dpkg-source: info: applying manpages.patch
dpkg-source: info: applying fix_clean_target.patch
fakeroot debian/rules clean
dh clean --with autoreconf
dh_testdir
dh_auto_clean
make -j1 clean
make[1]: Entering directory `/home/ross/debian/abcmidi'
rm *.o abc2midi midi2abc abc2abc mftext yaps midicopy abcmatch
rm: cannot remove ‘*.o’: No such file or directory
rm: cannot remove ‘abc2midi’: No such file or directory
rm: cannot remove ‘midi2abc’: No such file or directory
rm: cannot remove ‘abc2abc’: No such file or directory
rm: cannot remove ‘mftext’: No such file or directory
rm: cannot remove ‘yaps’: No such file or directory
rm: cannot remove ‘midicopy’: No such file or directory
rm: cannot remove ‘abcmatch’: No such file or directory
make[1]: [clean] Error 1 (ignored)
make[1]: Leaving directory `/home/ross/debian/abcmidi'
dh_autoreconf_clean
dh_clean
rm -f debian/abcmidi.substvars
rm -f debian/abcmidi.*.debhelper
rm -rf debian/abcmidi/
rm -f debian/*.debhelper.log
rm -f -- Makefile config.h config.log config.status
debian/abcmidi.debhelper.log debian/abcmidi.substvars debian/abcmidi/
debian/files
rm -f debian/files
find . \( \( -type f -a \
\( -name '#*#' -o -name '.*~' -o -name '*~' -o -name DEADJOE \
-o -name '*.orig' -o -name '*.rej' -o -name '*.bak' \
-o -name '.*.orig' -o -name .*.rej -o -name '.SUMS' \
-o -name TAGS -o \( -path '*/.deps/*' -a -name '*.P' \) \
\) -exec rm -f {} + \) -o \
\( -type d -a -name autom4te.cache -prune -exec rm -rf {} + \)
\)
rm -f *-stamp
dpkg-source -b abcmidi
dpkg-source: info: using options from abcmidi/debian/source/local-options:
--unapply-patches
dpkg-source: info: using source format `3.0 (quilt)'
dpkg-source: info: building abcmidi using existing
./abcmidi_20141016.orig.tar.gz
dpkg-source: warning: ignoring deletion of file config.h.in
dpkg-source: warning: ignoring deletion of file configure
dpkg-source: info: building abcmidi in
abcmidi_20141016-1~3.gbp63b824.debian.tar.gz
dpkg-source: info: building abcmidi in abcmidi_20141016-1~3.gbp63b824.dsc
debian/rules build
dh build --with autoreconf
dh_testdir
dh_autoreconf
find ! -ipath "./debian/*" -a ! \( -path '*/.git/*' -o -path '*/.hg/*'
-o -path '*/.bzr/*' -o -path '*/.svn/*' -o -path '*/CVS/*' \) -a -type f -exec
md5sum {} \; > debian/autoreconf.before
autoreconf -f -i
find ! -ipath "./debian/*" -a ! \( -path '*/.git/*' -o -path '*/.hg/*'
-o -path '*/.bzr/*' -o -path '*/.svn/*' -o -path '*/CVS/*' \) -a -type f -exec
md5sum {} \; > debian/autoreconf.after
dh_auto_configure
./configure --build=x86_64-linux-gnu --prefix=/usr
--includedir=\${prefix}/include --mandir=\${prefix}/share/man
--infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var
--libdir=\${prefix}/lib/x86_64-linux-gnu
--libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode
--disable-dependency-tracking
configure: WARNING: unrecognized options: --disable-maintainer-mode,
--disable-dependency-tracking
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking for a BSD-compatible install... /usr/bin/install -c
checking for main in -lm... yes
checking how to run the C preprocessor... gcc -E
checking for grep that ha
Re: Bug#765009: Subject: RFS: abcmidi/20140928-1 [ITA]
d/clean is your friend :) I pushed a fix to the repository: Adding debian/clean tobi@edoras:~/workspace/deb/mentors/_done/abcmidi/abcmidi$ cat debian/clean Makefile config.h config.log config.status -- tobi Am Samstag, den 25.10.2014, 18:45 +0200 schrieb Ross Gammon: > On 10/25/2014 09:29 AM, Ross Gammon wrote: > > > > > On 10/25/2014 01:18 AM, Tobias Frost wrote: > >> Many thanks James! Valid points > >> > >> Ross, please also consider those comments. Especially please fix > >> the build system. I missed that during my review, sorry, but I > >> will file a bug for that. > >> > >> Am Montag, den 20.10.2014, 21:59 +0100 schrieb James Cowgill: > > > > >>> The clean target doesn't work because you disabled it. This is > >>> a violation of debian policy (4.9) "clean (required): This > >>> must undo any effects that the build and binary targets may > >>> have had" > >>> > > Okay, this is now driving me nuts! I have restored dh_auto_clean and > patched the upstream makefile so the clean target does not fail when > run before the build. > > But still the package does not clean properly. I assumed this was > because I was forced to override dh_auto_install and manually run > make. So I added dh_auto_clean to the end of the > override_dh_auto_install. This manages to run the upstream clean > target okay, but still leaves autoreconf cruft behind. > > I can't work out how to pass the "--with autoreconf" option to > dh_auto_clean (which I assume would done automagically if I didn't > have the override). > > The d/rules snippet is here: > %: > dh $@ --with autoreconf > > override_dh_auto_install: > #Upstream prefix is usr/local so manually call make > $(MAKE) DESTDIR=$$(pwd)/debian/abcmidi prefix=/usr install > #Remove duplicate license information > rm $(CURDIR)/debian/abcmidi/usr/share/doc/abcmidi/gpl.txt > #Remove duplicate changelog file > rm $(CURDIR)/debian/abcmidi/usr/share/doc/abcmidi/CHANGES > #Remove superfluous VERSION file > rm $(CURDIR)/debian/abcmidi/usr/share/doc/abcmidi/VERSION > #Remove duplicate AUTHORS file > rm $(CURDIR)/debian/abcmidi/usr/share/doc/abcmidi/AUTHORS > dh_auto_clean > > And you can find the git repo here: > http://anonscm.debian.org/cgit/collab-maint/abcmidi.git > > Cheers, > > Ross > > -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/1414257575.13897.10.ca...@frost.de
Re: Bug#765009: Subject: RFS: abcmidi/20140928-1 [ITA]
On 10/25/2014 09:29 AM, Ross Gammon wrote: > On 10/25/2014 01:18 AM, Tobias Frost wrote: >> Many thanks James! Valid points >> >> Ross, please also consider those comments. Especially please fix >> the build system. I missed that during my review, sorry, but I >> will file a bug for that. >> >> Am Montag, den 20.10.2014, 21:59 +0100 schrieb James Cowgill: >>> The clean target doesn't work because you disabled it. This is >>> a violation of debian policy (4.9) "clean (required): This >>> must undo any effects that the build and binary targets may >>> have had" >>> Okay, this is now driving me nuts! I have restored dh_auto_clean and patched the upstream makefile so the clean target does not fail when run before the build. But still the package does not clean properly. I assumed this was because I was forced to override dh_auto_install and manually run make. So I added dh_auto_clean to the end of the override_dh_auto_install. This manages to run the upstream clean target okay, but still leaves autoreconf cruft behind. I can't work out how to pass the "--with autoreconf" option to dh_auto_clean (which I assume would done automagically if I didn't have the override). The d/rules snippet is here: %: dh $@ --with autoreconf override_dh_auto_install: #Upstream prefix is usr/local so manually call make $(MAKE) DESTDIR=$$(pwd)/debian/abcmidi prefix=/usr install #Remove duplicate license information rm $(CURDIR)/debian/abcmidi/usr/share/doc/abcmidi/gpl.txt #Remove duplicate changelog file rm $(CURDIR)/debian/abcmidi/usr/share/doc/abcmidi/CHANGES #Remove superfluous VERSION file rm $(CURDIR)/debian/abcmidi/usr/share/doc/abcmidi/VERSION #Remove duplicate AUTHORS file rm $(CURDIR)/debian/abcmidi/usr/share/doc/abcmidi/AUTHORS dh_auto_clean And you can find the git repo here: http://anonscm.debian.org/cgit/collab-maint/abcmidi.git Cheers, Ross -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/544bd38e.9020...@the-gammons.net
Bug#765009: Subject: RFS: abcmidi/20140928-1 [ITA]
Yes - thanks to both James & Tobias for your help with this! I was working through the issues one by one, and was planning to update the RFS bug with my status today :-) The manpage is done, and just needs checking. I have already been in touch with upstream about the 3 "Mayhem" bugs, and will forward the manpage & the other patches. I will also discuss the other warnings & build issues. The upstream author (Seymour) actually uses Debian, so he is extra helpfull!! Regards, Ross On 10/25/2014 01:18 AM, Tobias Frost wrote: > Many thanks James! Valid points > > Ross, please also consider those comments. Especially please fix > the build system. I missed that during my review, sorry, but I will > file a bug for that. > > (Also, please send your patches upstream.) > > -- tobi > > > Am Montag, den 20.10.2014, 21:59 +0100 schrieb James Cowgill: >> On Mon, 2014-10-20 at 15:59 +0200, Ross Gammon wrote: >>> Hi All, >>> >>> I know everyone is busy with the Jessie Release Freeze, but I >>> would be grateful if somebody could take a look at abcmidi (and >>> sponsor if happy). Abcmidi has been sitting unloved for a while >>> now (since 2007). It would be great to get the latest version >>> into Jessie. >> >> Hi, >> >> Here's a review (I'm not a DD so can't sponsor you however). >> >> General * There is a new upstream version (16th October 2014). * >> #764998 abcmidi: binary-without-manpage usr/bin/abcmatch >> Obviously you know this, but it would be good if a manpage was >> added. * The file "/usr/share/doc/abcmidi/VERSION" seems >> redundant and can probably be removed. > > Also ÁUTHORS should not be installed. > > >> debian/copyright * You don't need to list abc.h, sizes.h, >> structs.h manually in the first section since they're already >> included when you say "Files: *". * There seems to be some >> confusion about whether the code is GPL-2 or GPL-2+. Are you sure >> what you've put is correct? I see files with no copyright headers >> but nothing with "GPL 2 only" in them. * You don't need to repeat >> the GPL header lots of times. I'd also be tempted to merge all >> the GPL sections together and just have a large "Copyright:" >> block. >> >> debian/rules * I don't think you need to use autotools-dev in >> this package (I don't know a huge amount about this though). * >> The clean target doesn't work because you disabled it. This is a >> violation of debian policy (4.9) "clean (required): This must >> undo any effects that the build and binary targets may have had" >> >> debian/patches: * Make sure you send these patches upstream >> (sorry if you've already done this - they're not in the new >> version though). * hardening.patch: Only LDFLAGS should be passed >> during the link stage. Remove your CFLAGS and CPPFLAGS >> additions. >> >> Build There are lots of bad warnings printed when building this >> Examples: * parseabc.c:1701:3: warning: format ‘%s’ expects >> argument of type ‘char *’, but argument 3 has type ‘char **’ >> [-Wformat=] success = sscanf (s, "%%abc-version %s", >> &abcversion); /* [SS] 2014-08-11 */ >> >> Isn't this a buffer overflow?! >> >> * toabc.c:1490:8: warning: iteration 7u invokes undefined >> behavior [-Waggressive-loop-optimizations] semi = >> convertnote[i]; >> >> It's not too difficult to use these to make abc2midi segfault - >> please try and fix them if you have time. >> >> James >> >> > -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/544b5141.8090...@the-gammons.net
Bug#765009: Subject: RFS: abcmidi/20140928-1 [ITA]
Many thanks James! Valid points Ross, please also consider those comments. Especially please fix the build system. I missed that during my review, sorry, but I will file a bug for that. (Also, please send your patches upstream.) -- tobi Am Montag, den 20.10.2014, 21:59 +0100 schrieb James Cowgill: > On Mon, 2014-10-20 at 15:59 +0200, Ross Gammon wrote: > > Hi All, > > > > I know everyone is busy with the Jessie Release Freeze, but I would be > > grateful if somebody could take a look at abcmidi (and sponsor if > > happy). Abcmidi has been sitting unloved for a while now (since 2007). > > It would be great to get the latest version into Jessie. > > Hi, > > Here's a review (I'm not a DD so can't sponsor you however). > > General > * There is a new upstream version (16th October 2014). > * #764998 abcmidi: binary-without-manpage usr/bin/abcmatch > Obviously you know this, but it would be good if a manpage was added. > * The file "/usr/share/doc/abcmidi/VERSION" seems redundant and can > probably be removed. Also ÁUTHORS should not be installed. > debian/copyright > * You don't need to list abc.h, sizes.h, structs.h manually in the first > section since they're already included when you say "Files: *". > * There seems to be some confusion about whether the code is GPL-2 or > GPL-2+. Are you sure what you've put is correct? I see files with no > copyright headers but nothing with "GPL 2 only" in them. > * You don't need to repeat the GPL header lots of times. I'd also be > tempted to merge all the GPL sections together and just have a large > "Copyright:" block. > > debian/rules > * I don't think you need to use autotools-dev in this package (I don't > know a huge amount about this though). > * The clean target doesn't work because you disabled it. This is a > violation of debian policy (4.9) "clean (required): This must undo any > effects that the build and binary targets may have had" > > debian/patches: > * Make sure you send these patches upstream (sorry if you've already > done this - they're not in the new version though). > * hardening.patch: Only LDFLAGS should be passed during the link stage. > Remove your CFLAGS and CPPFLAGS additions. > > Build > There are lots of bad warnings printed when building this > Examples: > * parseabc.c:1701:3: warning: format ‘%s’ expects argument of type ‘char *’, > but argument 3 has type ‘char **’ [-Wformat=] >success = sscanf (s, "%%abc-version %s", &abcversion); /* [SS] 2014-08-11 > */ > > Isn't this a buffer overflow?! > > * toabc.c:1490:8: warning: iteration 7u invokes undefined behavior > [-Waggressive-loop-optimizations] >semi = convertnote[i]; > > It's not too difficult to use these to make abc2midi segfault - please > try and fix them if you have time. > > James > > -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/1414192702.31439.5.ca...@debian.org
Bug#765009: Subject: RFS: abcmidi/20140928-1 [ITA]
On Mon, 2014-10-20 at 15:59 +0200, Ross Gammon wrote: > Hi All, > > I know everyone is busy with the Jessie Release Freeze, but I would be > grateful if somebody could take a look at abcmidi (and sponsor if > happy). Abcmidi has been sitting unloved for a while now (since 2007). > It would be great to get the latest version into Jessie. Hi, Here's a review (I'm not a DD so can't sponsor you however). General * There is a new upstream version (16th October 2014). * #764998 abcmidi: binary-without-manpage usr/bin/abcmatch Obviously you know this, but it would be good if a manpage was added. * The file "/usr/share/doc/abcmidi/VERSION" seems redundant and can probably be removed. debian/copyright * You don't need to list abc.h, sizes.h, structs.h manually in the first section since they're already included when you say "Files: *". * There seems to be some confusion about whether the code is GPL-2 or GPL-2+. Are you sure what you've put is correct? I see files with no copyright headers but nothing with "GPL 2 only" in them. * You don't need to repeat the GPL header lots of times. I'd also be tempted to merge all the GPL sections together and just have a large "Copyright:" block. debian/rules * I don't think you need to use autotools-dev in this package (I don't know a huge amount about this though). * The clean target doesn't work because you disabled it. This is a violation of debian policy (4.9) "clean (required): This must undo any effects that the build and binary targets may have had" debian/patches: * Make sure you send these patches upstream (sorry if you've already done this - they're not in the new version though). * hardening.patch: Only LDFLAGS should be passed during the link stage. Remove your CFLAGS and CPPFLAGS additions. Build There are lots of bad warnings printed when building this Examples: * parseabc.c:1701:3: warning: format ‘%s’ expects argument of type ‘char *’, but argument 3 has type ‘char **’ [-Wformat=] success = sscanf (s, "%%abc-version %s", &abcversion); /* [SS] 2014-08-11 */ Isn't this a buffer overflow?! * toabc.c:1490:8: warning: iteration 7u invokes undefined behavior [-Waggressive-loop-optimizations] semi = convertnote[i]; It's not too difficult to use these to make abc2midi segfault - please try and fix them if you have time. James -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/1413838769.3790.1.ca...@cowgill.org.uk
Bug#765009: Subject: RFS: abcmidi/20140928-1 [ITA]
Hi All, I know everyone is busy with the Jessie Release Freeze, but I would be grateful if somebody could take a look at abcmidi (and sponsor if happy). Abcmidi has been sitting unloved for a while now (since 2007). It would be great to get the latest version into Jessie. This time I am copying in the Debian Multimedia Team to get a wider audience. Although probably not "mainstream" multimedia, it is MIDI! I would be happy to move the package to pkg-multimedia from collab-maint (maybe after the release to avoid unnecessary noise on the list). Regards, Ross On 10/12/2014 11:52 PM, Ross Gammon wrote: > Package: sponsorship-requests > Severity: normal > > Dear mentors, > > I am looking for a sponsor for my package "abcmidi" which I intend to adopt > and maintain on collab-maint. > > * Package name: abcmidi > Version : 20140928-1 > Upstream Author : Seymour Shlien > * URL : http://ifdo.ca/~seymour/runabc/top.html > * License : GPL2+ > Section : sound > > It builds this binary package: > > abcmidi- converter from ABC to MIDI format and back > > To access further information about this package, please visit the following > URL: > > http://mentors.debian.net/package/abcmidi > > > Alternatively, one can download the package with dget using this command: > > dget -x > http://mentors.debian.net/debian/pool/main/a/abcmidi/abcmidi_20140928-1.dsc > > More information about abc notation can be obtained from > http://abcnotation.com/. > > Changes since the last upload: > > * New maintainer (Closes: #540843) > * New upstream release (Closes: #691175) > * Rename abcmidi-yaps to yaps (LP: #525980) > * Handling of lyrics fixed (Closes: #205958) > * Created patch to spelling and hyphens in manpages > * Patched makefile to enable hardening flags > > > Regards, > Ross Gammon > > -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/54451540.2090...@the-gammons.net
Bug#765009: Subject: RFS: abcmidi/20140928-1 [ITA]
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "abcmidi" which I intend to adopt and maintain on collab-maint. * Package name: abcmidi Version : 20140928-1 Upstream Author : Seymour Shlien * URL : http://ifdo.ca/~seymour/runabc/top.html * License : GPL2+ Section : sound It builds this binary package: abcmidi- converter from ABC to MIDI format and back To access further information about this package, please visit the following URL: http://mentors.debian.net/package/abcmidi Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/a/abcmidi/abcmidi_20140928-1.dsc More information about abc notation can be obtained from http://abcnotation.com/. Changes since the last upload: * New maintainer (Closes: #540843) * New upstream release (Closes: #691175) * Rename abcmidi-yaps to yaps (LP: #525980) * Handling of lyrics fixed (Closes: #205958) * Created patch to spelling and hyphens in manpages * Patched makefile to enable hardening flags Regards, Ross Gammon signature.asc Description: OpenPGP digital signature
