Re: Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Gianfranco Costamagna]

Hi, done!

cheers,

G.





Il Lunedì 8 Febbraio 2016 7:02, Dmitry Bogatov  ha scritto:
Hi!

Complexity hit testing. Would you be so kind to upload this version
(just one more changelog entry) to jessie-backports? Since complexity
depends on libopts25, version from testing can't directly be installed
on stable.

http://mentors.debian.net/debian/pool/main/c/complexity/complexity_1.3+dfsg-1~bpo8+1.dsc


-- 
Accept: text/plain, text/x-diff
Accept-Language: eo,en,ru
X-Keep-In-CC: yes
X-Web-Site: sinsekvu.github.io

Re: Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Dmitry Bogatov]

Hi!

Complexity hit testing. Would you be so kind to upload this version
(just one more changelog entry) to jessie-backports? Since complexity
depends on libopts25, version from testing can't directly be installed
on stable.

http://mentors.debian.net/debian/pool/main/c/complexity/complexity_1.3+dfsg-1~bpo8+1.dsc

-- 
Accept: text/plain, text/x-diff
Accept-Language: eo,en,ru
X-Keep-In-CC: yes
X-Web-Site: sinsekvu.github.io


signature.asc
Description: Digital signature

Re: Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Gianfranco Costamagna]

Hi,

>If a package is already in NEW, you could ask ftp-masters to REJECT the 

>package. Then you could upload the package again with the same version.
>
>But it's simpler (both for you and ftp-masters) if you just upload a new 
>Debian release.
>
>Anyway, I see that -1 has been already accepted. No idea what happened 
>to -2...


I asked to remove the -1 and -2, and reuploaded the -1 above (the one currently 
in unstable).

cheers,

Gianfranco

Re: Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Jakub Wilk]

* Dmitry Bogatov , 2016-01-23, 19:20:
the package is already on new queue (1.3+dfsg-1 and 1.3+dfsg-2) do you 
want to ask me to bump the version to dfsg-3 or should I ask ftpmaster 
to reject it?


Why do we need -1,-2,-3 when none of them hit unstable? I am not sure 
what exactly should I do, but I want discard any previous versions and 
upload current 1.3+dfsg-1 for ftp-masters review and to get it into 
unstable.


If a package is already in NEW, you could ask ftp-masters to REJECT the 
package. Then you could upload the package again with the same version.


But it's simpler (both for you and ftp-masters) if you just upload a new 
Debian release.


Anyway, I see that -1 has been already accepted. No idea what happened 
to -2...


--
Jakub Wilk

Re: Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Dmitry Bogatov]

There was some time without movement. I fixed my access to mentors,
here is:

http://mentors.debian.net/debian/pool/main/c/complexity/complexity_1.3+dfsg-1.dsc

I fixed copyright issues (I believe) and some other minor
stuff. Lintian is absolutely happy. Would you be so kind to upload it?

-- 
Accept: text/plain, text/x-diff
Accept-Language: eo,en,ru
X-Keep-In-CC: yes
X-Web-Site: sinsekvu.github.io


signature.asc
Description: Digital signature

Re: Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Dmitry Bogatov]

> >http://mentors.debian.net/debian/pool/main/c/complexity/complexity_1.3+dfsg-1.dsc
> >
> >I fixed copyright issues (I believe) and some other minor
> >stuff. Lintian is absolutely happy. Would you be so kind to upload it?

> the package is already on new queue (1.3+dfsg-1 and 1.3+dfsg-2) do you
> want to ask me to bump the version to dfsg-3 or should I ask ftpmaster
> to reject it?

Why do we need -1,-2,-3 when none of them hit unstable? I am not sure
what exactly should I do, but I want discard any previous versions and
upload current 1.3+dfsg-1 for ftp-masters review and to get it into
unstable.

-- 
Accept: text/plain, text/x-diff
Accept-Language: eo,en,ru
X-Keep-In-CC: yes
X-Web-Site: sinsekvu.github.io


signature.asc
Description: Digital signature

Re: Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Gianfranco Costamagna]

Hi,


>http://mentors.debian.net/debian/pool/main/c/complexity/complexity_1.3+dfsg-1.dsc
>
>I fixed copyright issues (I believe) and some other minor
>stuff. Lintian is absolutely happy. Would you be so kind to upload it?



the package is already on new queue (1.3+dfsg-1 and 1.3+dfsg-2)
do you want to ask me to bump the version to dfsg-3 or should I ask ftpmaster 
to reject it?

cheers,
G.

Re: Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Dmitry Bogatov]

* Gianfranco Costamagna  [2015-12-16 
12:38:28+]
> Pong!
> 
> Cloning your git repo hasn't been an easy task :)

Sorry for it. If I will still expirience problems with mentors.debian,
I would provide shell snippet.

> Built, thanks for your contribution to Debian!
> 
> BTW
> 
> cat debian/complexity.install
> "/usr/share/man/*"
> 
> 
> this belongs to dh_installman, not dh_install.
> please fix it in a future upload if possible.

Will do.
 

-- 
Accept: text/plain, text/x-diff
Accept-Language: eo,en,ru
X-Keep-In-CC: yes
X-Web-Site: sinsekvu.github.io


signature.asc
Description: Digital signature

Re: Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Gianfranco Costamagna]

Pong!

Cloning your git repo hasn't been an easy task :)

Built, thanks for your contribution to Debian!

BTW

cat debian/complexity.install 
"/usr/share/man/*"


this belongs to dh_installman, not dh_install.

please fix it in a future upload if possible.

cheers,

(going to ping ftpmasters now)

G.






Il Mercoledì 16 Dicembre 2015 8:34, Dmitry Bogatov  ha scritto:
* Dmitry Bogatov  [2015-12-07 23:03:23+0300]
> > >I remember, there was another mail, stating opposite opinion. As far as
> > >I know, GNU Make documentation lacks of invariant sections, but it is
> > >still in non-free. But,
> > >
> > >Paul, if you are sure that keeping everything in main is okay and
> > >willing to sponsor, I will gladly revert.
> 
> Okay. I reverted in complexity repository. To me, sbuild is happy.

Ping.




-- 
Accept: text/plain, text/x-diff
Accept-Language: eo,en,ru
X-Keep-In-CC: yes
X-Web-Site: sinsekvu.github.io

Re: Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Gianfranco Costamagna]

Pong!

Cloning your git repo hasn't been an easy task :)

Built, thanks for your contribution to Debian!

BTW

cat debian/complexity.install
"/usr/share/man/*"


this belongs to dh_installman, not dh_install.

please fix it in a future upload if possible.

cheers,

(going to ping ftpmasters now)


(as said on irc, please ask upstream to relicense that file)


G.





Il Mercoledì 16 Dicembre 2015 8:34, Dmitry Bogatov  ha scritto:
* Dmitry Bogatov  [2015-12-07 23:03:23+0300]
> > >I remember, there was another mail, stating opposite opinion. As far as
> > >I know, GNU Make documentation lacks of invariant sections, but it is
> > >still in non-free. But,
> > >
> > >Paul, if you are sure that keeping everything in main is okay and
> > >willing to sponsor, I will gladly revert.
> 
> Okay. I reverted in complexity repository. To me, sbuild is happy.

Ping.




-- 
Accept: text/plain, text/x-diff
Accept-Language: eo,en,ru
X-Keep-In-CC: yes
X-Web-Site: sinsekvu.github.io

Re: Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Dmitry Bogatov]

* Dmitry Bogatov  [2015-12-07 23:03:23+0300]
> > >I remember, there was another mail, stating opposite opinion. As far as
> > >I know, GNU Make documentation lacks of invariant sections, but it is
> > >still in non-free. But,
> > >
> > >Paul, if you are sure that keeping everything in main is okay and
> > >willing to sponsor, I will gladly revert.
> 
> Okay. I reverted in complexity repository. To me, sbuild is happy.

Ping.



-- 
Accept: text/plain, text/x-diff
Accept-Language: eo,en,ru
X-Keep-In-CC: yes
X-Web-Site: sinsekvu.github.io


signature.asc
Description: Digital signature

Re: Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Jakub Wilk]

* Dmitry Bogatov , 2015-12-07, 20:37:
As far as I know, GNU Make documentation lacks of invariant sections, 
but it is still in non-free.


This is confusing, but "invariant section" is not the same as "Invariant 
Section". Perhaps we should have invented a better name, such as 
"unmodifiable section".


The GNU Make Manual doesn't have Invariant Sections, but it does have 
Front-Cover Texts and Back-Cover Texts, which are unmodifiable 
("invariant") sections. Because of this, make-doc is only available in 
non-free.


But complexity documentation is licensed under GFDL "with no Invariant 
Sections, no Front-Cover Texts, and no Back-Cover Texts", so as per the 
GR it meets requirements of DFSG.


--
Jakub Wilk

Re: Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Dmitry Bogatov]

* Paul Wise  [2015-12-07 14:04:57+0800]
> On Mon, Dec 7, 2015 at 12:52 PM, Dmitry Bogatov wrote:
> > * Gianfranco Costamagna [2015-11-18 17:37:28+]
> >> Hi, sure
> >> thanks!
> >
> > Can you please git-clone
> >
> > git://anonscm.debian.org/users/kaction-guest/complexity.git
> > git://anonscm.debian.org/users/kaction-guest/complexity-doc.git
> >
> > Both contains only debian/ and seems that `origtargz -u && sbuild`
> > should suffice.
> 
> Did you both miss these two mails?
> 
> https://lists.debian.org/1447244878.2416.3.ca...@43-1.org
> https://lists.debian.org/msgid-search/20151118215142.ga3...@jwilk.net

I remember, there was another mail, stating opposite opinion. As far as
I know, GNU Make documentation lacks of invariant sections, but it is
still in non-free. But,

Paul, if you are sure that keeping everything in main is okay and
willing to sponsor, I will gladly revert.

-- 
Accept: text/plain, text/x-diff
Accept-Language: eo,en,ru
X-Keep-In-CC: yes
X-Web-Site: sinsekvu.github.io


signature.asc
Description: Digital signature

Re: Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Gianfranco Costamagna]

Hi,



>I remember, there was another mail, stating opposite opinion. As far as
>I know, GNU Make documentation lacks of invariant sections, but it is
>still in non-free. But,
>
>Paul, if you are sure that keeping everything in main is okay and
>willing to sponsor, I will gladly revert.


I think the invariant section is a problem, however IANAL and I don't understand
deeply this issue, so if you want to revert, I'll be happy to sponsor the 
package
and ask ftpmasters to review.

if they reject the package we can still reupload without that part.

(doing the opposite will probably require more work, new binaries, overriding 
of sections, while
this way makes ftpmasters time spent possibly twice but probably once, and I'll 
be sure
to ping them, to avoid them loose time)

so, if you can revert it I'll finish the review and sponsor :)

(I came into this conclusion because nobody complained about the non-free 
section anymore)


cheers,

G.

Re: Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Dmitry Bogatov]

> >I remember, there was another mail, stating opposite opinion. As far as
> >I know, GNU Make documentation lacks of invariant sections, but it is
> >still in non-free. But,
> >
> >Paul, if you are sure that keeping everything in main is okay and
> >willing to sponsor, I will gladly revert.
> 
> 
> I think the invariant section is a problem, however IANAL and I don't 
> understand
> deeply this issue, so if you want to revert, I'll be happy to sponsor the 
> package
> and ask ftpmasters to review.
> 
> if they reject the package we can still reupload without that part.

Okay. I reverted in complexity repository. To me, sbuild is happy.

-- 
Accept: text/plain, text/x-diff
Accept-Language: eo,en,ru
X-Keep-In-CC: yes
X-Web-Site: sinsekvu.github.io


signature.asc
Description: Digital signature

Re: Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Paul Wise]

On Mon, Dec 7, 2015 at 12:52 PM, Dmitry Bogatov wrote:
> * Gianfranco Costamagna [2015-11-18 17:37:28+]
>> Hi, sure
>> thanks!
>
> Can you please git-clone
>
> git://anonscm.debian.org/users/kaction-guest/complexity.git
> git://anonscm.debian.org/users/kaction-guest/complexity-doc.git
>
> Both contains only debian/ and seems that `origtargz -u && sbuild`
> should suffice.

Did you both miss these two mails?

https://lists.debian.org/1447244878.2416.3.ca...@43-1.org
https://lists.debian.org/msgid-search/20151118215142.ga3...@jwilk.net

-- 
bye,
pabs

https://wiki.debian.org/PaulWise

Re: Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Dmitry Bogatov]

* Gianfranco Costamagna  [2015-11-18 
17:37:28+]
> Hi, sure
> thanks!

Can you please git-clone

git://anonscm.debian.org/users/kaction-guest/complexity.git
git://anonscm.debian.org/users/kaction-guest/complexity-doc.git

Both contains only debian/ and seems that `origtargz -u && sbuild`
should suffice.

-- 
Accept: text/plain, text/x-diff
Accept-Language: eo,en,ru
X-Keep-In-CC: yes
X-Web-Site: sinsekvu.github.io


signature.asc
Description: Digital signature

Re: Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Gianfranco Costamagna]

yes, I didn't miss it, but there are too many RFS open, and I was in VAC.

I'll be back when I have the time for this package :)

(hopefully soon)
cheers,

G.





Il Lunedì 7 Dicembre 2015 7:05, Paul Wise  ha scritto:
On Mon, Dec 7, 2015 at 12:52 PM, Dmitry Bogatov wrote:
> * Gianfranco Costamagna [2015-11-18 17:37:28+]

>> Hi, sure
>> thanks!
>
> Can you please git-clone
>
> git://anonscm.debian.org/users/kaction-guest/complexity.git
> git://anonscm.debian.org/users/kaction-guest/complexity-doc.git
>
> Both contains only debian/ and seems that `origtargz -u && sbuild`
> should suffice.

Did you both miss these two mails?

https://lists.debian.org/1447244878.2416.3.ca...@43-1.org
https://lists.debian.org/msgid-search/20151118215142.ga3...@jwilk.net

-- 
bye,
pabs

https://wiki.debian.org/PaulWise

Re: Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Dmitry Bogatov]

* Gianfranco Costamagna  [2015-11-18 
13:41:45+]
> Hi,
> 
> >E: complexity source: section-area-mismatch Package complexity-doc
> 
> 
> So how can we proceed with this one?
> Move to non-free, remove the file and repack?
> 
> I don't think overriding the section for the -doc package will work.

I will make complexity(to main) and complexity-doc(to non-free) source packages.
I will ping you when I am ready, if you don't object.

-- 
Accept: text/plain, text/x-diff
Accept-Language: eo,en,ru
X-Keep-In-CC: yes
X-Web-Site: nanlnhhunqer4xcy.onion


signature.asc
Description: Digital signature

Re: Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Gianfranco Costamagna]

Hi, sure
thanks!

G.




Il Mercoledì 18 Novembre 2015 18:28, Dmitry Bogatov  ha 
scritto:
* Gianfranco Costamagna  [2015-11-18 
13:41:45+]

> Hi,
> 
> >E: complexity source: section-area-mismatch Package complexity-doc
> 
> 
> So how can we proceed with this one?
> Move to non-free, remove the file and repack?
> 
> I don't think overriding the section for the -doc package will work.

I will make complexity(to main) and complexity-doc(to non-free) source packages.
I will ping you when I am ready, if you don't object.

-- 
Accept: text/plain, text/x-diff
Accept-Language: eo,en,ru
X-Keep-In-CC: yes
X-Web-Site: nanlnhhunqer4xcy.onion

Re: Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Gianfranco Costamagna]

Hi,

>E: complexity source: section-area-mismatch Package complexity-doc


So how can we proceed with this one?


Move to non-free, remove the file and repack?

I don't think overriding the section for the -doc package will work.

cheers,

G.

Re: Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Jakub Wilk]

* Gianfranco Costamagna , 2015-11-18, 13:41:

   E: complexity source: section-area-mismatch Package complexity-doc


So how can we proceed with this one?

Move to non-free, remove the file and repack?


As Ansgar correctly noted[0], the license in question is DSFG-free. 
The package can remain wholly in main.



[0] https://lists.debian.org/1447244878.2416.3.ca...@43-1.org

--
Jakub Wilk

Re: Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Dmitry Bogatov]

On 2015-11-11, Jakub Wilk  wrote:
> * Peter Pentchev , 2015-11-11, 11:28:
>>On Wed, Nov 11, 2015 at 11:45:10AM +0300, Dmitry Bogatov wrote:
>>>Well, I moved complexity-doc into 'non-free/doc' (!) section.
>>>
>>>Lintian complains, that I build free and non-free binaries from same 
>>>source package, but separating doc into almost-identical source 
>>>package and keeping them in sync is insane.
>
> It would have been helpful if Dmitry quoted exactly what Lintian said...

E: complexity source: section-area-mismatch Package complexity-doc

-- 
Accept: text/plain, text/x-diff
Accept-Language: eo,en,ru
X-Keep-In-CC: yes
X-Web-Site: nanlnhhunqer4xcy.onion

Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Peter Pentchev]

On Wed, Nov 11, 2015 at 11:45:10AM +0300, Dmitry Bogatov wrote:
> * Gianfranco Costamagna  [2015-11-04 
> 17:38:33+]
> > Hi, according to [1] [2] [3] FDL with the "no invariant" section is not 
> > considered DFSG.
> 
> Well, I moved complexity-doc into 'non-free/doc' (!) section.
> 
> Lintian complains, that I build free and non-free binaries from same
> source package, but separating doc into almost-identical source package
> and keeping them in sync is insane.

(the following is based on my opinion and impressions of how the Debian
archive, mirrors, and autobuilders work; if it is incorrect, corrections
would not merely be appreciated, but also very much welcome)

Well, the problem with this is that if your source package contains
files that are distributed under a non-DFSG license, your source package
may not be distributed in the Debian archive's "main" section.  Thus, it
will not be "visible" to the Debian autobuilders and, even if it does
build binary packages that target the "main" or "contrib" sections,
those packages will never be automatically built and uploaded.

Of course, your packages may still be uploaded manually; I believe that
this is the way the "non-free" section of the archive works (cue remark
about how "non-free" may or may not even be considered a part of
the archive).  Still, I don't think that this is the way that you would
prefer it to happen - every time your package needs to be updated, a
Debian developer with upload access should manually build it for all
the supported architectures... and, of course, this might have to
happen with library transitions, too, most probably leaving your package
broken (uninstallable) until somebody steps in, rebuilds it manually,
and uploads it.

It is certainly ultimately your call as the package maintainer; I just
thought you'd want to be aware of the implications :)

G'luck,
Peter

-- 
Peter Pentchev  r...@ringlet.net r...@freebsd.org p...@storpool.com
PGP key:http://people.FreeBSD.org/~roam/roam.key.asc
Key fingerprint 2EE7 A7A5 17FC 124C F115  C354 651E EFB0 2527 DF13


signature.asc
Description: PGP signature

Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Dmitry Bogatov]

* Gianfranco Costamagna  [2015-11-04 
17:38:33+]
> Hi, according to [1] [2] [3] FDL with the "no invariant" section is not 
> considered DFSG.

Well, I moved complexity-doc into 'non-free/doc' (!) section.

Lintian complains, that I build free and non-free binaries from same
source package, but separating doc into almost-identical source package
and keeping them in sync is insane.

> there is no problem in backporting it, but we prior need to make it dfsg and 
> pass the new queue.
> When the package will enter testing, a backport will be possible (assuming 
> the rdeps are in jessie)

They are, for sure.


-- 
Accept: text/plain, text/x-diff
Accept-Language: eo,en,ru
X-Keep-In-CC: yes
X-Web-Site: nanlnhhunqer4xcy.onion


signature.asc
Description: Digital signature

Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Ansgar Burchardt]

Gianfranco Costamagna wrote:
> Hi, according to [1] [2] [3] FDL with the "no invariant" section is
not considered DFSG.
[...]
> [1] https://wiki.debian.org/DFSGLicenses#GNU_Free_Documentation_Licen
se_.28GFDL.29
> [2] https://wiki.debian.org/qa.debian.org/gfdlinvariant
> 
> [3] https://www.debian.org/vote/2006/vote_001

To quote from the first link:

  "Data licensed under the FDL with no invariant sections are
   considered DFSG-free as of GR 2006-001"

The problem Debian has with the GFDL are invariant sections as they
restrict modification. Having no invariant sections (and no mandatory
back- and frontcover texts) avoids these restrictions thus Debian has
no problem with them.

Ansgar

Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Jakub Wilk]

* Peter Pentchev , 2015-11-11, 11:28:

On Wed, Nov 11, 2015 at 11:45:10AM +0300, Dmitry Bogatov wrote:

Well, I moved complexity-doc into 'non-free/doc' (!) section.

Lintian complains, that I build free and non-free binaries from same 
source package, but separating doc into almost-identical source 
package and keeping them in sync is insane.


It would have been helpful if Dmitry quoted exactly what Lintian said...

(the following is based on my opinion and impressions of how the Debian 
archive, mirrors, and autobuilders work; if it is incorrect, 
corrections would not merely be appreciated, but also very much welcome)


Well, the problem with this is that if your source package contains 
files that are distributed under a non-DFSG license, your source 
package may not be distributed in the Debian archive's "main" section.


This is correct.


Thus, it will not be "visible" to the Debian autobuilders and,


We do have autobuilders for contrib and non-free these days.
See Developer's Reference §5.10.5.

(However, even non-free autobuilders don't have contrib or non-free in 
their sources.list, so you can't build-depend on any such package. See 
bug #719626.)


even if it does build binary packages that target the "main" or 
"contrib" sections, those packages will never be automatically built 
and uploaded.


It is not allowed for a source package in "non-free" to build "main" or 
"contrib" binaries.


--
Jakub Wilk

Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Gianfranco Costamagna]

Hi, according to [1] [2] [3] FDL with the "no invariant" section is not 
considered DFSG.

So the package won't pass the new queue.

there is no problem in backporting it, but we prior need to make it dfsg and 
pass the new queue.

When the package will enter testing, a backport will be possible (assuming the 
rdeps are in jessie)


sorry for my bothering, but this is really a showstopper.

cheers,

G.


[1] 
https://wiki.debian.org/DFSGLicenses#GNU_Free_Documentation_License_.28GFDL.29
[2] https://wiki.debian.org/qa.debian.org/gfdlinvariant

[3] https://www.debian.org/vote/2006/vote_001

Il Mercoledì 4 Novembre 2015 7:09, Dmitry Bogatov  ha scritto:
* Gianfranco Costamagna  [2015-10-12 
12:38:29+0200]

> Hi Dmitry,
> 
> please check the copyrights carefully.
> 
> e.g. some documentation files are released under FDL license (some 1.2
> and some others 1.3)

Upstram maintainer was kind to apply patches and release GNU Complexity
1.3. Unfortunately, after that release problem with FDL versions is
still not fixed. Maintainer claims, that FDL 1.3 text dominates one line
in header and think it not worth trouble to release new version just
because of it. In 1.4, whenever it would be, problem will vanish.

So I beleive, GNU Complexity is ready to enter sid. What should I do to
make it enter backports?

-- 
Accept: text/plain, text/x-diff
Accept-Language: eo,en,ru
X-Keep-In-CC: yes
X-Web-Site: nanlnhhunqer4xcy.onion

Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Dmitry Bogatov]

* Gianfranco Costamagna  [2015-10-12 
12:38:29+0200]
> Hi Dmitry,
> 
> please check the copyrights carefully.
> 
> e.g. some documentation files are released under FDL license (some 1.2
> and some others 1.3)

Upstram maintainer was kind to apply patches and release GNU Complexity
1.3. Unfortunately, after that release problem with FDL versions is
still not fixed. Maintainer claims, that FDL 1.3 text dominates one line
in header and think it not worth trouble to release new version just
because of it. In 1.4, whenever it would be, problem will vanish.

So I beleive, GNU Complexity is ready to enter sid. What should I do to
make it enter backports?

-- 
Accept: text/plain, text/x-diff
Accept-Language: eo,en,ru
X-Keep-In-CC: yes
X-Web-Site: nanlnhhunqer4xcy.onion


signature.asc
Description: Digital signature

Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Gianfranco Costamagna]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Hi Dmitry,

please check the copyrights carefully.

e.g. some documentation files are released under FDL license (some 1.2
and some others 1.3)

This might not be an issue, I leave the deep check to you :)

cheers,

G.
-BEGIN PGP SIGNATURE-
Version: GnuPG v2

iQIcBAEBCAAGBQJWG42lAAoJEPNPCXROn13ZkkkQALqO8ZWxscPOMFle3kBFDRIp
h5PjCH51OOptScITvnYLn8x/gKLPPR3CtEBMyB+dh4EHTqUzAqHro5PgR3OBkXKX
EFP9SNUaetP8ozeCA5l+0tQSfbWvoKwpvir4XZajNFNncAJzUI9qCdx47xr13H3Y
zEFM7vD3Ju015n27Y+ujUHaMQVfOjzapn7sF6voGXPAaN0Z7QIp6Z2UCQkMWZIBz
Sj58SKnN50OMYXFZJdiMJReO+WTKTL4H3rAsJnGNECudXEo+xXVSs07EwnKKQcwh
gv/aY513/NkGLysTO9LA0OvBCC/1bOAr7pHdBC9Bmzu+RTA3K+Pq8UhotKizcnFD
ZM22K7uXk9XDW5OkUcamzwV8nUSZhpq1NvmHc91c1ANCcpaiwH4w45viMuf0oRQT
Tl+6qfYDllBzdOu8lTbnzbnmZVrMq8fWLXZTWe5yegt9tcRK8081z/WmQH5FRQRY
zLmhLCuFit06CMrtNvGfypjNzQNsko12NroflRTsGK6H0dHD4aV5eT82S9s9mVc0
ng7dU3pRx40D+IRuuCEa8F/shEMnrRxsBZofHqGqaJygMereaH1ZCE8etAhTrKG5
YXW81rRMY4vLEAvnBdAMrY65V2qstTOxG5Fja4WDOatXCtWxARXJZ0nJetXq+x8y
Q0JGrPcgHl5Ol9Mtemlt
=WrdF
-END PGP SIGNATURE-

Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Dmitry Bogatov]

I keep getting 500 from mentors, so would you be so kind to take
from /srv/home/users/kaction-guest/public_git/complexity.git?

> > I would suggest using https in all the debian/copyright URLs.
I fixed, but duck(1) complains about gnutls error. No idea, w3m opens
just fine these urls.

> > gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I..   -D_FORTIFY_SOURCE=2  -g
> - -O2 > -Werror=array-bounds -Werror=clobbered
> - -Werror=volatile-register-var > -Werror=implicit-function-declaration
> - -fPIE -fstack-protector-strong > -Wformat -Werror=format-security   -c
> - -o unistd.o unistd.c
> > unistd.c:2:0: warning: "_GL_UNISTD_INLINE" redefined #define
> > _GL_UNISTD_INLINE _GL_EXTERN_INLINE ^ In file included from
> > ../config.h:967:0, from unistd.c:1: ./unistd.h:139:0: note: this is
> > the location of the previous >
> definition
> > # define _GL_UNISTD_INLINE _GL_INLINE ^

Anything with _GL prefix is about gnulib and I would prefer to do not
touch it, unless strictly necessery.

> > ar:
> > 
> > ar cru libgnu.a fd-hook.o unistd.o xsize.o asnprintf.o
> > printf-args.o printf-parse.o vasnprintf.o ar: `u' modifier ignored
> > since `D' is the default (see `U')

Same.

> > $ cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not 
> > find or open any of the paths given.' [src/complexity.c:211]:
> > (error) Memory leak: lines_scoring [src/complexity.c:67]: (error)
> > va_list 'ap' was opened but not
> closed > by va_end().

Fixed.

> Let me know how to do you want to proceed with them, and I'll followup
> with another review.

Yes, please review again.

-- 
Accept: text/plain, text/x-diff
Accept-Language: eo,en,ru
X-Keep-In-CC: yes
X-Web-Site: nanlnhhunqer4xcy.onion


signature.asc
Description: Digital signature

Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Gianfranco Costamagna]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Hi Paul, are you still interested in sponsoring this package?

I did a quick look and it seems good now, however I'm wondering about
some hidden issues...

does this package have any showstopper to you?

cheers,

Gianfranco
-BEGIN PGP SIGNATURE-
Version: GnuPG v2

iQIcBAEBCAAGBQJWDqzKAAoJEPNPCXROn13Ziq4P/A8hXdpRuAz+xvIeJauTgrX8
4fha6fswZhV0UFbCvMesuh2cc5dQntWQLZqVnCB0+T/rIj/yVpN/2AtMwkbAQ013
2ZrRVqYieY/ofR5nMsx6iHVO1nAZW8dMKOzH78nDWj31vLcIX7/PC140CKLuzmtb
w+dJacD3BMN1aA4PmsUFL7tYgb4zYnbr+c8ngCNP7MtXf6vepOeNHRPdAi4v60mm
nEpkFH2XHt9+BufhocWMnlwxTo0rB1R6lbpyuF91CG0S9/LVieNCa6EUSwooJ1aW
FEBszGmRLB6NDO63z1cE+kr5BGnOTGhApd8BJfNQah9nf/AJjnrjQVSBGv/nYpL2
Ch7WDflHClCV6t9rs+nzwU+PnisHf7pWVEkZTtBAjFun4h0YOVRKDmb9XtIS1g/3
htij71DGcakikFkZWKhQd+Be0oQssqRYQjd5ET5hyqWt6exTOQhhDorb78lcjHC/
7qYAV7DC3tTdSNXfIbGHc/cIPKUqHUz+4KVWu6sD9MlPczcY43AQMK/J/Z+opkeF
d32P2M17OOERyZDX5B12DtavJDb5J62afPxVgHG3qt61ixzem27QWl9tXeX0mHdU
xde259T5j7XOsGKX2bm7l8+ZCei1fUCpWPE2Abc5vmuLLTqOHWfMex6PKAKTdGGC
8THFlFRAvUBSU0Ng7Qv5
=WLlo
-END PGP SIGNATURE-

Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Paul Wise]

On Fri, 2015-10-02 at 18:11 +0200, Gianfranco Costamagna wrote:

> Hi Paul, are you still interested in sponsoring this package?

I've been travelling so I haven't had much time for Debian stuff,
including reading mail and reviewing the update to this package.

> I did a quick look and it seems good now, however I'm wondering about
> some hidden issues...


Great, feel free to take over sponsorship :)


> does this package have any showstopper to you?

The only ones I know of are the ones I mentioned in my initial review,
which Dmitry says he has fixed.

If you want to check on those and upload, go ahead :)

-- 
bye,
pabs

https://wiki.debian.org/PaulWise




signature.asc
Description: This is a digitally signed message part

Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Dmitry Bogatov]

* Paul Wise  [2015-10-02 18:16:57+0200]
> > does this package have any showstopper to you?
> 
> The only ones I know of are the ones I mentioned in my initial review,
> which Dmitry says he has fixed.
> 
> If you want to check on those and upload, go ahead :)

Just in case, I am here and ready to respond rather timely.

-- 
Accept: text/plain, text/x-diff
Accept-Language: eo,en,ru
X-Keep-In-CC: yes
X-Web-Site: nanlnhhunqer4xcy.onion


signature.asc
Description: Digital signature

Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Gianfranco Costamagna]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Control: owner -1 !
Control: tags -1 moreinfo

> I would suggest using https in all the debian/copyright URLs.

this needs to be done :)
(there is an http


> gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I..   -D_FORTIFY_SOURCE=2  -g
- -O2 > -Werror=array-bounds -Werror=clobbered
- -Werror=volatile-register-var > -Werror=implicit-function-declaration
- -fPIE -fstack-protector-strong > -Wformat -Werror=format-security   -c
- -o unistd.o unistd.c
> unistd.c:2:0: warning: "_GL_UNISTD_INLINE" redefined #define
> _GL_UNISTD_INLINE _GL_EXTERN_INLINE ^ In file included from
> ../config.h:967:0, from unistd.c:1: ./unistd.h:139:0: note: this is
> the location of the previous >
definition
> # define _GL_UNISTD_INLINE _GL_INLINE ^
> 

still there

> ar:
> 
> ar cru libgnu.a fd-hook.o unistd.o xsize.o asnprintf.o
> printf-args.o printf-parse.o vasnprintf.o ar: `u' modifier ignored
> since `D' is the default (see `U')

still there

> $ cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not 
> find or open any of the paths given.' [src/complexity.c:211]:
> (error) Memory leak: lines_scoring [src/complexity.c:67]: (error)
> va_list 'ap' was opened but not
closed > by va_end().

still there

(something more)

Let me know how to do you want to proceed with them, and I'll followup
with another review.

In my opinion the define can be fixed, as well as the copyright file
and the memory leak.

(I didn't run the checkbashisms, codespell, lacheck, shellcheck,
flawfinder tools, but I presume the errors warnings are still there).

For sure you might consider forwarding typos fixes upstream.

cheers,

Gianfranco

cheers,

Gianfranco
-BEGIN PGP SIGNATURE-
Version: GnuPG v2

iQIcBAEBCAAGBQJWDrcsAAoJEPNPCXROn13Z1JIQAKG7VZjGh8cMJw6YsPTYq1jT
FGrq0jzPhVha0blXS3WRrg5JvMY/4DnpFJb3hOxCg9PIQfnf74HzvGN6qaB4lofR
1Y4I/V0Pl0zgI2ltttSu6aoKsfR8bEWQ5rp6txDQ7UZvfSJO0W5oqUHGbFXb+spF
mQPYSTfoLMhIEMvUx5BX8SuVklk9PLVfgTyV5v03BRNaAd1g+7EaBdC+3C9vPNYp
x501A4eWEg7AQyw6/5+ogyKH49Ss85k75iaG0X8PHlruD6bnMA/V65y2cR/MXqd+
yY/Dryks9IZvjLJuHJQGOo6BnkY8p92cJtLiwUCCbMEq7l7hkL6zBl166VyXnib7
EtkImRTGo4PmXqpg1Ux5ZqNmZr9EwcGy7ci7n/1CQL5NDbwsVRiQpUl/nfMUbBhc
9U4qKysQVUPzK/fcJ98uv2l1CeqHr0iyN6IKtkZjRqEGNNil25uVLLAKjUmPjufX
NksPVrj9UCoYGsMahfW5OteKPpx6VoVLgB1xAjORIQMuZY3rAwBfB1DcIHxVhrI3
ilkZwYL+4gvL1XLc7mVi/PwL/34Yxj0XHp9SmtHTDSbpr+tSfD/8GOpC9wKuieaY
E05G+Kxr2IvScz2LUxzIQ6NTzeAIOTxtyZ9NWbNVb6OQjuvrqSwncf/Adk9Jwo0f
+8yg5diw+Sm1OD6yGGeb
=Sb9O
-END PGP SIGNATURE-

Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Dmitry Bogatov]

Thanks for review. Please, review again and compare with my vision what
is done.

 As this is on my TODO list for check-all-the-things, I'm willing to
 review and sponsor. In exchange for the upload, I will require a patch
 for check-all-the-things to support complexity.
Okay, I will make the patch.

 These issues are blockers for uploading:
 
 doc/gendocs_template says it is licensed under the CC-BY-ND-3.0
 license, which doesn't allow derivatives and is not a free license.
 
 debian/copyright is missing the embedded code copies in lib and m4. I
 don't know if the ftpmasters will require those to be present but I
 would suggest to document them anyway.
Repacked and fixed.

 These issues would be nice to fix:
 
 You might want to use upstream's xz tarballs, they are smaller.
Done.
 
 debian/upstream/signing-key.pgp should be renamed .asc
Done.
 
 Please ask upstream to include doc/mk.sh in the tarball.
In TODO.
 
 Personally I would wrap debian/watch at the space (use a \).
Done.
 
 Please send upstream a patch to not install cx-vs-mc.
In TODO.
 
 I would suggest using https in all the debian/copyright URLs.
Done.
 
 I would suggest running wrap-and-sort -sa
Done.
 
 DH_VERBOSE is not normally turned on in debian/rules.
Done.
 
 tests/complexity.test should use mktemp instead of referencing /tmp
 src/char-types.map has a typo: caracter = character
Not a issue, imho.

 I would suggest using dh-autoreconf instead of autotools-dev.
Done.

 The code in src/ appears to get compiled three times, once in
 dh_auto_build, once in dh_auto_test and once in dh_auto_install.

In TODO to inform upstream.

 The following are generated files and should be removed before
 dh_auto_configure and rebuilt during the build process. Personally I
 would suggest all of them should be removed from the upstream VCS and
 the ones that aren't autotools requirements should be removed from the
 upstream tarballs.
 
 aclocal.m4
 bootstrap
 src/char-types.h
 configure
 config.h.in
 Makefile.in
 */Makefile.in
 lib/Makefile.am
 doc/complexity.info
 doc/gendocs_template
 doc/invoke-complexity.texi

Some of them are gone as result of repack.


 The following are embedded code copies and should be removed before
 dh_auto_configure and copied in from build-dependencies.
 
 lib
 m4
Done.
 You may want to add some upstream metadata:
 
 https://wiki.debian.org/UpstreamMetadata

In TODO.
 $ duck
 E: debian/control: Vcs-Git: 
 git://anonscm.debian.org/users/kaction-guest/complexity.git: ERROR 
 (Certainty:certain)
fatal: '/git/users/kaction-guest/complexity.git' does not appear to be a 
 git repository
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Major issue. Infrastructure problem. Wrote to admins, waiting for response.

 E: debian/control: Homepage: https://gnu.org/software/complexity: ERROR 
 (Certainty:certain)
Curl:56 HTTP:0 Failure when receiving data from the peer 
 gnutls_handshake() warning: The server name sent was not recognized
 
 E: debian/copyright:3: URL: https://gnu.org/software/complexity: ERROR 
 (Certainty:possible)
Curl:56 HTTP:0 Failure when receiving data from the peer 
 gnutls_handshake() warning: The server name sent was not recognized
Done.


-- 
Accept: text/plain, text/x-diff
Accept-Language: eo,en,ru
X-Keep-In-CC: yes


pgp9bThP1Kqy2.pgp
Description: PGP signature

Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Paul Wise]

Control: tags -1 + moreinfo
Control: outlook -1 Blocked by non-free content, missing copyright info

On Sun, 5 Apr 2015 Dmitry Bogatov wrote:

  complexity -  tool for analyzing the complexity of C program functions

As this is on my TODO list for check-all-the-things, I'm willing to
review and sponsor. In exchange for the upload, I will require a patch
for check-all-the-things to support complexity. Please take a look at
the check-all-the-things README and commit or send a patch. 

https://anonscm.debian.org/cgit/collab-maint/check-all-the-things.git

These issues are blockers for uploading:

doc/gendocs_template says it is licensed under the CC-BY-ND-3.0
license, which doesn't allow derivatives and is not a free license.

debian/copyright is missing the embedded code copies in lib and m4. I
don't know if the ftpmasters will require those to be present but I
would suggest to document them anyway.

These issues would be nice to fix:

You might want to use upstream's xz tarballs, they are smaller.

debian/upstream/signing-key.pgp should be renamed .asc

Please ask upstream to include doc/mk.sh in the tarball.

Personally I would wrap debian/watch at the space (use a \).

Please send upstream a patch to not install cx-vs-mc.

I would suggest using https in all the debian/copyright URLs.

I would suggest running wrap-and-sort -sa

DH_VERBOSE is not normally turned on in debian/rules.

tests/complexity.test should use mktemp instead of referencing /tmp

src/char-types.map has a typo: caracter = character

I would suggest using dh-autoreconf instead of autotools-dev.

The code in src/ appears to get compiled three times, once in
dh_auto_build, once in dh_auto_test and once in dh_auto_install.

The following are generated files and should be removed before
dh_auto_configure and rebuilt during the build process. Personally I
would suggest all of them should be removed from the upstream VCS and
the ones that aren't autotools requirements should be removed from the
upstream tarballs.

aclocal.m4
bootstrap
src/char-types.h
configure
config.h.in
Makefile.in
*/Makefile.in
lib/Makefile.am
doc/complexity.info
doc/gendocs_template
doc/invoke-complexity.texi

The following are embedded code copies and should be removed before
dh_auto_configure and copied in from build-dependencies.

lib
m4

You may want to add some upstream metadata:

https://wiki.debian.org/UpstreamMetadata

Automatic checks:

gcc:

gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I..   -D_FORTIFY_SOURCE=2  -g -O2 
-Werror=array-bounds -Werror=clobbered -Werror=volatile-register-var 
-Werror=implicit-function-declaration -fPIE -fstack-protector-strong -Wformat 
-Werror=format-security   -c -o unistd.o unistd.c
unistd.c:2:0: warning: _GL_UNISTD_INLINE redefined
 #define _GL_UNISTD_INLINE _GL_EXTERN_INLINE
 ^
In file included from ../config.h:967:0,
 from unistd.c:1:
./unistd.h:139:0: note: this is the location of the previous definition
 # define _GL_UNISTD_INLINE _GL_INLINE
 ^

ar:

ar cru libgnu.a fd-hook.o unistd.o xsize.o asnprintf.o printf-args.o 
printf-parse.o vasnprintf.o
ar: `u' modifier ignored since `D' is the default (see `U')

check-all-the-things:

The duck gnutls errors can be fixed by using www.gnu.org instead.

$ duck
E: debian/control: Vcs-Git: 
git://anonscm.debian.org/users/kaction-guest/complexity.git: ERROR 
(Certainty:certain)
   fatal: '/git/users/kaction-guest/complexity.git' does not appear to be a git 
repository
   fatal: Could not read from remote repository.
   
   Please make sure you have the correct access rights
   and the repository exists.

E: debian/control: Homepage: https://gnu.org/software/complexity: ERROR 
(Certainty:certain)
   Curl:56 HTTP:0 Failure when receiving data from the peer gnutls_handshake() 
warning: The server name sent was not recognized

E: debian/copyright:3: URL: https://gnu.org/software/complexity: ERROR 
(Certainty:possible)
   Curl:56 HTTP:0 Failure when receiving data from the peer gnutls_handshake() 
warning: The server name sent was not recognized

$ find -empty
./doc/texi-stamp

$ cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not find or open 
any of the paths given.'
[src/complexity.c:211]: (error) Memory leak: lines_scoring
[src/complexity.c:67]: (error) va_list 'ap' was opened but not closed by 
va_end().

$ flawfinder -Q -c .
Flawfinder version 1.31, (C) 2001-2014 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 169
lots of output

$ find -type f -iname '*.sh' -exec checkbashisms {} +
possible bashism in ./doc/mk.sh line 3 ('command' with option other than -p):
ag=`command -v autogen`

$ uscan --download-current-version --destdir .
complexity: Version (1.2) available on remote site:
  https://ftp.gnu.org/gnu/complexity/complexity-1.2.tar.gz
  (local version is 1.2)
gpgv: Signature made Sun 21 Dec 2014 02:06:49 AWST using DSA key ID BFBF0221
gpgv: [don't know]: invalid packet (ctb=2d)
gpgv: keydb_search failed: invalid 

Bug#781952: RFS:complexity/1.2-1 [ITP] -- tool for analyzing the complexity of C program functions

[Andrey Rahmatullin]

Control: tags -1 + moreinfo

On Tue, May 12, 2015 at 12:51:48PM +, Dmitry Bogatov wrote:
 To access futher information about this package, please visit following URL:
 
 http://mentors.debian.net/package/complexity
 
 Alternatively, one can download the package with dget using this command:
 
 dget -x 
 http://mentors.debian.net/debian/pool/main/c/complexity/complexity_1.2-1.dsc
The package doesn't exist on mentors.

-- 
WBR, wRAR


signature.asc
Description: Digital signature