Bug#790412: RFS: circus/0.12.0-1
On 11/09/2015 08:51 AM, David Douard wrote: > On 11/06/2015 04:30 PM, Gianfranco Costamagna wrote: >> Hi, >> > Hi, I've (at last) reuploaded a version of circus (0.12.1) on mentors. I've disabled the tests, as suggested by Gianfranco, in order to have a package. I'll try to figure out how to reenable them properly in a next release. Cheers, David > Hi > > sorry I had no time to spend on this RFS, but yes I'm still interested in > finishing it (I do currently > use circus it on several setups). > > I'll take time this week to respond and fix the packaging. > > cheers, > > David > > >> ping, if you are still interested, please answer and fix the above :) >> (or ask about how to fix it) >> >> otherwise I'll close the RFS and unassign myself, I do not like to >> keep RFS bugs open for too long time, and there is no need to upload >> if you aren't interested anymore :) >> >> cheers, >> >> G. >> >> On Mon, 19 Oct 2015 10:31:25 + (UTC) Gianfranco Costamagna >>wrote: >>> I use pbuilder-dist, and it doesn't work either >> >>> ['sudo', 'HOME=/home/locutus', 'ARCHITECTURE=amd64', >>> 'DISTRIBUTION=sid', 'ARCH=amd64', 'DIST=sid', 'DEB_BUILD_OPTIONS=', >>> 'pbuilder', '--build', '--distribution', 'sid', '--buildresult', >>> '/home/locutus/pbuilder/sid_result', '--basetgz', >>> '/home/locutus/pbuilder/sid-base.tgz', '--logfile', >>> u'/home/locutus/pbuilder/sid_result/circus_0.12.1+dfsg-1_amd64.build', >>> '--mirror', 'http://ftp.debian.org/debian', '--debootstrapopts', >>> '--keyring=/usr/share/keyrings/debian-archive-keyring.gpg', >>> '--aptcache', '/home/locutus/pbuilder/aptcache/debian', >>> '--components', 'main contrib non-free', >>> '/tmp/circus_0.12.1+dfsg-1.dsc'] >> >> >> >>> pbuilder 0.219 from sid/stretch >> >>> cheers, >> >>> G. >> >> >> >> >>> Il Lunedì 19 Ottobre 2015 12:24, Mattia Rizzolo >>> ha scritto: On Mon, Oct 19, 2015 at 10:50:21AM >>> +0200, David Douard wrote: After a quick search, Luca Falavigna pointed me to the fact that debomatic uses a no-network wrapper for sbuild (runs sbuild in an "unshare -n" env) in which the lo device was not up. He uploaded a fix for this a couple of days ago, so I'd like to try a new build from the same source package. >> >>> Well, this afaik is not supported. packages are allowed to use the >>> lo device during the build. In pbuilder we use this wrapper to set >>> it up: >> >>> ``` % cat >>> /usr/lib/pbuilder/pbuilder-unshare-wrapper #!/bin/sh >> >>> die() { echo >&2 E: "$2" returned error code "$1" echo >&2 N: Could >>> not set up the loopback interface. exit 1 } >> >>> if test -x /sbin/ifconfig; then /sbin/ifconfig lo up || die $? >>> ifconfig elif test -x /sbin/ip; then /sbin/ip link set lo up || die >>> $? ip elif test -x /bin/ip; then /bin/ip link set lo up || die $? >>> ip else echo >&2 E: Neither ifconfig nor ip found. echo >&2 N: >>> Could not set up the loopback interface. exit 1 fi >> >>> # having this variable set could cause programs looking for >>> unreachable machines unset http_proxy >> >>> exec "$@" >> >>> >> I'm not sure wether the package must be reuploaded on debomatic or if a rebuild dcut command is enough (since the source package has not been uploaded in the main debian queues for now). >> >>> Gian, can you try build it in pbuilder (which unshare the network >>> by default) and see if it builds there? if it does I'd just blame >>> the debomatic unshare setup :) >> > -- David DOUARD LOGILAB Directeur du département Outils & Systèmes +33 1 45 32 03 12david.dou...@logilab.fr +33 1 83 64 25 26http://www.logilab.fr/id/david.douard Formations - http://www.logilab.fr/formations Développements - http://www.logilab.fr/services Gestion de connaissances - http://www.cubicweb.org/ <> signature.asc Description: OpenPGP digital signature
Bug#790412: RFS: circus/0.12.0-1
On 11/06/2015 04:30 PM, Gianfranco Costamagna wrote: > Hi, > Hi sorry I had no time to spend on this RFS, but yes I'm still interested in finishing it (I do currently use circus it on several setups). I'll take time this week to respond and fix the packaging. cheers, David > ping, if you are still interested, please answer and fix the above :) > (or ask about how to fix it) > > otherwise I'll close the RFS and unassign myself, I do not like to > keep RFS bugs open for too long time, and there is no need to upload > if you aren't interested anymore :) > > cheers, > > G. > > On Mon, 19 Oct 2015 10:31:25 + (UTC) Gianfranco Costamagna >wrote: >> I use pbuilder-dist, and it doesn't work either > >> ['sudo', 'HOME=/home/locutus', 'ARCHITECTURE=amd64', >> 'DISTRIBUTION=sid', 'ARCH=amd64', 'DIST=sid', 'DEB_BUILD_OPTIONS=', >> 'pbuilder', '--build', '--distribution', 'sid', '--buildresult', >> '/home/locutus/pbuilder/sid_result', '--basetgz', >> '/home/locutus/pbuilder/sid-base.tgz', '--logfile', >> u'/home/locutus/pbuilder/sid_result/circus_0.12.1+dfsg-1_amd64.build', >> '--mirror', 'http://ftp.debian.org/debian', '--debootstrapopts', >> '--keyring=/usr/share/keyrings/debian-archive-keyring.gpg', >> '--aptcache', '/home/locutus/pbuilder/aptcache/debian', >> '--components', 'main contrib non-free', >> '/tmp/circus_0.12.1+dfsg-1.dsc'] > > > >> pbuilder 0.219 from sid/stretch > >> cheers, > >> G. > > > > >> Il Lunedì 19 Ottobre 2015 12:24, Mattia Rizzolo >> ha scritto: On Mon, Oct 19, 2015 at 10:50:21AM >> +0200, David Douard wrote: >>> After a quick search, Luca Falavigna pointed me to the fact that >>> debomatic uses a no-network wrapper for sbuild (runs sbuild in an >>> "unshare -n" env) in which the lo device was not up. He uploaded >>> a fix for this a couple of days ago, so I'd like to try a new >>> build from the same source package. > >> Well, this afaik is not supported. packages are allowed to use the >> lo device during the build. In pbuilder we use this wrapper to set >> it up: > >> ``` % cat >> /usr/lib/pbuilder/pbuilder-unshare-wrapper #!/bin/sh > >> die() { echo >&2 E: "$2" returned error code "$1" echo >&2 N: Could >> not set up the loopback interface. exit 1 } > >> if test -x /sbin/ifconfig; then /sbin/ifconfig lo up || die $? >> ifconfig elif test -x /sbin/ip; then /sbin/ip link set lo up || die >> $? ip elif test -x /bin/ip; then /bin/ip link set lo up || die $? >> ip else echo >&2 E: Neither ifconfig nor ip found. echo >&2 N: >> Could not set up the loopback interface. exit 1 fi > >> # having this variable set could cause programs looking for >> unreachable machines unset http_proxy > >> exec "$@" > >> > >>> I'm not sure wether the package must be reuploaded on debomatic >>> or if a rebuild dcut command is enough (since the source package >>> has not been uploaded in the main debian queues for now). > >> Gian, can you try build it in pbuilder (which unshare the network >> by default) and see if it builds there? if it does I'd just blame >> the debomatic unshare setup :) > -- David DOUARD LOGILAB Directeur du département Outils & Systèmes +33 1 45 32 03 12david.dou...@logilab.fr +33 1 83 64 25 26http://www.logilab.fr/id/david.douard Formations - http://www.logilab.fr/formations Développements - http://www.logilab.fr/services Gestion de connaissances - http://www.cubicweb.org/ <> signature.asc Description: OpenPGP digital signature
Bug#790412: RFS: circus/0.12.0-1
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, ping, if you are still interested, please answer and fix the above :) (or ask about how to fix it) otherwise I'll close the RFS and unassign myself, I do not like to keep RFS bugs open for too long time, and there is no need to upload if you aren't interested anymore :) cheers, G. On Mon, 19 Oct 2015 10:31:25 + (UTC) Gianfranco Costamagnawrote: > I use pbuilder-dist, and it doesn't work either > > ['sudo', 'HOME=/home/locutus', 'ARCHITECTURE=amd64', > 'DISTRIBUTION=sid', 'ARCH=amd64', 'DIST=sid', 'DEB_BUILD_OPTIONS=', > 'pbuilder', '--build', '--distribution', 'sid', '--buildresult', > '/home/locutus/pbuilder/sid_result', '--basetgz', > '/home/locutus/pbuilder/sid-base.tgz', '--logfile', > u'/home/locutus/pbuilder/sid_result/circus_0.12.1+dfsg-1_amd64.build', > '--mirror', 'http://ftp.debian.org/debian', '--debootstrapopts', > '--keyring=/usr/share/keyrings/debian-archive-keyring.gpg', > '--aptcache', '/home/locutus/pbuilder/aptcache/debian', > '--components', 'main contrib non-free', > '/tmp/circus_0.12.1+dfsg-1.dsc'] > > > > pbuilder 0.219 from sid/stretch > > cheers, > > G. > > > > > Il Lunedì 19 Ottobre 2015 12:24, Mattia Rizzolo > ha scritto: On Mon, Oct 19, 2015 at 10:50:21AM > +0200, David Douard wrote: >> After a quick search, Luca Falavigna pointed me to the fact that >> debomatic uses a no-network wrapper for sbuild (runs sbuild in an >> "unshare -n" env) in which the lo device was not up. He uploaded >> a fix for this a couple of days ago, so I'd like to try a new >> build from the same source package. > > Well, this afaik is not supported. packages are allowed to use the > lo device during the build. In pbuilder we use this wrapper to set > it up: > > ``` % cat > /usr/lib/pbuilder/pbuilder-unshare-wrapper #!/bin/sh > > die() { echo >&2 E: "$2" returned error code "$1" echo >&2 N: Could > not set up the loopback interface. exit 1 } > > if test -x /sbin/ifconfig; then /sbin/ifconfig lo up || die $? > ifconfig elif test -x /sbin/ip; then /sbin/ip link set lo up || die > $? ip elif test -x /bin/ip; then /bin/ip link set lo up || die $? > ip else echo >&2 E: Neither ifconfig nor ip found. echo >&2 N: > Could not set up the loopback interface. exit 1 fi > > # having this variable set could cause programs looking for > unreachable machines unset http_proxy > > exec "$@" > > > >> I'm not sure wether the package must be reuploaded on debomatic >> or if a rebuild dcut command is enough (since the source package >> has not been uploaded in the main debian queues for now). > > Gian, can you try build it in pbuilder (which unshare the network > by default) and see if it builds there? if it does I'd just blame > the debomatic unshare setup :) -BEGIN PGP SIGNATURE- Version: GnuPG v2 iQIcBAEBCAAGBQJWPMemAAoJEPNPCXROn13Z6uoQAKT/8aDKrSfajHjd9XHrWkHb sKHzVE4zHeJWhychIsabf/fQTHwXV75KCNBxyuEj0wR8UVEGABuyf8pW0LPfCIvV pidkVDqa83nuxHvR/5cOJyhMp3t1KsjXSyoQjeiNY3FwlsMF1sEB1qr3wTXU9utE q4iHlZeALtOSLurJSUFanuqmzh+xyufvKPLAz/6l44jyKsNxOIECcemaaEwZ9vxI H48ra9ZQuiERbVC5qfm0O2OY2IZlhr1xHLLsYIqnzyJ00XwBDd30MJq2Ahf82sAz gY1yqiWA/SmOABjfwgOOdCa3SQ/Z9dOzDY3MaQUjX/BEsQovoClJRgoe0Gz9LS5x miN+0LxEglvklIJSl7dhAETUoSHdIr/wytCMi6ART9azd00BzD2w0TDb3inomMyp 8i2HWiTJ/vkOKi70eNDUTPtLwgMM/Je+PDd/4TzneZf8QAY80TQDzcP4QluUz7qw z0AFJSoLSDZHc/hsljJT5ehlNZ8ERfzuSYS8NuBEPow3N4HmG+MGLtlOtv0wW6qo 8OgVllkFOJq3ZxWcoVCwZwLJWzE4WUv0oJS7vUgkWzk0UyCoEICShvPrMw5lg2Hl jjignATHcvKZekou+fdc+aLhJOlZkUjHKzoVSd+jr3VKaNuv0YQx6s9qnnxpkmer V8iHVE7ZtX/W16TZBjnK =C+kb -END PGP SIGNATURE-
Bug#790412: RFS: circus/0.12.0-1
On 10/15/2015 03:09 PM, Gianfranco Costamagna wrote: > Hi, actually it is *so* easy to debug. Hi > > it builds successfully here too. > Probably somewhere the buildd machines have some restrictions on the ports > you can open on localhost > (or maybe they have services on the ports). > > I think we can just disable the testsuite and live happy, or disable the > tests requiring opening local sockets > (actually local sockets should be allowed to be opened, so you might need to > dig into this issue) After a quick search, Luca Falavigna pointed me to the fact that debomatic uses a no-network wrapper for sbuild (runs sbuild in an "unshare -n" env) in which the lo device was not up. He uploaded a fix for this a couple of days ago, so I'd like to try a new build from the same source package. I'm not sure wether the package must be reuploaded on debomatic or if a rebuild dcut command is enough (since the source package has not been uploaded in the main debian queues for now). Cheers, David > cheers, > > G. > > > > > > Il Giovedì 15 Ottobre 2015 14:32, David Douardha > scritto: > On 10/15/2015 02:18 PM, Gianfranco Costamagna wrote: >> well, it FTBFS on both pbuilder and sbuild environments... >> >> http://debomatic-amd64.debian.net/distribution#unstable/circus/0.12.1+dfsg-1/buildlog >> > > humm, what's problematic is that it BFS nicely with sbuild (in a sid chroot) > on my laptop (jessie), > so it won't be so easy to debug. > > I'll try to figure out what's happening here. > > David > > > >> cheers, >> >> G. >> >> >> >> >> >> Il Giovedì 15 Ottobre 2015 13:48, David Douard ha >> scritto: >> On 10/15/2015 11:42 AM, Gianfranco Costamagna wrote: >>> Control: tags -1 moreinfo >>> >>> So please ping me as soon as you have fixed the above. >> >> Should be ok (I hope) >> >> David >> >> >> >>> >>> cheers, >>> >>> G. >>> >>> >>> >>> >>> Il Giovedì 15 Ottobre 2015 11:11, David Douard ha >>> scritto: >>> On 10/13/2015 07:17 PM, Gianfranco Costamagna wrote: Control: owner -1 ! Hi David quick review: >>> >>> Thanks, >>> 1) control: runtime dependencies: please let python:Depends to its job >>> >>> indeed >>> I see in setup.py install_requires = ['iowait', 'psutil', 'pyzmq>=13.1.0', 'tornado>=3.0'] (also: why some dependencies are not listed here?) >>> >>> some are dependencies for the tests (IIRC), some are optional in circus >>> (imported >>> in a try/except), but I prefer to keep them as Build-Depend to ensure these >>> execution >>> path are tested. In fact, some of them should be added in the Recommends or >>> Suggests section. >>> 2) rules/control: please consider using python3 >>> >>> I do, but one step at a time :-) >>> 3) rules: - why you remove examples from build? >>> >>> because I don't want these in the python package, but only in >>> /usr/share/doc/circus/examples >>> >>> - "make -C docs" I would use $(MAKE) -C docs >>> >>> Ok I'll fix that >>> >>> the other stuff looks good, but I didn't check carefully yet :) (and I didn't try a build) cheers, G. >>> >>> >> >> > > -- David DOUARD LOGILAB Directeur du département Outils & Systèmes +33 1 45 32 03 12david.dou...@logilab.fr +33 1 83 64 25 26http://www.logilab.fr/id/david.douard Formations - http://www.logilab.fr/formations Développements - http://www.logilab.fr/services Gestion de connaissances - http://www.cubicweb.org/ <> signature.asc Description: OpenPGP digital signature
Bug#790412: RFS: circus/0.12.0-1
Hi David, >After a quick search, Luca Falavigna pointed me to the fact that debomatic >uses a no-network wrapper for sbuild >(runs sbuild in an "unshare -n" env) in which the lo device was not up. He >uploaded a fix for this a couple of >days ago, so I'd like to try a new build from the same source package. > >I'm not sure wether the package must be reuploaded on debomatic or if a >rebuild dcut command is enough (since the >source package has not been uploaded in the main debian queues for now). I reuploaded, and the build failed again. Since this might be a problem For Debian and Debian derivatives (e.g. for Ubuntu that builds everything from source), what about disabling the testsuite? cheers, G.
Bug#790412: RFS: circus/0.12.0-1
I use pbuilder-dist, and it doesn't work either ['sudo', 'HOME=/home/locutus', 'ARCHITECTURE=amd64', 'DISTRIBUTION=sid', 'ARCH=amd64', 'DIST=sid', 'DEB_BUILD_OPTIONS=', 'pbuilder', '--build', '--distribution', 'sid', '--buildresult', '/home/locutus/pbuilder/sid_result', '--basetgz', '/home/locutus/pbuilder/sid-base.tgz', '--logfile', u'/home/locutus/pbuilder/sid_result/circus_0.12.1+dfsg-1_amd64.build', '--mirror', 'http://ftp.debian.org/debian', '--debootstrapopts', '--keyring=/usr/share/keyrings/debian-archive-keyring.gpg', '--aptcache', '/home/locutus/pbuilder/aptcache/debian', '--components', 'main contrib non-free', '/tmp/circus_0.12.1+dfsg-1.dsc'] pbuilder 0.219 from sid/stretch cheers, G. Il Lunedì 19 Ottobre 2015 12:24, Mattia Rizzoloha scritto: On Mon, Oct 19, 2015 at 10:50:21AM +0200, David Douard wrote: > After a quick search, Luca Falavigna pointed me to the fact that debomatic > uses a no-network wrapper for sbuild > (runs sbuild in an "unshare -n" env) in which the lo device was not up. He > uploaded a fix for this a couple of > days ago, so I'd like to try a new build from the same source package. Well, this afaik is not supported. packages are allowed to use the lo device during the build. In pbuilder we use this wrapper to set it up: ``` % cat /usr/lib/pbuilder/pbuilder-unshare-wrapper #!/bin/sh die() { echo >&2 E: "$2" returned error code "$1" echo >&2 N: Could not set up the loopback interface. exit 1 } if test -x /sbin/ifconfig; then /sbin/ifconfig lo up || die $? ifconfig elif test -x /sbin/ip; then /sbin/ip link set lo up || die $? ip elif test -x /bin/ip; then /bin/ip link set lo up || die $? ip else echo >&2 E: Neither ifconfig nor ip found. echo >&2 N: Could not set up the loopback interface. exit 1 fi # having this variable set could cause programs looking for unreachable machines unset http_proxy exec "$@" > I'm not sure wether the package must be reuploaded on debomatic or if a > rebuild dcut command is enough (since the > source package has not been uploaded in the main debian queues for now). Gian, can you try build it in pbuilder (which unshare the network by default) and see if it builds there? if it does I'd just blame the debomatic unshare setup :) -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: http://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Bug#790412: RFS: circus/0.12.0-1
On Mon, Oct 19, 2015 at 10:50:21AM +0200, David Douard wrote: > After a quick search, Luca Falavigna pointed me to the fact that debomatic > uses a no-network wrapper for sbuild > (runs sbuild in an "unshare -n" env) in which the lo device was not up. He > uploaded a fix for this a couple of > days ago, so I'd like to try a new build from the same source package. Well, this afaik is not supported. packages are allowed to use the lo device during the build. In pbuilder we use this wrapper to set it up: ``` % cat /usr/lib/pbuilder/pbuilder-unshare-wrapper #!/bin/sh die() { echo >&2 E: "$2" returned error code "$1" echo >&2 N: Could not set up the loopback interface. exit 1 } if test -x /sbin/ifconfig; then /sbin/ifconfig lo up || die $? ifconfig elif test -x /sbin/ip; then /sbin/ip link set lo up || die $? ip elif test -x /bin/ip; then /bin/ip link set lo up || die $? ip else echo >&2 E: Neither ifconfig nor ip found. echo >&2 N: Could not set up the loopback interface. exit 1 fi # having this variable set could cause programs looking for unreachable machines unset http_proxy exec "$@" > I'm not sure wether the package must be reuploaded on debomatic or if a > rebuild dcut command is enough (since the > source package has not been uploaded in the main debian queues for now). Gian, can you try build it in pbuilder (which unshare the network by default) and see if it builds there? if it does I'd just blame the debomatic unshare setup :) -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: http://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature
Bug#790412: RFS: circus/0.12.0-1
well, it FTBFS on both pbuilder and sbuild environments... http://debomatic-amd64.debian.net/distribution#unstable/circus/0.12.1+dfsg-1/buildlog cheers, G. Il Giovedì 15 Ottobre 2015 13:48, David Douardha scritto: On 10/15/2015 11:42 AM, Gianfranco Costamagna wrote: > Control: tags -1 moreinfo > > So please ping me as soon as you have fixed the above. Should be ok (I hope) David > > cheers, > > G. > > > > > Il Giovedì 15 Ottobre 2015 11:11, David Douard ha > scritto: > On 10/13/2015 07:17 PM, Gianfranco Costamagna wrote: >> Control: owner -1 ! >> >> Hi David >> >> quick review: > > Thanks, > >> >> 1) control: runtime dependencies: >> >> please let python:Depends to its job > > indeed > >> I see in setup.py >> install_requires = ['iowait', 'psutil', 'pyzmq>=13.1.0', 'tornado>=3.0'] >> >> >> (also: why some dependencies are not listed here?) > > some are dependencies for the tests (IIRC), some are optional in circus > (imported > in a try/except), but I prefer to keep them as Build-Depend to ensure these > execution > path are tested. In fact, some of them should be added in the Recommends or > Suggests section. > >> >> 2) rules/control: please consider using python3 >> > > I do, but one step at a time :-) > >> >> 3) rules: >> - why you remove examples from build? > > because I don't want these in the python package, but only in > /usr/share/doc/circus/examples > > >> - "make -C docs" I would use $(MAKE) -C docs > > Ok I'll fix that > > >> the other stuff looks good, but I didn't check carefully yet :) >> (and I didn't try a build) >> >> cheers, >> >> G. >> > > -- David DOUARD LOGILAB Directeur du département Outils & Systèmes +33 1 45 32 03 12david.dou...@logilab.fr +33 1 83 64 25 26http://www.logilab.fr/id/david.douard Formations - http://www.logilab.fr/formations Développements - http://www.logilab.fr/services Gestion de connaissances - http://www.cubicweb.org/
Bug#790412: RFS: circus/0.12.0-1
On 10/15/2015 02:18 PM, Gianfranco Costamagna wrote: > well, it FTBFS on both pbuilder and sbuild environments... > > http://debomatic-amd64.debian.net/distribution#unstable/circus/0.12.1+dfsg-1/buildlog > humm, what's problematic is that it BFS nicely with sbuild (in a sid chroot) on my laptop (jessie), so it won't be so easy to debug. I'll try to figure out what's happening here. David > cheers, > > G. > > > > > > Il Giovedì 15 Ottobre 2015 13:48, David Douardha > scritto: > On 10/15/2015 11:42 AM, Gianfranco Costamagna wrote: >> Control: tags -1 moreinfo >> >> So please ping me as soon as you have fixed the above. > > Should be ok (I hope) > > David > > > >> >> cheers, >> >> G. >> >> >> >> >> Il Giovedì 15 Ottobre 2015 11:11, David Douard ha >> scritto: >> On 10/13/2015 07:17 PM, Gianfranco Costamagna wrote: >>> Control: owner -1 ! >>> >>> Hi David >>> >>> quick review: >> >> Thanks, >> >>> >>> 1) control: runtime dependencies: >>> >>> please let python:Depends to its job >> >> indeed >> >>> I see in setup.py >>> install_requires = ['iowait', 'psutil', 'pyzmq>=13.1.0', 'tornado>=3.0'] >>> >>> >>> (also: why some dependencies are not listed here?) >> >> some are dependencies for the tests (IIRC), some are optional in circus >> (imported >> in a try/except), but I prefer to keep them as Build-Depend to ensure these >> execution >> path are tested. In fact, some of them should be added in the Recommends or >> Suggests section. >> >>> >>> 2) rules/control: please consider using python3 >>> >> >> I do, but one step at a time :-) >> >>> >>> 3) rules: >>> - why you remove examples from build? >> >> because I don't want these in the python package, but only in >> /usr/share/doc/circus/examples >> >> >>> - "make -C docs" I would use $(MAKE) -C docs >> >> Ok I'll fix that >> >> >>> the other stuff looks good, but I didn't check carefully yet :) >>> (and I didn't try a build) >>> >>> cheers, >>> >>> G. >>> >> >> > > -- David DOUARD LOGILAB Directeur du département Outils & Systèmes +33 1 45 32 03 12david.dou...@logilab.fr +33 1 83 64 25 26http://www.logilab.fr/id/david.douard Formations - http://www.logilab.fr/formations Développements - http://www.logilab.fr/services Gestion de connaissances - http://www.cubicweb.org/ <> signature.asc Description: OpenPGP digital signature
Bug#790412: RFS: circus/0.12.0-1
On 10/15/2015 11:42 AM, Gianfranco Costamagna wrote: > Control: tags -1 moreinfo > > So please ping me as soon as you have fixed the above. Should be ok (I hope) David > > cheers, > > G. > > > > > Il Giovedì 15 Ottobre 2015 11:11, David Douardha > scritto: > On 10/13/2015 07:17 PM, Gianfranco Costamagna wrote: >> Control: owner -1 ! >> >> Hi David >> >> quick review: > > Thanks, > >> >> 1) control: runtime dependencies: >> >> please let python:Depends to its job > > indeed > >> I see in setup.py >> install_requires = ['iowait', 'psutil', 'pyzmq>=13.1.0', 'tornado>=3.0'] >> >> >> (also: why some dependencies are not listed here?) > > some are dependencies for the tests (IIRC), some are optional in circus > (imported > in a try/except), but I prefer to keep them as Build-Depend to ensure these > execution > path are tested. In fact, some of them should be added in the Recommends or > Suggests section. > >> >> 2) rules/control: please consider using python3 >> > > I do, but one step at a time :-) > >> >> 3) rules: >> - why you remove examples from build? > > because I don't want these in the python package, but only in > /usr/share/doc/circus/examples > > >> - "make -C docs" I would use $(MAKE) -C docs > > Ok I'll fix that > > >> the other stuff looks good, but I didn't check carefully yet :) >> (and I didn't try a build) >> >> cheers, >> >> G. >> > > -- David DOUARD LOGILAB Directeur du département Outils & Systèmes +33 1 45 32 03 12david.dou...@logilab.fr +33 1 83 64 25 26http://www.logilab.fr/id/david.douard Formations - http://www.logilab.fr/formations Développements - http://www.logilab.fr/services Gestion de connaissances - http://www.cubicweb.org/ <> signature.asc Description: OpenPGP digital signature
Bug#790412: RFS: circus/0.12.0-1
Hi, actually it is *so* easy to debug. it builds successfully here too. Probably somewhere the buildd machines have some restrictions on the ports you can open on localhost (or maybe they have services on the ports). I think we can just disable the testsuite and live happy, or disable the tests requiring opening local sockets (actually local sockets should be allowed to be opened, so you might need to dig into this issue) cheers, G. Il Giovedì 15 Ottobre 2015 14:32, David Douardha scritto: On 10/15/2015 02:18 PM, Gianfranco Costamagna wrote: > well, it FTBFS on both pbuilder and sbuild environments... > > http://debomatic-amd64.debian.net/distribution#unstable/circus/0.12.1+dfsg-1/buildlog > humm, what's problematic is that it BFS nicely with sbuild (in a sid chroot) on my laptop (jessie), so it won't be so easy to debug. I'll try to figure out what's happening here. David > cheers, > > G. > > > > > > Il Giovedì 15 Ottobre 2015 13:48, David Douard ha > scritto: > On 10/15/2015 11:42 AM, Gianfranco Costamagna wrote: >> Control: tags -1 moreinfo >> >> So please ping me as soon as you have fixed the above. > > Should be ok (I hope) > > David > > > >> >> cheers, >> >> G. >> >> >> >> >> Il Giovedì 15 Ottobre 2015 11:11, David Douard ha >> scritto: >> On 10/13/2015 07:17 PM, Gianfranco Costamagna wrote: >>> Control: owner -1 ! >>> >>> Hi David >>> >>> quick review: >> >> Thanks, >> >>> >>> 1) control: runtime dependencies: >>> >>> please let python:Depends to its job >> >> indeed >> >>> I see in setup.py >>> install_requires = ['iowait', 'psutil', 'pyzmq>=13.1.0', 'tornado>=3.0'] >>> >>> >>> (also: why some dependencies are not listed here?) >> >> some are dependencies for the tests (IIRC), some are optional in circus >> (imported >> in a try/except), but I prefer to keep them as Build-Depend to ensure these >> execution >> path are tested. In fact, some of them should be added in the Recommends or >> Suggests section. >> >>> >>> 2) rules/control: please consider using python3 >>> >> >> I do, but one step at a time :-) >> >>> >>> 3) rules: >>> - why you remove examples from build? >> >> because I don't want these in the python package, but only in >> /usr/share/doc/circus/examples >> >> >>> - "make -C docs" I would use $(MAKE) -C docs >> >> Ok I'll fix that >> >> >>> the other stuff looks good, but I didn't check carefully yet :) >>> (and I didn't try a build) >>> >>> cheers, >>> >>> G. >>> >> >> > > -- David DOUARD LOGILAB Directeur du département Outils & Systèmes +33 1 45 32 03 12david.dou...@logilab.fr +33 1 83 64 25 26http://www.logilab.fr/id/david.douard Formations - http://www.logilab.fr/formations Développements - http://www.logilab.fr/services Gestion de connaissances - http://www.cubicweb.org/
Re: Bug#790412: RFS: circus/0.12.0-1
On 10/13/2015 07:17 PM, Gianfranco Costamagna wrote: > Control: owner -1 ! > > Hi David > > quick review: Thanks, > > 1) control: runtime dependencies: > > please let python:Depends to its job indeed > I see in setup.py > install_requires = ['iowait', 'psutil', 'pyzmq>=13.1.0', 'tornado>=3.0'] > > > (also: why some dependencies are not listed here?) some are dependencies for the tests (IIRC), some are optional in circus (imported in a try/except), but I prefer to keep them as Build-Depend to ensure these execution path are tested. In fact, some of them should be added in the Recommends or Suggests section. > > 2) rules/control: please consider using python3 > I do, but one step at a time :-) > > 3) rules: > - why you remove examples from build? because I don't want these in the python package, but only in /usr/share/doc/circus/examples > - "make -C docs" I would use $(MAKE) -C docs Ok I'll fix that > the other stuff looks good, but I didn't check carefully yet :) > (and I didn't try a build) > > cheers, > > G. > -- David DOUARD LOGILAB Directeur du département Outils & Systèmes +33 1 45 32 03 12david.dou...@logilab.fr +33 1 83 64 25 26http://www.logilab.fr/id/david.douard Formations - http://www.logilab.fr/formations Développements - http://www.logilab.fr/services Gestion de connaissances - http://www.cubicweb.org/ <> signature.asc Description: OpenPGP digital signature
Bug#790412: RFS: circus/0.12.0-1
Control: tags -1 moreinfo So please ping me as soon as you have fixed the above. cheers, G. Il Giovedì 15 Ottobre 2015 11:11, David Douardha scritto: On 10/13/2015 07:17 PM, Gianfranco Costamagna wrote: > Control: owner -1 ! > > Hi David > > quick review: Thanks, > > 1) control: runtime dependencies: > > please let python:Depends to its job indeed > I see in setup.py > install_requires = ['iowait', 'psutil', 'pyzmq>=13.1.0', 'tornado>=3.0'] > > > (also: why some dependencies are not listed here?) some are dependencies for the tests (IIRC), some are optional in circus (imported in a try/except), but I prefer to keep them as Build-Depend to ensure these execution path are tested. In fact, some of them should be added in the Recommends or Suggests section. > > 2) rules/control: please consider using python3 > I do, but one step at a time :-) > > 3) rules: > - why you remove examples from build? because I don't want these in the python package, but only in /usr/share/doc/circus/examples > - "make -C docs" I would use $(MAKE) -C docs Ok I'll fix that > the other stuff looks good, but I didn't check carefully yet :) > (and I didn't try a build) > > cheers, > > G. > -- David DOUARD LOGILAB Directeur du département Outils & Systèmes +33 1 45 32 03 12david.dou...@logilab.fr +33 1 83 64 25 26http://www.logilab.fr/id/david.douard Formations - http://www.logilab.fr/formations Développements - http://www.logilab.fr/services Gestion de connaissances - http://www.cubicweb.org/
Re: Bug#790412: RFS: circus/0.12.0-1
On 10/15/2015 03:09 PM, Gianfranco Costamagna wrote: > Hi, actually it is *so* easy to debug. > > it builds successfully here too. > Probably somewhere the buildd machines have some restrictions on the ports > you can open on localhost > (or maybe they have services on the ports). > > I think we can just disable the testsuite and live happy, or disable the > tests requiring opening local sockets > (actually local sockets should be allowed to be opened, so you might need to > dig into this issue) > I've already been tempted of doing this a couple of times... I'll see if I find a way not to disbale those tests. David > cheers, > > G. > > > > > > Il Giovedì 15 Ottobre 2015 14:32, David Douardha > scritto: > On 10/15/2015 02:18 PM, Gianfranco Costamagna wrote: >> well, it FTBFS on both pbuilder and sbuild environments... >> >> http://debomatic-amd64.debian.net/distribution#unstable/circus/0.12.1+dfsg-1/buildlog >> > > humm, what's problematic is that it BFS nicely with sbuild (in a sid chroot) > on my laptop (jessie), > so it won't be so easy to debug. > > I'll try to figure out what's happening here. > > David > > > >> cheers, >> >> G. >> >> >> >> >> >> Il Giovedì 15 Ottobre 2015 13:48, David Douard ha >> scritto: >> On 10/15/2015 11:42 AM, Gianfranco Costamagna wrote: >>> Control: tags -1 moreinfo >>> >>> So please ping me as soon as you have fixed the above. >> >> Should be ok (I hope) >> >> David >> >> >> >>> >>> cheers, >>> >>> G. >>> >>> >>> >>> >>> Il Giovedì 15 Ottobre 2015 11:11, David Douard ha >>> scritto: >>> On 10/13/2015 07:17 PM, Gianfranco Costamagna wrote: Control: owner -1 ! Hi David quick review: >>> >>> Thanks, >>> 1) control: runtime dependencies: please let python:Depends to its job >>> >>> indeed >>> I see in setup.py install_requires = ['iowait', 'psutil', 'pyzmq>=13.1.0', 'tornado>=3.0'] (also: why some dependencies are not listed here?) >>> >>> some are dependencies for the tests (IIRC), some are optional in circus >>> (imported >>> in a try/except), but I prefer to keep them as Build-Depend to ensure these >>> execution >>> path are tested. In fact, some of them should be added in the Recommends or >>> Suggests section. >>> 2) rules/control: please consider using python3 >>> >>> I do, but one step at a time :-) >>> 3) rules: - why you remove examples from build? >>> >>> because I don't want these in the python package, but only in >>> /usr/share/doc/circus/examples >>> >>> - "make -C docs" I would use $(MAKE) -C docs >>> >>> Ok I'll fix that >>> >>> the other stuff looks good, but I didn't check carefully yet :) (and I didn't try a build) cheers, G. >>> >>> >> >> > > -- David DOUARD LOGILAB Directeur du département Outils & Systèmes +33 1 45 32 03 12david.dou...@logilab.fr +33 1 83 64 25 26http://www.logilab.fr/id/david.douard Formations - http://www.logilab.fr/formations Développements - http://www.logilab.fr/services Gestion de connaissances - http://www.cubicweb.org/ <> signature.asc Description: OpenPGP digital signature
Bug#790412: RFS: circus/0.12.0-1
Control: owner -1 ! Hi David quick review: 1) control: runtime dependencies: please let python:Depends to its job I see in setup.py install_requires = ['iowait', 'psutil', 'pyzmq>=13.1.0', 'tornado>=3.0'] (also: why some dependencies are not listed here?) 2) rules/control: please consider using python3 3) rules: - why you remove examples from build? - "make -C docs" I would use $(MAKE) -C docs the other stuff looks good, but I didn't check carefully yet :) (and I didn't try a build) cheers, G.
Bug#790412: RFS: circus/0.12.0-1
On 10/07/2015 08:13 PM, Andrey Rahmatullin wrote: > On Tue, Oct 06, 2015 at 03:32:35PM +0200, David Douard wrote: >> Hi Andrey >> >> I've just uploaded a new version of the package (circus_0.12.1+dfsg-1). >> As you can see, I've renamed it to add a +dfsg suffix as you requested. > I: circus source: wildcard-matches-nothing-in-dep5-copyright > circus/test/venv/* (paragraph at line 19) > I: circus source: unused-file-paragraph-in-dep5-copyright paragraph at line 19 > > It's tests, not test. > indeed > Please merge changelog entries into one, as the first one doesn't > correspond to an uploaded package. humm, ok, makes sense. > > Why debian/source/include-binaries contains circus/__init__.pyc? > I don't known, a mistake (unclean directory I guess). Let me check this and reupload a package. -- David DOUARD LOGILAB Directeur du département Outils & Systèmes +33 1 45 32 03 12david.dou...@logilab.fr +33 1 83 64 25 26http://www.logilab.fr/id/david.douard Formations - http://www.logilab.fr/formations Développements - http://www.logilab.fr/services Gestion de connaissances - http://www.cubicweb.org/ <> signature.asc Description: OpenPGP digital signature
Bug#790412: RFS: circus/0.12.0-1
On Tue, Oct 06, 2015 at 03:32:35PM +0200, David Douard wrote: > Hi Andrey > > I've just uploaded a new version of the package (circus_0.12.1+dfsg-1). > As you can see, I've renamed it to add a +dfsg suffix as you requested. I: circus source: wildcard-matches-nothing-in-dep5-copyright circus/test/venv/* (paragraph at line 19) I: circus source: unused-file-paragraph-in-dep5-copyright paragraph at line 19 It's tests, not test. Please merge changelog entries into one, as the first one doesn't correspond to an uploaded package. Why debian/source/include-binaries contains circus/__init__.pyc? -- WBR, wRAR signature.asc Description: PGP signature
Bug#790412: RFS: circus/0.12.0-1
Hi Andrey I've just uploaded a new version of the package (circus_0.12.1+dfsg-1). As you can see, I've renamed it to add a +dfsg suffix as you requested. Cheers, David -- David DOUARD LOGILAB Directeur du département Outils & Systèmes +33 1 45 32 03 12david.dou...@logilab.fr +33 1 83 64 25 26http://www.logilab.fr/id/david.douard Formations - http://www.logilab.fr/formations Développements - http://www.logilab.fr/services Gestion de connaissances - http://www.cubicweb.org/ <> signature.asc Description: OpenPGP digital signature
Bug#790412: RFS: circus/0.12.0-1
On Thu, Jul 09, 2015 at 09:31:18AM +0200, David Douard wrote: Hi Andrey, so what's your opinion? Do you want me to make a 0.12.0+dfsg-1 package or is the already uploaded one is eventually enough? I would change the version for my own package. I'm not sure the dfsg flag really makes sense here since the removed files are not removed for licencing reasons, but mainly because they are useless... If files are removed for other reasons, the accepted practice is to add a +ds suffix. On 07/02/2015 02:34 PM, Julien Cristau wrote: On Thu, Jul 2, 2015 at 15:11:34 +0500, Andrey Rahmatullin wrote: On Thu, Jul 02, 2015 at 09:36:59AM +0200, David Douard wrote: Version : 0.12.0-1 I think the common practice is to bump the version after a ftp-team reject. Yes, but i've discussed this Julien (jcristau) and we thought it was simpler to keep the same version, since I've modified the Files-Excluded field of the debian/copyright (thus the orig tarball). I'm not sure what's the reasoning behind this. If the version was changed to 0.12.0+dfsg-1 then it would be OK. Maybe there is some misunderstanding here? The reasoning is it saves having to add versionmangle options in d/watch, and I didn't think the version number change was necessary as the previous version was never shipped. Cheers, Julien -- WBR, wRAR signature.asc Description: Digital signature
Bug#790412: RFS: circus/0.12.0-1
Hi Andrey, so what's your opinion? Do you want me to make a 0.12.0+dfsg-1 package or is the already uploaded one is eventually enough? I'm not sure the dfsg flag really makes sense here since the removed files are not removed for licencing reasons, but mainly because they are useless... David On 07/02/2015 02:34 PM, Julien Cristau wrote: On Thu, Jul 2, 2015 at 15:11:34 +0500, Andrey Rahmatullin wrote: On Thu, Jul 02, 2015 at 09:36:59AM +0200, David Douard wrote: Version : 0.12.0-1 I think the common practice is to bump the version after a ftp-team reject. Yes, but i've discussed this Julien (jcristau) and we thought it was simpler to keep the same version, since I've modified the Files-Excluded field of the debian/copyright (thus the orig tarball). I'm not sure what's the reasoning behind this. If the version was changed to 0.12.0+dfsg-1 then it would be OK. Maybe there is some misunderstanding here? The reasoning is it saves having to add versionmangle options in d/watch, and I didn't think the version number change was necessary as the previous version was never shipped. Cheers, Julien -- David DOUARD LOGILAB Directeur du département Outils Systèmes +33 1 45 32 03 12david.dou...@logilab.fr +33 1 83 64 25 26http://www.logilab.fr/id/david.douard Formations - http://www.logilab.fr/formations Développements - http://www.logilab.fr/services Gestion de connaissances - http://www.cubicweb.org/ attachment: david_douard.vcf signature.asc Description: OpenPGP digital signature
Bug#790412: RFS: circus/0.12.0-1
On 07/01/2015 07:24 PM, Andrey Rahmatullin wrote: On Mon, Jun 29, 2015 at 11:02:59AM +0200, David Douard wrote: Version : 0.12.0-1 I think the common practice is to bump the version after a ftp-team reject. Yes, but i've discussed this Julien (jcristau) and we thought it was simpler to keep the same version, since I've modified the Files-Excluded field of the debian/copyright (thus the orig tarball). * remove buildout related files from the source package As your orig tarball differs from the upstream repo (and the repo found in Vcs-*) and so from the tarball exported from the release tag by github, you'll need to note that in the upstream version number and provide a way to recreate such tarball, preferably as a get_orig_source d/rules target. I'm not sure I understand this. The orig tarball is built by uscan (from the upstream tarball from github, then modified by mk-origtargz according to the debian/copyright file). Isn't it the correct way to do this? -- David DOUARD LOGILAB Directeur du département Outils Systèmes +33 1 45 32 03 12david.dou...@logilab.fr +33 1 83 64 25 26http://www.logilab.fr/id/david.douard Formations - http://www.logilab.fr/formations Développements - http://www.logilab.fr/services Gestion de connaissances - http://www.cubicweb.org/ attachment: david_douard.vcf signature.asc Description: OpenPGP digital signature
Bug#790412: RFS: circus/0.12.0-1
On Thu, Jul 02, 2015 at 09:36:59AM +0200, David Douard wrote: Version : 0.12.0-1 I think the common practice is to bump the version after a ftp-team reject. Yes, but i've discussed this Julien (jcristau) and we thought it was simpler to keep the same version, since I've modified the Files-Excluded field of the debian/copyright (thus the orig tarball). I'm not sure what's the reasoning behind this. If the version was changed to 0.12.0+dfsg-1 then it would be OK. Maybe there is some misunderstanding here? * remove buildout related files from the source package As your orig tarball differs from the upstream repo (and the repo found in Vcs-*) and so from the tarball exported from the release tag by github, you'll need to note that in the upstream version number and provide a way to recreate such tarball, preferably as a get_orig_source d/rules target. I'm not sure I understand this. The orig tarball is built by uscan (from the upstream tarball from github, then modified by mk-origtargz according to the debian/copyright file). Isn't it the correct way to do this? Ah yes, so you already provide a way to recreate the tarball. Still, the upstream version should be changed. -- WBR, wRAR signature.asc Description: Digital signature
Bug#790412: RFS: circus/0.12.0-1
On Thu, Jul 2, 2015 at 15:11:34 +0500, Andrey Rahmatullin wrote: On Thu, Jul 02, 2015 at 09:36:59AM +0200, David Douard wrote: Version : 0.12.0-1 I think the common practice is to bump the version after a ftp-team reject. Yes, but i've discussed this Julien (jcristau) and we thought it was simpler to keep the same version, since I've modified the Files-Excluded field of the debian/copyright (thus the orig tarball). I'm not sure what's the reasoning behind this. If the version was changed to 0.12.0+dfsg-1 then it would be OK. Maybe there is some misunderstanding here? The reasoning is it saves having to add versionmangle options in d/watch, and I didn't think the version number change was necessary as the previous version was never shipped. Cheers, Julien signature.asc Description: Digital signature
Bug#790412: RFS: circus/0.12.0-1
On Mon, Jun 29, 2015 at 11:02:59AM +0200, David Douard wrote: Version : 0.12.0-1 I think the common practice is to bump the version after a ftp-team reject. * remove buildout related files from the source package As your orig tarball differs from the upstream repo (and the repo found in Vcs-*) and so from the tarball exported from the release tag by github, you'll need to note that in the upstream version number and provide a way to recreate such tarball, preferably as a get_orig_source d/rules target. -- WBR, wRAR signature.asc Description: Digital signature
Bug#790412: RFS: circus/0.12.0-1
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package circus * Package name: circus Version : 0.12.0-1 Upstream Author : Mozilla developers and others * URL : http://github.com/circus-tent/circus * License : Apache-2 Section : admin It builds those binary packages: circus - process socket manager. It can be used to monitor and control To access further information about this package, please visit the following URL: http://mentors.debian.net/package/circus Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/c/circus/circus_0.12.0-1.dsc More information about hello can be obtained from http://www.example.com. Changes since the last upload: * fix the debian/copyright to properly list files generated by pip for tests * remove buildout related files from the source package * spelling in package description, * remove wrong ${shlibs:Depends} from depends, * remove the not (yet) available python-gevent-zeromq package from recommends PS: The previous uploaded version have been rejected due to some of the errors listed above. Regards, David Douard -- David DOUARD LOGILAB Directeur du département Outils Systèmes +33 1 45 32 03 12david.dou...@logilab.fr +33 1 83 64 25 26http://www.logilab.fr/id/david.douard Formations - http://www.logilab.fr/formations Développements - http://www.logilab.fr/services Gestion de connaissances - http://www.cubicweb.org/ attachment: david_douard.vcf signature.asc Description: OpenPGP digital signature