Re: Bug#796828: RFS: xfce4-equake-plugin/1.3.8
+++ Jeroen van Aart [2015-08-27 15:37 -0700]: > On 08/27/2015 01:20 AM, Gianfranco Costamagna wrote: > >3) control/rules file: what about using dh-autoreconf instead of > >autotools-dev? > > Would I have to use dh-autoreconf? I tried it but it causes some > build errors I can't seem to fix. As far as can see it's not a > requirement and things have worked fine using autotools-dev. This page explains why it is a good thing (but also, as you say, not an actual requirement yet): https://wiki.debian.org/Autoreconf It also gives some clues for things to fix if you get errors. So it is good practice for a package to be autoreconfable as that means that it will build on more architectures, and new architectures correctly. But if you cannot easily fix it this is not a reason to delay upload (but you should probably tell upstream that their autofoo is broken/outdated). Wookey -- Principal hats: Linaro, Debian, Wookware, ARM http://wookware.org/
Bug#796828: RFS: xfce4-equake-plugin/1.3.8
On 08/27/2015 01:20 AM, Gianfranco Costamagna wrote: I know how to handle plugins in general, the question was "where I should click?" To add a plugin you right click on the panel and select the "panel -> add new items" option, then choose the panel plugin from the window which pops up. 1) rules file: please remove lines from 2 to 8 2) control file: you didn't run wrap-and-sort :) and debhelper (>= 9) is already fine I fixed those and uploaded it. 3) control/rules file: what about using dh-autoreconf instead of autotools-dev? Would I have to use dh-autoreconf? I tried it but it causes some build errors I can't seem to fix. As far as can see it's not a requirement and things have worked fine using autotools-dev. the other stuff looks really good now, and the package works correctly :) Good to know, thanks. Jeroen
Bug#796828: RFS: xfce4-equake-plugin/1.3.8
Control: owner -1 ! Hi Jeroen, >I am not sure what I could (or should) change with regards to the >package to enable successful install of the whole xfce4 DE plus >dependencies, or the configuration of the xfce session for the login >manager. Wouldn't it be out of the scope of a panel plugin? yes maybe, that was a question, I think people will install your plugin *after* they install xfce, so not needed to make it required >In a 64 bits environment it is installed into >/usr/lib/x86_64-linux-gnu/xfce4/panel-plugins/ when you install it using >the package. > >If compiled from source it will go into /usr/lib/xfce4/panel-plugins/ or >/usr/local/lib/xfce4/panel-plugins/ if you did not specify >"--prefix=/usr" during when running "./configure". > I know how to handle plugins in general, the question was "where I should click?" >In xfce you need to right click the panel and select to add a new item, >the requester that pops up may not always show newly installed plugins >right away. You may have to close it, wait for a bit and try again. It >will notice the presence of new panel-plugins eventually. It is possible >that if installed into /usr/local/... it will not find it. > >Similarly when I installed xfce 4.12 from source into /usr/local to test >equake out in a newer xfce environment the pane plugin requester, when >using the /usr/local installed xfce, would only find the plugin if >installed into /usr/local/... > >I am sure there are ways around it, but I didn't investigate further. I'm used to gnome-shell, where the interface is (in my opinion) more user friendly. e.g. you can install from extensions.gnome.org, and they appear automagically on the desktop environment, or use apt-get install gnome-shell-extension-name and the extension appears automatically at the end of the apt run (I didn't try recently but this was my experience with gnome). xfce seems a little bit more manual on installation, fine. >I think I have taken care of all these in the package I just uploaded to >mentors. > >Let me know if anything is still wrong. > >Thanks for the suggestions, I would have sponsored right away, but I guess some refinements might be good. 1) rules file: please remove lines from 2 to 8 2) control file: you didn't run wrap-and-sort :) and debhelper (>= 9) is already fine 3) control/rules file: what about using dh-autoreconf instead of autotools-dev? the other stuff looks really good now, and the package works correctly :) cheers, G.
Bug#796828: RFS: xfce4-equake-plugin/1.3.8
On 08/26/2015 01:40 AM, Gianfranco Costamagna wrote: much, much better! still a warning in source build-depends: libglib2.0-dev, libglib2.0-dev in source build-depends: libpango1.0-dev, libpango1.0-dev and a missing build dependency (intltool is needed, in a clean environment it doesn't configure otherwise). > watch file has comments that needs to be stripped > and please enable the VCS fields, or drop the comments (I would prefer the former). I think I have taken care of all these in the package I just uploaded to mentors. Let me know if anything is still wrong. Thanks for the suggestions, Jeroen
Bug#796828: RFS: xfce4-equake-plugin/1.3.8
On 08/26/2015 01:40 AM, Gianfranco Costamagna wrote: (I'll take care of warnings related to the package soon) Some questions: I installed it, and it installed many xfce dependencies on my system. The problem is that when I rebooted xfce isn't shown at the login screen. I had to manually do an apt-get install xfce4 to have it (and install some more stuff). Well, is that an use-case you want to take care of? I am not sure what I could (or should) change with regards to the package to enable successful install of the whole xfce4 DE plus dependencies, or the configuration of the xfce session for the login manager. Wouldn't it be out of the scope of a panel plugin? that said, I installed xfce4, rebooted. Where and how can I use your package? I don't see it anywhere In a 64 bits environment it is installed into /usr/lib/x86_64-linux-gnu/xfce4/panel-plugins/ when you install it using the package. If compiled from source it will go into /usr/lib/xfce4/panel-plugins/ or /usr/local/lib/xfce4/panel-plugins/ if you did not specify "--prefix=/usr" during when running "./configure". In xfce you need to right click the panel and select to add a new item, the requester that pops up may not always show newly installed plugins right away. You may have to close it, wait for a bit and try again. It will notice the presence of new panel-plugins eventually. It is possible that if installed into /usr/local/... it will not find it. Similarly when I installed xfce 4.12 from source into /usr/local to test equake out in a newer xfce environment the pane plugin requester, when using the /usr/local installed xfce, would only find the plugin if installed into /usr/local/... I am sure there are ways around it, but I didn't investigate further. Greetings, Jeroen
Bug#796828: RFS: xfce4-equake-plugin/1.3.8
Another little review: running wrap-and-sort might help you in spotting duplicated dependencies in the control file, and makes it look better. watch file has comments that needs to be stripped https://lintian.debian.org/tags/debian-watch-contains-dh_make-template.html and please enable the VCS fields, or drop the comments (I would prefer the former). cheers, G.
Bug#796828: RFS: xfce4-equake-plugin/1.3.8
Hi Jeroen, >Thanks for the comments. I think I have fixed most or all issues you >mentioned. I uploaded a new version and there were no warnings this >time. However please let me know if anything is still wrong or missing. >Version now is 1.3.8-1. much, much better! still a warning in source build-depends: libglib2.0-dev, libglib2.0-dev in source build-depends: libpango1.0-dev, libpango1.0-dev and a missing build dependency (intltool is needed, in a clean environment it doesn't configure otherwise). Some questions: I installed it, and it installed many xfce dependencies on my system. The problem is that when I rebooted xfce isn't shown at the login screen. I had to manually do an apt-get install xfce4 to have it (and install some more stuff). Well, is that an use-case you want to take care of? that said, I installed xfce4, rebooted. Where and how can I use your package? I don't see it anywhere NOTE: I never used xfce, so please forgive my dumbness (and my lazyness to look by myself about how to install it) cheers! G.
Bug#796828: RFS: xfce4-equake-plugin/1.3.8
On 08/25/2015 03:06 AM, Gianfranco Costamagna wrote: Hi Jeroen, the package right now is really not suitable for unstable You can see the lintian warnings errors on the mentors package page. Can you please fix them? also the changelog should mention "Initial Release: Closes #WNPPBUG) and the target shouldn't be "UNRELEASED" note, many lintian stuff is fixed by using a Debian revision, such as 1.3.8-1 in changelog, and almost all the others are really easy to fix. e.g. you don't have the copyright file mentioning the source tree. You don't have a watch file (please add it if possible) and the control file has some issues. Thanks for the comments. I think I have fixed most or all issues you mentioned. I uploaded a new version and there were no warnings this time. However please let me know if anything is still wrong or missing. Version now is 1.3.8-1. Greetings, Jeroen van Aart
Bug#796828: RFS: xfce4-equake-plugin/1.3.8
Hi Jeroen, the package right now is really not suitable for unstable You can see the lintian warnings errors on the mentors package page. Can you please fix them? also the changelog should mention "Initial Release: Closes #WNPPBUG) and the target shouldn't be "UNRELEASED" note, many lintian stuff is fixed by using a Debian revision, such as 1.3.8-1 in changelog, and almost all the others are really easy to fix. e.g. you don't have the copyright file mentioning the source tree. You don't have a watch file (please add it if possible) and the control file has some issues. cheers, G.
Bug#796828: RFS: xfce4-equake-plugin/1.3.8
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package "xfce4-equake-plugin" * Package name: xfce4-equake-plugin Version : 1.3.8 Upstream Author : Jeroen van Aart andr...@e-quake.org * URL : http://www.e-quake.org * License : GPL Section : xfce It builds those binary packages: xfce4-equake-plugin - Xfce panel plugin which monitors earthquakes To access further information about this package, please visit the following URL: http://mentors.debian.net/package/xfce4-equake-plugin Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/x/xfce4-equake-plugin/xfce4-equake-plugin_1.3.8.dsc More information about hello can be obtained from http://www.e-quake.org or https://sourceforge.net/projects/equake/ Changes since the last upload: * Closes: 728691 * Moved to bing maps for the detailed map display, the USGS map display remains unchanged Thank you, Jeroen van Aart
