Bug#827082: RFS: libredjackipset/1.1.1+20150311-1 [ITP] -- C library to store sets/maps of IP address

[Gianfranco Costamagna]

Hi,

>I think you build on ubuntu, so without "--builddirectory stuff" the
>build directory is
>build-*/
>When I tested in Debian, the build directory is obj-*/
>That's why I insist keeping "--builddirectory stuff" to make same
>install file for both Debian and Ubuntu.


nope, Ubuntu calls it obj-*
for some reasons the package was built, but empty.

So, just changing to obj-* is fine (tested on unstable/yakkety)

Mine was just a stupid typo, and the package was building fine, so I didn't
pay attention to the built deb file.
dpkg -c of it is correct now.

>Already posted to https://github.com/redjack/ipset/issues/41
>But I don't think there will be a clear reply.


sad, lets hope for the best

somebody accepted my pull request
https://github.com/redjack/ipset

so, whoever has write access is still around

>I think the upstream (the original author and redjack) know what we're
>doing here, and if they aren't against here, we can just upload.


seems an acceptable solution

>Explained before you asked me. No reply yet.


yep

>Thanks for your patch, applied well.

wonderful


>Applied.

ok

>Thanks for your suggestion!

lets hope a little more for upstream, and then I guess we are good.

G.

Bug#827082: RFS: libredjackipset/1.1.1+20150311-1 [ITP] -- C library to store sets/maps of IP address

[Roger Shimizu]

Sorry, the subject of this email thread should be changed to:
Re: Bug#827082: RFS: libcorkipset/1.1.1+20150311-1 [ITP] -- C library
to store sets/maps of IP address
 

It was not because I want to keep the shape of the thread :-P

Bug#827082: RFS: libredjackipset/1.1.1+20150311-1 [ITP] -- C library to store sets/maps of IP address

[Roger Shimizu]

[CC upstream]
[Douglas & John are original author of this library, and Greg
currently has write permission to git repo on github]

Dear G,

Thanks for your time to review again!

On Thu, Jun 23, 2016 at 1:00 AM, Gianfranco Costamagna
 wrote:
> Hi Roger
>
>>> cat debian/libcorkipset-doc.docs
>
>>> build-*/docs/html
>>
>>Debian builds obj- by default.
>>So it seems to specify "--builddirectory=build" safe for both debian and 
>>ubuntu.
>
>
> yes, but useless...
> maybe you didn't get completely the hint, but my guess was:
>
> remove the --builddirectory stuff
> and change
>
> build/docs/html
>
> to
> build-*/docs/html
>
> probably this sounds stupid/nitpick to you, but allows
> people to easily cross-compile stuff, or to compile the library for
> both amd64 and i386 without having to choose one or the other.
> that triplet is trivial, and makes less confusion to porters
> or even developer, who might want to build it on their own laptop
> and use on different architectures.
>
>
> (note: this isn't a blocker)

I think you build on ubuntu, so without "--builddirectory stuff" the
build directory is
build-*/
When I tested in Debian, the build directory is obj-*/
That's why I insist keeping "--builddirectory stuff" to make same
install file for both Debian and Ubuntu.

>>Yes, upstream just don't like calling it libredjackipset.
>>They seems fine with libcorkipset, but proposed another option: libipaddrset
>
> I'll wait for them make a decision then

Already posted to https://github.com/redjack/ipset/issues/41
But I don't think there will be a clear reply.

> so, please consider applying my above fixes, and ask me to 
> sponsor
> when upstream releases a new fixed renamed tarball
> (this should even avoid your dh_install override if I'm correctly 
> understanding it)

The original author (in CC list) left redjack, so now they don't have
write access to that repo, and cannot release a new version with new
name.

I think the upstream (the original author and redjack) know what we're
doing here, and if they aren't against here, we can just upload.


>>I don't like the latter one because the header will be installed to
>>/usr/include/libipaddrset/ipset.h
>>and user need to "#include "
>>
>>I think "#include " makes more sense.
>
>
> just explain that upstream :)
>
> I honestly don't care too much, but I want to use the name that upstream 
> choose
> to avoid overcomplicate things in the long run

Explained before you asked me. No reply yet.

>>"LIB_SUFFIX" is added to patch.
>
>
> bad me, it didn't work :(
> the patch wasn't correct, because the variable gets overridden anyway on the 
> following line.
>
> I tweaked the patch, to do something like
> +if(NOT CMAKE_INSTALL_LIBDIR)
> +set(CMAKE_INSTALL_LIBDIR lib CACHE STRING
> + "The base name of the installation directory for libraries")
> +endif(NOT CMAKE_INSTALL_LIBDIR)
>
>
> otherwise no matter who sets it, it gets defaulted to what upstream thinks it 
> is better for everybody.

Thanks for your patch, applied well.


> BTW I can't run dpkg-buildpackage twice, because a "RELEASE-VERSION" file is 
> added to the source
> tree
>
> echo RELEASE-VERSION > debian/clean might just fix that

Applied.
Thanks for your suggestion!

Cheers,
-- 
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 4096R/6C6ACD6417B3ACB1

Bug#827082: RFS: libredjackipset/1.1.1+20150311-1 [ITP] -- C library to store sets/maps of IP address

[Gianfranco Costamagna]

Hi Roger

>> cat debian/libcorkipset-doc.docs

>> build-*/docs/html
>
>Debian builds obj- by default.
>So it seems to specify "--builddirectory=build" safe for both debian and 
>ubuntu.


yes, but useless...
maybe you didn't get completely the hint, but my guess was:

remove the --builddirectory stuff
and change 

build/docs/html

to
build-*/docs/html

probably this sounds stupid/nitpick to you, but allows
people to easily cross-compile stuff, or to compile the library for
both amd64 and i386 without having to choose one or the other.
that triplet is trivial, and makes less confusion to porters
or even developer, who might want to build it on their own laptop
and use on different architectures.


(note: this isn't a blocker)

>Yes, upstream just don't like calling it libredjackipset.
>They seems fine with libcorkipset, but proposed another option: libipaddrset


I'll wait for them make a decision then

>I don't like the latter one because the header will be installed to
>/usr/include/libipaddrset/ipset.h
>and user need to "#include "
>
>I think "#include " makes more sense.


just explain that upstream :)

I honestly don't care too much, but I want to use the name that upstream choose
to avoid overcomplicate things in the long run


>"LIB_SUFFIX" is added to patch.


bad me, it didn't work :(
the patch wasn't correct, because the variable gets overridden anyway on the 
following line.

I tweaked the patch, to do something like
+if(NOT CMAKE_INSTALL_LIBDIR)
+set(CMAKE_INSTALL_LIBDIR lib CACHE STRING
+ "The base name of the installation directory for libraries")
+endif(NOT CMAKE_INSTALL_LIBDIR)


otherwise no matter who sets it, it gets defaulted to what upstream thinks it 
is better for everybody.


BTW I can't run dpkg-buildpackage twice, because a "RELEASE-VERSION" file is 
added to the source
tree

echo RELEASE-VERSION > debian/clean might just fix that

so, please consider applying my above fixes, and ask me to sponsor
when upstream releases a new fixed renamed tarball
(this should even avoid your dh_install override if I'm correctly understanding 
it)

GianfrancoFrom: Roger Shimizu 
Date: Sat, 11 Jun 2016 23:37:44 +0900
Subject: add library multi-arch support

Followed the instruction:
  https://wiki.debian.org/Multiarch/Implementation#CMake
---
 CMakeLists.txt | 4 +++-
 include/CMakeLists.txt | 2 +-
 src/ipset.pc.in| 4 ++--
 3 files changed, 6 insertions(+), 4 deletions(-)

--- libcorkipset-1.1.1+20150311.orig/CMakeLists.txt
+++ libcorkipset-1.1.1+20150311/CMakeLists.txt
@@ -78,8 +78,12 @@ if(NOT CMAKE_BUILD_TYPE)
 FORCE)
 endif(NOT CMAKE_BUILD_TYPE)
 
-set(CMAKE_INSTALL_LIBDIR lib CACHE STRING
-"The base name of the installation directory for libraries")
+include(GNUInstallDirs)
+
+if(NOT CMAKE_INSTALL_LIBDIR)
+set(CMAKE_INSTALL_LIBDIR lib CACHE STRING
+ "The base name of the installation directory for libraries")
+endif(NOT CMAKE_INSTALL_LIBDIR)
 
 if(CMAKE_C_COMPILER_ID STREQUAL "GNU")
 add_definitions(-Wall -Werror)
diff --git a/include/CMakeLists.txt b/include/CMakeLists.txt
index d1e4a7d..097b775 100644
--- a/include/CMakeLists.txt
+++ b/include/CMakeLists.txt
@@ -8,5 +8,5 @@
 # --
 
 install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/
-DESTINATION include
+DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}"
 FILES_MATCHING PATTERN "*.h")
diff --git a/src/ipset.pc.in b/src/ipset.pc.in
index 47a6637..0f8fd84 100644
--- a/src/ipset.pc.in
+++ b/src/ipset.pc.in
@@ -1,7 +1,7 @@
 prefix=@prefix@
 exec_prefix=${prefix}
-libdir=${exec_prefix}/lib
-includedir=${prefix}/include
+libdir=${exec_prefix}/@CMAKE_INSTALL_LIBDIR@
+includedir=${prefix}/@CMAKE_INSTALL_INCLUDEDIR@
 sharedir=${prefix}/share
 sphinxdir=${sharedir}/doc/libcorkipset-doc/html
 

Bug#827082: RFS: libredjackipset/1.1.1+20150311-1 [ITP] -- C library to store sets/maps of IP address

[Roger Shimizu]

Dear G,

Thanks for your review!
I updated the package.

On Wed, Jun 22, 2016 at 1:28 AM, Gianfranco Costamagna
 wrote:
>>So I used the same way in libcork to generate docs.
>>Actually the upstream was during the transition from sphinx to pandoc.
>>They removed sphinx setting, added pandoc setting, but didn't remove
>>sphinx docs.
>>So I patched back sphinx setting, just works.
>>
>>(docs from upstream just poor, even I wrote a patch to add index page)
>
>
> I was already ok with the patch, just adding some Description makes the
> review easier ;)

Thanks!
My additional description already added since previous update.

>>After reading your comment for three time, now I understand it.
>>I put it under dh_install as you recommend.
>>Now it's rebuildable.
>
> :)
>
>>Without "--builddirectory=build", the docs will be built under
>>/docs/
>>This make install file hard to write.
>>So here I keep as it was.
>
> mmm strange...
> this is what I have in the docs file
> cat debian/libcorkipset-doc.docs
> build-*/docs/html

Debian builds obj- by default.
So it seems to specify "--builddirectory=build" safe for both debian and ubuntu.

>>Since the most authors quit redjack, and they're almost not active,
>
>>I consider it should be called libcorkipset.
>
> I see activity upstream, lets wait for the rename to be effective then!

Yes, upstream just don't like calling it libredjackipset.
They seems fine with libcorkipset, but proposed another option: libipaddrset

I don't like the latter one because the header will be installed to
/usr/include/libipaddrset/ipset.h
and user need to "#include "

I think "#include " makes more sense.

>>> "set(CMAKE_INSTALL_LIBDIR lib${LIB_SUFFIX} CACHE STRING"
>>> note the LIB_SUFFIX
>>>
>>> and then the install files can change from
>>> usr/lib/lib*.so usr/lib/${DEB_HOST_MULTIARCH}
>>> to
>>> usr/lib/*/*.so
>>> and similar for others
>>
>>Yes, moving "include(GNUInstallDirs)" makes dh-exec useless.
>>My mistake forced me to introduced this complex. Sorry about that.
>
>
> the missing LIB_SUFFIX makes it FTBFS on Ubuntu, where cmake has a little
> different implementation.
>
> (and a non-defined variable is just a no-op in Debian)

"LIB_SUFFIX" is added to patch.

Takes you time and thanks again!

Cheers,
-- 
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 4096R/6C6ACD6417B3ACB1

Bug#827082: RFS: libredjackipset/1.1.1+20150311-1 [ITP] -- C library to store sets/maps of IP address

[Gianfranco Costamagna]

Hi Roger,

>Control: retitle -1 RFS: libcorkipset/1.1.1+20150311-1 [ITP] -- C
>library to store sets/maps of IP address


thanks for that!
>I think you didn't review since you did last time, and I did some
>changes based on some changes in previous post, so here I *rewrite*
>the previous post.


thanks
>Fixed.
>Fixed.


ok

>This convinced me that this library can be packaged, too.


:)
>Yes, I used python3-cram in libcork, but this time it just doesn't work.
>Without my patch, python-cram just report "no test" error.
>I guess upstream didn't finish the test case of cram.
>So I removed it.


ok


>upstream's docs/CMakeLists.txt just output nothing.
>You can see "set(MAN_PAGES)", the target is empty!


lol ok :)
>So I used the same way in libcork to generate docs.
>Actually the upstream was during the transition from sphinx to pandoc.
>They removed sphinx setting, added pandoc setting, but didn't remove
>sphinx docs.
>So I patched back sphinx setting, just works.
>
>(docs from upstream just poor, even I wrote a patch to add index page)


I was already ok with the patch, just adding some Description makes the
review easier ;)


>After reading your comment for three time, now I understand it.
>I put it under dh_install as you recommend.
>Now it's rebuildable.


:)

>Without "--builddirectory=build", the docs will be built under
>/docs/
>This make install file hard to write.
>So here I keep as it was.


mmm strange...
this is what I have in the docs file
cat debian/libcorkipset-doc.docs 
build-*/docs/html


:)

>Removed.
>Thanks for your suggestion!


wonderful! you are welcome!
>Since the most authors quit redjack, and they're almost not active,

>I consider it should be called libcorkipset.

I see activity upstream, lets wait for the rename to be effective then!
>Fixed.


ok

>> "set(CMAKE_INSTALL_LIBDIR lib${LIB_SUFFIX} CACHE STRING"
>> note the LIB_SUFFIX
>>
>> and then the install files can change from
>> usr/lib/lib*.so usr/lib/${DEB_HOST_MULTIARCH}
>> to
>> usr/lib/*/*.so
>> and similar for others
>
>Yes, moving "include(GNUInstallDirs)" makes dh-exec useless.
>My mistake forced me to introduced this complex. Sorry about that.


the missing LIB_SUFFIX makes it FTBFS on Ubuntu, where cmake has a little
different implementation.

(and a non-defined variable is just a no-op in Debian)

>Tried, just added a lintian warning.
>Should be fixed when debhelper 10 released.
>So I keep as it is.


yes, thanks!

(BTW compat 10 works great)

Gianfranco

Bug#827082: RFS: libredjackipset/1.1.1+20150311-1 [ITP] -- C library to store sets/maps of IP address

[Roger Shimizu]

Control: retitle -1 RFS: libcorkipset/1.1.1+20150311-1 [ITP] -- C
library to store sets/maps of IP address

Dear G,

I think you didn't review since you did last time, and I did some
changes based on some changes in previous post, so here I *rewrite*
the previous post.

On Mon, Jun 20, 2016 at 10:03 PM, Gianfranco Costamagna
 wrote:
> control: owner -1 !
> control: tags -1 moreinfo
>
> Hi, lets see
>
> 1) control: why the -dev package is not multiarch?
> sounds like it is multiarch ready to me
> (I didn't check but include/* seems to have the same md5sum on different archs

Yes, it's multi-arch, just forgot to mark it in d/control.
Fixed.

> 2) the dev package should suggest the doc one

Fixed.

> 3) d/p/0002-fix-build-with-static-libcheck-library.patch
>
> I can't complain here, I seem to know the author of that patch :p

Thanks for your great help!
This convinced me that this library can be packaged, too.

> 3) d/p/0004-remove-test-of-python-cram.patch
>
> why? python-cram is available on Debian

Yes, I used python3-cram in libcork, but this time it just doesn't work.
Without my patch, python-cram just report "no test" error.
I guess upstream didn't finish the test case of cram.
So I removed it.

> 4) d/p/0007-*
> why? please be more verbose on patches, otherwise I find difficult to 
> understand why you are using sphinx instead
> of pandoc to build documentation

upstream's docs/CMakeLists.txt just output nothing.
You can see "set(MAN_PAGES)", the target is empty!

So I used the same way in libcork to generate docs.
Actually the upstream was during the transition from sphinx to pandoc.
They removed sphinx setting, added pandoc setting, but didn't remove
sphinx docs.
So I patched back sphinx setting, just works.

(docs from upstream just poor, even I wrote a patch to add index page)

> 5) rules:
> I don't like hacks
> and your sed makes the package non-rebuildable.
>
> maybe overriding the
>
> dh_install target, and acting under debian/libfoo-dev/usr/include
>
> is a "better" way (also, a mv instead of ln -s since this old directory 
> should go away)

After reading your comment for three time, now I understand it.
I put it under dh_install as you recommend.
Now it's rebuildable.

> --buildsystem=cmake --builddirectory=build should be useless

I removed "--buildsystem=cmake"
Thanks for your suggestion!

Without "--builddirectory=build", the docs will be built under
/docs/
This make install file hard to write.
So here I keep as it was.

> also
> DPKG_EXPORT_BUILDFLAGS = 1
> include /usr/share/dpkg/buildflags.mk

Removed.
Thanks for your suggestion!

> 6) did you forward the rename to upstream?

Since the most authors quit redjack, and they're almost not active,
I consider it should be called libcorkipset.

> 7) libredjackipset-docs.docs
> is it useful? there is no package with that name, so probably the file can be 
> removed

Fixed.

> 8) I'm not a fan of dh-exec, and your patch about multiarch seems incomplete
>
> +include(GNUInstallDirs)
>
> this has to be done *before*
>
> "set(CMAKE_INSTALL_LIBDIR lib${LIB_SUFFIX} CACHE STRING"
> note the LIB_SUFFIX
>
> and then the install files can change from
> usr/lib/lib*.so usr/lib/${DEB_HOST_MULTIARCH}
> to
> usr/lib/*/*.so
> and similar for others

Yes, moving "include(GNUInstallDirs)" makes dh-exec useless.
My mistake forced me to introduced this complex. Sorry about that.

> 9)
>
> did you try compat level 10?
> it should speed up the build by running dh --parallel :)
> (you can also experiment with --parallel on the default dh call in rules file)

Tried, just added a lintian warning.
Should be fixed when debhelper 10 released.
So I keep as it is.

Thanks again!

Cheers,
-- 
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 17B3ACB1

Bug#827082: RFS: libredjackipset/1.1.1+20150311-1 [ITP] -- C library to store sets/maps of IP address

[Roger Shimizu]

On Tue, Jun 21, 2016 at 2:38 AM, Roger Shimizu  wrote:
>
> On Mon, Jun 20, 2016 at 10:03 PM, Gianfranco Costamagna
>  wrote:
>
>> 6) did you forward the rename to upstream?
>
> https://github.com/redjack/ipset/issues/41

Wait a minute, now I think your concern regarding renaming is right.
Consider the upstream contributor all left that company, using company
name in library name is not good idea.

Since this library is actually a sub-library of libcork, I'd rather
call it libcorkipset now.
I'll make the change and retitle the ITP/RFS later.

Thanks for your understanding!

Cheers,
-- 
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 17B3ACB1

Bug#827082: RFS: libredjackipset/1.1.1+20150311-1 [ITP] -- C library to store sets/maps of IP address

[Roger Shimizu]

Dear G,

Thanks for your review!

On Mon, Jun 20, 2016 at 10:03 PM, Gianfranco Costamagna
 wrote:
> control: owner -1 !
> control: tags -1 moreinfo
>
> Hi, lets see
>
> 1) control: why the -dev package is not multiarch?
> sounds like it is multiarch ready to me
> (I didn't check but include/* seems to have the same md5sum on different archs

Yes, it's multi-arch, just forgot to mark it in d/control.
Fixed.

> 2) the dev package should suggest the doc one

Fixed.

> 3) d/p/0002-fix-build-with-static-libcheck-library.patch
>
> I can't complain here, I seem to know the author of that patch :p

Thanks for your great help!
This convinced me that this library can be packaged, too.

> 3) d/p/0004-remove-test-of-python-cram.patch
>
> why? python-cram is available on Debian

Yes, I used python3-cram in libcork, but this time it just doesn't work.
So I removed it.

> 4) d/p/0007-*
> why? please be more verbose on patches, otherwise I find difficult to 
> understand why you are using sphinx instead
> of pandoc to build documentation

upstream's docs/CMakeLists.txt just output nothing.
You can see "set(MAN_PAGES)", the target is empty!

So I used the same way in libcork to generate docs.
Actually the upstream was during the transition from sphinx to pandoc.
They removed sphinx setting, added pandoc setting, but didn't remove
sphinx docs.
So I patched back sphinx setting, just works.

(docs from upstream just poor, even I wrote a patch to add index page)

> 5) rules:
> I don't like hacks
> and your sed makes the package non-rebuildable.
>
> maybe overriding the
>
> dh_install target, and acting under debian/libfoo-dev/usr/include
>
> is a "better" way (also, a mv instead of ln -s since this old directory 
> should go away)

gbp-buildpackage and git-pbuilder just behave differently.
the former does: build => install => build test + test
the latter does: build => build test + test => install

Because the library is renamed from libipset to libredjackipset,
current hack is the simplest way to make both gbp-buildpackage and
git-pbuilder happy.

> --buildsystem=cmake --builddirectory=build should be useless

I removed "--buildsystem=cmake"
Thanks for your suggestion!

Without "--builddirectory=build", the docs will be built under
/docs/
This make install file hard to write.

> also
> DPKG_EXPORT_BUILDFLAGS = 1
> include /usr/share/dpkg/buildflags.mk

Removed.
Thanks for your suggestion!

> 6) did you forward the rename to upstream?

https://github.com/redjack/ipset/issues/41

> 7) libredjackipset-docs.docs
> is it useful? there is no package with that name, so probably the file can be 
> removed

Fixed.

> 8) I'm not a fan of dh-exec, and your patch about multiarch seems incomplete
>
> +include(GNUInstallDirs)
>
> this has to be done *before*
>
> "set(CMAKE_INSTALL_LIBDIR lib${LIB_SUFFIX} CACHE STRING"
> note the LIB_SUFFIX
>
> and then the install files can change from
> usr/lib/lib*.so usr/lib/${DEB_HOST_MULTIARCH}
> to
> usr/lib/*/*.so
> and similar for others

Yes, moving "include(GNUInstallDirs)" makes dh-exec useless.
My mistake forced me to introduced this complex. Sorry about that.

> 9)
>
> did you try compat level 10?
> it should speed up the build by running dh --parallel :)
> (you can also experiment with --parallel on the default dh call in rules file)

I'd love to try new stuff after first release :-D

Thanks again!

Cheers,
-- 
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 17B3ACB1

Bug#827082: RFS: libredjackipset/1.1.1+20150311-1 [ITP] -- C library to store sets/maps of IP address

[Gianfranco Costamagna]

control: owner -1 !
control: tags -1 moreinfo

Hi, lets see

1) control: why the -dev package is not multiarch?
sounds like it is multiarch ready to me
(I didn't check but include/* seems to have the same md5sum on different archs


2) the dev package should suggest the doc one


3) d/p/0002-fix-build-with-static-libcheck-library.patch

I can't complain here, I seem to know the author of that patch :p


3) d/p/0004-remove-test-of-python-cram.patch

why? python-cram is available on Debian

4) d/p/0007-*
why? please be more verbose on patches, otherwise I find difficult to 
understand why you are using sphinx instead
of pandoc to build documentation

5) rules:
I don't like hacks
and your sed makes the package non-rebuildable.

maybe overriding the 

dh_install target, and acting under debian/libfoo-dev/usr/include 

is a "better" way (also, a mv instead of ln -s since this old directory should 
go away)

--buildsystem=cmake --builddirectory=build should be useless


also
DPKG_EXPORT_BUILDFLAGS = 1
include /usr/share/dpkg/buildflags.mk


6) did you forward the rename to upstream?

7) libredjackipset-docs.docs
is it useful? there is no package with that name, so probably the file can be 
removed

8) I'm not a fan of dh-exec, and your patch about multiarch seems incomplete

+include(GNUInstallDirs)

this has to be done *before*

"set(CMAKE_INSTALL_LIBDIR lib${LIB_SUFFIX} CACHE STRING"
note the LIB_SUFFIX

and then the install files can change from
usr/lib/lib*.so usr/lib/${DEB_HOST_MULTIARCH}
to
usr/lib/*/*.so
and similar for others

9)

did you try compat level 10?
it should speed up the build by running dh --parallel :)
(you can also experiment with --parallel on the default dh call in rules file)

I guess that's all for now :)

Gianfranco

Bug#827082: RFS: libredjackipset/1.1.1+20150311-1 [ITP] -- C library to store sets/maps of IP address

[Roger Shimizu]

Dear mentors,

I just updated again, and here's the change:

- pick up a few bits (revert, etc) from git history to make the docs working

All changes are pushed to branch pkg-test3 of my github:
  https://github.com/rogers0/libredjackipset

Thank you and look forward to your sponsor!

Cheers,
-- 
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 17B3ACB1

Bug#827082: RFS: libredjackipset/1.1.1+20150311-1 [ITP] -- C library to store sets/maps of IP address

[Roger Shimizu]

Dear mentors,

I just updated a bit, and here's the change:

- remove useless build dependency: pandoc
- add README.markdown as install target for both lib and lib-dev package

All changes are pushed to branch pkg-test3 of my github:
  https://github.com/rogers0/libredjackipset

Thank you and look forward to your sponsor!

Cheers,
-- 
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 17B3ACB1

Bug#827082: RFS: libredjackipset/1.1.1+20150311-1 [ITP] -- C library to store sets/maps of IP address

[Roger Shimizu]

Package: sponsorship-requests
Severity: wishlist
X-Debbugs-Cc: rogershim...@gmail.com

Dear mentors,

I am looking for a sponsor for my package "libredjackipset"

 * Package name: libredjackipset
   Version : 1.1.1+20150311-1
   Upstream Author : Douglas Creager 
 * URL : https://github.com/redjack/ipset
 * License : BSD-3-clause
   Section : libs

It builds those binary packages:

  libredjackipset-dev - C library to store sets/maps of IP address
(development files)
  libredjackipset1 - C library to store sets/maps of IP address

To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/libredjackipset

Alternatively, one can download the package with dget using this command:

  dget -x 
https://mentors.debian.net/debian/pool/main/libr/libredjackipset/libredjackipset_1.1.1+20150311-1.dsc

Some comments:
I have support Multi-Arch in this packaging, following instruction [0]
But since it's my first time doing so, there may be some mistake.
Please help to confirm I'm doing it right. Thank you!

[0] https://wiki.debian.org/Multiarch/Implementation#CMake

Cheers,
-- 
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 17B3ACB1