Bug#856827: RFS: xfce4-equake-plugin/1.3.8.1-2 [RC]
Dear mentors, I opened bug https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=857118 to request an unblock and that was approved, see copy below. I was requested to upload the new version, however I am unable to upload it myself. Would someone be able to upload it on my behalf? Thank you, Jeroen From: Niels Thykier To: Jeroen van Aart , 857...@bugs.debian.org Subject: Re: Bug#857118: unblock: xfce4-equake-plugin/1.3.8-1 Date: Thu, 09 Mar 2017 06:57:00 + Control: tags -1 confirmed moreinfo Jeroen van Aart: > Package: release.debian.org > Severity: serious > User: release.debian@packages.debian.org > Usertags: unblock > > Please unblock package xfce4-equake-plugin > Hi, > Please see related bugs: 856774 and 856827 > > I gave it severity "serious" since I assume it should reflect the severity of > the initial bug, please change as appropriate. > > [...] > Agreed, that bug seems like it would render this package unusable. > I have created a fix that will alow it to use encrypted https access. It uses > libcurl for that and attached a debdiff. > > Thank you for your consideration. > > unblock xfce4-equake-plugin/1.3.8-1 > Please go ahead with the upload and remove the moreinfo tag once it has seen at least 5 days of testing in unstable with no major regressions. Thanks, ~Niels
Bug#856827: RFS: xfce4-equake-plugin/1.3.8.1-2 [RC]
control: tag -1 +moreinfo Dear Jeroen, On Thu, Mar 09, 2017 at 04:50:04PM -0800, Jeroen van Aart wrote: > I opened bug https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=857118 to > request an unblock and that was approved, see copy below. I was requested > to upload the new version, however I am unable to upload it myself. > > Would someone be able to upload it on my behalf? Thank you for working on this RC bug. There are some problems with this upload: - it is conventional to use a version number of -1 (mentors will let you overwrite the old source package), but this is not a big deal (integers are cheap) - the debdiff you submitted to the unblock request is not the same as the debdiff between your proposed upload and the version in sid. Can you explain why? We don't want to upload this to sid unless we are sure it will be unblocked. Thanks. -- Sean Whitton signature.asc Description: PGP signature
Bug#856827: RFS: xfce4-equake-plugin/1.3.8.1-2 [RC]
Dear Sean, Thanks for you reply, see my responses below. > control: tag -1 +moreinfo > > Dear Jeroen, > > On Thu, Mar 09, 2017 at 04:50:04PM -0800, Jeroen van Aart wrote: >> I opened bug https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=857118 to >> request an unblock and that was approved, see copy below. I was >> requested >> to upload the new version, however I am unable to upload it myself. >> >> Would someone be able to upload it on my behalf? > > Thank you for working on this RC bug. There are some problems with this > upload: > > - it is conventional to use a version number of -1 (mentors will let you > overwrite the old source package), but this is not a big deal > (integers are cheap) I gave it version -2 because I initially had uploaded a -1 version to mentors. There were some lintian warnings and I fixed those, that's why I bumped the version to -2. If it is a problem I can change it back again, > - the debdiff you submitted to the unblock request is not the same as > the debdiff between your proposed upload and the version in sid. Can > you explain why? We don't want to upload this to sid unless we are > sure it will be unblocked. I created the debdiff using the versions that can be found in mentors and the one in sid: dget -x https://mentors.debian.net/debian/pool/main/x/xfce4-equake-plugin/xfce4-equake-plugin_1.3.8.1-2.dsc dget -x http://http.debian.net/debian/pool/main/x/xfce4-equake-plugin/xfce4-equake-plugin_1.3.8-1.dsc The latter url I got from https://packages.debian.org/sid/xfce4-equake-plugin I just double checked, when I get the above two version and create a debdiff, and then download the debdiff from the unblock request (https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=857118;filename=debdiff_xfce4-equake_v138-1_v1381-2.diff.gz;msg=5) and then run a diff between those the files turn out to be exactly the same. Maybe you checked against the xfce4-equake-plugin_1.3.8.1-1.dsc version in mentors? If so, I apologise for the confusion.
Bug#856827: RFS: xfce4-equake-plugin/1.3.8.1-2 [RC]
Dear Jeroen, On Sun, Mar 12, 2017 at 09:04:07PM -0700, Jeroen van Aart wrote: > I gave it version -2 because I initially had uploaded a -1 version to > mentors. There were some lintian warnings and I fixed those, that's why I > bumped the version to -2. If it is a problem I can change it back again, No, it's fine. It's just a convention that version numbers are incremented for uploads to the archive, not uploads to mentors. Please try to follow it in the future, just to avoid any confusion. > I just double checked, when I get the above two version and create a > debdiff, and then download the debdiff from the unblock request > (https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=857118;filename=debdiff_xfce4-equake_v138-1_v1381-2.diff.gz;msg=5) > and then run a diff between those the files turn out to be exactly the > same. > > Maybe you checked against the xfce4-equake-plugin_1.3.8.1-1.dsc version in > mentors? If so, I apologise for the confusion. That wasn't the problem. I was failing to pass -p1 to interdiff. Thank you for double checking, anyway. I'd like to see some improvements to your changelog before uploading this. - changes to d/copyright not documented - the last point about avoiding lintian warnings is unnecessarily brief. Please expand it. There is a convention for std-ver changes: * Bump standards version to 3.9.8 (no changes required). -- Sean Whitton signature.asc Description: PGP signature
Bug#856827: RFS: xfce4-equake-plugin/1.3.8.1-2 [RC]
Dear Sean, Thanks for taking the time to look at this. > On Sun, Mar 12, 2017 at 09:04:07PM -0700, Jeroen van Aart wrote: > No, it's fine. It's just a convention that version numbers are > incremented for uploads to the archive, not uploads to mentors. Please try to follow it in the future, just to avoid any confusion. I'll make sure to remember. > That wasn't the problem. I was failing to pass -p1 to interdiff. Thank you for double checking, anyway. > > I'd like to see some improvements to your changelog before uploading this. > > - changes to d/copyright not documented > > - the last point about avoiding lintian warnings is unnecessarily > brief. Please expand it. There is a convention for std-ver changes: > > * Bump standards version to 3.9.8 (no changes required). I made the changes you requested and uploaded it to mentors, I kept the version the same. I assume I don't need to create a debdiff for this small change? Best regards, Jeroen
Bug#856827: RFS: xfce4-equake-plugin/1.3.8.1-2 [RC]
Dear Jeroen, Please be sure to CC the RFS bug! On Wed, Mar 15, 2017 at 10:49:27PM -0700, Jeroen van Aart wrote: > > I'd like to see some improvements to your changelog before uploading > > this. > > > > - changes to d/copyright not documented > > > > - the last point about avoiding lintian warnings is unnecessarily > > brief. Please expand it. There is a convention for std-ver changes: > > > > * Bump standards version to 3.9.8 (no changes required). > > I made the changes you requested and uploaded it to mentors, I kept the > version the same. You still haven't noted that you updated the copyright years. And you haven't documented updating the Homepage: field. Also, there is a typo "Buil-Depends". > I assume I don't need to create a debdiff for this small change? I suggest that when you remove the moreinfo tag from the unblock bug, you say "some changelog tweaks with no functional change (feedback in RFS)". -- Sean Whitton signature.asc Description: PGP signature
Bug#856827: RFS: xfce4-equake-plugin/1.3.8.1-2 [RC]
> Dear Jeroen, > > Please be sure to CC the RFS bug! Forgot the "reply all". I did send it to the RFS bug separately. > On Wed, Mar 15, 2017 at 10:49:27PM -0700, Jeroen van Aart wrote: > You still haven't noted that you updated the copyright years. And you > haven't documented updating the Homepage: field. > > Also, there is a typo "Buil-Depends". I fixed the typo and added an entry to document the change in copyright years as well as the change in the Homepage: control field. I have uploaded it to mentors. >> I assume I don't need to create a debdiff for this small change? > > I suggest that when you remove the moreinfo tag from the unblock bug, > you say "some changelog tweaks with no functional change (feedback in > RFS)". I'll do that, thank you. Best regards, Jeroen
