Bug#859778: [supp...@mentors.debian.net: xtrs uploaded to mentors.debian.net]

[G. Branden Robinson]

At 2017-07-27T13:50:53-0700, Sean Whitton wrote:
> Hello Branden,
> 
> On Thu, Jun 15, 2017 at 04:35:23PM +0100, Sean Whitton wrote:
> > Please accept my apologies for letting this RFS sit for so long.  Thank
> > you for all your work.  Looking forward to uploading it soon.
> > 
> > Here's a full review of dc84e1861798b3aba0969e2fe81a2431f2ee17de:
> 
> Any progress on this?

Hi Sean,

Not much, as I've had a few distractions lately.  However, I do hope to
be able to make some progress on these items this coming week at
DebConf.  Not sure if you were aware, but I'll be there.  Since I see
your name in the keysigning-party keyring, I hope to meet you in person.

Looking forward to it!

Regards,
Branden


signature.asc
Description: PGP signature

Bug#859778: [supp...@mentors.debian.net: xtrs uploaded to mentors.debian.net]

[Sean Whitton]

Hello Branden,

On Thu, Jun 15, 2017 at 04:35:23PM +0100, Sean Whitton wrote:
> Please accept my apologies for letting this RFS sit for so long.  Thank
> you for all your work.  Looking forward to uploading it soon.
> 
> Here's a full review of dc84e1861798b3aba0969e2fe81a2431f2ee17de:

Any progress on this?

-- 
Sean Whitton


signature.asc
Description: PGP signature

Bug#859778: [supp...@mentors.debian.net: xtrs uploaded to mentors.debian.net]

[Sean Whitton]

control: tag -1 +moreinfo

Dear Branden,

Please accept my apologies for letting this RFS sit for so long.  Thank
you for all your work.  Looking forward to uploading it soon.

Here's a full review of dc84e1861798b3aba0969e2fe81a2431f2ee17de:

Should be fixed
===

1. Maybe we should just upload to unstable, DELAYED/7, because the
freeze will be over this weekend?  Would save another RFS next week.

2. Lintian says

W: xtrs source: file-without-copyright-information .gitignore

.gitignore is not copyrightable, so there is no bug, but I think it
would be best to add a Lintian override.  Then the package will be
Lintian-clean.

3. The orig.tar doesn't seem to be the same as the one available from
upstream:

zephyr ~ % shasum tmp/xtrs-4.9d.tar.gz rfs/xtrs_4.9d.orig.tar.gz
72b99ede6e8024b8ade4f8aa22eb073078576e74  tmp/xtrs-4.9d.tar.gz
42b1fc90246901456d29071421e838b545f39f0f  rfs/xtrs_4.9d.orig.tar.gz

Do you know why?  (I'm working from git, but I grabbed the orig.tar from
mentors.)

4. A few things not mentioned in the changelog:

   - new d/clean
   - new d/watch
   - deleted d/dirs
   - debhelper compat bump
   - rewrite d/rules & switch to use dh sequencer (not the same as
 compat bump)
 - add d/xtrs.install
   - std-ver bump (it would be reassuring to see "no changes required")
   - new build deps, e.g. bsdmainutils (btw, really nice commenting of
 the build-deps)
   - postinst tidied up (changes to maintscripts should always be
 mentioned in the changelog, since they are such a frequent source
 of bugs)
   - various patches in d/patches are not in d/changelog.  it might also
 be a good idea to give the patch name, instead of just the file
 modified, so someone can track down the change

5. Copyright file issues:

   - id.po and nl.po seem to have broken template "Copyright (C)" lines.

   - you need entries in d/copyright for the *.po files.  Or you could just
  add the author's names to the stanza for debian/*.

   - The FSF hold copyright on some code in *-idiomatize-manpage.patch

Suggestions
===

1. You could use debhelper compat 10.

2. You could uncomment Vcs-* and fill in the address of your alioth
repo.

3. Typo "appply" in xtrs.doc-base.cpmutil.

4. I think that cpmutil.dsk and utility.dsk should go into
/usr/share/xtrs not /usr/lib/xtrs, since they are binary but not
architecture-dependent

5. emtsafe-flag-on-by-default.patch would benefit from a description
explaining why it's a good idea.

If you're able to address the issues I've raised in this message, please
remove the moreinfo tag in this bug, and don't forget to re-run `dch -r`
to refresh the changelog timestamp.

-- 
Sean Whitton


signature.asc
Description: PGP signature

Bug#859778: [supp...@mentors.debian.net: xtrs uploaded to mentors.debian.net]

[G. Branden Robinson]

package sponsorship-requests
tag 859778 - moreinfo
thanks

$ dput mentors xtrs_4.9d-1_amd64.changes 
Checking signature on .changes
gpg: /home/branden/src/GIT/debian/xtrs_4.9d-1_amd64.changes: Valid signature 
from D19E9C7D71266DCE
Checking signature on .dsc
gpg: /home/branden/src/GIT/debian/xtrs_4.9d-1.dsc: Valid signature from 
D19E9C7D71266DCE
Uploading to mentors (via http to mentors.debian.net):
  Uploading xtrs_4.9d-1.dsc: done.
  Uploading xtrs_4.9d.orig.tar.gz: done.
  Uploading xtrs_4.9d-1.debian.tar.xz: done.  
  Uploading xtrs-dbgsym_4.9d-1_amd64.deb: done.
  Uploading xtrs_4.9d-1_amd64.buildinfo: done.
  Uploading xtrs_4.9d-1_amd64.deb: done.
  Uploading xtrs_4.9d-1_amd64.changes: done.
Successfully uploaded packages.

- Forwarded message from "mentors.debian.net"  
-

Date: Thu,  1 Jun 2017 21:11:41 + (UTC)
From: "mentors.debian.net" 
To: g.branden.robin...@gmail.com
Subject: xtrs uploaded to mentors.debian.net

Hi.

Your upload of the package 'xtrs' to mentors.debian.net was
successful. Others can now see it. The URL of your package is:
https://mentors.debian.net/package/xtrs

The respective dsc file can be found at:
https://mentors.debian.net/debian/pool/contrib/x/xtrs/xtrs_4.9d-1.dsc

If you do not yet have a sponsor for your package you may want to go to
https://mentors.debian.net/sponsors/rfs-howto/xtrs
and set the "Seeking a sponsor" option to highlight your package on the
welcome page.

You can also send an RFS (request for sponsorship) to the debian-mentors
mailing list. Your package page will give your suggestions on how to
send that mail.

Good luck in finding a sponsor!

Thanks,

-- 
mentors.debian.net

- End forwarded message -

Regards,
Branden


signature.asc
Description: PGP signature