Bug#860206: RFS: sysbench
control: tag -1 -moreinfo Sean, thanks for the review. Issues should all be addressed now. > Here is a review of 5a5d084bf540c903d4ea19f9761da2d6b38b3907: > > - It FTBFS. I've attached a log. Took a bit of work to reproduce this one. Restricting a VM to a single core, and stressing that to 100% during build did the trick. Turned out the test was expecting a 1.* value for latency but a system with limited resources would exceed that. Added a patch so that it will accept any latency value >= 1ms (the test has a usleep(1000) statement that ensures that minimum); also forwarded upstream. > An optional wishlist item: > > - crc32tbl.h is a generated file, and ideally it would be regenerated > during the package build. I understand the sentiment, but in this case that seems unnecessary. Looking at the code in crc32.c that table never changes, and it being generated rather than "hand made" was probably a mere choice of convenience for its original author. Upstream version was bumped to newly released v1.0.7 in the process. Git branch for use with dgit-maint-gbp workflow is available at: https://github.com/jcfp/debpkg-sysbench/tree/master/ HEAD commit id 5c1deac8b197e6de7bce29b7341829023fa17202 As requested in dgit-sponsorship(7), some sample commands: To generate the orig tarball: origtargz or using pristine-tar directly: pristine-tar checkout ../sysbench_1.0.7+ds.orig.tar.gz To build the source package: dgit --gbp build-source To Upload: dgit --gbp push pgp5qTZvpq3J5.pgp Description: OpenPGP digital signature
Bug#860206: RFS: sysbench
control: tag -1 +moreinfo Hello, Here is a review of 5a5d084bf540c903d4ea19f9761da2d6b38b3907: - It FTBFS. I've attached a log. - New file d/clean not mentioned in changelog. - Changelog typo "priastine-tar". - Did you run `wrap-and-sort`? It's conventional to say in the changelog that you ran it, giving the options you used, so someone else can run it with the same options if they do an NMU/etc. - I think that the "Manpage" section of the changelog could be clearer. You don't mention the new filename "manpage.txt", and you don't mention that you're now using txt2man (except in the d/control changes). - The patch header of 01_ could be enhanced with an explanation of why the third_party dir is included (I think I can guess, but it would be better explicitly stated) - Have you forwarded 02_ upstream? The DEP-3 patch header format can make this easier to indicate. - If you want to keep the "# you guessed :)" I think it would be best to use DEP-3's Description: field, otherwise it's not obvious why the comment line is there. - Patch 04_ definitely needs an explanation in the patch header as to why it's a good idea to strip it - Are you sure the upstream license is GPL-2, not GPL-2+? - src/xoroshiro128plus.h, m4/lib-ld.m4 missing from d/copyright An optional wishlist item: - crc32tbl.h is a generated file, and ideally it would be regenerated during the package build. If you're able to address the issues I've raised in this message, please remove the moreinfo tag in this bug, and don't forget to re-run `dch -r` to refresh the changelog timestamp. -- Sean Whitton sbuild (Debian sbuild) 0.73.0 (23 Dec 2016) on zephyr.silentflame.com +==+ | sysbench 1.0.6+ds-1 (i386) Fri, 19 May 2017 06:58:44 + | +==+ Package: sysbench Version: 1.0.6+ds-1 Source Version: 1.0.6+ds-1 Distribution: experimental Machine Architecture: i386 Host Architecture: i386 Build Architecture: i386 Build Type: binary I: NOTICE: Log filtering will replace 'var/run/schroot/mount/unstable-i386-sbuild-afa975e8-4d29-4456-8230-88a7e11336b9' with '<>' +--+ | Update chroot| +--+ Get:1 http://cdn-fastly.deb.debian.org/debian unstable InRelease [237 kB] Get:2 http://cdn-fastly.deb.debian.org/debian unstable/main Sources.diff/Index [27.9 kB] Get:3 http://cdn-fastly.deb.debian.org/debian unstable/main i386 Packages.diff/Index [27.9 kB] Get:4 http://cdn-fastly.deb.debian.org/debian unstable/main Sources 2017-05-18-0829.06.pdiff [2941 B] Get:5 http://cdn-fastly.deb.debian.org/debian unstable/main Sources 2017-05-18-1430.00.pdiff [3398 B] Get:6 http://cdn-fastly.deb.debian.org/debian unstable/main Sources 2017-05-18-2029.20.pdiff [3961 B] Get:7 http://cdn-fastly.deb.debian.org/debian unstable/main Sources 2017-05-19-0229.06.pdiff [851 B] Get:7 http://cdn-fastly.deb.debian.org/debian unstable/main Sources 2017-05-19-0229.06.pdiff [851 B] Get:8 http://cdn-fastly.deb.debian.org/debian unstable/main i386 Packages 2017-05-18-0829.06.pdiff [4548 B] Get:9 http://cdn-fastly.deb.debian.org/debian unstable/main i386 Packages 2017-05-18-1430.00.pdiff [1848 B] Get:10 http://cdn-fastly.deb.debian.org/debian unstable/main i386 Packages 2017-05-18-2029.20.pdiff [2917 B] Get:11 http://cdn-fastly.deb.debian.org/debian unstable/main i386 Packages 2017-05-19-0229.06.pdiff [33.9 kB] Get:11 http://cdn-fastly.deb.debian.org/debian unstable/main i386 Packages 2017-05-19-0229.06.pdiff [33.9 kB] Fetched 347 kB in 4s (79.3 kB/s) Reading package lists... Reading package lists... Building dependency tree... Reading state information... Calculating upgrade... The following packages will be upgraded: dpkg dpkg-dev libdpkg-perl 3 upgraded, 0 newly installed, 0 to remove and 0 not upgraded. Need to get 5009 kB of archives. After this operation, 105 kB of additional disk space will be used. Get:1 http://cdn-fastly.deb.debian.org/debian unstable/main i386 dpkg i386 1.18.24 [2134 kB] Get:2 http://cdn-fastly.deb.debian.org/debian unstable/main i386 dpkg-dev all 1.18.24 [1592 kB] Get:3 http://cdn-fastly.deb.debian.org/debian unstable/main i386 libdpkg-perl all 1.18.24 [1283 kB] debconf: delaying package configuration, since apt-utils is not installed Fetched 5009 kB in 4s (1079 kB/s) (Reading database ... (Reading database ... 5% (Reading database ... 10% (Reading database ... 15% (Reading database ... 20% (Reading database ... 25% (Reading database ... 30% (Reading database ... 35% (Reading database ... 40% (Reading database ... 45% (Reading database ... 50% (Reading database ... 55% (Reading database ... 60% (Reading database ... 65% (Reading
Bug#860206: RFS: sysbench
Control: tags -1 - moreinfo Control: retitle -1 RFS: sysbench/1.0.6+ds-1 [ITA] -- multi-threaded benchmark tool for database systems Updated the packaging to upstream v1.0.6 and tackled some minor issues. Git branch for use with dgit-maint-gbp workflow is available at: https://github.com/jcfp/debpkg-sysbench/tree/master/ (HEAD commit id 5a5d084) As requested in dgit-sponsorship(7), some sample commands: To generate the orig tarball: origtargz or using pristine-tar directly: pristine-tar checkout ../sysbench_1.0.6+ds.orig.tar.gz To build the source package: dgit --gbp build-source To Upload: dgit --gbp push pgpnx7ZQkot_C.pgp Description: OpenPGP digital signature
Bug#860206: RFS: sysbench/1.0.5-1 [ITA] -- multi-threaded benchmark tool for database systems
Thank you for your work to adopt this package. I'd like to review and hopefully sponsor this upload. I do require that we work out of git, instead of exchanging source packages via mentors.debian.net. I recommend the git workflow described in dgit-maint-merge(7), but any dgit-compatible workflow is fine -- see the other dgit-maint-*(7) manpages, and dgit-sponsorship(7). When you publish a packaging branch for me to review, it should be fast-forwarding, i.e., you should not rewrite history during the review process (or indeed, after). If this is acceptable to you, please set me as the owner of this RFS bug, and let me know where I can find your git branch. Otherwise, you are quite free to wait for a different potential sponsor. One point I noticed from your changelog: when you bump the std-ver, it is conventional to note "no changes required" if you bumped it without changing anything to be compliant with the new version. -- Sean Whitton signature.asc Description: PGP signature
Bug#860206: RFS: sysbench/1.0.5-1 [ITA] -- multi-threaded benchmark tool for database systems
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for "sysbench": Package name: sysbench Version : 1.0.5-1 Upstream Author : Alexey Kopytov URL : https://github.com/akopytov/sysbench License : GPL-2 Section : misc It builds a single binary package: sysbench - multi-threaded benchmark tool for database systems Mentors URL: https://mentors.debian.net/package/sysbench Download with dget: dget -x https://mentors.debian.net/debian/pool/main/s/sysbench/sysbench_1.0.5-1.dsc Changes since last upload: * New upstream version: + fixes build system issue resulting in an empty html manual. (Closes: #695377) * New maintainer. (Closes: #841528) * Remove d/dirs: not needed just to create /usr/bin. * Docs: + stop installing upstream TODO (empty file). + replace README with README.md (renamed upstream). + include doc-base entry for html manual. * Rules: + switch to dh sequencer with autoreconf. + override dh_auto_configure to enable pgsql database driver, and use system libs for libluajit and ck. + enable all hardening. * Control: + remove build-depends on cdbs, autoconf, automake, and libtool (obsoleted by switch to dh with autoreconf). + add build-depends on libaio-dev (asynchronous I/O mode support) (LP: #1009126), libpq-dev (for the postgresql database driver), python-cram (to run tests at build time), txt2man (to generate manpage during build), libluajit-5.1-dev, libck-dev, pkg-config (needed to use system luajit and ck), and vim-common (for xxd). + set upstream homepage to the project's github page. + enhance short description to include mention of focus on database systems; fix typo in long description. + update VCS links. + bump Standards-Version to 3.9.8 (from 3.9.5). * Patches: + drop d/p/disable-manual-creation.patch to re-enable building the html manual. + drop d/p/libmysqlclient_r, fixed upstream. + add 01: don't require third-party dir for build, after excluding it from the orig.tgz. + add 02: fix typo. + add 03: don't install tests into binary package, already run at build time. + add 04: strip env from shebang, replace with full path to sysbench executable. * Watch: point to github. * Remove d/TODO, all done now that postgresql support is builtin. * Manpage: + drop outdated debian/sysbench.xml and recreate based on help output, eliminating some typos in the process. (Closes: #793428) + remove incorrect examples. (Closes: #692822) + include options of various test modes. (LP: #1309532) * Copyright: + correct Format URI for machine-readable copyright spec. + update all upstream copyright and contact info. + add myself as a copyright holder for the packaging. + exclude third_party directory from orig.tgz. * Bump debhelper compat level to 10 (from 9). Regards. pgpT2M0BvziAj.pgp Description: OpenPGP digital signature
