Bug#893350: RFS: deepin-terminal/2.9.2-1 [ITP]

2018-03-18 Thread Yangfl 
Package: sponsorship-requests
Severity: normal [important for RC bugs, wishlist for new packages]

Dear mentors,

I am looking for a sponsor for my package "deepin-terminal"

 * Package name: deepin-terminal
   Version : 2.9.2-1
   Upstream Author : Deepin Technology Co., Ltd.
 * URL : http://www.deepin.org/
 * License : GPLv3
   Section : x11

It builds those binary packages:

  deepin-terminal - Deepin terminal emulator application

To access further information about this package, please visit the
following URL:

https://mentors.debian.net/package/deepin-terminal


Alternatively, one can download the package with dget using this command:

  dget -x 
https://mentors.debian.net/debian/pool/main/d/deepin-terminal/deepin-terminal_2.9.2-1.dsc


Regards,
 Yangfl

Bug#893350: RFS: deepin-terminal/2.9.2-1 [ITP]

2018-03-18 Thread Adam Borowski 
On Sun, Mar 18, 2018 at 03:40:17PM +0800, Yangfl wrote:
>  * Package name: deepin-terminal
>Version : 2.9.2-1

> It builds those binary packages:
> 
>   deepin-terminal - Deepin terminal emulator application
>   dget -x 
> https://mentors.debian.net/debian/pool/main/d/deepin-terminal/deepin-terminal_2.9.2-1.dsc

Hi!
Great to see a new terminal in.
However, there's a lot of problems with this upload.

First, it FTBFSes unless you apply the following patch:
--- deepin-terminal-2.9.2/debian/control2018-03-18 05:06:02.0 
+0100
+++ deepin-terminal-2.9.2/debian/control2018-03-18 05:06:02.0 
+0100
@@ -12,6 +12,7 @@
libpcre2-dev (>= 10.21),
libgtk-3-dev (>= 3.20),
libgnutls28-dev (>= 3.2.7),
+   libvte-2.91-dev,
libxml2-utils,
gobject-introspection (>= 0.9.12-4~),
libgirepository1.0-dev (>= 0.9.12),

Lots of assets have incorrect paths:
Got error when load css: :1:0Failed to import: Error opening file 
/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/style.css: No such file or 
directory
create_image_surface: tab_close_normal.svg Error opening file 
/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_close_normal.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_close_normal.svg:
 No such file or directory
create_image_surface: tab_close_hover.svg Error opening file 
/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_close_hover.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_close_hover.svg:
 No such file or directory
create_image_surface: tab_close_press.svg Error opening file 
/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_close_press.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_close_press.svg:
 No such file or directory
create_image_surface: tab_add_dark_normal.svg Error opening file 
/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_add_dark_normal.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_add_dark_normal.svg:
 No such file or directory
create_image_surface: tab_add_dark_hover.svg Error opening file 
/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_add_dark_hover.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_add_dark_hover.svg:
 No such file or directory
create_image_surface: tab_add_dark_press.svg Error opening file 
/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_add_dark_press.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_add_dark_press.svg:
 No such file or directory
create_image_surface: tab_add_light_normal.svg Error opening file 
/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_add_light_normal.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_add_light_normal.svg:
 No such file or directory
create_image_surface: tab_add_light_hover.svg Error opening file 
/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_add_light_hover.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_add_light_hover.svg:
 No such file or directory
create_image_surface: tab_add_light_press.svg Error opening file 
/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_add_light_press.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/tab_add_light_press.svg:
 No such file or directory
Failed to open file 
'/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/deepin-terminal.svg':
 No such file or directorycreate_image_surface: window_menu_dark_normal.svg 
Error opening file 
/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_menu_dark_normal.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_menu_dark_normal.svg:
 No such file or directory
create_image_surface: window_menu_dark_hover.svg Error opening file 
/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_menu_dark_hover.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_menu_dark_hover.svg:
 No such file or directory
create_image_surface: window_menu_dark_press.svg Error opening file 
/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_menu_dark_press.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_menu_dark_press.svg:
 No such file or directory
create_image_surface: window_menu_light_normal.svg Error opening file 
/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_menu_light_normal.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_menu_light_normal.svg:
 No such file or directory
create_image_surface: window_menu_light_hover.svg Error opening file 
/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_menu_light_hover.svg/file:/build/deepin-terminal-0vpSjU/deepin-terminal-2.9.2/image/window_menu_light_hover.svg:
 No such file or directory
create_image_

Bug#893350: RFS: deepin-terminal/2.9.2-1 [ITP]

2018-03-18 Thread Yangfl 
2018-03-18 20:36 GMT+08:00 Adam Borowski :
> First, it FTBFSes unless you apply the following patch:

Sorry for missing build-dep. Repacked.

> Lots of assets have incorrect paths:

I can't see such errors. Maybe due to the  in the first line?

Bug#893350: RFS: deepin-terminal/2.9.2-1 [ITP]

2018-03-18 Thread Adam Borowski 
On Sun, Mar 18, 2018 at 10:31:57PM +0800, Yangfl wrote:
> 2018-03-18 20:36 GMT+08:00 Adam Borowski :
> > First, it FTBFSes unless you apply the following patch:
> 
> Sorry for missing build-dep. Repacked.

Builds ok now, thanks.

> > Lots of assets have incorrect paths:
> 
> I can't see such errors. Maybe due to the  in the first line?

Still there; I see the build path embedded in the executable.

I assume you're building from your home dir rather than in sbuild; if this
is the case, running deepin-terminal will find the files on the disk, but it
won't work on any other machine.


喵!
-- 
⢀⣴⠾⠻⢶⣦⠀ 
⣾⠁⢠⠒⠀⣿⡁ A dumb species has no way to open a tuna can.
⢿⡄⠘⠷⠚⠋⠀ A smart species invents a can opener.
⠈⠳⣄ A master species delegates.

Bug#893350: RFS: deepin-terminal/2.9.2-1 [ITP]

2018-03-18 Thread Yangfl 
2018-03-18 22:48 GMT+08:00 Adam Borowski :
>
> Still there; I see the build path embedded in the executable.
>
> I assume you're building from your home dir rather than in sbuild; if this
> is the case, running deepin-terminal will find the files on the disk, but it
> won't work on any other machine.

Oh yes. Fixed and reuploaded.

Bug#893350: RFS: deepin-terminal/2.9.2-1 [ITP]

2018-03-18 Thread Adam Borowski 
On Sun, Mar 18, 2018 at 11:26:30PM +0800, Yangfl wrote:
> 2018-03-18 22:48 GMT+08:00 Adam Borowski :
> >
> > Still there; I see the build path embedded in the executable.
> >
> > I assume you're building from your home dir rather than in sbuild; if this
> > is the case, running deepin-terminal will find the files on the disk, but it
> > won't work on any other machine.
> 
> Oh yes. Fixed and reuploaded.

Hmm, in the version I just pulled from mentors, the only change from the
previous version are changes to copyright and a lintian override.
The embedded path is still there.


喵!
-- 
⢀⣴⠾⠻⢶⣦⠀ 
⣾⠁⢠⠒⠀⣿⡁ A dumb species has no way to open a tuna can.
⢿⡄⠘⠷⠚⠋⠀ A smart species invents a can opener.
⠈⠳⣄ A master species delegates.

Bug#893350: RFS: deepin-terminal/2.9.2-1 [ITP]

2018-03-18 Thread Yangfl 
2018-03-18 23:34 GMT+08:00 Adam Borowski 
> Hmm, in the version I just pulled from mentors, the only change from the
> previous version are changes to copyright and a lintian override.
> The embedded path is still there.

That's the delay of mentors. It should be fine now.