Bug#900368: RFS: pygithub/1.40a3-1 [ITP]
Hello Dmitry, I just pushed the update the package to Salsa. I pushed the PyGithub_1.40 version. Regards! Emmanuel El mié., 4 de jul. de 2018 a la(s) 10:41, eamanu15 < emmanuelaria...@gmail.com> escribió: > Ok! Thanks !!! > > El mié., 4 de jul. de 2018 a la(s) 09:13, Dmitry Shachnev < > mity...@debian.org> escribió: > >> On Wed, Jul 04, 2018 at 07:09:20AM -0300, eamanu15 wrote: >> > Hello Dmitry, >> > >> > I have the fixes almost already, Just, I have a doubt in this point: >> > >> > > - When building in the current sid, I get Lintian warnings about >> three files >> > > shipped in /usr/lib/python3.7/dist-packages/. >> > >> > To fix this problem I could add in the d/rules the next line: >> > >> > override_dh_auto_install: >> > dh_auto_install >> > find ./debian/python3-github/usr/lib/ -type f -name python3.* >> -delete >> > >> > isn't? >> >> It is a directory, not a file. Also you need to do it after dh_python3 >> runs. >> So better use this: >> >> override_dh_python3: >> dh_python3 >> rm -rfv debian/python3-github/usr/lib/python3.* >> >> -- >> Dmitry Shachnev >> > -- > Arias Emmanuel > https://www.linkedin.com/in/emmanuel-arias-437a6a8a > http://eamanu.com > -- Arias Emmanuel https://www.linkedin.com/in/emmanuel-arias-437a6a8a http://eamanu.com
Bug#900368: RFS: pygithub/1.40a3-1 [ITP]
Ok! Thanks !!! El mié., 4 de jul. de 2018 a la(s) 09:13, Dmitry Shachnev < mity...@debian.org> escribió: > On Wed, Jul 04, 2018 at 07:09:20AM -0300, eamanu15 wrote: > > Hello Dmitry, > > > > I have the fixes almost already, Just, I have a doubt in this point: > > > > > - When building in the current sid, I get Lintian warnings about three > files > > > shipped in /usr/lib/python3.7/dist-packages/. > > > > To fix this problem I could add in the d/rules the next line: > > > > override_dh_auto_install: > > dh_auto_install > > find ./debian/python3-github/usr/lib/ -type f -name python3.* -delete > > > > isn't? > > It is a directory, not a file. Also you need to do it after dh_python3 > runs. > So better use this: > > override_dh_python3: > dh_python3 > rm -rfv debian/python3-github/usr/lib/python3.* > > -- > Dmitry Shachnev > -- Arias Emmanuel https://www.linkedin.com/in/emmanuel-arias-437a6a8a http://eamanu.com
Bug#900368: RFS: pygithub/1.40a3-1 [ITP]
On Wed, Jul 04, 2018 at 07:09:20AM -0300, eamanu15 wrote: > Hello Dmitry, > > I have the fixes almost already, Just, I have a doubt in this point: > > > - When building in the current sid, I get Lintian warnings about three files > > shipped in /usr/lib/python3.7/dist-packages/. > > To fix this problem I could add in the d/rules the next line: > > override_dh_auto_install: > dh_auto_install > find ./debian/python3-github/usr/lib/ -type f -name python3.* -delete > > isn't? It is a directory, not a file. Also you need to do it after dh_python3 runs. So better use this: override_dh_python3: dh_python3 rm -rfv debian/python3-github/usr/lib/python3.* -- Dmitry Shachnev signature.asc Description: PGP signature
Bug#900368: RFS: pygithub/1.40a3-1 [ITP]
Hello Dmitry, I have the fixes almost already, Just, I have a doubt in this point: - When building in the current sid, I get Lintian warnings about three files > shipped in /usr/lib/python3.7/dist-packages/. > > That probably happens because of output of 2to3 is slightly different in > Python 3.6 and 3.7 (e.g. files.items() vs. iter(files.items())), and > dh_python3 does not remove the file if it does not match. > > I would recommend removing debian/python3-github/usr/lib/python3.* > manually > in debian/rules. Keeping debian-python@ in Cc in case someone has a > better > idea. > To fix this problem I could add in the d/rules the next line: override_dh_auto_install: dh_auto_install find ./debian/python3-github/usr/lib/ -type f -name python3.* -delete isn't? Regards! Thanks! Emmanuel -- Arias Emmanuel https://www.linkedin.com/in/emmanuel-arias-437a6a8a http://eamanu.com
Bug#900368: RFS: pygithub/1.40a3-1 [ITP]
On Tue, Jul 03, 2018 at 06:00:34PM -0300, eamanu15 wrote: > Hello Dimitry, > > Thanks for you email. I Will make the changes that you recommend. > > I have a cuestion for you. When I update to the version 1.40, Do I merge > all the changelog entries, including 1.35-1 upload, isn't? Yes, it is better to merge these entries and keep one entry per actual upload to archive. -- Dmitry Shachnev signature.asc Description: PGP signature
Bug#900368: RFS: pygithub/1.40a3-1 [ITP]
Hello Dimitry, Thanks for you email. I Will make the changes that you recommend. I have a cuestion for you. When I update to the version 1.40, Do I merge all the changelog entries, including 1.35-1 upload, isn't? Thanks Regards Arias Emmanuel eamanu.com El mar., 3 de jul. de 2018 17:17, Dmitry Shachnev escribió: > Control: merge 898416 898811 900368 > > Hi Emmanuel! > > On Tue, May 29, 2018 at 12:35:25PM -0300, eamanu15 wrote: > > Package: sponsorship-requests > > Severity: normal > > > > Dear mentors, > > > > I am looking for a sponsor for my package "pygithub" > > Note that I am merging your three RFS bugs. If you want to ping, just reply > to the existing bug, not file a new one. > > Here are my comments about your changes. > > - It would be nice if you based the repository on the existing Git > repository [1], rather than starting from scratch. > > Also for new team repositories as this one, it is better to use Gbp-Pq > workflow as described in the team wiki [2]. > > - Please merge the last three changelog entries, as 1.35-1 upload did not > happen. > > - When building in the current sid, I get Lintian warnings about three > files > shipped in /usr/lib/python3.7/dist-packages/. > > That probably happens because of output of 2to3 is slightly different in > Python 3.6 and 3.7 (e.g. files.items() vs. iter(files.items())), and > dh_python3 does not remove the file if it does not match. > > I would recommend removing debian/python3-github/usr/lib/python3.* > manually > in debian/rules. Keeping debian-python@ in Cc in case someone has a > better > idea. > > - A new stable 1.40 release has been released on June 26th [3]. > Can you update from alpha to the stable version? > > Also please add uversionmangle to debian/watch (like here [4]), to make > it > treat 1.40 as a higher version than 1.40aN. > > [1]: > https://alioth-archive.debian.org/git/users/kaction-guest/pygithub.git.tar.xz > [2]: https://wiki.debian.org/Python/GitPackagingPQ > [3]: https://pypi.org/project/PyGithub/1.40/ > [4]: https://pypi.debian.net/PyGithub/watch > > -- > Dmitry Shachnev >
Bug#900368: RFS: pygithub/1.40a3-1 [ITP]
Control: merge 898416 898811 900368 Hi Emmanuel! On Tue, May 29, 2018 at 12:35:25PM -0300, eamanu15 wrote: > Package: sponsorship-requests > Severity: normal > > Dear mentors, > > I am looking for a sponsor for my package "pygithub" Note that I am merging your three RFS bugs. If you want to ping, just reply to the existing bug, not file a new one. Here are my comments about your changes. - It would be nice if you based the repository on the existing Git repository [1], rather than starting from scratch. Also for new team repositories as this one, it is better to use Gbp-Pq workflow as described in the team wiki [2]. - Please merge the last three changelog entries, as 1.35-1 upload did not happen. - When building in the current sid, I get Lintian warnings about three files shipped in /usr/lib/python3.7/dist-packages/. That probably happens because of output of 2to3 is slightly different in Python 3.6 and 3.7 (e.g. files.items() vs. iter(files.items())), and dh_python3 does not remove the file if it does not match. I would recommend removing debian/python3-github/usr/lib/python3.* manually in debian/rules. Keeping debian-python@ in Cc in case someone has a better idea. - A new stable 1.40 release has been released on June 26th [3]. Can you update from alpha to the stable version? Also please add uversionmangle to debian/watch (like here [4]), to make it treat 1.40 as a higher version than 1.40aN. [1]: https://alioth-archive.debian.org/git/users/kaction-guest/pygithub.git.tar.xz [2]: https://wiki.debian.org/Python/GitPackagingPQ [3]: https://pypi.org/project/PyGithub/1.40/ [4]: https://pypi.debian.net/PyGithub/watch -- Dmitry Shachnev signature.asc Description: PGP signature
Bug#900368: RFS: pygithub/1.40a3-1 [ITP]
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "pygithub" * Package name: pygithub Version : 1.40a3-1 Upstream Author : Author : Adam Dangoor Vincent Jacques < vinc...@vincent-jacques.net> Jeremy Phelps < jphe...@linuxfoundation.org> * URL : https://pypi.python.org/pypi/PyGithub * License : LGPL-3+ Section : python It builds those binary packages: python-github - Access to full Github API v3 from Python2 python3-github - Access the full Github API v3 from Python3 To access further information about this package, please visit the following URL: https://mentors.debian.net/package/pygithub or https://salsa.debian.org/python-team/modules/pygithub Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/p/pygithub/pygithub_1.40a3-1.dsc or git clone g...@salsa.debian.org:python-team/modules/pygithub.git More information about pygithub can be obtained from http://pygithub.readthedocs.io/ Changes since the last upload: * New upstream release * Update Standards-Version from 4.1.3 to 4.1.4 version * Add Uploaders field from debian/control to intent to adopt the package (Closes: #851187) Regards, Emmanuel Arias -- Arias Emmanuel https://www.linkedin.com/in/emmanuel-arias-437a6a8a http://eamanu.com