Bug#923180: Please sponsor my game bug=923180
Hi, Am 11.03.19 um 21:05 schrieb Pedro Pena: > Hello Markus, > > Very exciting.. > > I applied the patches and made the other changes as well. > However, there are lintian warnings because infinitetux.jar > is now included in the source files. [...] I think I know the reason. You used source format 1.0. Better is to use format 3.0 (quilt). The changelog version should be 1.1-1 because infinitetux is a non-native package meaning we append a Debian revision number to the upstream version. The changelog should also close the ITP bug. I have already updated the package accordingly. I forgot to mention that you can even remove the compat file nowadays if you build-depend on debhelper-compat (= 12) instead of just debhelper. Less is more. :) I also added a watch file. See https://wiki.debian.org/debian/watch for future projects. Thanks for changing infinitetux-data to .infinitetux. Everything else looks good, I've just uploaded the package to NEW and imported it to https://salsa.debian.org/games-team/infinitetux If you want to improve the package or package a new upstream version, you can ask for sponsorship on debian-devel-games directly. You don't have to take the mentors route again. I have granted you access to our Git repository so you can prepare new updates there. Thanks for your contribution! Regards, Markus signature.asc Description: OpenPGP digital signature
Bug#923180: Please sponsor my game bug=923180
Hello Pedro, Am 08.03.19 um 02:49 schrieb Pedro Pena: > Hello Markus, > > I found an online appstream generator that helped me create the appstream > file. > > I built the package without any errors. and just uploaded it. > > I installed the package hoping to see the appstream data rendered in > the package manager but I guess it only displays info from the > control file when it isn't an official debian package. > > Please let me know if I'm missing anything. I think we are very close now to upload infinitetux. I have attached two patches. The first one will change the installation directory to /usr/share/games. The other one will use the --release flag instead of -source and -target. This prevents an error when using OpenJDK 8 to run the game. Please remove the executable bit from all java and resource files. chmod a-x. Currently the game creates an infinitetux-data directory in the user's home directory where it saves tiles.dat. This directory should be hidden and renamed to .infinitetux. You could also consider to follow the XDG specification. https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html Last but not least, please add some VCS links to debian/control and change the maintainer field to Debian Games Team and add yourself as Uploader. Uploaders: qbancoffee This way it is easier for others to make changes to the package and keep it in good shape. Otherwise the rest looks good to me. I will import the next revision into our Git repository. You can ask for access here: https://salsa.debian.org/games-team Cheers, Markus From 691369953345d31a88636c2f0f2aabdf0bb126f3 Mon Sep 17 00:00:00 2001 From: Markus Koschany Date: Sun, 10 Mar 2019 15:22:56 +0100 Subject: [PATCH 1/2] Install infinitetux.jar into /usr/share/games. --- debian/infinitetux.links | 2 +- debian/install | 2 +- debian/rules | 5 +++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/debian/infinitetux.links b/debian/infinitetux.links index 7c61489..6a78453 100644 --- a/debian/infinitetux.links +++ b/debian/infinitetux.links @@ -1 +1 @@ -/usr/share/infinitetux/infinitetux.jar /usr/games/infinitetux +/usr/share/games/infinitetux/infinitetux.jar /usr/games/infinitetux diff --git a/debian/install b/debian/install index b317498..2f17a48 100644 --- a/debian/install +++ b/debian/install @@ -1,4 +1,4 @@ -../infinitetux.jar usr/share/infinitetux +infinitetux.jar usr/share/games/infinitetux infinitetux.appdata.xml usr/share/metainfo infinitetux.desktop usr/share/applications infinitetux.png usr/share/icons/hicolor/256x256/apps diff --git a/debian/rules b/debian/rules index 091190d..7a62756 100755 --- a/debian/rules +++ b/debian/rules @@ -5,8 +5,9 @@ override_dh_auto_build: JAVA_HOME=/usr/lib/jvm/default-java jh_build --no-javadoc --javacopts="-source 1.8 -target 1.8" \ - --main=com.mojang.mario.FullScreenFrameLauncher ../infinitetux.jar src + --main=com.mojang.mario.FullScreenFrameLauncher infinitetux.jar src override_dh_install: - jar uf ../infinitetux.jar -C src/main/resources . + jar uf infinitetux.jar -C src/main/resources . dh_install + -- 2.20.1 From 824bce75f919d57e0019e3e842074583caaeeecc Mon Sep 17 00:00:00 2001 From: Markus Koschany Date: Sun, 10 Mar 2019 15:29:58 +0100 Subject: [PATCH 2/2] Use -release 8 option. --- debian/rules | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/rules b/debian/rules index 7a62756..90c82a9 100755 --- a/debian/rules +++ b/debian/rules @@ -4,7 +4,7 @@ override_dh_auto_build: JAVA_HOME=/usr/lib/jvm/default-java - jh_build --no-javadoc --javacopts="-source 1.8 -target 1.8" \ + jh_build --no-javadoc --javacopts="--release 8" \ --main=com.mojang.mario.FullScreenFrameLauncher infinitetux.jar src override_dh_install: -- 2.20.1 signature.asc Description: OpenPGP digital signature
Bug#923180: Please sponsor my game bug=923180
Control: reopen 923180 Am 07.03.19 um 05:24 schrieb Pedro Pena: [...] > "Bug #923180 does not belong to this package" > > Is this normal? Sorry, I got confused. This is your ITP bug. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=922844 It must be closed in debian/changelog, then Lintian won't complain anymore. You opened two RFS bugs. Let's close 923172 and continue our discussion in 923180 now. Markus signature.asc Description: OpenPGP digital signature
Bug#923180: Please sponsor my game bug=923180
Hi, Am 07.03.19 um 05:24 schrieb Pedro Pena: > Hello Markus, > > The only thing I have left is figuring out how to create an appstream > file and how to integrate it. There is a quick start guide which is quite helpful. https://www.freedesktop.org/software/appstream/docs/chap-Quickstart.html#sect-Quickstart-DesktopApps Here is an example file for another game in Debian. https://sources.debian.org/src/cube2-data/1.2-1/cube2-data.appdata.xml/ In short appstream increases the visibility of software in Debian and other distributions. All others things are done however, > After uploading the source, lintian complains with the following > error. > > "Bug #923180 does not belong to this package" > > Is this normal? > > Does not having an appstream file pause this process? This is unrelated. The error can be ignored. The ITP bug belongs to the WNPP pseudo package and since infinitetux is not in Debian yet, there is no possible way to reassign it. Regards, Markus signature.asc Description: OpenPGP digital signature
Bug#923180: Please sponsor my game bug=923180
Am 06.03.19 um 03:20 schrieb Pedro Pena: > Hello Markus, > Good to hear you finally able to play infinitetux! > > I'll start working on applying your suggestions. > > As far as the OGA -BY license goes,it appears that > OpenGameArt does indeed have a specific license. > > I don't see any non commercial wording in it, so is it still o.k. > to use? > > OpenGameArt has the following in the FAQ page. > > "OGA-BY 3.0 explicitly allows content to be relicensed under CC-BY 3.0. > Just change the license to CC-BY 3.0. No need to get explicit permission > to do this, as the license already allows it." > > https://opengameart.org/content/oga-by-30-faq > > > Should I just re-license the file then? > > Thank you for your help! Thanks for the link and clarification. Then OGA-BY-3.0 is just a slightly modified version of CC-BY-3.0. I'm fine with that. There is at least one -NC license though. Files: src/main/resources/endscene.gif Copyright: 2018, Pedro Pena License: CC-BY-NC-4.0 Comment: Modified by Pedro Pena link to source provided. http://pngimg.com/uploads/linux/linux_PNG43.png If the source file was already licensed this way, then you can't change the license to a non-NC one. In this case you have to find another image or the author might be willing to relicense it to CC-BY-4.0. Something I forgot to write yesterday. The icon must be renamed to infinitetux.png if you install it into the hicolor directory. The resulting jar file should be installed into /usr/share/games/infinitetux and the link should be in /usr/games not /usr/bin. Debian makes a distinction between games and normal applications, whether it is useful is another question, but that's the current policy. Regards, Markus signature.asc Description: OpenPGP digital signature
Bug#923180: Please sponsor my game bug=923180
Hello Pedro, Am 05.03.19 um 15:14 schrieb Pedro Pena: > Hello Markus, > > I have been able to remove the majority of the warnings that appear. > Unfortunately I can not seem to get lintian to show me the same errors > locally. I have to upload to mentors.debian.net to see the warnings. > > I thought that this might be due to a version difference with lintian > in Ubuntu 16.04 so I installed debian 9.8.0 on a virtual machine > in the hopes that that might makes things a little easier but the results > were the same. > > I also have an issue with the deb helper version. When I change to a version > higher than 10, debuild creates fatal errors. > dpkg-checkbuilddeps: error: Unmet build dependencies: debhelper (>= 11) > > Is it o.k. to leave it as 10 for now? You can even use debhelper 12 in Debian unstable. It works for me just fine. It is recommended to use an up-to-date Debian unstable/sid system for development because older versions or derivatives like Ubuntu don't provide all the features you need. Compat level 11 or 12 are not available in Debian 9. The package looks much better now and I could play the game for the first time. = copyright = Please note that NC (= non commercial) licenses are not approved and you must replace the content if you want to include infinitetux in Debian. Is there really a specific OpenGameArt license? The OGA-BY-3.0 looks similar to CC-BY-3.0. = changelog = The initial changelog should contain just one paragraph. infinitetux (1.1) unstable; urgency=medium * Initial release. (Closes: #923180) -- qbancoffee Thu, 27 Dec 2018 10:31:26 + You can update the changelog timestamp by running dch -r. = wrap-and-sort = There is nice tool called wrap-and-sort in the devscripts package. As the name implies it tidies your debian directory. wrap-and-sort -sa will also remove trailing whitespace (which is currently present in d/copyright = control = The short description should be Description: 2D platformer game inspired by Infinite Mario Here goes the long description. Currently the long description is incomplete. You duplicate the Homepage field. Section should be games not X11. desktop.file: [Desktop Entry] Comment=Infinite Tux. Terminal=false Name=Infinite Tux. Exec=/usr/bin/infinitetux Type=Application Icon=/usr/share/doc/infinitetux/icon.png NoDisplay=false Categories=Game The Comment should be different than the Name. I would change it to [Desktop Entry] Type=Application Terminal=false StartupNotify=false Categories=Game;ArcadeGame; Keywords=game;arcade;platform; Icon=infinitetux Exec=infinitetux Name=Infinitetux Comment=2D platformer game inspired by Infinite Mario There is no need for absolute paths and you should install the icon into the hicolor icon directory /usr/share/icons/hicolor/256x256/apps where it will be detected automatically. Bonus points if you create an appstream file as upstream too and install it into /usr/share/metainfo You can remove all maven.* files and infinitetux.poms because you don't use Maven to build the package. There is still one Lintian warning: manpage-has-bad-whatis-entry If you want to see all warnings including the experimental ones, then I suggest to use info=yes display-info=yes display-experimental=yes pedantic=yes show-overrides=yes color=auto verbose=yes in ~/.config/lintian/lintianrc We are getting closer! Regards, Markus signature.asc Description: OpenPGP digital signature
