Bug#923209: RFS: heaptrack/1.1.0+20180922.gitf752536-3.1 [NMU]
Hi Nicholas, > Maybe it's obvious, but perhaps the developer's reference and > wiki/PackageSalvaging would benefit from the addition of "Things to do > before NMUing…for a team maintained package, […] It's a > trivial bit of work I'd be happy to do... Go for it :) Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org 🍥 chris-lamb.co.uk `-
Bug#923209: RFS: heaptrack/1.1.0+20180922.gitf752536-3.1 [NMU]
On Tue, Feb 26, 2019 at 06:16:29PM -0500, Chris Lamb wrote: > Hi Nicholas, > > > Well, I packaged memleax because I couldn't find heaptrack, and when > > memleax was abandoned upstream I discovered heaptrack via memleax' > > issue tracker. > > I certainly would agree that this is a bug. That is not the question here. > > > So are NMUs only justified for fixing RC bugs > > Yes, or least something of "Severity: important" (or similar in > spirit). Our difference, if any, is that I don't feel that is > warranted here. :) > That's fair ;-) Also, I just realised that I've collaborated with some Debian Science Team members before, and have reached out to them. 'should have investigated that avenue before requesting an NMU. Maybe it's obvious, but perhaps the developer's reference and wiki/PackageSalvaging would benefit the addition of "Things to do before NMUing…for a team maintained package, try to find someone you know on the team to do a Team Upload (link to page that has Team IRC channels, and suggest examining Team members list on Salsa). It's a trivial bit of work I'd be happy to do... Thanks again! Nicholas signature.asc Description: PGP signature
Bug#923209: RFS: heaptrack/1.1.0+20180922.gitf752536-3.1 [NMU]
Hi Nicholas, > Well, I packaged memleax because I couldn't find heaptrack, and when > memleax was abandoned upstream I discovered heaptrack via memleax' > issue tracker. I certainly would agree that this is a bug. That is not the question here. > So are NMUs only justified for fixing RC bugs Yes, or least something of "Severity: important" (or similar in spirit). Our difference, if any, is that I don't feel that is warranted here. :) Best wishes, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org 🍥 chris-lamb.co.uk `-
Re: Bug#923209: RFS: heaptrack/1.1.0+20180922.gitf752536-3.1 [NMU]
On Tue, Feb 26, 2019 at 07:47:39PM -, Sune Vuorela wrote: > On 2019-02-25, Chris Lamb wrote: > > Hi Nicholas, > > > >> heaptrack (1.1.0+20180922.gitf752536-3.1) unstable; urgency=medium > >> > >> * Non-maintainer upload. > >> * Update description to make heaptrack more discoverable to users. > >> (Closes: #915241) > >> > >> -- Nicholas D Steeves Sun, 24 Feb 2019 19:44:03 > >> -0700 > > > > Whilst I agree about the poor visibility I don't think this > > warrants a non-maintainer upload (or even a "normal"-level > > severity…) especially during a freeze so I will not be sponsoring > > this upload. Apologies. > > Maybe the fact that heaptrack-gui doesn't depend on either heaptrack nor > libheaptrack might be a rc bug. and maybe this can be sneaked in ? :) > > /Sune > I did however find this W: heaptrack source: inconsistent-appstream-metadata-license src/analyze/gui/org.kde.heaptrack.appdata.xml (cc0-1.0 != lgpl-2.1+) which feels RCish, but not RC, because CC0-1.0 GPL-2.0+ and this file falls under Files: * Copyright: 2014-2017 Milian Wolff License: LGPL-2.1+ Presumably the resolution would be to note that this appdata.xml file is CC0-1.0 in debian/copyright. Cheers, Nicholas signature.asc Description: PGP signature
Bug#923209: RFS: heaptrack/1.1.0+20180922.gitf752536-3.1 [NMU]
Hi Chris, On Mon, Feb 25, 2019 at 07:29:56AM +, Chris Lamb wrote: > Hi Nicholas, > > > heaptrack (1.1.0+20180922.gitf752536-3.1) unstable; urgency=medium > > > > * Non-maintainer upload. > > * Update description to make heaptrack more discoverable to users. > > (Closes: #915241) > > > > -- Nicholas D Steeves Sun, 24 Feb 2019 19:44:03 -0700 > > Whilst I agree about the poor visibility I don't think this > warrants a non-maintainer upload (or even a "normal"-level > severity…) especially during a freeze so I will not be sponsoring > this upload. Apologies. > Well, I packaged memleax because I couldn't find heaptrack, and when memleax was abandoned upstream I discovered heaptrack via memleax' issue tracker. There, upstream said he might not have started work on memleax if he had known about heaptrack. [1] I thought that this warranted an NMU, after waiting > 2.5 months for a reply at #915241. eg: that an NMU was for the greatest good if people have such a hard time discovering heaptrack that they start projects to reimplement its functionality unawares. So are NMUs only justified for fixing RC bugs and/or never for adding basic discoverability (apt search keyword_or_expression)? Regards, Nicholas [1] https://github.com/WuBingzheng/memleax/issues/37#issuecomment-405792279 signature.asc Description: PGP signature
Re: Bug#923209: RFS: heaptrack/1.1.0+20180922.gitf752536-3.1 [NMU]
Hi Sune, On Tue, Feb 26, 2019 at 07:47:39PM -, Sune Vuorela wrote: > On 2019-02-25, Chris Lamb wrote: > > Hi Nicholas, > > > >> heaptrack (1.1.0+20180922.gitf752536-3.1) unstable; urgency=medium > >> > >> * Non-maintainer upload. > >> * Update description to make heaptrack more discoverable to users. > >> (Closes: #915241) > >> > >> -- Nicholas D Steeves Sun, 24 Feb 2019 19:44:03 > >> -0700 > > > > Whilst I agree about the poor visibility I don't think this > > warrants a non-maintainer upload (or even a "normal"-level > > severity…) especially during a freeze so I will not be sponsoring > > this upload. Apologies. > > Maybe the fact that heaptrack-gui doesn't depend on either heaptrack nor > libheaptrack might be a rc bug. and maybe this can be sneaked in ? :) > > /Sune > Hah, good idea! I checked just just now, and heaptrack-gui works fine without libheaptrack; surprisingly, the lib doesn't appear to be needed for the gui's data analysis. So much for sneakiness ;-) Cheers, Nicholas signature.asc Description: PGP signature
Re: Bug#923209: RFS: heaptrack/1.1.0+20180922.gitf752536-3.1 [NMU]
On 2019-02-25, Chris Lamb wrote: > Hi Nicholas, > >> heaptrack (1.1.0+20180922.gitf752536-3.1) unstable; urgency=medium >> >> * Non-maintainer upload. >> * Update description to make heaptrack more discoverable to users. >> (Closes: #915241) >> >> -- Nicholas D Steeves Sun, 24 Feb 2019 19:44:03 -0700 > > Whilst I agree about the poor visibility I don't think this > warrants a non-maintainer upload (or even a "normal"-level > severity…) especially during a freeze so I will not be sponsoring > this upload. Apologies. Maybe the fact that heaptrack-gui doesn't depend on either heaptrack nor libheaptrack might be a rc bug. and maybe this can be sneaked in ? :) /Sune
Bug#923209: RFS: heaptrack/1.1.0+20180922.gitf752536-3.1 [NMU]
Hi Nicholas, > heaptrack (1.1.0+20180922.gitf752536-3.1) unstable; urgency=medium > > * Non-maintainer upload. > * Update description to make heaptrack more discoverable to users. > (Closes: #915241) > > -- Nicholas D Steeves Sun, 24 Feb 2019 19:44:03 -0700 Whilst I agree about the poor visibility I don't think this warrants a non-maintainer upload (or even a "normal"-level severity…) especially during a freeze so I will not be sponsoring this upload. Apologies. Best wishes, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org 🍥 chris-lamb.co.uk `-
Bug#923209: RFS: heaptrack/1.1.0+20180922.gitf752536-3.1 [NMU]
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for an NMU of "heaptrack", to fix its poor discoverability. It builds these binary packages: heaptrack - heap memory profiler for Linux heaptrack-gui - heap memory profiler for Linux libheaptrack - heap memory profiler for Linux To access further information about this package, please visit the following URL: https://mentors.debian.net/package/heaptrack Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/h/heaptrack/heaptrack_1.1.0+20180922.gitf752536-3.1.dsc More information about heaptrack can be obtained from https://github.com/KDE/heaptrack. Changes since the last upload: heaptrack (1.1.0+20180922.gitf752536-3.1) unstable; urgency=medium * Non-maintainer upload. * Update description to make heaptrack more discoverable to users. (Closes: #915241) -- Nicholas D Steeves Sun, 24 Feb 2019 19:44:03 -0700 heaptrack (1.1.0+20180922.gitf752536-3) unstable; urgency=medium I've updated the description for all three bin:packages, and I believe you will agree that the following diff fragment represents a significant improvement, and justifies the NMU (apt search keyword will find heaptrack): -Description: Heap memory profiler for Linux - Heap memory usage profiler. It uses LD_PRELOAD to track all - calls to the core memory allocation functions and logs these - occurrences. Additionally, backtraces are obtained and logged. +Description: heap memory profiler for Linux + Heap memory usage profiler. It uses LD_PRELOAD to track all calls + to the core memory allocation functions and logs these occurrences. + Additionally, backtraces are obtained and logged. It can also + generate a historigram of allocation sizes over the number of + calls. Heaptrack measures the following: . - The package contains command line tools. + * Heap memory consumption (like Massif). + * Number of calls to allocation functions (like callgrind). + * Total amount of memory allocated, ignoring deallocations. + * Leaked memory (like memcheck). + . + Heaptrack is notable for it's ability to attach to running processes, + for consuming substantially less memory than Valgrind, and for not + reducing an application's interactivity as much as Valgrind does. + Heaptrack is useful for debugging memory leaks and memory ballooning. + . + The package contains the command line tools. Regards, Nicholas