Bug#960831: about RFS: yiyantang
hi,Tobias, I had uploaded the new yiyantang package again today. Would you have time to review? https://mentors.debian.net/package/yiyantang/ Regards, xiao sheng wen Well, d/copyright is inconsistent with the source code. Please recheck and update it. For example: - Upstream code is GPL-2+, at least setty.c - Other files have same license, but different copyright holders. - Please ensure to quote the complete license boiler plate, (all 3 paragraphs; if necessary, change the FSF address. "*" can be stripped.) used GPL-2+, from yiyantang/README and I also checked the files under src directory. I had uploaded the new package, please help to review again. Cheers, xiao sheng wen -- 肖盛文 xiao sheng wen Faris Xiao 微信(wechat)：atzlinux 《铜豌豆 Linux》 基于 Debian 的 Linux 中文桌面操作系统：https://www.atzlinux.com Debian QA page: https://qa.debian.org/developer.php?login=atzlinux%40sina.com GnuPG Public Key: 0x339240CB
Bug#960831: about RFS: yiyantang
Control: tags -1 - moreinfo 在 2020/9/30 下午10:33, Tobias Frost 写道: > Ehm, well > *some* programming skill ought to be useful when maintaining packages. > Well, ok, you'll learn the skills, I'm sure. > >>> d/copyright: >>> - You need to have the complete GPL boiler plate in the License text. > This is still missing. added, I'm sorry for my English level, I didn't very understand the meaning of the word "boiler plate" last time. > Also, this is not a license text for GPL-2 > This package was debianized by Yu Guanghui on > Tue, 1 May 2001 22:23:01 +0800. deleted > >>> Note, if you license debian/* GPL-2*+* you need to have an extra >>> section for the different license. (GPL-2 != GPL-2+) >> used GPL-2 in this upload. debian/* used GPL-2+ >> Well, d/copyright is inconsistent with the source code. Please recheck >> and update it. For example: >> - Upstream code is GPL-2+, at least setty.c >> - Other files have same license, but different copyright holders. >> - Please ensure to quote the complete license boiler plate, >> (all 3 paragraphs; if necessary, change the FSF address. "*" can >>be stripped.) used GPL-2+, from yiyantang/README and I also checked the files under src directory. I had uploaded the new package, please help to review again. Cheers, xiao sheng wen signature.asc Description: OpenPGP digital signature
Bug#960831: about RFS: yiyantang
Control: moreinfo -1 On Wed, Sep 30, 2020 at 08:29:29PM +0800, xiao sheng wen wrote: > Hi, Tobias, > > Thanks for your review. > > I had uploaded the new package, please help to review again. > > 在 2020/9/29 下午10:44, Tobias Frost 写道: > > So, congrats for becoming de-facto* upstream then… ;-) > > > > (* due to maintaining a dead-upstream package) > > I'm planning to find the appropriate person to become the new upstream > in the Chinese open source community. > > But this finding need time, perhaps we have lucky. > > > Yes, I see*. But I fear that needs to be debugged and eventually > > be fixed or it will fly right into your face, at some point of time**… > > > > At the very least, config.guess and config.sub needs updating > > frequently. (See /usr/share/doc/autotools-dev/README.Debian.gz) > Read it. > > (* The reason for the failure seems to be in configure.in:59; but I did not > > try > > anything except commenting out that line; autoreconf suceeds then but > > configure > > fails later.) > > It's not a easy thing for me that change the code to use autoreconf and > let the rebuild package success . > > I'm not a programmer. :-( Ehm, well *some* programming skill ought to be useful when maintaining packages. Well, ok, you'll learn the skills, I'm sure. > > d/copyright: > > - You need to have the complete GPL boiler plate in the License text. This is still missing. Also, this is not a license text for GPL-2 This package was debianized by Yu Guanghui on Tue, 1 May 2001 22:23:01 +0800. > > Note, if you license debian/* GPL-2*+* you need to have an extra > > section for the different license. (GPL-2 != GPL-2+) > used GPL-2 in this upload. Well, d/copyright is inconsistent with the source code. Please recheck and update it. For example: - Upstream code is GPL-2+, at least setty.c - Other files have same license, but different copyright holders. - Please ensure to quote the complete license boiler plate, (all 3 paragraphs; if necessary, change the FSF address. "*" can be stripped.) > > - Please also mention the previous maintainers in the debian/* section. > I find the previous maintainers info from git log and added to the > d/copyright file. -- tobi
Bug#960831: about RFS: yiyantang
Hi, Tobias, Thanks for your review. I had uploaded the new package, please help to review again. 在 2020/9/29 下午10:44, Tobias Frost 写道: > So, congrats for becoming de-facto* upstream then… ;-) > > (* due to maintaining a dead-upstream package) I'm planning to find the appropriate person to become the new upstream in the Chinese open source community. But this finding need time, perhaps we have lucky. > Yes, I see*. But I fear that needs to be debugged and eventually > be fixed or it will fly right into your face, at some point of time**… > > At the very least, config.guess and config.sub needs updating > frequently. (See /usr/share/doc/autotools-dev/README.Debian.gz) Read it. > (* The reason for the failure seems to be in configure.in:59; but I did not > try > anything except commenting out that line; autoreconf suceeds then but > configure > fails later.) It's not a easy thing for me that change the code to use autoreconf and let the rebuild package success . I'm not a programmer. :-( > (**I'm not saying you need to fix that right away; maybe you are lucky and it > never explodes…) > > d/copyright: > - You need to have the complete GPL boiler plate in the License text. > Note, if you license debian/* GPL-2*+* you need to have an extra > section for the different license. (GPL-2 != GPL-2+) used GPL-2 in this upload. > - Please also mention the previous maintainers in the debian/* section. I find the previous maintainers info from git log and added to the d/copyright file. -- 肖盛文 xiao sheng wen Faris Xiao 微信(wechat)：atzlinux 《铜豌豆 Linux》 基于 Debian 的 Linux 中文桌面操作系统：https://www.atzlinux.com Debian QA page: https://qa.debian.org/developer.php?login=atzlinux%40sina.com GnuPG Public Key: 0x339240CB signature.asc Description: OpenPGP digital signature
Bug#960831: about RFS: yiyantang
On Tue, Sep 29, 2020 at 10:04:16AM +0800, xiao sheng wen (肖盛文) wrote: > Hi, Paul,Tobias, > > Thanks for your review. > > I had uploaded the new package, please help to review again. > > About the upstream: > > I can't find any forks that could be new upstream on Internet. So, congrats for becoming de-facto* upstream then… ;-) (* due to maintaining a dead-upstream package) > About the "not using autoreconf": > > If use autoreconf, the build will failed: > > automake: warning: autoconf input should be named 'configure.ac', not > 'configure.in' > autoreconf: automake failed with exit status: 1 > dh_autoreconf: error: autoreconf -f -i returned exit code 1 Yes, I see*. But I fear that needs to be debugged and eventually be fixed or it will fly right into your face, at some point of time**… At the very least, config.guess and config.sub needs updating frequently. (See /usr/share/doc/autotools-dev/README.Debian.gz) > The source code is old, it use configure.in. (* The reason for the failure seems to be in configure.in:59; but I did not try anything except commenting out that line; autoreconf suceeds then but configure fails later.) (**I'm not saying you need to fix that right away; maybe you are lucky and it never explodes…) fix-typo-patch -> Please s/type/typo also in the dep3 headers. [nitpick] d/copyright: - You need to have the complete GPL boiler plate in the License text. Note, if you license debian/* GPL-2*+* you need to have an extra section for the different license. (GPL-2 != GPL-2+) - Please also mention the previous maintainers in the debian/* section. d/rules [nitpick] - Please wrap the long lines. Please fix d/copyright and possibly also the nitpicks and I will take a look again. -- tobi
Bug#960831: about RFS: yiyantang
Hi, Paul,Tobias, Thanks for your review. I had uploaded the new package, please help to review again. About the upstream: I can't find any forks that could be new upstream on Internet. About the "not using autoreconf": If use autoreconf, the build will failed: automake: warning: autoconf input should be named 'configure.ac', not 'configure.in' autoreconf: automake failed with exit status: 1 dh_autoreconf: error: autoreconf -f -i returned exit code 1 The source code is old, it use configure.in. 在 2020/9/28 上午9:27, Paul Wise 写道: > On Sun, Sep 27, 2020 at 3:18 PM Tobias Frost wrote: > >> If upstream is gone and won't come back you can delete the watch file. > I suggest instead to keep the watch file, but add a comment mentioning > the upstream situation. > >> Did you look if there are any forks that could be new upstream? > It can also be a good idea to create a new upstream project or take > over the existing one if it is still there but not active. > -- 肖盛文 xiao sheng wen Faris Xiao 微信(wechat)：atzlinux 《铜豌豆 Linux》 基于 Debian 的 Linux 中文桌面操作系统：https://www.atzlinux.com Debian QA page: https://qa.debian.org/developer.php?login=atzlinux%40sina.com GnuPG Public Key: 0x339240CB signature.asc Description: OpenPGP digital signature
Bug#960831: about RFS: yiyantang
On Sun, Sep 27, 2020 at 3:18 PM Tobias Frost wrote: > If upstream is gone and won't come back you can delete the watch file. I suggest instead to keep the watch file, but add a comment mentioning the upstream situation. > Did you look if there are any forks that could be new upstream? It can also be a good idea to create a new upstream project or take over the existing one if it is still there but not active. -- bye, pabs https://wiki.debian.org/PaulWise
Bug#960831: about RFS: yiyantang
Control: tags -1 moreinfo On Sat, Sep 26, 2020 at 11:37:25AM +0800, xiao sheng wen 肖盛文 wrote: > Control: tags 960831 - moreinfo > > Hi Tobias Frost, > > I'm the maintainer of the package yiyantang , so I use NMU to upload > that is inappropiate before. OK > I'd uploaded the new version yiyangtang package on mentors[1], please > help to review again. > > yiyantang is very old package, It's upstream is not exist now. The watch > file is bare. > > The watch file like this, Is need to delete ? If upstream is gone and won't come back you can delete the watch file. Did you look if there are any forks that could be new upstream? Here's a review: - don't mark the bugs as "forwarded: not needed" if upstream is gone. Either ignore (not override) the lintian thingy, or mark write "forwarded: no, dead upstream." "not needed" is kind of reserved for Debian specific patches. The patch "fix-type-error" should be rather named "fix-typo" (with "o" instead of "e")… (the current name is confusing…) Why is the package not using autoreconf? It seems to use autotools… Cheers, tobi > Thanks for your mentor. > > > [1] https://mentors.debian.net/package/yiyantang/ > > -- > 肖盛文 xiao sheng wen Faris Xiao > 微信(wechat)：atzlinux > 《铜豌豆 Linux》 > 基于 Debian 的 Linux 中文桌面操作系统：https://www.atzlinux.com > Debian QA page: https://qa.debian.org/developer.php?login=atzlinux%40sina.com > GnuPG Public Key: 0x339240CB > >
Bug#960831: about RFS: yiyantang
Control: tags 960831 - moreinfo Hi Tobias Frost, I'm the maintainer of the package yiyantang , so I use NMU to upload that is inappropiate before. I'd uploaded the new version yiyangtang package on mentors[1], please help to review again. yiyantang is very old package, It's upstream is not exist now. The watch file is bare. The watch file like this, Is need to delete ? Thanks for your mentor. [1] https://mentors.debian.net/package/yiyantang/ -- 肖盛文 xiao sheng wen Faris Xiao 微信(wechat)：atzlinux 《铜豌豆 Linux》 基于 Debian 的 Linux 中文桌面操作系统：https://www.atzlinux.com Debian QA page: https://qa.debian.org/developer.php?login=atzlinux%40sina.com GnuPG Public Key: 0x339240CB signature.asc Description: OpenPGP digital signature
