Bug#969782: RFS: jag/0.3.8-1 -- arcade and puzzle 2D game
Hi Reiner, > I think the test is not yet working. > > jag is a graphical application, but you are not instructing autopkgtest > to start a (virtual) X server. > And even if this was working, what would this actually be testing? > > I think the autopkgtest is only passing because of the & which starts it > in the background (where it fails to start) and then the shell process exits > successfully? > > I would recommend to remove the test as it's currently not testing > anything (not even "superficially"). Writing a proper test for a game > is probablby quite difficult, though maybe someone else has a better > idea how this could be tested. I see, I removed the autopkgtest from the package. But in future updates I will see if I can deploy correctly. Whoever sponsors this package, I will be very grateful. Thanks! -- ⢀⣴⠾⠻⢶⣦⠀ Carlos Donizete Froes [a.k.a coringao] ⣾⠁⢠⠒⠀⣿⡁ Debian Wiki: https://wiki.debian.org/coringao ⢿⡄⠘⠷⠚⠋⠀ GPG: 4096R/B638B780 ⠈⠳⣄⠀⠀⠀ 2157 630B D441 A775 BEFF D35F FA63 ADA6 B638 B780 signature.asc Description: This is a digitally signed message part
Bug#969782: RFS: jag/0.3.8-1 -- arcade and puzzle 2D game
Hi Carlos, > The test added just does 'jag &' which does not provide significant > test coverage as is evident from the output. > > autopkgtest [21:14:03]: test command1: jag & > autopkgtest [21:14:03]: test command1: [--- > > qt.qpa.xcb: could not connect to display > qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though > it was > found. I think the test is not yet working. jag is a graphical application, but you are not instructing autopkgtest to start a (virtual) X server. And even if this was working, what would this actually be testing? I think the autopkgtest is only passing because of the & which starts it in the background (where it fails to start) and then the shell process exits successfully? I would recommend to remove the test as it's currently not testing anything (not even "superficially"). Writing a proper test for a game is probablby quite difficult, though maybe someone else has a better idea how this could be tested. Kind regards, Reiner signature.asc Description: PGP signature
Bug#969782: RFS: jag/0.3.8-1 -- arcade and puzzle 2D game
On Wed, Sep 9, 2020 at 3:02 AM Carlos Donizete Froes wrote: > > Hi Sudip Mukherjee, > > > The test added just does 'jag &' which does not provide significant > > > > > > Please add "Restrictions: superficial" to debian/tests/control. > > > > More details at: > > https://sources.debian.org/data/main/a/autopkgtest/5.14/doc/README.package-tests.rst > > I am very grateful to evaluate my package. I have only checked the autopkgtest, have not checked anything else. > > Added "Restrictions: superficial". Thanks. -- Regards Sudip
Bug#969782: RFS: jag/0.3.8-1 -- arcade and puzzle 2D game
Hi Sudip Mukherjee, > The test added just does 'jag &' which does not provide significant > > test coverage as is evident from the output. > > autopkgtest [21:14:03]: test command1: jag & > > autopkgtest [21:14:03]: test command1: [--- > > qt.qpa.xcb: could not connect to display > > qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though > it was > found. > > This application failed to start because no Qt platform plugin could be > initialized. > Reinstalling the application may fix this problem. > > Even though the test passes, it does not necessarily mean that the package > > under test is actually functional. > > Please add "Restrictions: superficial" to debian/tests/control. > > More details at: > https://sources.debian.org/data/main/a/autopkgtest/5.14/doc/README.package-tests.rst I am very grateful to evaluate my package. Added "Restrictions: superficial". I forgot to mention it in debian/changelog and added the bug FTCBFS has been fixed. (Closes: #958672) Thanks! -- ⢀⣴⠾⠻⢶⣦⠀ Carlos Donizete Froes [a.k.a coringao] ⣾⠁⢠⠒⠀⣿⡁ Debian Wiki: https://wiki.debian.org/coringao ⢿⡄⠘⠷⠚⠋⠀ GPG: 4096R/B638B780 ⠈⠳⣄⠀⠀⠀ 2157 630B D441 A775 BEFF D35F FA63 ADA6 B638 B780 signature.asc Description: This is a digitally signed message part
Bug#969782: RFS: jag/0.3.8-1 -- arcade and puzzle 2D game
Hi, On Mon, Sep 07, 2020 at 11:31:02PM -0300, Carlos Donizete Froes wrote: > Package: sponsorship-requests > Severity: normal > > Dear mentors, > > I am looking for a sponsor for my package "jag": > >* Added autopkgtest. The test added just does 'jag &' which does not provide significant test coverage as is evident from the output. autopkgtest [21:14:03]: test command1: jag & autopkgtest [21:14:03]: test command1: [--- qt.qpa.xcb: could not connect to display qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was found. This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem. Even though the test passes, it does not necessarily mean that the package under test is actually functional. Please add "Restrictions: superficial" to debian/tests/control. More details at: https://sources.debian.org/data/main/a/autopkgtest/5.14/doc/README.package-tests.rst -- Regards Sudip
Bug#969782: RFS: jag/0.3.8-1 -- arcade and puzzle 2D game
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "jag": * Package name: jag Version : 0.3.8-1 Upstream Author : XlabSoft & Industrial Infosystems * URL : https://gitlab.com/coringao/jag/wikis * License : GPL-3+ * Vcs : https://salsa.debian.org/games-team/jag Section : games It builds those binary packages: jag - arcade and puzzle 2D game To access further information about this package, please visit the following URL: https://mentors.debian.net/package/jag/ Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/j/jag/jag_0.3.8-1.dsc Changes since the last upload: jag (0.3.8-1) unstable; urgency=medium . * New upstream release: - All themes have been removed, except the default theme for reasons that are "freeware", but with additional Fasticon restrictions. * debian/control: + Switch to debhelper-compat = 13. - Package and Depends "jag-data" removed. * debian/jag-data.install removed. * Renamed "jag.install" to "install". * debian/install: Added the "data" directory. * Added debian/docs. * debian/rules: - Removed DEB_LDFLAGS_MAINT_APPEND. Fixed upstream. * Added autopkgtest. Regards, -- Carlos Donizete Froes [a.k.a coringao]
