Problems with autoconf in pftools
Hi, I try to package pftools[1]. Unfortunately autoreconf throws the following error: dh_autoreconf -O--no-parallel configure.ac:6: error: possibly undefined macro: AC_MSG_NOTICE If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation. configure.ac:51: error: possibly undefined macro: AC_SUBST autoreconf: /usr/bin/autoconf failed with exit status: 1 dh_autoreconf: autoreconf -f -i returned exit code 1 debian/rules:8: recipe for target 'build' failed Websearches resulted in adding pkg-config to Build-Depends but I admit I do not understand why this should help to find macros that are in autoconf doc - and it actually does not help. Any other hints to get this working? Kind regards Andreas. [1] https://anonscm.debian.org/git/debian-med/pftools.git -- http://fam-tille.de
Re: Problems with autoconf in pftools
Hi, On Mon, 27 Mar 2017 14:04:01 +0200 Andreas Tille wrote: > I try to package pftools[1]. Unfortunately autoreconf throws the > following error: > >dh_autoreconf -O--no-parallel > configure.ac:6: error: possibly undefined macro: AC_MSG_NOTICE > If this token and others are legitimate, please use > m4_pattern_allow. See the Autoconf documentation. > configure.ac:51: error: possibly undefined macro: AC_SUBST > autoreconf: /usr/bin/autoconf failed with exit status: 1 > dh_autoreconf: autoreconf -f -i returned exit code 1 > debian/rules:8: recipe for target 'build' failed > > > Websearches resulted in adding pkg-config to Build-Depends but I > admit I do not understand why this should help to find macros that > are in autoconf doc - and it actually does not help. Any other hints > to get this working? configure.ac uses the AX_PTHREAD macro, you need to build depend on autoconf-archive (which contains /usr/share/aclocal/ax_pthread.m4). Btw, brackets in lines 98-101 of configure.ac, where AX_PTHREAD is used, look really wrong (though I'm not an autoconf expert). Regards Lukas pgpg_GMJq13YK.pgp Description: OpenPGP digital signature
Re: Problems with autoconf in pftools
On Mon, Mar 27, 2017 at 07:43:15PM +0200, Lukas Schwaighofer wrote: > > configure.ac uses the AX_PTHREAD macro, you need to build depend on > autoconf-archive (which contains /usr/share/aclocal/ax_pthread.m4). Thanks. This helped over the autoconf hurdle. However, it sounds pretty strange why documented functions stop working since an extra macro set is missing. I'd call this bad (broken at design). > Btw, brackets in lines 98-101 of configure.ac, where AX_PTHREAD is used, > look really wrong (though I'm not an autoconf expert). Me (obviously) neither and since it works I do not see any reason to derive from upstream. Thanks a lot for your help Andreas. -- http://fam-tille.de
Re: Problems with autoconf in pftools
On Mon, Mar 27, 2017, at 17:28, Andreas Tille wrote: > Thanks. This helped over the autoconf hurdle. However, it sounds > pretty strange why documented functions stop working since an extra > macro set is missing. I'd call this bad (broken at design). Meh, no opinion on the design being broken or not, but it is a best practice to fully document all your autofoo dependencies textually somewhere, be it at the top of configure.ac, or in autogen.sh/bootstrap.sh, or in some sort of README or INSTALL file. Also, it is a best practice to distribute the copies of the autoconf-archive macros used by the project under m4/ (or some other subdir where the project stores its own autoconf macros, refer to AC_CONFIG_MACRO_DIR) for aclocal to pick them up when autoreconf'ing. Note that autoconf macros sourced from the autoconf archive have a standard header and they're versioned. There is no automated machinery to refresh them when outdated either upstream or in debian (no, autoreconf doesn't do it), so it has to be done manually. Don't downgrade such a macro, unless you really know what you are doing. -- Henrique de Moraes Holschuh
