RFS: battery-stats (updated package)
Dear mentors, I am looking for a sponsor for the new version 0.3.3-3 of my package "battery-stats". It builds these binary packages: battery-stats - collects statistics about charge of laptop batteries The package appears to be lintian clean. The upload would fix these bugs: 283984, 287230, 409825, 473820 The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/b/battery-stats - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/b/battery-stats/battery-stats_0.3.3-3.dsc I would be glad if someone uploaded this package for me. Kind regards Antonio Radici -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
RFS: battery-stats (updated package)
Dear mentors, I am looking for a sponsor for the new version 0.3.4-1 of my package "battery-stats". It builds these binary packages: battery-stats - collects statistics about charge of laptop batteries The package appears to be lintian clean. The upload would fix these bugs: 512701 The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/b/battery-stats - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/b/battery-stats/battery-stats_0.3.4-1.dsc I would be glad if someone uploaded this package for me. Kind regards Antonio Radici -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Re: RFS: battery-stats (updated package)
On Sat, Jan 17, 2009 at 18:26, Antonio Radici wrote: > Dear mentors, > > I am looking for a sponsor for the new version 0.3.3-3 > of my package "battery-stats". Checking -- Sandro Tosi (aka morph, morpheus, matrixhasu) My website: http://matrixhasu.altervista.org/ Me at Debian: http://wiki.debian.org/SandroTosi -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Re: RFS: battery-stats (updated package)
On Sat, Jan 17, 2009 at 18:31, Sandro Tosi wrote:
> On Sat, Jan 17, 2009 at 18:26, Antonio Radici wrote:
>> Dear mentors,
>>
>> I am looking for a sponsor for the new version 0.3.3-3
>> of my package "battery-stats".
>
> Checking
debian/rules:
- don't write the patch/unpatch targets explicitly but "include
/usr/share/dpatch/dpatch.make"
debian/patches/desc
- what's this file?
debian/control
- do you need a bump in gnuplot versioned depends because "gnuplot is
using a new syntax so it should be reflected in the command the
package uses" ?
- add ${misc:Depends} to Depends
- remove the extra (empty) line at the end of this file
- I think logrotate should be elected to Depends: what will happen if
it's missing and at install time the package wants to install its
logrotate rule file?
- I'd describe the bin programs in the packaeg in the long description
(battery-graph in the paragraph about the graph, and battery-log in
another (new) paragraph).
debian/copyright
- I'd separate clearly the copyright and license section with a proper header
- I'd use GPL-2 file for common-license reference (and hence GPLv2 in
the same paragraph)
debian/README.source
- missing, but policy 3.8.0 "should" its presence in case of patch system
debian/README
- I'd refresh the info in this file a bit
debian/watch
- what about adding one? if it makes sense given the situation; are
you even adopting it upstream?
There is a small issue when running battery-graph and the log file is empty:
$ battery-graph
gnuplot> plot "-" using ($1 - 946681200):2 smooth unique axis x1y1
title "Battery %" with lines linewidth 3
^
line 0: warning: Skipping data file with no valid points
There are some lintian message to fix:
$ lintian -I ../pbuilder/result/battery-stats_0.3.3-3_amd64.changes
I: battery-stats source: debian-watch-file-is-missing
W: battery-stats source: dh-clean-k-is-deprecated
I: battery-stats: hyphen-used-as-minus-sign
usr/share/man/man1/battery-graph.1.gz:86
I: battery-stats: hyphen-used-as-minus-sign
usr/share/man/man1/battery-graph.1.gz:89
I: battery-stats: hyphen-used-as-minus-sign
usr/share/man/man1/battery-graph.1.gz:93
I: battery-stats: hyphen-used-as-minus-sign
usr/share/man/man1/battery-graph.1.gz:96
I: battery-stats: hyphen-used-as-minus-sign
usr/share/man/man1/battery-graph.1.gz:99
I: battery-stats: hyphen-used-as-minus-sign
usr/share/man/man1/battery-graph.1.gz:103
I: battery-stats: hyphen-used-as-minus-sign
usr/share/man/man1/battery-graph.1.gz:106
I: battery-stats: hyphen-used-as-minus-sign
usr/share/man/man1/battery-graph.1.gz:110
I: battery-stats: hyphen-used-as-minus-sign
usr/share/man/man1/battery-graph.1.gz:113
I: battery-stats: hyphen-used-as-minus-sign
usr/share/man/man1/battery-graph.1.gz:116
I: battery-stats: hyphen-used-as-minus-sign
usr/share/man/man1/battery-graph.1.gz 3 more occurrences not shown
$ lintian -V
Lintian v2.1.5
They are all pretty simple to fix (the show stopper is dpatch.make
missing) and otherwise the package works fine (at least for the short
time it's running here). Please get back to me once you've uploaded
the package again (no revision bump) to mentors.
Regards,
--
Sandro Tosi (aka morph, morpheus, matrixhasu)
My website: http://matrixhasu.altervista.org/
Me at Debian: http://wiki.debian.org/SandroTosi
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Re: RFS: battery-stats (updated package)
Sandro Tosi wrote:
On Sat, Jan 17, 2009 at 18:31, Sandro Tosi wrote:
[snip]
debian/rules:
- don't write the patch/unpatch targets explicitly but "include
/usr/share/dpatch/dpatch.make"
Done
debian/patches/desc
- what's this file?
Sorry, I didn't spot this from the diffstat, it was just cruft.
debian/control
- do you need a bump in gnuplot versioned depends because "gnuplot is
using a new syntax so it should be reflected in the command the
package uses" ?
- add ${misc:Depends} to Depends
- remove the extra (empty) line at the end of this file
- I think logrotate should be elected to Depends: what will happen if
it's missing and at install time the package wants to install its
logrotate rule file?
- I'd describe the bin programs in the packaeg in the long description
(battery-graph in the paragraph about the graph, and battery-log in
another (new) paragraph).
All done.
debian/copyright
- I'd separate clearly the copyright and license section with a proper header
- I'd use GPL-2 file for common-license reference (and hence GPLv2 in
the same paragraph)
debian/README.source
- missing, but policy 3.8.0 "should" its presence in case of patch system
debian/README
- I'd refresh the info in this file a bit
Done, the missing files were also added.
debian/watch
- what about adding one? if it makes sense given the situation; are
you even adopting it upstream?
Unfortunately the upstream has no site which can be scanned, the current
source file can be downloaded directly from his website but there is no
index.html or Indexes in apache for previous or future source files.
Adopting the upstream is probably the wisest thing to do, rather than
keeping on patching the code via dpatch, probably in the next release I
will do so (it will also depends whether we will get any future bug
report or not)
There is a small issue when running battery-graph and the log file is empty:
$ battery-graph
gnuplot> plot "-" using ($1 - 946681200):2 smooth unique axis x1y1
title "Battery %" with lines linewidth 3
^
line 0: warning: Skipping data file with no valid points
Yes, I saw this but battery-graph is calling another script and gplot is
reading from stdin, if it's fine for you I'd prefer not to patch this
because I should change the flow of battery-graph and probably getting
the error before sending data to the pipe.
There are some lintian message to fix:
$ lintian -I ../pbuilder/result/battery-stats_0.3.3-3_amd64.changes
I: battery-stats source: debian-watch-file-is-missing
W: battery-stats source: dh-clean-k-is-deprecated
I: battery-stats: hyphen-used-as-minus-sign
[snip]
All fixed, apart from the watchfile, see above
They are all pretty simple to fix (the show stopper is dpatch.make
missing) and otherwise the package works fine (at least for the short
time it's running here). Please get back to me once you've uploaded
the package again (no revision bump) to mentors.
The new release without version bump is in mentor; thanks a lot for your
assistance, please let me know if you need any other change.
Looking forward to you reply.
Cheers
Antonio
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Re: RFS: battery-stats (updated package)
Hi Antonio, thanks for the fast reply On Sat, Jan 17, 2009 at 21:04, Antonio Radici wrote: > Sandro Tosi wrote: >> debian/control [8<] >> - I'd describe the bin programs in the packaeg in the long description >> (battery-graph in the paragraph about the graph, and battery-log in >> another (new) paragraph). I don't see anything about battery-log, but it's a minor glitch you can consider for the next upload >> debian/copyright >> - I'd separate clearly the copyright and license section with a proper >> header Mh, I was meant something like [1], but not a big problem. [1] http://packages.debian.org/changelogs/pool/main/m/mathomatic/mathomatic_14.0.6-2/mathomatic.copyright >> debian/README >> - I'd refresh the info in this file a bit You could at least state from what version it supports ACPI. >> There is a small issue when running battery-graph and the log file is >> empty: >> >> $ battery-graph >> >> gnuplot> plot "-" using ($1 - 946681200):2 smooth unique axis x1y1 >> title "Battery %" with lines linewidth 3 >> >> ^ >> line 0: warning: Skipping data file with no valid points > > Yes, I saw this but battery-graph is calling another script and gplot is > reading from stdin, if it's fine for you I'd prefer not to patch this > because I should change the flow of battery-graph and probably getting the > error before sending data to the pipe. It's only annoying, because with the default config of "flush=10" the user have to wait 10 mins to see a graph and sees only this error without knowing why. Better if you can fix it somehow, in the next releases. > The new release without version bump is in mentor; thanks a lot for your > assistance, please let me know if you need any other change. In general, it's better if you tend to write all your changes in debian/changelog file, even if minor or so: for example, Depends changes are not there. This helps *a lot* to identify problems or errors. Please do next time, because this has just been uploaded :) Thanks for your contribution to Debian, -- Sandro Tosi (aka morph, morpheus, matrixhasu) My website: http://matrixhasu.altervista.org/ Me at Debian: http://wiki.debian.org/SandroTosi -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Re: RFS: battery-stats (updated package)
On Tue, Jan 27, 2009 at 08:01:29PM +, Antonio Radici wrote: > Dear mentors, > > I am looking for a sponsor for the new version 0.3.4-1 > of my package "battery-stats". Hi, Since battery-stats 0.3.3-2 is in testing you shouldn't upload a new upstream release in unstable[1]. experimental is still an option. You can prepare a 0.3.3-3 package with just the fix for #512701, after the upload you'll have to ask the release team to accept this package in testing[1]. For your current 0.3.4-1 package, the best is to upload it in experimental but for the moment it still has some issue: - It FTBFS is gnuplot-nox is not installed - /usr/lib/battery-stats/graph-setup should be in /usr/share/battery-stats since it's an arch indep file - /usr/share/common-licenses/GPL is now a symlink to GPL-3, you need to adjust the debian/copyright - since you provide a menu file, can you please also add a .desktop and an icon [1]: http://article.gmane.org/gmane.linux.debian.devel.announce/1250 Best regards, Gonéri Le Bouder signature.asc Description: Digital signature
Re: RFS: battery-stats (updated package)
Gonéri Le Bouder wrote: On Tue, Jan 27, 2009 at 08:01:29PM +, Antonio Radici wrote: Dear mentors, I am looking for a sponsor for the new version 0.3.4-1 of my package "battery-stats". Hi, Since battery-stats 0.3.3-2 is in testing you shouldn't upload a new upstream release in unstable[1]. experimental is still an option. You can prepare a 0.3.3-3 package with just the fix for #512701, after the upload you'll have to ask the release team to accept this package in testing[1]. For your current 0.3.4-1 package, the best is to upload it in experimental but for the moment it still has some issue: - It FTBFS is gnuplot-nox is not installed - /usr/lib/battery-stats/graph-setup should be in /usr/share/battery-stats since it's an arch indep file - /usr/share/common-licenses/GPL is now a symlink to GPL-3, you need to adjust the debian/copyright - since you provide a menu file, can you please also add a .desktop and an icon Hi, thanks for your review, I will fix these problems tomorrow. Just to clarify the status of battery-stats: version 0.3.3-3 was *already* uploaded to unstable and it is not building on some arch due to the libacpi dependency. That's why I opened a bug against this package. I've taken over the upstream to incorporate the debian patches and move it to autotools, so the dependency will be managed by autotools and battery-stats will build on all architectures. Cheers Antonio -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Re: RFS: battery-stats (updated package)
On Thu, Jan 29, 2009 at 01:08:34AM +, Antonio Radici wrote: > Gonéri Le Bouder wrote: >> On Tue, Jan 27, 2009 at 08:01:29PM +, Antonio Radici wrote: > Hi, > thanks for your review, I will fix these problems tomorrow. > Just to clarify the status of battery-stats: version 0.3.3-3 was *already* > uploaded to > unstable and it is not building on some arch due to the libacpi dependency. > That's why > I opened a bug against this package. > > I've taken over the upstream to incorporate the debian patches and move it to > autotools, > so the dependency will be managed by autotools and battery-stats will build > on all > architectures. Ok, I see. I don't think the release team will accept a so import debdiff. linda:~/tmp$debdiff battery-stats_0.3.3-3.dsc battery-stats_0.3.4-1.dsc| wc -l 13569 I doubt release team will accept this in testing. If you want to see #512701 fixed in Lenny, you've to prepare a 0.3.3-4 upload with just the needed changes. Best regards, Gonéri signature.asc Description: Digital signature
Re: RFS: battery-stats (updated package)
Gonéri Le Bouder wrote: Ok, I see. I don't think the release team will accept a so import debdiff. linda:~/tmp$debdiff battery-stats_0.3.3-3.dsc battery-stats_0.3.4-1.dsc| wc -l 13569 I doubt release team will accept this in testing. If you want to see #512701 fixed in Lenny, you've to prepare a 0.3.3-4 upload with just the needed changes. Ok, let me clarify again :-) I don't care about uploading in lenny, lenny has battery-stats 0.3.3-2 which is the version released before battery-stats was orphaned, it was released by the QA group, it includes no ACPI support and so on, it is fine. Sid has my last release (0.3.3-3) which caused #512701, this is why I released this new version :-) Whether you want to put it in sid or experimental it's the same for me, in any case lenny will be fine because it will keep using the old and stable version. Cheers Antonio -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Re: RFS: battery-stats (updated package)
On Thu, Jan 29, 2009 at 03:29:52PM +, Antonio Radici wrote: > Sid has my last release (0.3.3-3) which caused #512701, this is why I > released this new version :-) Whether you want to put it in sid or > experimental it's the same for me, in any case lenny will be fine > because it will keep using the old and stable version. Fine, to be able to do a futur RC bug fix upload to should keep Sid synchronized with Testing. So please use experimental. Best regards, Gonéri signature.asc Description: Digital signature
Re: RFS: battery-stats (updated package)
Gonéri Le Bouder wrote: Since battery-stats 0.3.3-2 is in testing you shouldn't upload a new upstream release in unstable[1]. experimental is still an option. You can prepare a 0.3.3-3 package with just the fix for #512701, after the upload you'll have to ask the release team to accept this package in testing[1]. For your current 0.3.4-1 package, the best is to upload it in experimental but for the moment it still has some issue: - It FTBFS is gnuplot-nox is not installed - /usr/lib/battery-stats/graph-setup should be in /usr/share/battery-stats since it's an arch indep file - /usr/share/common-licenses/GPL is now a symlink to GPL-3, you need to adjust the debian/copyright - since you provide a menu file, can you please also add a .desktop and an icon Hi, I've fixed all these things, and added the icon into the upstream. Please let me know if there are other problems. Cheers Antonio -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Re: RFS: battery-stats (updated package)
On Thu, Jan 29, 2009 at 09:56:09PM +, Antonio Radici wrote: > Gonéri Le Bouder wrote: >> Since battery-stats 0.3.3-2 is in testing you shouldn't upload a new >> upstream release in unstable[1]. experimental is still an option. >> You can prepare a 0.3.3-3 package with just the fix for #512701, after >> the upload you'll have to ask the release team to accept this package in >> testing[1]. >> For your current 0.3.4-1 package, the best is to upload it in experimental >> but >> for the moment it still has some issue: >> - It FTBFS is gnuplot-nox is not installed >> - /usr/lib/battery-stats/graph-setup should be in >> /usr/share/battery-stats since it's an arch indep file >> - /usr/share/common-licenses/GPL is now a symlink to GPL-3, you need to >> adjust the debian/copyright >> - since you provide a menu file, can you please also add a .desktop and an >> icon >> > > Hi, > I've fixed all these things, and added the icon into the upstream. Hi Antonio. Hum, I can't see the .desktop file. Can you please add I and I'll upload the package. I attached some changes I did to fix two remaining errors. Please apply the patch: E: battery-stats: bad-test-in-menu-item /usr/share/menu/battery-stats:3 E: battery-stats: menu-icon-not-in-xpm-format /usr/share/battery-stats/pixmaps/battery-stats.png Best regards, Gonéri Le Bouder diff --git a/debian/changelog b/debian/changelog index f622df9..1aeeefe 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,4 +1,6 @@ battery-stats (0.3.4-1) experimental; urgency=low + + [ Antonio Radici ] * debianizing new upstream release which includes: + all debian patches + autotools packaging and optinal ACPI support @@ -14,6 +16,10 @@ battery-stats (0.3.4-1) experimental; urgency=low * debian/changelog + uploading on experimental + [ Gonéri Le Bouder ] + * debian menu want xpm icon, adjust the debian/rules to generate it +from the .png and add a builddeps on imagemagick + -- Antonio Radici Sun, 25 Jan 2009 12:36:18 + battery-stats (0.3.3-3) unstable; urgency=low diff --git a/debian/control b/debian/control index a00f692..1644d47 100644 --- a/debian/control +++ b/debian/control @@ -2,7 +2,7 @@ Source: battery-stats Section: admin Priority: extra Maintainer: Antonio Radici -Build-Depends: debhelper (>= 7), libapm-dev, libacpi-dev [i386 amd64 ia64], cdbs, autotools-dev, gnuplot-nox (>= 4) +Build-Depends: debhelper (>= 7), libapm-dev, libacpi-dev [i386 amd64 ia64], cdbs, autotools-dev, gnuplot-nox (>= 4), imagemagick Standards-Version: 3.8.0 Homepage: http://karl.jorgensen.com/battery-stats/ diff --git a/debian/rules b/debian/rules index fd5774c..c514a7a 100755 --- a/debian/rules +++ b/debian/rules @@ -3,4 +3,12 @@ include /usr/share/cdbs/1/rules/debhelper.mk include /usr/share/cdbs/1/class/autotools.mk -# Add here any variable or target overrides you need. +build/battery-stats:: + mogrify -format xpm -geometry 32x32 pixmaps/battery-stats.png + +clean:: + rm -f ./pixmaps/battery-stats.xpm + +install/battery-stats:: + cp pixmaps/battery-stats.xpm debian/battery-stats/usr/share/battery-stats/pixmaps/battery-stats.xpm + signature.asc Description: Digital signature
Re: RFS: battery-stats (updated package)
Gonéri Le Bouder wrote: Hum, I can't see the .desktop file. Can you please add I and I'll upload the package. I attached some changes I did to fix two remaining errors. Please apply the patch: E: battery-stats: bad-test-in-menu-item /usr/share/menu/battery-stats:3 E: battery-stats: menu-icon-not-in-xpm-format /usr/share/battery-stats/pixmaps/battery-stats.png Hi, thanks for your help, I've applied the patch and added a .desktop file. I've uploaded the package to mentors with the same version. Cheers Antonio -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Re: RFS: battery-stats (updated package)
On Sat, Jan 31, 2009 at 12:46:27PM +, Antonio Radici wrote: > Gonéri Le Bouder wrote: >> Hum, I can't see the .desktop file. Can you please add I and I'll upload the >> package. >> >> I attached some changes I did to fix two remaining errors. Please apply the >> patch: >> E: battery-stats: bad-test-in-menu-item /usr/share/menu/battery-stats:3 >> E: battery-stats: menu-icon-not-in-xpm-format >> /usr/share/battery-stats/pixmaps/battery-stats.png >> > > Hi, > thanks for your help, I've applied the patch and added a .desktop file. > I've uploaded the package to mentors with the same version. Hi Antonio, Uploaded. I did a minor change to adjust the .desktop destination directory, take care to use the version I upload for the next release Best regards, Gonéri Le Bouder signature.asc Description: Digital signature
