Re: RFS: dalle
Hi Alberto, > Hi, > > I've uploaded a new package for review. Summary: > - Cleaned changelog. Added a thaks to Mònica. > - All source files now have license header (I didn't know > licensecheck ...) > - Email sent to the Pkg-mono-devel mailing list for help, review and > sponsor. > - copyright file changed to DEP5 > Thanks a lot for taking all this into account. From this point of view, the package looks really fine now. I would, however, hope that someone from pkg-mono-devel takes the time to review your package from a mono perspective and sponsor afterwards. > I've one question about licenses, as author of the software. > > I've taken some Apache-2 licensed code on dalle (GPL3). I've ported the > java code to c# (trivial). How do I have to license that files? > [...] Maybe someone else on this list knows (I don't), but probably asking on debian-le...@lists.debian.org is a much safer bet. I'd hope you can fine someone good knowledge on that list. Hope this helps, Michael pgptv30SWOBVd.pgp Description: PGP signature
Re: RFS: dalle
Hi, I've uploaded a new package for review. Summary: - Cleaned changelog. Added a thaks to Mònica. - All source files now have license header (I didn't know licensecheck ...) - Email sent to the Pkg-mono-devel mailing list for help, review and sponsor. - copyright file changed to DEP5 I've one question about licenses, as author of the software. I've taken some Apache-2 licensed code on dalle (GPL3). I've ported the java code to c# (trivial). How do I have to license that files? Thanks El dom, 07-11-2010 a las 22:12 +0100, Michael Tautschnig escribió: > Hi all, > > [...] > > > > > > > > > If any other person from the list see a mistake in my review, > > > > > "reviews of my review" are welcomed! > > > > > > > First of all: Thanks a lot Mònica for reviewing this package. I'd just like to > add a bit of information: > > - Several files lack license/copyright information. This is essential for > making > your software freely distributable. You might want to use licensecheck to > find > them more easily. > - There is not point in maintaining such a debian/changelog for a not-yet > uploaded Debian package (and, in fact, most of these entries don't tell that > much). A single entry will suffice this time, although you might want to > thank Mònica as well, as suggested in [1]. > - Have you worked your way through the Mono Group Policy [2]? > > > > > > > > > Is there someone with experience packaging CLI apps to review the > > > > package? > > > > > I think there is still another review by such a person needed as myself I feel > unable to check appropriateness of CLI-specific stuff. Alberto, could you > please > review the Mono Group Policy [2] and check whom to contact? There is at least > the pkg-mono-devel mailing list, and maybe more. > > Hope this helps, > Michael > > [1] http://lists.debian.org/debian-mentors/2010/11/msg00084.html > [2] http://pkg-mono.alioth.debian.org/docs/policy.html > -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/1289427072.4920.15.ca...@localhost
Re: RFS: dalle
Hi all, [...] > > > > > > If any other person from the list see a mistake in my review, "reviews > > > > of my review" are welcomed! > > > > First of all: Thanks a lot Mònica for reviewing this package. I'd just like to add a bit of information: - Several files lack license/copyright information. This is essential for making your software freely distributable. You might want to use licensecheck to find them more easily. - There is not point in maintaining such a debian/changelog for a not-yet uploaded Debian package (and, in fact, most of these entries don't tell that much). A single entry will suffice this time, although you might want to thank Mònica as well, as suggested in [1]. - Have you worked your way through the Mono Group Policy [2]? > > > > > > Is there someone with experience packaging CLI apps to review the > > > package? > > I think there is still another review by such a person needed as myself I feel unable to check appropriateness of CLI-specific stuff. Alberto, could you please review the Mono Group Policy [2] and check whom to contact? There is at least the pkg-mono-devel mailing list, and maybe more. Hope this helps, Michael [1] http://lists.debian.org/debian-mentors/2010/11/msg00084.html [2] http://pkg-mono.alioth.debian.org/docs/policy.html pgpxC482YAlAn.pgp Description: PGP signature
Re: RFS: dalle
El jue, 04-11-2010 a las 10:11 +0100, Mònica escribió: > On Wednesday 03 November 2010 at 23:23:54, Alberto Fernández wrote: > > El mié, 03-11-2010 a las 10:55 +0100, Mònica escribió: > > > > Thanks very much for your help. > > I've just uploaded a fixed package with your suggestions. > > :-) > > > > I'm not a DD, but here's my review for your package: > > > The review is about the Debian package source, I haven't reviewed how the > > > program works. > > > > > > * Lintian: I: dalle source: missing-debian-source-format > > > - You shopuld have the file debian/source/format indicating your > > > package source format. > > > Now, it's recommended switching to "3.0 (quilt)". > > > > I don't know why lintian didn't warn this to me ? > > lintian -i -I --show-overrides package > > If you use debuild you can use its configuration file .devscripts: > DEBUILD_LINTIAN=yes > DEBUILD_LINTIAN_OPTS="-i -I --show-overrides" > > Now you have another lintian warning: > I: dalle source: debian-watch-file-is-missing > > So, you should add a watch file. > > > > * debian/rules: > > > - Delete comment lines that are not your own comments like "Sample > > > debian/rules...". > > > - You can install files with the file debian/install, so you can delete > > > "cp" lines and your > > > debian/rules will be more simple. > > > - You can install manpages with files dalle.manpages or putting them in > > > debian directory > > > with namepacke.1 (or the corresponding number) > > > > Rules cleaned :) > > In case you don't know it, you can make packages with "dh $@". Your > debian/rules would be sitll nore simple. You can read about it in the "Debian > New Maintainers' Guide" [1]. > > > > > > > * debian/control > > > - Some spelling mistakes in the long description: splited -> split, > > > Dalle support -> Dalle suports > > > > It's my horrible English. I must practice. > > Me too :-) > > > > I hope my advises help you :-) > > Thank you. > > Not at all! I love helping :-) > > > > If any other person from the list see a mistake in my review, "reviews of > > > my review" are welcomed! > > > > > > > Is there someone with experience packaging CLI apps to review the > > package? > > Cheers. > > > [1] http://www.debian.org/doc/maint-guide/ > I've uploaded the package again with "dh $@". Note: the Spanish version of maint-guide doesn't contain the new "dh $@" section -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/1288988517.4069.25.ca...@localhost
Re: RFS: dalle
On Friday 05 November 2010 at 00:26:51, Alberto Fernández wrote: > El jue, 04-11-2010 a las 10:11 +0100, Mònica escribió: > > On Wednesday 03 November 2010 at 23:23:54, Alberto Fernández wrote: > > > El mié, 03-11-2010 a las 10:55 +0100, Mònica escribió: [...] > > > I don't know why lintian didn't warn this to me ? > > > > lintian -i -I --show-overrides package > > > > If you use debuild you can use its configuration file .devscripts: > > DEBUILD_LINTIAN=yes > > DEBUILD_LINTIAN_OPTS="-i -I --show-overrides" > > I was using dpkg-buildpackage and calling lintian manually with "-i -v > --pedantic". I've switched to debbuild. Excuse me. I forgot the --pedantic option. It should be: $ lintian -i -I --show-overrides --pedantic package or if you use debuild, in .devscripts add: DEBUILD_LINTIAN=yes DEBUILD_LINTIAN_OPTS="-i -I --show-overrides --pedantic" -- Mònica signature.asc Description: This is a digitally signed message part.
Re: RFS: dalle
El jue, 04-11-2010 a las 10:11 +0100, Mònica escribió: > On Wednesday 03 November 2010 at 23:23:54, Alberto Fernández wrote: > > El mié, 03-11-2010 a las 10:55 +0100, Mònica escribió: > > > > Thanks very much for your help. > > I've just uploaded a fixed package with your suggestions. > > :-) > > > > I'm not a DD, but here's my review for your package: > > > The review is about the Debian package source, I haven't reviewed how the > > > program works. > > > > > > * Lintian: I: dalle source: missing-debian-source-format > > > - You shopuld have the file debian/source/format indicating your > > > package source format. > > > Now, it's recommended switching to "3.0 (quilt)". > > > > I don't know why lintian didn't warn this to me ? > > lintian -i -I --show-overrides package > > If you use debuild you can use its configuration file .devscripts: > DEBUILD_LINTIAN=yes > DEBUILD_LINTIAN_OPTS="-i -I --show-overrides" I was using dpkg-buildpackage and calling lintian manually with "-i -v --pedantic". I've switched to debbuild. > > Now you have another lintian warning: > I: dalle source: debian-watch-file-is-missing > > So, you should add a watch file. > Fixed! > > > * debian/rules: > > > - Delete comment lines that are not your own comments like "Sample > > > debian/rules...". > > > - You can install files with the file debian/install, so you can delete > > > "cp" lines and your > > > debian/rules will be more simple. > > > - You can install manpages with files dalle.manpages or putting them in > > > debian directory > > > with namepacke.1 (or the corresponding number) > > > > Rules cleaned :) > > In case you don't know it, you can make packages with "dh $@". Your > debian/rules would be sitll nore simple. You can read about it in the "Debian > New Maintainers' Guide" [1]. I've to learn about it. Next week. > > > > > > > * debian/control > > > - Some spelling mistakes in the long description: splited -> split, > > > Dalle support -> Dalle suports > > > > It's my horrible English. I must practice. > > Me too :-) > > > > I hope my advises help you :-) > > Thank you. > > Not at all! I love helping :-) > > > > If any other person from the list see a mistake in my review, "reviews of > > > my review" are welcomed! > > > > > > > Is there someone with experience packaging CLI apps to review the > > package? > > Cheers. > > > [1] http://www.debian.org/doc/maint-guide/ > -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/1288913211.6239.70.ca...@localhost
Re: RFS: dalle
Hi Thomas, First of all, thanks for your suggestions. El jue, 04-11-2010 a las 21:33 +0800, Thomas Goirand escribió: > On 11/03/2010 08:23 AM, Alberto Fernández wrote:Kind regards > > > Alberto Fernández > > > > Hi Alberto, > > I don't have the intention to sponsor the package, but I just wanted > to help a bit with it. > > Having a quick look in your package, it seems that your debian/copyright > doesn't include all the upstream author. See by yourself the output > of grep -r -i \(c\) * > > src/ui/console/openhacha-text/src/openhachatextgui.cs:Copyright (C) > 2003 Ram�n Rey Vicente > Oops, I forgot to copy authors from AUTHORS file. > I have also find some people not referenced in the Documentation: > > documentacion/es/formatos_txt/maxsplitter.txt:rem Copyright (c) Max > Bylesj� 2001 > documentacion/es/formatos_txt/EasyFileSplit v1.5.txt:Echo Create with > the FREEWARE VERSION EASY SPLIT. (c) Dirk Paehl > documentacion/es/formatos_txt/EasyFileSplit v1.5.txt:Echo Create with > the FREEWARE VERSION EASY SPLIT. (c) Dirk Paehl They are in txt files containing samples of scripts generated by other proprietary software. They are not relative to any code. Anyway, I've deleted this lines. > > These seems to be under GPL v2 (please check, I only had a quick look). The program is GPL v3. Trust me. I'm the author :). It have portions of code taken from other projects under Apache / public domain / GPL licenses. I think there is no problem on it. If anybody knows more about this who can help ... > > Please correct this in your next upload. > > Also, your debian/docs references NEWS, which should in fact be packaged > in your binary-common, like this: > > dh_installchangelogs ChangeLog NEWS Fixed. > > Also, there's no "binary-arch" target. Is that normal? Is there something > that I missed that changed in the way to build packages in Debian? > I've deleted it , sorry. The work is done in binary-indep, and I deleted binary-arch instead leaving it empty. Fixed. > Thomas > -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/1288913067.6239.67.ca...@localhost
Re: RFS: dalle
On Wednesday 03 November 2010 at 23:23:54, Alberto Fernández wrote: > El mié, 03-11-2010 a las 10:55 +0100, Mònica escribió: > > Thanks very much for your help. > I've just uploaded a fixed package with your suggestions. :-) > > I'm not a DD, but here's my review for your package: > > The review is about the Debian package source, I haven't reviewed how the > > program works. > > > > * Lintian: I: dalle source: missing-debian-source-format > > - You shopuld have the file debian/source/format indicating your > > package source format. > > Now, it's recommended switching to "3.0 (quilt)". > > I don't know why lintian didn't warn this to me ? lintian -i -I --show-overrides package If you use debuild you can use its configuration file .devscripts: DEBUILD_LINTIAN=yes DEBUILD_LINTIAN_OPTS="-i -I --show-overrides" Now you have another lintian warning: I: dalle source: debian-watch-file-is-missing So, you should add a watch file. > > * debian/rules: > > - Delete comment lines that are not your own comments like "Sample > > debian/rules...". > > - You can install files with the file debian/install, so you can delete > > "cp" lines and your > > debian/rules will be more simple. > > - You can install manpages with files dalle.manpages or putting them in > > debian directory > > with namepacke.1 (or the corresponding number) > > Rules cleaned :) In case you don't know it, you can make packages with "dh $@". Your debian/rules would be sitll nore simple. You can read about it in the "Debian New Maintainers' Guide" [1]. > > > > * debian/control > > - Some spelling mistakes in the long description: splited -> split, > > Dalle support -> Dalle suports > > It's my horrible English. I must practice. Me too :-) > > I hope my advises help you :-) > Thank you. Not at all! I love helping :-) > > If any other person from the list see a mistake in my review, "reviews of > > my review" are welcomed! > > > > Is there someone with experience packaging CLI apps to review the > package? Cheers. [1] http://www.debian.org/doc/maint-guide/ -- Mònica "Normalment, només se'ns reconeix el dret de pensar quan pensem dins d'un dels corrents que cada època considera legítims; és a dir quan pensem el menys possible." Manuel de Pedrolo signature.asc Description: This is a digitally signed message part.
English localisation help for Debian package maintainers (was: RFS: dalle)
Alberto Fernández writes: > It's my horrible English. I must practice. […] > The comment is now in English and localized to Spanish to. Feel free to request help with English-language localisation on the appropriate forum http://lists.debian.org/debian-l10n-english/> for any of your Debian packaging work. -- \ “The best way to get information on Usenet is not to ask a | `\ question, but to post the wrong information.” —Aahz | _o__) | Ben Finney -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/87k4kugd5f.fsf...@benfinney.id.au
Re: RFS: dalle
El mié, 03-11-2010 a las 10:55 +0100, Mònica escribió: Thanks very much for your help. I've just uploaded a fixed package with your suggestions. > Hello, > > On Wednesday 03 November 2010 at 01:23:13, Alberto Fernández wrote: > > Dear mentors, > > > > I am looking for a sponsor for my package "dalle". > > > > * Package name: dalle > > Version : 0.10.11 > > Upstream Author : Alberto Fernández Martínez > > * URL : http://dalle.sourceforge.net > > * License : GPL3 > > Section : utils > > > > It builds these binary packages: > > dalle - File management tool > > > > The upload would fix these bugs : 599851 > [...] > > I'm not a DD, but here's my review for your package: > The review is about the Debian package source, I haven't reviewed how the > program works. > > * Lintian: I: dalle source: missing-debian-source-format > - You shopuld have the file debian/source/format indicating your > package source format. > Now, it's recommended switching to "3.0 (quilt)". I don't know why lintian didn't warn this to me ? > > * Lintian: W: dalle: latest-debian-changelog-entry-changed-to-native > - In your changelog the dalle version is 0.10.11. Dalle is not a Debian > native program, so it should be > 0.10.11-1 to indicate the Debian revision. > - Moreover, I don't know if you should keep the previous changes before > uploading the Debian. > Maybe someone else can help us int this point... I was not sure if dalle should be a "native" program. Now I'm sure no. > * debian/rules: > - Delete comment lines that are not your own comments like "Sample > debian/rules...". > - You can install files with the file debian/install, so you can delete > "cp" lines and your > debian/rules will be more simple. > - You can install manpages with files dalle.manpages or putting them in > debian directory > with namepacke.1 (or the corresponding number) Rules cleaned :) > > * debian/control > - Some spelling mistakes in the long description: splited -> split, > Dalle support -> Dalle suports It's my horrible English. I must practice. > > * debian/dalle-doc.files, dalle-doc.docs > - What are these files for? You have the debian/docs file that seems to > do what you want. Deleted. > > * debian/docs > - You are installing the file formatos_soportados.txt. > I think this file name should be in English as well as its content. Translated. Pending to translate NEWS. > > * debian/dirs > - Using debian/install, maybe you won't need this file. Replaced by debian/install > > * debian/dalle-gtk.desktop > - The comment is in Spanish, it should be en English. The comment is now in English and localized to Spanish to. > > I hope my advises help you :-) Thank you. > If any other person from the list see a mistake in my review, "reviews of my > review" are welcomed! > Is there someone with experience packaging CLI apps to review the package? > Cheers. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/1288823034.4189.9.ca...@localhost
Re: RFS: dalle
On Wed, Nov 03, 2010 at 10:55:49AM +0100, Mònica wrote: > * debian/control > - Some spelling mistakes in the long description: splited -> split, > Dalle support -> Dalle suports ^^^ supports -- Jonathan Wiltshire 4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC 74C3 5394 479D D352 4C51 -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101103094905.ga5...@lupin.powdarrmonkey.net
Re: RFS: dalle
Hello, On Wednesday 03 November 2010 at 01:23:13, Alberto Fernández wrote: > Dear mentors, > > I am looking for a sponsor for my package "dalle". > > * Package name: dalle > Version : 0.10.11 > Upstream Author : Alberto Fernández Martínez > * URL : http://dalle.sourceforge.net > * License : GPL3 > Section : utils > > It builds these binary packages: > dalle - File management tool > > The upload would fix these bugs : 599851 [...] I'm not a DD, but here's my review for your package: The review is about the Debian package source, I haven't reviewed how the program works. * Lintian: I: dalle source: missing-debian-source-format - You shopuld have the file debian/source/format indicating your package source format. Now, it's recommended switching to "3.0 (quilt)". * Lintian: W: dalle: latest-debian-changelog-entry-changed-to-native - In your changelog the dalle version is 0.10.11. Dalle is not a Debian native program, so it should be 0.10.11-1 to indicate the Debian revision. - Moreover, I don't know if you should keep the previous changes before uploading the Debian. Maybe someone else can help us int this point... * debian/rules: - Delete comment lines that are not your own comments like "Sample debian/rules...". - You can install files with the file debian/install, so you can delete "cp" lines and your debian/rules will be more simple. - You can install manpages with files dalle.manpages or putting them in debian directory with namepacke.1 (or the corresponding number) * debian/control - Some spelling mistakes in the long description: splited -> split, Dalle support -> Dalle suports * debian/dalle-doc.files, dalle-doc.docs - What are these files for? You have the debian/docs file that seems to do what you want. * debian/docs - You are installing the file formatos_soportados.txt. I think this file name should be in English as well as its content. * debian/dirs - Using debian/install, maybe you won't need this file. * debian/dalle-gtk.desktop - The comment is in Spanish, it should be en English. I hope my advises help you :-) If any other person from the list see a mistake in my review, "reviews of my review" are welcomed! Cheers. -- Mònica "Normalment, només se'ns reconeix el dret de pensar quan pensem dins d'un dels corrents que cada època considera legítims; és a dir quan pensem el menys possible." Manuel de Pedrolo signature.asc Description: This is a digitally signed message part.
RFS: dalle
Dear mentors, I am looking for a sponsor for my package "dalle". * Package name: dalle Version : 0.10.11 Upstream Author : Alberto Fernández Martínez * URL : http://dalle.sourceforge.net * License : GPL3 Section : utils It builds these binary packages: dalle - File management tool The upload would fix these bugs : 599851 My motivation for maintaining this package is: This program join and extract files from a variety of formats (mainly small programs "file splitters" for Windows), so you can use this archives from Linux. (Note: I'm the original author of dalle) The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/d/dalle - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/d/dalle/dalle_0.10.11.dsc I would be glad if someone uploaded this package for me. Kind regards Alberto Fernández -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/1288743793.4320.8.ca...@localhost
RFS: dalle
Dear mentors, I am looking for a sponsor for my package "dalle". * Package name: dalle Version : 0.10.11 Upstream Author : Alberto Fernández Martínez * URL : http://dalle.sourceforge.net * License : GPL3 Section : utils It builds these binary packages: dalle - File management tool The upload would fix these bugs : 599851 My motivation for maintaining this package is: This program join and extract files from a variety of formats (mainly small programs "file splitters" for Windows), so you can use this archives from Linux. (Note: I'm the original author of dalle) The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/d/dalle - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/d/dalle/dalle_0.10.11.dsc I would be glad if someone uploaded this package for me. Kind regards Alberto Fernández -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/1288744421.4320.9.ca...@localhost
