RFS: gtkvncviewer
Dear mentors, I am looking for a sponsor for my package "gtkvncviewer". * Package name: gtkvncviewer Version : 0.2.2 Upstream Author : Clement Lorteau <[EMAIL PROTECTED]> * URL : https://launchpad.net/gtkvncviewer * License : GPL Section : utils It builds these binary packages: gtkvncviewer - Small GTK tool to connect to VNC servers. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/g/gtkvncviewer - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/g/gtkvncviewer/gtkvncviewer_0.2.2.dsc I would be glad if someone uploaded this package for me. Thanks ! Kind regards, Clement Lorteau
RFS: gtkvncviewer
Dear mentors, I am looking for a sponsor for my package "gtkvncviewer". * Package name: gtkvncviewer Version : 0.2.2-1 Upstream Author : Clement Lorteau <[EMAIL PROTECTED]> * URL : https://launchpad.net/gtkvncviewer * License : GPLv2 Section : utils It builds these binary packages: gtkvncviewer - Small GTK tool to connect to VNC servers. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/g/gtkvncviewer - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/g/gtkvncviewer/gtkvncviewer_0.2.2-1.dsc I would be glad if someone uploaded this package for me. I sent such a request last month and got a comment, which I acted upon, but it seems then the package got forgotten. That would be great if someone could have a new look at it. Kind regards Clement Lorteau -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Re: RFS: gtkvncviewer
Please provide a reason for why this should be a native package or repackage it as non-native. See http://people.debian.org/~mpalmer/debian-mentors_FAQ.html#native_vs_non_native for further information. Helmut -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Re: RFS: gtkvncviewer
Hi On Tue, 6 May 2008 10:18:33 +0200 "Clement Lorteau" <[EMAIL PROTECTED]> wrote: > Dear mentors, > > I am looking for a sponsor for my package "gtkvncviewer". > > * Package name: gtkvncviewer > Version : 0.2.2-1 > Upstream Author : Clement Lorteau <[EMAIL PROTECTED]> > * URL : https://launchpad.net/gtkvncviewer > * License : GPLv2 > Section : utils > > It builds these binary packages: > gtkvncviewer - Small GTK tool to connect to VNC servers. > > The package can be found on mentors.debian.net: > - URL: http://mentors.debian.net/debian/pool/main/g/gtkvncviewer > - Source repository: deb-src http://mentors.debian.net/debian unstable > main contrib non-free > - dget > http://mentors.debian.net/debian/pool/main/g/gtkvncviewer/gtkvncviewer_0.2.2-1.dsc > > I would be glad if someone uploaded this package for me. I sent such a > request last month and got a comment, which I acted upon, but it seems > then the package got forgotten. That would be great if someone could > have a new look at it. Just a quick look: - debian/changelog format looks strange - debian/control - Homepage is missing - why do you depend on libgnome-keyring0? - use pycentral or pysupport and ${python:Depends} instead of depending on python2.5 - why does description start with empty line? - try to describe package more than just one sentence - debian/rules - do not use mkdir, install, use dh_install instead - no need for configure target if it is not used - no need to set CFLAGS, you don't compile anything - please remove commented out things - package should be built by binary-indep as it is arch all - you should not pass debian/changelog to dh_installchangelogs - debian/dirs is IMHO not needed at all - debian/copyright - upstream tarball does not indicate that the package is GPL, try contacting upstream to include license information in package - "This package was py2debianized(0.3-gtkvncviewer)"? - please use lintian: $ lintian gtkvncviewer_0.2.2-1_i386.changes W: gtkvncviewer source: binary-arch-rules-but-pkg-is-arch-indep W: gtkvncviewer: binary-without-manpage usr/bin/gtkvncviewer I: gtkvncviewer: desktop-entry-contains-encoding-key /usr/share/applications/data/gtkvncviewer.desktop:2 Encoding W: gtkvncviewer: description-synopsis-might-not-be-phrased-properly W: gtkvncviewer: spelling-error-in-description GTK GTK+ W: gtkvncviewer: spelling-error-in-description GTK GTK+ W: gtkvncviewer: new-package-should-close-itp-bug -- Michal Čihař | http://cihar.com | http://blog.cihar.com signature.asc Description: PGP signature
Re: RFS: gtkvncviewer
On Tue, 6 May 2008 10:18:33 +0200 "Clement Lorteau" <[EMAIL PROTECTED]> wrote: > Dear mentors, > > I am looking for a sponsor for my package "gtkvncviewer". > > * Package name: gtkvncviewer > Version : 0.2.2-1 > Upstream Author : Clement Lorteau <[EMAIL PROTECTED]> > * URL : https://launchpad.net/gtkvncviewer > * License : GPLv2 > Section : utils > > It builds these binary packages: > gtkvncviewer - Small GTK tool to connect to VNC servers. > > The package can be found on mentors.debian.net: > - URL: http://mentors.debian.net/debian/pool/main/g/gtkvncviewer > - Source repository: deb-src http://mentors.debian.net/debian unstable > main contrib non-free > - dget > http://mentors.debian.net/debian/pool/main/g/gtkvncviewer/gtkvncviewer_0.2.2-1.dsc > > I would be glad if someone uploaded this package for me. I sent such a > request last month and got a comment, which I acted upon, but it seems > then the package got forgotten. That would be great if someone could > have a new look at it. Also gtkvncviewer_0.2.2.orig.tar.gz should match upstream tarball which it does not (md5 is different). -- Michal Čihař | http://cihar.com | http://blog.cihar.com signature.asc Description: PGP signature
Re: rfs: gtkvncviewer
Hi On Wed, 7 May 2008 10:38:29 +0200 "Clement Lorteau" <[EMAIL PROTECTED]> wrote: > Thanks for the comments. I made all the changes you mentioned. Would > you (or someone else) mind checking the new package ? > > I also have a question: should I file an ITP, as your Lintian mentions > (my Lintian is provided by Ubuntu)? Definitely. > The package can be found on mentors.debian.net: > - URL: http://mentors.debian.net/debian/pool/main/g/gtkvncviewer > - Source repository: deb-src http://mentors.debian.net/debian unstable > main contrib non-free > - dget > http://mentors.debian.net/debian/pool/main/g/gtkvncviewer/gtkvncviewer_0.2.3-1.dsc Few more thoughts: debian/rules - please install docs by dh_installdocs (and use debian/gtkvncviewer.docs for this), no need to install LICENSE (debian/copyright is there for this purposse) - please install CHANGELOG by dh_installchangelog - I'd prefer to have single dh_install call and having all files listed in debian/gtkvncviewer.install) > > I: gtkvncviewer: > > desktop-entry-contains-encoding-key > > /usr/share/applications/data/gtkvncviewer.desktop:2 Encoding > > W: gtkvncviewer: description-synopsis-might-not-be-phrased-properly > > W: gtkvncviewer: spelling-error-in-description GTK GTK+ > > W: gtkvncviewer: spelling-error-in-description GTK GTK+ > That's part of the name of the program Then please add overrides for this (or consider full name of program to contain GTK+ as this is correct name). Anyway can you please install lintian from unstable and use it? It would save us lot of time: I: gtkvncviewer source: build-depends-without-arch-dep python-central W: gtkvncviewer: manpage-has-bad-whatis-entry usr/share/man/man1/gtkvncviewer.1.gz W: gtkvncviewer: extra-license-file usr/share/doc/gtkvncviewer/LICENSE.gz I: gtkvncviewer: desktop-entry-contains-encoding-key /usr/share/applications/data/gtkvncviewer.desktop:2 Encoding W: gtkvncviewer: description-synopsis-might-not-be-phrased-properly W: gtkvncviewer: extended-description-line-too-long W: gtkvncviewer: extended-description-line-too-long W: gtkvncviewer: spelling-error-in-description GTK GTK+ W: gtkvncviewer: spelling-error-in-description GTK GTK+ W: gtkvncviewer: changelog-file-not-compressed CHANGELOG W: gtkvncviewer: wrong-name-for-upstream-changelog usr/share/doc/gtkvncviewer/CHANGELOG W: gtkvncviewer: new-package-should-close-itp-bug -- Michal Čihař | http://cihar.com | http://blog.cihar.com signature.asc Description: PGP signature
Re: rfs: gtkvncviewer
Hi Dne Thu, 8 May 2008 00:24:37 +0200 "Clement Lorteau" <[EMAIL PROTECTED]> napsal(a): > I followed them all and uploaded the new package to > debian.mentors.net, could the package get another look ? Contents of > the RFS does not change, except "The upload would fix these bugs: > 480055" which is the newly filed ITP. > > Thank you for your help. Looks much better now, good work! Now I only see two minor lintian warnings: $ lintian -I ../gtkvncviewer_0.2.3-1_i386.changes I: gtkvncviewer source: build-depends-without-arch-dep python-central I: gtkvncviewer: desktop-entry-contains-encoding-key /usr/share/applications/data/gtkvncviewer.desktop:2 Encoding -- Michal Čihař | http://cihar.com | http://blog.cihar.com signature.asc Description: PGP signature
Re: rfs: gtkvncviewer
Hi Dne Sat, 10 May 2008 10:46:27 +0200 Clement Lorteau <[EMAIL PROTECTED]> napsal(a): > Oh, right. I fixed it and uploaded the new package to > mentors.debian.net. The details of the RFS don't change. Unfortunately there is still one problem with the package: it depends on python-gconf which is not available in Debian. PS: Also you should choose just one way of modifying sources, doing one change by dpatch and one by direct patching is a bit confusing, but both changes are minor and I guess you will integrate in next upstream version, so it really does not matter. -- Michal Čihař | http://cihar.com | http://blog.cihar.com signature.asc Description: PGP signature
Re: rfs: gtkvncviewer
Dne Sat, 10 May 2008 18:49:04 +0200 Clement Lorteau <[EMAIL PROTECTED]> napsal(a): > > Unfortunately there is still one problem with the package: it > > depends on python-gconf which is not available in Debian. > > Oopsy, i saw it before, then forgot it; sorry about that. The > python-gconf dependency is not needed in Debian: I made a new package > which doesn't depend on it, installed it in my Debian unstable, and the > program runs just fine, including the feature that uses gconf. > > I uploaded the new package. Thanks, package uploaded. -- Michal Čihař | http://cihar.com | http://blog.cihar.com signature.asc Description: PGP signature
Re: Re: RFS: gtkvncviewer
Thanks for the comment. I repackaged it as non-native. - URL: http://mentors.debian.net/debian/pool/main/g/gtkvncviewer - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/g/gtkvncviewer/gtkvncviewer_0.2.2-1.dsc > Please provide a reason for why this should be a native package or > repackage it as non-native. See > http://people.debian.org/~mpalmer/debian-mentors_FAQ.html#native_vs_non_native > for further information. > > Helmut > > -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
re: re: rfs: gtkvncviewer
Thanks for the comments. I made all the changes you mentioned. Would you (or someone else) mind checking the new package ? I also have a question: should I file an ITP, as your Lintian mentions (my Lintian is provided by Ubuntu)? New RFS details: * Package name: gtkvncviewer Version : 0.2.3-1 (upstream version shifted because included license file in the upstream) Upstream Author : Clement Lorteau <[EMAIL PROTECTED]> * URL : http://launchpad.net/gtkvncviewer * License : GPLv2 Section : utils It builds these binary packages: gtkvncviewer - Small GTK tool to connect to VNC servers. The package appears to be lintian clean. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/g/gtkvncviewer - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/g/gtkvncviewer/gtkvncviewer_0.2.3-1.dsc >- debian/changelog format looks strange >- debian/control > - Homepage is missing Added > - why do you depend on libgnome-keyring0? That's a mistake, python-gnome2-desktop depends on it already; corrected > - use pycentral or pysupport and ${python:Depends} instead of > depending on python2.5 Done (pycentral) > - why does description start with empty line? I thought that was the right format; corrected. > - try to describe package more than just one sentence Done >- debian/rules > - do not use mkdir, install, use dh_install instead Done > - no need for configure target if it is not used Removed > - no need to set CFLAGS, you don't compile anything Removed > - please remove commented out things Removed > - package should be built by binary-indep as it is arch all Done > - you should not pass debian/changelog to dh_installchangelogs Done > - debian/dirs is IMHO not needed at all >- debian/copyright > - upstream tarball does not indicate that the > package is GPL, try contacting upstream to include license > information in package I'm the upstream author, I added a "LICENSE" file in the tarball; that explains the shift in the upstream version number > - "This package was py2debianized(0.3-gtkvncviewer)"? >- please use lintian: > $ lintian gtkvncviewer_0.2.2-1_i386.changes > W: gtkvncviewer source: binary-arch-rules-but-pkg-is-arch-indep Fixed by upper comment > W: gtkvncviewer: binary-without-manpage usr/bin/gtkvncviewer Added (simple) manpage > I: gtkvncviewer: > desktop-entry-contains-encoding-key > /usr/share/applications/data/gtkvncviewer.desktop:2 Encoding > W: gtkvncviewer: description-synopsis-might-not-be-phrased-properly > W: gtkvncviewer: spelling-error-in-description GTK GTK+ > W: gtkvncviewer: spelling-error-in-description GTK GTK+ That's part of the name of the program > W: gtkvncviewer: new-package-should-close-itp-bug Should I file an ITP ? > >Also gtkvncviewer_0.2.2.orig.tar.gz should match upstream tarball which it >does not (md5 is different). Fixed my packaging script -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Re: Re: rfs: gtkvncviewer
> Now I only see two minor lintian warnings: > $ lintian -I ../gtkvncviewer_0.2.3-1_i386.changes > I: gtkvncviewer source: build-depends-without-arch-dep > python-central > I: gtkvncviewer: > desktop-entry-contains-encoding-key > /usr/share/applications/data/gtkvncviewer.desktop:2 Encoding Hello, From Lintian user's manual: "Info (I) The displayed message is meant to inform the maintainer about a certain packaging aspect. Such messages do not usually indicate errors, but might still be of interest to the curious." Doesn't that mean there's nothing to fix? In this case, yes, I have a build dependency while my package is architecture independent, but that's how python-central i think; and yes I have an "Encoding" key in my .desktop file, but that's for specifying that the translations in the Description field are in UTF-8; i don't see these as problems. Again, thank you for your help. -- Clement Lorteau www.lorteau.fr | launchpad.net/~northern-lights signature.asc Description: Ceci est une partie de message numériquement signée
Re: Re: rfs: gtkvncviewer
On Fri, May 9, 2008 at 4:27 PM, Clement Lorteau <[EMAIL PROTECTED]> wrote: > Doesn't that mean there's nothing to fix? In this case, yes, I have a > build dependency while my package is architecture independent, but > that's how python-central i think; and yes I have an "Encoding" key in > my .desktop file, but that's for specifying that the translations in the > Description field are in UTF-8; i don't see these as problems. Take a look at the explanations given by lintian -i -I -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Re: Re: rfs: gtkvncviewer
> Unfortunately there is still one problem with the package: it > depends on python-gconf which is not available in Debian. Oopsy, i saw it before, then forgot it; sorry about that. The python-gconf dependency is not needed in Debian: I made a new package which doesn't depend on it, installed it in my Debian unstable, and the program runs just fine, including the feature that uses gconf. I uploaded the new package. -- Clement Lorteau www.lorteau.fr | launchpad.net/~northern-lights signature.asc Description: Ceci est une partie de message numériquement signée
re: re: re: rfs: gtkvncviewer
I followed them all and uploaded the new package to debian.mentors.net, could the package get another look ? Contents of the RFS does not change, except "The upload would fix these bugs: 480055" which is the newly filed ITP. Thank you for your help. --- RFS: * Package name: gtkvncviewer Version : 0.2.3-1 Upstream Author : Clement Lorteau <[EMAIL PROTECTED]> * URL : http://launchpad.net/gtkvncviewer * License : GPLv2 Section : utils It builds these binary packages: gtkvncviewer - Small GTK+ tool to connect to VNC servers The package appears to be lintian clean. The upload would fix these bugs: 480055 The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/g/gtkvncviewer - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/g/gtkvncviewer/gtkvncviewer_0.2.3-1.dsc -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Re: Re: Re: rfs: gtkvncviewer
Oh, right. I fixed it and uploaded the new package to mentors.debian.net. The details of the RFS don't change. Thanks, Clement. -- Clement Lorteau www.lorteau.fr | launchpad.net/~northern-lights signature.asc Description: Ceci est une partie de message numériquement signée