Re: RFS: libgis - virtual globe library

2010-11-18 Thread Andy Spencer
A few more updates :)

- Joined the pkg-grass group:
  - Updated maintainers in debian/control
  - Updated VCS links in debian/control
  - Debian files are now hosted at:
http://git.debian.org/?p=pkg-grass/libgis.git
- Use libgis-dev.examples for gis-demo instead of libgis-bin
- Update Recommends/Suggests
- Add debian/clean to delete some generated files
- Fixed a bug that caused a crash when using Mesa

To compile gis-demo:

  gzip -d gis-demo.c.gz
  touch config.h
  gcc -I. --std=c99 -o gis-demo gis-demo.c `pkg-config --libs --cflags libgis`
 
(I'll be removing the dependency on config.h in the next release)


pgpT4T3SaxqIK.pgp
Description: PGP signature


Re: RFS: libgis - virtual globe library

2010-11-18 Thread David Paleino
Hello Andy,

On Thu, 18 Nov 2010 09:00:06 +, Andy Spencer wrote:

 - Joined the pkg-grass group:

Great!

   - Debian files are now hosted at:
 http://git.debian.org/?p=pkg-grass/libgis.git

You forgot to push everything. Please do:

$ git push --all ; git push --tags

 - Use libgis-dev.examples for gis-demo instead of libgis-bin
 - Update Recommends/Suggests
 - Add debian/clean to delete some generated files
 - Fixed a bug that caused a crash when using Mesa

Everything seems fine. Just one small thing: you're suggesting libgis-doc (=
${binary:Version}). libgis-doc is an Arch:all package, and binary:Version
doesn't apply there. I suggest to entirely drop the version, since it's
documentation, and there's no need of a strict dependency.

After fixing this (just do a commit with that change), and pushing the
remaining branches/tags, I'll upload it.

Kindly,
David

-- 
 . ''`.   Debian developer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 | http://deb.li/dapal
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174


signature.asc
Description: PGP signature


Re: RFS: libgis - virtual globe library

2010-11-18 Thread Andy Spencer
On 2010-11-18 10:19, David Paleino wrote:
- Debian files are now hosted at:
  http://git.debian.org/?p=pkg-grass/libgis.git
 
 You forgot to push everything. Please do:
 
 $ git push --all ; git push --tags

Oops, forgot to push upstream..


  - Use libgis-dev.examples for gis-demo instead of libgis-bin
  - Update Recommends/Suggests
  - Add debian/clean to delete some generated files
  - Fixed a bug that caused a crash when using Mesa
 
 Everything seems fine. Just one small thing: you're suggesting libgis-doc (=
 ${binary:Version}). libgis-doc is an Arch:all package, and binary:Version
 doesn't apply there. I suggest to entirely drop the version, since it's
 documentation, and there's no need of a strict dependency.
 
 After fixing this (just do a commit with that change), and pushing the
 remaining branches/tags, I'll upload it.

Ok, I removed the version and pushed the changes.

I just moved the debian/0.4.2-1 tag this time since it's an initial
release, I hope that's alright. In the future I'll make a changelog
entry and add a new tag.


pgpbUvwyCiDlH.pgp
Description: PGP signature


Re: RFS: libgis - virtual globe library

2010-11-15 Thread David Paleino
On Mon, 15 Nov 2010 06:24:01 +, Andy Spencer wrote:

 Thanks for the comments so far, I've posted an updated set of packages
 to mentors.debian.net, here's a quick list of changes (I may be
 forgetting a few):
 
 [..]
 
 I also set up a git repository on my local machine for storing the
 Debian files using git-buildpackage. As David suggested, I would like to
 host them as part of the pkg-grass project and am looking into getting a
 repository on Alioth.

If you want it to be in Debian GIS, a couple more changes are needed. In
debian/control, please set Debian GIS Project
pkg-grass-de...@lists.alioth.debian.org as Maintainer, and put yourself in
Uploaders field.

Unrelated to Debian GIS: always in debian/control, libgis-doc Recommends
libgis0. I know someone suggested it on this list, but why? Recommends are
installed by default, and that package is meant to provide documentation, so
I'd rather Suggest libgis-dev. That's IMHO though.

Also, you have changes stored in debian/patches/debian-changes-0.4.2-1 . Please
make so that patch doesn't appear. Usually, you want to avoid direct changes to
the upstream source, but rather you want to use quilt(1).
(Tip: that patch creates two autotools-related files. If you want to get rid of
them, add them to debian/clean, and they'll be removed during the clean target)

You have an examples/ directory. Why don't you install them? I'd put it in
debian/libgis-dev.examples .

Also, a symbols file is missing. Did you choose not to include one, or just
forgot it? :-)
To generate one, I'd suggest using (after a fakeroot debian/rules install):

$ dpkg-gensymbols -plibgis0 | sed -e 's/0.4.2-1/0.4.2/' | patch -p0

And then move the new_symbols_file to debian/libgis0.symbols.


After compiling it, I see that only a gis-demo is present in libgis-bin. I
thought at something more... useful? :-)
It might make sense to drop that binary package at all, and put the sources of
this gis-demo in libgis-dev.examples.

Quoting your other mail:

 Also, this is slightly unrelated, but do you know why I get a lot of
 errors of the form: 
 
   dpkg-shlibdeps: warning: dependency on libfoo.so.0 could be avoided if
   debian/libgis0/usr/lib/libgis0/map.so ... were not uselessly linked
   against it (they use none of its symbols).
 
 I've tried using -Wl,--as-needed hopping it would prevent these
 warnings, but it doesn't seem to make any difference.

Those are generally harmful.
You should check what's actually being linked, and if you're using any function
from those libraries (i.e. check what -l... are being passed to gcc).

This is only reflected in the generated dependencies. While it should really
be fixed, it's not a showstopper.


After the installation, trying to run it causes a segfault:

$ gis-demo
** (gis-demo:23376): DEBUG: GisPrefs: new - (null), (null)
** (gis-demo:23376): DEBUG: GisPrefs: class_init
** (gis-demo:23376): DEBUG: GisPrefs: init
** (gis-demo:23376): DEBUG: GisPrefs: new - Trying GIS defaults
** (gis-demo:23376): DEBUG: GisPrefs: new - Unable to load key file
`/home/neo/.config/libgis/config.ini': No such file or directory
** (gis-demo:23376): DEBUG: GisPrefs: new -
using /home/neo/.config/libgis/config.ini
** (gis-demo:23376): DEBUG: GisPlugins: new - dir=(null)
** (gis-demo:23376): DEBUG: GisOpenGL: new
** (gis-demo:23376): DEBUG: GisViewer: class_init
** (gis-demo:23376): DEBUG: GisOpenGL: class_init
** (gis-demo:23376): DEBUG: GisViewer: init
** (gis-demo:23376): DEBUG: GisOpenGL: init
** (gis-demo:23376): DEBUG: RoamSphere: new - 0x8aaf600
edge=90,00,0,00,90,00,0,00
** (gis-demo:23376): DEBUG: RoamSphere: new - 0x8aaf6e8
edge=90,00,0,00,180,00,90,00
** (gis-demo:23376): DEBUG: RoamSphere: new - 0x8aaf7d0
edge=90,00,0,00,-90,00,-180,00
** (gis-demo:23376): DEBUG: RoamSphere: new - 0x8aa93a0
edge=90,00,0,00,0,00,-90,00
** (gis-demo:23376): DEBUG: RoamSphere: new - 0x8aa9488
edge=0,00,-90,00,90,00,0,00
** (gis-demo:23376): DEBUG: RoamSphere: new - 0x8aa9570
edge=0,00,-90,00,180,00,90,00
** (gis-demo:23376): DEBUG: RoamSphere: new - 0x8aa9658
edge=0,00,-90,00,-90,00,-180,00
** (gis-demo:23376): DEBUG: RoamSphere: new - 0x8aa9740
edge=0,00,-90,00,0,00,-90,00
** (gis-demo:23376): DEBUG: GisOpenGL: on_configure
Segmentation fault
$

Here's the gdb backtrace so that you can
check: http://www.hanskalabs.net/tmp/libgis-gdb.txt


Kindly,
David

-- 
 . ''`.   Debian developer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 | http://deb.li/dapal
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174


signature.asc
Description: PGP signature


Re: RFS: libgis - virtual globe library

2010-11-15 Thread David Paleino
On Mon, 15 Nov 2010 09:01:32 +0100, David Paleino wrote:

 On Mon, 15 Nov 2010 06:24:01 +, Andy Spencer wrote:
 
  Thanks for the comments so far, I've posted an updated set of packages
  to mentors.debian.net, here's a quick list of changes (I may be
  forgetting a few):
  
  [..]
 
 [..]

I was forgetting. In libgis-doc, I can't see the use of a versioned
Recommends. If you really want it, please use (= ${source:Version}).

Have a nice day,
David

-- 
 . ''`.   Debian developer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 | http://deb.li/dapal
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174


signature.asc
Description: PGP signature


Re: RFS: libgis - virtual globe library

2010-11-15 Thread Andy Spencer
On 2010-11-15 09:01, David Paleino wrote:
 If you want it to be in Debian GIS, a couple more changes are needed. In
 debian/control, please set Debian GIS Project
 pkg-grass-de...@lists.alioth.debian.org as Maintainer, and put yourself in
 Uploaders field.

Sounds good


 Unrelated to Debian GIS: always in debian/control, libgis-doc Recommends
 libgis0. I know someone suggested it on this list, but why? Recommends are
 installed by default, and that package is meant to provide documentation, so
 I'd rather Suggest libgis-dev. That's IMHO though.

libgis-dev sounds better actually, I think I'll do some more reading
about how exactly the Recommends/Suggests works too.


 Also, you have changes stored in debian/patches/debian-changes-0.4.2-1 . 
 Please
 make so that patch doesn't appear. Usually, you want to avoid direct changes 
 to
 the upstream source, but rather you want to use quilt(1).
 (Tip: that patch creates two autotools-related files. If you want to get rid 
 of
 them, add them to debian/clean, and they'll be removed during the clean 
 target)

That's exactly what I want, thanks :)


 Also, a symbols file is missing. Did you choose not to include one, or just
 forgot it? :-)
 To generate one, I'd suggest using (after a fakeroot debian/rules install):
 
 $ dpkg-gensymbols -plibgis0 | sed -e 's/0.4.2-1/0.4.2/' | patch -p0
 
 And then move the new_symbols_file to debian/libgis0.symbols.

I think I'll avoid including a symbols file for now.


 You have an examples/ directory. Why don't you install them? I'd put it in
 debian/libgis-dev.examples .

 After compiling it, I see that only a gis-demo is present in libgis-bin. I
 thought at something more... useful? :-)
 It might make sense to drop that binary package at all, and put the sources of
 this gis-demo in libgis-dev.examples.

I'll have to think a little more about putting gis-demo in examples, to
some extent it is a usable program, just not a very fancy one. I think
I'll look into how .examples is used in other packages before making a
decision as well.

As for the examples/ directory, that name is probably little misleading,
they're not so much examples as test programs. E.g. there's one that
tests loading OpenGL textures with different texture parameters.
However, the examples/plugin/, src/gis-test.c, and possible
src/tile-test.c fit the definition of examples a little better.
I suppose my directory structure could use some clean-up at some point,
but that can wait until another day :)

Note: it looks like some of the examples/ files didn't get included in
the .tar.gz because they weren't mentioned in any Makefile.am.


 Quoting your other mail:
 
  Also, this is slightly unrelated, but do you know why I get a lot of
  errors of the form: 
  
dpkg-shlibdeps: warning: dependency on libfoo.so.0 could be avoided if
debian/libgis0/usr/lib/libgis0/map.so ... were not uselessly linked
against it (they use none of its symbols).
  
  I've tried using -Wl,--as-needed hopping it would prevent these
  warnings, but it doesn't seem to make any difference.
 
 Those are generally harmful.
 You should check what's actually being linked, and if you're using any 
 function
 from those libraries (i.e. check what -l... are being passed to gcc).
 
 This is only reflected in the generated dependencies. While it should really
 be fixed, it's not a showstopper.

It looks like a lot of Glib/GTK/X11 stuff, atk, fontconfig, gio, libICE,
libX11, etc. I think it's caused by how autotools/libtool/pkg-config
figures out dependencies. libtool tries to link it against _everything_
even when I only use functions from a couple of them. Here's a list of
the warnings if you're interested: http://vpaste.net/pRIlT


 After the installation, trying to run it causes a segfault:
 
 $ gis-demo
 ...

Thanks for the bug report :)

I'm guessing it could be affected by OpenGL drivers (I'm using the
binary NVidia drivers). In any case I'll take a closer look at your
backtrace during the next couple days reply to that separately.


Quoting your other mail:
 I was forgetting. In libgis-doc, I can't see the use of a versioned
 Recommends. If you really want it, please use (= ${source:Version}).

Sounds good


pgpGCRN3t8KuQ.pgp
Description: PGP signature


Re: RFS: libgis - virtual globe library

2010-11-14 Thread Andy Spencer
Thanks for the comments so far, I've posted an updated set of packages
to mentors.debian.net, here's a quick list of changes (I may be
forgetting a few):

  - Added an ITP bug #603393
  - Changed libgis-doc to arch:all
  - Converted debian/copyright to DEP-5 format
  - Removed .a files from libgis-dev.install
  - Fixed lintian errors (one info message left for no-symbols-control-file)
  - Removed ChangeLog from debian/docs
  - Improved library versioning
- Renamed libgis package to libgis0
- Added -version-info to libgis.so
- Moved plugins from /usr/lib/gis/ to /usr/lib/libgis0/
  - Improved debian/control
- Removed incorrect VCS links
- Improved package descriptions
- libgis-bin depends on shlibs:Depends not individual libraries
- libgis-dev suggests libigs-doc
- libgis-doc recommends libgis0

I also set up a git repository on my local machine for storing the
Debian files using git-buildpackage. As David suggested, I would like to
host them as part of the pkg-grass project and am looking into getting a
repository on Alioth.

Note, the new packages are called 0.4.2 instead of 0.4.1. These include
a few changes to libgis to accommodate Debian packaging. I'm waiting for
all the Debian changes to be finished before pushing a tag to libgis'
git mirrors though.


pgpzPPEptO62h.pgp
Description: PGP signature


Re: RFS: libgis - virtual globe library

2010-11-14 Thread Andy Spencer
On 2010-11-13 11:27, Benoît Knecht wrote:
  - In debian/docs, remove the ChangeLog entry; it is installed and
gzipped automatically.

Fixed.

  - You should delete debian/lintian.txt (after reading it :-) ).

Fixed.

  - In debian/control, libgis-bin should depend on ${shlibs:Depends}
instead of listing all the libraries explicitly. And I don't think
libgis-doc should Depend on libgis (but it could Recommend it, and
libgis could Suggest libgis-doc).

Fixed, I set libgis-dev to suggest libgis-doc and libgis-doc to
recommend libgis0.

Also, this is slightly unrelated, but do you know why I get a lot of
errors of the form: 

  dpkg-shlibdeps: warning: dependency on libfoo.so.0 could be avoided if
  debian/libgis0/usr/lib/libgis0/map.so ... were not uselessly linked
  against it (they use none of its symbols).

I've tried using -Wl,--as-needed hopping it would prevent these
warnings, but it doesn't seem to make any difference.


pgpEs2likV8pA.pgp
Description: PGP signature


Re: RFS: libgis - virtual globe library

2010-11-13 Thread Benoît Knecht
Hi Andy,

Andy Spencer wrote:
 I am looking for a sponsor for my package libgis.
 
 * Package name: libgis
   Version : 0.4.1-1
   Upstream Author : Andy Spencer (myself)
 * URL : http://lug.rose-hulman.edu/code/projects/libgis/wiki
 * License : GPL-3+
   Section : science
 
 It builds these binary packages:
 libgis - A Virtual Globe library
 libgis-bin - Example programs for libgis
 libgis-dev - Development files for libgis
 libgis-doc - HTML documentation for libgis

I didn't really look at your package yet, but I just wanted to point out
that you're not closing any bugs with this release. You're supposed to
file a bug against WNPP (Work-Needing and Prospective Packages) and note
in the debian/changelog entry that this package would be closing that
bug. See [1] for details about the procedure.

[1] http://www.debian.org/devel/wnpp/

Cheers,

-- 
Benoît Knecht


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20101113092203.ga3...@debian.lan



Re: RFS: libgis - virtual globe library

2010-11-13 Thread David Paleino
Hello Andy,
apart from Benoît's remark, which is correct, here are some comments:

On Sat, 13 Nov 2010 07:19:39 +, Andy Spencer wrote:

 * Package name: libgis
   Version : 0.4.1-1
   Upstream Author : Andy Spencer (myself)
 * URL : http://lug.rose-hulman.edu/code/projects/libgis/wiki
 * License : GPL-3+
   Section : science
 
 It builds these binary packages:
 libgis - A Virtual Globe library
 libgis-bin - Example programs for libgis
 libgis-dev - Development files for libgis
 libgis-doc - HTML documentation for libgis

IMHO, the name of your project is rather too generic (libgis). It should be
changed to something more descriptive, but that's your choice as upstream at
the end.
Apart from this, you're very welcome to maintain it under the Debian GIS Team
umbrella. To join us, please join the pkg-grass [0] project on
alioth.debian.org.

[0]: https://alioth.debian.org/projects/pkg-grass/

Here are some comments:

- In debian/control, you misinterpreted the meaning of Vcs-* fields. Those
  should point to the location where the Debian packaging is kept, while you
  pointed at the upstream repository. You can choose to maintain the debian/
  dir there as well, or host it on Alioth within the Debian GIS Team (which
  would be better for team-maintainance).

- Library packaging in Debian has to follow certain policies. The binary
  package you're producing should be named libgisSONAME (i.e. libgis0, or
  similar). This ensures that any dependant package depends on the correct
  version of the library.

- Why is libgis-doc an arch:any package? I didn't check its contents, but I
  suspect it should be arch:all. ;)

- You might want to use DEP-5 format for your debian/copyright. Read more at
  http://dep.debian.net/deps/dep5/ . It's entirely optional, and it won't be a
  stopper if you leave it like it is now.

- In libgis-dev.install , please avoid installing *.a files. We (as Debian) are
  deprecating them, and installing them in a brand new package is a bad thing.

- Your package doesn't seem to be lintian clean ;-) -- you pasted lintian's
  output in debian/lintian.txt, and there it clearly says to a) close an ITP
  bug and b) use a proper name for the binary (point 2 of my comments). Next
  time please read it ;)

- Always in the lintian warning, it says you're missing a symbols file. Since
  it's a C project, I strongly suggest you to make one (I personally dislike
  C++ symbols files, but that's just me). Please read more at
  http://wiki.debian.org/UsingSymbolsFiles

Please re-ping me once you fixed all this, or if you have any doubt/question.

Thank you for your work,
David

-- 
 . ''`.   Debian developer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 | http://deb.li/dapal
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174


signature.asc
Description: PGP signature


Re: RFS: libgis - virtual globe library

2010-11-13 Thread Benoît Knecht
Hi Andy,

Andy Spencer wrote:
 I am looking for a sponsor for my package libgis.
 
 * Package name: libgis
   Version : 0.4.1-1
   Upstream Author : Andy Spencer (myself)
 * URL : http://lug.rose-hulman.edu/code/projects/libgis/wiki
 * License : GPL-3+
   Section : science
 
 It builds these binary packages:
 libgis - A Virtual Globe library
 libgis-bin - Example programs for libgis
 libgis-dev - Development files for libgis
 libgis-doc - HTML documentation for libgis

I had a closer look at your package, and additionally to David's
comments, I noticed the following:

 - In debian/control, libgis-bin should depend on ${shlibs:Depends}
   instead of listing all the libraries explicitly. And I don't think
   libgis-doc should Depend on libgis (but it could Recommend it, and
   libgis could Suggest libgis-doc).

 - In debian/docs, remove the ChangeLog entry; it is installed and
   gzipped automatically.

 - You should delete debian/lintian.txt (after reading it :-) ).

Cheers,

-- 
Benoît Knecht


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20101113102747.gb3...@debian.lan



Re: RFS: libgis - virtual globe library

2010-11-13 Thread Andy Spencer
On 2010-11-13 10:21, Benoît Knecht wrote:
 I didn't really look at your package yet, but I just wanted to point out
 that you're not closing any bugs with this release. You're supposed to
 file a bug against WNPP (Work-Needing and Prospective Packages) and note
 in the debian/changelog entry that this package would be closing that
 bug. See [1] for details about the procedure.

Thanks, I've filed bug #603393 [1], added it to debian/changelog, and
noted it in the comment field on mentors.debian.net.

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=603393


pgpEN3Cag7NuN.pgp
Description: PGP signature


Re: RFS: libgis - virtual globe library

2010-11-13 Thread Andy Spencer
On 2010-11-13 10:58, David Paleino wrote:
 IMHO, the name of your project is rather too generic (libgis). It should be
 changed to something more descriptive, but that's your choice as upstream at
 the end.

 Apart from this, you're very welcome to maintain it under the Debian GIS Team
 umbrella. To join us, please join the pkg-grass [0] project on
 alioth.debian.org.
 
 [0]: https://alioth.debian.org/projects/pkg-grass/

I've never been good with names :) I agree that it is a little generic,
but I would rather leave it the way it is. I can't find any conflicts in
Contents-i386 and googling for libgis seems to indicate that it's a
fairly unique name, apart from a subsection of GRASS.

Maintaining it under the Debian GIS Team would be nice. That website
looks pretty GRASS-specific though, would it be suitable for a non-GRASS
related package?


 - In debian/control, you misinterpreted the meaning of Vcs-* fields. Those
   should point to the location where the Debian packaging is kept, while you
   pointed at the upstream repository. You can choose to maintain the debian/
   dir there as well, or host it on Alioth within the Debian GIS Team (which
   would be better for team-maintainance).

Oops, I've removed the links for now and will add proper links once
version control is set up for the debian files. Alioth seems like a good
place, I'll look into how that works.


 - Why is libgis-doc an arch:any package? I didn't check its contents, but I
   suspect it should be arch:all. ;)

Fixed :)


 - You might want to use DEP-5 format for your debian/copyright. Read more at
   http://dep.debian.net/deps/dep5/ . It's entirely optional, and it won't be a
   stopper if you leave it like it is now.

That looks like a nice format, I've change debian/copyright accordingly.


 - In libgis-dev.install , please avoid installing *.a files. We (as Debian) 
 are
   deprecating them, and installing them in a brand new package is a bad thing.

Removed.


 - Your package doesn't seem to be lintian clean ;-) -- you pasted lintian's
   output in debian/lintian.txt, and there it clearly says to a) close an ITP
   bug and b) use a proper name for the binary (point 2 of my comments). Next
   time please read it ;)

The first lintian file I generated was actually much bigger ;)
  a) Fixed now (per Benoît's email) #603393 for reference
  b) I wanted to discuss this one a little further before trying to
 correct it. (See below)

Another point of interest is that mentors.debian.net says:
  intian warnings: none
  intian errors:   none
Even though there were some warnings. I copied the `lintian clean'
message from the template it generated, but I'm not sure if it generated
the `lintian clean' part or if that was hard coded.


 - Library packaging in Debian has to follow certain policies. The binary
   package you're producing should be named libgisSONAME (i.e. libgis0, or
   similar). This ensures that any dependant package depends on the correct
   version of the library.

 - Always in the lintian warning, it says you're missing a symbols file. Since
   it's a C project, I strongly suggest you to make one (I personally dislike
   C++ symbols files, but that's just me). Please read more at
   http://wiki.debian.org/UsingSymbolsFiles

(I wanted to address these comments together)

Personally, I'm not too concerned with the symbols file, or library
versioning at all for that matter. Now, I had better clarify before
someone bashes me with the libtool manual ;)

As I mentioned in my initial email, libgis was developed to support
another program called AWeather. Since AWeather is the only program that
currently uses libgis and it depends on the latest version anyway, I
don't expect there to be very many issues with library versioning. 

That being said, if/when I hear about other people wanting to use libgis
in their own programs (which I hope they will) I will start caring much
more about library versioning, a stable API, etc.

Anyway, I suspect some library versioning will be required, but I think
doing as little as possible would (for now) be the most efficient way to
go. Does this sound correct for package names, or can I do without the
0.4?

  - libgis-0.4-0
  - libgis-0.4-dev
  - libgis-0.4-bin
  - libgis-0.4-doc

  (using -version-info 0:0:0 -release 0.4.1)


Thanks for all the comments. I'll build and post another set of packages
this evening with these (and other) changes.


pgp4iRhkm18jD.pgp
Description: PGP signature


Re: RFS: libgis - virtual globe library

2010-11-13 Thread David Paleino
On Sat, 13 Nov 2010 19:20:23 +, Andy Spencer wrote:

 On 2010-11-13 10:58, David Paleino wrote:
  IMHO, the name of your project is rather too generic (libgis). It should
  be changed to something more descriptive, but that's your choice as
  upstream at the end.
 
  Apart from this, you're very welcome to maintain it under the Debian GIS
  Team umbrella. To join us, please join the pkg-grass [0] project on
  alioth.debian.org.
  
  [0]: https://alioth.debian.org/projects/pkg-grass/
 
 I've never been good with names :) I agree that it is a little generic,
 but I would rather leave it the way it is. I can't find any conflicts in
 Contents-i386 and googling for libgis seems to indicate that it's a
 fairly unique name, apart from a subsection of GRASS.
 
 Maintaining it under the Debian GIS Team would be nice. That website
 looks pretty GRASS-specific though, would it be suitable for a non-GRASS
 related package?

Yes. The team is named pkg-grass mainly for historical reasons, now it
maintains all sorts of GIS-related software -- from GRASS to OpenStreetMap
things.

  - In debian/control, you misinterpreted the meaning of Vcs-* fields. Those
should point to the location where the Debian packaging is kept, while you
pointed at the upstream repository. You can choose to maintain the debian/
dir there as well, or host it on Alioth within the Debian GIS Team (which
would be better for team-maintainance).
 
 Oops, I've removed the links for now and will add proper links once
 version control is set up for the debian files. Alioth seems like a good
 place, I'll look into how that works.

If you join pkg-grass, you could ssh into alioth and do:

$ cd /git/pkg-grass/
$ ./setup-repository libgis 'some description'

After that, you can use git.debian.org/git/pkg-grass/libgis.git as remote in
your packaging repository. Most (if not all) of the packages there use the
git-buildpackage layout -- you might want to read about git-import-origin,
git-import-dsc and git-buildpackage.

 [..]
  - Your package doesn't seem to be lintian clean ;-) -- you pasted lintian's
output in debian/lintian.txt, and there it clearly says to a) close an ITP
bug and b) use a proper name for the binary (point 2 of my comments). Next
time please read it ;)
 
 The first lintian file I generated was actually much bigger ;)
   a) Fixed now (per Benoît's email) #603393 for reference
   b) I wanted to discuss this one a little further before trying to
  correct it. (See below)

Ack.

 Another point of interest is that mentors.debian.net says:
   intian warnings: none
   intian errors:   none
 Even though there were some warnings. I copied the `lintian clean'
 message from the template it generated, but I'm not sure if it generated
 the `lintian clean' part or if that was hard coded.

Well, no. AFAICT, mentors.debian.net doesn't use sid's lintian -- while a
maintainer should always use that one.

  - Library packaging in Debian has to follow certain policies. The binary
package you're producing should be named libgisSONAME (i.e. libgis0,
  or similar). This ensures that any dependant package depends on the correct
version of the library.
 
  - Always in the lintian warning, it says you're missing a symbols file.
  Since it's a C project, I strongly suggest you to make one (I personally
  dislike C++ symbols files, but that's just me). Please read more at
http://wiki.debian.org/UsingSymbolsFiles
 
 (I wanted to address these comments together)
 
 Personally, I'm not too concerned with the symbols file, or library
 versioning at all for that matter. Now, I had better clarify before
 someone bashes me with the libtool manual ;)

Yeah. Such statements don't usually pass unpunished :-)

 As I mentioned in my initial email, libgis was developed to support
 another program called AWeather. Since AWeather is the only program that
 currently uses libgis and it depends on the latest version anyway, I
 don't expect there to be very many issues with library versioning. 
 
 That being said, if/when I hear about other people wanting to use libgis
 in their own programs (which I hope they will) I will start caring much
 more about library versioning, a stable API, etc.

Uploading a library in Debian, you're giving other users the chance to use it,
and link against it. Even for private (as in not-published) projects. And
breaking users' software for no reason isn't good ;)

 Anyway, I suspect some library versioning will be required, but I think
 doing as little as possible would (for now) be the most efficient way to
 go. Does this sound correct for package names, or can I do without the
 0.4?
 
   - libgis-0.4-0
   - libgis-0.4-dev
   - libgis-0.4-bin
   - libgis-0.4-doc

Nope.
What's required in the package name is the SONAME, which in your case is 0. So
the packages should look like:

- libgis0
- libgis-bin
- libgis-dev
- libgis-doc

Why the SONAME is only on the shared library package? Because it's 

RFS: libgis - virtual globe library

2010-11-12 Thread Andy Spencer
Dear mentors,

I am looking for a sponsor for my package libgis.

* Package name: libgis
  Version : 0.4.1-1
  Upstream Author : Andy Spencer (myself)
* URL : http://lug.rose-hulman.edu/code/projects/libgis/wiki
* License : GPL-3+
  Section : science

It builds these binary packages:
libgis - A Virtual Globe library
libgis-bin - Example programs for libgis
libgis-dev - Development files for libgis
libgis-doc - HTML documentation for libgis

The package appears to be lintian clean.

My motivation for maintaining this package is:

  I am the primary developer (upstream) for this package and would like
  to make it easier to non-technical users to install and use.

  libgis is a Virtual Globe library which uses OpenGL to render an
  image of the earth using satellite and terrain data from publicly
  accessible servers. This is similar in concept to Google Earth and
  NASA World Wind, except implemented as a library.
  
  I am also working on a program called AWeather which I plan on
  packaging as well. The development of AWeather and libgis is closely
  tied and, as far as I know, aweather is currently the only program
  that uses libgis.

  Note: I am new to Debian and Debian packaging. This is my first
  attempt at putting a package together for libgis so it will probably
  need some work before it's all ready, especially since it's a library.

The package can be found on mentors.debian.net:
- URL: http://mentors.debian.net/debian/pool/main/l/libgis
- Source repository: deb-src http://mentors.debian.net/debian unstable main 
contrib non-free
- dget http://mentors.debian.net/debian/pool/main/l/libgis/libgis_0.4.1-1.dsc

I would be glad if someone could review this package and provide advice
on anything that needs to be improved, and eventually uploaded it for me
as well.

Kind regards
 Andy Spencer


pgpYiUNmjW3Xo.pgp
Description: PGP signature