Re: RFS: lilo (updated package) (new Maintainer)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 2010-12-12 19:43, Joachim Wiedorn wrote: Hello Niels, Niels Thykier ni...@thykier.net wrote on 2010-12-12 17:18: [...] For the next non-Squeeze upload you may want to consider using the 3.0 (quilt) format, since it supports binary files in the debian dir (insteand of the uudecode) as well as cleaning up in the d/rules file (e.g. using dh_clean instead of multiple rm -f etc) The next (already made) package with lilo 23.1 will use all new dh methods with format 3.0 (quilt). You can see the unofficial packages here: http://lilo.alioth.debian.org/ftp/ Also the old maintainer is still listed as the primary maintainer in d/copyright. With the new file format (see above) it is gone. On 2010-12-12 17:46, Joachim Wiedorn wrote: I know that problem. The most problems come from the special script 'liloconfig' which uses with debconf (but it should not do). It is a legacy. Sounds good :) I was not sure how much you had done in your 23.1 package (I did not check it) On 2010-12-12 17:46, Joachim Wiedorn wrote: [...] Should I nevertheless do an update of the package to give the release team the chance to let it into Squeeze? [...] In this case, I believe none of the changes mentioned here are worth trouble for a second upload for Squeeze (given that the release team were okay with the current package). Personally I would probably just do them in the next Squeeze + 1 upload. ~Niels -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIbBAEBCAAGBQJNBpMeAAoJEAVLu599gGRCg+oP90gesEouwkGSpvNfz8IOz8cq HZJHbbMs0pM1lEU1K1kK1OicUg6s67mytVt4L/IvCsMtR2b/4aKjIcZkeWjkbgNH 3LfG6QwWYp+dTdW/xvnflknWzQN72mX8Zm1sf5wB1b01FpI/T/lZRHJ3FpyG40cL g8ePq5xHsstwdzngNBTHEC7qs9DjLQGJz16wMddhBS+iC8ovgYVEA/V8V+Vz1CB+ vQvkVJq7jqH8LlBOowPerA97c0itfWw/rwqkHvu4FLEf7gMzC23IYbCX1t9romzH JCtkUJk5LhQEBWsp9w+4R8Zix9zr90E+zoVjEUlqd0caU551puuZKkwiV7lT3oL9 6iub1hWY20Ajzjh9j0PRE4XGBlHwww9tj9Z5XZYZYrPPEhCy40F0yUjMxPwYlEqU BSeDfbYU4IbGbO1ux5UHbG1+cacUy4JtGKf8e1kqKHEkq63tzVGP6HdWgu0kQl07 F0jnV6sBSs7jxdCmpk7pxrqCCuSK+Bcvv46gxTdlD/de/ZSv9SUSfCBUvU1s4nrR v5HbOQk+LiL0arI98O5aThl+4b8fM24CDeHRgVdPOtP+gkE9UpSn7aL0n0YxNo1P e6GQ59elc5egAa+aJZoBcsI1mN+3BNMnnOumtNm2r8Ur1cX8IrmE0OKFEsxBlzlm Rh8i7zWdAETHJz7qeFk= =QtoM -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4d06931f.1080...@thykier.net
Re: RFS: lilo (updated package) (new Maintainer)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 2010-12-11 18:29, Joachim Wiedorn wrote: Dear mentors, Hi, I had a quick look at your package, though there are things I may have missed. I am looking for a sponsor for the new version 1:22.8-9 of my package lilo. It builds these binary packages: lilo - LInux LOader - The Classic OS loader can load Linux and others lilo-doc - Documentation for LILO (LInux LOader) The package appears to be lintian clean. Too much copy paste from the RFS template :) The binary package has 11 warnings (it also triggers a number of less severe tags e.g. I). Anyhow, considering you are targeting this for Squeeze, lintian-cleanless in itself is not a priority. The upload would fix these bugs: 398957, 400642, 409285, 420587, 427507 [...] I would be glad if someone uploaded this package for me. The CTTE disposed at 1st December that I am allowed to be the new Maintainer for the LILO package: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=587886#158 This update of the LILO package (based on lilo 22.8-8.3) comes with a small set of bugfixes to work better within Squeeze. The target is to enter to testing before Squeeze will be released (I hope to the release team). Your priority being what it is; you should aim for fixing critical or highly annoying bugs with the minimal number of changes. If the diff gets to large, the release team may choose to reject it because they cannot keep track of the changes. Have you talked with the release team about the bugs you are fixing? I can understand the feeling of wanting to fix as much as possible, but the release team may feel the bugs are not important enough for the changes required. FYI here are the last changelog entry: lilo (1:22.8-9) unstable; urgency=low * New maintainter. * debian/patches: - Remove patch 16_geometry.patch for inaccessible disks and add information in README.Debian about using of 'inaccessible' option. (Closes: #409285, #400642) - Fix script checkit for newer gcc. - Fix for use LVM volume as root device. (Closes: #398957) - Fix for better computing vmlinux size, upgrade hints in README.Debian. (fixing sporadic failures). * Fix hook scripts: check for /sbin/lilo. * Add lacking file disk.com for creating test floppy. * Add universal menu image for debian, remove menu image for sarge. Update of template, postinst and postrm. (Closes: #420587, #427507) * Set source format 1.0. Add README.source file. I recommend undoing at least the README.source file; first off, it does not describe what it is supposed too and secondly even if you correct it, it has no functional change. The format part is only 1 line, so it is (probably) not going to disturb the reviewer too much. * Update watch file to new alioth project area. * debian/control: - Remove VCS urls and add new Homepage url. - Remove IA64 architecture (this is already status quo). - Remove double lines of Priority and Section. - Add package conflicts to grub-pc and grub-legacy. - Remove conflicts to manpages. - Bump to Standards-Version 3.9.1 (without changes). Kind regards Joachim Wiedorn I had a look and: - --- lilo-22.8/debian/lilo.postinst +++ lilo-22.8-9/debian/lilo.postinst [...] + # to be compatible to older debian package + if [ ! -e /boot/sarge.bmp ]; then + ln -sf debian.bmp /boot/sarge.bmp fi [...] That debian.bmp, should that have been a /boot/debian.bmp? In this snippet: - --- lilo-22.8/debian/rules +++ lilo-22.8-9/debian/rules @@ -23,6 +23,7 @@ dh_testdir make spotless -rm -f build debian/files debian/lilo.substvars [...] + -rm -f debian/*.debhelper.log debian/lilo-doc.substvars -rm -f doc/*.dvi doc/*.ps doc/*.aux doc/*.toc doc/*.log -rm -rf debian/lilo debian/lilo-doc debian/*.debhelper [...] [...] Most of these lines (incl. the one added) appear to be re-implementing dh_clean. Replacing those lines with dh_clean /might/ be better (because the release team knows what dh_clean does and do not need to verify the handmade version) There are also a lot of po file updates, which are not translation changes. I presume they have been made by some tool (e.g. debconf-updatepo from the clean target). As far as I can tell it has just added a Language header and in some cases modified the translation so that % is with its arguments (e.g. %\ns becomes \n%s). If these changes can sanely be avoided, then that might be a good idea as well. ~Niels -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCAAGBQJNBOTPAAoJEAVLu599gGRCQpMP/AggVPyEMLlcCe8SCJAGi02D kGpvLlNeKC7WilH3Vk7AJ0Xvylt/0F1kTCq5b/29QCXesZFtSv2GD8lxxjBx1VSN MJB1a+b4C9+ghFM8MSXGJ4l5K9QRRgeyV0CN6jEVHERa25kP1JSz85re2YbMKno8
Re: RFS: lilo (updated package) (new Maintainer)
* Niels Thykier ni...@thykier.net, 2010-12-12, 16:05: --- lilo-22.8/debian/lilo.postinst +++ lilo-22.8-9/debian/lilo.postinst [...] + # to be compatible to older debian package + if [ ! -e /boot/sarge.bmp ]; then + ln -sf debian.bmp /boot/sarge.bmp fi [...] That debian.bmp, should that have been a /boot/debian.bmp? Nope, this symlink should be relative, as per Policy 10.5. -- Jakub Wilk signature.asc Description: Digital signature
Re: RFS: lilo (updated package) (new Maintainer)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 2010-12-12 16:34, Jakub Wilk wrote: * Niels Thykier ni...@thykier.net, 2010-12-12, 16:05: --- lilo-22.8/debian/lilo.postinst +++ lilo-22.8-9/debian/lilo.postinst [...] + # to be compatible to older debian package + if [ ! -e /boot/sarge.bmp ]; then + ln -sf debian.bmp /boot/sarge.bmp fi [...] That debian.bmp, should that have been a /boot/debian.bmp? Nope, this symlink should be relative, as per Policy 10.5. Thanks for the correction, I always manage to confuse myself with how ln works. ~Niels -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCAAGBQJNBO71AAoJEAVLu599gGRChRwQALY9sxDyYOj47A16U4TFRfZv w4hpTGH+uJSOl62oq6+jRa9mVpX/Q5vLDCMJMXjUdvAkDDrX/XbTGIM6HU8okEWc WX8Nn0i6xm34lgRtOwqBbwgfmW+qQkRQk+Np6P7cekJE5zMj+C5FCansI+KozymW LOkjSyofAKEo5RuRzDhmY9q3zGiWs2DUP+5yTL7qLo4XU9psUSi2UdMn0j8kDs79 sXlXsNRyPOOWOv3yO4DlXn1Qj8FOAR6z6RgQ+atgLbo4O5yFbLe8VJh0zK6UURJb rPrn6TYe3r+RB0+KTrRNLxrsM50iUvu+iY7nhvhmqXqNkqOmX342+MqXn6xgVo+B fPimsIMP2a2isS3rTLjHZTeHDSlrxlJBilwSjq9pXYjlVg0AnTqDsyAVB4IaoZts Y+JiampBZXsO0uOWGCRxWI16otYyeb2Hw9Pn2JduSg0AfsEzjnfdosgLWlqe+MMN cQ15Y8dsdVxGNufIEzwSbaH6P5pkE2sM20ifG0Cq/P/WwbuG+FTVT4gt1TK3BRZG yWOjE9SrzKa4SfO+Cr5+uqZlKqTG/PDkbCQjh+Dvtq1fIWpBWhLMAmKnQQvgQR8h /ojutYPCiCgpcyGI0kq0voSi+FW72Lx+6vs/RQBNfw/2YN1R7m51UnNBS/xkQysz bXdRCKmAR2ba8gB8mmwm =gYB4 -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4d04eef6.3040...@thykier.net
Re: RFS: lilo (updated package) (new Maintainer)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 2010-12-12 16:05, Niels Thykier wrote: On 2010-12-11 18:29, Joachim Wiedorn wrote: [...] This update of the LILO package (based on lilo 22.8-8.3) comes with a small set of bugfixes to work better within Squeeze. The target is to enter to testing before Squeeze will be released (I hope to the release team). Your priority being what it is; you should aim for fixing critical or highly annoying bugs with the minimal number of changes. If the diff gets to large, the release team may choose to reject it because they cannot keep track of the changes. Have you talked with the release team about the bugs you are fixing? I can understand the feeling of wanting to fix as much as possible, but the release team may feel the bugs are not important enough for the changes required. [...] Hi again, I had a chat with Mehdi on IRC and they seemed positive about the changes (even those I would have minimalised). I will have a second look at it and upload to unstable unless I notice a real issue. :) ~Niels -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCAAGBQJNBPCAAAoJEAVLu599gGRConoP/3ln/OYezmfmqzVuzHAMOdvP okbVx14Z0Fs6X5hRLd0ArrIACLX+vbe6/qnFNAwQzME/1posAIl2pvl8oDOSWlRi 50JvGRvxY1KleC8cG4ZFjoPOqpgkvu4JKKZM0v43YZN44YjEZSnmt/5Qiqpu7YBR xjoKzBwryX94U7APYaT/VB14+hat0Tfx1RSYYWE5SnoXaEa6GUpDBCo7813lT+O2 Zzzhl+rTuJqZ5bHCPwqtANc7zRSUQP7yctpnd+gVNGGBR1SQJBeAuSpfTC+ACDwm rZg6uttts3YaiZij1S6np8KABtCgh4ktq6eMnlfhCWvE/Z2b8MM6PeywyUUBXpWF KwD85fZdFsg8p1QiwXOhHPl4o+8G5F4nLYo6J/3qow9Kn035EPAAodiYvBs3jf/c i1lhgzarxz0DR8VehAu1sFIGtWs1KJ6/7afkKth1/xDGVJObtEVFtYekmgLGji0d RNQHdrCN4r2T89EM955f6VpkM2f4ZrZDnKAcRmlELRXs2Nnvd1mnP7IXE6PdjZej frnbpFxFe68GN8lfsFsC+tyB7PjE388FxEo6+VyC/4oRc03XZo4rSPK9mE2+Q9vF cFZsZHBzQVHp7S58QV7g+/afl0tC/ucg2gMIpBMtp+EZm0NwxDfBEdC9nkYv+F2M YtgHs0kS3ntJRFX0z+5L =2HiY -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4d04f081.8090...@thykier.net
Re: RFS: lilo (updated package) (new Maintainer)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 2010-12-11 18:29, Joachim Wiedorn wrote: Dear mentors, I am looking for a sponsor for the new version 1:22.8-9 of my package lilo. It builds these binary packages: lilo - LInux LOader - The Classic OS loader can load Linux and others lilo-doc - Documentation for LILO (LInux LOader) The package appears to be lintian clean. The upload would fix these bugs: 398957, 400642, 409285, 420587, 427507 [...] Kind regards Joachim Wiedorn Uploaded, thanks for your contribution to Debian. :) For the next non-Squeeze upload you may want to consider using the 3.0 (quilt) format, since it supports binary files in the debian dir (insteand of the uudecode) as well as cleaning up in the d/rules file (e.g. using dh_clean instead of multiple rm -f etc) Also the old maintainer is still listed as the primary maintainer in d/copyright. ~Niels -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCAAGBQJNBPXKAAoJEAVLu599gGRCDtcP/RpW1Pu1XyTZ+laMlcyKDEgi 5MIl4kp30Lzgjxvq1TgO237v/ETA9Fped4d5qr0/lYe0GOOTrFlga6JlETvDbKFP 37H2JhWEOM1bc4NJPxORAzuR34EroeMyE9SBQ1azUBQziusQPzoittMnCPkWd4ES Utu9I/n4X5hObemDEskm4X52IJCYo3PpqEtPPLqsBRgCLaQZ/RleAWimzFVx4DLw YFC/feHMdHsYH/IKLVJ9V6t12ehOo1AUnKzdqwIyZ569DauVsv2yWux9Ar+242VJ p6+SmL6Yq0Pb8sVU+v1HldNXdmjdXkaPkp+7D00iitTg/xOpRQQ0HaOhiJnxxmTE kBx6a1oRxXnFMOysXaNCAEyv3xILI/Ilt6uN52tAmm2SXWhPw+J4berOKJ9gD6hA ibvpAnGHXIwUzS/K4hWYCDghh30A3YvU9UP7nFyllko1Cg367qQeWIGpmowNacRH UgylpddVG+Pn7cQhOZNvJ+1dv2W84sWKaqseX6WOzdW78uSX0ZYlYeK0q+vG6CBf a2WWXmt150ESSzGGfCk2wHsDYB5F9JybehG9Ja2LZyYZKIxiwzwGCTVzhgqAnt8u pvgRVCNVbQOOYMkCL6Iwc6+OGAhWNvG0hmT9DBx5OwsPD/vvH5B0O8HKLa9lzotH 6PS68xkxjI0WO4ly1Nmp =gdZu -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4d04f5ce.90...@thykier.net
Re: RFS: lilo (updated package) (new Maintainer)
Hello Niels, Niels Thykier ni...@thykier.net wrote on 2010-12-12 16:05: I had a quick look at your package, though there are things I may have missed. Thanks for your review. Too much copy paste from the RFS template :) The binary package has 11 warnings (it also triggers a number of less severe tags e.g. I). Anyhow, considering you are targeting this for Squeeze, lintian-cleanless in itself is not a priority. I know that problem. The most problems come from the special script 'liloconfig' which uses with debconf (but it should not do). It is a legacy. Your priority being what it is; you should aim for fixing critical or highly annoying bugs with the minimal number of changes. If the diff gets to large, the release team may choose to reject it because they cannot keep track of the changes. Thanks for this hint. Have you talked with the release team about the bugs you are fixing? I can understand the feeling of wanting to fix as much as possible, but the release team may feel the bugs are not important enough for the changes required. I wrote to RT, there are some bugs which should be fixed for the next release (Squeeze). I hope they see the special situation of LILO maintaining. With the next major upgrade to 23.1 much more bugs can be fixed (for Squeeze +1). * Set source format 1.0. Add README.source file. I recommend undoing at least the README.source file; first off, it does not describe what it is supposed too and secondly even if you correct it, it has no functional change. The format part is only 1 line, so it is (probably) not going to disturb the reviewer too much. I have done it because of a lintian warning (because of format 1.0). But yes you are right. And I could use lintian-overrides. Should I do it for this one warning? I think this is cosmetic, isn't it? I had a look and: - --- lilo-22.8/debian/lilo.postinst +++ lilo-22.8-9/debian/lilo.postinst [...] + # to be compatible to older debian package + if [ ! -e /boot/sarge.bmp ]; then + ln -sf debian.bmp /boot/sarge.bmp fi [...] That debian.bmp, should that have been a /boot/debian.bmp? As Jakub already have said this is o.k. It seems stupid to take account of a file (or link) with the old sarge name, but until now this is the main menu bitmap of lilo and I think enough user have activated the use of this bitmap. In this snippet: - --- lilo-22.8/debian/rules +++ lilo-22.8-9/debian/rules @@ -23,6 +23,7 @@ dh_testdir make spotless -rm -f build debian/files debian/lilo.substvars [...] + -rm -f debian/*.debhelper.log debian/lilo-doc.substvars -rm -f doc/*.dvi doc/*.ps doc/*.aux doc/*.toc doc/*.log -rm -rf debian/lilo debian/lilo-doc debian/*.debhelper [...] [...] Most of these lines (incl. the one added) appear to be re-implementing dh_clean. Replacing those lines with dh_clean /might/ be better (because the release team knows what dh_clean does and do not need to verify the handmade version) That is also a legacy. But you are right: the best is to use dh_clean. I will change this in the next update. There are also a lot of po file updates, which are not translation changes. I presume they have been made by some tool (e.g. debconf-updatepo from the clean target). As far as I can tell it has just added a Language header and in some cases modified the translation Yes it it made because of debconf-updatepo, which runs in every debuild. (see debian/rules). It is needless? Then I remove it in the next update. Just in this minute I see my lilo package were sponsored by Julien BLACHE jbla...@debian.org. Should I nevertheless do an update of the package to give the release team the chance to let it into Squeeze? Have a nice day, Joachim (Germany) -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101212174624.2ad0a...@jupiter.home
Re: RFS: lilo (updated package) (new Maintainer)
Hello Niels, Niels Thykier ni...@thykier.net wrote on 2010-12-12 17:18: Uploaded, thanks for your contribution to Debian. :) Thank you very much! Now I hope to the release team. For the next non-Squeeze upload you may want to consider using the 3.0 (quilt) format, since it supports binary files in the debian dir (insteand of the uudecode) as well as cleaning up in the d/rules file (e.g. using dh_clean instead of multiple rm -f etc) The next (already made) package with lilo 23.1 will use all new dh methods with format 3.0 (quilt). You can see the unofficial packages here: http://lilo.alioth.debian.org/ftp/ Also the old maintainer is still listed as the primary maintainer in d/copyright. With the new file format (see above) it is gone. Have a nice day, Joachim (Germany) signature.asc Description: PGP signature
RFS: lilo (updated package) (new Maintainer)
Dear mentors, I am looking for a sponsor for the new version 1:22.8-9 of my package lilo. It builds these binary packages: lilo - LInux LOader - The Classic OS loader can load Linux and others lilo-doc - Documentation for LILO (LInux LOader) The package appears to be lintian clean. The upload would fix these bugs: 398957, 400642, 409285, 420587, 427507 The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/l/lilo - Source repository: deb-src http://mentors.debian.net/debian unstable main - dget http://mentors.debian.net/debian/pool/main/l/lilo/lilo_22.8-9.dsc I would be glad if someone uploaded this package for me. The CTTE disposed at 1st December that I am allowed to be the new Maintainer for the LILO package: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=587886#158 This update of the LILO package (based on lilo 22.8-8.3) comes with a small set of bugfixes to work better within Squeeze. The target is to enter to testing before Squeeze will be released (I hope to the release team). FYI here are the last changelog entry: lilo (1:22.8-9) unstable; urgency=low * New maintainter. * debian/patches: - Remove patch 16_geometry.patch for inaccessible disks and add information in README.Debian about using of 'inaccessible' option. (Closes: #409285, #400642) - Fix script checkit for newer gcc. - Fix for use LVM volume as root device. (Closes: #398957) - Fix for better computing vmlinux size, upgrade hints in README.Debian. (fixing sporadic failures). * Fix hook scripts: check for /sbin/lilo. * Add lacking file disk.com for creating test floppy. * Add universal menu image for debian, remove menu image for sarge. Update of template, postinst and postrm. (Closes: #420587, #427507) * Set source format 1.0. Add README.source file. * Update watch file to new alioth project area. * debian/control: - Remove VCS urls and add new Homepage url. - Remove IA64 architecture (this is already status quo). - Remove double lines of Priority and Section. - Add package conflicts to grub-pc and grub-legacy. - Remove conflicts to manpages. - Bump to Standards-Version 3.9.1 (without changes). Kind regards Joachim Wiedorn signature.asc Description: PGP signature
