Re: UNS: Re: RFS: lshell (3rd try)
Hola Maximiliano! - It would be great if you document how to use lshell inside a chroot, maybe even using makejail. Ok, a few other things to add to the TODO list: - Upstream changelog gets installed twice (CHANGES.gz and changelog.gz) - A little document describing some useful setups lshell, as git, bzr, cvs, svn, rsync. This will be done in the next release. Uploaded. Thank you for everything. Kind regards, Ignace Mouzannar -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: UNS: Re: RFS: lshell (3rd try)
On Tue, Jul 28, 2009 at 05:31, Maximiliano Curiam...@debian.org wrote: Hola Ignace Mouzannar! Hola Maximiliano! There a few ways to check if a group exists, calling sg group_name true is a creative one, I not against the solution, but using getent group group_name is probably a more traditional approach used in a few other packages, in general, it's good to accept the de facto standard. Thank you for the tip. This has been corrected. The debian/rules file has been modified to use debhelper without cdbs. Great, I appreciate the effort, I didn't mean do it right away, though. No worries, it was very useful for me to create a debian/rules file from scratch using only debhelper. Extra comments: - control claims Build-Dependency of debhelper = 7, but compat says 5, one or the other is wrong, please fix it. debian/compat has been set to 7. - manpage: As the manpage is gunzip'ed in the source of lshell-0.9.4, I released a new upstream version with a non compressed manpage including the modifications below. The new lshell version is 0.9.5 [1]. - Refers to group lshellg instead of lshell This has been corrected. - Doesn't mention the default config file (/etc/lshell.conf) I added this to the CONFIGURATION section. - ¿Why is there a section called TODO? I renamed this section as NOTES and moved it to the end of the manpage. - It would be great if you document how to use lshell inside a chroot, maybe even using makejail. I am planning to work on this in the upcoming release. A new package has been uploaded on m.d.n [2]. Thank you again for your help. Regards, Ignace M [1] http://lshell.ghantoos.org/ [2] The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/l/lshell - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/l/lshell/lshell_0.9.5-1.dsc -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: UNS: Re: RFS: lshell (3rd try)
Hola Ignace Mouzannar! El 29/07/2009 a las 01:20 escribiste: - It would be great if you document how to use lshell inside a chroot, maybe even using makejail. I am planning to work on this in the upcoming release. Ok, a few other things to add to the TODO list: - Upstream changelog gets installed twice (CHANGES.gz and changelog.gz) - A little document describing some useful setups lshell, as git, bzr, cvs, svn, rsync. Thank you again for your help. You are welcome, good work so far, keep it up. Uploaded. -- Confucius say: He who play in root, eventually kill tree. Saludos /\/\ /\ `/ -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: RFS: lshell (3rd try)
On Sat, Jul 25, 2009 at 00:51, Maximiliano Curiam...@gnuservers.com.ar wrote: Hola Ignace Mouzannar! Hola Maximiliano! A few comments, in decreasing severity order: - You are creating a group lshellg in postinst using groupadd, without checking the group existance, this would fail on reinstall, or upgrade, so, you to check the existance of the group, you should use addgroup instead of groupadd, the group should be called lshell, and it must be a system group (--system in addgroup). Or you can decide to use adm or nogroup. This has been corrected. - The tar.gz provided is not the same file that upstream distributes (you had probably recreated the tar.gz) This has been corrected. - The license states GPL 2 or any later version, the copyright file refers the user to the GPL-3 license, while this can hardly be a problem, it might be better to point the user to the GPL license lshell is distributed under GPL v3 or any later version. I have modified the debian/copyright file to mention the 3rd version of the GPL. - I personally don't like using cdbs, I suggest you to also learn to package using debhelper, as well The debian/rules file has been modified to use debhelper without cdbs. Thank you for your tips. Regards, Ignace Mouzannar -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: UNS: Re: RFS: lshell (3rd try)
Hola Ignace Mouzannar! El 27/07/2009 a las 12:19 escribiste: - You are creating a group lshellg in postinst using groupadd, without checking the group existance, this would fail on reinstall, or upgrade, so, you to check the existance of the group, you should use addgroup instead of groupadd, the group should be called lshell, and it must be a system group (--system in addgroup). Or you can decide to use adm or nogroup. This has been corrected. There a few ways to check if a group exists, calling sg group_name true is a creative one, I not against the solution, but using getent group group_name is probably a more traditional approach used in a few other packages, in general, it's good to accept the de facto standard. The debian/rules file has been modified to use debhelper without cdbs. Great, I appreciate the effort, I didn't mean do it right away, though. Extra comments: - control claims Build-Dependency of debhelper = 7, but compat says 5, one or the other is wrong, please fix it. - manpage: - Refers to group lshellg instead of lshell - Doesn't mention the default config file (/etc/lshell.conf) - ¿Why is there a section called TODO? - It would be great if you document how to use lshell inside a chroot, maybe even using makejail. -- La duración de un minuto depende de que lado del baño estés. -- Ley de la Relatividad (Burke) Saludos /\/\ /\ `/ -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
RFS: lshell (3rd try)
Dear mentors, I am looking for a sponsor for my package lshell. I have made some modifications in the debian/control as well as debian/lshell.postinst files, and added a debian/lshell.dirs file. lshell now uses python-support instead of python-central. * Package name: lshell Version : 0.9.4-1 Upstream Author : Ignace Mouzannar mouzan...@gmail.com * URL : http://lshell.ghantoos.org * License : GPL Section : shells It builds these binary packages: lshell - restricts a user's shell environment to limited sets of commands lshell is a shell coded in Python that lets you restrict a user's environment to limited sets of commands, choose to enable/disable any command over SSH (e.g. SCP, SFTP, rsync, etc.), log user's commands, implement timing restrictions, and more. The package appears to be lintian clean. The upload would fix these bugs: 503437 The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/l/lshell - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/l/lshell/lshell_0.9.4-1.dsc I would be glad if someone reviewed/uploaded this package for me. Thank you for your time. Kind regards Ignace Mouzannar -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: RFS: lshell (3rd try)
Hola Ignace Mouzannar! El 24/07/2009 a las 11:18 escribiste: I am looking for a sponsor for my package lshell. I have made some modifications in the debian/control as well as debian/lshell.postinst files, and added a debian/lshell.dirs file. lshell now uses python-support instead of python-central. * Package name: lshell Version : 0.9.4-1 Upstream Author : Ignace Mouzannar mouzan...@gmail.com * URL : http://lshell.ghantoos.org * License : GPL Section : shells It builds these binary packages: lshell - restricts a user's shell environment to limited sets of commands lshell is a shell coded in Python that lets you restrict a user's environment to limited sets of commands, choose to enable/disable any command over SSH (e.g. SCP, SFTP, rsync, etc.), log user's commands, implement timing restrictions, and more. A few comments, in decreasing severity order: - You are creating a group lshellg in postinst using groupadd, without checking the group existance, this would fail on reinstall, or upgrade, so, you to check the existance of the group, you should use addgroup instead of groupadd, the group should be called lshell, and it must be a system group (--system in addgroup). Or you can decide to use adm or nogroup. - The tar.gz provided is not the same file that upstream distributes (you had probably recreated the tar.gz) - The license states GPL 2 or any later version, the copyright file refers the user to the GPL-3 license, while this can hardly be a problem, it might be better to point the user to the GPL license - I personally don't like using cdbs, I suggest you to also learn to package using debhelper, as well -- We must be very careful when we give advice to younger people: sometimes they follow it! -- Edsger W. Dijkstra Saludos /\/\ /\ `/ -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
