Bug#827149: marked as done (RFS: triggerhappy/0.4.0-1)
Your message dated Tue, 14 Jun 2016 04:28:13 + with message-id and subject line closing RFS: triggerhappy/0.4.0-1 has caused the Debian Bug report #827149, regarding RFS: triggerhappy/0.4.0-1 to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 827149: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=827149 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems --- Begin Message --- Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "triggerhappy" * Package name: triggerhappy Version : 0.4.0-1 Upstream Author : Stefan Tomanek * URL : https://github.com/wertarbyte/triggerhappy * License : GPLv3 Section : utils It builds those binary packages: triggerhappy - global hotkey daemon for Linux To access further information about this package, please visit the following URL: https://mentors.debian.net/package/triggerhappy Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/t/triggerhappy/triggerhappy_0.4.0-1.dsc More information about hello can be obtained from https://www.example.com. Changes since the last upload: * update to version 0.4.0 (closes: bug#827079, bug#769184) * adapt to newer debian packaging standards Regards, Stefan Tomanek --- End Message --- --- Begin Message --- Package triggerhappy version 0.4.0-1 is in unstable now. https://packages.qa.debian.org/triggerhappy--- End Message ---
Bug#827149: RFS: triggerhappy/0.4.0-1
control: owner -1 andre...@debian.org (no idea why I was replying from a wrong email) On 13 June 2016 at 16:03, Gianfranco Costamagna wrote: > control: owner -1 andrew.shado...@gmail.com > >>I think I could. > setting you as owner :) Thanks! >>There's https://github.com/wertarbyte/triggerhappy/commits/systemd but >>I haven't looked how much does it conflict with the master branch. > > > I did merge the systemd branch into master, and it merged correctly. > > $ git branch --contains bb2df386dd6e47edf442e684c78a87a2e979f5ac > systemd > > indeed, it has never been merged into it, so no part of the current release. -- Cheers, Andrew
Bug#827149: RFS: triggerhappy/0.4.0-1
control: owner -1 andrew.shado...@gmail.com >I think I could. setting you as owner :) >There's https://github.com/wertarbyte/triggerhappy/commits/systemd but >I haven't looked how much does it conflict with the master branch. I did merge the systemd branch into master, and it merged correctly. $ git branch --contains bb2df386dd6e47edf442e684c78a87a2e979f5ac systemd indeed, it has never been merged into it, so no part of the current release. G.
Bug#827149: RFS: triggerhappy/0.4.0-1
On 13 June 2016 at 15:47, Gianfranco Costamagna wrote: > control: owner -1 ! > >>Hi, could you please also ship my systemd integration (see upstream PR and >>branch)? > > > Andrew, do you plan to upload the package once this is fixed? I think I could. > I see Jakub already did a wonderful review, and the current package on > mentors seems > to address his concerns. > > I see your pull request doesn't merge anymore on current branch... There's https://github.com/wertarbyte/triggerhappy/commits/systemd but I haven't looked how much does it conflict with the master branch. -- Cheers, Andrew
Bug#827149: RFS: triggerhappy/0.4.0-1
control: owner -1 ! >Hi, could you please also ship my systemd integration (see upstream PR and >branch)? Andrew, do you plan to upload the package once this is fixed? I see Jakub already did a wonderful review, and the current package on mentors seems to address his concerns. I see your pull request doesn't merge anymore on current branch... G.
Bug#827149: RFS: triggerhappy/0.4.0-1
On 13 Jun 2016 00:03, "Stefan Tomanek" wrote: > > Package: sponsorship-requests > Severity: normal > > Dear mentors, > > I am looking for a sponsor for my package "triggerhappy" > > * Package name: triggerhappy >Version : 0.4.0-1 >Upstream Author : Stefan Tomanek > * URL : https://github.com/wertarbyte/triggerhappy > * License : GPLv3 >Section : utils > > It builds those binary packages: > > triggerhappy - global hotkey daemon for Linux > > To access further information about this package, please visit the following URL: > > https://mentors.debian.net/package/triggerhappy > > > Alternatively, one can download the package with dget using this command: > > dget -x https://mentors.debian.net/debian/pool/main/t/triggerhappy/triggerhappy_0.4.0-1.dsc > > More information about hello can be obtained from https://www.example.com. > > Changes since the last upload: > >* update to version 0.4.0 (closes: bug#827079, bug#769184) >* adapt to newer debian packaging standards Hi, could you please also ship my systemd integration (see upstream PR and branch)? -- Cheers, Andrew
Bug#827149: RFS: triggerhappy/0.4.0-1
Control: tags -1 + moreinfo [I don't intend to sponsor this package.] * Stefan Tomanek , 2016-06-12, 23:59: https://mentors.debian.net/debian/pool/main/t/triggerhappy/triggerhappy_0.4.0-1.dsc Bumping compat to 9 is not documented in the changelog. Please double-check that all other changes are documented, too. Your copyright file says "License: GPL-3", but it's "GPLv3 or any later version" according to upstream source. Also, it's not enough to say "On Debian systems, the full text ..." in the License field. You need to actually quote the license statement, i.e. "You have permission to copy, modify, and redistribute ...". Tagging this bug moreinfo, because the update would introduce an RC bug. -- Jakub Wilk
Bug#827149: RFS: triggerhappy/0.4.0-1
Good morning, Dies schrieb Sean Whitton (spwhit...@spwhitton.name): > On Sun, Jun 12, 2016 at 11:59:34PM +0200, Stefan Tomanek wrote: > > Changes since the last upload: > > > >* update to version 0.4.0 (closes: bug#827079, bug#769184) > > Although this bug closing syntax is acceptable, it's marked as "not > preferred" Developer's Reference section 5.8.4. You might consider the > more usual syntax: > > Closes: #769184, #827079 > > and you should perhaps mention that 0.4.0 is a new *upstream* version. > > >* adapt to newer debian packaging standards > > Could you be more verbose here, please? What you wrote could mean a lot > of things! Thanks for your input, I adjusted the changelog accordingly and reuploaded the package.
Bug#827149: RFS: triggerhappy/0.4.0-1
Dear Stegan, On Sun, Jun 12, 2016 at 11:59:34PM +0200, Stefan Tomanek wrote: > Changes since the last upload: > >* update to version 0.4.0 (closes: bug#827079, bug#769184) Although this bug closing syntax is acceptable, it's marked as "not preferred" Developer's Reference section 5.8.4. You might consider the more usual syntax: Closes: #769184, #827079 and you should perhaps mention that 0.4.0 is a new *upstream* version. > >* adapt to newer debian packaging standards Could you be more verbose here, please? What you wrote could mean a lot of things! -- Sean Whitton signature.asc Description: PGP signature
Bug#827149: RFS: triggerhappy/0.4.0-1
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "triggerhappy" * Package name: triggerhappy Version : 0.4.0-1 Upstream Author : Stefan Tomanek * URL : https://github.com/wertarbyte/triggerhappy * License : GPLv3 Section : utils It builds those binary packages: triggerhappy - global hotkey daemon for Linux To access further information about this package, please visit the following URL: https://mentors.debian.net/package/triggerhappy Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/t/triggerhappy/triggerhappy_0.4.0-1.dsc More information about hello can be obtained from https://www.example.com. Changes since the last upload: * update to version 0.4.0 (closes: bug#827079, bug#769184) * adapt to newer debian packaging standards Regards, Stefan Tomanek
RFS: triggerhappy
Dear mentors, I am looking for a sponsor for my package "triggerhappy". * Package name: triggerhappy Version : 0.3.4-2 Upstream Author : Stefan Tomanek * URL : https://github.com/wertarbyte/triggerhappy * License : GPLv3 Section : utils It builds these binary packages: triggerhappy - global hotkey daemon for Linux The package appears to be lintian clean. My motivation for maintaining this package is: I've written this little daemon software to allow the global handling of hotkeys. While many window managers offer such a functionality, they require a specific user being logged in, having the focus and running an X session. Triggerhappy observes the input device files provided by the kernel and can react to pressed keys, switches and buttons even on headless systems. It offers a few distinct features that set it apart from the few existing solutions: * system scope There is no need for anyone being logged in, since the daemon operates on a system wide scale, allowing e.g. the regulation of volume while using the console or the login manager. * hotplug capabilities A running triggerhappy daemon (thd) can handle an arbitrary number of input devices; devices can be added and removed without restarting the daemon by calling a helper program. A udev rule to inform the daemon about new devices is included. * optional exclusive grabbing of devices While usually running alongside the normal X session, thd can grab devices exclusively when instructed to do so; this way input events from those devices won't be handled by other software * generating synthetic events triggerhappy can not only launch arbitrary commands, but also generate input event itself by using uinput. By doing so, thd can grab input events from a device exclusively while channeling or even remap selected input events * support of different modes The triggerhappy daemon supports modes, allowing one to define several sets of key binding. Modes can be switched on-the-fly using the th-cmd command line utility or a predefined key Having this package uploaded to Debian would fill the gap I tried to fill by developing and packaging this tool; I'm using it on my notebook systems to regulate volume, as well as on my armel-Dockstar systems to control an mpd media player, where it proved useful as well due to its low memory footprint. Considering that there is currently no other software offering these features, I'd really appreciate the addition of my program to Debian. If you'd like to see any changes in the program or package, feel free to contact me. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/t/triggerhappy - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/t/triggerhappy/triggerhappy_0.3.4-2.dsc I would be glad if someone uploaded this package for me. Kind regards Stefan Tomanek signature.asc Description: Digital signature
Re: RFS: triggerhappy (retry)
Hello and thanks for your reply, Dies schrieb Stanislav Maslovski (stanislav.maslov...@gmail.com): > But the orig.tar.gz does not have it either, so it is probably OK by > now, however, you may consider adding it in future, because your work > may be of interest to other distributions, and for them the Debian > changelog is not a substitution for upstream's one. Sure, adding a changelog is something I'm considering to do, but I haven't gotten around to it. > A somewhat related note: the patch debian-changes-0.3.4-1 in > debian/patches contains changes that actually belong to upstream. As > you are the upstream it should not be a problem to incorporate them in > the proper place. Actually, uscan --verbose shows that you have not > even oficially released the version 0.3.4 yet, while you have already > packaged it for Debian! This is not good. I forgot to push the tag for release 0.3.4 to github, that's why the release was missing from the uscan output. It probably also caused the changes to appear to appear in the debian patch file. > Your debian/control insists on having debhelper (>= 7.0.50~) but as > you do not use any of the override-* directives, I think that (>= 7) > should suffice. Thanks, I'll see if I can use these more relaxed requirements. > Your debian/copyright is mostly OK, however, you may consider making > it more DEP-5 aware (http://dep.debian.net/deps/dep5/). In any case, > the copyright lines must match exactly what you have in the source > files, please amend your Copyright: paragraph respectively. There is > no need for any angular brackets around the copyright line; these > brackets most likely came from the template. > > You may also consider removing redundant comments that came from > templates and are seen in your init.d script and debian/rules file. Thanks for your input, I'll try to hunt down these issues. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110313125637.gd23...@zirkel.wertarbyte.de
Re: RFS: triggerhappy (retry)
On Wed, Mar 09, 2011 at 02:57:12PM +0100, Stefan Tomanek wrote: > Dear mentors, > > I am looking for a sponsor for my package "triggerhappy". [skipped] Dear Stefan, Thanks for your work on this software. I am not a DD, and cannot be an uploader for your package, but I have a strong opinion that your work deserves to be included in Debian. Therefore, I hope that an interested DD will show up. Here are my comments regarding the packaging: The package builds OK (tested in squeeze). lintian -I --pedantic displays a warning about missing upstream changelog: % lintian -I --pedantic ../triggerhappy_0.3.4-1_i386.deb P: triggerhappy: no-upstream-changelog But the orig.tar.gz does not have it either, so it is probably OK by now, however, you may consider adding it in future, because your work may be of interest to other distributions, and for them the Debian changelog is not a substitution for upstream's one. A somewhat related note: the patch debian-changes-0.3.4-1 in debian/patches contains changes that actually belong to upstream. As you are the upstream it should not be a problem to incorporate them in the proper place. Actually, uscan --verbose shows that you have not even oficially released the version 0.3.4 yet, while you have already packaged it for Debian! This is not good. Your debian/control insists on having debhelper (>= 7.0.50~) but as you do not use any of the override-* directives, I think that (>= 7) should suffice. Your debian/copyright is mostly OK, however, you may consider making it more DEP-5 aware (http://dep.debian.net/deps/dep5/). In any case, the copyright lines must match exactly what you have in the source files, please amend your Copyright: paragraph respectively. There is no need for any angular brackets around the copyright line; these brackets most likely came from the template. You may also consider removing redundant comments that came from templates and are seen in your init.d script and debian/rules file. -- Stanislav -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110313121818.GA5534@kaiba.homelan
RFS: triggerhappy (retry)
Dear mentors, I am looking for a sponsor for my package "triggerhappy". * Package name: triggerhappy Version : 0.3.4-1 Upstream Author : Stefan Tomanek * URL : https://github.com/wertarbyte/triggerhappy * License : GPLv3 Section : utils It builds these binary packages: triggerhappy - global hotkey daemon for Linux The package appears to be lintian clean. My motivation for maintaining this package is: I've written this little daemon software to allow the global handling of hotkeys. While many window managers offer such a functionality, they require a specific user being logged in, having the focus and running an X session. Triggerhappy observes the input device files provided by the kernel and can react to pressed keys, switches and buttons even on headless systems. It offers a few distinct features that set it apart from the few existing solutions: * system scope There is no need for anyone being logged in, since the daemon operates on a system wide scale, allowing e.g. the regulation of volume while using the console or the login manager. * hotplug capabilities A running triggerhappy daemon (thd) can handle an arbitrary number of input devices; devices can be added and removed without restarting the daemon by calling a helper program. A udev rule to inform the daemon about new devices is included. * optional exclusive grabbing of devices While usually running alongside the normal X session, thd can grab devices exclusively when instructed to do so; this way input events from those devices won't be handled by other software * generating synthetic events triggerhappy can not only launch arbitrary commands, but also generate input event itself by using uinput. By doing so, thd can grab input events from a device exclusively while channeling or even remap selected input events * support of different modes The triggerhappy daemon supports modes, allowing one to define several sets of key binding. Modes can be switched on-the-fly using the th-cmd command line utility or a predefined key Having this package uploaded to Debian would fill the gap I tried to fill by developing and packaging this tool; I'm using it on my notebook systems to regulate volume, as well as on my armel-Dockstar systems to control an mpd media player, where it proved useful as well due to its low memory footprint. Considering that there is currently no other software offering these features, I'd really appreciate the addition of my program to Debian. If you'd like to see any changes in the program or package, feel free to contact me. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/t/triggerhappy - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/t/triggerhappy/triggerhappy_0.3.4-1.dsc I would be glad if someone uploaded this package for me. Kind regards Stefan Tomanek signature.asc Description: Digital signature
RFS: triggerhappy (retry)
Dear mentors, I am looking for a sponsor for my package "triggerhappy". * Package name: triggerhappy Version : 0.3.3-1 Upstream Author : Stefan Tomanek * URL : https://github.com/wertarbyte/triggerhappy * License : GPLv3 Section : utils It builds these binary packages: triggerhappy - global hotkey daemon for Linux The package appears to be lintian clean. My motivation for maintaining this package is: I've written this little daemon software to allow the global handling of hotkeys. While many window managers offer such a functionality, they require a specific user being logged in, having the focus and running an X session. Triggerhappy observes the input device files provided by the kernel and can react to pressed keys, switches and buttons even on headless systems. It offers a few distinct features that set it apart from the few existing solutions: * system scope There is no need for anyone being logged in, since the daemon operates on a system wide scale, allowing e.g. the regulation of volume while using the console or the login manager. * hotplug capabilities A running triggerhappy daemon (thd) can handle an arbitrary number of input devices; devices can be added and removed without restarting the daemon by calling a helper program. A udev rule to inform the daemon about new devices is included. * optional exclusive grabbing of devices While usually running alongside the normal X session, thd can grab devices exclusively when instructed to do so; this way input events from those devices won't be handled by other software * generating synthetic events triggerhappy can not only launch arbitrary commands, but also generate input event itself by using uinput. By doing so, thd can grab input events from a device exclusively while channeling or even remap selected input events * support of different modes The triggerhappy daemon supports modes, allowing one to define several sets of key binding. Modes can be switched on-the-fly using the th-cmd command line utility or a predefined key Having this package uploaded to Debian would fill the gap I tried to fill by developing and packaging this tool; I'm using it on my notebook systems to regulate volume, as well as on my armel-Dockstar systems to control an mpd media player, where it proved useful as well due to its low memory footprint. Considering that there is currently no other software offering these features, I'd really appreciate the addition of my program to Debian. If you'd like to see any changes in the program or package, feel free to contact me. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/t/triggerhappy - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/t/triggerhappy/triggerhappy_0.3.3-1.dsc I would be glad if someone uploaded this package for me. Kind regards Stefan Tomanek signature.asc Description: Digital signature
RFS: triggerhappy
Dear mentors, I am looking for a sponsor for my package "triggerhappy". * Package name: triggerhappy Version : 0.3.3-1 Upstream Author : Stefan Tomanek * URL : https://github.com/wertarbyte/triggerhappy * License : GPLv3 Section : utils It builds these binary packages: triggerhappy - global hotkey daemon for Linux The package appears to be lintian clean. My motivation for maintaining this package is: I've written this little ademon software to allow the global handling of hotkeys. While many window managers offer such a functionality, they require a specific user being logged in, having the focus and running an X session. Triggerhappy observes the input device files provided by the kernel and can react to pressed keys, switches and buttons even on headless systems. It offers a few distinct features that set it apart from the few existing solutions: * system scope There is no need for anyone being logged in, since the daemon operates on a system wide scale, allowing e.g. the regulation of volume while using the console or the login manager * hotplug capabilities A running triggerhappy daemon (thd) can handle an arbitrary number of input devices; devices can be added and removed without restarting the daemon. A udev rule to inform the daemon about new devices is included. * optional exclusive grabbing of devices While usually running alongside the normal X session, thd can grab devices exclusively when instructed to do so; this way input events from those devices won't be handled by other software * generating synthetic events triggerhappy can not only launch arbitrary commands, but also generate input event itself by using uinput. By doing so, thd can grab input events from a device exclusively while channeling or even remap selected input events * support of different modes The triggerhappy daemon supports modes, allowing one to define several sets of key binding. Modes can be switched on-the-fly using the th-cmd command line utility or a predefined key Having this package uploaded to Debian would fill the gap I tried to fill by developing and packaging this tool; I'm using it on my notebook systems to regulate volume as well as my armel-Dockstar systems to control an mpd media player, where it proved useful as well due to its low memory footprint. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/t/triggerhappy - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/t/triggerhappy/triggerhappy_0.3.3-1.dsc I would be glad if someone uploaded this package for me. Kind regards Stefan Tomanek signature.asc Description: Digital signature
RFS: triggerhappy
Dear mentors, I am looking for a sponsor for my package "triggerhappy". * Package name: triggerhappy Version : 0.3.2-1 Upstream Author : Stefan Tomanek * URL : http://github.com/wertarbyte/triggerhappy * License : GPL Section : utils It builds these binary packages: triggerhappy - global hotkey daemon for Linux The package appears to be lintian clean. My motivation for maintaining this package is: Looking for a way of globally assigning hotkey handlers to the special keys found on my notebooks, I developed triggerhappy. I also use it to control headless systems, e.g. a ARM based MPD jukebox which is controlled by a USB keypad or bluetooth wiimote. Having this software in Debian would provide an easy way to bind commands to input events without the need for running an X11 session or logging in. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/t/triggerhappy - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/t/triggerhappy/triggerhappy_0.3.2-1.dsc I would be glad if someone uploaded this package for me. Kind regards Stefan Tomanek -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110120223231.gl18...@zirkel.wertarbyte.de
Re: RFS: triggerhappy
Dies schrieb Nick Leverton (n...@leverton.org): > > Every .c-file has to contain that header? Sure, possible, but seems very > > awkward? > > It helps, the Debian tool licensecheck can then scan and report on the > contents of the package. Also if a source is borrowed elsewhere, the > authorship is still clear. Do you have an example for such an header? I tried a few variants, but could not get licensecheck to work. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110118214753.gi18...@zirkel.wertarbyte.de
Re: RFS: triggerhappy
On Fri, Dec 24, 2010 at 06:00:53PM +0100, Stefan Tomanek wrote: > Dies schrieb Nick Leverton (n...@leverton.org): > > > I gather that this is a new package to Debian. Your debian/changelog > > should probably start from new in that case. > > I'm not sure about that and I heard different opinions about it - does > it hurt to keep the old history? OK, it'll survive inside the git repository, > but is removing the history before the package introduction really necessary? You're right that opinions vary and some uploaders may not mind. > > The new debian/changelog should start with the new version, 0.3.1-1, > > and should Close: your ITP bug #603842 (you've closed it in a version > > which AFAICS has never been in Debian). > > Sure, adding that line would be the first thing I'd do once someone volunteers > to sponsor the package. Ok - my preference as a maintainer is to make the package as ready as possible, as sponsors are often busy. That said they will often make valuable corr^Wcontributions anyway ! > > The source files licensing (author, date and a pointer to COPYING) needs > > to be made explicit in each file, via a comment block near the top: > > http://lists.debian.org/debian-mentors/2009/03/msg00451.html > > Are you your own upstream ? This could be easy to apply then :) > > Every .c-file has to contain that header? Sure, possible, but seems very > awkward? It helps, the Debian tool licensecheck can then scan and report on the contents of the package. Also if a source is borrowed elsewhere, the authorship is still clear. > > Sorry this took so long to write up, hope you can have a happy > > $FESTIVITIES and write some more cool code for Debian :-) > > Well, thanks for your review, I'll try to do both :-) Thanks for your contribution to Debian ! Nick -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101224205243.ga27...@leverton.org
Re: RFS: triggerhappy
Dies schrieb Nick Leverton (n...@leverton.org): > I gather that this is a new package to Debian. Your debian/changelog > should probably start from new in that case. You could perhaps move > the existing debian/changelog to changelog.OLD or similar, if you want > to retain the history of the code's evolution before it entered Debian. I'm not sure about that and I heard different opinions about it - does it hurt to keep the old history? OK, it'll survive inside the git repository, but is removing the history before the package introduction really necessary? > The new debian/changelog should start with the new version, 0.3.1-1, > and should Close: your ITP bug #603842 (you've closed it in a version > which AFAICS has never been in Debian). Sure, adding that line would be the first thing I'd do once someone volunteers to sponsor the package. > The source files licensing (author, date and a pointer to COPYING) needs > to be made explicit in each file, via a comment block near the top: > http://lists.debian.org/debian-mentors/2009/03/msg00451.html > Are you your own upstream ? This could be easy to apply then :) Every .c-file has to contain that header? Sure, possible, but seems very awkward? > Sorry this took so long to write up, hope you can have a happy > $FESTIVITIES and write some more cool code for Debian :-) Well, thanks for your review, I'll try to do both :-) -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101224170053.gb4...@zirkel.wertarbyte.de
Re: RFS: triggerhappy
On Sat, Dec 18, 2010 at 03:10:21PM +0100, Stefan Tomanek wrote: > > Looking for a way of globally assigning hotkey handlers to the special keys > found on my notebooks, I developed triggerhappy. I also use it to control > headless systems, e.g. a ARM based MPD jukebox which is controlled by a USB > keypad or bluetooth wiimote. Having this software in Debian would provide an > easy way to bind commands to input events without the need for running an > X11 session or logging in. Hi, I am not a DD so cannot upload your package, however in the light of the previous discussion on -mentors it looks interesting, so I have checked it out. I gather that this is a new package to Debian. Your debian/changelog should probably start from new in that case. You could perhaps move the existing debian/changelog to changelog.OLD or similar, if you want to retain the history of the code's evolution before it entered Debian. The new debian/changelog should start with the new version, 0.3.1-1, and should Close: your ITP bug #603842 (you've closed it in a version which AFAICS has never been in Debian). The source files licensing (author, date and a pointer to COPYING) needs to be made explicit in each file, via a comment block near the top: http://lists.debian.org/debian-mentors/2009/03/msg00451.html Are you your own upstream ? This could be easy to apply then :) As this is new to Debian, perhaps you could look at doing your debian/copyright file along the lines of DEP-5 to help in automated licence checks ? Your copyright file is quite clear, DEP-5 is just a suggested format which sums it up in a standard way. I can't find the current format just at the moment ... anyone know it please ? Sorry this took so long to write up, hope you can have a happy $FESTIVITIES and write some more cool code for Debian :-) Nick -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101224164037.ga21...@leverton.org
Re: RFS: triggerhappy
Dies schrieb Niels Thykier (ni...@thykier.net): > I just cloned the git repository and I cannot reproduce any more either. > I suspect this is because you fixed the buffer variable going out of scope. OK, I think now I incorporated all your suggested fixes and uploaded a new package with version 0.3.2-1. Thanks again for your review. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101221122307.gx4...@zirkel.wertarbyte.de
Re: RFS: triggerhappy
Dies schrieb Niels Thykier (ni...@thykier.net): > I just cloned the git repository and I cannot reproduce any more either. > I suspect this is because you fixed the buffer variable going out of scope. Strange, I did not touch anything in that section of code. But anyhow, I'm glad that warning is gone now :-) -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101221114340.gw4...@zirkel.wertarbyte.de
Re: RFS: triggerhappy
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 2010-12-21 11:48, Stefan Tomanek wrote: > Dies schrieb Niels Thykier (ni...@thykier.net): > >> It might be because you have a different version than I; I am using 1.44 >> (from testing). > > So am I: > > ste...@exa:~$ cppcheck --version > Cppcheck 1.44 > > I just cloned the git repository and I cannot reproduce any more either. I suspect this is because you fixed the buffer variable going out of scope. ~Niels -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCAAGBQJNEJGqAAoJEAVLu599gGRCAZ0P/1hUi3yQCHNk4yyQKeehzkDS cNMWqrhAOHJ+XFfdCNFw2k23Tls3sFFCYwFR7ya2FIQOinDgENLYELwqg0f9cSVu lL8D5MTYX1SKkODK8XND5kcmmrhDBTr7rPmzfjNpCZtGMc8Ehu2CifrMclivl1H+ 5tDs3vcCBJh9D/U6Y5OfZNq7w5q9mZ4Ln7YlXLOsGDq0KulGo2iuGBmrAPiDcvjy BlcJWe7N0/ElhVhbpfNypPnJfFybSMJ63bc+ByR8MCTPL7PZB+U8jMHNelr1RScr RkF/rDBF0hLxDrhReHAwx5LtWWvrebJUlyyOPgy8B/uUdwwAjFI8RO8m57GAhGgK zhtvVrLXgqe2gsShP+0Gs5D9xdyxnwx8z7VNF+QWuFjpsiLgCuffyBU/3K1/dVcq Zm9TTets9ChzTHNczrP5pTB7jQNWf5P031Rob9i5+awR5Z0coAvyZkdlQW82SH8R 35gKTxmLA7EMKQwO0V1bmywZf8oOqp5JKVYxKAr76CNGcvyuzkC24bwy8tTXpTku l7cRfEyaWidfIsSD5/feL0xoxr2v2X4wm5MWX0mEEA5o8EPNPXkmnQ7dtZhpAyNG 1ey/Tp0gvcjIfhb6lSDWfk/upP+HwAhYakHmpt9pux9DPVumLK2hFMG3+o0KVnUX z9295VrhTYmqSsrtsG2m =5pND -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4d1091ab.3040...@thykier.net
Re: RFS: triggerhappy
Dies schrieb Niels Thykier (ni...@thykier.net): > It might be because you have a different version than I; I am using 1.44 > (from testing). So am I: ste...@exa:~$ cppcheck --version Cppcheck 1.44 -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101221104819.gu4...@zirkel.wertarbyte.de
Re: RFS: triggerhappy
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 2010-12-20 21:20, Stefan Tomanek wrote: > Dies schrieb Niels Thykier (ni...@thykier.net): > Checking cmdsocket.c... [cmdsocket.c:126]: (error) Resource leak: fd > [...] >> Okay, perhaps you could document this in the code that this is >> intentional (e.g. transmitting the fd and the leak is a false-positive)? > > I'm playing around with cppcheck myself, but I cannot reproduce the message > above; > how did you call the program? > [...] It might be because you have a different version than I; I am using 1.44 (from testing). ~Niels -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCAAGBQJNEIOhAAoJEAVLu599gGRCScMQAJYvXHea6sJBjI5K1SiIlm5Y M62IFy7H4e2Tr16nvtwIzzz0ZISctEif0kAcuZjAYBEBpK7ZEgN3mgqdS9ft1vo9 UNp7rmqpnnN6PvpGQY/7l7JI6mXS5GW9DPzPNjI7e/GmQqAVYReSk3+s5Xz30SLM 0OcVPg6FPSGlXKupZYoj8lRuKdLGcTvEoiyo14T7RNPV+ZehuiDkzincAQ19070C GUjkPQFxFyG4ZrAUtf8KR0Y9oNwfQ4W0ifT7HuH1649Wqe0YN/eV9o04YMk6dQK6 7yejbtvYWMdg89JG2eyju11F6M4Fb3W2j8GDsawj3XB3W0LnbAtr49BVQ1F6iTKQ PMZHpV78xqd27H4GS1MQ8WIE5k/2YR+pbKTDyxfMFkWLtbIKSa6ZySkpE43PiDtu chEfGT5LVc9Rpe+LC9AtAobBS0JsYgYsOqzLGpmYpPqdaQWBjZcmHl+V8Krk4KV1 jHIm+FpfgKLVn2unZZj/M9/XNf34G2RPxqDU4M82e3Qi2g5G1bPYi/uafgH8Lkte TnRz66NxKCDMJLTOavobrS4aCj5rIDU8NpJ2Ckh0mVhoa506NiXAFw66jcwlV1AX rNpHOGjQsKHQ9Vgl0xK8GeKhWcn3z9AvD5VQ07D/lAyIiec/sFLsVYzHA1RhDqub QCabmNugL7beV/GTubp6 =4RLM -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4d1083a1.3060...@thykier.net
Re: RFS: triggerhappy
Dies schrieb Niels Thykier (ni...@thykier.net): > >> Checking cmdsocket.c... > >> [cmdsocket.c:126]: (error) Resource leak: fd [...] > Okay, perhaps you could document this in the code that this is > intentional (e.g. transmitting the fd and the leak is a false-positive)? I'm playing around with cppcheck myself, but I cannot reproduce the message above; how did you call the program? ste...@exa:~/git/triggerhappy$ cppcheck . --enable=all -v Checking ./cmdsocket.c... 1/11 files checked 9% done Checking ./devices.c... 2/11 files checked 18% done Checking ./eventnames.c... 3/11 files checked 27% done Checking ./ignore.c... 4/11 files checked 36% done Checking ./keystate.c... 5/11 files checked 45% done Checking ./obey.c... 6/11 files checked 54% done Checking ./th-cmd.c... 7/11 files checked 63% done Checking ./thd.c... 8/11 files checked 72% done Checking ./trigger.c... 9/11 files checked 81% done Checking ./triggerparser.c... 10/11 files checked 90% done Checking ./uinput.c... 11/11 files checked 100% done Checking usage of global functions.. [./trigger.c:1]: (style) The function 'count_triggers' is never used [./ignore.c:1]: (style) The function 'print_ignores' is never used ste...@exa:~/git/triggerhappy$ I've pushed the changes done so far to my git repository. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101220202027.gs4...@zirkel.wertarbyte.de
Re: RFS: triggerhappy
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 2010-12-20 17:08, Stefan Tomanek wrote:
> Dies schrieb Niels Thykier (ni...@thykier.net):
>
>> Though the upstream code might need a little attention (or some
>> clarification); e.g. cppcheck finds a resource leak:
>>
>> Checking cmdsocket.c...
>> [cmdsocket.c:126]: (error) Resource leak: fd
>>
>> Looking at the code I am not sure what the intention is. My best guess
>> is that it is trying to transmit the "leaked" file descriptor.
>
> Yes, it does that. This allows the daemon itself to run as user "nobody",
> while th-cmd (launched by udev) can open a new device and pass the fd
> to thd.
>
Okay, perhaps you could document this in the code that this is
intentional (e.g. transmitting the fd and the leak is a false-positive)?
>> [...]
>> cppcheck also believes that count_triggers (trigger.c) and print_ignores
>> (ignore.c) are never used. I did not verify that.
>
> Indeed, I used those functions for debugging purposes only, but I guess
> leaving them there does no harm.
>
There is no harm in leaving them; worst case the program is a bit larger
than needed (which could be solved with some #ifdef...#endif magic).
Anyhow just double checking it was intentional here. :)
>> In thd.c:331 the error message implies that the user does not exist, but
>> getpwnam can fail with other reasons; it might be a good idea to
>> use a more "neutral" error like:
>> int err = errno;
>> fprintf(stderr, "Could not look up the user %s\n", user);
>> errno = err;
>> perror("getpwnam");
>
> OK, I "neutralized" the error message, however using perror(errno) from
> getpwnam
> is not really interesting, since all I get is "Sucess", even when specifying
> a completely
> bogus name.
>
Mmm, reading getpwnam(3) I see that it may leave errno untouched (or set
it to 0; not quite sure) on a failure, but it is system/error dependent?
I guess you can do something like:
errno = 0;
var = getpwnam(...);
if(!var){
if(!errno){
fprintf(stderr, "No such user %s\n", ...);
} else {
/*possible no such user or "other" issue*/
}
}
Or simply suppress the perror if errno is 0. Anyhow - not a strict
requirement.
>> Adding warnings to gcc I saw the following:
>> cc -g -O2 -Wall -Wextra -g -O2 -Wall -Wextra -c -o eventnames.o
>> eventnames.c
>> In file included from eventtable.h:10,
>> from eventnames.c:5:
>> evtable_KEY.h:123: warning: initialized field overwritten
>> evtable_KEY.h:123: warning: (near initialization for 'KEY_NAME[122]')
> [...]
>> They are were triggered with -Wextra; it may be nothing, but I figured I
>> would mention it.
>
> Yes, I was aware of those. evtable_{KEY,EV,SW} are autogenerated from
> ,
> generating a mapping table from event names to the integer values, but since
> some events
> have multiple names, these messages appear.
>
Cool, just double checking this as well since I was not sure :)
> Thanks for your review, I'll push the changed advocated by you to my git
> repository
> today (https://github.com/wertarbyte/triggerhappy).
>
>
You are welcome.
~Niels
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQIcBAEBCAAGBQJND4U/AAoJEAVLu599gGRCjjkQAIzvwcIwjAOJqkNaH9yvsU5B
BmJdBxiVXBjgsYpH2fa0RNVlRCjwZCuA87O8OoZlbkPdcLxy8g5V8fSfR0wwK0gl
o4MqZxrBjbOdAeuFoQSyfsQ1wSAPJ5fXXN3dzOrVDl+FoQLkGfFrjn9n0bjRpkqX
+6muhjq5cBJBiWkpwgsRrfR1/kujTMt8PdS8RRmpBT7LXcnpreJEMk9zaG4UOT5b
Z1+YaNcW/rK6XDTCx5LLYWj6K/RZbND5H0e5xyqWN2MyJyepWh+fgg1kxAJKmcEJ
T4ixcB5qk4lpcllwjAgBhYdLmM5Mlgy8e2FTlf0UOVEdaUehiNIK3GCTJmKw3kWo
P8YlPZ2ZiwoHi/xNsTGlvYoLEWHbMLgU5KBz1pDX1PFsspmLhncR2fnspdPqmF+U
lvyOmlCyD9Wa8EMNA9Y/3sO9STlIgvipXtoEbbpvqAaLfBJph09IpRn46ZKJNY7F
Ef8t6UZcSkgwX70R4vb/piSns3KgoncGAuQoKbgZeSZfcJwJudV7ZZp3tRKD25fG
xVTH6ywOGwIesRyhmdn03nk25RwCPESjNqPzwpnxhwnHBWzYxa3eTrZ6W/qrgCCc
xHEsrMSxl9fy6EJLN0KZGk6OZOiPppPqk5Jypq7I4dAQenrXQ3jRpPXLSyDLC83m
DgUfTW3Ra96YNheQi6uK
=mWKg
-END PGP SIGNATURE-
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d0f8540.30...@thykier.net
Re: RFS: triggerhappy
Dies schrieb Niels Thykier (ni...@thykier.net):
> Though the upstream code might need a little attention (or some
> clarification); e.g. cppcheck finds a resource leak:
>
> Checking cmdsocket.c...
> [cmdsocket.c:126]: (error) Resource leak: fd
>
> Looking at the code I am not sure what the intention is. My best guess
> is that it is trying to transmit the "leaked" file descriptor.
Yes, it does that. This allows the daemon itself to run as user "nobody",
while th-cmd (launched by udev) can open a new device and pass the fd
to thd.
> Though I am not convinced this will work; even if it is possible (I
> vaguely recall seeing an extension in Linux to allow something like
> this), I suspect the program relies on undefined behaviour here:
>
> char buffer[CMSG_SPACE(sizeof(dev_fd))];
> m.msg_control = buffer;
>
> The issue is that buffer goes out of scope before m is used (in sendmsg).
I guess you are refering to line 115 in cmdsocket.c?
I see, I'll move the buffer declaration to a safer location.
> In the if in uinput.c:27 it looks like you are missing a uinput_fd = -1;
Fixed that, I'm now simply calling close_uinput(..) there.
> In trigger.c:205 there is no check for if fork failed and this leads to
> a "silent nothing happened". There are also got a number of unchecked
> malloc/strdup, which could lead to "out of memory" segfaults, but at
> least that is "some kind of feedback".
OK, I added some error reporting there.
> cppcheck also believes that count_triggers (trigger.c) and print_ignores
> (ignore.c) are never used. I did not verify that.
Indeed, I used those functions for debugging purposes only, but I guess
leaving them there does no harm.
> In thd.c:331 the error message implies that the user does not exist, but
> getpwnam can fail with other reasons; it might be a good idea to
> use a more "neutral" error like:
> int err = errno;
> fprintf(stderr, "Could not look up the user %s\n", user);
> errno = err;
> perror("getpwnam");
OK, I "neutralized" the error message, however using perror(errno) from getpwnam
is not really interesting, since all I get is "Sucess", even when specifying a
completely
bogus name.
> Adding warnings to gcc I saw the following:
> cc -g -O2 -Wall -Wextra -g -O2 -Wall -Wextra -c -o eventnames.o
> eventnames.c
> In file included from eventtable.h:10,
> from eventnames.c:5:
> evtable_KEY.h:123: warning: initialized field overwritten
> evtable_KEY.h:123: warning: (near initialization for 'KEY_NAME[122]')
[...]
> They are were triggered with -Wextra; it may be nothing, but I figured I
> would mention it.
Yes, I was aware of those. evtable_{KEY,EV,SW} are autogenerated from
,
generating a mapping table from event names to the integer values, but since
some events
have multiple names, these messages appear.
Thanks for your review, I'll push the changed advocated by you to my git
repository
today (https://github.com/wertarbyte/triggerhappy).
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20101220160842.gr4...@zirkel.wertarbyte.de
Re: RFS: triggerhappy
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 2010-12-18 15:10, Stefan Tomanek wrote:
> Dear mentors,
>
>
> [...]
>
> Looking for a way of globally assigning hotkey handlers to the special keys
> found on my notebooks, I developed triggerhappy. I also use it to control
> headless systems, e.g. a ARM based MPD jukebox which is controlled by a USB
> keypad or bluetooth wiimote. Having this software in Debian would provide an
> easy way to bind commands to input events without the need for running an
> X11 session or logging in.
>
> [...]
> I would be glad if someone uploaded this package for me.
>
> Kind regards
> Stefan Tomanek
>
>
Hey
I just did a quick review of your package; packaging-wise your package
looks good.
Though the upstream code might need a little attention (or some
clarification); e.g. cppcheck finds a resource leak:
Checking cmdsocket.c...
[cmdsocket.c:126]: (error) Resource leak: fd
Looking at the code I am not sure what the intention is. My best guess
is that it is trying to transmit the "leaked" file descriptor.
Though I am not convinced this will work; even if it is possible (I
vaguely recall seeing an extension in Linux to allow something like
this), I suspect the program relies on undefined behaviour here:
char buffer[CMSG_SPACE(sizeof(dev_fd))];
m.msg_control = buffer;
The issue is that buffer goes out of scope before m is used (in sendmsg).
In the if in uinput.c:27 it looks like you are missing a uinput_fd = -1;
In trigger.c:205 there is no check for if fork failed and this leads to
a "silent nothing happened". There are also got a number of unchecked
malloc/strdup, which could lead to "out of memory" segfaults, but at
least that is "some kind of feedback".
cppcheck also believes that count_triggers (trigger.c) and print_ignores
(ignore.c) are never used. I did not verify that.
In thd.c:331 the error message implies that the user does not exist, but
getpwnam can fail with other reasons; it might be a good idea to
use a more "neutral" error like:
int err = errno;
fprintf(stderr, "Could not look up the user %s\n", user);
errno = err;
perror("getpwnam");
Adding warnings to gcc I saw the following:
cc -g -O2 -Wall -Wextra -g -O2 -Wall -Wextra -c -o eventnames.o
eventnames.c
In file included from eventtable.h:10,
from eventnames.c:5:
evtable_KEY.h:123: warning: initialized field overwritten
evtable_KEY.h:123: warning: (near initialization for 'KEY_NAME[122]')
evtable_KEY.h:154: warning: initialized field overwritten
evtable_KEY.h:154: warning: (near initialization for 'KEY_NAME[152]')
evtable_KEY.h:379: warning: initialized field overwritten
evtable_KEY.h:379: warning: (near initialization for 'KEY_NAME[113]')
In file included from eventtable.h:14,
from eventnames.c:5:
evtable_SW.h:5: warning: initialized field overwritten
evtable_SW.h:5: warning: (near initialization for 'SW_NAME[3]')
They are were triggered with -Wextra; it may be nothing, but I figured I
would mention it.
~Niels
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQIcBAEBCAAGBQJND1SBAAoJEAVLu599gGRCmvcP/ivZpTqSIr210vAC2RY+Sb9+
dEjtT/QUGkxmBqK85yJ34uDsTciguKQ+JrQO0NouvaHiFjGMGFp/JI8oD0wKEf+n
ZCLMTWLp2C1Y0F6g6F6AdLpAijmD2kHVKeSbriFB9b6thjOC3VZBi/IycGO4oIiZ
Fg4TcF/4AcMov++YMJ9HN/ruXWdFrlHcjidYVW1ihnmyTFUW4HFtoYOFoj+kEYQX
0EUQ2cfJDArVkOLvWyxF62bAXryYEg0SvUkQH6Sqaybn9vdoQf3uv8XuGdNPhcPz
AvGq4U6SgHI655T5jHUn9JUO93IaYobm+ftoFgoo4zPd8+ufLsle4KgVyXTwBItR
BbTem2UgMqALKiL2uPhw8AtUZ2ObRIv3OTgWo0fJO1C0EzfeOVcEV73eKTVup2kZ
+aqTeHHal6eynV2+dswvHmpMB4WoK+IIquS5I6upPA/JEOWRtq0hVpa3rNR0p+y5
IE6aVToP9Usop1QzbwRj27iHHEZ+q+xAVv4uK8KdWy+AxH+fjiYrxl35N83BW//V
yNphRegV11NqjqgRx/z+WoE+8jT5r52JCgJts251z1ttiSo28DljXrvuO/UYHrn3
HFJI1Mh8yv0KfVTp8bCDkWJUIyeIKttVDp/qRGzXXOgSR9uM95xlP7zmWziQjTXX
CfSgd9/evkTcod/2yq9q
=Fjok
-END PGP SIGNATURE-
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d0f5482.3070...@thykier.net
RFS: triggerhappy
Dear mentors, I am looking for a sponsor for my package "triggerhappy". * Package name: triggerhappy Version : 0.3.1-1 Upstream Author : Stefan Tomanek * URL : http://github.com/wertarbyte/triggerhappy * License : GPL Section : utils It builds these binary packages: triggerhappy - global hotkey daemon for Linux The package appears to be lintian clean. My motivation for maintaining this package is: Looking for a way of globally assigning hotkey handlers to the special keys found on my notebooks, I developed triggerhappy. I also use it to control headless systems, e.g. a ARM based MPD jukebox which is controlled by a USB keypad or bluetooth wiimote. Having this software in Debian would provide an easy way to bind commands to input events without the need for running an X11 session or logging in. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/t/triggerhappy - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/t/triggerhappy/triggerhappy_0.3.1-1.dsc I would be glad if someone uploaded this package for me. Kind regards Stefan Tomanek -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101218141021.gn4...@zirkel.wertarbyte.de
Re: esekeyd and triggerhappy (Re: RFS: triggerhappy)
On Fri, Dec 10, 2010 at 11:43:17AM +0100, Stefan Tomanek wrote: > Dies schrieb Stanislav Maslovski (stanislav.maslov...@gmail.com): > > > Just a note for completeness: although not properly documented, acpid > > reacts to quite a few non-acpi events, including volume control > > buttons and cd-related buttons found on many laptops (as of ver. 2.0.7). > > It didn't use to to this; the thinkpad acpi module switching from acpi to > input > events was the main motivation to develop the perl based precursor to > triggerhappy (called magmakeys back then). I see. Acpid supported the input layer since around the end of 2008 and the support for some audio and video buttons was there since around the end of 2009 (but almost nobody was aware of that, I believe). CD-related buttons were added recently. -- Stanislav -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101211231938.ga6...@kaiba.homelan
Re: esekeyd and triggerhappy (Re: RFS: triggerhappy)
Dies schrieb Jonathan Nieder (jrnie...@gmail.com): > Would it be easy and would it be sensible to teach esekeyd these > features? Triggerhappy 0.3.0 brings some new features; individual devices can now be tagged, so that pressing a certain key on a USB keyboard can trigger a hotkey handler, while pressing the identical key on the system keyboard cannot; It is also possible to let triggerhappy grab a device exclusively; the daemon can also generate synthetic key events (using uinput) that can be processed by other applications. Still looking for a sponsor though :-) -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101210104703.gf28...@zirkel.wertarbyte.de
Re: esekeyd and triggerhappy (Re: RFS: triggerhappy)
Dies schrieb Stanislav Maslovski (stanislav.maslov...@gmail.com): > Just a note for completeness: although not properly documented, acpid > reacts to quite a few non-acpi events, including volume control > buttons and cd-related buttons found on many laptops (as of ver. 2.0.7). It didn't use to to this; the thinkpad acpi module switching from acpi to input events was the main motivation to develop the perl based precursor to triggerhappy (called magmakeys back then). -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101210104317.ge28...@zirkel.wertarbyte.de
Re: esekeyd and triggerhappy (Re: RFS: triggerhappy)
On Mon, Nov 29, 2010 at 01:14:21AM +0100, Stefan Tomanek wrote:
> Dies schrieb Jonathan Nieder (jrnie...@gmail.com):
>
> > This information could be useful for both package descriptions.
> > (Maybe, for triggerhappy:
> >
> > That is, this is similar to esekeyd but it also supports
> > , allowing you to .
> >
> > and for esekeyd:
> >
> > This package does not do ; for that, see
> > triggerhappy. In the simple situations it does handle,
> > esekeyd is {simpler to configure | compatible with the
> > old funkey daemon | more conservative in its use of
> > resources | providing a different interface that existing
> > users might be used to | whatever}.
>
> OK, I don't know esekeyd enough to include it into a direct comparison, but I
> tweaked my package description to better reflect the main aspects of
> triggerhappy and its features.
Just a note for completeness: although not properly documented, acpid
reacts to quite a few non-acpi events, including volume control
buttons and cd-related buttons found on many laptops (as of ver. 2.0.7).
--
Stanislav
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20101205164624.ga1...@kaiba.homelan
Re: esekeyd and triggerhappy (Re: RFS: triggerhappy)
Dies schrieb Jonathan Nieder (jrnie...@gmail.com):
> This information could be useful for both package descriptions.
> (Maybe, for triggerhappy:
>
> That is, this is similar to esekeyd but it also supports
> , allowing you to .
>
> and for esekeyd:
>
> This package does not do ; for that, see
> triggerhappy. In the simple situations it does handle,
> esekeyd is {simpler to configure | compatible with the
> old funkey daemon | more conservative in its use of
> resources | providing a different interface that existing
> users might be used to | whatever}.
OK, I don't know esekeyd enough to include it into a direct comparison, but I
tweaked my package description to better reflect the main aspects of
triggerhappy and its features.
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20101129001421.gb28...@zirkel.wertarbyte.de
Re: esekeyd and triggerhappy (Re: RFS: triggerhappy)
Dies schrieb Jonathan Nieder (jrnie...@gmail.com):
>
> This information could be useful for both package descriptions.
> (Maybe, for triggerhappy:
>
> That is, this is similar to esekeyd but it also supports
> , allowing you to .
>
> and for esekeyd:
>
> This package does not do ; for that, see
> triggerhappy. In the simple situations it does handle,
> esekeyd is {simpler to configure | compatible with the
> old funkey daemon | more conservative in its use of
> resources | providing a different interface that existing
> users might be used to | whatever}.
>
> ) As you can see, there are some placeholders because I do not know
> the packages; I am just saying it would be nice to provide the
> sysadmin with advice of some sort to choose between them.
I'm not sure whether such a direct comparison of packages in their description
might be not be considered offensive to some and might incite some kind of arms
race: "yo daemon so fat...".
Think of such comparisons in the description of gnome/kde or vim/emacs packages
:-)
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20101127152810.ga28...@zirkel.wertarbyte.de
Re: esekeyd and triggerhappy (Re: RFS: triggerhappy)
Stefan Tomanek wrote:
> I think
> merging the two programs would be difficult. Although young, triggerhappy
> has accumulated quite a few features that would require a redesigning many
> aspects of esekeyd (multiple devices, command socket, multiple config files).
This information could be useful for both package descriptions.
(Maybe, for triggerhappy:
That is, this is similar to esekeyd but it also supports
, allowing you to .
and for esekeyd:
This package does not do ; for that, see
triggerhappy. In the simple situations it does handle,
esekeyd is {simpler to configure | compatible with the
old funkey daemon | more conservative in its use of
resources | providing a different interface that existing
users might be used to | whatever}.
) As you can see, there are some placeholders because I do not know
the packages; I am just saying it would be nice to provide the
sysadmin with advice of some sort to choose between them.
Both sound very useful to me. Thanks to you both.
Ciao,
Jonathan
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20101123173732.ga12...@burratino
Re: esekeyd and triggerhappy (Re: RFS: triggerhappy)
Dies schrieb Jonathan Nieder (jrnie...@gmail.com): > > I think esekeyd can only handle KEY events, while triggerhappy can also > > process > > Switch and button events. I am also unsure whether esekeyd support the > > hotplugging of input devices (done in triggerhappy by a udev script) or > > daemon > > control via socket. From what I see, esekeyd also lacks the support for > > "modes", > > which can modify the button assignment depending on the state the daemon is > > in. > > Thanks, that helps. Next comes a question that might sound off-topic. > Would it be easy and would it be sensible to teach esekeyd these > features? I looked through the esekey source code, and from what I've seen esekey can handle only one input device at a time, while triggerhappy can open multiple devices simultanously. This is important for supporting devices that might not even be there when the daemon is started (bluetooth remote, USB keypad). > What I am trying to figure out is whether esekeyd and triggerhappy > occupy different niches or if it is an accident of history that you > are not already working on the same codebase. IIUC triggerhappy is > very young so there might be a chance to merge or make the user > interfaces compatible before users grow irrationally attached to the > quirks of one or the other. Of course I am in favor of _my_ pet project (who wouldn't?), but I think merging the two programs would be difficult. Although young, triggerhappy has accumulated quite a few features that would require a redesigning many aspects of esekeyd (multiple devices, command socket, multiple config files). -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101123141011.gq15...@zirkel.wertarbyte.de
esekeyd and triggerhappy (Re: RFS: triggerhappy)
Hi Krzysztof and Stefan, Stefan Tomanek wrote: > I think esekeyd can only handle KEY events, while triggerhappy can also > process > Switch and button events. I am also unsure whether esekeyd support the > hotplugging of input devices (done in triggerhappy by a udev script) or daemon > control via socket. From what I see, esekeyd also lacks the support for > "modes", > which can modify the button assignment depending on the state the daemon is > in. Thanks, that helps. Next comes a question that might sound off-topic. Would it be easy and would it be sensible to teach esekeyd these features? To be clear, I am not a DD, so please do not feel obligated to answer me as a hoop before getting triggerhappy uploaded. It won't help. :) What I am trying to figure out is whether esekeyd and triggerhappy occupy different niches or if it is an accident of history that you are not already working on the same codebase. IIUC triggerhappy is very young so there might be a chance to merge or make the user interfaces compatible before users grow irrationally attached to the quirks of one or the other. Jonathan -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101123095040.gc10...@burratino
Re: RFS: triggerhappy
Dies schrieb Jonathan Nieder (jrnie...@gmail.com): > How does triggerhappy compare to Krzysztof Burghardt's esekeyd? I think esekeyd can only handle KEY events, while triggerhappy can also process Switch and button events. I am also unsure whether esekeyd support the hotplugging of input devices (done in triggerhappy by a udev script) or daemon control via socket. From what I see, esekeyd also lacks the support for "modes", which can modify the button assignment depending on the state the daemon is in. > It is easy to misunderstand the short description. I think it is > meant to say that that the hotkey daemon is not tied to a user > session, but now it conjures up images of "user-independent hotkeys". > Maybe: > > Description: hotkey daemon for Linux > Triggerhappy watches connected input devices for certain key presses > (like Suspend and Volume Control) and runs administrator-configured > commands when they are pressed. Unlike , it runs as a > persistent, systemwide service and therefore can be used even > outside the context of a user or X11 session. > . > It can also handle remote controls, as they are presented as > keyboards. No kernel patch is required. The daemon is a userspace > program that polls the /dev/input/event? interfaces for incoming key > presses. > . > For example, this package might be useful on a headless system to > use input events generated by a remote control to control an > mpd server. Sounds good, I'll look into adapting that description. Thanks for your reply Stefan Tomanek -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101123085643.go15...@zirkel.wertarbyte.de
Re: RFS: triggerhappy
Stefan Tomanek wrote: > Dies schrieb Jonathan Nieder (jrnie...@gmail.com): >> How does this compare to Rick van Rein's funkey[1]? > > Hm, funkey does require a kernel patch und looks quite dated? > > "Funky Daemon which demonstrates how to parse the /dev/funkey character > device." Thanks for a quick response. Sorry, I did not read the following carefully enough: This patch is not being actively maintained, unlike my BadRAM patch. There is an alternative[1] that is said to work without kernel patching on current Linux systems. We keep this page around for historic service, especially because the information about keyboard modes is still useful. [1] http://www.burghardt.pl/wiki/software/esekeyd How does triggerhappy compare to Krzysztof Burghardt's esekeyd? > As I said, triggerhappy uses the /dev/input/eventX files, anything that fires > SW_, KEY_ or BTN_ events can be used t launch programs. That sounds like very useful information for the package description. Currently it says: | Description: global, user and session independent hotkey daemon | Triggerhappy observes all connected input devices and launches | configured commands when certain keys are pressed. The daemon | works as a system wide service and is independent of any user | session. To nitpick (please don't take this the wrong way --- when a person spends time on things like this, that usually means she thinks your package is valuable): It is easy to misunderstand the short description. I think it is meant to say that that the hotkey daemon is not tied to a user session, but now it conjures up images of "user-independent hotkeys". Maybe: Description: hotkey daemon for Linux Triggerhappy watches connected input devices for certain key presses (like Suspend and Volume Control) and runs administrator-configured commands when they are pressed. Unlike , it runs as a persistent, systemwide service and therefore can be used even outside the context of a user or X11 session. . It can also handle remote controls, as they are presented as keyboards. No kernel patch is required. The daemon is a userspace program that polls the /dev/input/event? interfaces for incoming key presses. . For example, this package might be useful on a headless system to use input events generated by a remote control to control an mpd server. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101123083459.ga10...@burratino
Re: RFS: triggerhappy
Dies schrieb Jonathan Nieder (jrnie...@gmail.com): > How does this compare to Rick van Rein's funkey[1]? Hm, funkey does require a kernel patch und looks quite dated? "Funky Daemon which demonstrates how to parse the /dev/funkey character device." As I said, triggerhappy uses the /dev/input/eventX files, anything that fires SW_, KEY_ or BTN_ events can be used t launch programs. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101123073810.gn15...@zirkel.wertarbyte.de
Re: RFS: triggerhappy
Hi Stefan, Stefan Tomanek wrote: > * URL : https://github.com/wertarbyte/triggerhappy [...] > My motivation for maintaining this package is: I've written this small > program to fill a need not covered by any existing program, so I think > having it in Debian and making it available to others is a good thing. > > Currently, there is no practical way to configure global hotkeys that act > independent from a user and/or X11 session. Buttons like Suspend or Volume > Control should be handeled without requiring a user to log into their desktop > environment How does this compare to Rick van Rein's funkey[1]? It might make sense to add your app to Andries Brouwer (cc'd)'s keyboard and console HOWTO, though the latter is sadly a bit dated by now. Regards, Jonathan [1] http://rick.vanrein.org/linux/funkey/ -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101123002327.ga3...@burratino
Re: RFS: triggerhappy [fixed mistake in URL]
Dies schrieb Benoît Knecht (benoit.kne...@fsfe.org): > As a matter of fact, I do :) You retitled it to the exact same title it > already has: Indeed, I just noticed. Classic case of "copy&paste" gone wrong. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101122084026.gd15...@zirkel.wertarbyte.de
Re: RFS: triggerhappy [fixed mistake in URL]
Stefan Tomanek wrote: > Dies schrieb Benoît Knecht (benoit.kne...@fsfe.org): > > > I understand :) But now that you're packaging it, you should let people > > know by retitling the bug to ITP and setting yourself as the bug owner > > (otherwise someone else might start working on it too, only to discover > > the work has already been done). And don't forget to add "(Closes: > > #603842)" to your changelog. > > Hm, for some reason the BTS did not retitle the report, although it processed > the ownership change, do you know what I did wrong? As a matter of fact, I do :) You retitled it to the exact same title it already has: retitle 603842 RFP: triggerhappy -- a system-wide hotkey and input event daemon Change that to: retitle 603842 ITP: triggerhappy -- a system-wide hotkey and input event daemon and it should work just fine. Cheers, -- Benoît Knecht -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101122083623.ga21...@debian.lan
Re: RFS: triggerhappy [fixed mistake in URL]
Dies schrieb Benoît Knecht (benoit.kne...@fsfe.org): > I understand :) But now that you're packaging it, you should let people > know by retitling the bug to ITP and setting yourself as the bug owner > (otherwise someone else might start working on it too, only to discover > the work has already been done). And don't forget to add "(Closes: > #603842)" to your changelog. Hm, for some reason the BTS did not retitle the report, although it processed the ownership change, do you know what I did wrong? -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101122082009.ga15...@zirkel.wertarbyte.de
Re: RFS: triggerhappy [fixed mistake in URL]
Stefan Tomanek wrote: > Dies schrieb Benoît Knecht (benoit.kne...@fsfe.org): > > > I see you've now opened a bug for your package (#603842), but you still > > need to close it in your changelog. And it should be an ITP bug owned by > > you, not an RFP. > > I opened that bug before I uploaded the package here, hoping that someone > else might pick up that torch :-) I understand :) But now that you're packaging it, you should let people know by retitling the bug to ITP and setting yourself as the bug owner (otherwise someone else might start working on it too, only to discover the work has already been done). And don't forget to add "(Closes: #603842)" to your changelog. > > Besides that, I still believe it would be best to run the daemon as a > > regular system user by default, and let the user decide if root > > privileges are required (with a commented-out option in > > /etc/default/triggerhappy with some explanation about when and why it > > should be run as root, for example). > > Do you think "nobody" would be sufficient, or should triggerhappy create > a dedicated user account for that? I guess "nobody" is okay, unless the daemon needs to access files that should only be read-/writable by it. Cheers, -- Benoît Knecht -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101121231102.gb8...@debian.lan
Re: RFS: triggerhappy [fixed mistake in URL]
Dies schrieb Benoît Knecht (benoit.kne...@fsfe.org): > I see you've now opened a bug for your package (#603842), but you still > need to close it in your changelog. And it should be an ITP bug owned by > you, not an RFP. I opened that bug before I uploaded the package here, hoping that someone else might pick up that torch :-) > Besides that, I still believe it would be best to run the daemon as a > regular system user by default, and let the user decide if root > privileges are required (with a commented-out option in > /etc/default/triggerhappy with some explanation about when and why it > should be run as root, for example). Do you think "nobody" would be sufficient, or should triggerhappy create a dedicated user account for that? > And this is not a big deal, but I think it's worth mentioning anyway: > your man pages have a "OPTIONS AND ARGUMENTS" header, whereas > man-pages(7) recommends simply using "OPTIONS"; you may want to change > that in order to be more consistent with most man pages. Hm, thanks for that remark, I'll look into this and change that in the next upstream version. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101121230008.gm17...@zirkel.wertarbyte.de
Re: RFS: triggerhappy [fixed mistake in URL]
Hi Stefan, Stefan Tomanek wrote: > I am looking for a sponsor for my package "triggerhappy". > > * Package name: triggerhappy > Version : 0.1.6-1 > Upstream Author : Stefan Tomanek > * URL : http://github.com/wertarbyte/triggerhappy/ > * License : GPL > Section : utils > > It builds these binary packages: > triggerhappy - global, user and session independent hotkey daemon > > The package appears to be lintian clean. I see you've now opened a bug for your package (#603842), but you still need to close it in your changelog. And it should be an ITP bug owned by you, not an RFP. Besides that, I still believe it would be best to run the daemon as a regular system user by default, and let the user decide if root privileges are required (with a commented-out option in /etc/default/triggerhappy with some explanation about when and why it should be run as root, for example). And this is not a big deal, but I think it's worth mentioning anyway: your man pages have a "OPTIONS AND ARGUMENTS" header, whereas man-pages(7) recommends simply using "OPTIONS"; you may want to change that in order to be more consistent with most man pages. Cheers, -- Benoît Knecht -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101121225441.ga8...@debian.lan
RFS: triggerhappy
Dear mentors, I am looking for a sponsor for my package "triggerhappy". * Package name: triggerhappy Version : 0.1.6-1 Upstream Author : Stefan Tomanek * URL : http://github.com/wertarbyte/triggerhappy/ * License : GPL Section : admin It builds these binary packages: triggerhappy - global, user and session independent hotkey daemon The package appears to be lintian clean. My motivation for maintaining this package is: I've written this small program to fill a need not covered by any existing program, so I think having it in Debian and making it available to others is a good thing. Currently, there is no practical way to configure global hotkeys that act independent from a user and/or X11 session. Buttons like Suspend or Volume Control should be handeled without requiring a user to log into their desktop environment, which is hard to achieve since most notebook drivers do not generate ACPI events for their special buttons. The daemon is also convinient to use in embedded or headless situations; I am using a Debian system installed on a Dockstar device (ARM9 system with USB and Ethernet) running mpd which is controlled by a bluetooth wiimote and an USB keypad; triggerhappy captures the input events generated by those devices and launches the appropiate mpc commands. No user session is required for this, since triggerhappy directly reads from /dev/input/eventX and is therefore independent from focus. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/t/triggerhappy - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/t/triggerhappy/triggerhappy_0.1.3-1.dsc I would be glad if someone uploaded this package for me. Kind regards Stefan Tomanek -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101121213307.gg17...@zirkel.wertarbyte.de
RFS: triggerhappy [fixed mistake in URL]
Dear mentors, I am looking for a sponsor for my package "triggerhappy". * Package name: triggerhappy Version : 0.1.6-1 Upstream Author : Stefan Tomanek * URL : http://github.com/wertarbyte/triggerhappy/ * License : GPL Section : utils It builds these binary packages: triggerhappy - global, user and session independent hotkey daemon The package appears to be lintian clean. My motivation for maintaining this package is: I've written this small program to fill a need not covered by any existing program, so I think having it in Debian and making it available to others is a good thing. Currently, there is no practical way to configure global hotkeys that act independent from a user and/or X11 session. Buttons like Suspend or Volume Control should be handeled without requiring a user to log into their desktop environment, which is hard to achieve since most notebook drivers do not generate ACPI events for their special buttons. The daemon is also convinient to use in embedded or headless situations; I am using a Debian system installed on a Dockstar device (ARM9 system with USB and Ethernet) running mpd which is controlled by a bluetooth wiimote and an USB keypad; triggerhappy captures the input events generated by those devices and launches the appropiate mpc commands. No user session is required for this, since triggerhappy directly reads from /dev/input/eventX and is therefore independent from focus. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/t/triggerhappy - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/t/triggerhappy/triggerhappy_0.1.6-1.dsc I would be glad if someone uploaded this package for me. Kind regards Stefan Tomanek -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101121214558.gi17...@zirkel.wertarbyte.de
RFS: triggerhappy
Dear mentors, I am looking for a sponsor for my package "triggerhappy". * Package name: triggerhappy Version : 0.1.6-1 Upstream Author : Stefan Tomanek * URL : http://github.com/wertarbyte/triggerhappy/ * License : GPL Section : admin It builds these binary packages: triggerhappy - global, user and session independent hotkey daemon The package appears to be lintian clean. My motivation for maintaining this package is: I've written this small program to fill a need not covered by any existing program, so I think having it in Debian and making it available to others is a good thing. Currently, there is no practical way to configure global hotkeys that act independent from a user and/or X11 session. Buttons like Suspend or Volume Control should be handeled without requiring a user to log into their desktop environment, which is hard to achieve since most notebook drivers do not generate ACPI events for their special buttons. The daemon is also convinient to use in embedded or headless situations; I am using a Debian system installed on a Dockstar device (ARM9 system with USB and Ethernet) running mpd which is controlled by a bluetooth wiimote and an USB keypad; triggerhappy captures the input events generated by those devices and launches the appropiate mpc commands. No user session is required for this, since triggerhappy directly reads from /dev/input/eventX and is therefore independent from focus. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/t/triggerhappy - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/t/triggerhappy/triggerhappy_0.1.3-1.dsc I would be glad if someone uploaded this package for me. Kind regards Stefan Tomanek -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101121214324.gh17...@zirkel.wertarbyte.de
Re: RFS: triggerhappy
On Wed, Nov 17, 2010 at 11:49:06PM +0100, Stefan Tomanek wrote: > Dear mentors, Hi Stefan > > I am looking for a sponsor for my package "triggerhappy". > > * Package name: triggerhappy > Version : 0.1.3-1 > Upstream Author : Stefan Tomanek > * URL : http://github.com/wertarbyte/triggerhappy > * License : GPL > Section : admin > > It builds these binary packages: > triggerhappy - global, user and session independent hotkey daemon > > The package appears to be lintian clean. > > My motivation for maintaining this package is: I've written this small > program to fill a need not covered by any existing program, so I think > having it in Debian and making it available to others is a good thing. > > The package can be found on mentors.debian.net: > - URL: http://mentors.debian.net/debian/pool/main/t/triggerhappy > - Source repository: deb-src http://mentors.debian.net/debian unstable main > contrib non-free > - dget > http://mentors.debian.net/debian/pool/main/t/triggerhappy/triggerhappy_0.1.3-1.dsc > > I would be glad if someone uploaded this package for me. Little remark: You first need to file an ITP for your package which then should be closed in your changelog - as this is the first upload to Debian there is no need for more than one changelog entry like "Initial release (Closes: $ITP_BUG_NUMBER)". > > Kind regards > Stefan Tomanek Kind regards Harald Jenny > > PS: Please CC me, since I am not yet subscribed to the list. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101118173723.ge11...@harald-has.a-little-linux-box.at
Re: RFS: triggerhappy
Dies schrieb Benoît Knecht (benoit.kne...@fsfe.org): > lintian -I --pedantic actually gives a few warnings: > > I: triggerhappy source: debian-watch-file-is-missing > W: triggerhappy: description-starts-with-leading-spaces > I: triggerhappy: init.d-script-does-not-provide-itself > /etc/init.d/triggerhappy > P: triggerhappy: no-upstream-changelog > I: triggerhappy: spelling-error-in-manpage usr/share/man/man1/thd.1.gz > seperated separated > I: triggerhappy: spelling-error-in-manpage usr/share/man/man1/thd.1.gz > appropiate appropriate > > I'm also wondering if "admin" is the right section for your package; > "utils" maybe? OK, I just uploaded 0.1.4-1, which addresses most of those issues, so if you (or anyone else) want to take another look? Greetings Stefan Tomanek -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101118065801.gj17...@zirkel.wertarbyte.de
Re: RFS: triggerhappy
Dies schrieb Benoît Knecht (benoit.kne...@fsfe.org): > lintian -I --pedantic actually gives a few warnings: > > I: triggerhappy source: debian-watch-file-is-missing > W: triggerhappy: description-starts-with-leading-spaces > I: triggerhappy: init.d-script-does-not-provide-itself > /etc/init.d/triggerhappy > P: triggerhappy: no-upstream-changelog > I: triggerhappy: spelling-error-in-manpage usr/share/man/man1/thd.1.gz > seperated separated > I: triggerhappy: spelling-error-in-manpage usr/share/man/man1/thd.1.gz > appropiate appropriate > > I'm also wondering if "admin" is the right section for your package; > "utils" maybe? Yes, that is probably a better choice. > Oh and one last thing (keep in mind I didn't look into your package very > thoroughly, so forgive me if it's a silly question), I saw in your > changelog that you introduced an option to drop root privileges; why > aren't you using it by default? From a security point of view, it would > of course be preferable, but maybe there's another reason not to do it? Dropping root privileges (and become nobody) might be a good idea, but it depends on what the daemon and its triggers are used for; if they are supposed to initiate a shutdown or configure the network, the root privileges might be missing. It also makes hotplugging more complicated, since the daemon cannot open new devices - although the th-cmd client is now able open the device itself and pass the open fd through the socket to the server, provided the client program runs as root, which is probably the case when triggered by udev. Thank you for your review, I'll see if I can squish some of those issues. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101118000706.gi17...@zirkel.wertarbyte.de
Re: RFS: triggerhappy
Hi Stefan, Stefan Tomanek wrote: > I am looking for a sponsor for my package "triggerhappy". > > * Package name: triggerhappy > Version : 0.1.3-1 > Upstream Author : Stefan Tomanek > * URL : http://github.com/wertarbyte/triggerhappy > * License : GPL > Section : admin > > It builds these binary packages: > triggerhappy - global, user and session independent hotkey daemon > > The package appears to be lintian clean. lintian -I --pedantic actually gives a few warnings: I: triggerhappy source: debian-watch-file-is-missing W: triggerhappy: description-starts-with-leading-spaces I: triggerhappy: init.d-script-does-not-provide-itself /etc/init.d/triggerhappy P: triggerhappy: no-upstream-changelog I: triggerhappy: spelling-error-in-manpage usr/share/man/man1/thd.1.gz seperated separated I: triggerhappy: spelling-error-in-manpage usr/share/man/man1/thd.1.gz appropiate appropriate I'm also wondering if "admin" is the right section for your package; "utils" maybe? And although it is not required, using DEP-5 format [1] for your debian/copyright file might be a good idea. [1] http://dep.debian.net/deps/dep5/ Well, it's a rather superficial review, but I hope it's helpful anyway. Oh and one last thing (keep in mind I didn't look into your package very thoroughly, so forgive me if it's a silly question), I saw in your changelog that you introduced an option to drop root privileges; why aren't you using it by default? From a security point of view, it would of course be preferable, but maybe there's another reason not to do it? Cheers, -- Benoît Knecht -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101117235955.gb9...@debian.lan
RFS: triggerhappy
Dear mentors, I am looking for a sponsor for my package "triggerhappy". * Package name: triggerhappy Version : 0.1.3-1 Upstream Author : Stefan Tomanek * URL : http://github.com/wertarbyte/triggerhappy * License : GPL Section : admin It builds these binary packages: triggerhappy - global, user and session independent hotkey daemon The package appears to be lintian clean. My motivation for maintaining this package is: I've written this small program to fill a need not covered by any existing program, so I think having it in Debian and making it available to others is a good thing. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/t/triggerhappy - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/t/triggerhappy/triggerhappy_0.1.3-1.dsc I would be glad if someone uploaded this package for me. Kind regards Stefan Tomanek PS: Please CC me, since I am not yet subscribed to the list. signature.asc Description: Digital signature
