Re: Bug#726835: RFS: qgit/2.5-2 [RC]

2013-10-20 Thread Andrey Rahmatullin
On Sat, Oct 19, 2013 at 10:40:10PM +0300, Boris Pek wrote:
 How about bug report #641745? It looks easy fixable.
I still don't think it's a problem of qgit (or any other package providing
this MimeType, such as easytag or gwenview).

 Lintian show one tag, which is easy fixable as well:
 I: qgit: desktop-entry-lacks-keywords-entry 
 usr/share/applications/qgit.desktop
I don't think the maintainer should, or even can, add Keywords to upstream
.desktop files (as opposed to Categories). See also Whether the desktop
file needs to have a Keywords line added is somewhat subjective. (from
https://wiki.gnome.org/GnomeGoals/DesktopFileKeywords ). Patches
are welcome (better send them directly to the upstream, I suppose).

 Also there are few bug reports on Launchpad:
 https://bugs.launchpad.net/ubuntu/+source/qgit
 They might be interesting for you.
They are either wishlist or unreproducible on current version, so no.

-- 
WBR, wRAR


signature.asc
Description: Digital signature


Re: Bug#726835: RFS: qgit/2.5-2 [RC]

2013-10-20 Thread Andrey Rahmatullin
On Sun, Oct 20, 2013 at 03:49:32PM +0300, Boris Pek wrote:
  I still don't think it's a problem of qgit (or any other package providing
  this MimeType, such as easytag or gwenview).
 Still? I don't see your opinion in bug report. Please send your comment there.
 And do not forget to Cc the submitter: he will be able to write other 
 arguments
 or he will agree with you.
I've discussed this situation on #-devel on 2011-12-03 (tumbleweed was
present). We couldn't decide anything useful though (apart from lindi not
being able to reproduce the problem, see his mail at #611938).
There were at that time at least #611938, #398999, #538093, since then
there may be some new bugs opened and the same can be applied to any other
package providing this MimeType, such as easytag or gwenview (nowadays you
probably can use codesearch.d.n to find all such packages). 

I guess I should just close this bug as MimeType: inode/directory should
be present for apps acting as directory viewers and if that causes
problems with DEs/file managers people should open bugs for them. Though
all other similar bugs should be closed in the same manner too.


   Lintian show one tag, which is easy fixable as well:
   I: qgit: desktop-entry-lacks-keywords-entry 
  usr/share/applications/qgit.desktop
 
  I don't think the maintainer should, or even can, add Keywords to upstream
  .desktop files (as opposed to Categories).
 
 Upstream does not provide the the .desktop file. You provide it in debian
 subdirectory:
 http://anonscm.debian.org/gitweb/?p=collab-maint/qgit.git;a=blob;f=debian/qgit.desktop;hb=HEAD
All the more reasons not to touch Keywords then, I guess.

  See also Whether the desktop
  file needs to have a Keywords line added is somewhat subjective. (from
  https://wiki.gnome.org/GnomeGoals/DesktopFileKeywords ).
 
 While it is not obligated, it is really easy to add one line in .desktop file
 to make few GNOME users more happy. Something like [1] should be enough I
 think.
 
 [1] Keywords=RevisionControlSystem;VCS;DCVS;git;
I have only a slight idea how is this field used in practice and I
wouldn't test it but if you insist I can add this (after changing DCVS
to DVCS and RevisionControlSystem to revision control system).

   Also there are few bug reports on Launchpad:
   https://bugs.launchpad.net/ubuntu/+source/qgit
   They might be interesting for you.
 
  They are either wishlist or unreproducible on current version, so no.
 
 Ok. So they might be commented and/or closed, right? Though it is a
 maintainer's decision to ignore or not ignore users of derivative distros.
Huh? I don't care about bugs in Ubuntu much more than about bugs in
RedHat. I also don't view myself as a maintainer of any packages in Ubuntu
and never thought about doing corresponding work.

-- 
WBR, wRAR


signature.asc
Description: Digital signature