Re: CRLF in upstream source code

[Eriberto Mota]

Em ter., 15 de mar. de 2022 às 13:29,  escreveu:
>
> > > Why should it matter to anything, including Debian, unless there are
> > > technical problems caused by that?
> >
> > So such as not compiling.  Or another reason not yet shared with us.
> >
>
> No problem with building the package. I just saw a comment on a bug and I was
> in doubt [1].
> I decided to ask first.  I'm a complete novice and I'm trying to make things
> right.
> Thank you Andrey and Geert.
>
> [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=698359#10

Note that the current source code in Github dropped the CRLF in
several files. To compare the old version with the current version via
diff, in a separate directory, you could use dos2unix. In src/, the
command "file *" will help to see all files using CRLF. This procedure
is a workaround for 698359#10.

Regards,

Eriberto

Re: CRLF in upstream source code

[lourisvaldo]

> > Why should it matter to anything, including Debian, unless there are
> > technical problems caused by that?
> 
> So such as not compiling.  Or another reason not yet shared with us.
> 

No problem with building the package. I just saw a comment on a bug and I was 
in doubt [1].
I decided to ask first.  I'm a complete novice and I'm trying to make things 
right.
Thank you Andrey and Geert.

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=698359#10

Re: CRLF in upstream source code

[Geert Stappers]

On Mon, Mar 14, 2022 at 08:51:27PM +0500, Andrey Rahmatullin wrote:
> On Mon, Mar 14, 2022 at 12:25:53PM -0300, Lourisvaldo Figueredo Junior wrote:
> > I have a doubt. In cases where the upstream uses the MS-DOS pattern CRLF
> > ("\r\n") to end of line, instead Unix pattern LF ("\n").
> > In this situation, should the maintainer make a patch converting this files 
> > to
> > the Unix pattern LF?
> No.
>
> > Or to Debian is 'acceptable' to build a package from source keeping the 
> > MS-DOS
> > pattern CRLF?
> Why should it matter to anything, including Debian, unless there are
> technical problems caused by that?

So such as not compiling.  Or another reason not yet shared with us.


> > The question is about the upstream source code, not to the debian directory.
As Andrey says: No need to change CRLF end of line into a LF e.o.l.
Still feel free to express what you deem a valid reason to change the EOL


> > Thank so much.

Thank you for reaching out to d-mentors@l.d.o.


Groeten
Geert Stappers
--
Silence is hard to parse

Re: CRLF in upstream source code

[Andrey Rahmatullin]

On Mon, Mar 14, 2022 at 12:25:53PM -0300, Lourisvaldo Figueredo Junior wrote:
> I have a doubt. In cases where the upstream uses the MS-DOS pattern CRLF 
> ("\r\n") to end of line, instead Unix pattern LF ("\n").
> In this situation, should the maintainer make a patch converting this files 
> to 
> the Unix pattern LF?
No.

> Or to Debian is 'acceptable' to build a package from source keeping the 
> MS-DOS 
> pattern CRLF?
Why should it matter to anything, including Debian, unless there are
technical problems caused by that?

-- 
WBR, wRAR


signature.asc
Description: PGP signature