Re: Looking for a mentor for the OpenSIPS project
Helly Guys, Sorry for the late reply, at the moment I don't have good internet connection, give me one week and I'll work on it. Kind regards, -- Julián Moreno Patiño Debian Developer .''`. Debian GNU/{Linux,KfreeBSD} : :' : Free Operating Systems `. `' http://debian.org/ `- GPG Fingerprint: C2C8 904E 314C D8FA 041D 9B00 D5FD FC15 6168 BF60 Registered GNU Linux User ID 488513
Re: Looking for a mentor for the OpenSIPS project
Sorry, I initially missed that warning. It is fixed now, I've re-uploaded the debs. There are still two spelling warnings, but those are false positives - those strings are not present in the sources. Is there anything I can do to remove those? Cheers, Răzvan Crainea OpenSIPS Solutions www.opensips-solutions.com On 08/27/2015 05:41 PM, Gianfranco Costamagna wrote: Hi, I think you might want to fix the last two copyright issues I unused-file-paragraph-in-dep5-copyright paragraph at line 1366 paragraph at line 53 I wildcard-matches-nothing-in-dep5-copyright cfg.tab.c (paragraph at line 53) cfg.tab.h (paragraph at line 53) (not blockers I guess, but nice to see fixed) cheers, G. Il Giovedì 27 Agosto 2015 16:34, Răzvan Crainearaz...@opensips.org ha scritto: Hi, all! After several ping-pongs with Julian, we've finally managed to have a candidate for upstream. I've uploaded the latests sources here: http://mentors.debian.net/debian/pool/main/o/opensips/opensips_2.1.1-1.dsc Best regards, Răzvan Crainea OpenSIPS Solutions www.opensips-solutions.com On 08/21/2015 11:57 AM, Julián Moreno Patiño wrote: Hello guys, Sorry but yestarday I was in the Debconf dinner. Right now I am at #debian-opensips in irc.debian.org Kind regards,
Re: Looking for a mentor for the OpenSIPS project
Ok, I'll choose option 1) :) Thanks, Răzvan Crainea OpenSIPS Solutions www.opensips-solutions.com On 08/28/2015 10:56 AM, Gianfranco Costamagna wrote: Hi Julián, do you want to upload? Răzvan for the binaries false positive you can: 1) not care at all (they are pedantic) 2) add a lintian override for me both are good :) cheers, G.
Re: Looking for a mentor for the OpenSIPS project
Hi Julián, do you want to upload? Răzvan for the binaries false positive you can: 1) not care at all (they are pedantic) 2) add a lintian override for me both are good :) cheers, G.
Re: Looking for a mentor for the OpenSIPS project
Hi, all! After several ping-pongs with Julian, we've finally managed to have a candidate for upstream. I've uploaded the latests sources here: http://mentors.debian.net/debian/pool/main/o/opensips/opensips_2.1.1-1.dsc Best regards, Răzvan Crainea OpenSIPS Solutions www.opensips-solutions.com On 08/21/2015 11:57 AM, Julián Moreno Patiño wrote: Hello guys, Sorry but yestarday I was in the Debconf dinner. Right now I am at #debian-opensips in irc.debian.org Kind regards,
Re: Looking for a mentor for the OpenSIPS project
Hi, I think you might want to fix the last two copyright issues I unused-file-paragraph-in-dep5-copyright paragraph at line 1366 paragraph at line 53 I wildcard-matches-nothing-in-dep5-copyright cfg.tab.c (paragraph at line 53) cfg.tab.h (paragraph at line 53) (not blockers I guess, but nice to see fixed) cheers, G. Il Giovedì 27 Agosto 2015 16:34, Răzvan Crainea raz...@opensips.org ha scritto: Hi, all! After several ping-pongs with Julian, we've finally managed to have a candidate for upstream. I've uploaded the latests sources here: http://mentors.debian.net/debian/pool/main/o/opensips/opensips_2.1.1-1.dsc Best regards, Răzvan Crainea OpenSIPS Solutions www.opensips-solutions.com On 08/21/2015 11:57 AM, Julián Moreno Patiño wrote: Hello guys, Sorry but yestarday I was in the Debconf dinner. Right now I am at #debian-opensips in irc.debian.org Kind regards,
Re: Looking for a mentor for the OpenSIPS project
Hello guys, Sorry but yestarday I was in the Debconf dinner. Right now I am at #debian-opensips in irc.debian.org Kind regards, -- Julián Moreno Patiño Debian Developer .''`. Debian GNU/{Linux,KfreeBSD} : :' : Free Operating Systems `. `' http://debian.org/ `- GPG Fingerprint: C2C8 904E 314C D8FA 041D 9B00 D5FD FC15 6168 BF60 Registered GNU Linux User ID 488513
Re: Looking for a mentor for the OpenSIPS project
Hi, Gianfranco, Julian! I revised the copyright files, ported some of Julian's work and generated a new set of debs. You can find them online. Let me know what to do next. PS: Note that we have just release OpenSIPS 2.1.1 Thanks a lot for your help! Răzvan Crainea OpenSIPS Solutions www.opensips-solutions.com On 08/19/2015 09:14 PM, Gianfranco Costamagna wrote: BTW I would like to have a rules file with plain dh_ calls, can you please try to use the rules file from julian's svn? you can compare the output of two builds with debdiff if needed, I would really appreciate the move (actually it should simplify the packaging, and makes two lintian warnings disappear) thanks a lot, Gianfranco Il Mercoledì 19 Agosto 2015 18:34, Gianfranco Costamagna costamagnagianfra...@yahoo.it ha scritto: Hi, I didn't have time for a complete review, but two things needs to be fixed: some copyrights are missing, ISL and some BSD2 IIRC (I did a licensecheck * -r) changelog should have one single entry with initial upload closes blah or whatever, and the target suite should be unstable, not stable. As soon as you fix the two above I'll give it a new spin (sorry but today I didn't have much time). Julian I would appreciate if you could do the upload, since you should already have a good knowledge about the package. Also an ack might be appreciated, specially for the copyright file :) cheers, Gianfranco Il Mercoledì 19 Agosto 2015 16:44, Răzvan Crainea raz...@opensips.org ha scritto: Hi, Gianfranco! I uploaded the latest version and it seems there are no other warnings. I changed the format of the archive to be non-native updated some of the files and everything seems ok now. @Julian: thanks for checking this too. I am aware there were some issues regarding the licencing, but these should have been solved now, since the TLS module (the code that was using openssl) is now in a completely new module. I added explicit licences for its code. Best regards, Răzvan Crainea OpenSIPS Solutions www.opensips-solutions.com On 08/19/2015 04:14 PM, Gianfranco Costamagna wrote: Hi W debian-watch-file-in-native-package* You asked me to add a watch file, but I created a native package. Should I remove the file? why? don't you have an orig tarball to start from? http://opensips.org/pub/opensips/latest/src/ just use quilt source format, and make the vcs point to the orig tarballs. If you want a native package you need to explain why you need, maybe you want a dfsg tarball, in that case you download it and remove unneeded files (with Files-Excluded copyright feature, or with a get-orig-source target) W native-package-with-dash-version* I can't change the package's name, because I will get a different error (latest-debian-changelog-entry-changed-to-native) yes, source/format is native, and you have a dash (because of the -1 revision) you need to choose P debian-watch-may-check-gpg-signature * is this mandatory or can be ommitted? can be omitted, but nice to have :) (nice to ask upstream to do it) cheers, G.
Re: Looking for a mentor for the OpenSIPS project
Hi, Gianfranco! It is not removed - it is still in the sources, but not in the .orig.tar.gz archive, since I read the upstream tarball should not have packaging specs inside it. Should I remove the copyright exception? Thanks, Răzvan Crainea OpenSIPS Solutions www.opensips-solutions.com On 08/20/2015 03:43 PM, Gianfranco Costamagna wrote: Hi, I unused-file-paragraph-in-dep5-copyright paragraph at line 70 I wildcard-matches-nothing-in-dep5-copyright packaging/gentoo/opensips-*.ebuild (paragraph at line 70) I guess you removed it? Julian, how do you feel about it? cheers, G. Il Giovedì 20 Agosto 2015 13:45, Răzvan Crainea raz...@opensips.org ha scritto: Hi, Gianfranco, Julian! I revised the copyright files, ported some of Julian's work and generated a new set of debs. You can find them online. Let me know what to do next. PS: Note that we have just release OpenSIPS 2.1.1 Thanks a lot for your help! Răzvan Crainea OpenSIPS Solutions www.opensips-solutions.com On 08/19/2015 09:14 PM, Gianfranco Costamagna wrote: BTW I would like to have a rules file with plain dh_ calls, can you please try to use the rules file from julian's svn? you can compare the output of two builds with debdiff if needed, I would really appreciate the move (actually it should simplify the packaging, and makes two lintian warnings disappear) thanks a lot, Gianfranco Il Mercoledì 19 Agosto 2015 18:34, Gianfranco Costamagna costamagnagianfra...@yahoo.it ha scritto: Hi, I didn't have time for a complete review, but two things needs to be fixed: some copyrights are missing, ISL and some BSD2 IIRC (I did a licensecheck * -r) changelog should have one single entry with initial upload closes blah or whatever, and the target suite should be unstable, not stable. As soon as you fix the two above I'll give it a new spin (sorry but today I didn't have much time). Julian I would appreciate if you could do the upload, since you should already have a good knowledge about the package. Also an ack might be appreciated, specially for the copyright file :) cheers, Gianfranco Il Mercoledì 19 Agosto 2015 16:44, Răzvan Crainea raz...@opensips.org ha scritto: Hi, Gianfranco! I uploaded the latest version and it seems there are no other warnings. I changed the format of the archive to be non-native updated some of the files and everything seems ok now. @Julian: thanks for checking this too. I am aware there were some issues regarding the licencing, but these should have been solved now, since the TLS module (the code that was using openssl) is now in a completely new module. I added explicit licences for its code. Best regards, Răzvan Crainea OpenSIPS Solutions www.opensips-solutions.com On 08/19/2015 04:14 PM, Gianfranco Costamagna wrote: Hi W debian-watch-file-in-native-package* You asked me to add a watch file, but I created a native package. Should I remove the file? why? don't you have an orig tarball to start from? http://opensips.org/pub/opensips/latest/src/ just use quilt source format, and make the vcs point to the orig tarballs. If you want a native package you need to explain why you need, maybe you want a dfsg tarball, in that case you download it and remove unneeded files (with Files-Excluded copyright feature, or with a get-orig-source target) W native-package-with-dash-version* I can't change the package's name, because I will get a different error (latest-debian-changelog-entry-changed-to-native) yes, source/format is native, and you have a dash (because of the -1 revision) you need to choose P debian-watch-may-check-gpg-signature * is this mandatory or can be ommitted? can be omitted, but nice to have :) (nice to ask upstream to do it) cheers, G.
Re: Looking for a mentor for the OpenSIPS project
Hi, It is not removed - it is still in the sources, but not in the .orig.tar.gz archive, since I read the upstream tarball should not have packaging specs inside it. Should I remove the copyright exception? For Debian sources means the orig tarball, that should be the same as the upstream shipped one (otherwise it might be a repack or a dfsg tarball). So if upstream removes them when releasing, for Debian the file doesn't exist at all. you might have everything you want in your git/svn tree, even built files or cmake or whatever. You need to document in copyright everything that is in the tarball you have with the software you upload in Debian. cheers, G.
Re: Looking for a mentor for the OpenSIPS project
Hi, I unused-file-paragraph-in-dep5-copyright paragraph at line 70 I wildcard-matches-nothing-in-dep5-copyright packaging/gentoo/opensips-*.ebuild (paragraph at line 70) I guess you removed it? Julian, how do you feel about it? cheers, G. Il Giovedì 20 Agosto 2015 13:45, Răzvan Crainea raz...@opensips.org ha scritto: Hi, Gianfranco, Julian! I revised the copyright files, ported some of Julian's work and generated a new set of debs. You can find them online. Let me know what to do next. PS: Note that we have just release OpenSIPS 2.1.1 Thanks a lot for your help! Răzvan Crainea OpenSIPS Solutions www.opensips-solutions.com On 08/19/2015 09:14 PM, Gianfranco Costamagna wrote: BTW I would like to have a rules file with plain dh_ calls, can you please try to use the rules file from julian's svn? you can compare the output of two builds with debdiff if needed, I would really appreciate the move (actually it should simplify the packaging, and makes two lintian warnings disappear) thanks a lot, Gianfranco Il Mercoledì 19 Agosto 2015 18:34, Gianfranco Costamagna costamagnagianfra...@yahoo.it ha scritto: Hi, I didn't have time for a complete review, but two things needs to be fixed: some copyrights are missing, ISL and some BSD2 IIRC (I did a licensecheck * -r) changelog should have one single entry with initial upload closes blah or whatever, and the target suite should be unstable, not stable. As soon as you fix the two above I'll give it a new spin (sorry but today I didn't have much time). Julian I would appreciate if you could do the upload, since you should already have a good knowledge about the package. Also an ack might be appreciated, specially for the copyright file :) cheers, Gianfranco Il Mercoledì 19 Agosto 2015 16:44, Răzvan Crainea raz...@opensips.org ha scritto: Hi, Gianfranco! I uploaded the latest version and it seems there are no other warnings. I changed the format of the archive to be non-native updated some of the files and everything seems ok now. @Julian: thanks for checking this too. I am aware there were some issues regarding the licencing, but these should have been solved now, since the TLS module (the code that was using openssl) is now in a completely new module. I added explicit licences for its code. Best regards, Răzvan Crainea OpenSIPS Solutions www.opensips-solutions.com On 08/19/2015 04:14 PM, Gianfranco Costamagna wrote: Hi W debian-watch-file-in-native-package* You asked me to add a watch file, but I created a native package. Should I remove the file? why? don't you have an orig tarball to start from? http://opensips.org/pub/opensips/latest/src/ just use quilt source format, and make the vcs point to the orig tarballs. If you want a native package you need to explain why you need, maybe you want a dfsg tarball, in that case you download it and remove unneeded files (with Files-Excluded copyright feature, or with a get-orig-source target) W native-package-with-dash-version* I can't change the package's name, because I will get a different error (latest-debian-changelog-entry-changed-to-native) yes, source/format is native, and you have a dash (because of the -1 revision) you need to choose P debian-watch-may-check-gpg-signature * is this mandatory or can be ommitted? can be omitted, but nice to have :) (nice to ask upstream to do it) cheers, G.
Re: Looking for a mentor for the OpenSIPS project
Hello guys, Right now I am in irc.debian.org at debian-opensis channel, if you want we can coordinate there. Kind regards, 2015-08-20 7:53 GMT-05:00 Gianfranco Costamagna costamagnagianfra...@yahoo.it: Hi, It is not removed - it is still in the sources, but not in the .orig.tar.gz archive, since I read the upstream tarball should not have packaging specs inside it. Should I remove the copyright exception? For Debian sources means the orig tarball, that should be the same as the upstream shipped one (otherwise it might be a repack or a dfsg tarball). So if upstream removes them when releasing, for Debian the file doesn't exist at all. you might have everything you want in your git/svn tree, even built files or cmake or whatever. You need to document in copyright everything that is in the tarball you have with the software you upload in Debian. cheers, G. -- Julián Moreno Patiño Debian Developer .''`. Debian GNU/{Linux,KfreeBSD} : :' : Free Operating Systems `. `' http://debian.org/ `- GPG Fingerprint: C2C8 904E 314C D8FA 041D 9B00 D5FD FC15 6168 BF60 Registered GNU Linux User ID 488513
Re: Looking for a mentor for the OpenSIPS project
Hello, The package fail to build from source: dpkg-buildpackage: source package opensips dpkg-buildpackage: source version 2.1.1-1 dpkg-buildpackage: source distribution unstable dpkg-buildpackage: source changed by Razvan Crainea raz...@opensips.org dpkg-buildpackage: host architecture amd64 dpkg-source --before-build opensips-2.1.1 fakeroot debian/rules clean debian/rules:177: *** missing separator (did you mean TAB instead of 8 spaces?). Stop. dpkg-buildpackage: error: fakeroot debian/rules clean gave error exit status 2 E: Failed autobuilding of package 2015-08-20 8:03 GMT-05:00 Julián Moreno Patiño jul...@debian.org: Hello guys, Right now I am in irc.debian.org at debian-opensis channel, if you want we can coordinate there. Kind regards, 2015-08-20 7:53 GMT-05:00 Gianfranco Costamagna costamagnagianfra...@yahoo.it: Hi, It is not removed - it is still in the sources, but not in the .orig.tar.gz archive, since I read the upstream tarball should not have packaging specs inside it. Should I remove the copyright exception? For Debian sources means the orig tarball, that should be the same as the upstream shipped one (otherwise it might be a repack or a dfsg tarball). So if upstream removes them when releasing, for Debian the file doesn't exist at all. you might have everything you want in your git/svn tree, even built files or cmake or whatever. You need to document in copyright everything that is in the tarball you have with the software you upload in Debian. cheers, G. -- Julián Moreno Patiño Debian Developer .''`. Debian GNU/{Linux,KfreeBSD} : :' : Free Operating Systems `. `' http://debian.org/ `- GPG Fingerprint: C2C8 904E 314C D8FA 041D 9B00 D5FD FC15 6168 BF60 Registered GNU Linux User ID 488513 -- Julián Moreno Patiño Debian Developer .''`. Debian GNU/{Linux,KfreeBSD} : :' : Free Operating Systems `. `' http://debian.org/ `- GPG Fingerprint: C2C8 904E 314C D8FA 041D 9B00 D5FD FC15 6168 BF60 Registered GNU Linux User ID 488513
Re: Looking for a mentor for the OpenSIPS project
Hi, Gianfranco! I fixed all the other warnings, but still have 3 that I don't really know how to handle: W debian-watch-file-in-native-package * You asked me to add a watch file, but I created a native package. Should I remove the file? W native-package-with-dash-version * I can't change the package's name, because I will get a different error (latest-debian-changelog-entry-changed-to-native) P debian-watch-may-check-gpg-signature * is this mandatory or can be ommitted? Thanks! Răzvan Crainea OpenSIPS Solutions www.opensips-solutions.com On 08/18/2015 05:45 PM, Gianfranco Costamagna wrote: Yes, would be nice to fix them too :) let me know when you have done! thanks, G. Il Martedì 18 Agosto 2015 16:35, Răzvan Crainea raz...@opensips.org ha scritto: Hi, Can you please check now. Not sure what happened in the first place. It looks like it still has some lintian warnings that I didn't detect (I was using an older lintian version), but I will work on fixing those too. Best regards, Răzvan Crainea OpenSIPS Solutions www.opensips-solutions.com On 08/18/2015 05:11 PM, Gianfranco Costamagna wrote: Hi, unfortunately the upload seems to be missing Uploaded: 2015-08-14 13:41 cheers, G. Il Martedì 18 Agosto 2015 15:22, Răzvan Crainea raz...@opensips.org ha scritto: Hi, Gianfranco! I managed to fix most of the warnings I had. Please check out the latest sources on mentor's site[1]. [1] http://mentors.debian.net/package/opensips Many thanks, Răzvan Crainea OpenSIPS Solutions www.opensips-solutions.com On 08/14/2015 10:41 PM, Gianfranco Costamagna wrote: Hi Răzvan, thanks for the fixes, mentors is showing many lintian errors... can you please fix them? reporting them here: E copyright-should-refer-to-common-license-file-for-gpl W hardening-no-relro I hardening-no-fortify-functions (usually fixed by not overriding C*FLAGS and LDFLAGS I package-contains-empty-directory usr/sbin/ udp_server.o tcp_read.o tcp_main.o sctp_server.o pass_fd.o object files in the source tree is bad W debhelper-but-no-misc-depends W debian-rules-missing-recommended-target build-arch build-indep W debian-watch-file-in-native-package the package shouldn't be native W dh-clean-k-is-deprecated W diff-contains-git-control-dir .git .git directory shouldn't really be there W native-package-with-dash-version W syntax-error-in-dep5-copyright line 7: Duplicate field copyright. P debian-watch-may-check-gpg-signature P source-contains-prebuilt-binary P source-contains-prebuilt-windows-binary W wrong-section-according-to-package-name opensips-dbg = debug I spelling-error-in-binary usr/lib/opensips/modules/dialplan.so Succesfully Successfully E copyright-should-refer-to-common-license-file-for-gpl W extended-description-line-too-long W binary-without-manpage usr/sbin/osipsconsole E dir-or-file-in-var-run var/run/opensips/ E init.d-script-missing-dependency-on-remote_fs etc/init.d/opensips: required-start etc/init.d/opensips: required-stop E python-script-but-no-python-dep usr/lib/opensips/opensipsctl/dbtextdb/dbtextdb.py W binary-without-manpage W init.d-script-does-not-source-init-functions etc/init.d/opensips W package-contains-upstream-install-documentation usr/share/doc/opensips/INSTALL.gz I hyphen-used-as-minus-sign usr/share/man/man8/opensipsctl.8.gz:127 usr/share/man/man8/opensipsctl.8.gz:135 I spelling-error-in-binary I spelling-error-in-manpage E missing-dependency-on-libc needed by usr/lib/opensips/modules/rest_client.so E possible-gpl-code-linked-with-openssl W hardening-no-relro many of them are really showstopper, while others might be just nitpicks. the gpl-code-linked-with-openssl is something really serious that needs to be fixed (even mentioned in the ITP bug). lintian can give you an explanation for all the above issues, if you have any kind of dubts please ask here and $somebody will give you an answer :) cheers, Gianfranco
Re: Looking for a mentor for the OpenSIPS project
Hi W debian-watch-file-in-native-package* You asked me to add a watch file, but I created a native package. Should I remove the file? why? don't you have an orig tarball to start from? http://opensips.org/pub/opensips/latest/src/ just use quilt source format, and make the vcs point to the orig tarballs. If you want a native package you need to explain why you need, maybe you want a dfsg tarball, in that case you download it and remove unneeded files (with Files-Excluded copyright feature, or with a get-orig-source target) W native-package-with-dash-version* I can't change the package's name, because I will get a different error (latest-debian-changelog-entry-changed-to-native) yes, source/format is native, and you have a dash (because of the -1 revision) you need to choose P debian-watch-may-check-gpg-signature * is this mandatory or can be ommitted? can be omitted, but nice to have :) (nice to ask upstream to do it) cheers, G.
Re: Looking for a mentor for the OpenSIPS project
Hello guys, I worked in opensis packaging sometime ago, may be this would be useful: http://anonscm.debian.org/viewvc/pkg-voip/opensips/trunk/debian/ or just check out the repository: svn://svn.debian.org/pkg-voip/opensips/trunk/ Check carefully the copyright, when I checked the source code I found several licensing types. If you need to know something please add me to CC, I am not subscribe to the list. Also try to maintain it under pkg-voip umbrella :) http://pkg-voip.alioth.debian.org/ Kind regards, -- Julián Moreno Patiño Debian Developer .''`. Debian GNU/{Linux,KfreeBSD} : :' : Free Operating Systems `. `' http://debian.org/ `- GPG Fingerprint: C2C8 904E 314C D8FA 041D 9B00 D5FD FC15 6168 BF60 Registered GNU Linux User ID 488513
Re: Looking for a mentor for the OpenSIPS project
Hi, Gianfranco! I uploaded the latest version and it seems there are no other warnings. I changed the format of the archive to be non-native updated some of the files and everything seems ok now. @Julian: thanks for checking this too. I am aware there were some issues regarding the licencing, but these should have been solved now, since the TLS module (the code that was using openssl) is now in a completely new module. I added explicit licences for its code. Best regards, Răzvan Crainea OpenSIPS Solutions www.opensips-solutions.com On 08/19/2015 04:14 PM, Gianfranco Costamagna wrote: Hi W debian-watch-file-in-native-package* You asked me to add a watch file, but I created a native package. Should I remove the file? why? don't you have an orig tarball to start from? http://opensips.org/pub/opensips/latest/src/ just use quilt source format, and make the vcs point to the orig tarballs. If you want a native package you need to explain why you need, maybe you want a dfsg tarball, in that case you download it and remove unneeded files (with Files-Excluded copyright feature, or with a get-orig-source target) W native-package-with-dash-version* I can't change the package's name, because I will get a different error (latest-debian-changelog-entry-changed-to-native) yes, source/format is native, and you have a dash (because of the -1 revision) you need to choose P debian-watch-may-check-gpg-signature * is this mandatory or can be ommitted? can be omitted, but nice to have :) (nice to ask upstream to do it) cheers, G.
Re: Looking for a mentor for the OpenSIPS project
Hi, I didn't have time for a complete review, but two things needs to be fixed: some copyrights are missing, ISL and some BSD2 IIRC (I did a licensecheck * -r) changelog should have one single entry with initial upload closes blah or whatever, and the target suite should be unstable, not stable. As soon as you fix the two above I'll give it a new spin (sorry but today I didn't have much time). Julian I would appreciate if you could do the upload, since you should already have a good knowledge about the package. Also an ack might be appreciated, specially for the copyright file :) cheers, Gianfranco Il Mercoledì 19 Agosto 2015 16:44, Răzvan Crainea raz...@opensips.org ha scritto: Hi, Gianfranco! I uploaded the latest version and it seems there are no other warnings. I changed the format of the archive to be non-native updated some of the files and everything seems ok now. @Julian: thanks for checking this too. I am aware there were some issues regarding the licencing, but these should have been solved now, since the TLS module (the code that was using openssl) is now in a completely new module. I added explicit licences for its code. Best regards, Răzvan Crainea OpenSIPS Solutions www.opensips-solutions.com On 08/19/2015 04:14 PM, Gianfranco Costamagna wrote: Hi W debian-watch-file-in-native-package* You asked me to add a watch file, but I created a native package. Should I remove the file? why? don't you have an orig tarball to start from? http://opensips.org/pub/opensips/latest/src/ just use quilt source format, and make the vcs point to the orig tarballs. If you want a native package you need to explain why you need, maybe you want a dfsg tarball, in that case you download it and remove unneeded files (with Files-Excluded copyright feature, or with a get-orig-source target) W native-package-with-dash-version* I can't change the package's name, because I will get a different error (latest-debian-changelog-entry-changed-to-native) yes, source/format is native, and you have a dash (because of the -1 revision) you need to choose P debian-watch-may-check-gpg-signature * is this mandatory or can be ommitted? can be omitted, but nice to have :) (nice to ask upstream to do it) cheers, G.
Re: Looking for a mentor for the OpenSIPS project
BTW I would like to have a rules file with plain dh_ calls, can you please try to use the rules file from julian's svn? you can compare the output of two builds with debdiff if needed, I would really appreciate the move (actually it should simplify the packaging, and makes two lintian warnings disappear) thanks a lot, Gianfranco Il Mercoledì 19 Agosto 2015 18:34, Gianfranco Costamagna costamagnagianfra...@yahoo.it ha scritto: Hi, I didn't have time for a complete review, but two things needs to be fixed: some copyrights are missing, ISL and some BSD2 IIRC (I did a licensecheck * -r) changelog should have one single entry with initial upload closes blah or whatever, and the target suite should be unstable, not stable. As soon as you fix the two above I'll give it a new spin (sorry but today I didn't have much time). Julian I would appreciate if you could do the upload, since you should already have a good knowledge about the package. Also an ack might be appreciated, specially for the copyright file :) cheers, Gianfranco Il Mercoledì 19 Agosto 2015 16:44, Răzvan Crainea raz...@opensips.org ha scritto: Hi, Gianfranco! I uploaded the latest version and it seems there are no other warnings. I changed the format of the archive to be non-native updated some of the files and everything seems ok now. @Julian: thanks for checking this too. I am aware there were some issues regarding the licencing, but these should have been solved now, since the TLS module (the code that was using openssl) is now in a completely new module. I added explicit licences for its code. Best regards, Răzvan Crainea OpenSIPS Solutions www.opensips-solutions.com On 08/19/2015 04:14 PM, Gianfranco Costamagna wrote: Hi W debian-watch-file-in-native-package* You asked me to add a watch file, but I created a native package. Should I remove the file? why? don't you have an orig tarball to start from? http://opensips.org/pub/opensips/latest/src/ just use quilt source format, and make the vcs point to the orig tarballs. If you want a native package you need to explain why you need, maybe you want a dfsg tarball, in that case you download it and remove unneeded files (with Files-Excluded copyright feature, or with a get-orig-source target) W native-package-with-dash-version* I can't change the package's name, because I will get a different error (latest-debian-changelog-entry-changed-to-native) yes, source/format is native, and you have a dash (because of the -1 revision) you need to choose P debian-watch-may-check-gpg-signature * is this mandatory or can be ommitted? can be omitted, but nice to have :) (nice to ask upstream to do it) cheers, G.
Re: Looking for a mentor for the OpenSIPS project
Hi, Can you please check now. Not sure what happened in the first place. It looks like it still has some lintian warnings that I didn't detect (I was using an older lintian version), but I will work on fixing those too. Best regards, Răzvan Crainea OpenSIPS Solutions www.opensips-solutions.com On 08/18/2015 05:11 PM, Gianfranco Costamagna wrote: Hi, unfortunately the upload seems to be missing Uploaded: 2015-08-14 13:41 cheers, G. Il Martedì 18 Agosto 2015 15:22, Răzvan Crainea raz...@opensips.org ha scritto: Hi, Gianfranco! I managed to fix most of the warnings I had. Please check out the latest sources on mentor's site[1]. [1] http://mentors.debian.net/package/opensips Many thanks, Răzvan Crainea OpenSIPS Solutions www.opensips-solutions.com On 08/14/2015 10:41 PM, Gianfranco Costamagna wrote: Hi Răzvan, thanks for the fixes, mentors is showing many lintian errors... can you please fix them? reporting them here: E copyright-should-refer-to-common-license-file-for-gpl W hardening-no-relro I hardening-no-fortify-functions (usually fixed by not overriding C*FLAGS and LDFLAGS I package-contains-empty-directory usr/sbin/ udp_server.o tcp_read.o tcp_main.o sctp_server.o pass_fd.o object files in the source tree is bad W debhelper-but-no-misc-depends W debian-rules-missing-recommended-target build-arch build-indep W debian-watch-file-in-native-package the package shouldn't be native W dh-clean-k-is-deprecated W diff-contains-git-control-dir .git .git directory shouldn't really be there W native-package-with-dash-version W syntax-error-in-dep5-copyright line 7: Duplicate field copyright. P debian-watch-may-check-gpg-signature P source-contains-prebuilt-binary P source-contains-prebuilt-windows-binary W wrong-section-according-to-package-name opensips-dbg = debug I spelling-error-in-binary usr/lib/opensips/modules/dialplan.so Succesfully Successfully E copyright-should-refer-to-common-license-file-for-gpl W extended-description-line-too-long W binary-without-manpage usr/sbin/osipsconsole E dir-or-file-in-var-run var/run/opensips/ E init.d-script-missing-dependency-on-remote_fs etc/init.d/opensips: required-start etc/init.d/opensips: required-stop E python-script-but-no-python-dep usr/lib/opensips/opensipsctl/dbtextdb/dbtextdb.py W binary-without-manpage W init.d-script-does-not-source-init-functions etc/init.d/opensips W package-contains-upstream-install-documentation usr/share/doc/opensips/INSTALL.gz I hyphen-used-as-minus-sign usr/share/man/man8/opensipsctl.8.gz:127 usr/share/man/man8/opensipsctl.8.gz:135 I spelling-error-in-binary I spelling-error-in-manpage E missing-dependency-on-libc needed by usr/lib/opensips/modules/rest_client.so E possible-gpl-code-linked-with-openssl W hardening-no-relro many of them are really showstopper, while others might be just nitpicks. the gpl-code-linked-with-openssl is something really serious that needs to be fixed (even mentioned in the ITP bug). lintian can give you an explanation for all the above issues, if you have any kind of dubts please ask here and $somebody will give you an answer :) cheers, Gianfranco
Re: Looking for a mentor for the OpenSIPS project
Yes, would be nice to fix them too :) let me know when you have done! thanks, G. Il Martedì 18 Agosto 2015 16:35, Răzvan Crainea raz...@opensips.org ha scritto: Hi, Can you please check now. Not sure what happened in the first place. It looks like it still has some lintian warnings that I didn't detect (I was using an older lintian version), but I will work on fixing those too. Best regards, Răzvan Crainea OpenSIPS Solutions www.opensips-solutions.com On 08/18/2015 05:11 PM, Gianfranco Costamagna wrote: Hi, unfortunately the upload seems to be missing Uploaded: 2015-08-14 13:41 cheers, G. Il Martedì 18 Agosto 2015 15:22, Răzvan Crainea raz...@opensips.org ha scritto: Hi, Gianfranco! I managed to fix most of the warnings I had. Please check out the latest sources on mentor's site[1]. [1] http://mentors.debian.net/package/opensips Many thanks, Răzvan Crainea OpenSIPS Solutions www.opensips-solutions.com On 08/14/2015 10:41 PM, Gianfranco Costamagna wrote: Hi Răzvan, thanks for the fixes, mentors is showing many lintian errors... can you please fix them? reporting them here: E copyright-should-refer-to-common-license-file-for-gpl W hardening-no-relro I hardening-no-fortify-functions (usually fixed by not overriding C*FLAGS and LDFLAGS I package-contains-empty-directory usr/sbin/ udp_server.o tcp_read.o tcp_main.o sctp_server.o pass_fd.o object files in the source tree is bad W debhelper-but-no-misc-depends W debian-rules-missing-recommended-target build-arch build-indep W debian-watch-file-in-native-package the package shouldn't be native W dh-clean-k-is-deprecated W diff-contains-git-control-dir .git .git directory shouldn't really be there W native-package-with-dash-version W syntax-error-in-dep5-copyright line 7: Duplicate field copyright. P debian-watch-may-check-gpg-signature P source-contains-prebuilt-binary P source-contains-prebuilt-windows-binary W wrong-section-according-to-package-name opensips-dbg = debug I spelling-error-in-binary usr/lib/opensips/modules/dialplan.so Succesfully Successfully E copyright-should-refer-to-common-license-file-for-gpl W extended-description-line-too-long W binary-without-manpage usr/sbin/osipsconsole E dir-or-file-in-var-run var/run/opensips/ E init.d-script-missing-dependency-on-remote_fs etc/init.d/opensips: required-start etc/init.d/opensips: required-stop E python-script-but-no-python-dep usr/lib/opensips/opensipsctl/dbtextdb/dbtextdb.py W binary-without-manpage W init.d-script-does-not-source-init-functions etc/init.d/opensips W package-contains-upstream-install-documentation usr/share/doc/opensips/INSTALL.gz I hyphen-used-as-minus-sign usr/share/man/man8/opensipsctl.8.gz:127 usr/share/man/man8/opensipsctl.8.gz:135 I spelling-error-in-binary I spelling-error-in-manpage E missing-dependency-on-libc needed by usr/lib/opensips/modules/rest_client.so E possible-gpl-code-linked-with-openssl W hardening-no-relro many of them are really showstopper, while others might be just nitpicks. the gpl-code-linked-with-openssl is something really serious that needs to be fixed (even mentioned in the ITP bug). lintian can give you an explanation for all the above issues, if you have any kind of dubts please ask here and $somebody will give you an answer :) cheers, Gianfranco
Re: Looking for a mentor for the OpenSIPS project
Hi, Gianfranco! I managed to fix most of the warnings I had. Please check out the latest sources on mentor's site[1]. [1] http://mentors.debian.net/package/opensips Many thanks, Răzvan Crainea OpenSIPS Solutions www.opensips-solutions.com On 08/14/2015 10:41 PM, Gianfranco Costamagna wrote: Hi Răzvan, thanks for the fixes, mentors is showing many lintian errors... can you please fix them? reporting them here: E copyright-should-refer-to-common-license-file-for-gpl W hardening-no-relro I hardening-no-fortify-functions (usually fixed by not overriding C*FLAGS and LDFLAGS I package-contains-empty-directory usr/sbin/ udp_server.o tcp_read.o tcp_main.o sctp_server.o pass_fd.o object files in the source tree is bad W debhelper-but-no-misc-depends W debian-rules-missing-recommended-target build-arch build-indep W debian-watch-file-in-native-package the package shouldn't be native W dh-clean-k-is-deprecated W diff-contains-git-control-dir .git .git directory shouldn't really be there W native-package-with-dash-version W syntax-error-in-dep5-copyright line 7: Duplicate field copyright. P debian-watch-may-check-gpg-signature P source-contains-prebuilt-binary P source-contains-prebuilt-windows-binary W wrong-section-according-to-package-name opensips-dbg = debug I spelling-error-in-binary usr/lib/opensips/modules/dialplan.so Succesfully Successfully E copyright-should-refer-to-common-license-file-for-gpl W extended-description-line-too-long W binary-without-manpage usr/sbin/osipsconsole E dir-or-file-in-var-run var/run/opensips/ E init.d-script-missing-dependency-on-remote_fs etc/init.d/opensips: required-start etc/init.d/opensips: required-stop E python-script-but-no-python-dep usr/lib/opensips/opensipsctl/dbtextdb/dbtextdb.py W binary-without-manpage W init.d-script-does-not-source-init-functions etc/init.d/opensips W package-contains-upstream-install-documentation usr/share/doc/opensips/INSTALL.gz I hyphen-used-as-minus-sign usr/share/man/man8/opensipsctl.8.gz:127 usr/share/man/man8/opensipsctl.8.gz:135 I spelling-error-in-binary I spelling-error-in-manpage E missing-dependency-on-libc needed by usr/lib/opensips/modules/rest_client.so E possible-gpl-code-linked-with-openssl W hardening-no-relro many of them are really showstopper, while others might be just nitpicks. the gpl-code-linked-with-openssl is something really serious that needs to be fixed (even mentioned in the ITP bug). lintian can give you an explanation for all the above issues, if you have any kind of dubts please ask here and $somebody will give you an answer :) cheers, Gianfranco
Re: Looking for a mentor for the OpenSIPS project
Hi, unfortunately the upload seems to be missing Uploaded: 2015-08-14 13:41 cheers, G. Il Martedì 18 Agosto 2015 15:22, Răzvan Crainea raz...@opensips.org ha scritto: Hi, Gianfranco! I managed to fix most of the warnings I had. Please check out the latest sources on mentor's site[1]. [1] http://mentors.debian.net/package/opensips Many thanks, Răzvan Crainea OpenSIPS Solutions www.opensips-solutions.com On 08/14/2015 10:41 PM, Gianfranco Costamagna wrote: Hi Răzvan, thanks for the fixes, mentors is showing many lintian errors... can you please fix them? reporting them here: E copyright-should-refer-to-common-license-file-for-gpl W hardening-no-relro I hardening-no-fortify-functions (usually fixed by not overriding C*FLAGS and LDFLAGS I package-contains-empty-directory usr/sbin/ udp_server.o tcp_read.o tcp_main.o sctp_server.o pass_fd.o object files in the source tree is bad W debhelper-but-no-misc-depends W debian-rules-missing-recommended-target build-arch build-indep W debian-watch-file-in-native-package the package shouldn't be native W dh-clean-k-is-deprecated W diff-contains-git-control-dir .git .git directory shouldn't really be there W native-package-with-dash-version W syntax-error-in-dep5-copyright line 7: Duplicate field copyright. P debian-watch-may-check-gpg-signature P source-contains-prebuilt-binary P source-contains-prebuilt-windows-binary W wrong-section-according-to-package-name opensips-dbg = debug I spelling-error-in-binary usr/lib/opensips/modules/dialplan.so Succesfully Successfully E copyright-should-refer-to-common-license-file-for-gpl W extended-description-line-too-long W binary-without-manpage usr/sbin/osipsconsole E dir-or-file-in-var-run var/run/opensips/ E init.d-script-missing-dependency-on-remote_fs etc/init.d/opensips: required-start etc/init.d/opensips: required-stop E python-script-but-no-python-dep usr/lib/opensips/opensipsctl/dbtextdb/dbtextdb.py W binary-without-manpage W init.d-script-does-not-source-init-functions etc/init.d/opensips W package-contains-upstream-install-documentation usr/share/doc/opensips/INSTALL.gz I hyphen-used-as-minus-sign usr/share/man/man8/opensipsctl.8.gz:127 usr/share/man/man8/opensipsctl.8.gz:135 I spelling-error-in-binary I spelling-error-in-manpage E missing-dependency-on-libc needed by usr/lib/opensips/modules/rest_client.so E possible-gpl-code-linked-with-openssl W hardening-no-relro many of them are really showstopper, while others might be just nitpicks. the gpl-code-linked-with-openssl is something really serious that needs to be fixed (even mentioned in the ITP bug). lintian can give you an explanation for all the above issues, if you have any kind of dubts please ask here and $somebody will give you an answer :) cheers, Gianfranco
Re: Looking for a mentor for the OpenSIPS project
Hi Răzvan, thanks for the fixes, mentors is showing many lintian errors... can you please fix them? reporting them here: E copyright-should-refer-to-common-license-file-for-gpl W hardening-no-relro I hardening-no-fortify-functions (usually fixed by not overriding C*FLAGS and LDFLAGS I package-contains-empty-directory usr/sbin/ udp_server.o tcp_read.o tcp_main.o sctp_server.o pass_fd.o object files in the source tree is bad W debhelper-but-no-misc-depends W debian-rules-missing-recommended-target build-arch build-indep W debian-watch-file-in-native-package the package shouldn't be native W dh-clean-k-is-deprecated W diff-contains-git-control-dir .git .git directory shouldn't really be there W native-package-with-dash-version W syntax-error-in-dep5-copyright line 7: Duplicate field copyright. P debian-watch-may-check-gpg-signature P source-contains-prebuilt-binary P source-contains-prebuilt-windows-binary W wrong-section-according-to-package-name opensips-dbg = debug I spelling-error-in-binary usr/lib/opensips/modules/dialplan.so Succesfully Successfully E copyright-should-refer-to-common-license-file-for-gpl W extended-description-line-too-long W binary-without-manpage usr/sbin/osipsconsole E dir-or-file-in-var-run var/run/opensips/ E init.d-script-missing-dependency-on-remote_fs etc/init.d/opensips: required-start etc/init.d/opensips: required-stop E python-script-but-no-python-dep usr/lib/opensips/opensipsctl/dbtextdb/dbtextdb.py W binary-without-manpage W init.d-script-does-not-source-init-functions etc/init.d/opensips W package-contains-upstream-install-documentation usr/share/doc/opensips/INSTALL.gz I hyphen-used-as-minus-sign usr/share/man/man8/opensipsctl.8.gz:127 usr/share/man/man8/opensipsctl.8.gz:135 I spelling-error-in-binary I spelling-error-in-manpage E missing-dependency-on-libc needed by usr/lib/opensips/modules/rest_client.so E possible-gpl-code-linked-with-openssl W hardening-no-relro many of them are really showstopper, while others might be just nitpicks. the gpl-code-linked-with-openssl is something really serious that needs to be fixed (even mentioned in the ITP bug). lintian can give you an explanation for all the above issues, if you have any kind of dubts please ask here and $somebody will give you an answer :) cheers, Gianfranco
Re: Looking for a mentor for the OpenSIPS project
Hi, Gianfranco! Thanks for looking into this and pointing me to the right documentation. I did some package cleanup as you requested: 1) Looking through the bugs agaist wnpp[1], I found out there was a previous Request For Package for OpenSIPS here[2] and I changed its title to ITP and its owner. 2) I updated the changelog to close the 556131 bug[2] 3) Updated compat version to 9 4) Updated copyright format 5) Removed blank line from opensips.examples 6) Removed debian/patches 7) Added watch file 8) Increased the std version to 3.9.6 and removed the conflicts 9) I'm not sure what generated stuff you want me to remove from debian/rules. I will look into the dh format in the following week to convert the rules file. I uploaded the new debs on the mentors page[3]. Can you please revise them and let me know where I should look next? [1] https://bugs.debian.org/cgi-bin/pkgreport.cgi?package=wnpp [2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=556131 [3] http://mentors.debian.net/package/opensips Thanks for your help! Răzvan Crainea OpenSIPS Solutions www.opensips-solutions.com On 08/11/2015 04:51 PM, Gianfranco Costamagna wrote: Hi My name is Razvan Crainea[1] and I am one of the Core developers of the OpenSIPS project, a Voice-over-IP SIP server. We would like our project to be added to the official Debian repository and we need a mentor to help us achieve this. We already have some DEB packages for OpenSIPS that are public here[2]. Is there anybody willing to mentor our project and help us push the OpenSIPS DEBs in the official repository? In order to speed up things and reviews you can upload your packages on mentors.debian.net, and read the documentation here :) anyway, I did a dget -u http://apt.opensips.org/debian/bleeding/jessie/pool/main/o/opensips/opensips_2.1.1~1.gbpa02d31.dsc and some package cleanup is neededd: 1) please open an ITP bug https://www.debian.org/devel/wnpp/ 2) update the changelog to say Initial Release (Closes: #ITPBUGN) 3) debian/compat level should be 9 4) debian/copyright should be in a machine-readable form https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ 5) debian/opensips.examples has a blank newline (nitpick) 6) debian/patches looks old, please remove 7) please add a watch file 8) debian/control - please bump std-version to 3.9.6 - please remove the conflicts ( ${binary:Version}) you need to put the exact version where a package split or whatever has been made in order to be able to remove it when the version will be already in old-old-stable - please run wrap-and-sort 9) debian/rules please remove the autogenerated stuff at the begin - nice to have: please convert in the new dh format cheers, Gianfranco
Re: Looking for a mentor for the OpenSIPS project
Hi My name is Razvan Crainea[1] and I am one of the Core developers of the OpenSIPS project, a Voice-over-IP SIP server. We would like our project to be added to the official Debian repository and we need a mentor to help us achieve this. We already have some DEB packages for OpenSIPS that are public here[2]. Is there anybody willing to mentor our project and help us push the OpenSIPS DEBs in the official repository? In order to speed up things and reviews you can upload your packages on mentors.debian.net, and read the documentation here :) anyway, I did a dget -u http://apt.opensips.org/debian/bleeding/jessie/pool/main/o/opensips/opensips_2.1.1~1.gbpa02d31.dsc and some package cleanup is neededd: 1) please open an ITP bug https://www.debian.org/devel/wnpp/ 2) update the changelog to say Initial Release (Closes: #ITPBUGN) 3) debian/compat level should be 9 4) debian/copyright should be in a machine-readable form https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ 5) debian/opensips.examples has a blank newline (nitpick) 6) debian/patches looks old, please remove 7) please add a watch file 8) debian/control - please bump std-version to 3.9.6 - please remove the conflicts ( ${binary:Version}) you need to put the exact version where a package split or whatever has been made in order to be able to remove it when the version will be already in old-old-stable - please run wrap-and-sort 9) debian/rules please remove the autogenerated stuff at the begin - nice to have: please convert in the new dh format cheers, Gianfranco -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/550354816.2799809.1439301091892.javamail.ya...@mail.yahoo.com