Re: RFS: ESO Common Pipeline Library
Am 13.10.2011 20:55, schrieb Julian Taylor: On 10/13/2011 06:04 PM, Ole Streicher wrote: Am 12.10.2011 20:20, schrieb Julian Taylor: Else the package looks nice, good work. I implemented all changes from you and Sylvestre and re-uploaded the package: it still does not build. Its missing a dependency on libltdl-dev for ltdl.m4 as you now use autoreconf. Please test if your package builds in a clean environment. E.g. with pbuilder: https://wiki.ubuntu.com/PbuilderHowto Oops, sorry for that. I added the missing dependency now and successfully tested the package build in a clean pbuilder environment. I have reuploaded it to mentors.debian.net; http://mentors.debian.net/package/cpl I also successfully tested the esorex package in the pbuilder: http://mentors.debian.net/package/esorex I would be glad if they could be reviewed again, and possibly uploaded. Best regards Ole -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4e986ea7.4030...@liska.ath.cx
Re: RFS: ESO Common Pipeline Library
Am 12.10.2011 20:20, schrieb Julian Taylor: Else the package looks nice, good work. I implemented all changes from you and Sylvestre and re-uploaded the package: * Package name: cpl Version : 5.3.1-1 Upstream Author : ESO Project Team cpl-h...@eso.org * URL : http://www.eso.org/sci/software/cpl/ * License : GPLv2 Section : libs It builds those binary packages: libcext-dev - C utility library written by ESO (development files) libcext-doc - API documentation for ESO's C utility library libcext libcext0 - C utility library written by ESO libcpl-dev - ESO library for automated astronomical data-reduction libcpl-doc - API documentation for the Common Pipeline Library libcplcore12 - Fundamental CPL data types and functions libcpldfs12 - CPL functions for Data Flow System compability libcpldrs12 - CPL higher level data processing algorithms libcplui12 - CPL framework interface library To access further information about this package, please visit the following URL: http://mentors.debian.net/package/cpl Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/c/cpl/cpl_5.3.1-1.dsc I would be glad if someone uploaded this package for me. Kind regards, Ole Streicher -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4e970c04.3090...@liska.ath.cx
Re: RFS: ESO Common Pipeline Library
On 10/13/2011 06:04 PM, Ole Streicher wrote: Am 12.10.2011 20:20, schrieb Julian Taylor: Else the package looks nice, good work. I implemented all changes from you and Sylvestre and re-uploaded the package: it still does not build. Its missing a dependency on libltdl-dev for ltdl.m4 as you now use autoreconf. Please test if your package builds in a clean environment. E.g. with pbuilder: https://wiki.ubuntu.com/PbuilderHowto signature.asc Description: OpenPGP digital signature
Re: RFS: ESO Common Pipeline Library
Hello Ole, Le mercredi 12 octobre 2011 à 18:57 +0200, Ole Streicher a écrit : Dear mentors, I am looking for a sponsor for my package cpl. I am willing to sponsor you under the Debian Science umbrella. which will require your package to be hosted under svn or git and to follow the debian science policy: http://debian-science.alioth.debian.org/debian-science-policy.html Anyway, it could be nice to update a bit the description of the package. Thanks, Sylvestre -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/1318439313.3600.55.ca...@losinj.inria.fr
Re: RFS: ESO Common Pipeline Library
On 10/12/2011 06:57 PM, Ole Streicher wrote:
Dear mentors,
I am looking for a sponsor for my package cpl.
* Package name: cpl
Version : 5.3.1-1
Upstream Author : ESO Project Team cpl-h...@eso.org
* URL : http://www.eso.org/sci/software/cpl/
* License : GPLv2
Section : libs
It builds those binary packages:
libcext-dev - Header files for libcext
libcext-doc - API documentation for libcext
libcext0 - ESO's C Library Extensions
libcpl-dev - Header files for the Common Pipeline Library
libcpl-doc - API documentation for the Common Pipeline Library
libcplcore12 - Fundamental CPL data types and functions
libcpldfs12 - CPL functions to provide DFS compability
libcpldrs12 - CPL higher level data processing algorithms
libcplui12 - CPL framework interface library
To access further information about this package, please visit the
following URL:
http://mentors.debian.net/package/cpl
Alternatively, one can download the package with dget using this command:
dget -x http://mentors.debian.net/debian/pool/main/c/cpl/cpl_5.3.1-1.dsc
I would be glad if someone uploaded this package for me.
Hi,
the package does not build in a clean unstable chroot:
config.log
configure:12591: checking for cfitsio
configure: 12628: /usr/include/fitsio.h
taking that
configure: 12687: /usr/lib64/libcfitsio.a
configure: 12706: /usr/lib32/libcfitsio.a
configure: 12724: /usr/lib/libcfitsio.a
configure:12738: error: cfitsio was not found on your system. Please check!
This is because cfitsio has been converted to multiarch placing it in
/usr/lib/$(dpkg-architecture -qDEB_HOST_MULTIARCH)
The build should fall back to the system default paths when the library
is not found in the paths defined in m4/cpl.m4.
There are a couple of files with copyright held by the FSF in the source
but thats not mentioned in debian/copyright
You also don't need the GPL-2 license header twice, once is enough.
you don't need .dirs files for standard system paths like usr/{lib,include}
VLT instrument ... abbreviation in the description needs explaining or
maybe dropping.
fi is typed weird in everal places
line 68 operations de~Aned on, 108, 112 ...
Also as this package contains a number of libraries please consider
adding symbol files to aid finding api compatibility problems.
Else the package looks nice, good work.
Best Regards,
Julian Taylor
signature.asc
Description: OpenPGP digital signature
Re: RFS: ESO Common Pipeline Library
On 10/12/2011 06:57 PM, Ole Streicher wrote: Dear mentors, I am looking for a sponsor for my package cpl. * Package name: cpl Version : 5.3.1-1 Upstream Author : ESO Project Team cpl-h...@eso.org * URL : http://www.eso.org/sci/software/cpl/ * License : GPLv2 Section : libs It builds those binary packages: libcext-dev - Header files for libcext libcext-doc - API documentation for libcext libcext0 - ESO's C Library Extensions libcpl-dev - Header files for the Common Pipeline Library libcpl-doc - API documentation for the Common Pipeline Library libcplcore12 - Fundamental CPL data types and functions libcpldfs12 - CPL functions to provide DFS compability libcpldrs12 - CPL higher level data processing algorithms libcplui12 - CPL framework interface library To access further information about this package, please visit the following URL: http://mentors.debian.net/package/cpl Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/c/cpl/cpl_5.3.1-1.dsc I would be glad if someone uploaded this package for me. Kind regards, Ole Streicher I forgot: you depend on autotools-dev but do not use it. With dh-7 its: dh $@ --with autotools-dev signature.asc Description: OpenPGP digital signature
Re: RFS: ESO Common Pipeline Library
On Wed, Oct 12, 2011 at 11:30 AM, Julian Taylor jtaylor.deb...@googlemail.com wrote: On 10/12/2011 06:57 PM, Ole Streicher wrote: Dear mentors, I am looking for a sponsor for my package cpl. * Package name : cpl Version : 5.3.1-1 Upstream Author : ESO Project Team cpl-h...@eso.org * URL : http://www.eso.org/sci/software/cpl/ * License : GPLv2 Section : libs It builds those binary packages: libcext-dev - Header files for libcext libcext-doc - API documentation for libcext libcext0 - ESO's C Library Extensions libcpl-dev - Header files for the Common Pipeline Library libcpl-doc - API documentation for the Common Pipeline Library libcplcore12 - Fundamental CPL data types and functions libcpldfs12 - CPL functions to provide DFS compability libcpldrs12 - CPL higher level data processing algorithms libcplui12 - CPL framework interface library To access further information about this package, please visit the following URL: http://mentors.debian.net/package/cpl Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/c/cpl/cpl_5.3.1-1.dsc I would be glad if someone uploaded this package for me. Kind regards, Ole Streicher I forgot: you depend on autotools-dev but do not use it. With dh-7 its: dh $@ --with autotools-dev Please correct me if I'm mistaken...but isn't it supposed to be --with autotools_dev (i.e. with an underscore, not a dash)? Vincent -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/caczd_ta24eotwkq2xj_4bm0v3ypzywenrbxdajq6dzgufoh...@mail.gmail.com
Re: RFS: ESO Common Pipeline Library
Julian Taylor jtaylor.deb...@googlemail.com writes:
On 10/12/2011 06:57 PM, Ole Streicher wrote:
I am looking for a sponsor for my package cpl.
the package does not build in a clean unstable chroot:
configure:12738: error: cfitsio was not found on your system. Please check!
This is because cfitsio has been converted to multiarch placing it in
/usr/lib/$(dpkg-architecture -qDEB_HOST_MULTIARCH)
The build should fall back to the system default paths when the library
is not found in the paths defined in m4/cpl.m4.
OK. One question here: there are other, optional libraries that are
checked in the same way -- libwcs4 and libfftw3. The configure would not
fail if these are not there, but the resulting cpl libs are then
suboptimal.
A simple way would be to remove the checks for libcfitsio3, libwcs4 and
libfftw3 from cpl.m4 completely -- they are supposed to be there because
of the build dependencies of the package, and the filesystem standard
defines where they are. Would this be acceptable, or what would be the
best way to check the multiarch library path additionally? I could also
just add
--with-cfitsio-libs=/usr/lib/$(dpkg-architecture -qDEB_HOST_MULTIARCH) \
--with-wcs-libs=/usr/lib/$(dpkg-architecture -qDEB_HOST_MULTIARCH) \
--with-fftw-libs=/usr/lib/$(dpkg-architecture -qDEB_HOST_MULTIARCH)
as configure options?
There are a couple of files with copyright held by the FSF in the source
but thats not mentioned in debian/copyright
How exact should this be? Would be something like
--8
Files: *
Copyright: Copyright (C) 2001-2010 European Southern Observatory
License: GPL-2
This program is [...] version 2 can be found in the file
`/usr/share/common-licenses/GPL-2'.
Files: */Makefile.in libltdl/* admin/* libcext/m4/lt*.m4 aclocal.m4 configure
Copyright: Copyright (C) 1994-2009 Free Software Foundation, Inc.
License: Free
Files: libcext/cext/snprintf.c
Copyright: Patrick Powell 1995
License: Free
Files: debian/*
Copyright: 2011 Ole Streicher deb...@liska.ath.cx
License: GPL-2
--8
be sufficient?
You also don't need the GPL-2 license header twice, once is enough.
I would just keep the first line License: GPL-2, right?
you don't need .dirs files for standard system paths like usr/{lib,include}
VLT instrument ... abbreviation in the description needs explaining or
maybe dropping.
fi is typed weird in everal places
line 68 operations de~Aned on, 108, 112 ...
OK. Will be fixed.
Also as this package contains a number of libraries please consider
adding symbol files to aid finding api compatibility problems.
Since I just started with Debian packaging, I dont know how to do
this. I would suggest that I do that in a later release, once I learned
this.
Thank you for your review.
Best regards
Ole
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/87zkh5udet@liska.ath.cx
Re: RFS: ESO Common Pipeline Library
* Vincent Cheng vincentc1...@gmail.com, 2011-10-12, 13:19: I forgot: you depend on autotools-dev but do not use it. With dh-7 its: dh $@ --with autotools-dev Please correct me if I'm mistaken...but isn't it supposed to be --with autotools_dev (i.e. with an underscore, not a dash)? It can be either, dh does s/-/_/g before loading the module. Reference: http://anonscm.debian.org/gitweb/?p=debhelper/debhelper.git;a=blob;f=dh;h=3bcd069cadad6593e9d997942f277d5f20d3eb04;hb=b023550cd4256f0341c43860645b77c25f470509#l523 -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/2011101023.ga9...@jwilk.net
