Re: RFS: New version of cvs-autoreleasedeb

2004-02-20 Thread Joey Hess
Eike zyro Sauer wrote:
> Raphael Goulais schrieb:
> >  - Why do you remove /var/log/cvs-autoreleasedeb.log at postrm, since
> >the log files are in /var/log/cvs-autoreleasedeb/ ? Also, I don't
> >think you should remove the log files anyway, even on a purge.
> 
> Is this consensus?
> I thought I'd get rid of everything a package made when purging.

I'm not familiar with this package, but policy is quite clear:

 Log files should be removed when the package is purged (but not when
 it is only removed).  This should be done by the `postrm' script when
 it is called with the argument `purge' (see Section 6.7, `Details of
 removal and/or configuration purging').

-- 
see shy jo


signature.asc
Description: Digital signature


Re: RFS: New version of cvs-autoreleasedeb

2004-02-20 Thread Andreas Metzler
On 2004-02-20 Eike zyro Sauer <[EMAIL PROTECTED]> wrote:
> Raphael Goulais schrieb:
> >  - Why do you remove /var/log/cvs-autoreleasedeb.log at postrm, since
> >the log files are in /var/log/cvs-autoreleasedeb/ ? Also, I don't
> >think you should remove the log files anyway, even on a purge.

> Is this consensus?

No, it is not.

> I thought I'd get rid of everything a package made when purging.

I would not go that far (Reductio ad absurdum: Removing /var/mail/*
when uninstalling the MTA) but logfiles should indeed be deleted on
purge, see policy 10.8.
  cu andreas



Re: RFS: New version of cvs-autoreleasedeb

2004-02-20 Thread Eike \"zyro\" Sauer
Raphael Goulais schrieb:
>  - Why do you remove /var/log/cvs-autoreleasedeb.log at postrm, since
>the log files are in /var/log/cvs-autoreleasedeb/ ? Also, I don't
>think you should remove the log files anyway, even on a purge.

Is this consensus?
I thought I'd get rid of everything a package made when purging.

Ciao,
Eike




Re: RFS: New version of cvs-autoreleasedeb

2004-02-20 Thread Joey Hess
Eike zyro Sauer wrote:
> Raphael Goulais schrieb:
> >  - Why do you remove /var/log/cvs-autoreleasedeb.log at postrm, since
> >the log files are in /var/log/cvs-autoreleasedeb/ ? Also, I don't
> >think you should remove the log files anyway, even on a purge.
> 
> Is this consensus?
> I thought I'd get rid of everything a package made when purging.

I'm not familiar with this package, but policy is quite clear:

 Log files should be removed when the package is purged (but not when
 it is only removed).  This should be done by the `postrm' script when
 it is called with the argument `purge' (see Section 6.7, `Details of
 removal and/or configuration purging').

-- 
see shy jo


signature.asc
Description: Digital signature


Re: RFS: New version of cvs-autoreleasedeb

2004-02-20 Thread Andreas Metzler
On 2004-02-20 Eike zyro Sauer <[EMAIL PROTECTED]> wrote:
> Raphael Goulais schrieb:
> >  - Why do you remove /var/log/cvs-autoreleasedeb.log at postrm, since
> >the log files are in /var/log/cvs-autoreleasedeb/ ? Also, I don't
> >think you should remove the log files anyway, even on a purge.

> Is this consensus?

No, it is not.

> I thought I'd get rid of everything a package made when purging.

I would not go that far (Reductio ad absurdum: Removing /var/mail/*
when uninstalling the MTA) but logfiles should indeed be deleted on
purge, see policy 10.8.
  cu andreas


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



Re: RFS: New version of cvs-autoreleasedeb

2004-02-20 Thread Eike \"zyro\" Sauer
Raphael Goulais schrieb:
>  - Why do you remove /var/log/cvs-autoreleasedeb.log at postrm, since
>the log files are in /var/log/cvs-autoreleasedeb/ ? Also, I don't
>think you should remove the log files anyway, even on a purge.

Is this consensus?
I thought I'd get rid of everything a package made when purging.

Ciao,
Eike



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



Re: RFS: New version of cvs-autoreleasedeb

2004-02-20 Thread Daniel Ruoso
>  - Why do you remove /var/log/cvs-autoreleasedeb.log at postrm, since
>the log files are in /var/log/cvs-autoreleasedeb/ ? Also, I don't
>think you should remove the log files anyway, even on a purge.

The log used to be in /var/cvs-autoreleasedeb.log a long time ago, I
missed this. I agree that the log shouldn't be removed. Fixed.

>  - It sounds dangerous to purge the user and group on a failed or
>aborted upgrade.

Done.

>  - some dh_ scripts are called but not used (this is cosmetic)

I didn't review completely, but removed some I saw that I really didn't
use. I'll review better in the next releases.

>  - The dir contained in orig.tar.gz is postfixed with .orig. This is
>not the good way (see warning when building the package).

H... That's the way cvs-buildpackage does... I just use it. Maybe a
bug could be submitted against cvs-buildpackage.

The standards version was updated also.

The version 0.5-2 is available at:
https://sourceforge.net/project/showfiles.php?group_id=57915&package_id=53579&release_id=218421

daniel


signature.asc
Description: Esta é uma parte de mensagem	assinada digitalmente


Re: RFS: New version of cvs-autoreleasedeb

2004-02-20 Thread Daniel Ruoso
>  - Why do you remove /var/log/cvs-autoreleasedeb.log at postrm, since
>the log files are in /var/log/cvs-autoreleasedeb/ ? Also, I don't
>think you should remove the log files anyway, even on a purge.

The log used to be in /var/cvs-autoreleasedeb.log a long time ago, I
missed this. I agree that the log shouldn't be removed. Fixed.

>  - It sounds dangerous to purge the user and group on a failed or
>aborted upgrade.

Done.

>  - some dh_ scripts are called but not used (this is cosmetic)

I didn't review completely, but removed some I saw that I really didn't
use. I'll review better in the next releases.

>  - The dir contained in orig.tar.gz is postfixed with .orig. This is
>not the good way (see warning when building the package).

H... That's the way cvs-buildpackage does... I just use it. Maybe a
bug could be submitted against cvs-buildpackage.

The standards version was updated also.

The version 0.5-2 is available at:
https://sourceforge.net/project/showfiles.php?group_id=57915&package_id=53579&release_id=218421

daniel


signature.asc
Description: Esta =?ISO-8859-1?Q?=E9?= uma parte de mensagem	assinada digitalmente


Re: RFS: New version of cvs-autoreleasedeb

2004-02-20 Thread Raphael Goulais
On Fri, 2004-02-20 at 11:39, Raphael Goulais wrote:
> Some remarks first :

And updating the standard version :)

Raphael



Re: RFS: New version of cvs-autoreleasedeb

2004-02-20 Thread Raphael Goulais
On Fri, 2004-02-20 at 11:39, Raphael Goulais wrote:
> Some remarks first :

And updating the standard version :)

Raphael


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



Re: RFS: New version of cvs-autoreleasedeb

2004-02-20 Thread Raphael Goulais
On Thu, 2004-02-19 at 19:56, Daniel Ruoso wrote:
> I'm looking for a sponsor for the version 0.5-1 of cvs-autoreleasedeb
> that already is into the archive.

Some remarks first :

 - Why do you remove /var/log/cvs-autoreleasedeb.log at postrm, since
   the log files are in /var/log/cvs-autoreleasedeb/ ? Also, I don't
   think you should remove the log files anyway, even on a purge.
 - It sounds dangerous to purge the user and group on a failed or
   aborted upgrade.
 - some dh_ scripts are called but not used (this is cosmetic)
 - The dir contained in orig.tar.gz is postfixed with .orig. This is
   not the good way (see warning when building the package).

Cheers,

Raphael

PS: If you think I'm wrong on some point, just tell me why :)




Re: RFS: New version of cvs-autoreleasedeb

2004-02-20 Thread Raphael Goulais
On Thu, 2004-02-19 at 19:56, Daniel Ruoso wrote:
> I'm looking for a sponsor for the version 0.5-1 of cvs-autoreleasedeb
> that already is into the archive.

I'm can do it, if nobody replied to you before.

Raphael



Re: RFS: New version of cvs-autoreleasedeb

2004-02-20 Thread Raphael Goulais
On Thu, 2004-02-19 at 19:56, Daniel Ruoso wrote:
> I'm looking for a sponsor for the version 0.5-1 of cvs-autoreleasedeb
> that already is into the archive.

Some remarks first :

 - Why do you remove /var/log/cvs-autoreleasedeb.log at postrm, since
   the log files are in /var/log/cvs-autoreleasedeb/ ? Also, I don't
   think you should remove the log files anyway, even on a purge.
 - It sounds dangerous to purge the user and group on a failed or
   aborted upgrade.
 - some dh_ scripts are called but not used (this is cosmetic)
 - The dir contained in orig.tar.gz is postfixed with .orig. This is
   not the good way (see warning when building the package).

Cheers,

Raphael

PS: If you think I'm wrong on some point, just tell me why :)



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



Re: RFS: New version of cvs-autoreleasedeb

2004-02-20 Thread Raphael Goulais
On Thu, 2004-02-19 at 19:56, Daniel Ruoso wrote:
> I'm looking for a sponsor for the version 0.5-1 of cvs-autoreleasedeb
> that already is into the archive.

I'm can do it, if nobody replied to you before.

Raphael


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]