Re: RFS: admesh (updated package)

[Anton Gladky]

Thank you!

Hope next time I will do everything without mistakes.

Anton




On Sat, Jan 8, 2011 at 12:51 PM, Ansgar Burchardt  wrote:
> Hi,
>
> Anton Gladky  writes:
>> I have fixed that.
>
> I uploaded admesh to unstable.  Thanks for your work :)
>
> Regards,
> Ansgar
>
>
> --
> To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
> with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
> Archive: http://lists.debian.org/87zkrbehq2@marvin.43-1.org
>
>


--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/aanlktim5ysvpa4ngcv=krkrsi52277ccgziofjuz0...@mail.gmail.com

Re: RFS: admesh (updated package)

[Ansgar Burchardt]

Hi,

Anton Gladky  writes:
> I have fixed that.

I uploaded admesh to unstable.  Thanks for your work :)

Regards,
Ansgar


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/87zkrbehq2@marvin.43-1.org

Re: RFS: admesh (updated package)

[Anton Gladky]

I have fixed that.

http://mentors.debian.net/cgi-bin/sponsor-pkglist?action=details;package=admesh

Thanks for suggestion
Anton




On Fri, Jan 7, 2011 at 5:44 PM, Ansgar Burchardt  wrote:
> Hi,
>
> Anton Gladky  writes:
>> Thanks a lot for suggestions and reviewing.
>>
>> I have updated the package again, hopefully the last time for now ;)
>
> There were two occurrences of "[LICENSE TEXT]" in debian/copyright. You
> just replaced the first one (my fault, I said "a" :) ).
>
> It's in my opinion more readable to have the text about the license, so
> instead of writing the same text a second time, I would just create an
> extra paragraph for the license (as for example in [1]).
>
> Regards,
> Ansgar
>
> [1] 
> 
>
>
> --
> To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
> with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
> Archive: http://lists.debian.org/87fwt4mzos@marvin.43-1.org
>
>


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/aanlktimby9vgqyhqo95-dujdzggaxoumnmd3chtuo...@mail.gmail.com

Re: RFS: admesh (updated package)

[Ansgar Burchardt]

Hi,

Anton Gladky  writes:
> Thanks a lot for suggestions and reviewing.
>
> I have updated the package again, hopefully the last time for now ;)

There were two occurrences of "[LICENSE TEXT]" in debian/copyright. You
just replaced the first one (my fault, I said "a" :) ).

It's in my opinion more readable to have the text about the license, so
instead of writing the same text a second time, I would just create an
extra paragraph for the license (as for example in [1]).

Regards,
Ansgar

[1] 



-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/87fwt4mzos@marvin.43-1.org

Re: RFS: admesh (updated package)

[Anton Gladky]

Hi,
Thanks a lot for suggestions and reviewing.

I have updated the package again, hopefully the last time for now ;)

Anton




On Thu, Jan 6, 2011 at 5:41 PM, Ansgar Burchardt  wrote:
> Hi,
>
> Anton Gladky  writes:
>> I just want to ask, how do you get those warnings, for example:
>>>   lintian: debian-changelog-line-too-long
>> I use the same lintian 2.4.3 and do not get this message.
>
> How do you start lintian?  There are checks for both source (*.dsc) and
> binary (*.deb) packages and if you give only the source package as an
> argument, lintian will not check the binary package:
>
>  $ lintian admesh_0.95-8.dsc
>  [ no output ]
>  $ lintian admesh_0.95-8_amd64.deb
>  E: admesh: copyright-should-refer-to-common-license-file-for-gpl
>  W: admesh: debian-changelog-line-too-long line 2
>  W: admesh: debian-changelog-line-too-long line 5
>
> You can also run lintian on the *.changes file to check both source and
> binary packages at the same time:
>
>  $ lintian admesh_0.95-8_multi.changes
>  E: admesh: copyright-should-refer-to-common-license-file-for-gpl
>  W: admesh: debian-changelog-line-too-long line 2
>  W: admesh: debian-changelog-line-too-long line 5
>
> Some less important tags are only shown when you use the
> -I/--display-info option.  You can get an explanation for the tags with
> either passing -i/--info to lintian or `lintian-info --tags [tag]':
>
>  $ lintian -iI admesh_0.95-8_multi.changes
>  I: admesh source: debian-watch-file-is-missing
>  N:
>  N:    This source package is not Debian-native but it does not have a
>  N:    debian/watch file. This file is used for automatic detection of new
>  [ ... ]
>
> Regards,
> Ansgar
>
>
> --
> To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
> with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
> Archive: http://lists.debian.org/87pqsax9v9@marvin.43-1.org
>
>


--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/aanlktimbj3_xqswm4a_it3fi9vd=ljnxkg7dtcglg...@mail.gmail.com

Re: RFS: admesh (updated package)

[Ansgar Burchardt]

Hi,

Anton Gladky  writes:
> I just want to ask, how do you get those warnings, for example:
>>   lintian: debian-changelog-line-too-long
> I use the same lintian 2.4.3 and do not get this message.

How do you start lintian?  There are checks for both source (*.dsc) and
binary (*.deb) packages and if you give only the source package as an
argument, lintian will not check the binary package:

  $ lintian admesh_0.95-8.dsc
  [ no output ]
  $ lintian admesh_0.95-8_amd64.deb
  E: admesh: copyright-should-refer-to-common-license-file-for-gpl
  W: admesh: debian-changelog-line-too-long line 2
  W: admesh: debian-changelog-line-too-long line 5

You can also run lintian on the *.changes file to check both source and
binary packages at the same time:

  $ lintian admesh_0.95-8_multi.changes
  E: admesh: copyright-should-refer-to-common-license-file-for-gpl
  W: admesh: debian-changelog-line-too-long line 2
  W: admesh: debian-changelog-line-too-long line 5

Some less important tags are only shown when you use the
-I/--display-info option.  You can get an explanation for the tags with
either passing -i/--info to lintian or `lintian-info --tags [tag]':

  $ lintian -iI admesh_0.95-8_multi.changes
  I: admesh source: debian-watch-file-is-missing
  N: 
  N:This source package is not Debian-native but it does not have a
  N:debian/watch file. This file is used for automatic detection of new
  [ ... ]
  
Regards,
Ansgar


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/87pqsax9v9@marvin.43-1.org

Re: RFS: admesh (updated package)

[Anton Gladky]

Hi,

thanks, Ansgar, for your comments. I will fix that.

I just want to ask, how do you get those warnings, for example:
>   lintian: debian-changelog-line-too-long
I use the same lintian 2.4.3 and do not get this message.


Anton




On Thu, Jan 6, 2011 at 3:57 PM, Ansgar Burchardt  wrote:
> Hi,
>
> Anton Gladky  writes:
>> I have fixed the package according to your suggestions and would be
>> glad if you have a look at them.
>
> The package builds fine and DEB_BUILD_OPTIONS=nostrip works as well.
> Some issues remain (some of them are new, but all easy to change):
>
>  · Please wrap long lines in debian/changelog.
>   lintian: debian-changelog-line-too-long
>  · There is one more mentioning of /usr/doc/ in the man page:
>   It refers to /usr/doc/copyright/GPL, but should refer to
>   /usr/share/common-licenses/GPL-2 (and the text above as well).
>   I did miss this before.
>   lintian: FSSTND-dir-in-manual-page
>  · debian/copyright has a "[LICENSE TEXT]" template where the license
>   should be included (or in this case referred to the file above).
>   Also please use "GPL-2+" (for GPL 2 or later).
>   See for example the copyright information for a Perl module:
>   
> 
>   lintian: copyright-should-refer-to-common-license-file-for-gpl
>  · Please call dh_md5sums just before dh_builddeb to include checksums
>   of the package contents.
>   lintian: no-md5sums-control-file
>  · (very minor) debian/control: The Depends: line has two spaces.  One
>   should be enough.
>   lintian: debian-control-has-unusual-field-spacing (--pedantic)
>
> There is one more lintian warning about debian/watch. The following
> seems to find at least the current version:
>
>  version=3
>  http://www.varlog.com/index.html .*admesh-(.+)\.tar\.gz
>
> See uscan(1) for more information about debian/watch.
>
> Please run lintian on your package. It will detect many common packaging
> problems. I usually use `lintian -iI *.changes': it will display an
> explanation for all issues and look for some more, less important
> mistakes. (The last lintian warning I mention is only shown when using
> the `--pedantic' option, but those might not always be of interest.)
> Note that you should always use the latest version (2.4.3 right now).
>
> Thanks for your work :-)
>
> Regards,
> Ansgar
>
>
> --
> To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
> with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
> Archive: http://lists.debian.org/87tyhmxep8@marvin.43-1.org
>
>


--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/aanlktimaxzjjxj8bgqxtzz=n3meuh1_knicmkr9w=...@mail.gmail.com

Re: RFS: admesh (updated package)

[Ansgar Burchardt]

Hi,

Anton Gladky  writes:
> I have fixed the package according to your suggestions and would be
> glad if you have a look at them.

The package builds fine and DEB_BUILD_OPTIONS=nostrip works as well.
Some issues remain (some of them are new, but all easy to change):

 · Please wrap long lines in debian/changelog.
   lintian: debian-changelog-line-too-long
 · There is one more mentioning of /usr/doc/ in the man page:
   It refers to /usr/doc/copyright/GPL, but should refer to
   /usr/share/common-licenses/GPL-2 (and the text above as well).
   I did miss this before.
   lintian: FSSTND-dir-in-manual-page
 · debian/copyright has a "[LICENSE TEXT]" template where the license
   should be included (or in this case referred to the file above).
   Also please use "GPL-2+" (for GPL 2 or later).
   See for example the copyright information for a Perl module:
   

   lintian: copyright-should-refer-to-common-license-file-for-gpl
 · Please call dh_md5sums just before dh_builddeb to include checksums
   of the package contents.
   lintian: no-md5sums-control-file
 · (very minor) debian/control: The Depends: line has two spaces.  One
   should be enough.
   lintian: debian-control-has-unusual-field-spacing (--pedantic)

There is one more lintian warning about debian/watch. The following
seems to find at least the current version:

  version=3
  http://www.varlog.com/index.html .*admesh-(.+)\.tar\.gz

See uscan(1) for more information about debian/watch.

Please run lintian on your package. It will detect many common packaging
problems. I usually use `lintian -iI *.changes': it will display an
explanation for all issues and look for some more, less important
mistakes. (The last lintian warning I mention is only shown when using
the `--pedantic' option, but those might not always be of interest.)
Note that you should always use the latest version (2.4.3 right now).

Thanks for your work :-)

Regards,
Ansgar


--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/87tyhmxep8@marvin.43-1.org

Re: RFS: admesh (updated package)

[Anton Gladky]

Thanks, Ansgar, for the package review.

I have fixed the package according to your suggestions and would be
glad if you have a look at them.

Thanks
Anton




On Wed, Jan 5, 2011 at 1:31 PM, Ansgar Burchardt  wrote:
> Hi,
>
> Anton Gladky  writes:
>> I am looking for a sponsor for the new version 0.95-8
>> of my package "admesh".
>
> Please write informative changelog entries when closing bugs. Just
> "Closes: #nn" does not say much.  You might want to add a small
> informative header to the patch as well (maybe using the proposed DEP-3
> format).
>
> What does "debian/directory is deleted from orig.tar.gz" mean? You
> cannot change the .orig.tar.gz without changing the upstream version.
>
> The license used upstream seems to be "GPL-2 or later". Please mention
> this in debian/copyright.  For some files (getopt*) the FSF has the
> copyright.  (There is also the proposed DEP-5 format for d/copyright, of
> course you are also free not to use it.)
>
> Most people prefer to license the Debian packaging under the same terms
> as the upstream source, so that for example patches can be reused by
> upstream as well.
>
> The "Sample debian/rules" header is not true: It's not a sample. There
> are two hashbang lines ("#!/usr/bin/make"). Passing "-a" to the dh_*
> tools should not be necessary. The newlines near the end should be
> removed.
>
> Is the build-dependency on autotools-dev used anywhere?
>
> Regards,
> Ansgar
>
>
> --
> To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
> with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
> Archive: http://lists.debian.org/87y66zedm4@marvin.43-1.org
>
>


--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/aanlktikzndrxnpzmkhpxsbuqh_4tp=hfs-xxbjfj6...@mail.gmail.com

Re: RFS: admesh (updated package)

[Ansgar Burchardt]

Hi,

Anton Gladky  writes:
> I am looking for a sponsor for the new version 0.95-8
> of my package "admesh".

Please write informative changelog entries when closing bugs. Just
"Closes: #nn" does not say much.  You might want to add a small
informative header to the patch as well (maybe using the proposed DEP-3
format).

What does "debian/directory is deleted from orig.tar.gz" mean? You
cannot change the .orig.tar.gz without changing the upstream version.

The license used upstream seems to be "GPL-2 or later". Please mention
this in debian/copyright.  For some files (getopt*) the FSF has the
copyright.  (There is also the proposed DEP-5 format for d/copyright, of
course you are also free not to use it.)

Most people prefer to license the Debian packaging under the same terms
as the upstream source, so that for example patches can be reused by
upstream as well.

The "Sample debian/rules" header is not true: It's not a sample. There
are two hashbang lines ("#!/usr/bin/make"). Passing "-a" to the dh_*
tools should not be necessary. The newlines near the end should be
removed.

Is the build-dependency on autotools-dev used anywhere?

Regards,
Ansgar


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/87y66zedm4@marvin.43-1.org