Re: RFS: b43-fwcutter (updated package)
Hey Patrick! On Fri, 2011-05-06 at 17:12 +0200, Patrick Matthäi wrote: > > I will care about the package. The next time you may direct mail me ;-) > Great! Thank you as usual :-) Cheers, Fabrizio. signature.asc Description: This is a digitally signed message part
Re: RFS: b43-fwcutter (updated package)
Am 06.05.2011 17:05, schrieb Fabrizio Regalli: Dear mentors, I am looking for a sponsor for the new version 1:014-3 of my package "b43-fwcutter". It builds these binary packages: b43-fwcutter - Utility for extracting Broadcom 43xx firmware firmware-b43-installer - Installer package for firmware for the b43 driver firmware-b43-lpphy-installer - Installer package for firmware for the b43 driver (LP-PHY version firmware-b43legacy-installer - Installer package for firmware for the b43legacy driver The package appears to be lintian clean. The upload would fix these bugs: 625876 The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/contrib/b/b43-fwcutter - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/contrib/b/b43-fwcutter/b43-fwcutter_014-3.dsc I would be glad if someone uploaded this package for me. I will care about the package. The next time you may direct mail me ;-) -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4dc40fe4.8060...@debian.org
Re: RFS: b43-fwcutter (updated package)
Hi! > You can check the debian/copyright for DEP5 errors by using the config-edit > script from the libconfig-model-perl package as follows: > > $ config-edit -application dpkg-copyright -ui none > > You have to run it from the parent folder of the debian/ directory of your > package (it reads the file 'debian/copyright' by default). > > Cheers > > The copyright file located in Mentors is Ok. Unless, If I build the package, there are files *.log that dh_clean can't erase. Cheers -- Epsilon http://www.rinconinformatico.net http://www.fitnessdeportes.com http://www.dragonjar.org Linux user: #477840 Debian user
Re: RFS: b43-fwcutter (updated package)
On Tue, 2011-03-15 at 19:19 +0100, Alessandro Ghedini wrote:
> On Tue, Mar 15, 2011 at 02:32:47PM +0100, Fabrizio Regalli wrote:
> > > I'm not an DD so I can't sponsor this, but I have a comment
> > >
> > > The copyright file has some errores, please check [1]
> > >
> > >
> > > [1]: http://dep.debian.net/deps/dep5/
> >
> > Daniel, could you please check it now?
> > Thanks.
>
> You can check the debian/copyright for DEP5 errors by using the config-edit
> script from the libconfig-model-perl package as follows:
>
>$ config-edit -application dpkg-copyright -ui none
Thanks. It seems ok.
Ciao.
Fabrizio.
>
> You have to run it from the parent folder of the debian/ directory of your
> package (it reads the file 'debian/copyright' by default).
>
> Cheers
>
> --
> perl -E'$_=q;$/= @{[@_]};and s;\S+;;eg;say~~reverse'
>
>
signature.asc
Description: This is a digitally signed message part
Re: RFS: b43-fwcutter (updated package)
On Tue, Mar 15, 2011 at 02:32:47PM +0100, Fabrizio Regalli wrote:
> > I'm not an DD so I can't sponsor this, but I have a comment
> >
> > The copyright file has some errores, please check [1]
> >
> >
> > [1]: http://dep.debian.net/deps/dep5/
>
> Daniel, could you please check it now?
> Thanks.
You can check the debian/copyright for DEP5 errors by using the config-edit
script from the libconfig-model-perl package as follows:
$ config-edit -application dpkg-copyright -ui none
You have to run it from the parent folder of the debian/ directory of your
package (it reads the file 'debian/copyright' by default).
Cheers
--
perl -E'$_=q;$/= @{[@_]};and s;\S+;;eg;say~~reverse'
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20110315181908.gb5...@pc-ale.rete
Re: RFS: b43-fwcutter (updated package)
Hello, On Wed, 2011-03-09 at 19:50 -0500, Daniel Echeverry wrote: > Hi, > > > > > > For bonus points you could also convert the debian/copyright > file to use > > the DEP5 format [1]. > > > Ok, changed. > > > I'm not an DD so I can't sponsor this, but I have a comment > > The copyright file has some errores, please check [1] > > > [1]: http://dep.debian.net/deps/dep5/ > > Daniel, could you please check it now? Thanks. > -- > Epsilon > http://www.rinconinformatico.net > http://www.fitnessdeportes.com > http://www.dragonjar.org > Linux user: #477840 > Debian user > > signature.asc Description: This is a digitally signed message part
Re: RFS: b43-fwcutter (updated package)
Hi, > > > For bonus points you could also convert the debian/copyright file to use > > the DEP5 format [1]. > > Ok, changed. > I'm not an DD so I can't sponsor this, but I have a comment The copyright file has some errores, please check [1] [1]: http://dep.debian.net/deps/dep5/ -- Epsilon http://www.rinconinformatico.net http://www.fitnessdeportes.com http://www.dragonjar.org Linux user: #477840 Debian user
Re: RFS: b43-fwcutter (updated package)
On Wed, Mar 09, 2011 at 12:30:50PM +0100, David Paleino wrote:
> > On Tue, Mar 08, 2011 at 10:34:00PM +0100, Fabrizio Regalli wrote:
> > > http://mentors.debian.net/debian/pool/contrib/b/b43-fwcutter/b43-fwcutter_013-4.dsc
> >
> > The package FTBFS:
> >
> >make[1]: Entering directory `/tmp/b43-fwcutter-013'
> >install -d -o 0 -g 0 -m 755 /usr/local/bin/
> >install -o 0 -g 0 -m 755 b43-fwcutter /usr/local/bin/
> >install: cannot create regular file "/usr/local/bin/b43-fwcutter":
> > Permission denied make[1]: *** [install] Error 1
> >
> > Why is it installing under /usr/local, anyway? In the upstream Makefile you
> > should replace
> >
> >PREFIX ?= /usr/local
> >
> > with
> >
> >PREFIX ?= $(DESTDIR)/usr
> >
> > That fixes both the issues. See maint-guide §3.3 [0].
>
> How are you compiling that package? It doesn't FTBFS here.
Using debuild(1), but I just re-tried, and it doesn't do it anymore.
I'm not sure what I did wrong though... well, sorry for the noise :)
Cheers
--
perl -E'$_=q;$/= @{[@_]};and s;\S+;;eg;say~~reverse'
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20110309184416.ga2...@pc-ale.rete
Re: RFS: b43-fwcutter (updated package)
Hi, On Wed, 2011-03-09 at 12:25 +0100, Alessandro Ghedini wrote: > On Tue, Mar 08, 2011 at 10:34:00PM +0100, Fabrizio Regalli wrote: ... > > The debian/ directory looks dirty. All the *.debhelper.log and *.substvars > shouldn't be there. > You are right. I've updated a new version on mentors. > You probably are using the lintian override wrongly: > >I: b43-fwcutter source: unused-override no-upstream-changelog > The previous version of packages, already in debian official repository, didn't have an override for that. > And finally the watch file looks weird (at least to uscan(1)): > > Newest version on remote site is 009, local version is 013 > b43-fwcutter: remote site does not even have current version I've changed the site because the previous contains old site, with old software version. > > For bonus points you could also convert the debian/copyright file to use > the DEP5 format [1]. Ok, changed. > > Please note that I'm not a DD, therefore I can't sponsor your package. > > Cheers Cheers, Fabrizio. signature.asc Description: This is a digitally signed message part
Re: RFS: b43-fwcutter (updated package)
Hi Alexander, On Wed, 2011-03-09 at 11:24 +0100, Alexander Reichle-Schmehl wrote: > Hi! > > * Fabrizio Regalli [110308 22:34]: > > > I am looking for a sponsor for the new version 1:013-4 > > of my package "b43-fwcutter". > > I just looked briefly through your package. And noticed, that while > your debian/changelog just reads: > > * New maintainer. Closes: #581798. > * Now it's recognized similar devices. (Closes: #599741) > * Remove BCM4312 from long description. (Closes: #617394) > + Thanks to Geoff Simmons for these patches! > > debdiff seems to disagree: > > $ debdiff b43-fwcutter_013-3.dsc b43-fwcutter_013-4.dsc|diffstat > NEWS |4 - > b43-fwcutter.debhelper.log | 77 > + > b43-fwcutter.dirs |1 > changelog |9 +++ > compat |2 > control| 13 +++- > dirs |1 > docs |1 > firmware-b43-installer.debhelper.log | 77 > + > firmware-b43-installer.postinst| 59 +- > firmware-b43-lpphy-installer.debhelper.log | 77 > + > firmware-b43-lpphy-installer.postinst | 26 ++--- > firmware-b43legacy-installer.debhelper.log | 77 > + > firmware-b43legacy-installer.postinst | 24 ++--- > patches/debian-changes-1:013-4 | 42 +++ > patches/series |1 > rules |4 - > source/lintian-overrides |1 > watch |2 > 19 files changed, 448 insertions(+), 50 deletions(-) > > > You'd probably want to clean that package up first. I'm really very sorry for that. I've update a new version on mentors. It seems more reasonable. NEWS |4 +- b43-fwcutter.dirs |1 changelog | 18 ++ compat|2 - control | 13 --- copyright | 22 +--- dirs |1 docs |1 firmware-b43-installer.postinst | 59 ++ firmware-b43-lpphy-installer.postinst | 26 ++ firmware-b43legacy-installer.postinst | 24 + patches/debian-changes-1:013-4| 51 ++ patches/series|1 rules |2 - watch |2 + 15 files changed, 166 insertions(+), 61 deletions(-) changelog contains all modifications. Thanks Alexander for your review. Regards, Fabrizio signature.asc Description: This is a digitally signed message part
DESTDIR-awareness [Was: Re: RFS: b43-fwcutter (updated package)]
On Wed, Mar 09, 2011 at 12:25:24PM +0100, Alessandro Ghedini wrote:
> On Tue, Mar 08, 2011 at 10:34:00PM +0100, Fabrizio Regalli wrote:
> > Dear mentors,
> >
> > I am looking for a sponsor for the new version 1:013-4
> > of my package "b43-fwcutter".
> >
> > It builds these binary packages:
> > b43-fwcutter - Utility for extracting Broadcom 43xx firmware
> > firmware-b43-installer - Installer package for firmware for the b43
> > driver
> > firmware-b43-lpphy-installer - Installer package for firmware for the
> > b43 driver (LP-PHY version
> > firmware-b43legacy-installer - Installer package for firmware for the
> > b43legacy driver
> >
> > The package appears to be lintian clean.
> >
> > The upload would fix these bugs: 581798, 599741
> >
> > The package can be found on mentors.debian.net:
> > - URL: http://mentors.debian.net/debian/pool/contrib/b/b43-fwcutter
> > - Source repository: deb-src http://mentors.debian.net/debian unstable
> > main contrib non-free
> > - dget
> > http://mentors.debian.net/debian/pool/contrib/b/b43-fwcutter/b43-fwcutter_013-4.dsc
>
> The package FTBFS:
>
>make[1]: Entering directory `/tmp/b43-fwcutter-013'
>install -d -o 0 -g 0 -m 755 /usr/local/bin/
>install -o 0 -g 0 -m 755 b43-fwcutter /usr/local/bin/
>install: cannot create regular file "/usr/local/bin/b43-fwcutter":
> Permission denied
>make[1]: *** [install] Error 1
>
> Why is it installing under /usr/local, anyway? In the upstream Makefile you
> should replace
>
>PREFIX ?= /usr/local
>
> with
>
>PREFIX ?= $(DESTDIR)/usr
>
> That fixes both the issues. See maint-guide §3.3 [0].
Just a note: adding DESTDIR to PREFIX, BINDIR, MANDIR, etc in the
upstream Makefile is not always the best solution. Sometimes part of
the install (or even the build) process consists of updating some
configuration files, documentation, etc. with the actual locations of
some files and directories on the target system; if one appends DESTDIR
to those directories, the results might be... funny :)
A much better approach is to make the installation process
"DESTDIR-aware" - look through all the install* targets in the Makefile
and add a ${DESTDIR} at any places that do not have it. For example, if
the upstream Makefile has something like this:
install-program:
install (some options) fooclient ${PREFIX}/bin
install (some options) fooserver ${PREFIX}/sbin
...that should be changed to:
install-program:
install (some options) fooclient ${DESTDIR}${PREFIX}/bin
install (some options) fooserver ${DESTDIR}${PREFIX}/sbin
This achieves both goals - the files end up in the DESTDIR tree and
PREFIX, BINDIR, etc keep their "real" values that correspond to the
paths where the files will be at runtime.
Of course, the change should then be forwarded upstream :)
G'luck,
Peter
--
Peter Pentchev r...@ringlet.net r...@freebsd.org pe...@packetscale.com
PGP key:http://people.FreeBSD.org/~roam/roam.key.asc
Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553
I am the meaning of this sentence.
signature.asc
Description: Digital signature
Re: RFS: b43-fwcutter (updated package)
On Wed, 9 Mar 2011 12:25:24 +0100, Alessandro Ghedini wrote: > On Tue, Mar 08, 2011 at 10:34:00PM +0100, Fabrizio Regalli wrote: > > http://mentors.debian.net/debian/pool/contrib/b/b43-fwcutter/b43-fwcutter_013-4.dsc > > The package FTBFS: > >make[1]: Entering directory `/tmp/b43-fwcutter-013' >install -d -o 0 -g 0 -m 755 /usr/local/bin/ >install -o 0 -g 0 -m 755 b43-fwcutter /usr/local/bin/ >install: cannot create regular file "/usr/local/bin/b43-fwcutter": > Permission denied make[1]: *** [install] Error 1 > > Why is it installing under /usr/local, anyway? In the upstream Makefile you > should replace > >PREFIX ?= /usr/local > > with > >PREFIX ?= $(DESTDIR)/usr > > That fixes both the issues. See maint-guide §3.3 [0]. How are you compiling that package? It doesn't FTBFS here. David -- . ''`. Debian developer | http://wiki.debian.org/DavidPaleino : :' : Linuxer #334216 --|-- http://www.hanskalabs.net/ `. `'` GPG: 1392B174 | http://deb.li/dapal `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 signature.asc Description: PGP signature
Re: RFS: b43-fwcutter (updated package)
On Tue, Mar 08, 2011 at 10:34:00PM +0100, Fabrizio Regalli wrote:
> Dear mentors,
>
> I am looking for a sponsor for the new version 1:013-4
> of my package "b43-fwcutter".
>
> It builds these binary packages:
> b43-fwcutter - Utility for extracting Broadcom 43xx firmware
> firmware-b43-installer - Installer package for firmware for the b43
> driver
> firmware-b43-lpphy-installer - Installer package for firmware for the
> b43 driver (LP-PHY version
> firmware-b43legacy-installer - Installer package for firmware for the
> b43legacy driver
>
> The package appears to be lintian clean.
>
> The upload would fix these bugs: 581798, 599741
>
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/contrib/b/b43-fwcutter
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> main contrib non-free
> - dget
> http://mentors.debian.net/debian/pool/contrib/b/b43-fwcutter/b43-fwcutter_013-4.dsc
The package FTBFS:
make[1]: Entering directory `/tmp/b43-fwcutter-013'
install -d -o 0 -g 0 -m 755 /usr/local/bin/
install -o 0 -g 0 -m 755 b43-fwcutter /usr/local/bin/
install: cannot create regular file "/usr/local/bin/b43-fwcutter":
Permission denied
make[1]: *** [install] Error 1
Why is it installing under /usr/local, anyway? In the upstream Makefile you
should replace
PREFIX ?= /usr/local
with
PREFIX ?= $(DESTDIR)/usr
That fixes both the issues. See maint-guide §3.3 [0].
Also, since what some of the built packages do is downloading the
firmwares from an external sites you may also point it out in the
packages' descriptions (just like flashplugin-nonfree does).
The debian/ directory looks dirty. All the *.debhelper.log and *.substvars
shouldn't be there.
You probably are using the lintian override wrongly:
I: b43-fwcutter source: unused-override no-upstream-changelog
And finally the watch file looks weird (at least to uscan(1)):
Newest version on remote site is 009, local version is 013
b43-fwcutter: remote site does not even have current version
For bonus points you could also convert the debian/copyright file to use
the DEP5 format [1].
Please note that I'm not a DD, therefore I can't sponsor your package.
Cheers
[0] http://www.debian.org/doc/maint-guide/ch-modify.en.html#s-destdir
[1] http://dep.debian.net/deps/dep5/
--
perl -E'$_=q;$/= @{[@_]};and s;\S+;;eg;say~~reverse'
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20110309112524.ga5...@pc-ale.rete
Re: RFS: b43-fwcutter (updated package)
Hi! * Fabrizio Regalli [110308 22:34]: > I am looking for a sponsor for the new version 1:013-4 > of my package "b43-fwcutter". I just looked briefly through your package. And noticed, that while your debian/changelog just reads: * New maintainer. Closes: #581798. * Now it's recognized similar devices. (Closes: #599741) * Remove BCM4312 from long description. (Closes: #617394) + Thanks to Geoff Simmons for these patches! debdiff seems to disagree: $ debdiff b43-fwcutter_013-3.dsc b43-fwcutter_013-4.dsc|diffstat NEWS |4 - b43-fwcutter.debhelper.log | 77 + b43-fwcutter.dirs |1 changelog |9 +++ compat |2 control| 13 +++- dirs |1 docs |1 firmware-b43-installer.debhelper.log | 77 + firmware-b43-installer.postinst| 59 +- firmware-b43-lpphy-installer.debhelper.log | 77 + firmware-b43-lpphy-installer.postinst | 26 ++--- firmware-b43legacy-installer.debhelper.log | 77 + firmware-b43legacy-installer.postinst | 24 ++--- patches/debian-changes-1:013-4 | 42 +++ patches/series |1 rules |4 - source/lintian-overrides |1 watch |2 19 files changed, 448 insertions(+), 50 deletions(-) You'd probably want to clean that package up first. Best Regards, Alexander -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110309102449.gc28...@melusine.alphascorpii.net
