Re: RFS: gecrit (2nd try)

2011-07-21 Thread Thomas Preud'homme
Le jeudi 21 juillet 2011 01:29:09, Vincent Cheng a écrit :
 (I sent out a RFS for gecrit a week ago and have yet to receive a
 single reply, so I'm giving this a second try.)
Sorry, forgot to reply.
 
 Dear mentors,
Hi Vincent,
 
 I am looking for a sponsor for my package gecrit.
[SNIP]
 
 * Package name: gecrit
  Version : 2.7-1
  Upstream Author : Groza Cristian kristi9...@gmail.com
 * URL : http://sourceforge.net/projects/gecrit/
 * License : GPL-3+
  Section : editors
 
 It builds these binary packages:
 gecrit - simple, easy-to-use Python IDE
 
 The package appears to be lintian clean.
 
 The upload would fix these bugs: 633420
 
 My motivation for maintaining this package is: gEcrit is a relatively
 new and promising Python editor/IDE that I hope will be of use to
 other Debian users.
 
 The package can be found on mentors.debian.net:
 - URL: http://mentors.debian.net/debian/pool/main/g/gecrit
 - Source repository: deb-src http://mentors.debian.net/debian unstable
 main contrib non-free
 - dget http://mentors.debian.net/debian/pool/main/g/gecrit/gecrit_2.7-1.dsc
 
 I would be glad if someone uploaded this package for me.
Below are my remarks but note that I'm just DM and hence can't sponsor your 
package.

Things to improve:
* Your orig.tar.gz has a different md5 than the upstream tarball.
* Vcs-Svn should use anonscm link
* Dependency on ${python:Depends} is for python modules, not python programs 
and hence is useless
* Same thing for X-Python-Version, it's for python modules

Neutral comments:
dpkg-gencontrol generate a warning about shlibs:Depends [0] but I'm not sure 
it's a good idea to remove the ${shlibs:Depends}. A future version of the 
package could needs shared library so you can ignore this warning.

[0] dpkg-gencontrol: warning: Depends field of package gecrit: unknown 
substitution variable ${shlibs:Depends}

On the good sides:
* No lintian warning, even with -I --pedantic. Congratulations.
* Happy to see a DEP5 copyright (not required by policy), especially since 
config-edit -application dpkg-copyright -ui none seems happy with it
* Package don't FTBFS.

Best regards,

Thomas Preud'homme
 
 Kind regards
  Vincent Cheng


signature.asc
Description: This is a digitally signed message part.


Re: RFS: gecrit (2nd try)

2011-07-21 Thread Jakub Wilk

* Thomas Preud'homme robo...@celest.fr, 2011-07-21, 17:38:
* Dependency on ${python:Depends} is for python modules, not python 
programs and hence is useless


Err, no, it's not only for Python modules.


* Same thing for X-Python-Version, it's for python modules


Ditto.

--
Jakub Wilk


--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20110721154517.ga5...@jwilk.net



Re: RFS: gecrit (2nd try)

2011-07-21 Thread Jakub Wilk

* Jakub Wilk jw...@debian.org, 2011-07-21, 17:45:
* Dependency on ${python:Depends} is for python modules, not python 
programs and hence is useless


Err, no, it's not only for Python modules.


* Same thing for X-Python-Version, it's for python modules


Ditto.


And in this particular case, the package does ship public public 
modules[0], so omitting ${python:Depends} would render the package 
RC-buggy.



[0] It's likely not the optimal way to package a Python application, but 
oh well…


--
Jakub Wilk


--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20110721155337.ga8...@jwilk.net



Re: RFS: gecrit (2nd try)

2011-07-21 Thread Vincent Cheng
On Thu, Jul 21, 2011 at 8:38 AM, Thomas Preud'homme robo...@celest.fr wrote:
 Le jeudi 21 juillet 2011 01:29:09, Vincent Cheng a écrit :
 (I sent out a RFS for gecrit a week ago and have yet to receive a
 single reply, so I'm giving this a second try.)
 Sorry, forgot to reply.

 Dear mentors,
 Hi Vincent,

 I am looking for a sponsor for my package gecrit.
 [SNIP]

 * Package name    : gecrit
  Version         : 2.7-1
  Upstream Author : Groza Cristian kristi9...@gmail.com
 * URL             : http://sourceforge.net/projects/gecrit/
 * License         : GPL-3+
  Section         : editors

 It builds these binary packages:
 gecrit     - simple, easy-to-use Python IDE

 The package appears to be lintian clean.

 The upload would fix these bugs: 633420

 My motivation for maintaining this package is: gEcrit is a relatively
 new and promising Python editor/IDE that I hope will be of use to
 other Debian users.

 The package can be found on mentors.debian.net:
 - URL: http://mentors.debian.net/debian/pool/main/g/gecrit
 - Source repository: deb-src http://mentors.debian.net/debian unstable
 main contrib non-free
 - dget http://mentors.debian.net/debian/pool/main/g/gecrit/gecrit_2.7-1.dsc

 I would be glad if someone uploaded this package for me.
 Below are my remarks but note that I'm just DM and hence can't sponsor your
 package.

Regardless, thanks for taking the time to review my packaging!

 Things to improve:
 * Your orig.tar.gz has a different md5 than the upstream tarball.

It looks like upstream released a newer source tarball under the same
name; I've re-uploaded my packaging to mentors.d.n with this new
tarball.

 * Vcs-Svn should use anonscm link

Fixed.

 * Dependency on ${python:Depends} is for python modules, not python programs
 and hence is useless
 * Same thing for X-Python-Version, it's for python modules

 Neutral comments:
 dpkg-gencontrol generate a warning about shlibs:Depends [0] but I'm not sure
 it's a good idea to remove the ${shlibs:Depends}. A future version of the
 package could needs shared library so you can ignore this warning.

 [0] dpkg-gencontrol: warning: Depends field of package gecrit: unknown
 substitution variable ${shlibs:Depends}

I suppose I'll keep ${shlibs:Depends}, then.

 On the good sides:
 * No lintian warning, even with -I --pedantic. Congratulations.
 * Happy to see a DEP5 copyright (not required by policy), especially since
 config-edit -application dpkg-copyright -ui none seems happy with it
 * Package don't FTBFS.

 Best regards,

 Thomas Preud'homme

 Kind regards
  Vincent Cheng


- Vincent


--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/CACZd_tDsoeUPFhuiukwbUjQA=pn0b5e1z4swzxzehn7scwa...@mail.gmail.com



Re: RFS: gecrit (2nd try)

2011-07-21 Thread Vincent Cheng
On Thu, Jul 21, 2011 at 8:53 AM, Jakub Wilk jw...@debian.org wrote:
 [0] It's likely not the optimal way to package a Python application, but oh
 well…

Please expand on this a bit...is this an issue with my debian
packaging, or an issue with upstream's build system? If it's the
former, I'll gladly fix it; I'm also in contact with upstream, so if
it's the latter, I can get that fixed as well. Thanks!

- Vincent


--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/caczd_tdzfgmep5jbdv8fcfbcc3nbxlrnxrhvpsbgyy3q2qq...@mail.gmail.com



Re: RFS: gecrit (2nd try)

2011-07-21 Thread Jakub Wilk

* Vincent Cheng vincentc1...@gmail.com, 2011-07-21, 13:53:
[0] It's likely not the optimal way to package a Python application, 
but oh well…


Please expand on this a bit...is this an issue with my debian 
packaging, or an issue with upstream's build system? If it's the 
former, I'll gladly fix it; I'm also in contact with upstream, so if 
it's the latter, I can get that fixed as well. Thanks!


I don't have strong opinion on how a Python application should be 
packaged from upstream POV. (However, please note that due to hardcoded 
paths in the gecrit script, it won't work on non-Debian systems...)


As for Debian packaging, you should move the Python modules into a 
private directory, e.g. /usr/share/gecrit/.


--
Jakub Wilk


--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20110721214640.ga4...@jwilk.net