Re: RFS: iguanair (try #2)
On Monday 08 June 2009, Jack Kelly wrote: 2009/6/8 Stefanos Harhalakis v...@v13.gr: The package appears to be lintian clean except from an the override of: iguanair source: configure-generated-file-in-source config.status I believe that the override is justified since the upstream tarball doesn't include a configure.in source and cannot be remade with auto-tools. config.status is generated by configure, not autoconf, so you'll probably find that you can take it out. I'm already removing it in the clean target: debian.rules: clean:: rm -f config.status Isn't that sufficient? -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: RFS: iguanair (try #2)
2009/6/8 Stefanos Harhalakis v...@v13.gr: On Monday 08 June 2009, Jack Kelly wrote: 2009/6/8 Stefanos Harhalakis v...@v13.gr: The package appears to be lintian clean except from an the override of: iguanair source: configure-generated-file-in-source config.status I believe that the override is justified since the upstream tarball doesn't include a configure.in source and cannot be remade with auto-tools. config.status is generated by configure, not autoconf, so you'll probably find that you can take it out. I'm already removing it in the clean target: debian.rules: clean:: rm -f config.status Isn't that sufficient? I'm not a dev, but if lintian's complaining, then probably not. If you remove it manually, then won't it be removed by the diff when you make the source package? -- Jack -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: RFS: iguanair (try #2)
On Tuesday 09 June 2009, Jack Kelly wrote: 2009/6/8 Stefanos Harhalakis v...@v13.gr: On Monday 08 June 2009, Jack Kelly wrote: 2009/6/8 Stefanos Harhalakis v...@v13.gr: The package appears to be lintian clean except from an the override of: iguanair source: configure-generated-file-in-source config.status I believe that the override is justified since the upstream tarball doesn't include a configure.in source and cannot be remade with auto-tools. config.status is generated by configure, not autoconf, so you'll probably find that you can take it out. I'm already removing it in the clean target: debian.rules: clean:: rm -f config.status Isn't that sufficient? I'm not a dev, but if lintian's complaining, then probably not. If you remove it manually, then won't it be removed by the diff when you make the source package? The lintian explanation[1] says: The clean rule in debian/rules should remove this file. [...] Note that Lintian cannot reliably detect the removal in the clean rule, so once you fix this, please ignore or override this warning. I also try not to touch anything outside debian/ directory since it will make lintian complain because there are patches too. [1] http://lintian.debian.org/tags/configure-generated-file-in-source.html -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: RFS: iguanair (try #2)
2009/6/9 V13 v...@v13.gr: On Tuesday 09 June 2009, Jack Kelly wrote: 2009/6/8 Stefanos Harhalakis v...@v13.gr: On Monday 08 June 2009, Jack Kelly wrote: 2009/6/8 Stefanos Harhalakis v...@v13.gr: The package appears to be lintian clean except from an the override of: iguanair source: configure-generated-file-in-source config.status I believe that the override is justified since the upstream tarball doesn't include a configure.in source and cannot be remade with auto-tools. config.status is generated by configure, not autoconf, so you'll probably find that you can take it out. I'm already removing it in the clean target: debian.rules: clean:: rm -f config.status Isn't that sufficient? I'm not a dev, but if lintian's complaining, then probably not. If you remove it manually, then won't it be removed by the diff when you make the source package? The lintian explanation[1] says: The clean rule in debian/rules should remove this file. [...] Note that Lintian cannot reliably detect the removal in the clean rule, so once you fix this, please ignore or override this warning. I also try not to touch anything outside debian/ directory since it will make lintian complain because there are patches too. [1] http://lintian.debian.org/tags/configure-generated-file-in-source.html Okay, good to know. Thanks. -- Jack -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: RFS: iguanair (try #2)
2009/6/8 Stefanos Harhalakis v...@v13.gr: The package appears to be lintian clean except from an the override of: iguanair source: configure-generated-file-in-source config.status I believe that the override is justified since the upstream tarball doesn't include a configure.in source and cannot be remade with auto-tools. config.status is generated by configure, not autoconf, so you'll probably find that you can take it out. -- Jack -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: RFS: iguanair
2009/5/22 Stefanos Harhalakis v...@v13.gr: iguanair - IguanaWorks IR daemon/driver iguanair-python - IguanaWorks IR python bindings Should be python-iguanair. iguanair-reflasher - IguanaWorks IR reflasher utility libiguanair - IguanaWorks IR support library Package name should contain the SONAME/ABI number, details in the libpkg-guide (please read the two bugs on it too). -- bye, pabs http://wiki.debian.org/PaulWise -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: RFS: iguanair
Hello and thank you for the review, On Friday 22 May 2009, Paul Wise wrote: 2009/5/22 Stefanos Harhalakis v...@v13.gr: iguanair - IguanaWorks IR daemon/driver iguanair-python - IguanaWorks IR python bindings Should be python-iguanair. Fixed. iguanair-reflasher - IguanaWorks IR reflasher utility libiguanair - IguanaWorks IR support library Package name should contain the SONAME/ABI number, details in the libpkg-guide (please read the two bugs on it too). I believe I fixed it. Following the instruction of libpkg-guide I changed the libiguanair package to libiguanair0 (which matches the SONAME). From what I've read on one of the bug reports, I understand that the correct naming for -dev is libiguanair-dev so I left it as-is. The new version is in mentors using the same version: - URL: http://mentors.debian.net/debian/pool/main/i/iguanair - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/i/iguanair/iguanair_0.99-1.dsc -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
