Re: RFS: libpar2 (reupload to Debian)

2011-07-09 Thread Andreas Moog
On 07/09/2011 12:38 AM, Andreas Moog wrote:
[...]
 Or, what would be even easier, I could just ignore the lintian warning
 for now, file a wishlist bug against the package once it's built and go
 from there with the (future) cleaned up api?

After a small discussion on IRC, this is what I will do.

Updated package pushed to git://git.debian.org/collab-maint/libpar2.git
and available at mentors:
dget http://mentors.debian.net/debian/pool/main/l/libpar2/libpar2_0.2-2.dsc

Thanks,

 Andreas



signature.asc
Description: OpenPGP digital signature


Re: RFS: libpar2 (reupload to Debian)

2011-07-09 Thread Kilian Krause
Hi Andreas,

On Sat, Jul 09, 2011 at 03:50:11PM +0200, Andreas Moog wrote:
 On 07/09/2011 12:38 AM, Andreas Moog wrote:
 [...]
  Or, what would be even easier, I could just ignore the lintian warning
  for now, file a wishlist bug against the package once it's built and go
  from there with the (future) cleaned up api?
 
 After a small discussion on IRC, this is what I will do.
 
 Updated package pushed to git://git.debian.org/collab-maint/libpar2.git
 and available at mentors:
 dget http://mentors.debian.net/debian/pool/main/l/libpar2/libpar2_0.2-2.dsc

that version still seems to lack that mentioned fix.

-- 
Best regards,
Kilian


signature.asc
Description: Digital signature


Re: RFS: libpar2 (reupload to Debian)

2011-07-09 Thread Andreas Moog
On 07/09/2011 04:26 PM, Kilian Krause wrote:

 Updated package pushed to git://git.debian.org/collab-maint/libpar2.git
 and available at mentors:
 dget
http://mentors.debian.net/debian/pool/main/l/libpar2/libpar2_0.2-2.dsc

 that version still seems to lack that mentioned fix.

Mentors doesn't seem to process uploads at the moment. You can use

dget http://people.ubuntu.com/~amoog/libpar2_0.2-2.dsc

to get a updated package.

Thanks and sorry for causing so much work.

 Andreas




signature.asc
Description: OpenPGP digital signature


Re: RFS: libpar2 (reupload to Debian)

2011-07-08 Thread Andreas Moog
On 07/07/2011 10:43 PM, Paul Wise wrote:

 There is one lintian warning:
 
 I: libpar2-0: no-symbols-control-file usr/lib/libpar2.so.0.0.1

Ups, yes. Symbols file added.

 Two cppcheck warnings:

 [libpar2.h:29]: (error) Memory leak: LibPar2::par1Repairer
 [libpar2.h:30]: (error) Memory leak: LibPar2::par2Repairer

Fixed, thanks for checking with cppcheck, didn't think of that.

 Since you are essentially upstream now, will you be attempting to get
 admin access to the upstream sourceforge project?

I don't think so. The sourceforge project is for many programs developed
for par2 file handling and I'm more thinking of hosting my libpar2 in
a separate project. But currently I have no concrete plans in that
direction.

Thanks for checking the package, a new version should be available at
the mentors.debian.net and in the git-repository at alioth.

Cheers,

 aNdreas




signature.asc
Description: OpenPGP digital signature


Re: RFS: libpar2 (reupload to Debian)

2011-07-08 Thread Kilian Krause
Hi Andreas,

On Fri, Jul 08, 2011 at 07:35:41PM +0200, Andreas Moog wrote:
 On 07/07/2011 10:43 PM, Paul Wise wrote:
 
  There is one lintian warning:
  
  I: libpar2-0: no-symbols-control-file usr/lib/libpar2.so.0.0.1
 
 Ups, yes. Symbols file added.
[...]
 Thanks for checking the package, a new version should be available at
 the mentors.debian.net and in the git-repository at alioth.

sorry, but FTBFS for me:
http://people.debian.org/~kilian/libpar2_0.2-2_i386.build

And just for the record, is #532041 part of your patches? Sounds a bit like
it from the changelog entry. Please add a matching Closes if is the case.

I'm looking forward to you setting up your own upstream repo so that the
patches will vanish from the package and there will be a new official
upstream tarball. ;-)

-- 
Best regards,
Kilian


signature.asc
Description: Digital signature


Re: RFS: libpar2 (reupload to Debian)

2011-07-08 Thread Andreas Moog
On 07/08/2011 09:31 PM, Kilian Krause wrote:
 Hi Andreas,
 
 On Fri, Jul 08, 2011 at 07:35:41PM +0200, Andreas Moog wrote:
 On 07/07/2011 10:43 PM, Paul Wise wrote:

 There is one lintian warning:

 I: libpar2-0: no-symbols-control-file usr/lib/libpar2.so.0.0.1

 Ups, yes. Symbols file added.
 [...]
 Thanks for checking the package, a new version should be available at
 the mentors.debian.net and in the git-repository at alioth.
 
 sorry, but FTBFS for me:
 http://people.debian.org/~kilian/libpar2_0.2-2_i386.build

Urgs, yeah, seems I need arch-specific symbols files. Currently libpar2
exports way too many symbols, 80% aren't needed anyway. It's on my
radar to reduce that and properly mark private what should be private,
but it's part of a bigger rewrite.

So, would it be acceptable to upload the package with
DPKG_GENSYMBOLS_CHECK_LEVEL=0 to get the package built on all arches and
then provide the symbols files as needed? (I don't have access to all
arches to generate the initial symbols file myself).

Or, what would be even easier, I could just ignore the lintian warning
for now, file a wishlist bug against the package once it's built and go
from there with the (future) cleaned up api?

 And just for the record, is #532041 part of your patches? Sounds a bit like
 it from the changelog entry. Please add a matching Closes if is the case.

Aye.

Thanks,

 Andreas



signature.asc
Description: OpenPGP digital signature


Re: RFS: libpar2 (reupload to Debian)

2011-07-07 Thread Paul Wise
On Wed, Jul 6, 2011 at 7:54 PM, Andreas Moog wrote:

 dget http://mentors.debian.net/debian/pool/main/l/libpar2/libpar2_0.2-2.dsc

I am unable to unpack the source package:

dpkg-source: error: File ./libpar2_0.2.orig.tar.gz has size 401700
instead of expected 403492

-- 
bye,
pabs

http://wiki.debian.org/PaulWise


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/CAKTje6Gm74oWUR_vPU4kK7UBQa0DgJnTmZ8F5=WTNvr=wz9...@mail.gmail.com



Re: RFS: libpar2 (reupload to Debian)

2011-07-07 Thread Andreas Moog
On 07/07/2011 09:53 PM, Paul Wise wrote:
 On Wed, Jul 6, 2011 at 7:54 PM, Andreas Moog wrote:
 
 dget http://mentors.debian.net/debian/pool/main/l/libpar2/libpar2_0.2-2.dsc
 
 I am unable to unpack the source package:
 
 dpkg-source: error: File ./libpar2_0.2.orig.tar.gz has size 401700
 instead of expected 403492

Hmm, interesting.

'git-buildpackage -S' with pristine-tar produces a different sized
orig.tar.gz. I need to investigate that. For now, fixed by using the
tarball downloaded from upstream instead of using gpb's reconstructed one.

Thanks.

Andreas



signature.asc
Description: OpenPGP digital signature


Re: RFS: libpar2 (reupload to Debian)

2011-07-07 Thread Paul Wise
There is one lintian warning:

I: libpar2-0: no-symbols-control-file usr/lib/libpar2.so.0.0.1

Two cppcheck warnings:

[libpar2.h:29]: (error) Memory leak: LibPar2::par1Repairer
[libpar2.h:30]: (error) Memory leak: LibPar2::par2Repairer

Since you are essentially upstream now, will you be attempting to get
admin access to the upstream sourceforge project?

-- 
bye,
pabs

http://wiki.debian.org/PaulWise


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/caktje6hjnpgh_ybnbkhovqklvaxggnmatptubhmamsnbkgm...@mail.gmail.com