Re: RFS: ndpmon
Thanks very much for your time! I will look into your comments, especially concerning the IEEE and get back to you. Thanks, again. On Tue, Aug 30, 2011 at 2:28 PM, Sven Hoexter wrote: > On Mon, Aug 29, 2011 at 02:32:36PM -0400, John R. Baskwill wrote: > > Hey John, > > thanks for working on ndpmon. > > > I am looking for a sponsor for my package "ndpmon", > > Here are some more remarks, I'm not sure if some of them were already > discussed, I didn't follow the original RFS and just read one of your > later mails. > > * The Vcs-* fields in debian/control have kind of a different meaning, > they're > not for the upstream repo. See Dev-Ref 6.2.5. > > * debian/copyright is incomplete. Stuff from plugins/mac_resolv > is missing and debian/manuf. I'd suggest to start with > 'grep -ir copyright *'. > > * I don't think the README.Debian contains useful information. > > * Regarding the manuf file I'm not 100% sure if we can distribute that > and if it's really GPL 2+ because according to the comments it's > compiled from several sources. Did they all agree that it's GPL 2+? > I've strong doubts about that for the IEEE. > > Didn't look at the init script so far, if nobody else steps up I'll try > to do that later this week. > > Cheers, > Sven > -- > And I don't know much, but I do know this: > With a golden heart comes a rebel fist. > [ Streetlight Manifesto - Here's To Life ] > -- John R. Baskwill, jr...@psu.edu Systems Analyst, Information Technology Services Penn State Harrisburg W303 Olmsted Building 777 West Harrisburg Pike Middletown, PA 17057-4898 Phone: 717-948-6268 Fax: 717-948-6535
Re: RFS: ndpmon
On Mon, Aug 29, 2011 at 02:32:36PM -0400, John R. Baskwill wrote: Hey John, thanks for working on ndpmon. > I am looking for a sponsor for my package "ndpmon", Here are some more remarks, I'm not sure if some of them were already discussed, I didn't follow the original RFS and just read one of your later mails. * The Vcs-* fields in debian/control have kind of a different meaning, they're not for the upstream repo. See Dev-Ref 6.2.5. * debian/copyright is incomplete. Stuff from plugins/mac_resolv is missing and debian/manuf. I'd suggest to start with 'grep -ir copyright *'. * I don't think the README.Debian contains useful information. * Regarding the manuf file I'm not 100% sure if we can distribute that and if it's really GPL 2+ because according to the comments it's compiled from several sources. Did they all agree that it's GPL 2+? I've strong doubts about that for the IEEE. Didn't look at the init script so far, if nobody else steps up I'll try to do that later this week. Cheers, Sven -- And I don't know much, but I do know this: With a golden heart comes a rebel fist. [ Streetlight Manifesto - Here's To Life ] -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110830182843.GB2312@marvin
Re: RFS: ndpmon
> > > While reading into your package I'm wondering about: > > 1.) ndpmon.init: >- DAEMON and INIT must be defined in /etc/default/ndpmon. I doubt > that's a good default. You should define fall-back defaults in the init > script too > >- you background start-stop-daemon during starting yet try to > evaluate > its return value. I doubt that's a good combination. Moreover you have a > added sleep without any useful value IMHO as the return code is pulled > before the sleep anyway. > >- during stop you unconditionally cat a PIDFILE without checking it > exists and run kill on the outcome. A better solution would be something > like PID=$(ps -C $DAEMON -o pid=) and check if that's not empty and kill > that (or check if that's equal to the PIDFILE and kill it then). > >- status should check PIDFILE and/or something like the ps -C > $DAEMON > and report based on that. > > I'd recommend you check the manpage of ps for further options you > may > see fit. > >- exit $? at the end is very likely to not match what you intended > to > use as exit status. Maybe you should > I'm still not sure about the INIT script. Before, the INIT script that was in the original source code did not support status or force-reload. So I basically copied the script and added those sections. Now, I tried to incorporate the suggestions above, which results in an INIT script that is different from the one in the source code, but I'm not sure of how good of a job I did. Any more suggestions would be appreciated. 2.) Patches: >- there is no need to modify Makefile to delete config.log and > config.status unless you want to report this back to upstream (which is > not indicated in the header). From a Debian POV debian/clean and/or > debian/rules will do (and should be used preferred) > >- I'm not sure install.patch is needed. You can as well use > debian/tmp > as DESTDIR and move files from there using dh_install I guess. Reporting > the fixes back upstream seem to make sense yet there again is no > indication this was done. > I removed the patch to the Makefile and added a debian/clean file. Also, the installation is now handled by the files debian/ndpmon.dirs and debian/install. >- spelling errors - again look useful, but please make sure they > don't > remain in Debian's archive alone but are included upstream. > I plan to send the spelling patches upstream. I was holding off until I had a better idea of the status of getting the program into debian, and all of the changes that were necessary so I could just submit things once. > 3.) debian/rules template header can be omited. > Done. >as autotools-dev are already in Build-Depends (which is good) they > should also be activated in debian/rules (using --with autotools_dev) > Done. I also added -with autoreconf. > 4.) Fetching http://standards.ieee.org/regauth/oui/oui_public.txt. > >OUCH! There is no internet access guaranteed during building a > package. That means this is quite likely to fail. > >Moreover: > Fetching http://www.cavebear.com/CaveBear/Ethernet.txt > Error fetching http://www.cavebear.com/CaveBear/Ethernet/Ethernet.txt: > 404 Not Found > >N.b. there is an attempt to make a shared package for that. See e.g. > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=481299 for details and > more bugs numbers. Please try to use that package (once avail) or an > offline copy in the meantime. > The purpose of make-manuf is to provide an up-to-date copy of manuf, which the program uses to match MAC addresses with manufacturers. If Internet access is not available during the build, I thought it would be better to create an up-to-date copy of manuf offline, and simply produce a patch to bring the copy in the original source code up-to-date, and make sure make-manuf doesn't run. > 5.) Rebuilding your package twice in a row produces a Debian patch: > dpkg-source: info: local changes stored in > ndpmon-1.4.0/debian/patches/debian-changes-1.4.0-1, the modified files > are: > ndpmon-1.4.0/Makefile > ndpmon-1.4.0/config_ndpmon.xml > ndpmon-1.4.0/ndpmon.sh > ndpmon-1.4.0/ndpmon_defs.h > ndpmon-1.4.0/neighbor_list.xml > ndpmon-1.4.0/plugins/countermeasures/Makefile > ndpmon-1.4.0/plugins/mac_resolv/Makefile > dpkg-source: info: building ndpmon in ndpmon_1.4.0-1.debian.tar.gz > I believe this problem is solved with the use of the debian/clean file. > 6.) You still ship source files in your binary package like: > ./usr/lib/ndpmon/plugins/mac_resolv/mac_resolv.c > ./usr/lib/ndpmon/plugins/mac_resolv/mac_resolv.h > ./usr/lib/ndpmon/plugins/mac_resolv/Makefile.in > ./usr/lib/ndpmon/plugins/countermeasures/icmp_lib_nd.c > ./usr/lib/ndpmon/plugins/countermeasures/countermeasures.c > ./usr/lib/ndpmon/plugins/countermeasures/countermeasures.h > ./usr/lib/ndpmon/plugins/countermeasures/icmp_lib_nd.h > ./usr/lib/ndpmon/plugins/countermeasures/icmp_lib.c > ./usr/lib/ndpmon/plugins/c
Re: RFS: ndpmon
Hi John, On Sat, 2011-08-06 at 18:23 -0400, John R. Baskwill wrote: > Now that I have the correct version of lintian, things look better. I > have upload a new version of the ndpmon package. I changed the > version back to 1.4.0-1 because I was told I shouldn't change the > version number if this was the initial release of the package. Thanks > for all of the help. thanks for the update. While reading into your package I'm wondering about: 1.) ndpmon.init: - DAEMON and INIT must be defined in /etc/default/ndpmon. I doubt that's a good default. You should define fall-back defaults in the init script too - you background start-stop-daemon during starting yet try to evaluate its return value. I doubt that's a good combination. Moreover you have a added sleep without any useful value IMHO as the return code is pulled before the sleep anyway. - during stop you unconditionally cat a PIDFILE without checking it exists and run kill on the outcome. A better solution would be something like PID=$(ps -C $DAEMON -o pid=) and check if that's not empty and kill that (or check if that's equal to the PIDFILE and kill it then). - status should check PIDFILE and/or something like the ps -C $DAEMON and report based on that. I'd recommend you check the manpage of ps for further options you may see fit. - exit $? at the end is very likely to not match what you intended to use as exit status. Maybe you should 2.) Patches: - there is no need to modify Makefile to delete config.log and config.status unless you want to report this back to upstream (which is not indicated in the header). From a Debian POV debian/clean and/or debian/rules will do (and should be used preferred) - I'm not sure install.patch is needed. You can as well use debian/tmp as DESTDIR and move files from there using dh_install I guess. Reporting the fixes back upstream seem to make sense yet there again is no indication this was done. - spelling errors - again look useful, but please make sure they don't remain in Debian's archive alone but are included upstream. 3.) debian/rules template header can be omited. as autotools-dev are already in Build-Depends (which is good) they should also be activated in debian/rules (using --with autotools_dev) 4.) Fetching http://standards.ieee.org/regauth/oui/oui_public.txt. OUCH! There is no internet access guaranteed during building a package. That means this is quite likely to fail. Moreover: Fetching http://www.cavebear.com/CaveBear/Ethernet.txt Error fetching http://www.cavebear.com/CaveBear/Ethernet/Ethernet.txt: 404 Not Found N.b. there is an attempt to make a shared package for that. See e.g. http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=481299 for details and more bugs numbers. Please try to use that package (once avail) or an offline copy in the meantime. 5.) Rebuilding your package twice in a row produces a Debian patch: dpkg-source: info: local changes stored in ndpmon-1.4.0/debian/patches/debian-changes-1.4.0-1, the modified files are: ndpmon-1.4.0/Makefile ndpmon-1.4.0/config_ndpmon.xml ndpmon-1.4.0/ndpmon.sh ndpmon-1.4.0/ndpmon_defs.h ndpmon-1.4.0/neighbor_list.xml ndpmon-1.4.0/plugins/countermeasures/Makefile ndpmon-1.4.0/plugins/mac_resolv/Makefile dpkg-source: info: building ndpmon in ndpmon_1.4.0-1.debian.tar.gz 6.) You still ship source files in your binary package like: ./usr/lib/ndpmon/plugins/mac_resolv/mac_resolv.c ./usr/lib/ndpmon/plugins/mac_resolv/mac_resolv.h ./usr/lib/ndpmon/plugins/mac_resolv/Makefile.in ./usr/lib/ndpmon/plugins/countermeasures/icmp_lib_nd.c ./usr/lib/ndpmon/plugins/countermeasures/countermeasures.c ./usr/lib/ndpmon/plugins/countermeasures/countermeasures.h ./usr/lib/ndpmon/plugins/countermeasures/icmp_lib_nd.h ./usr/lib/ndpmon/plugins/countermeasures/icmp_lib.c ./usr/lib/ndpmon/plugins/countermeasures/Makefile.in ./usr/lib/ndpmon/plugins/countermeasures/icmp_lib.h ./usr/lib/ndpmon/plugins/countermeasures/countermeasures_on_link.h ./usr/lib/ndpmon/plugins/countermeasures/countermeasures_guard.h Sorry! -- Best regards, Kilian signature.asc Description: This is a digitally signed message part
Re: RFS: ndpmon
Now that I have the correct version of lintian, things look better. I have upload a new version of the ndpmon package. I changed the version back to 1.4.0-1 because I was told I shouldn't change the version number if this was the initial release of the package. Thanks for all of the help. > On Sat, Aug 6, 2011 at 5:41 PM, Kilian Krause wrote: > >> Hi John, >> >> On Sat, Aug 06, 2011 at 05:26:26PM -0400, John R. Baskwill wrote: >> > 2011/8/4 Benoît Knecht >> [...] >> > > > > - 'lintian -I --pedantic ndpmon_1.4.0-2_*.changes' had this to >> say: >> > > > > >> > > > > W: ndpmon source: configure-generated-file-in-source >> config.status >> > > > > W: ndpmon source: configure-generated-file-in-source >> config.cache >> > > > > W: ndpmon source: configure-generated-file-in-source >> config.log >> > > >> > >> > These files are included in the original tarball. I modified the clean >> > target to remove these files, and also included lintian overrides for >> the >> > files. I will suggest to upstream to not include these files in the >> future. >> > I do have one question about the tarball, though. The file I >> downloaded >> > was named ndpmon-1.4.0.tgz. Everything I read about packaging seemed to >> > assume the tarball would be named ndpmon-1.4.0.tar.gz, so I renamed the >> > file. Is that permissible, or should I have left the name as it was? >> >> Renaming is fine. uscan will do that for you even if you ask it to >> --rename. >> >> As you have a configure-based upstream source I hope you've put >> autotools-dev in charge of keeping your config.* files up to date. ;-) >> >> >> > > > > W: ndpmon source: out-of-date-standards-version 3.9.1 >> (current is >> > > > > 3.9.2) >> > > >> > >> > My lintian says the current standard is 3.9.1, but OK. >> >> Then use the latest unstable or backports version. ;-) >> >> >> [...] >> > > > > I: ndpmon: spelling-error-in-binary usr/sbin/ndpmon Recieved >> > > Received >> > > > > I: ndpmon: spelling-error-in-binary usr/sbin/ndpmon adress >> address >> > > > > I: ndpmon: spelling-error-in-binary usr/sbin/ndpmon unkown >> unknown >> > > > > I: ndpmon: spelling-error-in-binary usr/sbin/ndpmon unkown >> unknown >> > > > > I: ndpmon: spelling-error-in-binary usr/src/ndpmon/ndpmon.o >> > > Recieved >> > > > > Received >> > > > > I: ndpmon: spelling-error-in-binary usr/src/ndpmon/ndpmon.o >> adress >> > > > > address >> > > > > I: ndpmon: spelling-error-in-binary >> usr/src/ndpmon/neighbors.o >> > > unkown >> > > > > unknown >> > > > > I: ndpmon: spelling-error-in-binary >> usr/src/ndpmon/neighbors.o >> > > unkown >> > > > > unknown >> > > > > E: ndpmon: helper-templates-in-copyright >> > > > > I: ndpmon: spelling-error-in-manpage >> > > usr/share/man/man8/ndpmon.8.gz >> > > > > allows to allows one to >> > > > > >> > > >> > >> > I included patches to correct the spelling errors. The patches have not >> > been sent upstream yet, but I will do that. The copyright file is in >> DEP5 >> > format. >> >> Patches should have their headers in DEP-3 format. DEP-5 is for >> debian/changelog only. >> >> [...] >> >> Thanks for keeping us posted! >> >> Please also tell us when the next version is up on mentors.d.n for review. >> >> -- >> Best regards, >> Kilian >> >> -BEGIN PGP SIGNATURE- >> Version: GnuPG v1.4.10 (GNU/Linux) >> >> iD8DBQFOPbT0vdkzt4X+wX8RAszaAJ9nSKT/ZO80rgmuNXfk2p5Gc4g6FgCfXdGF >> X/yfR9rGOZU4YH4CIETfweE= >> =TRbN >> -END PGP SIGNATURE- >> >> > > > -- > John R. Baskwill, jr...@psu.edu > Systems Analyst, Information Technology Services > Penn State Harrisburg > W303 Olmsted Building > 777 West Harrisburg Pike > Middletown, PA 17057-4898 > Phone: 717-948-6268 > Fax: 717-948-6535 > -- John R. Baskwill, jr...@psu.edu Systems Analyst, Information Technology Services Penn State Harrisburg W303 Olmsted Building 777 West Harrisburg Pike Middletown, PA 17057-4898 Phone: 717-948-6268 Fax: 717-948-6535
Re: RFS: ndpmon
Hi John, On Sat, Aug 06, 2011 at 05:26:26PM -0400, John R. Baskwill wrote: > 2011/8/4 Benoît Knecht [...] > > > > - 'lintian -I --pedantic ndpmon_1.4.0-2_*.changes' had this to say: > > > > > > > > W: ndpmon source: configure-generated-file-in-source config.status > > > > W: ndpmon source: configure-generated-file-in-source config.cache > > > > W: ndpmon source: configure-generated-file-in-source config.log > > > > These files are included in the original tarball. I modified the clean > target to remove these files, and also included lintian overrides for the > files. I will suggest to upstream to not include these files in the future. > I do have one question about the tarball, though. The file I downloaded > was named ndpmon-1.4.0.tgz. Everything I read about packaging seemed to > assume the tarball would be named ndpmon-1.4.0.tar.gz, so I renamed the > file. Is that permissible, or should I have left the name as it was? Renaming is fine. uscan will do that for you even if you ask it to --rename. As you have a configure-based upstream source I hope you've put autotools-dev in charge of keeping your config.* files up to date. ;-) > > > > W: ndpmon source: out-of-date-standards-version 3.9.1 (current is > > > > 3.9.2) > > > > My lintian says the current standard is 3.9.1, but OK. Then use the latest unstable or backports version. ;-) [...] > > > > I: ndpmon: spelling-error-in-binary usr/sbin/ndpmon Recieved > > Received > > > > I: ndpmon: spelling-error-in-binary usr/sbin/ndpmon adress address > > > > I: ndpmon: spelling-error-in-binary usr/sbin/ndpmon unkown unknown > > > > I: ndpmon: spelling-error-in-binary usr/sbin/ndpmon unkown unknown > > > > I: ndpmon: spelling-error-in-binary usr/src/ndpmon/ndpmon.o > > Recieved > > > > Received > > > > I: ndpmon: spelling-error-in-binary usr/src/ndpmon/ndpmon.o adress > > > > address > > > > I: ndpmon: spelling-error-in-binary usr/src/ndpmon/neighbors.o > > unkown > > > > unknown > > > > I: ndpmon: spelling-error-in-binary usr/src/ndpmon/neighbors.o > > unkown > > > > unknown > > > > E: ndpmon: helper-templates-in-copyright > > > > I: ndpmon: spelling-error-in-manpage > > usr/share/man/man8/ndpmon.8.gz > > > > allows to allows one to > > > > > > > > I included patches to correct the spelling errors. The patches have not > been sent upstream yet, but I will do that. The copyright file is in DEP5 > format. Patches should have their headers in DEP-3 format. DEP-5 is for debian/changelog only. [...] Thanks for keeping us posted! Please also tell us when the next version is up on mentors.d.n for review. -- Best regards, Kilian signature.asc Description: Digital signature
Re: RFS: ndpmon
2011/8/4 Benoît Knecht
> John R. Baskwill wrote:
> > 2011/8/4 Benoît Knecht
> > > [...]
> > >
> > > From a quick look at your package:
> > >
> > > - You have a debian/patches/debian-changes-1.4.0-1 patch that is
> > >probably not intentional.
>
You are correct. That was not intentional. The patch has been removed.
> > >
> > > - It would be great if you could use DEP-5 [1] for your
> > >debian/copyright.
> > >
> > >[1] http://dep.debian.net/deps/dep5/
> > >
>
I believe the format is correct for DEP-5 now.
> > >Also, if you run 'licensecheck -r .' in the root directory of your
> > >package, you'll notice that some files lack a copyright header. You
> > >should probably contact upstream about that and make sure that all
> > >the files are indeed released under the LGPL.
> > >
>
I emailed upstream to ask whether all of the source files were covered by
the LGPL, and not just the files with a copyright header. This was Olivier
Festor's (one of ndpmon's contacts) reply:
Absolutely ALL files of NDPMon are LGPL.
So I believe everything is fine from a licensing standpoint.
> > > - 'lintian -I --pedantic ndpmon_1.4.0-2_*.changes' had this to say:
> > >
> > > W: ndpmon source: configure-generated-file-in-source config.status
> > > W: ndpmon source: configure-generated-file-in-source config.cache
> > > W: ndpmon source: configure-generated-file-in-source config.log
>
These files are included in the original tarball. I modified the clean
target to remove these files, and also included lintian overrides for the
files. I will suggest to upstream to not include these files in the future.
I do have one question about the tarball, though. The file I downloaded
was named ndpmon-1.4.0.tgz. Everything I read about packaging seemed to
assume the tarball would be named ndpmon-1.4.0.tar.gz, so I renamed the
file. Is that permissible, or should I have left the name as it was?
> > > W: ndpmon source: out-of-date-standards-version 3.9.1 (current is
> > > 3.9.2)
>
My lintian says the current standard is 3.9.1, but OK.
> > > I: ndpmon source: debian-watch-contains-dh_make-template
>
The watch file has been cleaned up.
> > > I: ndpmon: spelling-error-in-binary usr/sbin/ndpmon Recieved
> Received
> > > I: ndpmon: spelling-error-in-binary usr/sbin/ndpmon adress address
> > > I: ndpmon: spelling-error-in-binary usr/sbin/ndpmon unkown unknown
> > > I: ndpmon: spelling-error-in-binary usr/sbin/ndpmon unkown unknown
> > > I: ndpmon: spelling-error-in-binary usr/src/ndpmon/ndpmon.o
> Recieved
> > > Received
> > > I: ndpmon: spelling-error-in-binary usr/src/ndpmon/ndpmon.o adress
> > > address
> > > I: ndpmon: spelling-error-in-binary usr/src/ndpmon/neighbors.o
> unkown
> > > unknown
> > > I: ndpmon: spelling-error-in-binary usr/src/ndpmon/neighbors.o
> unkown
> > > unknown
> > > E: ndpmon: helper-templates-in-copyright
> > > I: ndpmon: spelling-error-in-manpage
> usr/share/man/man8/ndpmon.8.gz
> > > allows to allows one to
> > >
>
I included patches to correct the spelling errors. The patches have not
been sent upstream yet, but I will do that. The copyright file is in DEP5
format.
> > >(Run it with '-i' to get a detailed explanation for each warning or
> > >error.)
> > >
> > > - Your .deb contains plenty of .{c,h,o} files, and the full source in
> > >/usr/src; I don't think it's what you intended to do, is it?
>
The installation target has been modified to not install these files.
> > >
> > > - In debian/control, the description of the package contains
> > >information about when, where and by whom the software was
> > >developed; I don't think it's relevant here. You also depend
> > >explicitly on some libraries, but these should be in
> > >${shlibs:Depends} already if the package links against them.
> > >
>
I removed that section of the description, and remove the explicit
dependencies.
> > > I hope this helps. Don't hesitate to ask if you have problems/questions
> > > about these issues.
> >
> > Thank you very much for taking the time to look at my package. I will
> work
> > on the items you listed.
>
> Great! A couple more things, in case you have too much time on your
> hands :)
>
> - debian/docs: You shouldn't install CHANGES, FILES, MD5SUMS or
>VERSION; they're really not useful to the user (except changes, but
>it's installed as changelog.gz by dh_installchangelogs already).
>
>
I changed the docs file to include only the README.
> - debian/ndpmon.init: Instead of hardcoding variables such as INIT or
>LOGDIR, you could source /etc/default/ndpmon (you'd have to create
>it in your package) so that users can easily change these paths.
>Also, and correct me if I'm wrong, but isn't $"string" a bashism?
>
>
I did as you suggested and included a ndpmon.default file with the default
paths for ndpmon.
> - debian/{postinst,prerm,postrm} do
Re: RFS: ndpmon
John R. Baskwill wrote:
> 2011/8/4 Benoît Knecht
>
> >
> > >From a quick look at your package:
> >
> > - Your .deb contains plenty of .{c,h,o} files, and the full source in
> >/usr/src; I don't think it's what you intended to do, is it?
> >
> >
> The original source code installed the .{c,h,o} files into
> /usr/local/ndpmon, so I assumed the authors wanted users to have access to
> all of the source. I did move those files to what I thought was a more
> appropriate location. Is it more appropriate to simply not install the
> files?
Yes, you shouldn't install those files at all. If anyone needs access to
the source, they can download the source package. I can't see in what
usage scenario someone would need those files installed alongside the
main program.
--
Benoît Knecht
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20110804163740.gc3...@marvin.lan
Re: RFS: ndpmon
John R. Baskwill wrote:
> 2011/8/4 Benoît Knecht
> > [...]
> >
> > From a quick look at your package:
> >
> > - You have a debian/patches/debian-changes-1.4.0-1 patch that is
> >probably not intentional.
> >
> > - It would be great if you could use DEP-5 [1] for your
> >debian/copyright.
> >
> >[1] http://dep.debian.net/deps/dep5/
> >
> >Also, if you run 'licensecheck -r .' in the root directory of your
> >package, you'll notice that some files lack a copyright header. You
> >should probably contact upstream about that and make sure that all
> >the files are indeed released under the LGPL.
> >
> > - 'lintian -I --pedantic ndpmon_1.4.0-2_*.changes' had this to say:
> >
> > W: ndpmon source: configure-generated-file-in-source config.status
> > W: ndpmon source: configure-generated-file-in-source config.cache
> > W: ndpmon source: configure-generated-file-in-source config.log
> > W: ndpmon source: out-of-date-standards-version 3.9.1 (current is
> > 3.9.2)
> > I: ndpmon source: debian-watch-contains-dh_make-template
> > I: ndpmon: spelling-error-in-binary usr/sbin/ndpmon Recieved Received
> > I: ndpmon: spelling-error-in-binary usr/sbin/ndpmon adress address
> > I: ndpmon: spelling-error-in-binary usr/sbin/ndpmon unkown unknown
> > I: ndpmon: spelling-error-in-binary usr/sbin/ndpmon unkown unknown
> > I: ndpmon: spelling-error-in-binary usr/src/ndpmon/ndpmon.o Recieved
> > Received
> > I: ndpmon: spelling-error-in-binary usr/src/ndpmon/ndpmon.o adress
> > address
> > I: ndpmon: spelling-error-in-binary usr/src/ndpmon/neighbors.o unkown
> > unknown
> > I: ndpmon: spelling-error-in-binary usr/src/ndpmon/neighbors.o unkown
> > unknown
> > E: ndpmon: helper-templates-in-copyright
> > I: ndpmon: spelling-error-in-manpage usr/share/man/man8/ndpmon.8.gz
> > allows to allows one to
> >
> >(Run it with '-i' to get a detailed explanation for each warning or
> >error.)
> >
> > - Your .deb contains plenty of .{c,h,o} files, and the full source in
> >/usr/src; I don't think it's what you intended to do, is it?
> >
> > - In debian/control, the description of the package contains
> >information about when, where and by whom the software was
> >developed; I don't think it's relevant here. You also depend
> >explicitly on some libraries, but these should be in
> >${shlibs:Depends} already if the package links against them.
> >
> > I hope this helps. Don't hesitate to ask if you have problems/questions
> > about these issues.
>
> Thank you very much for taking the time to look at my package. I will work
> on the items you listed.
Great! A couple more things, in case you have too much time on your
hands :)
- debian/docs: You shouldn't install CHANGES, FILES, MD5SUMS or
VERSION; they're really not useful to the user (except changes, but
it's installed as changelog.gz by dh_installchangelogs already).
- debian/ndpmon.init: Instead of hardcoding variables such as INIT or
LOGDIR, you could source /etc/default/ndpmon (you'd have to create
it in your package) so that users can easily change these paths.
Also, and correct me if I'm wrong, but isn't $"string" a bashism?
- debian/{postinst,prerm,postrm} do not do anything, you should remove
them. I also think you can safely remove debian/preinst; the daemon
will be stopped on upgrades by the prerm script generated by
debhelper.
Cheers,
--
Benoît Knecht
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20110804163339.gb3...@marvin.lan
Re: RFS: ndpmon
2011/8/4 Benoît Knecht
>
> >From a quick look at your package:
>
> - Your .deb contains plenty of .{c,h,o} files, and the full source in
>/usr/src; I don't think it's what you intended to do, is it?
>
>
The original source code installed the .{c,h,o} files into
/usr/local/ndpmon, so I assumed the authors wanted users to have access to
all of the source. I did move those files to what I thought was a more
appropriate location. Is it more appropriate to simply not install the
files?
--
John R. Baskwill, jr...@psu.edu
Systems Analyst, Information Technology Services
Penn State Harrisburg
W303 Olmsted Building
777 West Harrisburg Pike
Middletown, PA 17057-4898
Phone: 717-948-6268
Fax: 717-948-6535
Re: RFS: ndpmon
2011/8/4 Benoît Knecht
> Hi John,
>
> John R. Baskwill wrote:
> > I am looking for a sponsor for my package "ndpmon",
> >
> > * Package name : ndpmon
> > Version : 1.4.0-2
> > Upstream Author : frederic.b...@loria.fr
> > * URL : http://ndpmon.sourceforge.net/index.html
> > * License : LGPL 2.1+
> > Section : net
> >
> > It builds these binary packages:
> > ndpmon - IPv6 Neighbor Discovery Protocol Monitor
> >
> > The upload would fix these bugs: 635975
>
> >From a quick look at your package:
>
> - You have a debian/patches/debian-changes-1.4.0-1 patch that is
>probably not intentional.
>
> - It would be great if you could use DEP-5 [1] for your
>debian/copyright.
>
>[1] http://dep.debian.net/deps/dep5/
>
>Also, if you run 'licensecheck -r .' in the root directory of your
>package, you'll notice that some files lack a copyright header. You
>should probably contact upstream about that and make sure that all
>the files are indeed released under the LGPL.
>
> - 'lintian -I --pedantic ndpmon_1.4.0-2_*.changes' had this to say:
>
> W: ndpmon source: configure-generated-file-in-source config.status
> W: ndpmon source: configure-generated-file-in-source config.cache
> W: ndpmon source: configure-generated-file-in-source config.log
> W: ndpmon source: out-of-date-standards-version 3.9.1 (current is
> 3.9.2)
> I: ndpmon source: debian-watch-contains-dh_make-template
> I: ndpmon: spelling-error-in-binary usr/sbin/ndpmon Recieved Received
> I: ndpmon: spelling-error-in-binary usr/sbin/ndpmon adress address
> I: ndpmon: spelling-error-in-binary usr/sbin/ndpmon unkown unknown
> I: ndpmon: spelling-error-in-binary usr/sbin/ndpmon unkown unknown
> I: ndpmon: spelling-error-in-binary usr/src/ndpmon/ndpmon.o Recieved
> Received
> I: ndpmon: spelling-error-in-binary usr/src/ndpmon/ndpmon.o adress
> address
> I: ndpmon: spelling-error-in-binary usr/src/ndpmon/neighbors.o unkown
> unknown
> I: ndpmon: spelling-error-in-binary usr/src/ndpmon/neighbors.o unkown
> unknown
> E: ndpmon: helper-templates-in-copyright
> I: ndpmon: spelling-error-in-manpage usr/share/man/man8/ndpmon.8.gz
> allows to allows one to
>
>(Run it with '-i' to get a detailed explanation for each warning or
>error.)
>
> - Your .deb contains plenty of .{c,h,o} files, and the full source in
>/usr/src; I don't think it's what you intended to do, is it?
>
> - In debian/control, the description of the package contains
>information about when, where and by whom the software was
>developed; I don't think it's relevant here. You also depend
>explicitly on some libraries, but these should be in
>${shlibs:Depends} already if the package links against them.
>
> I hope this helps. Don't hesitate to ask if you have problems/questions
> about these issues.
>
> Cheers,
>
> --
> Benoît Knecht
>
>
> --
> To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
> with a subject of "unsubscribe". Trouble? Contact
> listmas...@lists.debian.org
> Archive: http://lists.debian.org/20110804151446.ga3...@marvin.lan
>
>
Thank you very much for taking the time to look at my package. I will work
on the items you listed.
--
John R. Baskwill, jr...@psu.edu
Systems Analyst, Information Technology Services
Penn State Harrisburg
W303 Olmsted Building
777 West Harrisburg Pike
Middletown, PA 17057-4898
Phone: 717-948-6268
Fax: 717-948-6535
Re: RFS: ndpmon
Hi John,
John R. Baskwill wrote:
> I am looking for a sponsor for my package "ndpmon",
>
> * Package name : ndpmon
> Version : 1.4.0-2
> Upstream Author : frederic.b...@loria.fr
> * URL : http://ndpmon.sourceforge.net/index.html
> * License : LGPL 2.1+
> Section : net
>
> It builds these binary packages:
> ndpmon - IPv6 Neighbor Discovery Protocol Monitor
>
> The upload would fix these bugs: 635975
>From a quick look at your package:
- You have a debian/patches/debian-changes-1.4.0-1 patch that is
probably not intentional.
- It would be great if you could use DEP-5 [1] for your
debian/copyright.
[1] http://dep.debian.net/deps/dep5/
Also, if you run 'licensecheck -r .' in the root directory of your
package, you'll notice that some files lack a copyright header. You
should probably contact upstream about that and make sure that all
the files are indeed released under the LGPL.
- 'lintian -I --pedantic ndpmon_1.4.0-2_*.changes' had this to say:
W: ndpmon source: configure-generated-file-in-source config.status
W: ndpmon source: configure-generated-file-in-source config.cache
W: ndpmon source: configure-generated-file-in-source config.log
W: ndpmon source: out-of-date-standards-version 3.9.1 (current is 3.9.2)
I: ndpmon source: debian-watch-contains-dh_make-template
I: ndpmon: spelling-error-in-binary usr/sbin/ndpmon Recieved Received
I: ndpmon: spelling-error-in-binary usr/sbin/ndpmon adress address
I: ndpmon: spelling-error-in-binary usr/sbin/ndpmon unkown unknown
I: ndpmon: spelling-error-in-binary usr/sbin/ndpmon unkown unknown
I: ndpmon: spelling-error-in-binary usr/src/ndpmon/ndpmon.o Recieved
Received
I: ndpmon: spelling-error-in-binary usr/src/ndpmon/ndpmon.o adress address
I: ndpmon: spelling-error-in-binary usr/src/ndpmon/neighbors.o unkown
unknown
I: ndpmon: spelling-error-in-binary usr/src/ndpmon/neighbors.o unkown
unknown
E: ndpmon: helper-templates-in-copyright
I: ndpmon: spelling-error-in-manpage usr/share/man/man8/ndpmon.8.gz
allows to allows one to
(Run it with '-i' to get a detailed explanation for each warning or
error.)
- Your .deb contains plenty of .{c,h,o} files, and the full source in
/usr/src; I don't think it's what you intended to do, is it?
- In debian/control, the description of the package contains
information about when, where and by whom the software was
developed; I don't think it's relevant here. You also depend
explicitly on some libraries, but these should be in
${shlibs:Depends} already if the package links against them.
I hope this helps. Don't hesitate to ask if you have problems/questions
about these issues.
Cheers,
--
Benoît Knecht
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20110804151446.ga3...@marvin.lan
Re: RFS: ndpmon
On Thu, Aug 4, 2011 at 10:08 AM, John R. Baskwill wrote: > > > On Thu, Aug 4, 2011 at 10:29 AM, Matt Zagrabelny wrote: >> >> Hi John, >> >> On Thu, Aug 4, 2011 at 9:18 AM, John R. Baskwill wrote: >> > >> > Dear mentors, >> > I am looking for a sponsor for my package "ndpmon", >> > * Package name : ndpmon >> > Version : 1.4.0-2 >> >> If your first attempt at getting sponsored and uploaded didn't take, >> you'd keep the version of the package at 1.4.0-1. >> >> -mz > > > Thanks very much for your reply. This is my first attempt at getting > sponsored. The first upload was OK, but based on the reply I received > from mentors.debian.net, I changed the clean target and uploaded a revised > package. Should I have kept it at 1.4.0-1 in that case? Yep. You only bump versions when there is an upload. Thus, you'll keep it at that same version while doing all of your (initial) packaging until it is sponsored and uploaded. -mz -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/caolfk3xftgngqsa5y-7jzovdwtvtx7m+wwgdx1hbktrv16d...@mail.gmail.com
Re: RFS: ndpmon
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi John, On 04.08.2011 17:08, John R. Baskwill wrote: > Thanks very much for your reply. This is my first attempt at getting > sponsored. The first upload was OK, but based on the reply I received from > mentors.debian.net, I changed the clean target and uploaded a revised > package. Should I have kept it at 1.4.0-1 in that case? different people have different opinions here, but basically yes. It is common practice to reflect version number changes only for uploads targetting for Debian directly (in fact, this is a requirement there, its not possible to overwrite packages). For mentors.d.n you can pretty much do what you want, including overwriting the same package again. Please note, an upload to mentors.d.n does /not/ mean, your package has been uploaded to Debian's official repositories. That's is just a public platform for peer reviews and sponsor searching. - -- with kind regards, Arno Töll IRC: daemonkeeper on Freenode/OFTC GnuPG Key-ID: 0x9D80F36D -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJOOrbdAAoJEMcrUe6dgPNt2kcQAKExETXQQ6NM9nQUTkaayZLW OLNxBqSNRukVFWuP69SRwj1/jJddzeUruN+LL+qUPoIiwLUeCzCpMPQ0A99/4nsg XzYK3uGaGlxwhxVmM8aYpU5h5l6PsBy17PN2YSZ/PjwII0V36B+HJJf/gw3eV3zm CU8N8md+0eMObp/X19STCTrsKKg0dkWJaDa0u7Jji/tXrBZD22dOCDRtoOSQfYto sCS5rR77gpnITbA/LTj+4teGKaTJmFoj2p4HLDr9fE5kh/yOMFgBBbKhMFQ5PPY+ sSMB6ZLdjPpVxS4Ac6kKaUgTk4pnLYmVTu6URnM03+DAbo5j4d//hxgiPa2Ocq7j Qbc0+Ja77dO8KjAEguodxq5wGIaTnMS1zDXjIyLBxXmRgoIdb0goPSyjzfZ/9yTk IjFzP6kIjSejtpsvIIoOnt5qBEvS/KlOnWJwP+7eTVtw5T3U6wmOfKSFptVKJjxb SvB+zQrZ8FhshXjJr/TIyf1feIrNk4+HtY36lOvtExlk8QZU9lotCNXMaCf5ElX/ S8dFVIuuKzRi082Kn9b51e5Uu9Ow3DQ8bDiDRz1ujLIYmNWlVI93epVAUBRFMOY0 39sMzwl3JlVMyA9SqjF/iolY0Oymjznm0wt6O7TdGtGgIcydqs4ViLOvAwLD0v5P iOeNAY0smSAGZkRhS/de =P+V6 -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4e3ab6dd.1080...@toell.net
Re: RFS: ndpmon
On Thu, Aug 4, 2011 at 10:29 AM, Matt Zagrabelny wrote: > Hi John, > > On Thu, Aug 4, 2011 at 9:18 AM, John R. Baskwill wrote: > > > > Dear mentors, > > I am looking for a sponsor for my package "ndpmon", > > * Package name : ndpmon > > Version : 1.4.0-2 > > If your first attempt at getting sponsored and uploaded didn't take, > you'd keep the version of the package at 1.4.0-1. > > -mz > Thanks very much for your reply. This is my first attempt at getting sponsored. The first upload was OK, but based on the reply I received from mentors.debian.net, I changed the clean target and uploaded a revised package. Should I have kept it at 1.4.0-1 in that case? -- John R. Baskwill, jr...@psu.edu Systems Analyst, Information Technology Services Penn State Harrisburg W303 Olmsted Building 777 West Harrisburg Pike Middletown, PA 17057-4898 Phone: 717-948-6268 Fax: 717-948-6535
Re: RFS: ndpmon
Hi John, On Thu, Aug 4, 2011 at 9:18 AM, John R. Baskwill wrote: > > Dear mentors, > I am looking for a sponsor for my package "ndpmon", > * Package name : ndpmon > Version : 1.4.0-2 If your first attempt at getting sponsored and uploaded didn't take, you'd keep the version of the package at 1.4.0-1. -mz -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/caolfk3ua-qnte6htf8pfnhuthv42wvepocupyivnxfosdzk...@mail.gmail.com
