Re: RFS: pyamf
On Sat, Apr 17, 2010 at 07:39:57PM -0430, Miguel Landaeta wrote: Hi Christoph, On Sat, Apr 17, 2010 at 5:15 AM, Christoph Egger christ...@debian.org wrote: I've just having a look at it. Below you can find some random points I noticed. * the BSD licene in common-licenses tells (c) The Regents of the University of California -- it is unsuitable for everything but original BSD software. Please just include a copy in your copyright (or use the MIT license that is already there). I just adopted this package and the debian bits were already licensed under BSD. Surely I can change the license to MIT, but I preferred to keep the license chose by the previous maintainer. Now, for example so many packages license the debian dir with GPL and use the text in common-licences and it tells Copyright (C) 2007 Free Software Foundation, Inc but AFAIK it doesn't mean that FSF own that software. Or am I wrong? The GPL says /--- Copyright (C) 2007 Free Software Foundation, Inc. http://fsf.org/ Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed. \--- claiming copyright for the license to the FSF while the BSD license does the same for the same for the software - regents of Berkley. For the GPL you have these some paragraphes long part in your copright file which includes copyright notices for the authors. THat's the difference. * There's a patch included in your package. It is not at all clear why it must be there, whether it has been forwarded (or if that could be done) nor anything else. Please comment your patch. I found out this patch was useless and it was removed. * Your watchfile doesn't seem to work very well % uscan --report-status uscan warning: In debian/watch, no matching hrefs for pattern http://download.pyamf.org/releases/([\d.]+) at /usr/bin/uscan line 1571, WATCH line 2. uscan warning: In watchfile debian/watch, reading webpage http://download.pyamf.org/releases/1/ failed: 404 Not Found Yes, upstream changed the URLs, but this is already fixed. OK then as Jakub wanted to do the review already which I didn't notice I guess he'll continue. Regards Christoph -- /\ ASCII Ribbon : GPG-Key ID: 0xD49AE731 \ /Campaign : CaCert Assurer X against HTML : Debian Developer / \ in eMails : http://www.debian.org/ http://www.christoph-egger.org/ signature.asc Description: Digital signature
Re: RFS: pyamf
Hi! On Wed, Apr 14, 2010 at 11:35:10AM -0430, Miguel Landaeta wrote: I am looking for a sponsor for my package pyamf. * Package name: pyamf Version : 0.5.1-1 Upstream Author : The PyAMF Project d...@pyamf.org * URL : http://pyamf.org/ * License : MIT Section : python It builds these binary packages: python-pyamf - Action Message Format support for Python python-pyamf-doc - documentation for the Python AMF support The package appears to be lintian clean. The upload would fix these bugs: 499617 My motivation for maintaining this package is: I'm developing software that Depends on this. I would like to maintain this under Debian Python Modules Team. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/p/pyamf - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/p/pyamf/pyamf_0.5.1-1.dsc - Vcs-Svn: svn://svn.debian.org/python-modules/packages/pyamf/trunk/ I've just having a look at it. Below you can find some random points I noticed. * the BSD licene in common-licenses tells (c) The Regents of the University of California -- it is unsuitable for everything but original BSD software. Please just include a copy in your copyright (or use the MIT license that is already there). * There's a patch included in your package. It is not at all clear why it must be there, whether it has been forwarded (or if that could be done) nor anything else. Please comment your patch. * Your watchfile doesn't seem to work very well % uscan --report-status uscan warning: In debian/watch, no matching hrefs for pattern http://download.pyamf.org/releases/([\d.]+) at /usr/bin/uscan line 1571, WATCH line 2. uscan warning: In watchfile debian/watch, reading webpage http://download.pyamf.org/releases/1/ failed: 404 Not Found Regards Christoph -- /\ ASCII Ribbon : GPG-Key ID: 0xD49AE731 \ /Campaign : CaCert Assurer X against HTML : Debian Developer / \ in eMails : http://www.debian.org/ http://www.christoph-egger.org/ signature.asc Description: Digital signature
Re: RFS: pyamf
Hi Christoph, On Sat, Apr 17, 2010 at 5:15 AM, Christoph Egger christ...@debian.org wrote: I've just having a look at it. Below you can find some random points I noticed. * the BSD licene in common-licenses tells (c) The Regents of the University of California -- it is unsuitable for everything but original BSD software. Please just include a copy in your copyright (or use the MIT license that is already there). I just adopted this package and the debian bits were already licensed under BSD. Surely I can change the license to MIT, but I preferred to keep the license chose by the previous maintainer. Now, for example so many packages license the debian dir with GPL and use the text in common-licences and it tells Copyright (C) 2007 Free Software Foundation, Inc but AFAIK it doesn't mean that FSF own that software. Or am I wrong? * There's a patch included in your package. It is not at all clear why it must be there, whether it has been forwarded (or if that could be done) nor anything else. Please comment your patch. I found out this patch was useless and it was removed. * Your watchfile doesn't seem to work very well % uscan --report-status uscan warning: In debian/watch, no matching hrefs for pattern http://download.pyamf.org/releases/([\d.]+) at /usr/bin/uscan line 1571, WATCH line 2. uscan warning: In watchfile debian/watch, reading webpage http://download.pyamf.org/releases/1/ failed: 404 Not Found Yes, upstream changed the URLs, but this is already fixed. Thanks for your review, Cheers, -- Miguel Landaeta, miguel at miguel.cc secure email with PGP 0x7D8967E9 available at http://keyserver.pgp.com/ Faith means not wanting to know what is true. -- Nietzsche -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/j2w38bcf1e31004171709mc90f8741tf263a1ef8fa2...@mail.gmail.com
Re: RFS: pyamf
Miguel Landaeta scrisse: I am looking for a sponsor for my package pyamf. [...] My motivation for maintaining this package is: I'm developing software that Depends on this. I would like to maintain this under Debian Python Modules Team. As I was the one who opened the RFP, I'd be glad to sponsor this if nobody step up in some days (but I'd _really_ prefer to have it uploaded by someone inside the DPMT, as I'm not so much skilled in python modules). Ciao, Luca -- .''`. ** Debian GNU/Linux ** | Luca Bruno (kaeso) : :' : The Universal O.S.| lucab (AT) debian.org `. `'` | GPG Key ID: 3BFB9FB3 `- http://www.debian.org | Debian GNU/Linux Developer pgpxu4EA4WSSS.pgp Description: PGP signature
