Re: RFS: smarty
On Tue, Mar 13, 2007 at 10:41:25PM +0300, Thierry Randrianiriana wrote: > I am looking for a sponsor for the new version 2.6.18-1 > of my package "smarty". Found one yet? If not I'll do this and the -doc - Craig -- Craig Small GnuPG:1C1B D893 1418 2AF4 45EE 95CB C76C E5AC 12CA DFA5 http://www.enc.com.au/ csmall at : enc.com.au http://www.debian.org/ Debian GNU/Linux, software should be Free -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Re: RFS: smarty
On 3/15/07, Craig Small <[EMAIL PROTECTED]> wrote: On Tue, Mar 13, 2007 at 10:41:25PM +0300, Thierry Randrianiriana wrote: > I am looking for a sponsor for the new version 2.6.18-1 > of my package "smarty". Found one yet? If not I'll do this and the -doc not yet , thanks! - Craig -- Craig Small GnuPG:1C1B D893 1418 2AF4 45EE 95CB C76C E5AC 12CA DFA5 http://www.enc.com.au/ csmall at : enc.com.au http://www.debian.org/ Debian GNU/Linux, software should be Free -- Thierry Randrianiriana -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Re: RFS: smarty
On 08/01/2011 07:23 AM, Wojciech Szaranski wrote: > Dear mentors, > > I am looking for a sponsor for my package "smarty". > > * Package name: smarty > Version : 3.0.8-5 > Upstream Author : Monte Ohrt , Uwe Tews > * URL : http://www.smarty.net/ > * License : LGPL version 3 > Section : web > > It builds these binary packages: > smarty - Template engine for PHP I have looked no further than debian/changelog. Changelog entries should be one entry with the full changeset from the previous release into the debian archive. Yours shows 5 separate entries since the latest version 2.6.26-0.2. There are several reverse dependencies - have you tested out each of those against this new major upstream revision? Just a couple thoughts after a very quick look. :-) -- Kind regards, Michael -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4e36c988.6090...@pbandjelly.org
Re: RFS: smarty
W dniu 11-08-01 17:43, Michael Shuler pisze: > On 08/01/2011 07:23 AM, Wojciech Szaranski wrote: >> Dear mentors, >> >> I am looking for a sponsor for my package "smarty". >> >> * Package name : smarty >> Version : 3.0.8-5 >> Upstream Author : Monte Ohrt , Uwe Tews >> * URL : http://www.smarty.net/ >> * License : LGPL version 3 >> Section : web >> >> It builds these binary packages: >> smarty - Template engine for PHP > > I have looked no further than debian/changelog. Changelog entries > should be one entry with the full changeset from the previous release > into the debian archive. Yours shows 5 separate entries since the > latest version 2.6.26-0.2. > > There are several reverse dependencies - have you tested out each of > those against this new major upstream revision? > > Just a couple thoughts after a very quick look. :-) > > I have misunderstood debian package versioning :) I thinked that if I'm changing package I should change version number regardless of that it was or wasn't uploaded into debian archive because someone could use my packages apart of debian main repository. I've testet this package with php-cli. This is php library so it must work with apache module or php-cgi. Is there any unified unit testing for packages? Could I write some automated tests and run them on my next versions of package? (something like phpunit for php classes;) Smarty 3.x require php5 - older versions had less restrictive requirements. Maybe I should rename my package to php5-smarty? There are many php5-* libraries and I don't understand why smarty is different... signature.asc Description: OpenPGP digital signature
Re: RFS: smarty
Hi, thanks for your interest in smarty. On Mon, 01 Aug 2011, Wojciech Szaranski wrote: > The package appears to be lintian clean. > > The upload would fix these bugs: 514305 Have you read http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=514305#10 ? Because: 1/ you have not taken care of the case where other packages install files in /usr/share/php/smarty/libs/plugins (i.e. no preinst, no conflicts, nothing for this) $ apt-file search /usr/share/php/smarty/libs | cut -d: -f1 | uniq collabtive smarty smarty-acl-render smarty-gettext smarty-validate 2/ you have not informed me 3/ you have not contacted any other maintainer of a reverse-dependency asking them to test with your updated package (and warning them that a new upstream version will land shortly in Debian) (but before doing so, let's fix this package) $ apt-cache showpkg smarty Reverse Depends: piwigo,smarty 2.6.26 moodle,smarty smarty-acl-render,smarty gosa,smarty smbind,smarty smarty-validate,smarty smarty-gettext,smarty slbackup-php,smarty serendipity,smarty piwigo,smarty 2.6.26 phpgacl,smarty 2.6.9 ojs,smarty moodle,smarty kolab-webadmin,smarty gallery2,smarty 2.6.26 collabtive,smarty Maitaining a library requires more care than the usual package, please pay attention to everything. > My motivation for maintaining this package is: I would like to share > packages that I'm using :) Great, but you should make it work for everybody and not only you. :-) A few remarks: - you should not package it as a Debian native package but as "3.0 (quilt)" mkdir debian/source echo "3.0 (quilt)" > debian/source/format - you should indicate in the changelog which security issues are fixed by this upload by incorporating all the corresponding CVE numbers http://security-tracker.debian.org/tracker/source-package/smarty - you should update it to the latest Standards-Version (verify that it follows the latest policy with /usr/share/doc/debian-policy/upgrading-checklist.txt.gz) - the package does not even build currently because "make" invokes "make install" as that's the only target and "debian/rules build" does not have the required root rights There's lots of work left as you can see. You should really also check your package with lintian on Debian unstable, there are lots of issues: W: smarty source: native-package-with-dash-version I: smarty source: missing-debian-source-format W: smarty source: out-of-date-standards-version 3.8.4 (current is 3.9.2) W: smarty: wrong-name-for-upstream-changelog usr/share/doc/smarty/change_log.txt.gz W: smarty: debian-changelog-line-too-long line 2 E: smarty: helper-templates-in-copyright W: smarty: symlink-is-self-recursive usr/share/php/smarty/libs . I: smarty: package-contains-empty-directory usr/share/doc/smarty/demo/cache/ I: smarty: package-contains-empty-directory usr/share/doc/smarty/demo/templates_c/ Obviously "W: smarty: symlink-is-self-recursive usr/share/php/smarty/libs ." can't be fixed, you have to override it and document the reason for this override. Please CC me for a secound review once you have fixed everything reported here. Feel free to ask questions as well if you don't understand something. Cheers, -- Raphaël Hertzog ◈ Debian Developer Follow my Debian News ▶ http://RaphaelHertzog.com (English) ▶ http://RaphaelHertzog.fr (Français) -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110803065527.gd28...@rivendell.home.ouaza.com
Re: RFS: smarty
On Wed, 03 Aug 2011, Raphael Hertzog wrote: > Because: > 1/ you have not taken care of the case where other packages install >files in /usr/share/php/smarty/libs/plugins (i.e. no preinst, no >conflicts, nothing for this) Just to clarify, you should add versioned conflicts on all those packages so that they are upgraded/removed before smarty is upgraded. Of course the other packages have to provide new versions with the files moved for this to work. Thus you have to coordinate with those maintainers. The postinst should have some code to drop the directory /usr/share/php/smarty/libs and replace it with a symlink because the simple upgrade will not replace it properly (dpkg does not replace dir by symlinks and vice-versa, per policy). On a unrelated note, it would be a good idea to maintain this package in a public VCS repository on collab-maint (my preference goes to git): http://wiki.debian.org/Alioth/PackagingProject Cheers, -- Raphaël Hertzog ◈ Debian Developer Follow my Debian News ▶ http://RaphaelHertzog.com (English) ▶ http://RaphaelHertzog.fr (Français) -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110803070518.gf28...@rivendell.home.ouaza.com
Re: RFS: smarty
hi, On Mon, Aug 1, 2011 at 3:23 PM, Wojciech Szaranski wrote: > * Package name : smarty > Version : 3.0.8-5 There is a smarty3 package with the same version http://packages.debian.org/sid/smarty3 . Best Regards, -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAFFwCaSXzqgJdP+c5Z6d3dy80svsbb8NK=DKL=qo8hbftdm...@mail.gmail.com
Re: RFS: smarty
Hi, On Wed, 03 Aug 2011, Thierry Randrianiriana wrote: > On Mon, Aug 1, 2011 at 3:23 PM, Wojciech Szaranski wrote: > > * Package name : smarty > > Version : 3.0.8-5 > > There is a smarty3 package with the same version > http://packages.debian.org/sid/smarty3 . And you are the maintainer of it... can you elaborate why you packaged it under a new package name? We certainly don't want 2 versions of this package in the long term in Debian. Please ensure we have some sort of upgrade plans to get back to 1 version only. In particular given the number of security issues that have affected it. Cheers, -- Raphaël Hertzog ◈ Debian Developer Follow my Debian News ▶ http://RaphaelHertzog.com (English) ▶ http://RaphaelHertzog.fr (Français) -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110803093546.gj28...@rivendell.home.ouaza.com
