Re: embedded-zlib and fpc
E: easymp3gain-gtk: embedded-zlib ./usr/bin/easymp3gain @ftp-masters: was the removal of embedded-zlib from the list of tags that can be overridden just temporary (because of the klibc incident)? Yes it was temporary and its already back. -- bye, Joerg liw I'm kinky and perverse, but my illness is laziness pgp8XJhbJ3Tbz.pgp Description: PGP signature
Re: embedded-zlib and fpc
Patrick Matthäi pmatth...@debian.org writes: Am 13.04.2010 06:55, schrieb Raphael Geissert: Patrick Matthäi wrote: There is also an lintian error, which can not be overwritten and would reject it from the repository: E: easymp3gain-gtk: embedded-zlib ./usr/bin/easymp3gain This is added by fpc, see #472304. Not sure what the real status is, though. @ftp-masters: was the removal of embedded-zlib from the list of tags that can be overridden just temporary (because of the klibc incident)? A new version of lintian is about to be released and would like to know whether that change should be propagated. I think raising the severity of the bug to a RC-one would be a good idea, because this prevents packages built with fpc to get uploaded into the archive. Another possible solution would be, to allow again the embedded-zlib, until this bug has been fixed. That bug looks unrelated to embedded-zlib. It's about statically linking with Pascal libraries included in FPC. The problem with embedded-zlib appears to be a false positive in Lintian. It seems to be triggering on the string: Seek in deflate compressed stream failed. although I don't see how that would match the regex that Lintian is using. I can't find any other occurance of inflate or deflate in the strings for easymp3gain, though. You should override this Lintian tag for right now until we can figure out what's going on. -- Russ Allbery (r...@debian.org) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/87zl17qclt@windlord.stanford.edu
Re: embedded-zlib and fpc
Am 13.04.2010 23:14, schrieb Russ Allbery: Patrick Matthäipmatth...@debian.org writes: Am 13.04.2010 06:55, schrieb Raphael Geissert: Patrick Matthäi wrote: There is also an lintian error, which can not be overwritten and would reject it from the repository: E: easymp3gain-gtk: embedded-zlib ./usr/bin/easymp3gain This is added by fpc, see #472304. Not sure what the real status is, though. @ftp-masters: was the removal of embedded-zlib from the list of tags that can be overridden just temporary (because of the klibc incident)? A new version of lintian is about to be released and would like to know whether that change should be propagated. I think raising the severity of the bug to a RC-one would be a good idea, because this prevents packages built with fpc to get uploaded into the archive. Another possible solution would be, to allow again the embedded-zlib, until this bug has been fixed. That bug looks unrelated to embedded-zlib. It's about statically linking with Pascal libraries included in FPC. The problem with embedded-zlib appears to be a false positive in Lintian. It seems to be triggering on the string: Seek in deflate compressed stream failed. although I don't see how that would match the regex that Lintian is using. I can't find any other occurance of inflate or deflate in the strings for easymp3gain, though. You should override this Lintian tag for right now until we can figure out what's going on. But this one is one of the not-overrideable-ones as in: the package will be rejected. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4bc4dedc.2070...@debian.org
Re: embedded-zlib and fpc
Patrick Matthäi pmatth...@debian.org writes: Am 13.04.2010 23:14, schrieb Russ Allbery: You should override this Lintian tag for right now until we can figure out what's going on. But this one is one of the not-overrideable-ones as in: the package will be rejected. No, it isn't. Look at http://ftp-master.debian.org/static/lintian.tags. It's non-fatal. -- Russ Allbery (r...@debian.org) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/87hbnfqc65@windlord.stanford.edu
Re: embedded-zlib and fpc
Russ Allbery r...@debian.org writes: The problem with embedded-zlib appears to be a false positive in Lintian. It seems to be triggering on the string: Seek in deflate compressed stream failed. Ah, no, I was looking in the wrong package. It's fp-units-base, and the string is indeed exactly the problematic string indicating an embedded copy of zlib: 4 deflate 1.1.2 Copyright 1995-1998 Jean-loup Gailly It's in usr/lib/fpc/2.4.0/units/i386-linux/paszlib/zdeflate.o, and that's because despite being a completely different implementation translated to Pascal, the Pascal implementation embeds exactly the same copyright and version string as the C imlementation. Sigh. This is generally a false positive in that this is not the problem that Lintian is trying to diagnose (although I don't understand why it only sometimes shows up in builds of easymp3gain). I'm trying to figure out a good way of having Lintian avoid this problem. I wonder if we can trigger off of that leading 4 to suppress this tag, since that seems to be peculiar to the Pascal implementation. I think I'll give that a try for the next Lintian release. -- Russ Allbery (r...@debian.org) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/87d3y3qbu5@windlord.stanford.edu
Re: embedded-zlib and fpc
On Tue, 13 Apr 2010 14:30:58 -0700, Russ Allbery r...@debian.org wrote: Russ Allbery r...@debian.org writes: The problem with embedded-zlib appears to be a false positive in Lintian. It seems to be triggering on the string: Seek in deflate compressed stream failed. Ah, no, I was looking in the wrong package. It's fp-units-base, and the string is indeed exactly the problematic string indicating an embedded copy of zlib: 4 deflate 1.1.2 Copyright 1995-1998 Jean-loup Gailly It's in usr/lib/fpc/2.4.0/units/i386-linux/paszlib/zdeflate.o, and that's because despite being a completely different implementation translated to Pascal, the Pascal implementation embeds exactly the same copyright and version string as the C imlementation. Sigh. This is generally a false positive in that this is not the problem that Lintian is trying to diagnose (although I don't understand why it only sometimes shows up in builds of easymp3gain). I'm trying to figure out a good way of having Lintian avoid this problem. I wonder if we can trigger off of that leading 4 to suppress this tag, since that seems to be peculiar to the Pascal implementation. I think I'll give that a try for the next Lintian release. Thank you! I asked at debian-devel for some info about this and worked with the FPC developers and came to exactly the same conclusion as you do. If you ldd the binary, you can also see zlib is dynamically linked. -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/48e1691a135d06eb6ba6bd8f410a9...@mb8-2.1blu.de
Re: embedded-zlib and fpc
Matthias Klumpp matth...@nlinux.org writes: On Tue, 13 Apr 2010 14:30:58 -0700, Russ Allbery r...@debian.org wrote: Ah, no, I was looking in the wrong package. It's fp-units-base, and the string is indeed exactly the problematic string indicating an embedded copy of zlib: 4 deflate 1.1.2 Copyright 1995-1998 Jean-loup Gailly It's in usr/lib/fpc/2.4.0/units/i386-linux/paszlib/zdeflate.o, and that's because despite being a completely different implementation translated to Pascal, the Pascal implementation embeds exactly the same copyright and version string as the C imlementation. Sigh. This is generally a false positive in that this is not the problem that Lintian is trying to diagnose (although I don't understand why it only sometimes shows up in builds of easymp3gain). I'm trying to figure out a good way of having Lintian avoid this problem. I wonder if we can trigger off of that leading 4 to suppress this tag, since that seems to be peculiar to the Pascal implementation. I think I'll give that a try for the next Lintian release. I've tested this modification and it will be in the next Lintian release. The 4 is the Pascal string length (52), which luckily turns out to be an ASCII character in this case so it shows up in the strings output. It should be reliable as a way to avoid this problem, although we'll have to tweak Lintian again if the length of that string ever changes. Thank you! I asked at debian-devel for some info about this and worked with the FPC developers and came to exactly the same conclusion as you do. If you ldd the binary, you can also see zlib is dynamically linked. Yeah, it's unfortunate that the different implementation copies the string so exactly, but part of the fun of working on Lintian is coming up with little hacks to avoid false positives. :) -- Russ Allbery (r...@debian.org) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/8739yzqb5l@windlord.stanford.edu
