Re: Request for voluntary package reviews
On Sun, Nov 07, 2010 at 09:23:53PM +0100, Michael Tautschnig wrote: > Hi Alexandre, > > [...] (review by chrysn and comments) > > > > > > > i couldn't test the functionality itself for lack of midi hardware, but > > > at least that's reflected by appropriate warnings by midish. > > > > I was mostly concerned by any packaging mistakes, but testing the code > > itself never hurts :-) > > > > The package includes regression tests - would it make sense to run these at > build time, or would that only make sense if a MIDI device was present? I > tried > to run them and all of them passed, but I don't really know if this is just > trivially true as I don't have MIDI hardware. If it makes sense to run them > even > without MIDI hardware, please include a make check run in future releases of > your package. Indeed these tests require no midi hardware. They are mostly useful to developpers but running them can't hurt ;) I'll include them in the next version of the package. > > Thanks for your comments, the new package is on the usual place: > > > > http://mentors.debian.net/debian/pool/main/m/midish > > > > Thanks to the review by chrysn it was pretty easy to do another final review; > I > have now built and uploaded your package. For future versions, please take the > following into consideration: > > - As said above, a regression test would of course be nice to have. > - In line with [1] you might consider acknowleding reviews such as chrysn's as > those help in speeding up the sponsoring process. > - You require a compat level of 7, so you could also make use of the much > simplified rules file made possible by debhelper 7. See [2] for further > information. Thanks for the review and for uploading the package. I just got a notification that the package fails to build on kfreebsd, I guess the kfreebsd has clock_gettime() in librt. Fixing these issues... -- Alexandre -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101108174518.gx5...@moule.localdomain
Re: Request for voluntary package reviews
Hi Alexandre, [...] (review by chrysn and comments) > > > > i couldn't test the functionality itself for lack of midi hardware, but > > at least that's reflected by appropriate warnings by midish. > > I was mostly concerned by any packaging mistakes, but testing the code > itself never hurts :-) > The package includes regression tests - would it make sense to run these at build time, or would that only make sense if a MIDI device was present? I tried to run them and all of them passed, but I don't really know if this is just trivially true as I don't have MIDI hardware. If it makes sense to run them even without MIDI hardware, please include a make check run in future releases of your package. > Thanks for your comments, the new package is on the usual place: > > http://mentors.debian.net/debian/pool/main/m/midish > Thanks to the review by chrysn it was pretty easy to do another final review; I have now built and uploaded your package. For future versions, please take the following into consideration: - As said above, a regression test would of course be nice to have. - In line with [1] you might consider acknowleding reviews such as chrysn's as those help in speeding up the sponsoring process. - You require a compat level of 7, so you could also make use of the much simplified rules file made possible by debhelper 7. See [2] for further information. As yourself you benefitted from non-DD reviews, you might want to do so yourself as well. I have just asked two others at [3] to do so. Please let me address this to you as well. Thank you very much for your contribution, Michael [1] http://lists.debian.org/debian-mentors/2010/11/msg00084.html [2] http://www.debian.org/doc/manuals/maint-guide/ch-dreq.en.html#s-rules [3] http://lists.debian.org/debian-mentors/2010/11/msg00148.html pgpeay8fWUSFY.pgp Description: PGP signature
Request for voluntary package reviews
Hi Andreas and Laurent, I have recently sponsored your packages sciteproj and dhcp-probe. As many others are still looking for sponsors for their packages, and in a follow-up to [1], I would like to ask you to give back to the community, if you feel happy about your package having been uploaded to Debian archives. This is a completely voluntary step, but it would be great if you could help others by reviewing their packages. Of course you cannot actually do the sponsoring, but the more feedback prospective package maintainers get for their fresh packages, the better those packages will be, which in turn makes later sponsoring a lot easier. You can find a long list of packages seeking sponsorship at [2], but please note that some of these packages have been reviewed already. Some of the packages which, to the best of my knowledge, have not seen any review yet are [3], [4] and [5]. Thank you very much for your contribution and thanks in advance if you should choose to help others as well. Best regards, Michael [1] http://lists.debian.org/debian-mentors/2010/10/msg00424.html [2] http://mentors.debian.net/cgi-bin/sponsor-pkglist [3] http://lists.debian.org/debian-mentors/2010/10/msg00352.html [4] http://lists.debian.org/debian-mentors/2010/10/msg00410.html [5] http://lists.debian.org/debian-mentors/2010/10/msg00490.html pgpVk0rX0aeLm.pgp Description: PGP signature
Re: Request for voluntary package reviews
On Sun, Oct 31, 2010 at 12:03:27AM +0200, chrysn wrote: > > concerning the midish package: > > i've had a look at the midish package mentioned in [1]. it seems to be > packaged in a reasonable way. > > the only potential issue i've spottet is that Willem van Engen, > co-author of mdep_alsa.c, is mentioned in the file's copyright section, > but not in debian/copyright; Oops. Now Willem in the debian/copyright file > also, Samuel Mimram did the earlier > packaging, he might deserve being mentioned in debian/copyright as well, > unless 0.3.0-1 was a complete re-packaging, in which case that should be > stated in the changelog. > Yes, 1.0.4-1 is a complete repackaging because many things changed (the upstream build process, standards, alsa support, ...). I added the corresponding line in the changelog > (on the minor end of the severity scale, one might suggest to upstream > to keep source code, man pages and examples in appropriate > sub-directories, but that's probably just a matter of style.) > > i couldn't test the functionality itself for lack of midi hardware, but > at least that's reflected by appropriate warnings by midish. I was mostly concerned by any packaging mistakes, but testing the code itself never hurts :-) Thanks for your comments, the new package is on the usual place: http://mentors.debian.net/debian/pool/main/m/midish cheers, -- Alexandre -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101031120631.gc15...@moule.localdomain
Re: Request for voluntary package reviews
On 10/31/2010 12:03 AM, chrysn wrote: > On Sat, Oct 30, 2010 at 09:49:41PM +0200, Michael Tautschnig wrote: >> I have recently sponsored your packages downloadstatusbar and visolate. > > thanks; i've received the messages, just waited for the package to pass > through NEW for confirmation. > >> As many others are still looking for sponsors for their packages, and >> in a follow-up to [1], I would like to ask you to give back to the >> community, if you feel happy about your package having been uploaded >> to Debian archives. > > i wasn't aware that mentors is used like this -- it might be useful to > have this stated on mentors.debian.net, the start page text mainly > emphasizes on the different roles of developers as sponsors and > non-developers as sponsees. > > as a result, i just subscribed to mentors. The reviewing of packages is not an immediate requirement, neither for DDs nor for anyone else. However, the distribution would not work without it. With your first package in the distribution, the DM status is only a formality, really. I understood Michael's stimulus rather as a continuation of his initial mentoring, i.e. a training for your Debian Developer status. Your review was fine, from what I saw. You may want to ask Michael to advocate you if you are not on the NM already. Steffen -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4ccca94f.4070...@gmx.de
Re: Request for voluntary package reviews
On Sat, Oct 30, 2010 at 09:49:41PM +0200, Michael Tautschnig wrote: > I have recently sponsored your packages downloadstatusbar and visolate. thanks; i've received the messages, just waited for the package to pass through NEW for confirmation. > As many others are still looking for sponsors for their packages, and > in a follow-up to [1], I would like to ask you to give back to the > community, if you feel happy about your package having been uploaded > to Debian archives. i wasn't aware that mentors is used like this -- it might be useful to have this stated on mentors.debian.net, the start page text mainly emphasizes on the different roles of developers as sponsors and non-developers as sponsees. as a result, i just subscribed to mentors. concerning the midish package: i've had a look at the midish package mentioned in [1]. it seems to be packaged in a reasonable way. the only potential issue i've spottet is that Willem van Engen, co-author of mdep_alsa.c, is mentioned in the file's copyright section, but not in debian/copyright; also, Samuel Mimram did the earlier packaging, he might deserve being mentioned in debian/copyright as well, unless 0.3.0-1 was a complete re-packaging, in which case that should be stated in the changelog. (on the minor end of the severity scale, one might suggest to upstream to keep source code, man pages and examples in appropriate sub-directories, but that's probably just a matter of style.) i couldn't test the functionality itself for lack of midi hardware, but at least that's reflected by appropriate warnings by midish. hth chrysn [1] http://lists.debian.org/debian-mentors/2010/10/msg00464.html <20101030121441.ga15...@moule.localdomain> -- To use raw power is to make yourself infinitely vulnerable to greater powers. -- Bene Gesserit axiom signature.asc Description: Digital signature
Request for voluntary package reviews
Hi Williams and chrysn, I have recently sponsored your packages downloadstatusbar and visolate. As many others are still looking for sponsors for their packages, and in a follow-up to [1], I would like to ask you to give back to the community, if you feel happy about your package having been uploaded to Debian archives. This is a completely voluntary step, but it would be great if you could help others by reviewing their packages. Of course you cannot actually do the sponsoring, but the more feedback prospective package maintainers get for their fresh packages, the better those packages will be, which in turn makes later sponsoring a lot easier. You can find a long list of packages seeking sponsorship at [2], but please note that some of these packages have been reviewed already. Some of the packages which, to the best of my knowledge, have not seen any review yet are [3], [4] and [5]. Thank you very much for your contribution and thanks in advance if you should choose to help others as well. Best regards, Michael [1] http://lists.debian.org/debian-mentors/2010/10/msg00424.html [2] http://mentors.debian.net/cgi-bin/sponsor-pkglist [3] http://lists.debian.org/debian-mentors/2010/10/msg00464.html [4] http://lists.debian.org/debian-mentors/2010/09/msg00095.html [5] http://lists.debian.org/debian-mentors/2010/10/msg00352.html pgpy4r2IoFifq.pgp Description: PGP signature
