Re: [debian-mentors] config.sub and config.guess | .diff.gz bloat
I demand that Geert Stappers may or may not have written... [snip] find . -name exact-name-of-file | xargs rm -f or find . -name exact-name-of-file -print0 | xargs -0r rm -f can be reduced to rm -f exact-name-of-file They can't: consider what happens when ./foo/exact-name-of-file exists. My message is: avoid surprises from find. :-) -- | Darren Salt | linux (or ds) at | nr. Ashington, | woody, sarge, | youmustbejoking | Northumberland | RISC OS | demon co uk | Toon Army | I don't ask for much, just untold riches... Proposals, as understood by the proposer, will be judged otherwise by others. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: [debian-mentors] config.sub and config.guess | .diff.gz bloat
I demand that Geert Stappers may or may not have written... [snip] find . -name exact-name-of-file | xargs rm -f or find . -name exact-name-of-file -print0 | xargs -0r rm -f can be reduced to rm -f exact-name-of-file They can't: consider what happens when ./foo/exact-name-of-file exists. My message is: avoid surprises from find. :-) -- | Darren Salt | linux (or ds) at | nr. Ashington, | woody, sarge, | youmustbejoking | Northumberland | RISC OS | demon co uk | Toon Army | I don't ask for much, just untold riches... Proposals, as understood by the proposer, will be judged otherwise by others.
Re: [debian-mentors] Re: [debian-mentors] config.sub and config.guess | .diff.gz bloat
A levelezm azt hiszi, hogy Andreas Metzler a kvetkezeket rta:
Two things:
Does -name config.{log,status,cache} actually work for you? It doesn't
do for me:
[]
Never ever use |xargs rm -f.
Thank you. Is it okay now?
--- orig/debian/rules
+++ mod/debian/rules
@@ -56,7 +56,7 @@
clean: debfiles-stamp
dh_testdir
dh_testroot
- find . -name config.{log,status,cache} |xargs rm -f
+ find . \( -name config.log -o -name config.status -o -name
config.cache \) -print0 |xargs -0r rm -f
rm -f build-stamp
rm -f modules/config-stamp
rm -d debian/zorp-modules.files
@@ -64,12 +64,12 @@
# Add here commands to clean up after the build process.
-$(MAKE) distclean
- -find -name ltmain.sh -o -name config.h.in -o -name stamp-h.in \
+ -find \( -name ltmain.sh -o -name config.h.in -o -name
stamp-h.in \
-o -name config.cache -o -name config.log -o -name
config.status\
-o -name stamp-h -o -name config.sub -o -name config.guess \
- -o -name Makefile.in -o -name aclocal.m4 -o -name configure|grep
-v ++pristine |xargs rm
- -find -name autom4te.cache |grep -v ++pristine |xargs rm -rf
- -find -type l |grep -v ++pristine |xargs rm
+ -o -name Makefile.in -o -name aclocal.m4 -o -name configure \)
-print0|grep -z -v ++pristine |xargs -0r rm
+ -find -name autom4te.cache -print0|grep -z -v ++pristine |xargs
-r0 rm -rf
+ -find -type l -print0|grep -z -v ++pristine |xargs -0r rm
-rm -f modules/zorp-module-http-2.0.0/tests/Makefile
dh_clean
--
GNU GPL: csak tiszta forrsbl
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: [debian-mentors] Re: [debian-mentors] config.sub and config.guess | .diff.gz bloat
On Mon, Nov 10, 2003 at 11:50:09AM +, Magos?nyi ?rp?d wrote:
A levelezõm azt hiszi, hogy Andreas Metzler a következõeket írta:
Two things:
Does -name config.{log,status,cache} actually work for you? It doesn't
do for me:
[]
Never ever use |xargs rm -f.
Thank you. Is it okay now?
--- orig/debian/rules
+++ mod/debian/rules
[still dangerous |xargs rm -f code]
Use
rm -f config.status and other files
Geert Stappers
--
Keep It Simple Stupid
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: [debian-mentors] Re: [debian-mentors] config.sub and config.guess | .diff.gz bloat
A levelezm azt hiszi, hogy Geert Stappers a kvetkezeket rta: On Mon, Nov 10, 2003 at 11:50:09AM +, Magos?nyi ?rp?d wrote: A levelez?m azt hiszi, hogy Andreas Metzler a kvetkez?eket rta: [quoting] or [1] find ... -print0 | xargs -0r rm -f cu andreas [1] This is a lot faster, but won't work with every find. It is safe to use on Debian though because we use GNU findutils. [still dangerous |xargs rm -f code] Now what? I thought using |xargs -0r rm -f is safe. -- GNU GPL: csak tiszta forrsbl -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: [debian-mentors] config.sub and config.guess | .diff.gz bloat
On Mon, Nov 10, 2003 at 11:50:09AM +, Magosányi Árpád wrote:
A levelez?m azt hiszi, hogy Andreas Metzler a következ?eket írta:
Two things:
Does -name config.{log,status,cache} actually work for you? It doesn't
do for me:
[]
Never ever use |xargs rm -f.
Thank you. Is it okay now?
--- orig/debian/rules
+++ mod/debian/rules
[...]
I think so, unless I misparsed the diff.
cu andreas
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: [debian-mentors] config.sub and config.guess | .diff.gz bloat
Geert Stappers [EMAIL PROTECTED] wrote:
On Mon, Nov 10, 2003 at 11:50:09AM +, Magos?nyi ?rp?d wrote:
A levelezõm azt hiszi, hogy Andreas Metzler a következõeket írta:
Two things:
Does -name config.{log,status,cache} actually work for you? It doesn't
do for me:
[]
Never ever use |xargs rm -f.
Thank you. Is it okay now?
--- orig/debian/rules
+++ mod/debian/rules
[still dangerous |xargs rm -f code]
[...]
Where? I only see find -print0 | xargs -0r rm which is safe.
cu andreas
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: [debian-mentors] config.sub and config.guess | .diff.gz bloat
On Mon, Nov 10, 2003 at 01:27:27PM +, Magos?nyi ?rp?d wrote:
A levelezõm azt hiszi, hogy Geert Stappers a következõeket írta:
On Mon, Nov 10, 2003 at 11:50:09AM +, Magos?nyi ?rp?d wrote:
A levelez?m azt hiszi, hogy Andreas Metzler a következ?eket írta:
| | | - find . -name config.{log,status,cache} |xargs rm -f
| | | + find . \( -name config.log -o -name config.status -o -name config.cache
\) -print0 |xargs -0r rm -f
[quoting]
or [1]
find ... -print0 | xargs -0r rm -f
cu andreas
[1] This is a lot faster, but won't work with every find. It is safe
to use on Debian though because we use GNU findutils.
[still dangerous |xargs rm -f code]
| |
| | Use
| |
| |rm -f config.status and other files
| |
Now what? I thought using |xargs -0r rm -f is safe.
There is still the risk that find finds more then you expect.
A simple
rm -f config.log config.status config.cache
will only remove what has been told to remove.
If you like find and surprises, you are free to ignore this advice.
Geert Stappers
pgp0.pgp
Description: PGP signature
Re: [debian-mentors] config.sub and config.guess | .diff.gz bloat
On Mon, Nov 10, 2003 at 01:57:17PM +, Andreas Metzler wrote:
Geert Stappers [EMAIL PROTECTED] wrote:
On Mon, Nov 10, 2003 at 11:50:09AM +, Magos?nyi ?rp?d wrote:
A levelezõm azt hiszi, hogy Andreas Metzler a következõeket írta:
Two things:
Does -name config.{log,status,cache} actually work for you? It doesn't
do for me:
[]
Never ever use |xargs rm -f.
Thank you. Is it okay now?
--- orig/debian/rules
+++ mod/debian/rules
[still dangerous |xargs rm -f code]
[...]
Where? I only see find -print0 | xargs -0r rm which is safe.
Oops, an other one that could be offended: Sorry.
find . -name exact-name-of-file | xargs rm -f
or
find . -name exact-name-of-file -print0 | xargs -0r rm -f
can be reduced to
rm -f exact-name-of-file
My message is: avoid surprises from find.
cu andreas
Geert Stappers
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: [debian-mentors] Re: [debian-mentors] config.sub and config.guess | .diff.gz bloat
A levelezm azt hiszi, hogy Geert Stappers a kvetkezeket rta: My message is: avoid surprises from find. Got the message, thank you for the warning. However I doubt that upstream will use names like config.guess for anything other than files which can and should be regenerated in build phase, and expect that there will be even more modules for Zorp as time passes. Each module have its own autoconfiguration, as they in theory can be compiled on their own right. Because of that I would like to stick with find. We are talking about some half a hundred files which should be cleaned. -- GNU GPL: csak tiszta forrsbl -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: [debian-mentors] Re: [debian-mentors] config.sub and config.guess | .diff.gz bloat
A levelezőm azt hiszi, hogy Andreas Metzler a következőeket írta:
Two things:
Does -name config.{log,status,cache} actually work for you? It doesn't
do for me:
[]
Never ever use |xargs rm -f.
Thank you. Is it okay now?
--- orig/debian/rules
+++ mod/debian/rules
@@ -56,7 +56,7 @@
clean: debfiles-stamp
dh_testdir
dh_testroot
- find . -name config.{log,status,cache} |xargs rm -f
+ find . \( -name config.log -o -name config.status -o -name
config.cache \) -print0 |xargs -0r rm -f
rm -f build-stamp
rm -f modules/config-stamp
rm -d debian/zorp-modules.files
@@ -64,12 +64,12 @@
# Add here commands to clean up after the build process.
-$(MAKE) distclean
- -find -name ltmain.sh -o -name config.h.in -o -name stamp-h.in \
+ -find \( -name ltmain.sh -o -name config.h.in -o -name
stamp-h.in \
-o -name config.cache -o -name config.log -o -name
config.status\
-o -name stamp-h -o -name config.sub -o -name config.guess \
- -o -name Makefile.in -o -name aclocal.m4 -o -name configure|grep
-v ++pristine |xargs rm
- -find -name autom4te.cache |grep -v ++pristine |xargs rm -rf
- -find -type l |grep -v ++pristine |xargs rm
+ -o -name Makefile.in -o -name aclocal.m4 -o -name configure \)
-print0|grep -z -v ++pristine |xargs -0r rm
+ -find -name autom4te.cache -print0|grep -z -v ++pristine |xargs
-r0 rm -rf
+ -find -type l -print0|grep -z -v ++pristine |xargs -0r rm
-rm -f modules/zorp-module-http-2.0.0/tests/Makefile
dh_clean
--
GNU GPL: csak tiszta forrásból
Re: [debian-mentors] Re: [debian-mentors] config.sub and config.guess | .diff.gz bloat
On Mon, Nov 10, 2003 at 11:50:09AM +, Magos?nyi ?rp?d wrote:
A levelezõm azt hiszi, hogy Andreas Metzler a következõeket írta:
Two things:
Does -name config.{log,status,cache} actually work for you? It doesn't
do for me:
[]
Never ever use |xargs rm -f.
Thank you. Is it okay now?
--- orig/debian/rules
+++ mod/debian/rules
[still dangerous |xargs rm -f code]
Use
rm -f config.status and other files
Geert Stappers
--
Keep It Simple Stupid
Re: [debian-mentors] Re: [debian-mentors] config.sub and config.guess | .diff.gz bloat
A levelezőm azt hiszi, hogy Geert Stappers a következőeket írta: On Mon, Nov 10, 2003 at 11:50:09AM +, Magos?nyi ?rp?d wrote: A levelez?m azt hiszi, hogy Andreas Metzler a következ?eket írta: [quoting] or [1] find ... -print0 | xargs -0r rm -f cu andreas [1] This is a lot faster, but won't work with every find. It is safe to use on Debian though because we use GNU findutils. [still dangerous |xargs rm -f code] Now what? I thought using |xargs -0r rm -f is safe. -- GNU GPL: csak tiszta forrásból
Re: [debian-mentors] config.sub and config.guess | .diff.gz bloat
On Mon, Nov 10, 2003 at 11:50:09AM +, Magosányi Árpád wrote:
A levelez?m azt hiszi, hogy Andreas Metzler a következ?eket írta:
Two things:
Does -name config.{log,status,cache} actually work for you? It doesn't
do for me:
[]
Never ever use |xargs rm -f.
Thank you. Is it okay now?
--- orig/debian/rules
+++ mod/debian/rules
[...]
I think so, unless I misparsed the diff.
cu andreas
Re: [debian-mentors] config.sub and config.guess | .diff.gz bloat
Geert Stappers [EMAIL PROTECTED] wrote:
On Mon, Nov 10, 2003 at 11:50:09AM +, Magos?nyi ?rp?d wrote:
A levelezõm azt hiszi, hogy Andreas Metzler a következõeket írta:
Two things:
Does -name config.{log,status,cache} actually work for you? It doesn't
do for me:
[]
Never ever use |xargs rm -f.
Thank you. Is it okay now?
--- orig/debian/rules
+++ mod/debian/rules
[still dangerous |xargs rm -f code]
[...]
Where? I only see find -print0 | xargs -0r rm which is safe.
cu andreas
Re: [debian-mentors] config.sub and config.guess | .diff.gz bloat
On Mon, Nov 10, 2003 at 01:27:27PM +, Magos?nyi ?rp?d wrote:
A levelezõm azt hiszi, hogy Geert Stappers a következõeket írta:
On Mon, Nov 10, 2003 at 11:50:09AM +, Magos?nyi ?rp?d wrote:
A levelez?m azt hiszi, hogy Andreas Metzler a következ?eket írta:
| | | - find . -name config.{log,status,cache} |xargs rm -f
| | | + find . \( -name config.log -o -name config.status -o -name
config.cache \) -print0 |xargs -0r rm -f
[quoting]
or [1]
find ... -print0 | xargs -0r rm -f
cu andreas
[1] This is a lot faster, but won't work with every find. It is safe
to use on Debian though because we use GNU findutils.
[still dangerous |xargs rm -f code]
| |
| | Use
| |
| |rm -f config.status and other files
| |
Now what? I thought using |xargs -0r rm -f is safe.
There is still the risk that find finds more then you expect.
A simple
rm -f config.log config.status config.cache
will only remove what has been told to remove.
If you like find and surprises, you are free to ignore this advice.
Geert Stappers
pgp8Hd3Ap3JKP.pgp
Description: PGP signature
Re: [debian-mentors] config.sub and config.guess | .diff.gz bloat
On Mon, Nov 10, 2003 at 01:57:17PM +, Andreas Metzler wrote:
Geert Stappers [EMAIL PROTECTED] wrote:
On Mon, Nov 10, 2003 at 11:50:09AM +, Magos?nyi ?rp?d wrote:
A levelezõm azt hiszi, hogy Andreas Metzler a következõeket írta:
Two things:
Does -name config.{log,status,cache} actually work for you? It doesn't
do for me:
[]
Never ever use |xargs rm -f.
Thank you. Is it okay now?
--- orig/debian/rules
+++ mod/debian/rules
[still dangerous |xargs rm -f code]
[...]
Where? I only see find -print0 | xargs -0r rm which is safe.
Oops, an other one that could be offended: Sorry.
find . -name exact-name-of-file | xargs rm -f
or
find . -name exact-name-of-file -print0 | xargs -0r rm -f
can be reduced to
rm -f exact-name-of-file
My message is: avoid surprises from find.
cu andreas
Geert Stappers
Re: [debian-mentors] Re: [debian-mentors] config.sub and config.guess | .diff.gz bloat
A levelezőm azt hiszi, hogy Geert Stappers a következőeket írta: My message is: avoid surprises from find. Got the message, thank you for the warning. However I doubt that upstream will use names like config.guess for anything other than files which can and should be regenerated in build phase, and expect that there will be even more modules for Zorp as time passes. Each module have its own autoconfiguration, as they in theory can be compiled on their own right. Because of that I would like to stick with find. We are talking about some half a hundred files which should be cleaned. -- GNU GPL: csak tiszta forrásból
Re: config.sub and config.guess | .diff.gz bloat
On Thu, 06 Nov 2003, Zenaan Harkness wrote: Should I email this to the debhelper script maintainer? No. But you could send a wishlist bug to the dh_make (or debmake, whichever one you used) pakcages to update it. I have changed this thing in autotools-dev' README for quite a while. The old cp way was there to satisfy some weird notion people (and even I, I admit :-) ) had that it was somewhat better to put the dang thing in the sources, since that's what upstream should have been doing anyway. Even if the program I'm packaging doesn't use autotools If it needs config.sub or config.guess, then you need them in. Otherwise you obviously don't. I suggest you grep for them in your source tree. (I have a vague understanding that perhaps they're needed for cross-platform autobuilds and have to stay, but haven't got a clear answer yet...)? config.sub is needed everywhere autoconf was used (it is called by the configure script). config.guess is often needed as well, either because you don't want users asking why calling ./configure doesn't work, or because you don't call configure properly in your debian/rules file in the first place (HINT: You are to tell it the build and target platforms using info from the proper env. variables). -- One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie. -- The Silicon Valley Tarot Henrique Holschuh -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: config.sub and config.guess | .diff.gz bloat
On Thu, 06 Nov 2003, Zenaan Harkness wrote: Should I email this to the debhelper script maintainer? No. But you could send a wishlist bug to the dh_make (or debmake, whichever one you used) pakcages to update it. I have changed this thing in autotools-dev' README for quite a while. The old cp way was there to satisfy some weird notion people (and even I, I admit :-) ) had that it was somewhat better to put the dang thing in the sources, since that's what upstream should have been doing anyway. Even if the program I'm packaging doesn't use autotools If it needs config.sub or config.guess, then you need them in. Otherwise you obviously don't. I suggest you grep for them in your source tree. (I have a vague understanding that perhaps they're needed for cross-platform autobuilds and have to stay, but haven't got a clear answer yet...)? config.sub is needed everywhere autoconf was used (it is called by the configure script). config.guess is often needed as well, either because you don't want users asking why calling ./configure doesn't work, or because you don't call configure properly in your debian/rules file in the first place (HINT: You are to tell it the build and target platforms using info from the proper env. variables). -- One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie. -- The Silicon Valley Tarot Henrique Holschuh
Re: config.sub and config.guess | .diff.gz bloat
On Thu, Nov 06, 2003 at 11:53:48AM +1100, Zenaan Harkness wrote: debhelper puts the following into the clean rule in debian/rules: ifneq $(wildcard /usr/share/misc/config.sub) cp -f /usr/share/misc/config.sub config.sub endif ifneq $(wildcard /usr/share/misc/config.guess) cp -f /usr/share/misc/config.guess config.guess endif Three questions: - why are these two files copied in? - are they necessary for the build of the program I am packaging? - they make my .diff.gz file twice their otherwise size; can I delete that entry from my rules file altogether, or otherwise remove them from the output? Three days ago there was http://lists.debian.org/debian-mentors/2003/debian-mentors-200311/msg00030.html with these lines: | Or just copy in updated config.guess and config.sub files manually each | time it becomes necessary; that way you might also remember to tell | upstream that they should update their copies, which is something a good | Debian maintainer should be doing. | | Cheers, | | -- | Colin Watson [EMAIL PROTECTED] tia zen Geert Stappers -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: config.sub and config.guess | .diff.gz bloat
On Thu, Nov 06, 2003 at 03:25:28PM +1100, Zenaan Harkness wrote: On Thu, 2003-11-06 at 13:58, Henrique de Moraes Holschuh wrote: [...] Anyway, whatever you do, you are to keep these files up-to-date. Even if the program I'm packaging doesn't use autotools [...] If your package does not use autoconf (or automake) there is no reason to include these files. But don't get me wrong, I am not talking about the package requiring that autoconf is installed, but that it includes a ./configure which was generated by autoconf from configure.(in|ac). I.e. usually you have to keep up to date but you don't need to *add* them if they are not present in the original sourcetree. cu andreas -- See, I told you they'd listen to Reason, [SPOILER] Svfurlr fnlf, fuhggvat qbja gur juveyvat tha. Neal Stephenson in Snow Crash -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: config.sub and config.guess | .diff.gz bloat
On Thu, Nov 06, 2003 at 07:14:13PM +1100, Zenaan Harkness wrote: (Yes, I hadn't read that thread - thanks.) However, I'm still unsure whether these (I assume _yes_ at this point) confusion came from the fact that the upstream source does not have these files at all. In that case dh_make is just being stupid. You can delete those lines from debian/rules. Cheers, -- Colin Watson [EMAIL PROTECTED] -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: config.sub and config.guess | .diff.gz bloat
On Thu, Nov 06, 2003 at 11:53:48AM +1100, Zenaan Harkness wrote: debhelper puts the following into the clean rule in debian/rules: dh_make != debhelper. ifneq $(wildcard /usr/share/misc/config.sub) cp -f /usr/share/misc/config.sub config.sub endif ifneq $(wildcard /usr/share/misc/config.guess) cp -f /usr/share/misc/config.guess config.guess endif Three questions: - why are these two files copied in? No good reason. - are they necessary for the build of the program I am packaging? Not unless they were already present. - they make my .diff.gz file twice their otherwise size; can I delete that entry from my rules file altogether, or otherwise remove them from the output? Yes. -- - mdz -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: config.sub and config.guess | .diff.gz bloat
Zenaan Harkness [EMAIL PROTECTED] writes: debhelper puts the following into the clean rule in debian/rules: dh_make - why are these two files copied in? There is *no* good reason for it. That should help if there are newer version of the files available. If that happens its IMO better to kick Upstream to include them in his package and not to make the debian diff big with them. (To get this rules too work you would need an extra build-dependency or they are useless). -- bye Joerg maxx Aqua mach mal man brain Aquariophile maxx: schon probiert das gibts ned -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: config.sub and config.guess | .diff.gz bloat
Zenaan Harkness wrote: debhelper puts the following into the clean rule in debian/rules: No it didn't. Should I email this to the debhelper script maintainer? Only if you want me to bounce it to the maintainer of the package that actually put those lines there. -- see shy jo signature.asc Description: Digital signature
Re: [debian-mentors] config.sub and config.guess | .diff.gz bloat
A levelezm azt hiszi, hogy Zenaan Harkness a kvetkezeket rta:
Three questions:
- why are these two files copied in?
Because they are needed for autoconf et al, and in some cases
the upstream version of them is not suitable to build the package on
your system. I had stumbled upon this right now with Zorp.
- are they necessary for the build of the program I am packaging?
They are, but you don't have to copy them actually, as automake -a will
create a symling for you.
- they make my .diff.gz file twice their otherwise size; can I delete
that entry from my rules file altogether, or otherwise remove them from
the output?
I decided to delete all files which can be generated by autoconf
et al in clean: Makefiles, etc. As clean runs before generating the
diff, diff will complain about them missing, but will happily forget
about them. In the build-stamp rule I am reconfiguring them all.
It is the relevant part of the diff to my debian/rules
Note how many files you can get rid of.
(the 'grep -v ++pristine' is because I use gnu arch internally)
-
@@ -18,6 +18,8 @@
build-stamp:
dh_testdir
+ automake -a
+ autoreconf
./configure \
--prefix=/usr \
--mandir=\$${prefix}/share/man \
@@ -54,12 +56,21 @@
clean: debfiles-stamp
dh_testdir
dh_testroot
+ find . -name config.{log,status,cache} |xargs rm -f
rm -f build-stamp
rm -f modules/config-stamp
+ rm -d debian/zorp-modules.files
rm -f debfiles-stamp
# Add here commands to clean up after the build process.
-$(MAKE) distclean
+ -find -name ltmain.sh -o -name config.h.in -o -name stamp-h.in \
+ -o -name config.cache -o -name config.log -o -name
config.status\
+ -o -name stamp-h -o -name config.sub -o -name config.guess \
+ -o -name Makefile.in -o -name aclocal.m4 -o -name configure|grep
-v ++pristine |xargs rm
+ -find -name autom4te.cache |grep -v ++pristine |xargs rm -rf
+ -find -type l |grep -v ++pristine |xargs rm
+ -rm -f modules/zorp-module-http-2.0.0/tests/Makefile
--
GNU GPL: csak tiszta forrsbl
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: [debian-mentors] config.sub and config.guess | .diff.gz bloat
On Thu, Nov 06, 2003 at 07:43:46PM +, Magosányi Árpád wrote:
[...]
+ find . -name config.{log,status,cache} |xargs rm -f
[...]
Two things:
Does -name config.{log,status,cache} actually work for you? It doesn't
do for me:
--
[EMAIL PROTECTED]:/tmp/test touch config.log
[EMAIL PROTECTED]:/tmp/test find . -name 'config.{log,status,cache}'
[EMAIL PROTECTED]:/tmp/test find . -name config.{log,status,cache}
find: paths must precede expression
Usage: find [path...] [expression]
--
Never ever use |xargs rm -f.
--
[EMAIL PROTECTED]:/tmp/test mkdir -p 'evil /etc/passwd /'
[EMAIL PROTECTED]:/tmp/test touch 'evil /etc/passwd /config.sub'
[EMAIL PROTECTED]:/tmp/test find . -name config.sub | xargs rm -v
rm: cannot remove `./evil': No such file or directory
removing `/etc/passwd'
rm: cannot unlink `/etc/passwd': Permission denied
rm: cannot remove `/config.sub': No such file or directory
--
If you combine find with anything that modifies the results (mv, rm,
cp, ...) _always_ use either
find ... -exec rm '{}' \;
or [1]
find ... -print0 | xargs -0r rm -f
cu andreas
[1] This is a lot faster, but won't work with every find. It is safe
to use on Debian though because we use GNU findutils.
--
See, I told you they'd listen to Reason, [SPOILER] Svfurlr fnlf,
fuhggvat qbja gur juveyvat tha.
Neal Stephenson in Snow Crash
pgp0.pgp
Description: PGP signature
Re: config.sub and config.guess | .diff.gz bloat
On Thu, Nov 06, 2003 at 02:42:59PM -0500, Joey Hess wrote: Zenaan Harkness wrote: Should I email this to the debhelper script maintainer? Only if you want me to bounce it to the maintainer of the package that actually put those lines there. Be careful - he may think that's a valid way to get his problems solved. g - Matt -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: config.sub and config.guess | .diff.gz bloat
On Fri, 2003-11-07 at 09:41, Matthew Palmer wrote: On Thu, Nov 06, 2003 at 02:42:59PM -0500, Joey Hess wrote: Zenaan Harkness wrote: Should I email this to the debhelper script maintainer? Only if you want me to bounce it to the maintainer of the package that actually put those lines there. Be careful - he may think that's a valid way to get his problems solved. g Damn ... I thought I telepath'ed you not to let that out ... now I'll have to find some other devious n00b upstream diversion hack... -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: config.sub and config.guess | .diff.gz bloat
On Fri, Nov 07, 2003 at 11:37:25AM +1100, Zenaan Harkness wrote: On Fri, 2003-11-07 at 09:41, Matthew Palmer wrote: On Thu, Nov 06, 2003 at 02:42:59PM -0500, Joey Hess wrote: Zenaan Harkness wrote: Should I email this to the debhelper script maintainer? Only if you want me to bounce it to the maintainer of the package that actually put those lines there. Be careful - he may think that's a valid way to get his problems solved. g Damn ... I thought I telepath'ed you not to let that out ... now I'll Sorry, I'm not running stock Debian kernels, and I'm not running the /dev/uri/geller patch. My cutlery kept getting bent when I had it compiled, so I got rid of it. - Matt -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: config.sub and config.guess | .diff.gz bloat
On Thu, Nov 06, 2003 at 11:53:48AM +1100, Zenaan Harkness wrote: debhelper puts the following into the clean rule in debian/rules: ifneq $(wildcard /usr/share/misc/config.sub) cp -f /usr/share/misc/config.sub config.sub endif ifneq $(wildcard /usr/share/misc/config.guess) cp -f /usr/share/misc/config.guess config.guess endif Three questions: - why are these two files copied in? - are they necessary for the build of the program I am packaging? - they make my .diff.gz file twice their otherwise size; can I delete that entry from my rules file altogether, or otherwise remove them from the output? Three days ago there was http://lists.debian.org/debian-mentors/2003/debian-mentors-200311/msg00030.html with these lines: | Or just copy in updated config.guess and config.sub files manually each | time it becomes necessary; that way you might also remember to tell | upstream that they should update their copies, which is something a good | Debian maintainer should be doing. | | Cheers, | | -- | Colin Watson [EMAIL PROTECTED] tia zen Geert Stappers
Re: config.sub and config.guess | .diff.gz bloat
On Thu, Nov 06, 2003 at 03:25:28PM +1100, Zenaan Harkness wrote: On Thu, 2003-11-06 at 13:58, Henrique de Moraes Holschuh wrote: [...] Anyway, whatever you do, you are to keep these files up-to-date. Even if the program I'm packaging doesn't use autotools [...] If your package does not use autoconf (or automake) there is no reason to include these files. But don't get me wrong, I am not talking about the package requiring that autoconf is installed, but that it includes a ./configure which was generated by autoconf from configure.(in|ac). I.e. usually you have to keep up to date but you don't need to *add* them if they are not present in the original sourcetree. cu andreas -- See, I told you they'd listen to Reason, [SPOILER] Svfurlr fnlf, fuhggvat qbja gur juveyvat tha. Neal Stephenson in Snow Crash
Re: config.sub and config.guess | .diff.gz bloat
On Thu, 2003-11-06 at 18:36, Geert Stappers wrote: On Thu, Nov 06, 2003 at 11:53:48AM +1100, Zenaan Harkness wrote: - why are these two files copied in? Three days ago there was http://lists.debian.org/debian-mentors/2003/debian-mentors-200311/msg00030.html with these lines: | Or just copy in ... from ... To make it (hopefully very) clear what I don't understand - is it necessary at all to copy in these files? Since my diff is simply a whole bunch of + lines for each of these files. ta zen
Re: config.sub and config.guess | .diff.gz bloat
On Thu, Nov 06, 2003 at 07:14:13PM +1100, Zenaan Harkness wrote: (Yes, I hadn't read that thread - thanks.) However, I'm still unsure whether these (I assume _yes_ at this point) confusion came from the fact that the upstream source does not have these files at all. In that case dh_make is just being stupid. You can delete those lines from debian/rules. Cheers, -- Colin Watson [EMAIL PROTECTED]
Re: config.sub and config.guess | .diff.gz bloat
Zenaan Harkness [EMAIL PROTECTED] writes: debhelper puts the following into the clean rule in debian/rules: dh_make - why are these two files copied in? There is *no* good reason for it. That should help if there are newer version of the files available. If that happens its IMO better to kick Upstream to include them in his package and not to make the debian diff big with them. (To get this rules too work you would need an extra build-dependency or they are useless). -- bye Joerg maxx Aqua mach mal man brain Aquariophile maxx: schon probiert das gibts ned
Re: config.sub and config.guess | .diff.gz bloat
On Fri, 2003-11-07 at 09:41, Matthew Palmer wrote: On Thu, Nov 06, 2003 at 02:42:59PM -0500, Joey Hess wrote: Zenaan Harkness wrote: Should I email this to the debhelper script maintainer? Only if you want me to bounce it to the maintainer of the package that actually put those lines there. Be careful - he may think that's a valid way to get his problems solved. g Damn ... I thought I telepath'ed you not to let that out ... now I'll have to find some other devious n00b upstream diversion hack...
Re: config.sub and config.guess | .diff.gz bloat
On Fri, Nov 07, 2003 at 11:37:25AM +1100, Zenaan Harkness wrote: On Fri, 2003-11-07 at 09:41, Matthew Palmer wrote: On Thu, Nov 06, 2003 at 02:42:59PM -0500, Joey Hess wrote: Zenaan Harkness wrote: Should I email this to the debhelper script maintainer? Only if you want me to bounce it to the maintainer of the package that actually put those lines there. Be careful - he may think that's a valid way to get his problems solved. g Damn ... I thought I telepath'ed you not to let that out ... now I'll Sorry, I'm not running stock Debian kernels, and I'm not running the /dev/uri/geller patch. My cutlery kept getting bent when I had it compiled, so I got rid of it. - Matt
config.sub and config.guess | .diff.gz bloat
debhelper puts the following into the clean rule in debian/rules: ifneq $(wildcard /usr/share/misc/config.sub) cp -f /usr/share/misc/config.sub config.sub endif ifneq $(wildcard /usr/share/misc/config.guess) cp -f /usr/share/misc/config.guess config.guess endif Three questions: - why are these two files copied in? - are they necessary for the build of the program I am packaging? - they make my .diff.gz file twice their otherwise size; can I delete that entry from my rules file altogether, or otherwise remove them from the output? tia zen -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: config.sub and config.guess | .diff.gz bloat
On Nov 5, 2003, at 4:53 PM, Zenaan Harkness wrote: debhelper puts the following into the clean rule in debian/rules: ifneq $(wildcard /usr/share/misc/config.sub) cp -f /usr/share/misc/config.sub config.sub endif ifneq $(wildcard /usr/share/misc/config.guess) cp -f /usr/share/misc/config.guess config.guess endif Three questions: - why are these two files copied in? - are they necessary for the build of the program I am packaging? - they make my .diff.gz file twice their otherwise size; can I delete that entry from my rules file altogether, or otherwise remove them from the output? Zenaan, My understanding is that these lines ensure that autoconf-based packages can be easily ported to architectures that are newer than the software (specifically, newer than the version of autoconf used by the upstream maintainer when releasing software). If I recall correctly, this was a particular problem for hppa and ia64, for which many packages failed to build with old versions of these files (see, for example bugs.debian.org/103340, which is just the first thing I found with google). I suppose (but am not an authority) that an arch: i386 package could safely do away with these lines. Any package that does not use run configure would not need these lines either. Further, these lines would need to be corrected if config.sub and config.guess existed in a different place in upstream source. -neil -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: config.sub and config.guess | .diff.gz bloat
On Thu, 06 Nov 2003, Zenaan Harkness wrote: debhelper puts the following into the clean rule in debian/rules: ifneq $(wildcard /usr/share/misc/config.sub) cp -f /usr/share/misc/config.sub config.sub endif ifneq $(wildcard /usr/share/misc/config.guess) cp -f /usr/share/misc/config.guess config.guess endif It would be cleaner (for the diff) to: 1. build-depend on autotools-dev 2. use ln -sf instead of cp -f. Of course, for that to work, you HAVE to rm -f both files in the clean target, and do the ln -sf before you call configure. Anyway, whatever you do, you are to keep these files up-to-date. See the autotools-dev readme file. -- One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie. -- The Silicon Valley Tarot Henrique Holschuh -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: config.sub and config.guess | .diff.gz bloat
On Thu, 2003-11-06 at 12:14, Neil Spring wrote: On Nov 5, 2003, at 4:53 PM, Zenaan Harkness wrote: debhelper puts the following into the clean rule in debian/rules: ifneq $(wildcard /usr/share/misc/config.sub) cp -f /usr/share/misc/config.sub config.sub endif ifneq $(wildcard /usr/share/misc/config.guess) cp -f /usr/share/misc/config.guess config.guess endif Three questions: - why are these two files copied in? - are they necessary for the build of the program I am packaging? - they make my .diff.gz file twice their otherwise size; can I delete that entry from my rules file altogether, or otherwise remove them from the output? Zenaan, My understanding is that these lines ensure that autoconf-based packages can be easily ported to architectures that are newer than the software (specifically, newer than the version of autoconf used by the upstream maintainer when releasing software). If I recall correctly, this was a particular problem for hppa and ia64, for which many packages failed to build with old versions of these files (see, for example bugs.debian.org/103340, which is just the first thing I found with google). I suppose (but am not an authority) that an arch: i386 package could safely do away with these lines. Any package that does not use run configure would not need these lines either. Further, these lines would need to be corrected if config.sub and config.guess existed in a different place in upstream source. Thanks Neil. Do you know why they aren't just pointed to by the build daemons, rather than copied in for each package (it just seems like unnecessary bloat to me)? ta zen -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: config.sub and config.guess | .diff.gz bloat
On Thu, 2003-11-06 at 13:58, Henrique de Moraes Holschuh wrote: On Thu, 06 Nov 2003, Zenaan Harkness wrote: debhelper puts the following into the clean rule in debian/rules: ifneq $(wildcard /usr/share/misc/config.sub) cp -f /usr/share/misc/config.sub config.sub endif ifneq $(wildcard /usr/share/misc/config.guess) cp -f /usr/share/misc/config.guess config.guess endif It would be cleaner (for the diff) to: 1. build-depend on autotools-dev 2. use ln -sf instead of cp -f. Of course, for that to work, you HAVE to rm -f both files in the clean target, and do the ln -sf before you call configure. Should I email this to the debhelper script maintainer? Anyway, whatever you do, you are to keep these files up-to-date. Even if the program I'm packaging doesn't use autotools (I have a vague understanding that perhaps they're needed for cross-platform autobuilds and have to stay, but haven't got a clear answer yet...)? See the autotools-dev readme file. thanks zenaan -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
config.sub and config.guess | .diff.gz bloat
debhelper puts the following into the clean rule in debian/rules: ifneq $(wildcard /usr/share/misc/config.sub) cp -f /usr/share/misc/config.sub config.sub endif ifneq $(wildcard /usr/share/misc/config.guess) cp -f /usr/share/misc/config.guess config.guess endif Three questions: - why are these two files copied in? - are they necessary for the build of the program I am packaging? - they make my .diff.gz file twice their otherwise size; can I delete that entry from my rules file altogether, or otherwise remove them from the output? tia zen
Re: config.sub and config.guess | .diff.gz bloat
On Nov 5, 2003, at 4:53 PM, Zenaan Harkness wrote: debhelper puts the following into the clean rule in debian/rules: ifneq $(wildcard /usr/share/misc/config.sub) cp -f /usr/share/misc/config.sub config.sub endif ifneq $(wildcard /usr/share/misc/config.guess) cp -f /usr/share/misc/config.guess config.guess endif Three questions: - why are these two files copied in? - are they necessary for the build of the program I am packaging? - they make my .diff.gz file twice their otherwise size; can I delete that entry from my rules file altogether, or otherwise remove them from the output? Zenaan, My understanding is that these lines ensure that autoconf-based packages can be easily ported to architectures that are newer than the software (specifically, newer than the version of autoconf used by the upstream maintainer when releasing software). If I recall correctly, this was a particular problem for hppa and ia64, for which many packages failed to build with old versions of these files (see, for example bugs.debian.org/103340, which is just the first thing I found with google). I suppose (but am not an authority) that an arch: i386 package could safely do away with these lines. Any package that does not use run configure would not need these lines either. Further, these lines would need to be corrected if config.sub and config.guess existed in a different place in upstream source. -neil
Re: config.sub and config.guess | .diff.gz bloat
On Thu, 06 Nov 2003, Zenaan Harkness wrote: debhelper puts the following into the clean rule in debian/rules: ifneq $(wildcard /usr/share/misc/config.sub) cp -f /usr/share/misc/config.sub config.sub endif ifneq $(wildcard /usr/share/misc/config.guess) cp -f /usr/share/misc/config.guess config.guess endif It would be cleaner (for the diff) to: 1. build-depend on autotools-dev 2. use ln -sf instead of cp -f. Of course, for that to work, you HAVE to rm -f both files in the clean target, and do the ln -sf before you call configure. Anyway, whatever you do, you are to keep these files up-to-date. See the autotools-dev readme file. -- One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie. -- The Silicon Valley Tarot Henrique Holschuh
Re: config.sub and config.guess | .diff.gz bloat
On Thu, 2003-11-06 at 12:14, Neil Spring wrote: On Nov 5, 2003, at 4:53 PM, Zenaan Harkness wrote: debhelper puts the following into the clean rule in debian/rules: ifneq $(wildcard /usr/share/misc/config.sub) cp -f /usr/share/misc/config.sub config.sub endif ifneq $(wildcard /usr/share/misc/config.guess) cp -f /usr/share/misc/config.guess config.guess endif Three questions: - why are these two files copied in? - are they necessary for the build of the program I am packaging? - they make my .diff.gz file twice their otherwise size; can I delete that entry from my rules file altogether, or otherwise remove them from the output? Zenaan, My understanding is that these lines ensure that autoconf-based packages can be easily ported to architectures that are newer than the software (specifically, newer than the version of autoconf used by the upstream maintainer when releasing software). If I recall correctly, this was a particular problem for hppa and ia64, for which many packages failed to build with old versions of these files (see, for example bugs.debian.org/103340, which is just the first thing I found with google). I suppose (but am not an authority) that an arch: i386 package could safely do away with these lines. Any package that does not use run configure would not need these lines either. Further, these lines would need to be corrected if config.sub and config.guess existed in a different place in upstream source. Thanks Neil. Do you know why they aren't just pointed to by the build daemons, rather than copied in for each package (it just seems like unnecessary bloat to me)? ta zen
Re: config.sub and config.guess | .diff.gz bloat
On Thu, 2003-11-06 at 13:58, Henrique de Moraes Holschuh wrote: On Thu, 06 Nov 2003, Zenaan Harkness wrote: debhelper puts the following into the clean rule in debian/rules: ifneq $(wildcard /usr/share/misc/config.sub) cp -f /usr/share/misc/config.sub config.sub endif ifneq $(wildcard /usr/share/misc/config.guess) cp -f /usr/share/misc/config.guess config.guess endif It would be cleaner (for the diff) to: 1. build-depend on autotools-dev 2. use ln -sf instead of cp -f. Of course, for that to work, you HAVE to rm -f both files in the clean target, and do the ln -sf before you call configure. Should I email this to the debhelper script maintainer? Anyway, whatever you do, you are to keep these files up-to-date. Even if the program I'm packaging doesn't use autotools (I have a vague understanding that perhaps they're needed for cross-platform autobuilds and have to stay, but haven't got a clear answer yet...)? See the autotools-dev readme file. thanks zenaan
